Works great here
On Tue, Apr 16, 2019 at 02:46:39PM +0200, Daniel Lezcano wrote:
> From: Neil Armstrong
>
> The OX820 compatible is wrong is the driver, fix it.
>
> Fixes: 2ea3401e2a84 ("clocksource/drivers/oxnas: Add OX820 compatible")
> Reported-by: Daniel
Hi Pavel,
On Fri, Sep 21, 2018 at 12:04:49AM +0200, Pavel Machek wrote:
> Hi!
>
> > > > +#ifdef CONFIG_ATA_LEDS
> > > > + /* register LED triggers for all ports */
> > > > + for (i = 0; i < host->n_ports; i++) {
> > > > + if (unlikely(!host->ports[i]->ledtrig))
> > > > +
Hi!
On Thu, Sep 20, 2018 at 09:23:54AM +0200, Pavel Machek wrote:
> Hi!
>
> > +#ifdef CONFIG_ATA_LEDS
> > + /* register LED triggers for all ports */
> > + for (i = 0; i < host->n_ports; i++) {
> > + if (unlikely(!host->ports[i]->ledtrig))
> > + continue;
> > +
> >
n Kconfig instead?
>
> Please let's not go down that route and make such facilities less
> useful due to decreased coverage.
Being the one to blame for submitting the patch adding most of the
problem's footprint: Arnd's change looks good to me and I believe it
should be merged.
This is the type of feedback I was hoping for when submitting all the
long-forgotten and rotting patches from OpenWrt's mac80211 driver
patches! Thanks to Arnd for your efforts!
Consider this as
Acked-by: Daniel Golle
for Arnd's original patch (and for NOT adding 'depends on !KASAN')
Cheers
Daniel
>
> Thanks.
Hi Neil,
On Tue, Oct 18, 2016 at 01:24:22PM +0200, Neil Armstrong wrote:
> On 10/18/2016 01:08 PM, Daniel Golle wrote:
> > Hi Neil,
> >
> > great to see progress towards supporting OX820!
> > The NAND driver I hacked up for Kernel 4.1 and 4.4 in OpenWrt/LEDE
Hi Neil,
great to see progress towards supporting OX820!
The NAND driver I hacked up for Kernel 4.1 and 4.4 in OpenWrt/LEDE
looks very similar, see
https://git.lede-project.org/?p=lede/dangole/staging.git;a=blob;f=target/linux/oxnas/files/drivers/mtd/nand/oxnas_nand.c;h=f5a142950e32227fee304de731
6 matches
Mail list logo
