On Wed, Oct 23, 2024 at 6:32 PM Mathieu Poirier
wrote:
>
> Hello Daniel,
>
> On Fri, Oct 18, 2024 at 02:09:29PM +0300, Daniel Baluta wrote:
> > Currently we generate notifyids in the linux kernel and override
> > those found in rsc_table.
> >
> > This doesn
is we also define an invalid notifid as 0xU. This
should be placed as notifids if users want Linux to generate the ids.
Signed-off-by: Alexandru Lastur
Signed-off-by: Daniel Baluta
---
drivers/remoteproc/remoteproc_core.c | 14 --
include/linux/remoteproc.h | 1 +
2
eate them as non-blocking.
>
> Note that power off and restart are totally different operations and are
> not complementary.
>
> We introduce a new flag in the imx remoteproc per device data which tells
> us when a device needs this special setup. For now, only imx7ulp needs it.
>
> Signed-off-by: Peng Fan
Reviewed-by: Daniel Baluta
x_block mode to be set (true/false) depending on usecase.
>
> No functional changes.
>
> Signed-off-by: Peng Fan
Reviewed-by: Daniel Baluta
Hello Mathieu,
I've talked to Peng and if my understanding is correct I think the patch is OK.
Maybe we can split the patch in two:
* first, adding the power off callback with explanations.
* second, adding the restart callback with explanations.
And also add a more detailed explanation.
Power o
for completion.
>
> patch 1 is to support non-blocking tx mailbox channel
> patch 2 is to switch to non-blocking tx for system poweroff or restart.
>
> Based on patchset:
> https://lore.kernel.org/all/20240719-imx_rproc-v2-0-10d0268c7...@nxp.com/
>
> Signed-off-by: Peng Fan
Series looks good to me.
Reviewed-by: Daniel Baluta
> Signed-off-by: Peng Fan
Neat and clean.
Reviewed-by: Daniel Baluta
Thanks Peng!
On Fri, Jan 5, 2024 at 6:02 PM Ulf Hansson wrote:
>
> Updates in v2:
> - Ccing Daniel Baluta and Iuliana Prodan the NXP remoteproc patches to
> requests help with testing.
> - Fixed NULL pointer bug in patch1, pointed out by Nikunj.
> - Added so
On Tue, Sep 12, 2023 at 12:54 PM Iuliana Prodan wrote:
>
> On 9/12/2023 11:26 AM, Krzysztof Kozlowski wrote:
> > On 12/09/2023 10:13, Iuliana Prodan wrote:
> >> On 9/12/2023 10:07 AM, Krzysztof Kozlowski wrote:
> >>> On 12/09/2023 00:44, Iuliana Prodan (OSS) wrote:
> From: Iuliana Prodan
> >
From: Daniel Baluta
A DAI link has 3 components:
* CPU
* platform
* codec(s)
A component is specified via:
* name
* of_node
* dai_name
In order to avoid confusion when building a sound card we disallow
matching by both name and of_node (1
On Fri, Mar 12, 2021 at 4:24 PM Mark Brown wrote:
>
> On Fri, Mar 12, 2021 at 02:37:30PM +0200, Daniel Baluta wrote:
> > On Fri, Mar 12, 2021 at 1:59 PM Mark Brown wrote:
>
> > > No, just the opposite! If there's an explict name configured why do you
> > >
On Fri, Mar 12, 2021 at 1:59 PM Mark Brown wrote:
>
> On Fri, Mar 12, 2021 at 12:59:29PM +0200, Daniel Baluta wrote:
> > On Fri, Mar 12, 2021 at 12:50 PM Mark Brown wrote:
>
> > > If an explicit name has been provided why would we override it with an
> > > autog
On Fri, Mar 12, 2021 at 12:50 PM Mark Brown wrote:
>
> On Fri, Mar 12, 2021 at 10:32:54AM +0200, Daniel Baluta wrote:
> > On Tue, Mar 9, 2021 at 5:38 PM Mark Brown wrote:
>
> > > > + if (!dai_link->platforms->of_node)
> > > > +
On Tue, Mar 9, 2021 at 5:38 PM Mark Brown wrote:
>
> On Tue, Mar 09, 2021 at 10:23:28AM +0200, Daniel Baluta wrote:
> > From: Daniel Baluta
> >
> > Platform may be specified by either name or OF node but not
> > both.
> >
> > For OF node platforms (e
From: Daniel Baluta
Platform may be specified by either name or OF node but not
both.
For OF node platforms (e.g i.MX) we end up with both platform name
and of_node set and sound card registration will fail with the error:
asoc-simple-card sof-sound-wm8960: ASoC: Neither/both
platform name
t;
> wm8962 3-001a: Unsupported BCLK ratio 9
>
> Fix this by relaxing bitclk divider searching, so that when
> no exact value can be derived from sysclk pick the closest
> value greater than expected bitclk.
>
> Signed-off-by: Shengjiu Wang
Reviewed-by: Daniel Baluta
On Tue, Nov 10, 2020 at 4:15 PM wrote:
>
> From: Franck LENORMAND
Looks good to me. Thanks Franck!
Reviewed-by: Daniel Baluta
_sync which increments device
usage count and will keep the device active. Specifically, mailbox
clock will be always ON when a mailbox channel is requested.
Signed-off-by: Daniel Baluta
---
drivers/firmware/imx/imx-dsp.c | 25 +
include/linux/firmware/imx/dsp.h
We want to request / free channels on demand later in order
to save power.
For this for each channel we save the name and use it to
reference the channel later.
Signed-off-by: Daniel Baluta
---
drivers/firmware/imx/imx-dsp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
uce a way to request/free IMX DSP channels
on demand to save power when the channels are not used.
First two patches are doing code refactoring preparing the path
for 3rd patch which exports functions for on demand channel request/free
Daniel Baluta (3):
firmware: imx: Introduce imx_dsp_setup_cha
Create a separate function that sets up DSP mailbox channels
so that imx_dsp_probe function will be easier to read.
Signed-off-by: Daniel Baluta
---
drivers/firmware/imx/imx-dsp.c | 41 +-
1 file changed, 26 insertions(+), 15 deletions(-)
diff --git a/drivers
On Tue, Oct 13, 2020 at 1:49 PM Shengjiu Wang wrote:
>
> On Tue, Oct 13, 2020 at 6:42 PM Daniel Baluta wrote:
> >
> > On Tue, Oct 13, 2020 at 12:29 PM Nicolin Chen
> > wrote:
> > >
> > > Hi Shengjiu,
> > >
> > > On Mon, Oct 12, 2020 a
t; > Signed-off-by: Shengjiu Wang
> > Signed-off-by: Viorel Suman
>
> Probably should put your own Signed-off at the bottom?
Hi Shengjiu,
Also please keep the original author of the patch. You can change that
using git commit --amend --author="Viorel Suman ".
With that,
Reviewed-by: Daniel Baluta
From: Daniel Baluta
SOF boots the DSP at probe and keeps it up all the time.
With this change, after booting if no one is using the DSP
the SOF core will turn off the DSP to save power.
Reviewed-by: Kai Vehmanen
Reviewed-by: Paul Olaru
Reviewed-by: Pierre-Louis Bossart
Signed-off-by: Daniel
From: Daniel Baluta
Use SOF defined callbacks (snd_sof_prepare/snd_sof_complete)
in order to update internal SOF system suspend target.
Reviewed-by: Kai Vehmanen
Reviewed-by: Paul Olaru
Reviewed-by: Pierre-Louis Bossart
Signed-off-by: Daniel Baluta
---
sound/soc/sof/sof-of-dev.c | 2 ++
1
From: Daniel Baluta
This enables runtime PM for SOF device. Next patchseries will
provide PM suspend/resume handlers for i.MX8 specific devices.
Daniel Baluta (2):
ASoC: SOF: Activate runtime PM with SOF OF device
ASoC: SOF: Add .prepare/.complete callbacks
sound/soc/sof/sof-of-dev.c | 6
From: Daniel Baluta
Create a separate function that sets up DSP mailbox channels
so that imx_dsp_probe function will be easier to read.
Signed-off-by: Daniel Baluta
---
drivers/firmware/imx/imx-dsp.c | 41 +-
1 file changed, 26 insertions(+), 15 deletions
From: Daniel Baluta
In order to save power, we only need to request a channel
when the communication with the DSP active.
For this we export the following functions:
- imx_dsp_request_channel, gets a channel with a given index
- imx_dsp_free_channel, frees a channel with a given
From: Daniel Baluta
We want to request / free channels on demand later in order
to save power.
For this for each channel we save the name and use it to
reference the channel later.
Signed-off-by: Daniel Baluta
---
drivers/firmware/imx/imx-dsp.c | 6 +++---
1 file changed, 3 insertions(+), 3
From: Daniel Baluta
Requesting an mailbox channel will call mailbox's startup
function.
startup function calls pm_runtime_get_sync which increments device usage
count and will keep the device active. Specifically, mailbox clock will
be always ON when a mailbox channel is requested.
For
On Tue, Jul 21, 2020 at 8:03 PM Srinivas Kandagatla
wrote:
>
> Make use of new set_codec_params callback to allow decoder switching
> during gapless playback.
>
> Signed-off-by: Srinivas Kandagatla
> ---
> sound/soc/qcom/qdsp6/q6asm-dai.c | 33
> 1 file changed,
From: Daniel Baluta
This must match DAI name from topology. Also, esai-port is too generic
as they are 2 ESAIs on i.MX8/i.MX8X boards.
SOF integration only uses ESAI0 for now.
Signed-off-by: Daniel Baluta
Reviewed-by: Pierre-Louis Bossart
Reviewed-by: Kai Vehmanen
Reviewed-by: Ranjani
From: Daniel Baluta
This patchseries contains a couple of SOF IMX fixes
found during our first IMX SOF release.
Daniel Baluta (7):
ASoC: SOF: define INFO_ flags in dsp_ops for imx8
ASoC: SOF: imx: Use ARRAY_SIZE instead of hardcoded value
ASoC: SOF: imx8: Fix ESAI DAI driver name for
From: Daniel Baluta
With this change we no longer need to update num_drv when adding
new DAI driver.
Signed-off-by: Daniel Baluta
Reviewed-by: Pierre-Louis Bossart
Reviewed-by: Kai Vehmanen
Reviewed-by: Ranjani Sridharan
Reviewed-by: Guennadi Liakhovetski
---
sound/soc/sof/imx/imx8.c | 4
From: Daniel Baluta
Fixup BE DAI links rate/channels parameters to match any values
from topology.
Signed-off-by: Daniel Baluta
Reviewed-by: Pierre-Louis Bossart
Reviewed-by: Ranjani Sridharan
---
sound/soc/sof/pcm.c | 8
1 file changed, 8 insertions(+)
diff --git a/sound/soc/sof
From: Daniel Baluta
In the past, the INFO_ flags such as PAUSE/NO_PERIOD_WAKEUP were
defined in the SOF PCM core, but that was changed since
commit 27e322fabd50 ("ASoC: SOF: define INFO_ flags in dsp_ops")
Now these flags must be set in DSP ops.
Signed-off-by: Daniel Baluta
R
From: Daniel Baluta
With SOF we support 1 ESAI interface and 1 SAI interface.
This patch adds SAI1 interface support existing on i.MX8/i.MX8X
boards.
Signed-off-by: Daniel Baluta
Reviewed-by: Pierre-Louis Bossart
Reviewed-by: Kai Vehmanen
Reviewed-by: Ranjani Sridharan
Reviewed-by: Guennadi
From: Daniel Baluta
This must match DAI name from topology. Also, sai-port
is too generic. Physical DAI port on i.MX8MP is labeled SAI3.
Signed-off-by: Daniel Baluta
Reviewed-by: Pierre-Louis Bossart
Reviewed-by: Kai Vehmanen
Reviewed-by: Ranjani Sridharan
Reviewed-by: Guennadi Liakhovetski
From: Daniel Baluta
These parameters are read from topology file and sent to DSP.
Signed-off-by: Daniel Baluta
Reviewed-by: Pierre-Louis Bossart
Reviewed-by: Ranjani Sridharan
---
sound/soc/sof/topology.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/sof/topology.c b/sound
On 7/17/20 2:44 AM, Anson Huang wrote:
Hi, Daniel
Subject: Re: [PATCH 1/2] pinctrl: imx: Support building SCU pinctrl driver as
module
On 7/16/20 6:21 PM, Anson Huang wrote:
Hi, Daniel
Subject: Re: [PATCH 1/2] pinctrl: imx: Support building SCU pinctrl
driver as module
Hi Anson,
Few com
On 7/16/20 6:21 PM, Anson Huang wrote:
Hi, Daniel
Subject: Re: [PATCH 1/2] pinctrl: imx: Support building SCU pinctrl driver as
module
Hi Anson,
Few comments inline:
On 7/16/20 6:06 PM, Anson Huang wrote:
To support building i.MX SCU pinctrl driver as module, below things need to
be chang
Hi Anson,
Few comments inline:
On 7/16/20 6:06 PM, Anson Huang wrote:
To support building i.MX SCU pinctrl driver as module, below things need to be
changed:
- Export SCU related functions and use "IS_ENABLED" instead of
"ifdef" to support SCU pinctrl driver user and itself to be
From: Daniel Baluta
We want to request / free channels on demand later in order
to save power.
For this for each channel we save the name and use it to
reference the channel later.
Signed-off-by: Daniel Baluta
---
drivers/firmware/imx/imx-dsp.c | 6 +++---
1 file changed, 3 insertions(+), 3
From: Daniel Baluta
Requesting an mailbox channel will call mailbox's startup
function.
startup function calls pm_runtime_get_sync which increments device usage
count and will keep the device active. Specifically, mailbox clock will
be always ON when a mailbox channel is requested.
For
From: Daniel Baluta
In order to save power, we only need to request a channel
when the communication with the DSP active.
For this we export the following functions:
- imx_dsp_request_channel, gets a channel with a given index
- imx_dsp_free_channel, frees a channel with a given
From: Daniel Baluta
Create a separate function that sets up DSP mailbox channels
so that imx_dsp_probe function will be easier to read.
Signed-off-by: Daniel Baluta
---
drivers/firmware/imx/imx-dsp.c | 41 +-
1 file changed, 26 insertions(+), 15 deletions
imx_mu_suspend_noirq()/imx_mu_resume_noirq() __maybe_unused to
address the issue.
Cc: Jassi Brar
Cc: Shawn Guo
Cc: Sascha Hauer
Cc: Pengutronix Kernel Team
Cc: Fabio Estevam
Cc: NXP Linux Team
Signed-off-by: Vincenzo Frascino
Reviewed-by: Daniel Baluta
From: Daniel Baluta
Use dev_multi_pm_attach / dev_multi_pm_detach instead of the hardcoded
version.
Signed-off-by: Daniel Baluta
---
sound/soc/sof/imx/imx8.c | 60 ++--
1 file changed, 9 insertions(+), 51 deletions(-)
diff --git a/sound/soc/sof/imx/imx8.c
From: Daniel Baluta
This patch introduces helpers support for multi PM domains.
API consists of:
1) dev_multi_pm_attach - powers up all PM domains associated with a given
device. Because we can attach one PM domain per device, we create
virtual devices (children of initial device) and
From: Daniel Baluta
i.MX8QXP/i.MX8QM has IPs that need multiple power domains to be up
in order to work. In order to help drivers, we introduce multi PM
domains helpers that are able to activate/deactivate multi PM domains.
First patch introduces the helpers and second patch demonstrates how
a
From: Daniel Baluta
i.MX8QXP/i.MX8QM has IPs that need multiple power domains to be up
in order to work. In order to help drivers, we introduce multi PM
domains helpers that are able to activate/deactivate multi PM domains.
First patch introduces the helpers and second patch demonstrates how
a
From: Daniel Baluta
Use dev_multi_pm_attach / dev_multi_pm_detach instead of the hardcoded
version.
Signed-off-by: Daniel Baluta
---
sound/soc/sof/imx/imx8.c | 60 ++--
1 file changed, 9 insertions(+), 51 deletions(-)
diff --git a/sound/soc/sof/imx/imx8.c
From: Daniel Baluta
This patch introduces helpers support for multi PM domains.
API consists of:
1) dev_multi_pm_attach - powers up all PM domains associated with a given
device. Because we can attach one PM domain per device, we create
virtual devices (children of initial device) and
On 6/18/20 2:01 PM, Mark Brown wrote:
On Wed, Jun 17, 2020 at 09:02:32PM -0400, Sasha Levin wrote:
From: Daniel Baluta
[ Upstream commit c26fde3b15ed41f5f452f1da727795f787833287 ]
This provides a better separation between runtime and PM sleep
callbacks.
Only do nothing if given runtime flag
On 11.06.2020 11:48, Anson Huang wrote:
Hi, Daniel
Subject: Re: [PATCH V4 4/9] pinctrl: imx8mn: Support building as module
Maybe this is obvious but I would really like to see an explanation
of why we are switching from arch_initcall to platform_init.
Commit message act as documentation f
On 11.06.2020 11:44, Anson Huang wrote:
Hi, Daniel
Subject: Re: [PATCH V4 0/9] Support i.MX8 SoCs pinctrl drivers built as module
Hi Anson,
Patch series mostly looks good to me. I have a comment about adding
the MODULE_LICENSE. This is a pretty important change.
Can you please add this c
Maybe this is obvious but I would really like to see an explanation
of why we are switching from arch_initcall to platform_init.
Commit message act as documentation for the reviewers.
On 10.06.2020 10:57, Anson Huang wrote:
Support building i.MX8MN pinctrl driver as module.
Signed-off-by: An
Hi Anson,
Patch series mostly looks good to me. I have a comment about adding
the MODULE_LICENSE. This is a pretty important change.
Can you please add this change in a separate patch with a proper explanation
of why it is needed.
Most likely it is because it was forgotten in the previous p
On 03.06.2020 12:29, peng@nxp.com wrote:
From: Peng Fan
Use devm_kasprintf to simplify code
Signed-off-by: Peng Fan
Reviewed-by: Daniel Baluta
> Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development
> kit")
>
> Signed-off-by: Adam Ford
No need for a new line between fixes and signed-off-by.
With that:
Reviewed-by: Daniel Baluta
ed-off-by: Guido Günther
For audio related part:
Reviewed-by: Daniel Baluta
On 22.05.2020 17:26, Jonathan Albrieux wrote:
On Fri, May 22, 2020 at 01:47:21PM +0300, Daniel Baluta wrote:
+
+maintainers:
+ - can't find a mantainer, author is Daniel Baluta
Daniel is still active in the kernel, just not at Intel any more. +CC
Oh ok thank you! Daniel are you
+
+maintainers:
+ - can't find a mantainer, author is Daniel Baluta
Daniel is still active in the kernel, just not at Intel any more. +CC
Oh ok thank you! Daniel are you still maintaining this driver?
I can do reviews if requested but I'm not actively maintaining this
On 4/30/20 3:46 PM, Schrempf Frieder wrote:
+ /*
+* On i.MX8MM there is an interrupt getting triggered immediately
+* after requesting the IRQ, which leads to a stall as the handler
+* accesses the GPU registers whithout the clock being enabled.
+* Enabling the
d.
One concern is that we could end up in a case where IMX_DSP={y|m} but
IMX_MBOX=n.
Technically this is not possible because IMX_DSP depends on IMX_MBOX. So,
one cannot generate such a .config file from menuconfig interface.
You can add my:
Acked-by: Daniel Baluta
On Sat, Apr 25, 2020 at 11:03 AM ChenTao wrote:
>
> Fix the following warning:
>
> sound/soc/sof/imx/imx8m.c:95:20: warning:
> symbol 'imx8m_dsp_ops' was not declared. Should it be static?
>
> Reported-by: Hulk Robot
> Signed-off-by: ChenTao
Reviewed-by: Dan
On Wed, 2019-10-23 at 14:34 +0800, Anson Huang wrote:
> Machine compatible string normally is located in board DT, remove
> the duplicated one from SoC dtsi.
>
> Signed-off-by: Anson Huang
Reviewed-by: Daniel Baluta
> ---
> arch/arm64/boot/dts/freescale/imx8mm.dtsi | 1 -
&g
On Wed, 2019-10-23 at 14:34 +0800, Anson Huang wrote:
> Machine compatible string normally is located in board DT, remove
> the duplicated one from SoC dtsi.
>
> Signed-off-by: Anson Huang
Reviewed-by: Daniel Baluta
> ---
> arch/arm64/boot/dts/freescale/imx8mn.dtsi | 1 -
&g
b9fdef6c ("arm64: dts: imx8mm-evk: Enable audio codec
> wm8524")
> Signed-off-by: Shengjiu Wang
Reviewed-by: Daniel Baluta
> ---
> arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 2 ++
> arch/arm64/boot/dts/freescale/imx8mm.dtsi| 8 ++--
> 2 files changed, 8 ins
Hi Stephen,
On Fri, Oct 11, 2019 at 3:04 AM Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from include/sound/sof/dai-imx.h:11,
> from :
> include/sound/sof/header.
IMX DSP device is created by SOF layer. The current call to
devm_of_platform_populate is not needed and it doesn't produce
any effects.
Fixes: ffbf23d50353915d ("firmware: imx: Add DSP IPC protocol interface)
Signed-off-by: Daniel Baluta
---
drivers/firmware/imx/imx-dsp.c | 2 +-
1 fi
On Mon, Oct 14, 2019 at 2:57 PM Mark Brown wrote:
>
> On Sun, Oct 13, 2019 at 10:00:14PM +0300, Daniel Baluta wrote:
>
> > This property can be global in which case all links created will be DPCM
> > or present in certian dai-link subnode in which case only that specific
>
CPU.
Add force-dpcm DT property to realize this.
Signed-off-by: Daniel Baluta
---
include/sound/simple_card_utils.h | 4
sound/soc/generic/simple-card-utils.c | 17 +
sound/soc/generic/simple-card.c | 25 +++--
3 files changed, 44 insertions(+), 2
This property can be global in which case all links created will be DPCM
or present in certian dai-link subnode in which case only that specific
link is forced to be DPCM.
Signed-off-by: Daniel Baluta
---
Documentation/devicetree/bindings/sound/simple-card.txt | 1 +
1 file changed, 1 insertion
We need to be able to create DPCM links even if we have a single CPU DAI
or just a dummy CPU DAI.
Daniel Baluta (2):
ASoC: simple-card: Introduce force-dpcm DT property
ASoC: simple-card: Add documentation for force-dpcm property
.../devicetree/bindings/sound/simple-card.txt | 1 +
include
On Sat, Oct 12, 2019 at 4:12 AM Richard Zhu wrote:
>
> Hi Daniel:
> New version patch-set had been sent out on Oct9.
> https://patchwork.kernel.org/cover/11180683/
Thanks Richard. Jassi, care to have a look?
Daniel
asoc_simple_debug_info and asoc_simple_debug_dai must be static
otherwise we might a compilation error if the compiler decides
not to inline the given function.
Fixes: 0580dde59438686d ("ASoC: simple-card-utils: add
asoc_simple_debug_info()")
Signed-off-by: Daniel Baluta
---
inc
include/sound/simple_card_utils.h:168:3: note: in expansion of macro
‘dev_dbg’
dev_dbg(dev, "%s clk %luHz\n", name, clk_get_rate(dai->clk));
Fix this by including the appropriate header.
Fixes: 0580dde59438686d ("ASoC: simple-card-utils: add
asoc_simple_debug_info()
For this to happen we symbol DEBUG to be defined.
Daniel Baluta (2):
ASoC: simple_card_utils.h: Add missing include
ASoC: Fix potential multiple redefinition error
include/sound/simple_card_utils.h | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
--
2.17.1
Hi Richard,
Can you please rebase and resend this patch series?
On Mon, Aug 5, 2019 at 10:21 PM Daniel Baluta wrote:
>
> On Mon, Aug 5, 2019 at 8:16 AM Richard Zhu wrote:
> >
> > There is a version 1.0 MU on i.MX7ULP platform.
> > One new version ID register is add
uot;ASoC: SOF: imx8: Fix COMPILE_TEST error")
> Fixes: 202acc565a1f ("ASoC: SOF: imx: Add i.MX8 HW support")
> Signed-off-by: Arnd Bergmann
Acked-by: Daniel Baluta
Indeed we will need to somehow avoid getting sof_imx8_ops from
sof-of-dev.c by directly referencing it.
Will k
For a sound card ignore_machine means that existing FEs links should be
ignored and existing BEs links should be overridden with some information
from the matching component driver.
Current code make some confusions about this so fix it!
Signed-off-by: Daniel Baluta
---
sound/soc/soc-core.c
This series contains several fixes for SAI. They are unrelated
but grouped them in a patch series to be easier applied.
Daniel Baluta (1):
ASoC: fsl_sai: Fix TCSR.TE/RCSR.RE in synchronous mode
Mihai Serban (1):
ASoC: fsl_sai: Fix noise when using EDMA
Shengjiu Wang (1):
ASoC: fsl_sai
be set in record
to enable the transmitter which provides bit clock and frame sync.
Cc: NXP Linux Team
Signed-off-by: Daniel Baluta
---
Changes since v1:
* new patch
sound/soc/fsl/fsl_sai.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/sound/soc/fsl/fsl_sai.c
From: Shengjiu Wang
When Tx is synchronous with receiver the RMR should not be changed.
When Rx is synchronous with transmitter the TMR should not be changed.
Cc: NXP Linux Team
Signed-off-by: Shengjiu Wang
Signed-off-by: Daniel Baluta
---
Changes since v1:
* new patch
sound/soc/fsl
: Mihai Serban
Signed-off-by: Daniel Baluta
---
Changes since v1:
* rename variable to use_edma as per Nicolin's suggestion.
sound/soc/fsl/fsl_sai.c | 15 +++
sound/soc/fsl/fsl_sai.h | 1 +
2 files changed, 16 insertions(+)
diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_
On Wed, Sep 11, 2019 at 2:01 PM Mark Brown wrote:
>
> On Thu, Sep 05, 2019 at 06:29:39PM -0700, Nicolin Chen wrote:
> > On Sat, Aug 31, 2019 at 12:59:10AM +0300, Daniel Baluta wrote:
>
> > > This is to allow machine drivers to set a certain bitclk rate
> > >
On Tue, Sep 10, 2019 at 1:40 PM Anson Huang wrote:
>
>
>
> > On Sat, Sep 7, 2019 at 9:47 PM Stephen Boyd wrote:
> > >
> > > Quoting Peng Fan (2019-08-27 01:17:50)
> > > > From: Peng Fan
> > > >
> > > > There is hardware issue that:
> > > > The output clock the LPCG cell will not turn back on as
On Fri, Sep 6, 2019 at 4:25 AM Nicolin Chen wrote:
>
> On Fri, Aug 30, 2019 at 11:09:00PM +0300, Daniel Baluta wrote:
> > From: Mihai Serban
> >
> > EDMA requires the period size to be multiple of maxburst. Otherwise the
> > remaining bytes are not transfer
X_TOPLEVEL always depends on SND_SOC_SOF_OF
>
> Reported-by: Hulk Robot
> Fixes: 202acc565a1f ("ASoC: SOF: imx: Add i.MX8 HW support")
> Signed-off-by: YueHaibing
Reviewed-by: Daniel Baluta
> ---
> sound/soc/sof/imx/Kconfig | 3 ++-
> 1 file changed, 2 insertion
On Mon, Sep 2, 2019 at 3:42 PM Mark Brown wrote:
>
> On Sat, Aug 31, 2019 at 01:55:14AM +0300, Daniel Baluta wrote:
>
> > Fix this by setting CHMOD to Output Mode so that pins will output zero
> > when slots are masked or channels are disabled.
>
> This patch seems
hen slots are masked or channels are disabled.
Cc: NXP Linux Team
Signed-off-by: Cosmin-Gabriel Samoila
Signed-off-by: Daniel Baluta
---
sound/soc/fsl/fsl_sai.c | 15 ---
sound/soc/fsl/fsl_sai.h | 2 ++
2 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/sound/soc/
From: Viorel Suman
This is to allow machine drivers to set a certain bitclk rate
which might not be exactly rate * frame size.
Cc: NXP Linux Team
Signed-off-by: Viorel Suman
Signed-off-by: Daniel Baluta
---
sound/soc/fsl/fsl_sai.c | 21 +++--
sound/soc/fsl/fsl_sai.h | 1
Team
Signed-off-by: Mihai Serban
Signed-off-by: Daniel Baluta
---
sound/soc/fsl/fsl_sai.c | 15 +++
sound/soc/fsl/fsl_sai.h | 1 +
2 files changed, 16 insertions(+)
diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
index 728307acab90..fe126029f4e3 100644
--- a/sound/soc
On Tue, 2019-08-27 at 18:13 -0400, Shengjiu Wang wrote:
> Use force_suspend/resume to make sure clocks are disabled/enabled
> accordingly during system suspend/resume.
>
> Signed-off-by: Dong Aisheng
> Signed-off-by: Shengjiu Wang
Reviewed-by: Daniel Baluta
> ---
> sou
On Tue, Aug 27, 2019 at 1:15 PM Shengjiu Wang wrote:
>
> Use force_suspend/resume to make sure clocks are disabled/enabled
> accordingly during system suspend/resume.
>
> Signed-off-by: Dong Aisheng
> Signed-off-by: Shengjiu Wang
Reviewed-by: Daniel Baluta
> ---
> so
by the value in child device.
>
> Fixes: b86ef5367761 ("ASoC: fsl: Add Audio Mixer machine driver")
> Signed-off-by: Viorel Suman
> Signed-off-by: Shengjiu Wang
Reviewed-by: Daniel Baluta
Thanks Shengjiu for the fix!
> ---
> sound/soc/fsl/imx-audmix.c | 4 ++--
> 1 file
W support")
> Signed-off-by: Wei Yongjun
Good catch. Thanks!
Reviewed-by: Daniel Baluta
> ---
> sound/soc/sof/imx/imx8.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/sof/imx/imx8.c b/sound/soc/sof/imx/imx8.c
> index e502f5842
d. Should it be static?
> sound/soc/sof/imx/imx8.c:348:5: warning: symbol 'imx8_ipc_pcm_params' was not
> declared. Should it be static?
>
> Reported-by: Hulk Robot
> Signed-off-by: YueHaibing
Reviewed-by: Daniel Baluta
> ---
> sound/soc/sof/imx/imx8.c | 18 +--
On Wed, 2019-08-21 at 18:33 +0200, Guido Günther wrote:
> The current code prints 'ret' (thus 0) while it should use 'err'.
>
> Signed-off-by: Guido Günther
Reviewed-by: Daniel Baluta
> ---
> drivers/soc/imx/gpcv2.c | 2 +-
> 1 file changed, 1 inserti
1 - 100 of 955 matches
Mail list logo
