Re: [PATCH] led-class.c permission change

2007-05-05 Thread Colin Leroy
On 05 May 2007 at 22h05, Alan Cox wrote: Hi, > > This patch changes the led brightness file's permissions to 0666, > > so that a user's MUA can light up the mail LED without needing root > > permissions. > > NAK. > > The management of user specific temporary permissions belongs in user > spa

[PATCH] led-class.c permission change

2007-05-05 Thread Colin Leroy
Hi, This patch changes the led brightness file's permissions to 0666, so that a user's MUA can light up the mail LED without needing root permissions. Thanks! Signed-Off-By: Colin Leroy <[EMAIL PROTECTED]> --- a/drivers/leds/led-class.c 2007-05-05 12:45:20.0 +0200 ++

[PATCH] fix oom_kill_task

2005-09-09 Thread Colin Leroy
Hi, oom_kill_task's comment states that we should be careful about not sending SIGKILL to processes with SYS_CAP_RAWIO, then the code happily sends it anyway. Here's a patch that fixes that. Signed-Off-By: Colin Leroy <[EMAIL PROTECTED]> --- a/mm/oom_kill.c 2005-09-09 17

Re: [PATCH] fix oom_kill_task

2005-09-09 Thread Colin Leroy
Hi, Alternatively, if sending SIGKILL is intended, here's the patch that fixes the comment. Thanks, Signed-Off-By: Colin Leroy <[EMAIL PROTECTED]> --- a/mm/oom_kill.c 2005-09-09 17:29:08.0 +0200 +++ b/mm/oom_kill.c 2005-09-09 17:32:47.0 +0200 @@ -168,11 +168,

2.6.12-rc3 cpufreq compile error on ppc32

2005-04-21 Thread Colin Leroy
o the previous patch, but it doesn't apply cleanly anymore. It's named add-suspend-method-to-cpufreq-core-warning-fix.patch Here's an updated version. HTH, Signed-off-by: Colin Leroy <[EMAIL PROTECTED]> --- a/drivers/cpufreq/cpufreq.c 2005-04-21 09:14:28.0 +0200 ++

hpfsck question

2005-04-20 Thread Colin Leroy
Hi Klaus, Yesterday I tried to mount my iPod as usual, but the hfsplus kernel module complained the following: HFS+-fs warning: Filesystem was not cleanly unmounted, running fsck.hfsplus is recommended. mounting read-only. So I installed your hfsplusutils package and ran hpfsck. After that

Re: [PATCH] hfsplus: add an option to force r/w mount

2005-04-20 Thread Colin Leroy
On 20 Apr 2005 at 22h04, Roman Zippel wrote: Hi, > > for some reason yet unknown, fsck.hfsplus doesn't correctly set the > > HFSPLUS_VOL_UNMNT flag here. > > If fsck doesn't mark it clean, there must be a reason By the way, the reason is that this stupid utility opens the device read-only (hen

Re: [PATCH] hfsplus: add an option to force r/w mount

2005-04-20 Thread Colin Leroy
On 20 Apr 2005 at 22h04, Roman Zippel wrote: Hi, > Hi, > > On Wed, 20 Apr 2005, Colin Leroy wrote: > > > for some reason yet unknown, fsck.hfsplus doesn't correctly set the > > HFSPLUS_VOL_UNMNT flag here. > > If fsck doesn't mark it clean, there mu

Re: [linux-usb-devel] USB glitches after suspend on ppc

2005-04-06 Thread Colin Leroy
On Thu, 07 Apr 2005 09:02:57 +1000 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > Interesting. Looks like pci_enable_wake(dev, state, 0) isn't > > actually disabling wakeup on your hardware. (Assuming > > CONFIG_USB_SUSPEND=n; if not, then it's odd that the system went > > back to sleep!)

Re: [linux-usb-devel] USB glitches after suspend on ppc

2005-04-06 Thread Colin Leroy
On Wed, 6 Apr 2005 13:11:53 -0700 David Brownell <[EMAIL PROTECTED]> wrote: > Interesting. Looks like pci_enable_wake(dev, state, 0) isn't actually > disabling wakeup on your hardware. (Assuming CONFIG_USB_SUSPEND=n; if > not, then it's odd that the system went back to sleep!) Yes, CONFIG_USB_

Re: [linux-usb-devel] USB glitches after suspend on ppc

2005-04-06 Thread Colin Leroy
On 05 Apr 2005 at 13h04, David Brownell wrote: Hi, > > There are known issues with USB after suspend/resume (D3 hot) on > > powerpc. > > Also known fixes to some of them, which haven't yet been merged. > I'll repost these as followups to this message, to linux-usb-devel > and CC Colin. They're

USB glitches after suspend on ppc

2005-04-05 Thread Colin Leroy
Hi, There are known issues with USB after suspend/resume (D3 hot) on powerpc. For example, plugging or unplugging devices during sleep results in oopses at resume; and one time out of two, the USB ports are unpowered on resume (because the registers think they are, and linux doesn't repower them.

[PATCH] fix shared key auth in zd1201

2005-03-28 Thread Colin Leroy
using the zd1201 driver. The attached patch fixes it. The reason was (probably) a typo in the definitions of the authentification types. I found that they should be (1,2) instead of (0,1) by looking at the old linux-wlan-ng driver by Zydas. Signed-off-by: Colin Leroy <[EMAIL PROTECTED]> --- a/

RFC: workaround quality bug in zd1201 hardware

2005-03-23 Thread Colin Leroy
more knowledge on 802.11b than I have could give me an hint, it'd be appreciated. Thanks! Signed-off-by: Colin Leroy <[EMAIL PROTECTED]> --- a/drivers/usb/net/zd1201.c 2005-03-23 15:17:12.0 +0100 +++ b/drivers/usb/net/zd1201.c 2005-03-23 15:17:50.0 +0100 @@ -1

`dd` problem from cdrom

2005-03-16 Thread Colin Leroy
Hi, Using 2.6.10 and 2.6.11, trying to use dd from the ide cdrom in my Ibook G4 fails like this: [EMAIL PROTECTED] /usr/src/linux-2.6.10]$ dd if=/dev/hdc of=/dev/null dd: reading `/dev/hdc': Input/output error 0+0 records in 0+0 records out [EMAIL PROTECTED] /usr/src/linux-2.6.10]$ dmesg hdc: com

[PATCH] Make therm_adt746x handle latest powerbooks

2005-03-07 Thread Colin Leroy
an". Here's a patch that handles both old and new form. Please apply :) Signed-off-by: Colin Leroy <[EMAIL PROTECTED]> --- a/drivers/macintosh/therm_adt746x.c 2005-03-07 09:03:58.0 +0100 +++ b/drivers/macintosh/therm_adt746x.c 2005-03-07 09:04:35.0 +0100 @@ -

Re: [PATCH] therm_adt746x: smooth fan

2005-01-26 Thread Colin Leroy
> This patchs allows a smoother fan speed switching with therm_adt746x. > Instead of setting 0 or 128, it scales speed according to temperature. Thanks, but you'd have saved some of your time if you had checked 2.6.10: I implemented such a system, it's in since 2.6.10 :) > It would be even better