[PATCH][next] selftests/futex: Fix spelling mistake "manaul" -> "manual"

There is a spelling mistake in a ksft_test_result message. Fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/futex/functional/futex_priv_hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/futex/functional/futex_priv_hash.c b/tools

[PATCH][next] selftests/futex: Fix spelling mistake "unitiliazed" -> "uninitialized"

There is a spelling mistake in a fail error message. Fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/futex/functional/futex_numa_mpol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/futex/functional/futex_numa_mpol.c b/tools

[PATCH][next] selftests/perf_events: Fix spelling mistake "sycnhronize" -> "synchronize"

There is a spelling mistake in an error message. Fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/perf_events/watermark_signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/perf_events/watermark_signal.c b/tools/testing/selftests

[PATCH][next] KVM: selftests: Fix spelling mistake "avaialable" -> "available"

There is a spelling mistake in a ksft_test_result_skip message. Fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/kvm/s390/cpumodel_subfuncs_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/s390/cpumodel_subfuncs_test.c b

[PATCH]][next] KVM: selftests: Fix spelling mistake "UFFDIO_CONINUE" -> "UFFDIO_CONTINUE"

There is a spelling mistake in a PER_PAGE_DEBUG debug message. Fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/kvm/lib/userfaultfd_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/lib/userfaultfd_util.c b/tools/testing

[PATCH][next] selftests/x86/xstate: Fix spelling mistake "hader" -> "header"

There is a spelling mistake in a sig_print message. Fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/x86/xstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/x86/xstate.c b/tools/testing/selftests/x86/xstate.c index 875777911d82

[PATCH][next] KVM: selftests: Fix spelling mistake "Unabled" -> "Unable"

There is a spelling mistake in a TEST_FAIL message. Fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/kvm/lib/kvm_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c

[PATCH] KVM: selftests: Fix spelling mistake "initally" -> "initially"

There is a spelling mistake in a literal string and in the function test_get_inital_dirty. Fix them. Signed-off-by: Colin Ian King --- tools/testing/selftests/kvm/s390/cmma_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/kvm/s390

[PATCH][next] KVM: selftests: Fix spelling mistake "initally" -> "initially"

There is a spelling mistake in a literal string. Fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/kvm/s390/cmma_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/s390/cmma_test.c b/tools/testing/selftests/kvm/s390

[PATCH][next] virtio_vdpa: remove redundant check on desc

ned-off-by: Colin Ian King --- drivers/virtio/virtio_vdpa.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c index 7364bd53e38d..1f60c9d5cb18 100644 --- a/drivers/virtio/virtio_vdpa.c +++ b/drivers/virtio/virtio_vdp

[PATCH][next] KVM: s390: selftests: Fix spelling mistake "avaialable" -> "available"

There is a spelling mistake in a ksft_test_result_skip message. Fix it. Signed-off-by: Colin Ian King --- tools/testing/selftests/kvm/s390x/cpumodel_subfuncs_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/kvm/s390x/cpumodel_subfuncs_test.c b

[PATCH][next] firewire: core: Fix spelling mistakes in tracepoint messages

There are two spelling mistakes in the tracepoint message text. Fix them. Signed-off-by: Colin Ian King --- include/trace/events/firewire.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/trace/events/firewire.h b/include/trace/events/firewire.h index

[PATCH][next] dax: remove redundant assignment to variable rc

Signed-off-by: Colin Ian King --- drivers/dax/bus.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c index 797e1ebff299..f758afbf8f09 100644 --- a/drivers/dax/bus.c +++ b/drivers/dax/bus.c @@ -1204,7 +1204,6 @@ static ssize_t mapping_store(struct device *d

[PATCH][next] fsdax: remove redundant variable 'error'

ue is never actually read from 'error' [deadcode.DeadStores] Signed-off-by: Colin Ian King --- fs/dax.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/dax.c b/fs/dax.c index 2ababb89918d..cb36c6746fc4 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -1830,

[PATCH] nvdimm/region: Fix spelling mistake "memergion" -> "memregion"

There is a spelling mistake in a dev_warn message. Fix it. Signed-off-by: Colin Ian King --- drivers/nvdimm/region_devs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c index 83dbf398ea84..8f5274b04348 100644 --- a

Re: [PATCH] perf/x86: Fix integer overflow when left shifting an integer more than 32 bits

On 20/04/2021 16:31, Peter Zijlstra wrote: > On Tue, Apr 20, 2021 at 05:03:03PM +0200, Peter Zijlstra wrote: >> On Tue, Apr 20, 2021 at 03:29:07PM +0100, Colin King wrote: >>> From: Colin Ian King >>> >>> The 64 bit value read from MSR_ARCH_PERFMON_FIXED_CTR_CT

re: phy: nxp-c45: add driver for tja1103

Hi, Static analysis with Coverity on linux-next has found a potential issue in drivers/net/phy/nxp-c45-tja11xx.c, function nxp_c45_get_phase_shift. The analysis by Coverity is as follows: 350 static u64 nxp_c45_get_phase_shift(u64 phase_offset_raw) 351 { 352/* The delay in degree phase is

Re: [PATCH][next] can: etas_es58x: Fix potential null pointer dereference on pointer cf

On 15/04/2021 10:03, Marc Kleine-Budde wrote: > On 15.04.2021 09:55:35, Colin King wrote: >> From: Colin Ian King >> >> The pointer cf is being null checked earlier in the code, however the >> update of the rx_bytes statistics is dereferencing cf without null >>

Re: [PATCH][next] KEYS: trusted: Fix missing null return from kzalloc call

On 12/04/2021 17:48, James Bottomley wrote: > On Mon, 2021-04-12 at 17:01 +0100, Colin King wrote: >> From: Colin Ian King >> >> The kzalloc call can return null with the GFP_KERNEL flag so >> add a null check and exit via a new error exit label. Use the >> same e

Re: [PATCH] xfs: fix return of uninitialized value in variable error

On 09/04/2021 15:28, Brian Foster wrote: > On Fri, Apr 09, 2021 at 03:18:34PM +0100, Colin King wrote: >> From: Colin Ian King >> >> A previous commit removed a call to xfs_attr3_leaf_read that >> assigned an error return code to variable error. We now have >>

cnic: issue with double assignment to ictx->xstorm_st_context.common.flags

Hi, Analysis of linux with Coverity has detected an issue with the assignment of ictx->xstorm_st_context.common.fla in drivers/net/ethernet/broadcom/cnic.c in function cnic_setup_bnx2x_ctx. This was introduced a while back with the following commit: commit 619c5cb6885b936c44ae1422ef805b69c629148

Re: [PATCH][next] mlxsw: spectrum_router: remove redundant initialization of variable force

On 29/03/2021 08:13, Ido Schimmel wrote: > On Sat, Mar 27, 2021 at 10:33:34PM +, Colin King wrote: >> From: Colin Ian King >> >> The variable force is being initialized with a value that is >> never read and it is being updated later with a new value. The >>

Re: [PATCH] clk: uniphier: Fix potential infinite loop

On 09/04/2021 07:46, Masahiro Yamada wrote: > On Thu, Apr 8, 2021 at 12:25 AM Colin King wrote: >> >> From: Colin Ian King >> >> The for-loop iterates with a u8 loop counter i and compares this >> with the loop upper limit of num_parents that is an int type. >

re: drm/i915/selftests: Prepare gtt tests for obj->mm.lock removal

Hi, Static analysis with Coverity on Linux-next has detected a potential issue with the following commit: commit 480ae79537b28f30ef6e07b7de69a9ae2599daa7 Author: Maarten Lankhorst Date: Tue Mar 23 16:50:49 2021 +0100 drm/i915/selftests: Prepare gtt tests for obj->mm.lock removal The ana

re: ALSA: control - add layer registration routines

Hi, Static analysis on linux-next with Coverity has detected a potential issue in the following commit: commit 3f0638a0333bfdd0549985aa620f2ab69737af47 Author: Jaroslav Kysela Date: Wed Mar 17 18:29:41 2021 +0100 ALSA: control - add layer registration routines The static analysis is as f

Re: [PATCH] mm/page_alloc: Add a bulk page allocator -fix -fix

On 30/03/2021 12:48, Mel Gorman wrote: > Colin Ian King reported the following problem (slightly edited) > > Author: Mel Gorman > Date: Mon Mar 29 11:12:24 2021 +1100 > > mm/page_alloc: add a bulk page allocator > > ... > >

re: mm/page_alloc: add a bulk page allocator

Hi, Static analysis on linux-next with Coverity has found a potential uninitialized variable issue in function __alloc_pages_bulk with the following commit: commit b0e0a469733fa571ddd8fe147247c9561b51b2da Author: Mel Gorman Date: Mon Mar 29 11:12:24 2021 +1100 mm/page_alloc: add a bulk pa

re: drm/ttm: switch to per device LRU lock

Hi, Static analysis with Coverity in linux-next has detected an issue in drivers/gpu/drm/ttm/ttm_bo.c with the follow commit: commit a1f091f8ef2b680a5184db065527612247cb4cae Author: Christian König Date: Tue Oct 6 17:26:42 2020 +0200 drm/ttm: switch to per device LRU lock Instead of

Re: [PATCH] x86/kprobes: Remove dead code

On 24/03/2021 17:36, Muhammad Usama Anjum wrote: > The condition in switch statement `opcode & 0xf0` cannot evaluate to > 0xff. So this case statement will never execute. Remove it. > > Fixes: 6256e668b7 ("x86/kprobes: Use int3 instead of debug trap for > single-step") > Signed-off-by: Muhammad U

Re: [PATCH][next] staging: rtl8188eu: Fix null pointer dereference on free_netdev call

On 24/03/2021 16:11, Martin Kaiser wrote: > Hello Colin, > > Thus wrote Colin King (colin.k...@canonical.com): > >> From: Colin Ian King > >> An unregister_netdev call checks if pnetdev is null, hence a later >> call to free_netdev can potentially be passing

re: x86/kprobes: Use int3 instead of debug trap for single-step

Hi, Static analysis on linux-next using Coverity has detected an issue in the following commit: commit 6256e668b7af9d81472e03c6a171630c08f8858a Author: Masami Hiramatsu Date: Wed Mar 3 00:25:46 2021 +0900 x86/kprobes: Use int3 instead of debug trap for single-step The analysis is as foll

Re: [PATCH][next] loop: Fix missing max_active argument in alloc_workqueue call

On 19/03/2021 15:54, Dan Schatzberg wrote: > On Thu, Mar 18, 2021 at 03:16:26PM +, Colin King wrote: >> From: Colin Ian King >> >> The 3rd argument to alloc_workqueue should be the max_active count, >> however currently it is the lo->lo_number that is intended

Re: [PATCH][next] loop: Fix missing max_active argument in alloc_workqueue call

On 18/03/2021 20:12, Jens Axboe wrote: > On 3/18/21 9:16 AM, Colin King wrote: >> From: Colin Ian King >> >> The 3rd argument to alloc_workqueue should be the max_active count, >> however currently it is the lo->lo_number that is intended for the >> loop

Re: [PATCH][next] soc: xilinx: vcu: remove deadcode on null divider check

On 11/02/2021 19:05, Stephen Boyd wrote: > Quoting Michael Tretter (2021-02-10 23:39:06) >> On Wed, 10 Feb 2021 19:28:18 -0800, Stephen Boyd wrote: >>> Quoting Colin King (2021-02-10 10:49:38) >>>> From: Colin Ian King >>>> >>>> The pointer

Re: pinctrl: core: Handling pinmux and pinconf separately

On 12/03/2021 12:45, Andy Shevchenko wrote: > On Thu, Mar 11, 2021 at 1:26 PM Colin Ian King > wrote: >> On 11/03/2021 11:16, Michal Simek wrote: >>> On 3/11/21 11:57 AM, Colin Ian King wrote: > >>>> For the PIN_MAP_TYPE_CONFIGS_PIN and PIN_MAP_TYPE_CONFIG

Re: [PATCH] pinctrl: core: Set ret to 0 when group is skipped

ze ret to 0 to avoid uninitialized ret value in first > loop or reusing ret value from first loop in second. > > Addresses-Coverity: ("Uninitialized variables") > Signed-off-by: Michal Simek > CC: Colin Ian King > CC: Dan Carpenter > --- > > drivers/pinctrl/c

Re: [PATCH][next] nvmem: core: Fix unintentional sign extension issue

On 11/03/2021 17:12, Doug Anderson wrote: > Hi, > > On Thu, Mar 11, 2021 at 1:53 AM Colin King wrote: >> >> From: Colin Ian King >> >> The shifting of the u8 integer buf[3] by 24 bits to the left will >> be promoted to a 32 bit signed int and then sign-

Re: pinctrl: core: Handling pinmux and pinconf separately

On 11/03/2021 11:28, Michal Simek wrote: > > > On 3/11/21 12:24 PM, Colin Ian King wrote: >> On 11/03/2021 11:16, Michal Simek wrote: >>> >>> >>> On 3/11/21 11:57 AM, Colin Ian King wrote: >>>> Hi, >>>> >>>> Static an

Re: pinctrl: core: Handling pinmux and pinconf separately

On 11/03/2021 11:16, Michal Simek wrote: > > > On 3/11/21 11:57 AM, Colin Ian King wrote: >> Hi, >> >> Static analysis on linux-next with Coverity has found a potential issue >> in drivers/pinctrl/core.c with the following commit: >> >> commit 0952b

re: scsi: sg: Replace sg_allow_access()

Hi, Static analysis on linux-next with Coverity has detected an issue in drivers/scsi/sg.c in function sg_remove_sfp_usercontext with the following recent commit: commit 0c32296d73ec5dec64729eb555f1a29ded8a7272 Author: Douglas Gilbert Date: Fri Feb 19 21:00:28 2021 -0500 scsi: sg: Replace

re: pinctrl: core: Handling pinmux and pinconf separately

Hi, Static analysis on linux-next with Coverity has found a potential issue in drivers/pinctrl/core.c with the following commit: commit 0952b7ec1614abf232e921aac0cc2bca8e60e162 Author: Michal Simek Date: Wed Mar 10 09:16:54 2021 +0100 pinctrl: core: Handling pinmux and pinconf separately

re: scsi: sg: NO_DXFER move to/from kernel buffers

Hi, Static analysis on linux-next with Coverity has detected an issue in drivers/scsi/sg.c with the following recent commit: commit b32ac463cb59e758b4560260fd168a2b4ea6e81a Author: Douglas Gilbert Date: Fri Feb 19 21:00:54 2021 -0500 scsi: sg: NO_DXFER move to/from kernel buffers The ana

net: mscc: ocelot: issue with uninitialized pointer read in ocelot_flower_parse_key

Hi, Static analysis with Coverity had detected an uninitialized pointer read in function ocelot_flower_parse_key in drivers/net/ethernet/mscc/ocelot_flower.c introduced by commit: commit 75944fda1dfe836fdd406bef6cb3cc8a80f7af83 Author: Xiaoliang Yang Date: Fri Oct 2 15:02:23 2020 +0300 ne

Re: [PATCH] usb: dwc3: Fix dereferencing of null dwc->usb_psy

On 03/03/2021 21:29, Heiko Thiery wrote: > Hi all, > >> On Wed, Mar 3, 2021 at 6:00 PM Colin King wrote: >>> >>> From: Colin Ian King >>> >>> Currently the null check logic on dwc->usb_psy is inverted as it allows >>> calls to power_su

Re: f2fs_convert_inline_inode causing rebalance based on random uninitialized value in dn.node_changed

On 03/03/2021 19:44, Jaegeuk Kim wrote: > On 03/02, Colin Ian King wrote: >> Hi, >> >> Static analysis on linux-next detected a potential uninitialized >> variable dn.node_changed that does not get set when a call to >> f2fs_get_node_page() fails. This uninitializ

re: drm/amd/display: Implement dmub trace event

Hi, Static analysis on linux-next wit Coverity has found a potential null pointer dereference in commit: commit 70732504c53b2d3aae2cebc457515a304672d5bb Author: Yongqiang Sun Date: Fri Feb 19 14:50:23 2021 -0500 drm/amd/display: Implement dmub trace event The analysis is as follows: 400

Re: [PATCH][next] mtd: nand: Fix error handling in nand_prog_page_op

On 03/03/2021 09:46, Miquel Raynal wrote: > Hi Colin, > > Colin King wrote on Wed, 3 Mar 2021 > 09:42:46 +: > >> From: Colin Ian King >> >> The less than zero comparison with status is always false because status >> is a u8. Fix this by using

f2fs_convert_inline_inode causing rebalance based on random uninitialized value in dn.node_changed

Hi, Static analysis on linux-next detected a potential uninitialized variable dn.node_changed that does not get set when a call to f2fs_get_node_page() fails. This uninitialized value gets used in the call to f2fs_balance_fs() that may or not may not balances dirty node and dentry pages depending

Re: [PATCH] memory: gpmc: fix out of bounds read and dereference on gpmc_cs[]

On 02/03/2021 08:44, Krzysztof Kozlowski wrote: > On Tue, Feb 23, 2021 at 07:38:21PM +, Colin King wrote: >> From: Colin Ian King >> >> Currently the array gpmc_cs is indexed by cs before it cs is range checked >> and the pointer read from this out-of-index rea

re: cifs: Retain old ACEs when converting between mode bits and ACL.

Hi, Static analysis on linux-next with Coverity had detected a potential null pointer dereference with the following commit: commit f5065508897a922327f32223082325d10b069ebc Author: Shyam Prasad N Date: Fri Feb 12 04:38:43 2021 -0800 cifs: Retain old ACEs when converting between mode bits

Re: [PATCH] memory: gpmc: fix out of bounds read and dereference on gpmc_cs[]

On 24/02/2021 07:55, Dan Carpenter wrote: > On Tue, Feb 23, 2021 at 07:38:21PM +, Colin King wrote: >> From: Colin Ian King >> >> Currently the array gpmc_cs is indexed by cs before it cs is range checked >> and the pointer read from this out-of-index read is d

NACK: [PATCH][next] tracing/tools: fix spelling mistake "functionph" -> "graph"

On 16/02/2021 14:01, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in the -g help option, I believe > it should be "graph". Fix it. > > Signed-off-by: Colin Ian King > --- > tools/tracing/latency/latency-collector.c | 2 +- &g

re: octeontx2-af: cn10k: MAC internal loopback support

Hi, Static analysis on linux-next today using Coverity found an issue in the following commit: commit 3ad3f8f93c81f81d6e28b2e286b03669cc1fb3b0 Author: Hariprasad Kelam Date: Thu Feb 11 21:28:34 2021 +0530 octeontx2-af: cn10k: MAC internal loopback support The analysis is as follows: 723

Re: [PATCH][next] media: i2c: imx334: Fix a read of the uninitialized variable ret

On 11/02/2021 10:41, Dan Carpenter wrote: > On Wed, Feb 10, 2021 at 11:03:03PM +0200, Sakari Ailus wrote: >> Hi Colin, >> >> On Wed, Feb 10, 2021 at 07:07:52PM +, Colin King wrote: >>> From: Colin Ian King >>> >>> Currently there is a dev_

Re: [PATCH][next] soc: xilinx: vcu: remove deadcode on null divider check

On 11/02/2021 07:31, Michael Tretter wrote: > On Wed, 10 Feb 2021 18:49:38 +, Colin King wrote: >> From: Colin Ian King >> >> The pointer 'divider' has previously been null checked followed by >> a return, hence the subsequent null check is redundant deadc

NAK: [PATCH][next] media: uvcvideo: remove duplicated dma_dev assignment

On 10/02/2021 17:45, Colin King wrote: > From: Colin Ian King > > The assignment to dma_dev has been performed twice in one > statement. Fix this by removing the extraneous assignment. > > Addresses-Coverity: ("Evaluation order violation") > Fixes: fdcd

re: mt76: mt7921: add MCU support

Hi, Static analysis with Coverity on linux-next has found an issue with the following commit: commit 1c099ab44727c8e42fe4de4d91b53cec3ef02860 Author: Sean Wang Date: Thu Jan 28 03:33:39 2021 +0800 mt76: mt7921: add MCU support The analysis is as follows: 390 static void 391 mt7921_mcu_t

Re: [PATCH] HID: logitech-dj: fix unintentional integer overflow on left shift

On 08/02/2021 15:06, Dan Carpenter wrote: > On Sun, Feb 07, 2021 at 11:21:20PM +, Colin King wrote: >> From: Colin Ian King >> >> Shifting the integer value 1 is evaluated using 32-bit rithmetic >> and then used in an expression that expects a 64-bit value, so

Re: [PATCH][next] usb: cdnsp: Fix spelling mistake "delagete" -> "delegate"

On 04/02/2021 09:25, Pawel Laszczak wrote: > > I've sent the patch that remove this one and others similar printk from > driver. Thanks Pawel. Colin > >> >> >> On Thu, Feb 04, 2021 at 05:07:16AM +, Pawel Laszczak wrote: >>> Hi Dan, >>&g

Re: [PATCH][next] Input: iqs5xx: Ensure error_bl is initialized on error exit path

On 28/01/2021 14:39, Jeff LaBundy wrote: > Hi Colin, > > On Thu, Jan 28, 2021 at 12:19:03PM +, Colin King wrote: >> From: Colin Ian King >> >> Currently if the call to qs5xx_fw_file_parse fails the error return >> exit path will read the uninitialized

re: GTP: add support for flow based tunneling API

Hi, Static analysis of today's linux-next using Coverity has found a potential memory leak issue in the following commit: commit 9ab7e76aefc97a9aa664accb59d6e8dc5e52514a Author: Pravin B Shelar Date: Sat Jan 9 23:00:21 2021 -0800 GTP: add support for flow based tunneling API The analysis

Re: [PATCH][next] drm/amdgpu: Add missing BOOTUP_DEFAULT to profile_name[]

On 15/01/2021 10:07, Christophe JAILLET wrote: > Le 15/01/2021 à 10:37, Colin Ian King a écrit : >> On 12/01/2021 10:07, Dan Carpenter wrote: >>> On Mon, Jan 11, 2021 at 11:46:38AM +, Colin King wrote: >>>> From: Colin Ian King >>>> >>>

Re: [PATCH][next] drm/amdgpu: Add missing BOOTUP_DEFAULT to profile_name[]

On 12/01/2021 10:07, Dan Carpenter wrote: > On Mon, Jan 11, 2021 at 11:46:38AM +, Colin King wrote: >> From: Colin Ian King >> >> A recent change added a new BOOTUP_DEFAULT power profile mode >> to the PP_SMC_POWER_PROFILE enum but omitted updating the >>

Re: [PATCH][next] ASoC: soc-pcm: Fix uninitialised return value in variable ret

On 12/01/2021 10:22, Dan Carpenter wrote: > On Mon, Jan 11, 2021 at 05:37:36PM +0000, Colin Ian King wrote: >> On 11/01/2021 16:35, Mark Brown wrote: >>> On Fri, Jan 08, 2021 at 12:35:46PM +, Colin King wrote: >>>> From: Colin Ian King >>>> >>&g

Re: [PATCH][next] ASoC: soc-pcm: Fix uninitialised return value in variable ret

On 11/01/2021 16:35, Mark Brown wrote: > On Fri, Jan 08, 2021 at 12:35:46PM +, Colin King wrote: >> From: Colin Ian King >> >> Currently when attempting to start the BE fails because the >> FE is not started the error return variable ret is not initialized >&

Re: [PATCH][next] ASoC: soc-pcm: Fix uninitialised return value in variable ret

On 11/01/2021 16:35, Mark Brown wrote: > On Fri, Jan 08, 2021 at 12:35:46PM +, Colin King wrote: >> From: Colin Ian King >> >> Currently when attempting to start the BE fails because the >> FE is not started the error return variable ret is not initialized >&

Re: platform/surface: Add Surface Aggregator user-space interface (static analysis issues)

On 11/01/2021 14:37, Maximilian Luz wrote: > On 1/11/21 3:11 PM, Colin Ian King wrote: >> On 11/01/2021 13:55, Maximilian Luz wrote: >>> On 1/11/21 1:12 PM, Colin Ian King wrote: >>>> Hi Maximilian, >>>> >>>> Static analysis of linux-nex

Re: platform/surface: Add Surface Aggregator user-space interface (static analysis issues)

On 11/01/2021 13:55, Maximilian Luz wrote: > On 1/11/21 1:12 PM, Colin Ian King wrote: >> Hi Maximilian, >> >> Static analysis of linux-next with Coverity has found several issues >> with the following commit: >> >> commit 178f6ab77e617c984d6520b92e747075a126

re: platform/surface: Add Surface Aggregator user-space interface (static analysis issues)

Hi Maximilian, Static analysis of linux-next with Coverity has found several issues with the following commit: commit 178f6ab77e617c984d6520b92e747075a12676ff Author: Maximilian Luz Date: Mon Dec 21 19:39:58 2020 +0100 platform/surface: Add Surface Aggregator user-space interface The ana

Re: [PATCH v2] f2fs: fix null page reference in redirty_blocks

On 05/01/2021 04:16, Daeho Jeong wrote: > From: Daeho Jeong > > Fixed null page reference when find_lock_page() fails in > redirty_blocks(). > > Signed-off-by: Daeho Jeong > Reported-by: Colin Ian King > Fixes: 5fdb322ff2c2 ("f2fs: add F2FS_IOC_DECOMPRESS_FILE

re: f2fs: add F2FS_IOC_DECOMPRESS_FILE and F2FS_IOC_COMPRESS_FILE

Hi, Static analysis using Coverity has detected a potential null pointer dereference after a null check in the following commit: commit 5fdb322ff2c2b4ad519f490dcb7ebb96c5439af7 Author: Daeho Jeong Date: Thu Dec 3 15:56:15 2020 +0900 f2fs: add F2FS_IOC_DECOMPRESS_FILE and F2FS_IOC_COMPRESS

[tip: timers/urgent] timekeeping: Fix spelling mistake in Kconfig "fullfill" -> "fulfill"

The following commit has been merged into the timers/urgent branch of tip: Commit-ID: f6f5cd840ae782680c5e94048c72420e4e6857f9 Gitweb: https://git.kernel.org/tip/f6f5cd840ae782680c5e94048c72420e4e6857f9 Author:Colin Ian King AuthorDate:Thu, 17 Dec 2020 17:17:05 Committer

NAK: [PATCH] wilc1000: fix spelling mistake in Kconfig "devision" -> "division"

On 16/12/2020 11:54, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in the Kconfig help text. Fix it. > > Signed-off-by: Colin Ian King > --- > drivers/net/ethernet/ni/Kconfig | 2 +- > drivers/net/wireless/microchip/wilc1000/K

re: scsi: ufs: Serialize eh_work with system PM events and async scan

Hi, Static analysis on linux-next with Coverity had found a potential null pointer dereference issue in the following commit: commit 88a92d6ae4fe09b2b27781178c5c9432d27b1ffb Author: Can Guo Date: Wed Dec 2 04:04:01 2020 -0800 scsi: ufs: Serialize eh_work with system PM events and async sc

Re: [PATCH][next] seg6: fix unintentional integer overflow on left shift

On 07/12/2020 19:59, Andrea Mayer wrote: > On Mon, 7 Dec 2020 14:45:03 + > Colin King wrote: > >> From: Colin Ian King >> >> Shifting the integer value 1 is evaluated using 32-bit arithmetic >> and then used in an expression that expects a unsigned l

Re: media: i2c: add OV02A10 image sensor driver

On 03/12/2020 18:10, Andy Shevchenko wrote: > On Thu, Dec 3, 2020 at 8:03 PM Colin Ian King > wrote: > >> Static analysis on linux-next with Coverity has detected an issue with >> the following commit: > > If you want to fix it properly, see my comments be

re: media: i2c: add OV02A10 image sensor driver

Hi, Static analysis on linux-next with Coverity has detected an issue with the following commit: 529 static int ov02a10_s_stream(struct v4l2_subdev *sd, int on) 530 { 531struct ov02a10 *ov02a10 = to_ov02a10(sd); 532struct i2c_client *client = v4l2_get_subdevdata(&ov02a10->subdev);

Re: ACK: [PATCH 1/1] efi/efi_test: read RuntimeServicesSupported

On 27/11/2020 19:29, Ard Biesheuvel wrote: > On Fri, 27 Nov 2020 at 20:28, Colin Ian King wrote: >> >> On 27/11/2020 19:20, Heinrich Schuchardt wrote: >>> Since the UEFI 2.8A specification the UEFI enabled firmware provides a >>> configuration table EFI_RT_PROPE

ACK: [PATCH 1/1] efi/efi_test: read RuntimeServicesSupported

On 27/11/2020 19:20, Heinrich Schuchardt wrote: > Since the UEFI 2.8A specification the UEFI enabled firmware provides a > configuration table EFI_RT_PROPERTIES_TABLE which indicates which runtime > services are enabled. The EFI stub reads this table and saves the value of > the field RuntimeServic

Re: [PATCH] dma-mapping: Fix sizeof() mismatch on tsk allocation

On 25/11/2020 18:29, Christoph Hellwig wrote: > I'll fold this one in as well. > OK, so two SoB's disappear?

Re: [PATCH][next] drm/kmb: fix array out-of-bounds writes to kmb->plane_status[]

On 16/11/2020 16:53, Chrisanthus, Anitha wrote: > Hi Sam and Colin, > >> -Original Message- >> From: Sam Ravnborg >> Sent: Friday, November 13, 2020 10:02 AM >> To: Colin Ian King >> Cc: Chrisanthus, Anitha ; Dea, Edmund J >>

Re: [PATCH][next] drm/atomic: avoid null pointer dereference on pointer crtc

On 16/11/2020 11:08, Simon Ser wrote: > On Monday, November 16, 2020 12:03 PM, Colin King > wrote: > >> From: Colin Ian King colin.k...@canonical.com >> >> Since moving to the new debug helper functions we now have a debug message >> that dereferences crtc to

Re: [PATCH][V2] PCI: Fix a potential uninitentional integer overflow issue

On 14/11/2020 21:53, Bjorn Helgaas wrote: > [+cc Dan] > > On Tue, Nov 10, 2020 at 10:10:48PM +, Colin King wrote: >> From: Colin Ian King >> >> The shift of 1 by align_order is evaluated using 32 bit arithmetic >> and the result is assigned to a resource_siz

Re: [PATCH][next] drm/kmb: fix array out-of-bounds writes to kmb->plane_status[]

On 13/11/2020 14:55, Sam Ravnborg wrote: > Hi Colin. > > On Fri, Nov 13, 2020 at 12:01:21PM +, Colin King wrote: >> From: Colin Ian King >> >> Writes to elements in the kmb->plane_status array in function >> kmb_plane_atomic_disable are overrunning the a

Re: [PATCH][next] mptcp: fix a dereference of pointer before msk is null checked.

On 11/11/2020 18:49, Mat Martineau wrote: > On Mon, 9 Nov 2020, Colin King wrote: > >> From: Colin Ian King >> >> Currently the assignment of pointer net from the sock_net(sk) call >> is potentially dereferencing a null pointer sk. sk points to the >> sam

[tip: sched/urgent] sched/debug: Fix memory corruption caused by multiple small reads of flags

The following commit has been merged into the sched/urgent branch of tip: Commit-ID: 8d4d9c7b4333abccb3bf310d76ef7ea2edb9828f Gitweb: https://git.kernel.org/tip/8d4d9c7b4333abccb3bf310d76ef7ea2edb9828f Author:Colin Ian King AuthorDate:Thu, 29 Oct 2020 15:11:03 Committer

Re: [PATCH] PCI: fix a potential uninitentional integer overflow issue

t 12:46:15PM +0100, Colin King wrote: >>>>> From: Colin Ian King >>>>> >>>>> The shift of 1 by align_order is evaluated using 32 bit arithmetic >>>>> and the result is assigned to a resource_size_t type variable that >>>>> i

Re: [PATCH][next] cpumask: allocate enough space for string and trailing '\0' char

On 10/11/2020 18:38, Paul E. McKenney wrote: > On Tue, Nov 10, 2020 at 03:34:05PM +0000, Colin Ian King wrote: >> On 10/11/2020 15:24, Paul E. McKenney wrote: >>> On Mon, Nov 09, 2020 at 11:57:15PM -0500, Paul Gortmaker wrote: >>>> >>>> >>>>

Re: [PATCH v2 0/4] support for global CPU list abbreviations

On 10/11/2020 15:32, Paul E. McKenney wrote: > On Mon, Nov 09, 2020 at 11:07:21PM -0500, Paul Gortmaker wrote: >> RFC/v1 ---> v2: >> >> commit #1: >>leave one line stub behind for !SMP solving build failures. >>Reported by Randy Dunlap and various build bots. >> >> commit #4 >>manage to

Re: [PATCH][next] cpumask: allocate enough space for string and trailing '\0' char

On 10/11/2020 15:24, Paul E. McKenney wrote: > On Mon, Nov 09, 2020 at 11:57:15PM -0500, Paul Gortmaker wrote: >> >> >> On 2020-11-09 8:07 p.m., Qian Cai wrote: >>> On Mon, 2020-11-09 at 13:04 +, Colin King wrote: >>>> From: Colin Ian King >&g

Re: net: dsa: hellcreek: Add support for hardware timestamping

On 09/11/2020 13:59, Kurt Kanzenbach wrote: > Hi Colin, > > On Mon Nov 09 2020, Colin Ian King wrote: >> Hi >> >> Static analysis on linux-next with Coverity has detected a potential >> null pointer dereference issue on the following commit: >> >> co

re: net: dsa: hellcreek: Add support for hardware timestamping

Hi Static analysis on linux-next with Coverity has detected a potential null pointer dereference issue on the following commit: commit f0d4ba9eff75a79fccb7793f4d9f12303d458603 Author: Kamil Alkhouri Date: Tue Nov 3 08:10:58 2020 +0100 net: dsa: hellcreek: Add support for hardware timestam

re: scsi: ufs: Try to save power mode change and UIC cmd completion timeout

Hi Static analysis with Coverity on linux-next has detected a potential null pointer deference issue with commit: commit 0f52fcb99ea2738a0a0f28e12cf4dd427069dd2a Author: Can Guo Date: Mon Nov 2 22:24:40 2020 -0800 scsi: ufs: Try to save power mode change and UIC cmd completion timeout T

Re: [PATCH][next] hwmon: corsair-psu: fix unintentional sign extension issue

On 05/11/2020 12:32, Wilken Gottwalt wrote: > On Thu, 5 Nov 2020 11:50:19 + > Colin King wrote: > >> From: Colin Ian King >> >> The shifting of the u8 integer data[3] by 24 bits to the left will >> be promoted to a 32 bit signed int and then sign-extende

re: spi: bcm2835: fix gpio cs level inversion

Hi, Static analysis with coverity on today's linux-next has detected a potential issue in bcm2835_spi_setup() in the following commit: commit 5e31ba0c0543a04483b53151eb5b7413efece94c Author: Martin Hundebøll Date: Wed Oct 14 11:02:30 2020 +0200 spi: bcm2835: fix gpio cs level inversion

Re: [PATCH] ASoC: qcom: sm8250: Fix array out of bounds access

cro. > > Fixes: aa2e2785545a ("ASoC: qcom: sm8250: add sound card qrb5165-rb5 support") > Reported-by: Colin Ian King > Signed-off-by: Srinivas Kandagatla > --- > sound/soc/qcom/sm8250.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/sound

Re: PM / devfreq: map devfreq drivers to governor using name

On 28/10/2020 12:00, Colin Ian King wrote: > Hi, > > Static analysis of linux-next with Coverity has found a potential null > pointer dereference issue with the following commit: > > commit 1b5c1be2c88e8445a20fa1929e26c37e7ca8c926 > Author: Nishanth Menon > Date:

re: PM / devfreq: map devfreq drivers to governor using name

Hi, Static analysis of linux-next with Coverity has found a potential null pointer dereference issue with the following commit: commit 1b5c1be2c88e8445a20fa1929e26c37e7ca8c926 Author: Nishanth Menon Date: Mon Oct 29 15:01:45 2012 -0500 PM / devfreq: map devfreq drivers to governor using n

re: ASoC: qcom: sm8250: add sound card qrb5165-rb5 support

Hi, Static analysis on linux-next with Coverity had detected a potential array out-of-bounds write issue in the following commit: commit aa2e2785545aab21b6cb2e23f111ae0751cbcca7 Author: Srinivas Kandagatla Date: Mon Oct 26 17:09:47 2020 + ASoC: qcom: sm8250: add sound card qrb5165-rb5

Re: [PATCH][next] afs: fix a dereference on pointer cell before cell is null checked

On 27/10/2020 11:05, David Howells wrote: > Colin King wrote: > >> @@ -606,7 +605,7 @@ void afs_unuse_cell(struct afs_net *net, struct afs_cell >> *cell, enum afs_cell_tr >> >> u = atomic_read(&cell->ref); >> a = atomic_dec_return(&cell->active); >> -trace_afs_cell(debug_id, u, a

  1   2   3   4   5   6   >