On Tue, 2019-06-04 at 10:45 +0800, Aaron Ma wrote:
> Hi Christopher:
>
> Have got time to review these 2 patches?
> Users reported it works fine since I sent out this patch.
Hi Aaron,
I've been poking around with this off and on. Unfortunately, more off
than on :-( but here's my current take:
On Thu, 2019-03-28 at 14:02 +0800, Aaron Ma wrote:
> Hi Dmitry and Chiristopher:
>
> Do you have any suggestion about these 2 patches?
>
> Many users confirmed that they fixed issues of Trackpoint/Touchpad
> after S3.
>
> Will you consider them be accepted?
Hi Aaron,
Sorry - I thought I'd repl
On Wed, 2019-02-20 at 17:41 +0100, Aaron Ma wrote:
> CAUTION: Email originated externally, do not click links or open
> attachments unless you recognize the sender and know the content is
> safe.
>
>
> rmi4 got spam data after S3 resume on some ThinkPads.
> Then TrackPoint lost when be detected b
On Wed, 2017-01-11 at 18:48 +0100, Benjamin Tissoires wrote:
> On Jan 11 2017 or thereabouts, Arnd Bergmann wrote:
> >
> > On Wednesday, January 11, 2017 5:28:28 PM CET Benjamin Tissoires
> > wrote:
> > >
> > > Yep, it was initially written that way, and IIRC there was some
> > > issues
> > > dep
Chris
>
> On Thu, Oct 20, 2016 at 4:28 PM, Christopher Heiny com> wrote:
> > On Thu, 2016-10-20 at 23:51 +0100, Nick Dyer wrote:
> > > On Mon, Oct 17, 2016 at 02:30:08PM -0700, Guenter Roeck wrote:
> > > >
> > > > On Fri, Sep 30, 20
On Thu, 2016-10-20 at 23:51 +0100, Nick Dyer wrote:
> On Mon, Oct 17, 2016 at 02:30:08PM -0700, Guenter Roeck wrote:
> >
> > On Fri, Sep 30, 2016 at 08:22:47PM -0700, Guenter Roeck wrote:
> > >
> > > Sensor tuning support is needed to determine the number of
> > > enabled
> > > tx and rx electrod
On 07/22/2014 11:11 PM, Dmitry Torokhov wrote:
Signed-off-by: Dmitry Torokhov
I've reviewed this, and can say:
Acked-by: Christopher Heiny
but I haven't had a chance to apply it to my build tree.
Andrew - I'll be OOO for a couple of days. Can you do that, and add a
Tested
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
Do not write configuration data in probe(), we have config() for that.
I've just submitted a patch to correctly call config() after probe().
So this becomes...
Signed-off-by: Christopher Heiny
Signed-off-by: Dmitry Torokhov
---
dr
On 02/17/2014 11:23 AM, Dmitry Torokhov wrote:
On Fri, Feb 14, 2014 at 03:00:43PM -0800, Christopher Heiny wrote:
On 02/13/2014 01:54 PM, Dmitry Torokhov wrote:
On Thu, Feb 13, 2014 at 11:23:44AM -0800, Christopher Heiny wrote:
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
Do not write
On 02/13/2014 01:54 PM, Dmitry Torokhov wrote:
On Thu, Feb 13, 2014 at 11:23:44AM -0800, Christopher Heiny wrote:
>On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
> >Do not write configuration data in probe(), we have config() for that.
>
>Then we should call config() in rmi
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
It is not used by anyone.
Signed-off-by: Dmitry Torokhov
Acked-by: Christopher Heiny
---
drivers/input/rmi4/rmi_f01.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/input/rmi4/rmi_f01.c b/drivers/input/rmi4/rmi_f01.c
index
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
We have too many "data"s: f01_data, driver_data, pdata, etc. Let's
untangle it a bit.
Signed-off-by: Dmitry Torokhov
Acked-by: Christopher Heiny
---
drivers/input/rmi4/rmi_f01.c | 135 ++---
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
Use rmi_read()/rmi_write() for reading/writing single-byte data. Also print
error code when IO fails.
Signed-off-by: Dmitry Torokhov
Acked-by: Christopher Heiny
---
drivers/input/rmi4/rmi_f01.c | 170
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
Device core provides way of accessing driver-private data, we should
use it.
Signed-off-by: Dmitry Torokhov
Acked-by: Christopher Heiny
---
drivers/input/rmi4/rmi_bus.h | 1 -
drivers/input/rmi4/rmi_f01.c | 14 +--
drivers/input
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
We do not need to persist it - we read it when signalled.
Signed-off-by: Dmitry Torokhov
Acked-by: Christopher Heiny
---
drivers/input/rmi4/rmi_f01.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a
We'll want to look at some of our other #define
accessors as well, I think.
Signed-off-by: Christopher Heiny
Signed-off-by: Dmitry Torokhov
---
drivers/input/rmi4/rmi_bus.h| 7 ++-
drivers/input/rmi4/rmi_driver.c | 8
drivers/input/rmi4/rmi_f01.c| 2 +-
dri
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
Let's allocate interrupt mask together with the main structure and combine
rmi_f01_alloc_memory, rmi_f01_initialize and rmi_f01_probe into single
function.
Signed-off-by: Dmitry Torokhov
Signed-off-by: Christopher Heiny
---
drivers/
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
From: Christopher Heiny
Both F01_RMI_Ctrl2 and F01_RMI_Ctrl3 (doze_interval and wakeup_threshold)
are controlled by the has_adjustable_doze bit.
Signed-off-by: Christopher Heiny
Signed-off-by: Dmitry Torokhov
Not sure if this need an Ack, but
return error;
- }
} else {
error = rmi_read(rmi_dev, data->doze_holdoff_addr,
&data->device_control.doze_holdoff);
--
Christopher Heiny
Senior Staff Firmware Engineer
Synaptics Incorporated
--
To unsubscri
On 02/12/2014 09:27 PM, Dmitry Torokhov wrote:
It is an empty stub and is not needed.
Signed-off-by: Dmitry Torokhov
Signed-off-by: Christopher Heiny
---
drivers/input/rmi4/rmi_f01.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/input/rmi4/rmi_f01.c b/drivers/input
: Christopher Heiny
---
drivers/input/rmi4/rmi_f01.c | 23 +--
1 file changed, 9 insertions(+), 14 deletions(-)
diff --git a/drivers/input/rmi4/rmi_f01.c b/drivers/input/rmi4/rmi_f01.c
index 381ad60..92b90d1 100644
--- a/drivers/input/rmi4/rmi_f01.c
+++ b/drivers/input
On 02/03/2014 11:56 PM, Linus Walleij wrote:
On Sat, Jan 19, 2013 at 2:12 AM, Christopher Heiny wrote:
This patchset implements changes based on the synaptics-rmi4 branch of
Dmitry's input tree.
What is happening to the RMI4 driver stuff?
Has this development stalled? The bran
nt->dev,
- "read %zd bytes at %#06x: %*ph\n",
- len, addr, (int)len, buf);
+ xport->stats.rx_bytes += len;
-exit:
mutex_unlock(&rmi_i2c->page_mutex);
return retval;
}
--
Christopher Heiny
Senior Staff Firm
proper
tyep - size_t.
Also rename rmi_transport_info to rmi_transport_stats and move protocol
name (which is the only immutable piece of data there) into the transport
device itself.
Acked-by: Christopher Heiny
Signed-off-by: Dmitry Torokhov
---
drivers/input/rmi4/rmi_bus.h| 64
On 01/09/2014 11:44 PM, Dmitry Torokhov wrote:
When adapter does not support required functionality (I2C_FUNC_I2C) we were
returning 0 to the upper layers, making them believe that device bound
successfully.
Acked-by: Christopher Heiny
Signed-off-by: Dmitry Torokhov
---
drivers/input
ked-by: Christopher Heiny
Signed-off-by: Dmitry Torokhov
---
drivers/input/rmi4/rmi_bus.h | 3 --
drivers/input/rmi4/rmi_i2c.c | 112 +--
2 files changed, 56 insertions(+), 59 deletions(-)
diff --git a/drivers/input/rmi4/rmi_bus.h b/drivers/input/rmi4/rmi
ssful on some older platforms. I've tested it on
some more current platforms, though, and it works there. The old
platforms are running 2.6.xx series kernels, and don't look likely ever
to be updated, So....
Acked-by: Christopher Heiny
Signed-off-by: Dmitry Torokhov
---
dri
Sorry if this is a duplicate - there's some email issues here at work.
On 07/08/2013 03:39 PM, Dmitry Torokhov wrote:
> On Monday, July 08, 2013 10:21:16 PM Christopher Heiny wrote:
>> On 07/08/2013 01:25 AM, Balint Czobor wrote:
>>> Add initial support for Synap
On 07/08/2013 01:25 AM, Balint Czobor wrote:
> Add initial support for Synaptics RMI over I2C based touchscreens.
This is pretty old code - it looks like a modification of patches we
submitted last year. Is there some reason you're not basing it off the
latest checkins in synaptics-rmi4 branch of
On 01/31/2013 01:14 PM, Christopher Heiny wrote:
On 01/31/2013 12:08 AM, Dmitry Torokhov wrote:
Hi Chris,
On Fri, Jan 18, 2013 at 05:12:44PM -0800, Christopher Heiny wrote:
In addition to the changes described in 0/0 of this patchset, this patch
includes device serialization updated to
On 01/31/2013 12:08 AM, Dmitry Torokhov wrote:
Hi Chris,
On Fri, Jan 18, 2013 at 05:12:44PM -0800, Christopher Heiny wrote:
In addition to the changes described in 0/0 of this patchset, this patch
includes device serialization updated to conform to the latest RMI4
specification.
I was
Changes here are limited to those described in the 0/5 of this patchset, plus
some tweaks to debugging output.
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
drivers/input/rmi4/rmi_i2c.c | 141
In addition to the changes described in 0/0 of this patchset, this patch
includes device serialization updated to conform to the latest RMI4
specification.
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
drivers/input
his is the last time we'll have wide-ranging structural changes in
the driver code, and future patchsets can be much smaller and confined to
one or two areas of interest.
Comments and other feedback on this driver are welcomed.
Christopher Heiny and the Synaptics RMI4 driver team
Signed-off-
order to account for the fact that the PDT may change after
the initial reset.
* Problems with release_rmidev_device() identified by Greg KH are fixed and
tested.
* EXPORT_SYMBOL() changed to EXPORT_SYMBOL_GPL(), per Greg KH input.
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus
In addition to the changes described in part 0/5, this fixes some cut&paste
issues in the comments for module_rmi_function_driver.
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
include/linux/rmi.h |
order to account for the fact that the PDT may change after
the initial reset.
* Problems with release_rmidev_device() identified by Greg KH are fixed and
tested.
* EXPORT_SYMBOL() changed to EXPORT_SYMBOL_GPL(), per Greg KH input.
Signed-off-by: Christopher Heiny
Cc: Greg Kroah-Hartman
Cc: Dmitry
In addition to the changes described in 0/0 of this patchset, this patch
includes:
* changes to the handling of sysfs as requested in feedback to our
previous patch.
* device serialization updated to conform to the latest specification.
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc
In addition to the changes described in part 0/5, this fixes some cut&paste
issues in the comments for module_rmi_function_driver.
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
include/linux/rmi.h |
Changes here are limited to those described in the 0/0 of this patchset, plus
some tweaks to debugging output.
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
drivers/input/rmi4/rmi_i2c.c | 141
In addition to the changes described in 0/0 of this patchset, this patch
includes:
* elimination of unused sysfs and debugfs parameters.
* some fixes to the input device parameters.
* removal of some stray Android stuff.
Signed-off-by: Christopher Heiny
To: Henrik Rydberg
Cc: Dmitry Torokhov
d future patchsets can be much smaller and confined to
one or two areas of interest.
Comments and other feedback on this driver are welcomed.
Christopher Heiny and the Synaptics RMI4 driver team
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Jean Delvare
Cc: Linus Walleij
Cc: Jo
give these changes a try,
possibly with some slight modifications.
Thanks!
Chris
From: linux-input-ow...@vger.kernel.org [linux-input-ow...@vger.kernel.org] on
behalf of Dmitry Torokhov [dmitry.torok...@gmail.com]
Sent: Thursday, November 29, 2012 9:21 AM
error);
+ return error;
}
- return retval;
+ return 0;
}
-static void __exit rmi_driver_exit(void)
+void __exit rmi_unregister_sensor_driver(void)
{
bus_unregister_notifier(&rmi_bus_type, &rmi_bus_notifier);
- driver_unregister(&sensor_driver.driver);
+
On 11/27/2012 01:29 AM, Dmitry Torokhov wrote:
On Mon, Nov 26, 2012 at 02:31:27PM -0800, Christopher Heiny wrote:
>On 11/26/2012 01:40 AM, Dmitry Torokhov wrote:
> >Hi Christopher,
> >
> >On Fri, Nov 16, 2012 at 07:58:53PM -0800, Christopher Heiny wrote:
> >>RM
atic void __exit rmi_f11_module_exit(void)
-{
- rmi_unregister_function_handler(&rmi_f11_handler);
-}
-
-module_init(rmi_f11_module_init);
-module_exit(rmi_f11_module_exit);
+module_rmi_driver(rmi_f11_handler);
MODULE_AUTHOR("Christopher Heiny
--
Christopher Heiny
Senior Staff
On 11/27/2012 01:21 AM, Dmitry Torokhov wrote:
To save my old fingers...
Signed-off-by: Dmitry Torokhov
---
It looks like this driver(s) need some love and I might have some time so I
will refresh my "synaptics" branch with the patches you have sent and start
working off it. If you have updates
On 11/26/2012 10:41 AM, Benjamin Tissoires wrote:
Hi Christopher,
On Sat, Nov 17, 2012 at 4:58 AM, Christopher Heiny wrote:
rmi_bus.c implements the basic functionality of the RMI bus. This file is
greatly simplified compared to the previous patch - we've switched from
"do i
On 11/26/2012 01:40 AM, Dmitry Torokhov wrote:
Hi Christopher,
On Fri, Nov 16, 2012 at 07:58:53PM -0800, Christopher Heiny wrote:
RMI Function 01 implements basic device control and power management
behaviors for the RMI4 sensor.
rmi_f01.h exports definitions that we expect to be used by
On 11/17/2012 01:54 PM, Greg Kroah-Hartman wrote:
On Fri, Nov 16, 2012 at 07:58:50PM -0800, Christopher Heiny wrote:
+static void release_rmidev_device(struct device *dev)
+{
+ device_unregister(dev);
+}
You just leaked memory here, right?
Also, you already unregistered the device
at we seek your input on these core
files, particularly the bus implementation.
Signed-off-by: Christopher Heiny
Cc: Greg Kroah-Hartman
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Naveen Kumar Gaddipati
Cc: Joeri de Gram
---
drivers/input/rmi4/rmi_bus.c| 248 ++
drivers/input/rm
RMI Function 01 implements basic device control and power management
behaviors for the RMI4 sensor.
rmi_f01.h exports definitions that we expect to be used by other functionality
in the future (such as firmware reflash).
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
device).
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Naveen Kumar Gaddipati
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
drivers/input/rmi4/rmi_i2c.c | 490 ++
1 files changed, 490 insertions(+), 0 deletions(-)
diff
Infrastructure files for configuration and building.
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Naveen Kumar Gaddipati
Cc: Joeri de Gram
---
drivers/input/Kconfig |2 +
drivers/input/Makefile |3 ++
drivers/input/rmi4/Kconfig | 76
rmi.h provides public definitions required by the RMI bus implementation and
modules that interact with it.
debugfs and sysfs attributes are documented in files in
Documentation/ABI/testing. There's two files, one for debugfs and one for
sysfs.
Signed-off-by: Christopher Heiny
Cc: D
s:
01 - public header files and documentation
02 - core sensor and bus implementation
03 - I2C physical layer driver
04 - Kconfigs and Makefiles
05..06 - drivers for individual RMI functions
Comments and other feedback on this driver are welcomed.
Christopher Heiny and the Synapt
On 10/10/2012 11:21 AM, Henrik Rydberg wrote:
Hi Christopher,
rmi_f11.c is a driver for 2D touch sensors. It has been updated to support
the MT-B specification, partition control attributes between debugfs andsysfs,
and to use the standard bus model for loading/unloading.
Please find comment
On 10/23/2012 05:11 PM, Dmitry Torokhov wrote:
On Tuesday, October 23, 2012 04:46:28 PM Christopher Heiny wrote:
On 10/11/2012 01:13 AM, Dmitry Torokhov wrote:
On Thu, Oct 11, 2012 at 04:15:56AM +, Christopher Heiny wrote:
On Thursday, October 11, 2012 02:21:53 AM you wrote:
On Sat, Oct
On 10/11/2012 01:13 AM, Dmitry Torokhov wrote:
On Thu, Oct 11, 2012 at 04:15:56AM +, Christopher Heiny wrote:
On Thursday, October 11, 2012 02:21:53 AM you wrote:
On Sat, Oct 6, 2012 at 6:09 AM, Christopher Heiny wrote:
+
+/** This is here because all those casts made for some ugly
On 10/15/2012 11:26 PM, Mark Brown wrote:
On Thu, Oct 11, 2012 at 05:32:59PM +0200, Linus Walleij wrote:
On Thu, Oct 11, 2012 at 5:41 AM, Christopher Heiny wrote:
In previous patch submissions, we always used these warning functions.
But in the feedback on those patches, we were asked to
On 10/11/2012 08:32 AM, Linus Walleij wrote:
On Thu, Oct 11, 2012 at 5:41 AM, Christopher Heiny wrote:
Linus Walleij wrote:
But please use arithmetic operators (I think I said this on the last
review):
dest[0] = src & 0xFF;
dest[1] = src >> 8;
Doing it the above way makes artith
On 10/11/2012 01:24 AM, Dmitry Torokhov wrote:
On Thu, Oct 11, 2012 at 03:41:41AM +, Christopher Heiny wrote:
>Linus Walleij wrote:
> >On Sat, Oct 6, 2012 at 6:09 AM, Christopher Heiny
wrote:
> >
> > >+#ifdef CONFIG_RMI4_DEBUG
> > >+/**
> > >+
On 10/11/2012 01:20 AM, Dmitry Torokhov wrote:
On Fri, Oct 05, 2012 at 09:09:58PM -0700, Christopher Heiny wrote:
+
+ int (*write_block)(struct rmi_phys_device *phys, u16 addr, u8 *buf,
+ int len);
+ int (*read_block)(struct rmi_phys_device *phys, u16 addr
On 10/11/2012 10:16 PM, Mark Brown wrote:
On Thu, Oct 11, 2012 at 03:56:22AM +, Christopher Heiny wrote:
Fix your mailer to word wrap within paragraphs.
Sorry - I was on the road and had to use a web interface. It looked OK
during composition. Is this better?
>If this feature i
On 10/10/2012 08:06 PM, Joe Perches wrote:
On Thu, 2012-10-11 at 02:49 +, Christopher Heiny wrote:
Joe Perches wrote:
[]
+ list_for_each_entry(entry, &data->rmi_functions.list, list)
+ if (entry->irq_mask)
+ process_one_interrupt(entry,
Linus Walleij wrote:
> On Sat, Oct 6, 2012 at 6:10 AM, Christopher Heiny
> wrote:
>
> So looking closer at this one since we will use it. Maybe it's in such a
> good shape now that I should be able to actually test it with the hardware?
Well, it's been possible to test
Linus Walleij wrote:
> On Sat, Oct 6, 2012 at 6:10 AM, Christopher Heiny
> wrote:
> > RMI Function 01 implements basic device control and power management
> > behaviors for the RMI4 sensor. Since the last patch, we've decoupled
> > rmi_f01.c implementation from rm
Linus Walleij wrote:
> On Sat, Oct 6, 2012 at 6:10 AM, Christopher Heiny
> wrote:
>
> (...)
>
> > diff --git a/drivers/input/rmi4/Kconfig b/drivers/input/rmi4/Kconfig
>
> (...)
>
> > +config RMI4_DEBUG
> > + bool "RMI4 Debugging"
Linus Walleij wrote:
> On Sat, Oct 6, 2012 at 6:10 AM, Christopher Heiny
> wrote:
> > The I2C physical driver is not extensively changed in terms of
> > functionality since the previous patch. Management of the attention GPIO
> > has been moved to rmi_driver.c (see prev
On Thursday, October 11, 2012 02:21:53 AM you wrote:
> On Sat, Oct 6, 2012 at 6:09 AM, Christopher Heiny
> wrote:
> > rmi_bus.c implements the basic functionality of the RMI bus. This file is
> > greatly simplified compared to the previous patch - we've switched from
>
Mark Brown wrote:
> On Tue, Oct 09, 2012 at 09:43:13AM +0200, Linus Walleij wrote:
> > On Sat, Oct 6, 2012 at 6:09 AM, Christopher Heiny
> > wrote:
> > > + * @cs_assert - For systems where the SPI subsystem does not control
> > > the CS/SSB + * line, or wher
Linus Walleij wrote:
> On Sat, Oct 6, 2012 at 6:09 AM, Christopher Heiny
> wrote:
> > As requested in the feedback from the previous patch, we've documented the
> > debugfs and sysfs attributes in files in
> > Documentation/ABI/testing. There's two files, one
Joe Perches wrote:
> On Fri, 2012-10-05 at 21:09 -0700, Christopher Heiny wrote:
> []
>
> Just some trivial comments:
Thanks - see below for responses.
> > diff --git a/drivers/input/rmi4/rmi_driver.c
> > b/drivers/input/rmi4/rmi_driver.c
> []
>
> > @@ -0
Not much to say here, except that we've reduced the number of different
Kconfig options, which will hopefully make it easier to configure RMI4
support in kernels.
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Naveen Kumar Gaddipati
Cc: Joeri de
umber of attributes have been moved from sysfs to
debugfs, depending on their expected use.
rmi_f01.h exports definitions that we expect to be used by other functionality
in the future (such as firmware reflash).
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: N
As requested in the feedback from the previous patch, we've documented the
debugfs and sysfs attributes in files in Documentation/ABI/testing. There's
two files, one for debugfs and one for sysfs.
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Na
features has been
moved from compile-time to runtime switches available via debugfs.
The core I2C functionality was previously ACKed by Jean Delvare. I don't
believe that portion of the code has changed much since then, but we'd
appreciate a second glance at this.
Signed-off-by: Christopher
lic header files and documentation
02 - core sensor and bus implementation
03 - I2C physical layer driver
04 - Kconfigs and Makefiles
05..06 - drivers for individual RMI functions
Comments and other feedback on this driver are welcomed.
Christopher Heiny and the Synaptics RMI4 driver
Sorry about the delay in following up on this one - we're going over the
feedback, and realized we'd missed this comment.
On 08/23/2012 01:55 AM, Linus Walleij wrote:
+/* Create templates for given types */
>+#define simple_show_union_struct_unsigned(regtype, propname)\
>+simple_show_union_str
series
- S730X series
- S22xx series
The driver supports multifinger pointing functionality and power management.
The driver is based on the original work submitted by
Linus Walleij and
Naveen Kumar Gaddipati .
Naveen's driver is sitting in drivers/staging/ste_rmi4 right now because
Christ
On 08/27/2012 04:01 PM, Linus Walleij wrote:
>Signed-off-by: Christopher Heiny
>+#include
>+#include
>+#include
>+#include
>+#include
>+#include
This is not using the existing in-kernel framework for ADC (which I think is
what you're doing), in this case use th
On 08/27/2012 03:58 PM, Linus Walleij wrote:
GPIO/LED, nice since I'm a GPIO maintainer I'll take a closer look.
If the bus will start doing a lot of non-input business it should live under
drivers/mfd but I think this is just one exception, right?
On Fri, Aug 17, 2012 at 3:17 PM, C
On 08/27/2012 11:49 AM, Linus Walleij wrote:
On Fri, Aug 17, 2012 at 3:17 PM, Christopher Heiny wrote:
Driver for Synaptics touchscreens using RMI4 protocol.
Really? This looks more like some custom char driver to get a pipe
into the device from userspace. Put in a proper description of
On 08/27/2012 03:07 PM, Linus Walleij wrote:
[snip]
>+static struct device_attribute attrs[] = {
>+ __ATTR(status, RMI_RW_ATTR,
>+ rmi_f09_status_show, rmi_f09_status_store),
>+ __ATTR(limitRegisterCount, RMI_RO_ATTR,
>+ rmi_f09_limit_register_count_show,
On 08/22/2012 05:50 AM, Linus Walleij wrote:
On Sat, Aug 18, 2012 at 12:17 AM, Christopher Heiny
wrote:
>This patch implements a driver supporting Synaptics ClearPad and other
>touchscreen sensors that use the RMI4 protocol, as defined here:
Nice!
>This patch is against the v2.6.
On 08/22/2012 02:45 PM, Dmitry Torokhov wrote:
On Wednesday, August 22, 2012 09:08:00 PM Linus Walleij wrote:
>On Sat, Aug 18, 2012 at 12:17 AM, Christopher Heiny
> wrote:
>
> >+/* Helper fn to convert a byte array representing a short in the RMI
> >+ * endian-ness to
On 08/22/2012 05:50 AM, Linus Walleij wrote:
On Sat, Aug 18, 2012 at 12:17 AM, Christopher Heiny
wrote:
This patch implements a driver supporting Synaptics ClearPad and other
touchscreen sensors that use the RMI4 protocol, as defined here:
Nice!
This patch is against the v2.6.38 tag of
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Naveen Kumar Gaddipati
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
drivers/input/rmi4/rmi_f30.c | 1247 ++
1 files changed, 1247 insertions(+), 0 deletions(-)
diff --git
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Naveen Kumar Gaddipati
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
drivers/input/rmi4/rmi_f1a.c | 1025 ++
1 files changed, 1025 insertions(+), 0 deletions(-)
diff --git
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Naveen Kumar Gaddipati
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
drivers/input/rmi4/rmi_f41.c | 1020 ++
1 files changed, 1020 insertions(+), 0 deletions(-)
diff --git
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Naveen Kumar Gaddipati
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
drivers/input/rmi4/rmi_f34.c | 917 ++
drivers/input/rmi4/rmi_f34.h | 74
2 files changed, 991
Driver for Synaptics touchscreens using RMI4 protocol.
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Naveen Kumar Gaddipati
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
drivers/input/rmi4/rmi_dev.c | 448 ++
1 files
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Naveen Kumar Gaddipati
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
Documentation/input/rmi4.txt | 25 ++
Documentation/input/rmidev.txt | 144 +
Documentation/input/rmisysfs.txt | 200
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Naveen Kumar Gaddipati
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
drivers/input/rmi4/rmi_f01.c | 1331 ++
drivers/input/rmi4/rmi_f01.h | 88 +++
2 files changed, 1419
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Naveen Kumar Gaddipati
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
drivers/input/rmi4/rmi_i2c.c | 452 +
drivers/input/rmi4/rmi_spi.c | 911 ++
2
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Naveen Kumar Gaddipati
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
drivers/input/rmi4/rmi_f21.c | 832 ++
1 files changed, 832 insertions(+), 0 deletions(-)
diff --git a
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Naveen Kumar Gaddipati
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
drivers/input/rmi4/rmi_f19.c | 869 ++
1 files changed, 869 insertions(+), 0 deletions(-)
diff --git a
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Naveen Kumar Gaddipati
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
drivers/input/rmi4/rmi_f09.c | 772 ++
1 files changed, 772 insertions(+), 0 deletions(-)
diff --git a
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Naveen Kumar Gaddipati
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
drivers/input/rmi4/rmi_fw_update.c | 724
1 files changed, 724 insertions(+), 0 deletions(-)
diff --git a
Signed-off-by: Christopher Heiny
Cc: Dmitry Torokhov
Cc: Linus Walleij
Cc: Naveen Kumar Gaddipati
Cc: Joeri de Gram
Acked-by: Jean Delvare
---
drivers/input/rmi4/rmi_f17.c | 713 ++
1 files changed, 713 insertions(+), 0 deletions(-)
diff --git a
1 - 100 of 102 matches
Mail list logo
