[PATCH 0/2] hwmon: (ucd9000) Add sysfs interface to clear logged faults

2017-08-30 Thread Christopher Bostic
This set covers changes required to allow user space to clear logged faults on ucd9000 type devices via sysfs. A write to this new file with any value will perform the clear operation. Patch 1: Document new sysfs file. Patch 2: Implementation of new file and clear process. Christopher Bostic

[PATCH 1/2] hwmon: (ucd9000) Add support for clearing logged faults via sysfs

2017-08-30 Thread Christopher Bostic
Create an attribute to allow clearing of logged faults. Signed-off-by: Christopher Bostic --- Documentation/hwmon/ucd9000 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/hwmon/ucd9000 b/Documentation/hwmon/ucd9000 index 262e713..de7f7f23 100644 --- a/Documentation/hwmon

[PATCH 2/2] hwmon: (ucd9000) Add sysfs attribute to clear logged faults

2017-08-30 Thread Christopher Bostic
Add ability to clear logged faults via sysfs. Signed-off-by: Christopher Bostic --- drivers/hwmon/pmbus/ucd9000.c | 45 ++- 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/pmbus/ucd9000.c b/drivers/hwmon/pmbus/ucd9000.c index

Re: [PATCH v5 0/6] drivers/i2c: Add FSI-attached I2C master algorithm

2017-08-15 Thread Christopher Bostic
On 8/15/17 3:10 AM, Joel Stanley wrote: On Tue, Aug 15, 2017 at 4:06 PM, Peter Rosin wrote: On 2017-07-26 19:13, Eddie James wrote: From: "Edward A. James" This series adds an algorithm for an I2C master physically located on an FSI slave device. The I2C master has multiple ports, each of

[PATCH v5 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-07-17 Thread Christopher Bostic
dog timeout. Signed-off-by: Christopher Bostic --- v5 - Add explicit check for property type "none". Return error if property type is not a known value. - Default reset type when no property present changed to match original code: SOC + SYSTEM reset v4 - Change the three

[PATCH v5 1/2] drivers/watchdog: Add optional ASPEED device tree properties

2017-07-17 Thread Christopher Bostic
y) * aspeed,alt-boot - Boot from alternate block on signal Signed-off-by: Christopher Bostic --- v5 - Removed aspeed,interrupt property - no plans at this point to need this functionality in the driver. v4 - Add aspeed-reset-type and assign one of four values, cpu, soc, system, none.

[PATCH v5 0/2] Add ASPEED watchdog device tree properties

2017-07-17 Thread Christopher Bostic
Document device tree optional properties for ASPEED watchdog. Reference properties in ASPEED watchdog driver and configure accordingly. Christopher Bostic (2): drivers/watchdog: Add optional ASPEED device tree properties drivers/watchdog: ASPEED reference dev tree properties for config

Re: [v4, 1/2] drivers/watchdog: Add optional ASPEED device tree properties

2017-07-10 Thread Christopher Bostic
On 7/8/17 9:59 AM, Guenter Roeck wrote: On Thu, Jul 06, 2017 at 07:48:59PM -0500, Christopher Bostic wrote: Describe device tree optional properties: * aspeed,reset-type = "cpu|soc|system|none" One of three different, mutually exclusive, values "cpu"

Re: [v4, 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-07-10 Thread Christopher Bostic
On 7/8/17 9:55 AM, Guenter Roeck wrote: On Thu, Jul 06, 2017 at 07:49:00PM -0500, Christopher Bostic wrote: Reference the system device tree when configuring the watchdog engines. If property 'aspeed,reset_type' is present then set reset behavior based on the specified value. This

[PATCH v4 1/2] drivers/watchdog: Add optional ASPEED device tree properties

2017-07-06 Thread Christopher Bostic
Generate external signal (WDT1 and WDT2 only) * aspeed,alt-boot - Boot from alternate block on signal Signed-off-by: Christopher Bostic --- v4 - Add aspeed-reset-type and assign one of four values, cpu, soc, system, none. v3 - Invert soc and sys reset to 'no' to preserve b

[PATCH v4 0/2] Add ASPEED watchdog device tree properties

2017-07-06 Thread Christopher Bostic
Document device tree optional properties for ASPEED watchdog. Reference properties in ASPEED watchdog driver and configure accordingly. Christopher Bostic (2): drivers/watchdog: Add optional ASPEED device tree properties drivers/watchdog: ASPEED reference dev tree properties for config

[PATCH v4 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-07-06 Thread Christopher Bostic
dog timeout. Signed-off-by: Christopher Bostic --- v4 - Change the three reset type parameters to a new property 'aspeed,reset_type' and check assignment for one of four different values, cpu, soc, system, none v3 - Invert the logic for system reset dev tree property to pr

Re: [PATCH v3 1/2] drivers/watchdog: Add optional ASPEED device tree properties

2017-07-06 Thread Christopher Bostic
On 7/6/17 3:48 PM, Guenter Roeck wrote: On Thu, Jul 06, 2017 at 02:27:18PM -0500, Christopher Bostic wrote: On 7/6/17 9:35 AM, Rob Herring wrote: On Thu, Jun 29, 2017 at 08:04:17AM -0700, Guenter Roeck wrote: On Thu, Jun 29, 2017 at 08:39:59AM -0500, Christopher Bostic wrote: On 6/28/17

Re: [PATCH v3 1/2] drivers/watchdog: Add optional ASPEED device tree properties

2017-07-06 Thread Christopher Bostic
On 7/6/17 9:35 AM, Rob Herring wrote: On Thu, Jun 29, 2017 at 08:04:17AM -0700, Guenter Roeck wrote: On Thu, Jun 29, 2017 at 08:39:59AM -0500, Christopher Bostic wrote: On 6/28/17 10:33 PM, Guenter Roeck wrote: On 06/28/2017 05:28 PM, Christopher Bostic wrote: Describe device tree

Re: [PATCH v3 1/2] drivers/watchdog: Add optional ASPEED device tree properties

2017-06-29 Thread Christopher Bostic
On 6/28/17 10:33 PM, Guenter Roeck wrote: On 06/28/2017 05:28 PM, Christopher Bostic wrote: Describe device tree optional properties: * aspeed,arm-reet - ARM CPU reset on signal * aspeed,no-soc-reset - SOC reset on signal * aspeed,no-sys-reset - System reset on signal * aspeed

[PATCH v3 1/2] drivers/watchdog: Add optional ASPEED device tree properties

2017-06-28 Thread Christopher Bostic
WDT2 only) * aspeed,alt-boot - Boot from alternate block on signal Signed-off-by: Christopher Bostic --- v3 - Invert soc and sys reset to 'no' to preserve backwards compatibility. SOC and SYS reset will be set by default without any optional parameters set v2 - Add 'asp

[PATCH v3 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-06-28 Thread Christopher Bostic
do not set soc reset mode. Signed-off-by: Christopher Bostic --- v3 - Invert the logic for system reset dev tree property to preserve backwards compatibility. If not specified the default is to configure for system reset - Add check for 'aspeed,no-soc-reset' property and o

[PATCH v3 0/2] Add ASPEED watchdog device tree properties

2017-06-28 Thread Christopher Bostic
Document device tree optional properties for ASPEED watchdog. Reference properties in ASPEED watchdog driver and configure accordingly. Christopher Bostic (2): drivers/watchdog: Add optional ASPEED device tree properties drivers/watchdog: ASPEED reference dev tree properties for config

Re: [PATCH v2 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-06-28 Thread Christopher Bostic
On 6/28/17 11:06 AM, Guenter Roeck wrote: On Wed, Jun 28, 2017 at 10:55:08AM -0500, Christopher Bostic wrote: On 6/28/17 10:08 AM, Guenter Roeck wrote: On Wed, Jun 28, 2017 at 09:59:22AM -0500, Christopher Bostic wrote: On 6/28/17 9:54 AM, Guenter Roeck wrote: On Wed, Jun 28, 2017 at 09

Re: [PATCH v2 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-06-28 Thread Christopher Bostic
On 6/28/17 10:08 AM, Guenter Roeck wrote: On Wed, Jun 28, 2017 at 09:59:22AM -0500, Christopher Bostic wrote: On 6/28/17 9:54 AM, Guenter Roeck wrote: On Wed, Jun 28, 2017 at 09:29:50AM -0500, Christopher Bostic wrote: On 6/28/17 6:31 AM, Guenter Roeck wrote: On 06/27/2017 02:17 PM

Re: [PATCH v2 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-06-28 Thread Christopher Bostic
On 6/28/17 9:54 AM, Guenter Roeck wrote: On Wed, Jun 28, 2017 at 09:29:50AM -0500, Christopher Bostic wrote: On 6/28/17 6:31 AM, Guenter Roeck wrote: On 06/27/2017 02:17 PM, Christopher Bostic wrote: Reference the system device tree when configuring the watchdog engines. Set external

Re: [PATCH v2 1/2] drivers/watchdog: Add optional ASPEED device tree properties

2017-06-28 Thread Christopher Bostic
On 6/27/17 5:07 PM, Guenter Roeck wrote: On Tue, Jun 27, 2017 at 04:42:24PM -0500, Christopher Bostic wrote: On 6/27/17 4:32 PM, Guenter Roeck wrote: On Tue, Jun 27, 2017 at 04:17:33PM -0500, Christopher Bostic wrote: Describe device tree optional properties: * aspeed,arm-reet - ARM

Re: [PATCH v2 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-06-28 Thread Christopher Bostic
On 6/28/17 6:31 AM, Guenter Roeck wrote: On 06/27/2017 02:17 PM, Christopher Bostic wrote: Reference the system device tree when configuring the watchdog engines. Set external signal mode on timeout if specified. Set system reset on timeout if specified. Signed-off-by: Christopher Bostic

Re: [PATCH v2 1/2] drivers/watchdog: Add optional ASPEED device tree properties

2017-06-27 Thread Christopher Bostic
On 6/27/17 4:32 PM, Guenter Roeck wrote: On Tue, Jun 27, 2017 at 04:17:33PM -0500, Christopher Bostic wrote: Describe device tree optional properties: * aspeed,arm-reet - ARM CPU reset on signal * aspeed,soc-reset - SOC reset on signal * aspeed,sys-reset - System reset on signal

[PATCH v2 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-06-27 Thread Christopher Bostic
Reference the system device tree when configuring the watchdog engines. Set external signal mode on timeout if specified. Set system reset on timeout if specified. Signed-off-by: Christopher Bostic --- v2 - Change of_get_property() to of_property_read_bool() - Remove redundant check for NULL

[PATCH v2 1/2] drivers/watchdog: Add optional ASPEED device tree properties

2017-06-27 Thread Christopher Bostic
system is responsible for this. * aspeed,interrupt - Interrupt CPU on signal * aspeed,external-signal - Generate external signal (WDT1 and WDT2 only) * aspeed,alt-boot - Boot from alternate block on signal Signed-off-by: Christopher Bostic --- v2 - Add 'aspeed,' pre

[PATCH v2 0/2] Add ASPEED watchdog device tree properties

2017-06-27 Thread Christopher Bostic
Document device tree optional properties for ASPEED watchdog. Reference properties in ASPEED watchdog driver and configure accordingly. Christopher Bostic (2): drivers/watchdog: Add optional ASPEED device tree properties drivers/watchdog: ASPEED reference dev tree properties for config

Re: [PATCH 1/2] drivers/watchdog: Document new aspeed optional dev tree properties.

2017-06-27 Thread Christopher Bostic
On 6/26/17 9:59 PM, Joel Stanley wrote: On Wed, Jun 14, 2017 at 6:08 AM, Christopher Bostic wrote: Describe new optional property 'external-signal'. When present in the system device tree an exernal signal is generated on watchdog timeout. Describe new optional property '

Re: [2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-06-26 Thread Christopher Bostic
On 6/24/17 5:17 PM, Guenter Roeck wrote: On Tue, Jun 13, 2017 at 03:38:18PM -0500, Christopher Bostic wrote: Reference the system device tree when configuring the watchdog. Configure for external signal generation if optional attribute 'external-signal' is present in device tree.

Re: [1/2] drivers/watchdog: Document new aspeed optional dev tree properties.

2017-06-26 Thread Christopher Bostic
On 6/24/17 5:07 PM, Guenter Roeck wrote: On Tue, Jun 13, 2017 at 03:38:17PM -0500, Christopher Bostic wrote: Describe new optional property 'external-signal'. When present in the system device tree an exernal signal is generated on watchdog timeout. Describe new optional property

[PATCH 2/2] drivers/watchdog: ASPEED reference dev tree properties for config

2017-06-13 Thread Christopher Bostic
sabling system reset may be required in situations where one of the other watchdogs in the systems is responsible for this. Signed-off-by: Christopher Bostic --- drivers/watchdog/aspeed_wdt.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/as

[PATCH 0/2] drivers/watchdog ASPEED: Add optional dev tree configs

2017-06-13 Thread Christopher Bostic
. This mode is used when one of the other watchdogs in system is to be responsible for managing system reset. Christopher Bostic (2): drivers/watchdog: Document new aspeed optional dev tree properties. drivers/watchdog: ASPEED reference dev tree properties for config Documentation/devicetr

[PATCH 1/2] drivers/watchdog: Document new aspeed optional dev tree properties.

2017-06-13 Thread Christopher Bostic
out. System reset in this case is managed by one of the other watchogs available. Signed-off-by: Christopher Bostic --- Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.

Re: [PATCH] drivers/watchdog: Add sys files to modify watchdog behavior

2017-06-12 Thread Christopher Bostic
On 6/1/17 5:03 PM, Guenter Roeck wrote: On Thu, Jun 01, 2017 at 04:35:21PM -0500, Christopher Bostic wrote: Add files to enable/disable Aspeed watchdog: * External signal after timeout * Reset system after timeout The subject line is heavily misleading. Signed-off-by: Christopher Bostic

[PATCH v8 02/24] drivers/fsi: Add slave definition

2017-06-06 Thread Christopher Bostic
From: Jeremy Kerr Add the initial fsi slave device, which is private to the core code. This will be a child of the master, and parent to endpoint devices. Signed-off-by: Jeremy Kerr Signed-off-by: Chris Bostic Signed-off-by: Joel Stanley --- drivers/fsi/fsi-core.c | 10 ++ 1 file cha

[PATCH v8 04/24] lib: Add crc4 module

2017-06-06 Thread Christopher Bostic
From: Jeremy Kerr Add a little helper for crc4 calculations. This works 4-bits-at-a-time, using a simple table approach. We will need this in the FSI core code, as well as any master implementations that need to calculate CRCs in software. Signed-off-by: Jeremy Kerr Signed-off-by: Chris Bostic

[PATCH v8 03/24] drivers/fsi: Add empty master scan

2017-06-06 Thread Christopher Bostic
From: Jeremy Kerr When a new fsi master is added, we will need to scan its links, and slaves attached to those links. This change introduces a little shell to iterate the links, which we will populate with the actual slave scan in a later change. Signed-off-by: Jeremy Kerr Signed-off-by: Chris

[PATCH v8 08/24] drivers/fsi: Set slave SMODE to init communication

2017-06-06 Thread Christopher Bostic
Set CFAM to appropriate ID so that the controlling master can manage link memory ranges. Add slave engine register definitions. Includes changes from Jeremy Kerr . Signed-off-by: Jeremy Kerr Signed-off-by: Christopher Bostic Signed-off-by: Joel Stanley --- drivers/fsi/fsi-core.c | 75

[PATCH v8 07/24] drivers/fsi: Implement slave initialisation

2017-06-06 Thread Christopher Bostic
From: Jeremy Kerr Implement fsi_slave_init: if we can read a chip ID, create fsi_slave devices and register with the driver core. Includes changes from Christopher Bostic . Signed-off-by: Jeremy Kerr Signed-off-by: Christopher Bostic Signed-off-by: Joel Stanley --- drivers/fsi/Kconfig

[PATCH v8 10/24] drivers/fsi: Add device read/write/peek API

2017-06-06 Thread Christopher Bostic
From: Jeremy Kerr This change introduces the fsi device API: simple read, write and peek accessors for the devices' address spaces. Includes contributions from Christopher Bostic and Edward A. James . Signed-off-by: Edward A. James Signed-off-by: Jeremy Kerr Signed-off-by: Christ

[PATCH v8 06/24] drivers/fsi: Set up links for slave communication

2017-06-06 Thread Christopher Bostic
Enable each link and send a break command, and try to detect a slave by reading from the SMODE register. Signed-off-by: Christopher Bostic Signed-off-by: Joel Stanley --- drivers/fsi/fsi-core.c | 37 +++-- 1 file changed, 35 insertions(+), 2 deletions(-) diff

[PATCH v8 09/24] drivers/fsi: scan slaves & register devices

2017-06-06 Thread Christopher Bostic
From: Jeremy Kerr Now that we have fsi_slave devices, scan each for endpoints, and register them on the fsi bus. Includes contributions from Christopher Bostic . Signed-off-by: Jeremy Kerr Signed-off-by: Christopher Bostic Signed-off-by: Joel Stanley --- drivers/fsi/fsi-core.c | 128

[PATCH v8 13/24] drivers/fsi: Add client driver register utilities

2017-06-06 Thread Christopher Bostic
Add driver_register and driver_unregister wrappers for FSI. Signed-off-by: Christopher Bostic Signed-off-by: Joel Stanley --- drivers/fsi/fsi-core.c | 17 + include/linux/fsi.h| 12 2 files changed, 29 insertions(+) diff --git a/drivers/fsi/fsi-core.c b

[PATCH v8 12/24] drivers/fsi: Add documentation for GPIO bindings

2017-06-06 Thread Christopher Bostic
Add fsi master gpio device tree binding documentation. Includes changes from Jeremy Kerr . Signed-off-by: Christopher Bostic Signed-off-by: Jeremy Kerr Signed-off-by: Joel Stanley Acked-by: Rob Herring --- .../devicetree/bindings/fsi/fsi-master-gpio.txt| 24 ++ 1

[PATCH v8 15/24] drivers/fsi: expose direct-access slave API

2017-06-06 Thread Christopher Bostic
From: Jeremy Kerr Allow drivers to access the slave address ranges. Signed-off-by: Jeremy Kerr Signed-off-by: Joel Stanley Signed-off-by: Christopher Bostic --- v8 - export symbols fsi_slave_read, fsi_slave_write, fsi_slave_claim_range, fsi_slave_release_range --- drivers/fsi/fsi

[PATCH v8 14/24] drivers/fsi: Add sysfs files for FSI master & slave accesses

2017-06-06 Thread Christopher Bostic
From: Jeremy Kerr This change adds a 'raw' file for reads & writes, and a 'term' file for the TERM command, and a 'break' file for issuing a BREAK. Signed-off-by: Jeremy Kerr Signed-off-by: Joel Stanley Signed-off-by: Christopher Bostic

[PATCH v8 17/24] drivers/fsi: Add error handling for slave

2017-06-06 Thread Christopher Bostic
From: Jeremy Kerr This change implements error handling in the FSI core, by cleaining up and retrying failed operations, using the SISC, TERM and BREAK facilities. Signed-off-by: Jeremy Kerr Signed-off-by: Christopher Bostic --- drivers/fsi/fsi-core.c | 121

[PATCH v8 16/24] drivers/fsi: Add tracepoints for low-level operations

2017-06-06 Thread Christopher Bostic
From: Jeremy Kerr Trace low level read and write FSI bus operations. Signed-off-by: Jeremy Kerr Signed-off-by: Joel Stanley Signed-off-by: Christopher Bostic --- v8 - type cast to 'int' to clean up build warnings --- drivers/fsi/fsi-core.c | 27 +++--- include/trace/ev

[PATCH v8 18/24] drivers/fsi: Document FSI master sysfs files in ABI

2017-06-06 Thread Christopher Bostic
Add info for sysfs scan file in Documentaiton ABI/testing Signed-off-by: Christopher Bostic --- v7 - Rename scan file to 'rescan' - Add 'raw' file details - Add 'term' file details - Add 'break' file details - Update kernel version for each fil

[PATCH v8 19/24] drivers/fsi: Add GPIO based FSI master

2017-06-06 Thread Christopher Bostic
Kerr Signed-off-by: Christopher Bostic Signed-off-by: Joel Stanley --- v7 - Move global spinlock to struct fsi_master_gpio - Remove redundant checks for valid gpio descriptors - Clarify 'active low' comments - More descriptive comments for build_abs_ar_command() - Test MTOE

[PATCH v8 23/24] drivers/fsi: Use asynchronous slave mode

2017-06-06 Thread Christopher Bostic
From: Jeremy Kerr For slaves that are behind a software-clocked master, we want FSI CFAMs to run asynchronously to the FSI clock, so set up our slaves to be in async mode. Signed-off-by: Jeremy Kerr Signed-off-by: Christopher Bostic --- drivers/fsi/fsi-core.c| 22

[PATCH v8 21/24] drivers/fsi: Add SCOM FSI client device driver

2017-06-06 Thread Christopher Bostic
Create a simple SCOM engine device driver that reads and writes its control registers via an FSI bus. Includes changes from Edward A. James . Signed-off-by: Christopher Bostic Signed-off-by: Joel Stanley Signed-off-by: Edward A. James Signed-off-by: Jeremy Kerr --- drivers/fsi/Kconfig

[PATCH v8 20/24] drivers/fsi/gpio: Add tracepoints for GPIO master

2017-06-06 Thread Christopher Bostic
From: Jeremy Kerr Trace low level input/output GPIO operations. Signed-off-by: Jeremy Kerr Signed-off-by: Christopher Bostic --- drivers/fsi/fsi-master-gpio.c | 9 + include/trace/events/fsi_master_gpio.h | 68 ++ 2 files changed, 77 insertions

[PATCH v8 24/24] drivers/fsi: Add module license to core driver

2017-06-06 Thread Christopher Bostic
Add missing MODULE_LICENSE("GPL") to the core FSI driver. Signed-off-by: Christopher Bostic --- drivers/fsi/fsi-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c index b56f4ed..a485864 100644 --- a/drivers/fsi/fsi-core.c +++ b/d

[PATCH v8 22/24] drivers/fsi: Add hub master support

2017-06-06 Thread Christopher Bostic
Add an engine driver to expose a "hub" FSI master - which has a set of control registers in the engine address space, and uses a chunk of the slave address space for actual FSI communication. Additional changes from Jeremy Kerr . Signed-off-by: Christopher Bostic Signed-off-by: J

[PATCH v8 11/24] drivers/fsi: Add master unscan

2017-06-06 Thread Christopher Bostic
Allow a master to undo a previous scan. Should a master scan a bus twice it will need to ensure it doesn't double register any previously detected device. Signed-off-by: Christopher Bostic Signed-off-by: Joel Stanley v7 - Unscan when unregistering master - Remove leading '

[PATCH v8 00/24] FSI device driver implementation

2017-06-06 Thread Christopher Bostic
- Assign value of master->master.dev at probe time. - Use get_optional interface for all optional GPIO pins. Christopher Bostic (10): drivers/fsi: Set up links for slave communication drivers/fsi: Set slave SMODE to init communication drivers/fsi: Add master unscan drivers/fsi: Add docum

[PATCH v8 05/24] drivers/fsi: Add slave & master read/write APIs

2017-06-06 Thread Christopher Bostic
From: Jeremy Kerr Introduce functions to perform reads/writes on the slave address space; these simply pass the request on the slave's master with the correct link and slave ID. We implement these on top of similar helpers for the master. Signed-off-by: Jeremy Kerr Signed-off-by: Joel Stanley

[PATCH v8 01/24] drivers/fsi: Add fsi master definition

2017-06-06 Thread Christopher Bostic
From: Jeremy Kerr Add a `struct fsi_master` to represent a FSI master controller. FSI master drivers register one of these structs to provide device-specific of the standard operations: read/write/term/break and link control. Includes changes from Edward A. James & Jeremy Kerr . Signed-off-by

Re: [PATCH v7 00/23] FSI device driver implementation

2017-06-05 Thread Christopher Bostic
On 6/3/17 4:25 PM, Steven Rostedt wrote: On Sat, 3 Jun 2017 19:05:10 +0900 Greg KH wrote: On Wed, May 31, 2017 at 12:17:05PM -0500, Christopher Bostic wrote: Hi Greg, Are there any further changes you require for this patch set? This has been extensively tested internally and all is

Re: [PATCH v7 00/23] FSI device driver implementation

2017-06-05 Thread Christopher Bostic
On 6/3/17 5:05 AM, Greg KH wrote: On Wed, May 31, 2017 at 12:17:05PM -0500, Christopher Bostic wrote: Hi Greg, Are there any further changes you require for this patch set? This has been extensively tested internally and all is working as expected. Would it be possible to move forward with

[PATCH] drivers/watchdog: Add sys files to modify watchdog behavior

2017-06-01 Thread Christopher Bostic
Add files to enable/disable Aspeed watchdog: * External signal after timeout * Reset system after timeout Signed-off-by: Christopher Bostic --- .../ABI/testing/sysfs-platform-aspeed-wdt | 40 +++ drivers/watchdog/aspeed_wdt.c | 79 +- 2

Re: [PATCH v7 00/23] FSI device driver implementation

2017-05-31 Thread Christopher Bostic
, Christopher Bostic wrote: Implementation of the IBM 'Flexible Support Interface' (FSI) bus device driver. FSI is a high fan out serial bus consisting of a clock and a serial data line capable of running at speeds up to 166 MHz. This set provides the basic framework to add FSI extensi

[PATCH v7 02/23] drivers/fsi: Add slave definition

2017-05-11 Thread Christopher Bostic
From: Jeremy Kerr Add the initial fsi slave device, which is private to the core code. This will be a child of the master, and parent to endpoint devices. Signed-off-by: Jeremy Kerr Signed-off-by: Chris Bostic Signed-off-by: Joel Stanley --- drivers/fsi/fsi-core.c | 10 ++ 1 file cha

[PATCH v7 04/23] lib: Add crc4 module

2017-05-11 Thread Christopher Bostic
From: Jeremy Kerr Add a little helper for crc4 calculations. This works 4-bits-at-a-time, using a simple table approach. We will need this in the FSI core code, as well as any master implementations that need to calculate CRCs in software. Signed-off-by: Jeremy Kerr Signed-off-by: Chris Bostic

[PATCH v7 09/23] drivers/fsi: scan slaves & register devices

2017-05-11 Thread Christopher Bostic
From: Jeremy Kerr Now that we have fsi_slave devices, scan each for endpoints, and register them on the fsi bus. Includes contributions from Christopher Bostic . Signed-off-by: Jeremy Kerr Signed-off-by: Christopher Bostic Signed-off-by: Joel Stanley --- v7 - Use GEN_MASK for bitmask

[PATCH v7 10/23] drivers/fsi: Add device read/write/peek API

2017-05-11 Thread Christopher Bostic
From: Jeremy Kerr This change introduces the fsi device API: simple read, write and peek accessors for the devices' address spaces. Includes contributions from Christopher Bostic and Edward A. James . Signed-off-by: Edward A. James Signed-off-by: Jeremy Kerr Signed-off-by: Christ

[PATCH v7 11/23] drivers/fsi: Add master unscan

2017-05-11 Thread Christopher Bostic
Allow a master to undo a previous scan. Should a master scan a bus twice it will need to ensure it doesn't double register any previously detected device. Signed-off-by: Christopher Bostic Signed-off-by: Joel Stanley v7 - Unscan when unregistering master - Remove leading '

[PATCH v7 14/23] drivers/fsi: Add sysfs files for FSI master & slave accesses

2017-05-11 Thread Christopher Bostic
From: Jeremy Kerr This change adds a 'raw' file for reads & writes, and a 'term' file for the TERM command, and a 'break' file for issuing a BREAK. Signed-off-by: Jeremy Kerr Signed-off-by: Joel Stanley Signed-off-by: Christopher Bostic

[PATCH v7 13/23] drivers/fsi: Add client driver register utilities

2017-05-11 Thread Christopher Bostic
Add driver_register and driver_unregister wrappers for FSI. Signed-off-by: Christopher Bostic Signed-off-by: Joel Stanley --- drivers/fsi/fsi-core.c | 17 + include/linux/fsi.h| 12 2 files changed, 29 insertions(+) diff --git a/drivers/fsi/fsi-core.c b

[PATCH v7 07/23] drivers/fsi: Implement slave initialisation

2017-05-11 Thread Christopher Bostic
From: Jeremy Kerr Implement fsi_slave_init: if we can read a chip ID, create fsi_slave devices and register with the driver core. Includes changes from Christopher Bostic . Signed-off-by: Jeremy Kerr Signed-off-by: Christopher Bostic Signed-off-by: Joel Stanley --- v7 - Change warning

[PATCH v7 12/23] drivers/fsi: Add documentation for GPIO bindings

2017-05-11 Thread Christopher Bostic
Add fsi master gpio device tree binding documentation. Includes changes from Jeremy Kerr . Signed-off-by: Christopher Bostic Signed-off-by: Jeremy Kerr Signed-off-by: Joel Stanley Acked-by: Rob Herring --- .../devicetree/bindings/fsi/fsi-master-gpio.txt| 24 ++ 1

[PATCH v7 16/23] drivers/fsi: Add tracepoints for low-level operations

2017-05-11 Thread Christopher Bostic
From: Jeremy Kerr Trace low level read and write FSI bus operations. Signed-off-by: Jeremy Kerr Signed-off-by: Joel Stanley Signed-off-by: Christopher Bostic --- drivers/fsi/fsi-core.c | 27 +++--- include/trace/events/fsi.h | 127 + 2

[PATCH v7 18/23] drivers/fsi: Document FSI master sysfs files in ABI

2017-05-11 Thread Christopher Bostic
From: Chris Bostic Add info for sysfs scan file in Documentaiton ABI/testing Signed-off-by: Christopher Bostic --- v7 - Rename scan file to 'rescan' - Add 'raw' file details - Add 'term' file details - Add 'break' file details - Upd

[PATCH v7 21/23] drivers/fsi: Add SCOM FSI client device driver

2017-05-11 Thread Christopher Bostic
Create a simple SCOM engine device driver that reads and writes its control registers via an FSI bus. Includes changes from Edward A. James . Signed-off-by: Christopher Bostic Signed-off-by: Joel Stanley Signed-off-by: Edward A. James Signed-off-by: Jeremy Kerr --- drivers/fsi/Kconfig

[PATCH v7 17/23] drivers/fsi: Add error handling for slave

2017-05-11 Thread Christopher Bostic
From: Jeremy Kerr This change implements error handling in the FSI core, by cleaning up and retrying failed operations, using the SISC, TERM and BREAK facilities. Signed-off-by: Jeremy Kerr Signed-off-by: Christopher Bostic --- drivers/fsi/fsi-core.c | 121

[PATCH v7 20/23] drivers/fsi/gpio: Add tracepoints for GPIO master

2017-05-11 Thread Christopher Bostic
From: Jeremy Kerr Trace low level input/output GPIO operations. Signed-off-by: Jeremy Kerr Signed-off-by: Christopher Bostic --- drivers/fsi/fsi-master-gpio.c | 9 + include/trace/events/fsi_master_gpio.h | 68 ++ 2 files changed, 77 insertions

[PATCH v7 23/23] drivers/fsi: Use asynchronous slave mode

2017-05-11 Thread Christopher Bostic
From: Jeremy Kerr For slaves that are behind a software-clocked master, we want FSI CFAMs to run asynchronously to the FSI clock, so set up our slaves to be in async mode. Signed-off-by: Jeremy Kerr Signed-off-by: Christopher Bostic --- drivers/fsi/fsi-core.c| 22

[PATCH v7 22/23] drivers/fsi: Add hub master support

2017-05-11 Thread Christopher Bostic
Add an engine driver to expose a "hub" FSI master - which has a set of control registers in the engine address space, and uses a chunk of the slave address space for actual FSI communication. Additional changes from Jeremy Kerr . Signed-off-by: Christopher Bostic Signed-off-by: J

[PATCH v7 19/23] drivers/fsi: Add GPIO based FSI master

2017-05-11 Thread Christopher Bostic
Kerr Signed-off-by: Christopher Bostic Signed-off-by: Joel Stanley --- v7 - Move global spinlock to struct fsi_master_gpio - Remove redundant checks for valid gpio descriptors - Clarify 'active low' comments - More descriptive comments for build_abs_ar_command() - Test MTOE

[PATCH v7 15/23] drivers/fsi: expose direct-access slave API

2017-05-11 Thread Christopher Bostic
From: Jeremy Kerr Allow drivers to access the slave address ranges. Signed-off-by: Jeremy Kerr Signed-off-by: Joel Stanley Signed-off-by: Christopher Bostic --- drivers/fsi/fsi-core.c | 26 -- include/linux/fsi.h| 12 2 files changed, 32 insertions

[PATCH v7 03/23] drivers/fsi: Add empty master scan

2017-05-11 Thread Christopher Bostic
From: Jeremy Kerr When a new fsi master is added, we will need to scan its links, and slaves attached to those links. This change introduces a little shell to iterate the links, which we will populate with the actual slave scan in a later change. Signed-off-by: Jeremy Kerr Signed-off-by: Chris

[PATCH v7 06/23] drivers/fsi: Set up links for slave communication

2017-05-11 Thread Christopher Bostic
Enable each link and send a break command, and try to detect a slave by reading from the SMODE register. Signed-off-by: Christopher Bostic Signed-off-by: Joel Stanley --- drivers/fsi/fsi-core.c | 37 +++-- 1 file changed, 35 insertions(+), 2 deletions(-) diff

[PATCH v7 05/23] drivers/fsi: Add slave & master read/write APIs

2017-05-11 Thread Christopher Bostic
From: Jeremy Kerr Introduce functions to perform reads/writes on the slave address space; these simply pass the request on the slave's master with the correct link and slave ID. We implement these on top of similar helpers for the master. Signed-off-by: Jeremy Kerr Signed-off-by: Joel Stanley

[PATCH v7 08/23] drivers/fsi: Set slave SMODE to init communication

2017-05-11 Thread Christopher Bostic
Set CFAM to appropriate ID so that the controlling master can manage link memory ranges. Add slave engine register definitions. Includes changes from Jeremy Kerr . Signed-off-by: Jeremy Kerr Signed-off-by: Christopher Bostic Signed-off-by: Joel Stanley --- drivers/fsi/fsi-core.c | 75

[PATCH v7 00/23] FSI device driver implementation

2017-05-11 Thread Christopher Bostic
n request. - Assign value of master->master.dev at probe time. - Use get_optional interface for all optional GPIO pins. Christopher Bostic (9): drivers/fsi: Document FSI master sysfs files in ABI drivers/fsi: Set up links for slave communication drivers/fsi: Set slave SMODE to in

[PATCH v7 01/23] drivers/fsi: Add fsi master definition

2017-05-11 Thread Christopher Bostic
From: Jeremy Kerr Add a `struct fsi_master` to represent a FSI master controller. FSI master drivers register one of these structs to provide device-specific of the standard operations: read/write/term/break and link control. Includes changes from Edward A. James & Jeremy Kerr . Signed-off-by

Re: [PATCH v6 19/23] drivers/fsi: Add GPIO based FSI master

2017-05-11 Thread Christopher Bostic
On 5/10/17 8:58 PM, Jeremy Kerr wrote: Hi Chris, I don't think we'd want this per master. The lock is for the 'top' master issuing commands. Only the top master can initiate any transactions on the bus to any devices connected downstream. Downstream masters such as hub masters, etc... cann

Re: [PATCH v6 10/23] drivers/fsi: Add device read/write/peek API

2017-05-10 Thread Christopher Bostic
On 5/10/17 3:13 AM, Joel Stanley wrote: On Tue, Apr 11, 2017 at 5:16 AM, Christopher Bostic wrote: From: Jeremy Kerr This change introduces the fsi device API: simple read, write and peek accessors for the devices' address spaces. Includes contributions from Chris Bostic and Edw

Re: [PATCH v6 11/23] drivers/fsi: Add master unscan

2017-05-10 Thread Christopher Bostic
On 5/10/17 2:31 AM, Joel Stanley wrote: On Tue, Apr 11, 2017 at 5:16 AM, Christopher Bostic wrote: From: Chris Bostic Allow a master to undo a previous scan. Should a master scan a bus twice it will need to ensure it doesn't double register any previously detected device. Signed-o

Re: [PATCH v6 09/23] drivers/fsi: scan slaves & register devices

2017-05-10 Thread Christopher Bostic
On 5/10/17 2:30 AM, Joel Stanley wrote: On Tue, Apr 11, 2017 at 5:16 AM, Christopher Bostic wrote: From: Jeremy Kerr Now that we have fsi_slave devices, scan each for endpoints, and register them on the fsi bus. Includes contributions from Chris Bostic Signed-off-by: Jeremy Kerr Signed

Re: [PATCH v6 18/23] drivers/fsi: Document FSI master sysfs files in ABI

2017-05-10 Thread Christopher Bostic
On 5/10/17 2:30 AM, Joel Stanley wrote: On Tue, Apr 11, 2017 at 5:17 AM, Christopher Bostic wrote: From: Chris Bostic Add info for sysfs scan file in Documentaiton ABI/testing You are missing documentation for the 'raw', 'term' and 'break' files. Hi Joel,

Re: [PATCH v6 19/23] drivers/fsi: Add GPIO based FSI master

2017-05-10 Thread Christopher Bostic
On 5/10/17 2:30 AM, Joel Stanley wrote: Hi Chris, On Tue, Apr 11, 2017 at 5:17 AM, Christopher Bostic wrote: From: Chris Bostic Implement a FSI master using GPIO. Will generate FSI protocol for read and write commands to particular addresses. Sends master command and waits for and

Re: [PATCH v6 07/23] drivers/fsi: Implement slave initialisation

2017-05-02 Thread Christopher Bostic
On 5/2/17 1:24 AM, Joel Stanley wrote: On Tue, Apr 11, 2017 at 5:16 AM, Christopher Bostic wrote: From: Jeremy Kerr Implement fsi_slave_init: if we can read a chip ID, create fsi_slave devices and register with the driver core. Includes changes from Chris Bostic . Signed-off-by: Jeremy

[PATCH v6 19/23] drivers/fsi: Add GPIO based FSI master

2017-04-10 Thread Christopher Bostic
From: Chris Bostic Implement a FSI master using GPIO. Will generate FSI protocol for read and write commands to particular addresses. Sends master command and waits for and decodes a slave response. Includes changes from Edward A. James and Jeremy Kerr . Signed-off-by: Edward A. James Signe

[PATCH v6 22/23] drivers/ fsi: Add hub master support

2017-04-10 Thread Christopher Bostic
From: Chris Bostic Add an engine driver to expose a "hub" FSI master - which has a set of control registers in the engine address space, and uses a chunk of the slave address space for actual FSI communication. Additional changes from Jeremy Kerr . Signed-off-by: Chris Bostic Signed-off-by: Je

[PATCH v6 23/23] drivers/fsi: Use asynchronous slave mode

2017-04-10 Thread Christopher Bostic
From: Jeremy Kerr For slaves that are behind a software-clocked master, we want FSI CFAMs to run asynchronously to the FSI clock, so set up our slaves to be in async mode. Signed-off-by: Jeremy Kerr Signed-off-by: Chris Bostic --- drivers/fsi/fsi-core.c| 22 +- dri

[PATCH v6 21/23] drivers/fsi: Add SCOM FSI client device driver

2017-04-10 Thread Christopher Bostic
From: Chris Bostic Create a simple SCOM engine device driver that reads and writes its control registers via an FSI bus. Includes changes from Edward A. James . Signed-off-by: Chris Bostic Signed-off-by: Joel Stanley Signed-off-by: Edward A. James Signed-off-by: Jeremy Kerr --- drivers/fsi

[PATCH v6 18/23] drivers/fsi: Document FSI master sysfs files in ABI

2017-04-10 Thread Christopher Bostic
From: Chris Bostic Add info for sysfs scan file in Documentaiton ABI/testing Signed-off-by: Chris Bostic --- Documentation/ABI/testing/sysfs-bus-fsi | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-bus-fsi diff --git a/Documentation/ABI/testing/s

[PATCH v6 20/23] drivers/fsi/gpio: Add tracepoints for GPIO master

2017-04-10 Thread Christopher Bostic
From: Jeremy Kerr Add trace points for key GPIO operations of the GPIO based FSI master. Signed-off-by: Jeremy Kerr Signed-off-by: Chris Bostic --- drivers/fsi/fsi-master-gpio.c | 9 + include/trace/events/fsi_master_gpio.h | 68 ++ 2 files change

  1   2   3   >