Re: [PATCH 06/16] arch: remove tile port

2018-03-15 Thread Chris Metcalf
On 3/14/2018 10:36 AM, Arnd Bergmann wrote: The Tile architecture port was added by Chris Metcalf in 2010, and maintained until early 2018 when he orphaned it due to his departure from Mellanox, and nobody else stepped up to maintain it. The product line is still around in the form of the

[GIT PULL] arch/tile "bugfix" for 4.15-rc3

2017-12-05 Thread Chris Metcalf
come. Chris Metcalf (1):   arch/tile: mark as orphaned  MAINTAINERS | 4 +---  1 file changed, 1 insertion(+), 3 deletions(-) -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: linux-next: remove the tile tree?

2017-12-04 Thread Chris Metcalf
On 12/4/2017 3:25 PM, Stephen Rothwell wrote: Hi Chris, Given commit 8ee5ad1d4c0b ("arch/tile: mark as orphaned") in Linus' tree, should I remove the tile tree from linux-next? Yes, that would make sense.  Good catch! -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

[PATCH] arch/tile: mark as orphaned

2017-12-04 Thread Chris Metcalf
Metcalf Signed-off-by: Chris Metcalf --- This is my last week at Mellanox, and in the absence of customer engagements, it doesn't seem to make sense to transition the tile architecture maintainer role over to some other Mellanox employee. It would be great if someone in the community were interest

Re: [PATCH v16 00/13] support "task_isolation" mode

2017-11-07 Thread Chris Metcalf
On 11/7/2017 12:10 PM, Christopher Lameter wrote: On Mon, 6 Nov 2017, Chris Metcalf wrote: On 11/6/2017 10:38 AM, Christopher Lameter wrote: What about that d*mn 1 Hz clock? It's still there, so this code still requires some further work before it can actually get a process into long

Re: [PATCH v16 10/13] arch/arm: enable task isolation functionality

2017-11-06 Thread Chris Metcalf
s and help make the last week of -rc8 pass more quickly by digging into this patch series!  :-) -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH v16 09/13] arch/arm64: enable task isolation functionality

2017-11-03 Thread Chris Metcalf
On 11/3/2017 1:32 PM, Mark Rutland wrote: Hi Chris, On Fri, Nov 03, 2017 at 01:04:48PM -0400, Chris Metcalf wrote: In do_notify_resume(), call task_isolation_start() for TIF_TASK_ISOLATION tasks. Add _TIF_TASK_ISOLATION to _TIF_WORK_MASK, and define a local NOTIFY_RESUME_LOOP_FLAGS to check

[PATCH] arch/tile: Implement ->set_state_oneshot_stopped()

2017-11-03 Thread Chris Metcalf
rrupts, as explained by: commit 8fff52fd5093 ("clockevents: Introduce CLOCK_EVT_STATE_ONESHOT_STOPPED state"). Signed-off-by: Chris Metcalf --- arch/tile/kernel/time.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/tile/kernel/time.c b/arch/tile/kernel/time.c index 6643ff

Re: [PATCH v16 12/13] arm, tile: turn off timer tick for oneshot_stopped state

2017-11-03 Thread Chris Metcalf
On 11/3/2017 1:18 PM, Mark Rutland wrote: Hi Chris, On Fri, Nov 03, 2017 at 01:04:51PM -0400, Chris Metcalf wrote: diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c index fd4b7f684bd0..61ea7f907c56 100644 --- a/drivers/clocksource/arm_arch_timer.c +++ b

[GIT PULL] arch/tile bugfixes for 4.14-rcN

2017-11-03 Thread Chris Metcalf
Linus, Please pull the following two commits for 4.14 from: git://git.kernel.org/pub/scm/linux/kernel/git/cmetcalf/linux-tile.git master These are both one-line bug fixes. Chris Metcalf (1): arch/tile: Implement ->set_state_oneshot_stopped() Luc Van Oostenryck (1): tile: p

Re: [PATCH v16 10/13] arch/arm: enable task isolation functionality

2017-11-03 Thread Chris Metcalf
On 11/3/2017 1:23 PM, Russell King - ARM Linux wrote: On Fri, Nov 03, 2017 at 01:04:49PM -0400, Chris Metcalf wrote: From: Francis Giraldeau This patch is a port of the task isolation functionality to the arm 32-bit architecture. The task isolation needs an additional thread flag that

[PATCH v16 07/13] Add task isolation hooks to arch-independent code

2017-11-03 Thread Chris Metcalf
r, so that for example smp_send_reschedule() is a single generic function that just calls arch_smp_send_reschedule(), allowing generic code to be called every time smp_send_reschedule() is invoked. But for now, we just update either callers or callees as makes most sense. Signed-off-by: Chr

[PATCH v16 10/13] arch/arm: enable task isolation functionality

2017-11-03 Thread Chris Metcalf
Giraldeau Signed-off-by: Chris Metcalf [with modifications] --- arch/arm/Kconfig | 1 + arch/arm/include/asm/thread_info.h | 10 +++--- arch/arm/kernel/entry-common.S | 12 arch/arm/kernel/ptrace.c | 10 ++ arch/arm/kernel/signal.c

[PATCH v16 09/13] arch/arm64: enable task isolation functionality

2017-11-03 Thread Chris Metcalf
We instrument the smp_send_reschedule() routine so that it checks for isolated tasks and generates a suitable warning if needed. Finally, report on page faults in task-isolation processes in do_page_faults(). Signed-off-by: Chris Metcalf --- arch/arm64/Kconfig | 1 + arch/arm64/include/asm/

[PATCH v16 08/13] arch/x86: enable task isolation functionality

2017-11-03 Thread Chris Metcalf
, namely non-signalling page faults and non-signalling MPX fixups. Signed-off-by: Chris Metcalf --- arch/x86/Kconfig | 1 + arch/x86/entry/common.c| 14 ++ arch/x86/include/asm/apic.h| 3 +++ arch/x86/include/asm/thread_info.h | 8 +--- arch

[PATCH v16 05/13] Add try_stop_full_tick() API for NO_HZ_FULL

2017-11-03 Thread Chris Metcalf
This API checks to see if the scheduler tick can be stopped, and if so, stops it and returns 0; otherwise it returns an error. This is intended for use with task isolation, where we will want to be able to stop the tick synchronously when returning to userspace. Signed-off-by: Chris Metcalf

[PATCH v16 06/13] task_isolation: userspace hard isolation from kernel

2017-11-03 Thread Chris Metcalf
reschedule IPI to be sent to the remote core so it can be sure to generate a signal to notify the process. Separate patches that follow provide these changes for x86, tile, arm, and arm64. Signed-off-by: Chris Metcalf --- Documentation/admin-guide/kernel-parameters.txt | 6 + include/linux/i

[PATCH v16 03/13] Revert "sched/core: Drop the unused try_get_task_struct() helper function"

2017-11-03 Thread Chris Metcalf
This reverts commit f11cc0760b8397e0d230122606421b6a96e9f869. We do need this function for try_get_task_struct_on_cpu(). Signed-off-by: Chris Metcalf --- include/linux/sched/task.h | 2 ++ kernel/exit.c | 13 + 2 files changed, 15 insertions(+) diff --git a/include

[PATCH v16 12/13] arm, tile: turn off timer tick for oneshot_stopped state

2017-11-03 Thread Chris Metcalf
interval will properly re-enable it. This fix avoids a small performance hiccup for regular applications, but for TASK_ISOLATION code, it fixes a potentially serious kernel timer interruption to the time-sensitive application. Signed-off-by: Chris Metcalf Acked-by: Daniel Lezcano --- arch/tile/kernel

[PATCH v16 13/13] task_isolation self test

2017-11-03 Thread Chris Metcalf
This code tests various aspects of task_isolation. Signed-off-by: Chris Metcalf --- tools/testing/selftests/Makefile | 1 + tools/testing/selftests/task_isolation/Makefile| 6 + tools/testing/selftests/task_isolation/config | 1 + tools/testing/selftests

[PATCH v16 11/13] arch/tile: enable task isolation functionality

2017-11-03 Thread Chris Metcalf
y not generate signals to the application. Signed-off-by: Chris Metcalf --- arch/tile/Kconfig | 1 + arch/tile/include/asm/thread_info.h | 2 ++ arch/tile/kernel/hardwall.c | 2 ++ arch/tile/kernel/irq.c | 3 +++ arch/tile/kernel/messaging.c| 4

[PATCH v16 04/13] Add try_get_task_struct_on_cpu() to scheduler for task isolation

2017-11-03 Thread Chris Metcalf
; it uses try_get_task_struct() to increment the ref count on the returned task_struct so that the caller can examine it even if the actual remote task has already exited by that point. Signed-off-by: Chris Metcalf --- include/linux/sched/task.h | 1 + kernel/sched/core.c| 11

[PATCH v16 02/13] vmstat: add vmstat_idle function

2017-11-03 Thread Chris Metcalf
This function checks to see if a vmstat worker is not running, and the vmstat diffs don't require an update. The function is called from the task-isolation code to see if we need to actually do some work to quiet vmstat. Acked-by: Christoph Lameter Signed-off-by: Chris Metcalf --- in

[PATCH v16 01/13] vmstat: add quiet_vmstat_sync function

2017-11-03 Thread Chris Metcalf
guarantees that the vmstat worker will not run on the core on return from the function. Add a quiet_vmstat_sync() function with that semantic. Signed-off-by: Chris Metcalf --- include/linux/vmstat.h | 2 ++ mm/vmstat.c| 9 + 2 files changed, 11 insertions(+) diff --git a/inc

[PATCH v16 00/13] support "task_isolation" mode

2017-11-03 Thread Chris Metcalf
ll there, so this code still requires some further work before it can actually get a process into long-term task isolation (without the obvious one-line kernel hack). Frederic suggested a while ago forcing updates on cpustats was required as the last gating factor; do we think that is still true? C

Re: [GIT PULL] Introduce housekeeping subsystem v4

2017-10-21 Thread Chris Metcalf
in no matter what, to allow ensuring kernel isolation when you absolutely require it.) The current task isolation tree is in the "dataplane" branch at git://git.kernel.org/pub/scm/linux/kernel/git/cmetcalf/linux-tile.git -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

[PATCH] firmware: bluefield: add boot control driver

2017-10-09 Thread Chris Metcalf
, but the use case above is what the driver primarily supports. It is structured as a simple sysfs driver that is loaded based on an ACPI table entry, and allows reading/writing text strings to various /sys/bus/platform/drivers/mlx-bootctl/* files. Signed-off-by: Chris Metcalf --- Ingo, since there

[GIT PULL] arch/tile bugfixes for 4.14-rc2

2017-09-22 Thread Chris Metcalf
): tile: defconfig: Cleanup from old Kconfig options arch/tile/configs/tilegx_defconfig | 1 - arch/tile/configs/tilepro_defconfig | 2 -- arch/tile/kernel/setup.c| 2 +- 3 files changed, 1 insertion(+), 4 deletions(-) -- Chris Metcalf, Mellanox Technologies http

Re: [RFC PATCH 0/9] Introduce housekeeping subsystem

2017-08-11 Thread Chris Metcalf
me to work on it. I really would like to get out a new spin. Fingers crossed. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [RFC PATCH 0/9] Introduce housekeeping subsystem

2017-08-11 Thread Chris Metcalf
On 8/11/2017 2:36 AM, Mike Galbraith wrote: On Thu, 2017-08-10 at 09:57 -0400, Chris Metcalf wrote: On 8/10/2017 8:54 AM, Frederic Weisbecker wrote: But perhaps I should add a new NO_HZ_FULL_BUT_HOUSEKEEPING option. Otherwise we'll change the meaning of NO_HZ_FULL_ALL way too much, t

Re: [RFC PATCH 0/9] Introduce housekeeping subsystem

2017-08-10 Thread Chris Metcalf
ing NOHZ_FULL on the core... or maybe it's just implied by TASK_ISOLATION. I've done a bad job of finding time to work on that since last year's Plumbers, but September looks good :) -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH 09/11] tile/topology: Remove the unused parent_node() macro

2017-07-26 Thread Chris Metcalf
ff-by: Dou Liyang Cc: Chris Metcalf --- arch/tile/include/asm/topology.h | 6 -- 1 file changed, 6 deletions(-) Acked-by: Chris Metcalf -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH] tile: array underflow in setup_maxnodemem()

2017-07-24 Thread Chris Metcalf
n into the tile tree. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [RFC PATCH 0/9] Introduce housekeeping subsystem

2017-07-21 Thread Chris Metcalf
tick offloading (remove residual 1Hz) and all unbound kthreads. git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git nohz/0hz HEAD: 68e3af1de5db228bf6c2a5e721bce59a02cfc4e1 For the series: Reviewed-by: Chris Metcalf I spotted a few typos that you should grep for and fi

Re: [RESEND PATCH] tile: defconfig: Cleanup from old Kconfig options

2017-07-20 Thread Chris Metcalf
nts of ulog targets"); Signed-off-by: Krzysztof Kozlowski --- arch/tile/configs/tilegx_defconfig | 1 - arch/tile/configs/tilepro_defconfig | 2 -- 2 files changed, 3 deletions(-) Thanks! Taken into the tile tree. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH] lib/strscpy: avoid KASAN false positive

2017-07-19 Thread Chris Metcalf
ASAN, but I haven't looked deeply at the tradeoffs here. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

[GIT PULL] arch/tile changes for 4.13

2017-07-14 Thread Chris Metcalf
Linus, Please pull the following changes for 4.13 from: git://git.kernel.org/pub/scm/linux/kernel/git/cmetcalf/linux-tile.git master This adds support for an to help with removing __need_xxx #defines from glibc, and removes some dead code in arch/tile/mm/init.c. Chris Metcalf (1

Re: [RFC][PATCH] atomic: Fix atomic_set_release() for 'funny' architectures

2017-06-09 Thread Chris Metcalf
any of the other SC atomic primitives and therefore seem to rely on their spinlock implementation being SC (I did not fully validate all that). Therefore, the normal atomic_set() is SC and can be used at atomic_set_release(). Acked-by: Chris Metcalf [for tile] -- Chris Metcalf, Mellan

Re: Updating kernel.org cross compilers?

2017-05-23 Thread Chris Metcalf
e the tilegx/tilepro issues were sorted out -- as someone noted, you need to have the kernel headers available to build glibc. However, if there are any outstanding tile issues, please feel free to loop me in! -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH 2/6] mm, tile: drop arch_{add,remove}_memory

2017-03-30 Thread Chris Metcalf
ause nobody has noticed that __add_pages has a different signature since 2009. Cc: Chris Metcalf Signed-off-by: Michal Hocko --- arch/tile/mm/init.c | 30 -- 1 file changed, 30 deletions(-) Thanks - taken into the tile tree. -- Chris Metcalf, Mellanox Te

[PATCH] tile: prefer to __need_int_reg_t

2017-03-27 Thread Chris Metcalf
As part of some work in glibc to move away from the "__need" prefix, this commit breaks away the definitions of __int_reg_t, __uint_reg_t, __INT_REG_BITS, and __INT_REG_FMT to a separate "microheader". It is then included from to preserve the semantics of the previous header. For now, we contin

Re: [PATCH 1/3] futex: remove duplicated code

2017-03-03 Thread Chris Metcalf
laby Acked-by: Chris Metcalf [for tile] -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH v15 04/13] task_isolation: add initial support

2017-02-02 Thread Chris Metcalf
for man-pages, describing the new prctl calls, is missing. Thanks, I appreciate the feedback. I'll fold this into the next spin of the series! -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH] tile: fix build failure

2017-01-24 Thread Chris Metcalf
/parport/jobs/194717687 arch/tile/include/asm/div64.h | 1 + 1 file changed, 1 insertion(+) Acked-by: Chris Metcalf -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

[GIT PULL] arch/tile bugfix for 4.10-rc6

2017-01-23 Thread Chris Metcalf
/kernel/ptrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: Questions on the task isolation patches

2016-12-22 Thread Chris Metcalf
On 12/20/2016 4:27 AM, Paolo Bonzini wrote: On 16/12/2016 22:00, Chris Metcalf wrote: Sorry, I think I wasn't clear. Normally when you are running task isolated and you enter the kernel, you will get a fatal signal. The exception is if you call prctl itself (or exit), the kernel tolerat

Re: Questions on the task isolation patches

2016-12-16 Thread Chris Metcalf
Sorry for the slow response - I have been busy with some other things. On 12/6/2016 4:43 PM, yunhong jiang wrote: On Fri, 2 Dec 2016 13:58:08 -0500 Chris Metcalf wrote: On 12/1/2016 5:28 PM, yunhong jiang wrote: a) If the task isolation need prctl to mark itself as isolated, possibly the

[GIT PULL] arch/tile changes for 4.10

2016-12-16 Thread Chris Metcalf
Linus, Please pull the following changes for 4.10 from: git://git.kernel.org/pub/scm/linux/kernel/git/cmetcalf/linux-tile.git master Another grab-bag of miscellaneous changes. Chris Metcalf (2): tile: remove #pragma unroll from finv_buffer_remote() tile: use __ro_after_init

Re: [patch 5/6] [RFD] timekeeping: Provide optional 128bit math

2016-12-09 Thread Chris Metcalf
, gcc-5.4, gcc-6.2: bad I also found 4.4 was good on tilegx at recognizing the 32x32, and bad on the later versions I tested; I don't recall which specific later versions I tried, though. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [patch 5/6] [RFD] timekeeping: Provide optional 128bit math

2016-12-09 Thread Chris Metcalf
ux/math64.h| 26 ++ 4 files changed, 42 insertions(+), 9 deletions(-) Untested, but I looked at it closely, and it seems like a decent idea. Acked-by: Chris Metcalf [for tile] Of course if this is pushed up, it will then probably be too tempting for me not to

Re: Questions on the task isolation patches

2016-12-02 Thread Chris Metcalf
urn off the task isolation before yield the CPU and the restart the task isolation after the new packet, right? Yes, exactly. I am not likely to pursue KVM myself, at least until the basic patch series has been accepted upstream. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

[tip:timers/core] timekeeping/clocksource_cyc2ns: Document intended range limitation

2016-11-29 Thread tip-bot for Chris Metcalf
Commit-ID: ec4101e8903e318b9fd4e3bbf72b1eaba53c64e1 Gitweb: http://git.kernel.org/tip/ec4101e8903e318b9fd4e3bbf72b1eaba53c64e1 Author: Chris Metcalf AuthorDate: Mon, 28 Nov 2016 14:35:20 -0800 Committer: Thomas Gleixner CommitDate: Tue, 29 Nov 2016 18:02:58 +0100 timekeeping

[GIT PULL] arch/tile bugfix for 4.9-rc7

2016-11-23 Thread Chris Metcalf
Linus, Please pull the following change for 4.9-rc7 from: git://git.kernel.org/pub/scm/linux/kernel/git/cmetcalf/linux-tile.git stable This fixes a bug that causes reboots after 208 days of uptime :-) Chris Metcalf (1): tile: avoid using clocksource_cyc2ns with absolute cycle count

Re: [PATCH 4/4] timekeeping: clocksource_cyc2ns: Document intended range limitation

2016-11-21 Thread Chris Metcalf
On 11/21/2016 3:54 AM, Ingo Molnar wrote: * John Stultz wrote: From: Chris Metcalf The "cycles" argument should not be an absolute clocksource cycle value, as the implementation's arithmetic will overflow relatively easily with wide (64 bit) clocksource counters. For p

Re: [PATCH v2] tile: avoid using clocksource_cyc2ns with absolute cycle count

2016-11-18 Thread Chris Metcalf
On 11/18/2016 5:34 AM, Peter Zijlstra wrote: On Thu, Nov 17, 2016 at 03:00:14PM -0500, Chris Metcalf wrote: On 11/17/2016 4:53 AM, Peter Zijlstra wrote: On Wed, Nov 16, 2016 at 03:16:59PM -0500, Chris Metcalf wrote: PeterZ (cc'ed) then improved it to use __int128 math via mul_u64_u3

Re: [PATCH v2] tile: avoid using clocksource_cyc2ns with absolute cycle count

2016-11-17 Thread Chris Metcalf
On 11/17/2016 4:53 AM, Peter Zijlstra wrote: On Wed, Nov 16, 2016 at 03:16:59PM -0500, Chris Metcalf wrote: PeterZ (cc'ed) then improved it to use __int128 math via mul_u64_u32_shr(), but that doesn't help tile; we only do one multiply instead of two, but the multiply is handled by

Re: [PATCH v2] tile: avoid using clocksource_cyc2ns with absolute cycle count

2016-11-16 Thread Chris Metcalf
On 11/16/2016 2:59 PM, John Stultz wrote: On Wed, Nov 16, 2016 at 11:35 AM, Chris Metcalf wrote: For large values of "mult" and long uptimes, the intermediate result of "cycles * mult" can overflow 64 bits. For example, the tile platform calls clocksource_cyc2ns with a 1.

Re: [PATCH] clocksource_cyc2ns: avoid overflowing 64 bits

2016-11-16 Thread Chris Metcalf
On 11/16/2016 2:45 PM, John Stultz wrote: On Wed, Nov 16, 2016 at 11:30 AM, Chris Metcalf wrote: diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h index 08398182f56e..529884b8 100644 --- a/include/linux/clocksource.h +++ b/include/linux/clocksource.h @@ -171,6 +171,10

[PATCH v2] time: Avoid signed overflow in timekeeping_delta_to_ns()

2016-11-16 Thread Chris Metcalf
way by changing the type of "nsec" to unsigned and adding a comment explaining why. Signed-off-by: Chris Metcalf --- v2: just use "u64 nsec" to fix the signed shift problem kernel/time/timekeeping.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCH] clocksource_cyc2ns: avoid overflowing 64 bits

2016-11-16 Thread Chris Metcalf
On 11/16/2016 1:04 PM, John Stultz wrote: On Wed, Nov 16, 2016 at 8:57 AM, Chris Metcalf wrote: include/linux/clocksource.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h index 08398182f56e..b2a022acf232 100644

Re: [PATCH] clocksource_cyc2ns: avoid overflowing 64 bits

2016-11-16 Thread Chris Metcalf
On 11/16/2016 3:00 PM, John Stultz wrote: On Wed, Nov 16, 2016 at 11:56 AM, Chris Metcalf wrote: On 11/16/2016 2:45 PM, John Stultz wrote: On Wed, Nov 16, 2016 at 11:30 AM, Chris Metcalf wrote: diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h index 08398182f56e

[PATCH v2] tile: avoid using clocksource_cyc2ns with absolute cycle count

2016-11-16 Thread Chris Metcalf
() is intended to be used for relative cycle counts, not absolute cycle counts, performance is more importance than accepting a wider range of cycle values. So, just use mult_frac() directly in tile's sched_clock(). Signed-off-by: Chris Metcalf --- Blackfin should make a similar change in th

[PATCH] clocksource_cyc2ns: avoid overflowing 64 bits

2016-11-16 Thread Chris Metcalf
same as the fix for arch/x86 __cycles_2_ns() in commit 4cecf6d401a0 ("sched, x86: Avoid unnecessary overflow in sched_clock"), using the new mult_frac() helper. In addition to tile, arm/plat-omap and blackfin also use this helper function, so will presumably hit similar issues. Signed

[GIT PULL] arch/tile bugfix for 4.9-rc6

2016-11-14 Thread Chris Metcalf
Linus, Please pull the following change for 4.9-rc6 from: git://git.kernel.org/pub/scm/linux/kernel/git/cmetcalf/linux-tile.git stable This just fixes an incompatibility with tile __ro_after_init. Chris Metcalf (1): tile: handle __ro_after_init like parisc does arch/tile/include/asm

[PATCH v2] tile: handle __ro_after_init like parisc does

2016-11-14 Thread Chris Metcalf
. __read_mostly. Signed-off-by: Chris Metcalf --- arch/tile/include/asm/cache.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/tile/include/asm/cache.h b/arch/tile/include/asm/cache.h index 6160761d5f61..4810e48dbbbf 100644 --- a/arch/tile/include/asm/cache.h +++ b/arch/tile/include/asm

[PATCH] time: Avoid signed overflow in timekeeping_delta_to_ns()

2016-11-14 Thread Chris Metcalf
This bugfix was originally made in commit 35a4933a8959 ("time: Avoid signed overflow in timekeeping_get_ns()"). When the code was refactored in commit 6bd58f09e1d8 ("time: Add cycles to nanoseconds translation") the signed overflow fix was lost. Re-introduce it. Signed-o

[PATCH] tile-srom: allow the driver to be built as a module

2016-11-07 Thread Chris Metcalf
The code was already configured that way, but the Kconfig file didn't support requesting it. A buglet caused a null pointer deref when unloading the module, but this commit also corrects that issue. Signed-off-by: Chris Metcalf --- This is in response to Paul's patch (see the i

[PATCH] tile: handle RO_AFTER_INIT_DATA

2016-11-07 Thread Chris Metcalf
This is the minimal change to handle RO_AFTER_INIT_DATA. The tile architecture already marks RO_DATA as read-only in the kernel, so grouping RO_AFTER_INIT_DATA with RO_DATA, as is done by default, means the kernel faults in init when it tries to write to RO_AFTER_INIT_DATA. For now, just move it p

task isolation discussion at Linux Plumbers

2016-11-04 Thread Chris Metcalf
fix this for tile and arm64 in my patch series; Thomas volunteered to look at adding equivalent support for x86. Many thanks to all those who participated in the discussion. Frederic, we wished you had been there! -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH 01/18] 32-bit ABI: introduce ARCH_32BIT_OFF_T config option

2016-10-24 Thread Chris Metcalf
tile" here is particularly confusing, since there are no architectures except tile that use the __SYSCALL_COMPAT functionality in the current tree. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH 02/18] arm64: ilp32: add documentation on the ILP32 ABI for ARM64

2016-10-24 Thread Chris Metcalf
actual implementation definition, like "have their top 32 bits zeroed". +AARCH64/ILP32 provides next types turned to 64-bit (comparing to AARCH32): What does "turned" mean here? And I "next types" isn't standard English; you want to say something like &quo

Re: Ping: [PATCH v15 00/13] support "task_isolation" mode

2016-09-30 Thread Chris Metcalf
On 9/27/2016 10:35 AM, Frederic Weisbecker wrote: On 8/16/2016 5:19 PM, Chris Metcalf wrote: Here is a respin of the task-isolation patch set. Again, I have been getting email asking me when and where this patch will be upstreamed so folks can start using it. I had been thinking the obvious

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-09-30 Thread Chris Metcalf
On 8/30/2016 2:43 PM, Andy Lutomirski wrote: On Aug 30, 2016 10:02 AM, "Chris Metcalf" wrote: We really want to run task isolation last, so we can guarantee that all the isolation prerequisites are met (dynticks stopped, per-cpu lru cache empty, etc). But achieving that state c

Re: [PATCH] arch/arm: enable task isolation functionality

2016-09-26 Thread Chris Metcalf
dable at least) with any further changes. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH v2 09/11] tile/tracing: fix compat syscall handling

2016-09-20 Thread Chris Metcalf
On 9/16/2016 3:11 AM, Marcin Nowakowski wrote: Add missing arch code - arch_trace_is_compat_syscall and arch_syscall_addr Signed-off-by: Marcin Nowakowski Cc:Cc: Steven Rostedt Cc: Ingo Molnar Cc: Chris Metcalf --- arch/tile/include/asm/ftrace.h | 10 ++ arch/tile/kernel/Makefile

Re: [PATCH] tile: migrate exception table users off module.h and onto extable.h

2016-09-20 Thread Chris Metcalf
x27;t really need to compile these files. Cc: Chris Metcalf Signed-off-by: Paul Gortmaker --- [see:https://lkml.org/lkml/2016/7/24/224 for additional context if needed] arch/tile/kernel/unaligned.c | 2 +- arch/tile/mm/extable.c | 2 +- arch/tile/mm/fault.c | 2 +- 3 files c

Re: Ping: [PATCH v15 00/13] support "task_isolation" mode

2016-09-13 Thread Chris Metcalf
uration and boot argument details. I can work on that and also write some doc (Documentation/task-isolation.txt ?). Sure, documentation is always welcome! -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-09-12 Thread Chris Metcalf
On 9/12/2016 1:41 PM, Andy Lutomirski wrote: On Sep 9, 2016 1:40 PM, "Chris Metcalf" wrote: On 9/2/2016 1:28 PM, Andy Lutomirski wrote: On Sep 2, 2016 7:04 AM, "Chris Metcalf" wrote: On 8/30/2016 3:50 PM, Andy Lutomirski wrote: On Tue, Aug 30, 2016 at 12:37 PM, Chris Me

Re: Ping: [PATCH v15 00/13] support "task_isolation" mode

2016-09-12 Thread Chris Metcalf
On 9/7/2016 5:11 PM, Francis Giraldeau wrote: On 2016-08-29 12:27 PM, Chris Metcalf wrote: On 8/16/2016 5:19 PM, Chris Metcalf wrote: Here is a respin of the task-isolation patch set. No concerns have been raised yet with the v15 version of the patch series in the two weeks since I posted it

Re: [PATCH v14 04/14] task_isolation: add initial support

2016-09-09 Thread Chris Metcalf
On 9/3/2016 11:31 AM, Frederic Weisbecker wrote: On Tue, Aug 30, 2016 at 02:17:27PM -0400, Chris Metcalf wrote: On 8/30/2016 1:36 PM, Chris Metcalf wrote: See the other thread with Peter Z for the longer discussion of this. At this point I'm leaning towards replacing the set_tsk_need_re

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-09-09 Thread Chris Metcalf
On 9/2/2016 1:28 PM, Andy Lutomirski wrote: On Sep 2, 2016 7:04 AM, "Chris Metcalf" wrote: On 8/30/2016 3:50 PM, Andy Lutomirski wrote: On Tue, Aug 30, 2016 at 12:37 PM, Chris Metcalf wrote: On 8/30/2016 2:43 PM, Andy Lutomirski wrote: What if we did it the other way around: se

Re: [RFC v4 10/22] arch/tile/kernel/time: set ->min_delta_ticks and ->max_delta_ticks

2016-09-09 Thread Chris Metcalf
On 9/8/2016 7:21 AM, Nicolai Stange wrote: Chris Metcalf writes: On 08/22/2016 07:33 PM, Nicolai Stange wrote: With the yet to come introduction of NTP correction awareness to the clockevent core, drivers should report their valid ranges in units of cycles to the latter. Currently, the

[PATCH] tile: remove #pragma unroll from finv_buffer_remote()

2016-09-06 Thread Chris Metcalf
n any case, so the extra optimization here was mostly just for it's own sake. Signed-off-by: Chris Metcalf --- arch/tile/lib/cacheflush.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/arch/tile/lib/cacheflush.c b/arch/tile/lib/cacheflush.c index 9c0ec22009a

Re: [RFC v4 10/22] arch/tile/kernel/time: set ->min_delta_ticks and ->max_delta_ticks

2016-09-06 Thread Chris Metcalf
e. Initialize ->min_delta_ticks and ->max_delta_ticks with these values. Signed-off-by: Nicolai Stange --- arch/tile/kernel/time.c | 2 ++ 1 file changed, 2 insertions(+) Thanks. Taken into the tile tree. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH 0/2] tile-module: Fine-tuning for module_alloc()

2016-09-06 Thread Chris Metcalf
+-- 1 file changed, 5 insertions(+), 6 deletions(-) Thanks! Taken into the tile tree. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-09-02 Thread Chris Metcalf
On 8/30/2016 3:50 PM, Andy Lutomirski wrote: On Tue, Aug 30, 2016 at 12:37 PM, Chris Metcalf wrote: On 8/30/2016 2:43 PM, Andy Lutomirski wrote: What if we did it the other way around: set a percpu flag saying "going quiescent; disallow new deferred work", then finish all existin

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-09-02 Thread Chris Metcalf
On 9/1/2016 6:06 AM, Peter Zijlstra wrote: On Tue, Aug 30, 2016 at 11:32:16AM -0400, Chris Metcalf wrote: On 8/30/2016 3:58 AM, Peter Zijlstra wrote: What !? I really don't get this, what are you waiting for? Why is rescheduling making things better. We need to wait for the last dynti

Re: [PATCH v14 04/14] task_isolation: add initial support

2016-08-30 Thread Chris Metcalf
On 8/30/2016 1:10 PM, Frederic Weisbecker wrote: On Tue, Aug 30, 2016 at 11:41:36AM -0400, Chris Metcalf wrote: On 8/29/2016 8:55 PM, Frederic Weisbecker wrote: On Mon, Aug 15, 2016 at 10:59:55AM -0400, Chris Metcalf wrote: On 8/11/2016 2:50 PM, Christoph Lameter wrote: On Thu, 11 Aug 2016

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-08-30 Thread Chris Metcalf
On 8/30/2016 2:43 PM, Andy Lutomirski wrote: On Aug 30, 2016 10:02 AM, "Chris Metcalf" wrote: On 8/30/2016 12:30 PM, Andy Lutomirski wrote: On Tue, Aug 30, 2016 at 8:32 AM, Chris Metcalf wrote: The basic idea is just that we don't want to be at risk from the dyntick

Re: [PATCH v14 04/14] task_isolation: add initial support

2016-08-30 Thread Chris Metcalf
On 8/30/2016 1:36 PM, Chris Metcalf wrote: See the other thread with Peter Z for the longer discussion of this. At this point I'm leaning towards replacing the set_tsk_need_resched() with set_current_state(TASK_INTERRUPTIBLE); schedule(); __set_current_state(TASK_RUNNING

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-08-30 Thread Chris Metcalf
On 8/30/2016 12:30 PM, Andy Lutomirski wrote: On Tue, Aug 30, 2016 at 8:32 AM, Chris Metcalf wrote: On 8/30/2016 3:58 AM, Peter Zijlstra wrote: On Mon, Aug 29, 2016 at 12:40:32PM -0400, Chris Metcalf wrote: On 8/29/2016 12:33 PM, Peter Zijlstra wrote: On Tue, Aug 16, 2016 at 05:19:27PM

Re: [PATCH v14 04/14] task_isolation: add initial support

2016-08-30 Thread Chris Metcalf
On 8/29/2016 8:55 PM, Frederic Weisbecker wrote: On Mon, Aug 15, 2016 at 10:59:55AM -0400, Chris Metcalf wrote: On 8/11/2016 2:50 PM, Christoph Lameter wrote: On Thu, 11 Aug 2016, Frederic Weisbecker wrote: Do we need to quiesce vmstat everytime before entering userspace? I thought that

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-08-30 Thread Chris Metcalf
On 8/30/2016 3:58 AM, Peter Zijlstra wrote: On Mon, Aug 29, 2016 at 12:40:32PM -0400, Chris Metcalf wrote: On 8/29/2016 12:33 PM, Peter Zijlstra wrote: On Tue, Aug 16, 2016 at 05:19:27PM -0400, Chris Metcalf wrote: + /* +* Request rescheduling unless we are in full dynticks mode

Ping: [PATCH v15 00/13] support "task_isolation" mode

2016-08-29 Thread Chris Metcalf
On 8/16/2016 5:19 PM, Chris Metcalf wrote: Here is a respin of the task-isolation patch set. Again, I have been getting email asking me when and where this patch will be upstreamed so folks can start using it. I had been thinking the obvious path was via Frederic Weisbecker to Ingo as a NOHZ

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-08-29 Thread Chris Metcalf
On 8/29/2016 12:48 PM, Peter Zijlstra wrote: On Mon, Aug 29, 2016 at 12:40:32PM -0400, Chris Metcalf wrote: On 8/29/2016 12:33 PM, Peter Zijlstra wrote: On Tue, Aug 16, 2016 at 05:19:27PM -0400, Chris Metcalf wrote: + /* +* Request rescheduling unless we are in full dynticks

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-08-29 Thread Chris Metcalf
On 8/29/2016 12:33 PM, Peter Zijlstra wrote: On Tue, Aug 16, 2016 at 05:19:27PM -0400, Chris Metcalf wrote: + /* +* Request rescheduling unless we are in full dynticks mode. +* We would eventually get pre-empted without this, and if +* there's another task wa

Re: [PATCH] tile/pci_gx: fix spelling mistake: "delievered" -> "delivered"

2016-08-29 Thread Chris Metcalf
On 8/18/2016 11:42 AM, Colin King wrote: From: Colin Ian King trivial fix to spelling mistake in pr_warn message Signed-off-by: Colin Ian King --- arch/tile/kernel/pci_gx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks; taken into the tile tree! -- Chris Metcalf, Mellanox

[PATCH v9 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-08-29 Thread Chris Metcalf
racing API (sparc64 and mips) are converted to use the cpumask approach rather than the all/allbutself approach. The mips code ignored the "include_self" boolean but with this change it will now also dump a local backtrace if requested. Signed-off-by: Chris Metcalf Reviewed-by: Aaron Tomli

[PATCH v9 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI

2016-08-29 Thread Chris Metcalf
register state will be missing, but that state is likely not particularly helpful in any case. Or, if we think it is helpful, we should be capturing and emitting the current register state in all cases when regs == NULL is passed to nmi_cpu_backtrace(). Signed-off-by: Chris Metcalf Acked-by

[PATCH v9 3/4] arch/tile: adopt the new nmi_backtrace framework

2016-08-29 Thread Chris Metcalf
backtrace if the old one was still in progress. Signed-off-by: Chris Metcalf --- arch/tile/include/asm/irq.h | 5 ++-- arch/tile/kernel/pmc.c | 3 -- arch/tile/kernel/process.c | 73 +++-- arch/tile/kernel/traps.c| 9 -- 4 files changed, 27

  1   2   3   4   5   6   7   8   9   10   >