Re: [PATCH v5 1/9] lib: zstd: Add zstd compatibility wrapper

2020-11-10 Thread Chris Mason
On 10 Nov 2020, at 13:39, Christoph Hellwig wrote: On Mon, Nov 09, 2020 at 02:01:41PM -0500, Chris Mason wrote: You do consistently ask for a shim layer, but you haven???t explained what we gain by diverging from the documented and tested API of the upstream zstd project. It???s an important

Re: [PATCH v5 1/9] lib: zstd: Add zstd compatibility wrapper

2020-11-09 Thread Chris Mason
On 6 Nov 2020, at 13:38, Christoph Hellwig wrote: You just keep resedning this crap, don't you? Haven't you been told multiple times to provide a proper kernel API by now? You do consistently ask for a shim layer, but you haven’t explained what we gain by diverging from the documented and

Re: [PATCH] fix scheduler regression from "sched/fair: Rework load_balance()"

2020-10-26 Thread Chris Mason
On 26 Oct 2020, at 12:20, Vincent Guittot wrote: Le lundi 26 oct. 2020 à 12:04:45 (-0400), Rik van Riel a écrit : On Mon, 26 Oct 2020 16:42:14 +0100 Vincent Guittot wrote: On Mon, 26 Oct 2020 at 16:04, Rik van Riel wrote: Could utilization estimates be off, either lagging or simply having

Re: [PATCH] fix scheduler regression from "sched/fair: Rework load_balance()"

2020-10-26 Thread Chris Mason
On 26 Oct 2020, at 11:05, Chris Mason wrote: On 26 Oct 2020, at 10:24, Vincent Guittot wrote: Could you try the fix below ? --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -9049,7 +9049,8 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s

Re: [PATCH] fix scheduler regression from "sched/fair: Rework load_balance()"

2020-10-26 Thread Chris Mason
On 26 Oct 2020, at 10:24, Vincent Guittot wrote: Le lundi 26 oct. 2020 à 08:45:27 (-0400), Chris Mason a écrit : On 26 Oct 2020, at 4:39, Vincent Guittot wrote: Hi Chris On Sat, 24 Oct 2020 at 01:49, Chris Mason wrote: Hi everyone, We’re validating a new kernel in the fleet, and

Re: [PATCH] fix scheduler regression from "sched/fair: Rework load_balance()"

2020-10-26 Thread Chris Mason
On 26 Oct 2020, at 4:39, Vincent Guittot wrote: Hi Chris On Sat, 24 Oct 2020 at 01:49, Chris Mason wrote: Hi everyone, We’re validating a new kernel in the fleet, and compared with v5.2, Which version are you using ? several improvements have been added since v5.5 and the rework of

[PATCH] fix scheduler regression from "sched/fair: Rework load_balance()"

2020-10-23 Thread Chris Mason
Hi everyone, We’re validating a new kernel in the fleet, and compared with v5.2, performance is ~2-3% lower for some of our workloads. After some digging, Johannes found that our involuntary context switch rate was ~2x higher, and we were leaving a CPU idle a higher percentage of the time, e

Re: [PATCH v4 0/9] Update to zstd-1.4.6

2020-10-02 Thread Chris Mason
On 2 Oct 2020, at 2:54, Christoph Hellwig wrote: On Wed, Sep 30, 2020 at 08:05:45PM +, Nick Terrell wrote: On Sep 29, 2020, at 11:53 PM, Christoph Hellwig wrote: As you keep resend this I keep retelling you that should not do it. Please provide a proper Linux API, and switch to that.

Re: [PATCH 5/9] btrfs: zstd: Switch to the zstd-1.4.6 API

2020-09-17 Thread Chris Mason
On 17 Sep 2020, at 6:04, Christoph Hellwig wrote: On Wed, Sep 16, 2020 at 09:35:51PM -0400, Rik van Riel wrote: One possibility is to have a kernel wrapper on top of the zstd API to make it more ergonomic. I personally don???t really see the value in it, since it adds another layer of indire

Re: [PATCH 5/9] btrfs: zstd: Switch to the zstd-1.4.6 API

2020-09-16 Thread Chris Mason
On 16 Sep 2020, at 4:49, Christoph Hellwig wrote: On Tue, Sep 15, 2020 at 08:42:59PM -0700, Nick Terrell wrote: From: Nick Terrell Move away from the compatibility wrapper to the zstd-1.4.6 API. This code is functionally equivalent. Again, please use sensible names And no one gives a fuck

Re: [PATCH 5/9] btrfs: zstd: Switch to the zstd-1.4.6 API

2020-09-16 Thread Chris Mason
On 16 Sep 2020, at 10:46, Christoph Hellwig wrote: On Wed, Sep 16, 2020 at 10:43:04AM -0400, Chris Mason wrote: Otherwise we just end up with drift and kernel-specific bugs that are harder to debug. To the extent those APIs make us contort the kernel code, I???m sure Nick is interested in

Re: [PATCH 5/9] btrfs: zstd: Switch to the zstd-1.4.6 API

2020-09-16 Thread Chris Mason
On 16 Sep 2020, at 10:30, Christoph Hellwig wrote: On Wed, Sep 16, 2020 at 10:20:52AM -0400, Chris Mason wrote: It???s not completely clear what you???re asking for here. If the API matches what???s in zstd-1.4.6, that seems like a reasonable way to label it. That???s what the upstream is

Re: [PATCH] mm : fix pte _PAGE_DIRTY bit when fallback migrate page

2020-07-17 Thread Chris Mason
still have _PAGE_RW, when the next mmap write occurs, we don't need to trigger the page_mkwrite again. I don’t know the page migration code well, but you’ll need this one as well on the 4.4 kernel you mentioned: commit 25f3c5021985e885292980d04a1423fd83c967bb Author: Chris Mason Date:

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Chris Mason
On 6 Jul 2020, at 10:06, Laurent Pinchart wrote: Hi Chris, On Mon, Jul 06, 2020 at 12:45:34PM +, Chris Mason via Ksummit-discuss wrote: On 5 Jul 2020, at 0:55, Willy Tarreau wrote: Maybe instead of providing an explicit list of a few words it should simply say that terms that take

Re: [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Chris Mason
On 5 Jul 2020, at 0:55, Willy Tarreau wrote: > On Sat, Jul 04, 2020 at 01:02:51PM -0700, Dan Williams wrote: >> +Non-inclusive terminology has that same distracting effect which is >> why >> +it is a style issue for Linux, it injures developer efficiency. > > I'm personally thinking that for a no

Re: [PATCH btrfs/for-next] btrfs: fix fatal extent_buffer readahead vs releasepage race

2020-06-17 Thread Chris Mason
On 17 Jun 2020, at 13:20, Filipe Manana wrote: On Wed, Jun 17, 2020 at 5:32 PM Boris Burkov wrote: --- fs/btrfs/extent_io.c | 45 1 file changed, 29 insertions(+), 16 deletions(-) diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index c

Re: [PATCH 10/12] btrfs: flag files as supporting buffered async reads

2020-05-26 Thread Chris Mason
On 26 May 2020, at 15:51, Jens Axboe wrote: > btrfs uses generic_file_read_iter(), which already supports this. > > Signed-off-by: Jens Axboe Really looking forward to this! Acked-by: Chris Mason

Re: linux-next: cleanup the btrfs trees

2019-10-21 Thread Chris Mason
On 19 Oct 2019, at 23:47, Stephen Rothwell wrote: > Hi all, > > The btrfs tree > (git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git#next) > has not bee updated in more than a year, so I have removed it and then > renamed the btrfs-kdave tree to btrfs. I hope this is OK and if an

Re: linux-next: Signed-off-by missing for commits in the net-next tree

2019-08-16 Thread Chris Mason
On 16 Aug 2019, at 5:15, Andy Grover wrote: > On 8/16/19 3:06 PM, Gerd Rausch wrote: >> Hi, >> >> Just added the e-mail addresses I found using a simple "google >> search", >> in order to reach out to the original authors of these commits: >> C

Re: [RFC PATCH 00/11] bpf, trace, dtrace: DTrace BPF program type implementation and sample use

2019-05-31 Thread Chris Mason
I'm being pretty liberal with chopping down quoted material to help emphasize a particular opinion about how to bootstrap existing out-of-tree projects into the kernel. My goal here is to talk more about the process and less about the technical details, so please forgive me if I've ignored or

Re: [PATCH] fs,xfs: fix missed wakeup on l_flush_wait

2019-05-08 Thread Chris Mason
it the lost wakeup in prod. I could search through all the related hung task timeouts, but they are probably all stuck in blkmq. Acked-but-I'm-still-blaming-Jens-by: Chris Mason -chris

Re: [PATCH 1/2] Revert "mm: don't reclaim inodes with many attached pages"

2019-01-31 Thread Chris Mason
On 30 Jan 2019, at 20:34, Dave Chinner wrote: > On Wed, Jan 30, 2019 at 12:21:07PM +0000, Chris Mason wrote: >> >> >> On 29 Jan 2019, at 23:17, Dave Chinner wrote: >> >>> From: Dave Chinner >>> >>> This reverts commit a76cf1a474d7dbcd9336b5

Re: [PATCH 1/2] Revert "mm: don't reclaim inodes with many attached pages"

2019-01-30 Thread Chris Mason
On 29 Jan 2019, at 23:17, Dave Chinner wrote: > From: Dave Chinner > > This reverts commit a76cf1a474d7dbcd9336b5f5afb0162baa142cf0. > > This change causes serious changes to page cache and inode cache > behaviour and balance, resulting in major performance regressions > when combining worklao

Re: [LKP] [lkp-robot] [brd] 316ba5736c: aim7.jobs-per-min -11.2% regression

2018-12-19 Thread Chris Mason
On 18 Dec 2018, at 13:57, Jens Axboe wrote: > On 12/18/18 2:11 AM, kemi wrote: >> Hi, All >> Do we have special reason to keep this patch (316ba5736c9:brd: Mark >> as non-rotational). >> which leads to a performance regression when BRD is used as a disk on >> btrfs. > > I really suspect that t

Linux Foundation Technical Advisory Board Elections -- Call for nominations

2018-11-04 Thread Chris Mason
he deadline for nominations is right before voting begins, any statements must be received by Monday November 12th at 5PM Pacific, so that we have time to setup the slideshow. Current TAB members, and their election year: Chris Mason 2016 H. Peter Anvin 2016 Olof Johansson 2016 Rik van Riel2016 Da

Linux Foundation Technical Advisory Board Elections -- Call for nominations

2018-10-22 Thread Chris Mason
ng begins, any statements must be received by Monday November 12th at 5PM Pacific, so that we have time to setup the slideshow. Current TAB members, and their election year: Chris Mason 2016 H. Peter Anvin 2016 Olof Johansson 2016 Rik van Riel2016 Dan Williams 2016 Jon Corbet 2017 Greg Kroah-Hart

Re: [PATCH 2/2] code-of-conduct: Strip the enforcement paragraph pending community discussion

2018-10-08 Thread Chris Mason
On 6 Oct 2018, at 17:37, James Bottomley wrote: Significant concern has been expressed about the responsibilities outlined in the enforcement clause of the new code of conduct. Since there is concern that this becomes binding on the release of the 4.19 kernel, strip the enforcement clauses to

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

2018-03-06 Thread Chris Mason
On 6 Mar 2018, at 11:12, Linus Torvalds wrote: On Mon, Mar 5, 2018 at 5:34 PM, Alexei Starovoitov wrote: As the first step in development of bpfilter project [1] the request_module() code is extended to allow user mode helpers to be invoked. Idea is that user mode helpers are built as part of

Re: [PATCHSET v2] cgroup, writeback, btrfs: make sure btrfs issues metadata IOs from the root cgroup

2017-11-30 Thread Chris Mason
On 11/30/2017 12:23 PM, David Sterba wrote: On Wed, Nov 29, 2017 at 01:38:26PM -0500, Chris Mason wrote: On 11/29/2017 12:05 PM, Tejun Heo wrote: On Wed, Nov 29, 2017 at 09:03:30AM -0800, Tejun Heo wrote: Hello, On Wed, Nov 29, 2017 at 05:56:08PM +0100, Jan Kara wrote: What has happened

Re: [PATCHSET v2] cgroup, writeback, btrfs: make sure btrfs issues metadata IOs from the root cgroup

2017-11-29 Thread Chris Mason
On 11/29/2017 12:05 PM, Tejun Heo wrote: On Wed, Nov 29, 2017 at 09:03:30AM -0800, Tejun Heo wrote: Hello, On Wed, Nov 29, 2017 at 05:56:08PM +0100, Jan Kara wrote: What has happened with this patch set? No idea. cc'ing Chris directly. Chris, if the patchset looks good, can you please rout

Reminder v2: Linux Foundation Technical Advisory Board Elections -- Call for nominations

2017-10-22 Thread Chris Mason
https://goo.gl/ADVFtT The deadline for receiving nominations is up until the beginning of the election event. Any statements for the online document need to be sent by Monday Oct 23rd. Please get your nomination in early so everyone has a chance to review the nominations before voting. Chris Mason

Reminder: Linux Foundation Technical Advisory Board Elections -- Call for nominations

2017-10-16 Thread Chris Mason
oo.gl/ADVFtT The deadline for receiving nominations is up until the beginning of the election event. Any statements for the online document need to be sent by Monday Oct 23rd. Please get your nomination in early so everyone has a chance to review the nominations before voting. Chris Mason, TAB Chai

Linux Foundation Technical Advisory Board Elections -- Call for nominations

2017-10-09 Thread Chris Mason
tions before voting. Chris Mason, TAB Chair [1] TAB members sit for a term of two years, and half of the board is up for election every year. Five of the seats are up for election now. The other five are halfway through their term and will be up for election next year.

Linux Foundation Technical Advisory Board Elections -- Call for nominations

2017-10-09 Thread Chris Mason
tions before voting. Chris Mason, TAB Chair [1] TAB members sit for a term of two years, and half of the board is up for election every year. Five of the seats are up for election now. The other five are halfway through their term and will be up for election next year.

[GIT PULL v2] zstd support (lib, btrfs, squashfs, nocrypto)

2017-09-11 Thread Chris Mason
Hi Linus, Nick Terrell's patch series to add zstd support to the kernel has been floating around for a while. After talking with Dave Sterba, Herbert and Phillip, we decided to send the whole thing in as one pull request. Herbert had asked about the crypto patch when we discussed the pull, but I

Re: [GIT PULL] zstd support (lib, btrfs, squashfs)

2017-09-08 Thread Chris Mason
On Sat, Sep 09, 2017 at 09:35:59AM +0800, Herbert Xu wrote: On Fri, Sep 08, 2017 at 03:33:05PM -0400, Chris Mason wrote: crypto/Kconfig |9 + crypto/Makefile|1 + crypto/testmgr.c | 10 + crypto/testmgr.h | 71 + crypto/zstd.c

Re: [GIT PULL] zstd support (lib, btrfs, squashfs)

2017-09-08 Thread Chris Mason
On 09/08/2017 03:33 PM, Chris Mason wrote: Hi Linus, Nick Terrell's patch series to add zstd support to the kernel has been floating around for a while. After talking with Dave Sterba, Herbert and Phillip, we decided to send the whole thing in as one pull request. I have it in my

[GIT PULL] zstd support (lib, btrfs, squashfs)

2017-09-08 Thread Chris Mason
Hi Linus, Nick Terrell's patch series to add zstd support to the kernel has been floating around for a while. After talking with Dave Sterba, Herbert and Phillip, we decided to send the whole thing in as one pull request. I have it in my zstd branch: git://git.kernel.org/pub/scm/linux/kernel/gi

Re: [PATCH v5 2/5] lib: Add zstd modules

2017-08-11 Thread Chris Mason
On 08/10/2017 03:25 PM, Hugo Mills wrote: On Thu, Aug 10, 2017 at 01:41:21PM -0400, Chris Mason wrote: On 08/10/2017 04:30 AM, Eric Biggers wrote: Theses benchmarks are misleading because they compress the whole file as a single stream without resetting the dictionary, which isn't how

Re: [PATCH v5 2/5] lib: Add zstd modules

2017-08-10 Thread Chris Mason
On 08/10/2017 03:00 PM, Eric Biggers wrote: On Thu, Aug 10, 2017 at 01:41:21PM -0400, Chris Mason wrote: On 08/10/2017 04:30 AM, Eric Biggers wrote: On Wed, Aug 09, 2017 at 07:35:53PM -0700, Nick Terrell wrote: The memory reported is the amount of memory the compressor requests. | Method

Re: [PATCH v5 2/5] lib: Add zstd modules

2017-08-10 Thread Chris Mason
On 08/10/2017 04:30 AM, Eric Biggers wrote: On Wed, Aug 09, 2017 at 07:35:53PM -0700, Nick Terrell wrote: The memory reported is the amount of memory the compressor requests. | Method | Size (B) | Time (s) | Ratio | MB/s| Adj MB/s | Mem (MB) | |--|--|--|---|-

Re: Moving ndctl development into the kernel tree?

2017-07-25 Thread Chris Mason
On 07/22/2017 02:49 PM, Dan Williams wrote: On Fri, Jul 21, 2017 at 7:52 PM, Dan Williams wrote: [ adding Chris ] On Fri, Jul 21, 2017 at 4:44 PM, Dan Williams wrote: On Fri, Jul 21, 2017 at 3:58 PM, Ingo Molnar wrote: * Dan Williams wrote: [...] * Like perf, ndctl borrows the sub-com

[GIT PULL] Btrfs

2017-06-10 Thread Chris Mason
Hi Linus, My for-linus-4.12 branch has some fixes that Dave Sterba collected: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.12 We've been hitting an early enospc problem on production machines that Omar tracked down to an old int->u64 mistake. I waited a bit o

Re: hackbench vs select_idle_sibling; was: [tip:sched/core] sched/fair, cpumask: Export for_each_cpu_wrap()

2017-06-09 Thread Chris Mason
On 06/06/2017 05:21 AM, Peter Zijlstra wrote: On Mon, Jun 05, 2017 at 02:00:21PM +0100, Matt Fleming wrote: On Fri, 19 May, at 04:00:35PM, Matt Fleming wrote: On Wed, 17 May, at 12:53:50PM, Peter Zijlstra wrote: Please test.. Results are still coming in but things do look better with your p

Re: hackbench vs select_idle_sibling; was: [tip:sched/core] sched/fair, cpumask: Export for_each_cpu_wrap()

2017-05-17 Thread Chris Mason
On 05/17/2017 06:53 AM, Peter Zijlstra wrote: On Mon, May 15, 2017 at 02:03:11AM -0700, tip-bot for Peter Zijlstra wrote: sched/fair, cpumask: Export for_each_cpu_wrap() -static int cpumask_next_wrap(int n, const struct cpumask *mask, int start, int *wrapped) -{ - next = find_next_b

Re: [GIT PULL] Btrfs

2017-05-09 Thread Chris Mason
On 05/09/2017 01:56 PM, Chris Mason wrote: > Hi Linus, > > My for-linus-4.12 branch: > > git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git > for-linus-4.12 I hit send too soon, sorry. There's a trivial conflict with our WARN_ON fix that went i

[GIT PULL] Btrfs

2017-05-09 Thread Chris Mason
OT (+23/-1) btrfs: No need to check !(flags & MS_RDONLY) twice (+1/-2) Chris Mason (1) commits (+2/-2): btrfs: fix the gfp_mask for the reada_zones radix tree Adam Borowski (1) commits (+9/-3): btrfs: fix a bogus warning when converting only data or metadata Deepa Dinamani (1)

Re: [PATCH] btrfs: always write superblocks synchronously

2017-05-03 Thread Chris Mason
On 05/03/2017 04:36 AM, Jan Kara wrote: On Tue 02-05-17 09:28:13, Davidlohr Bueso wrote: Commit b685d3d65ac7 "block: treat REQ_FUA and REQ_PREFLUSH as synchronous" removed REQ_SYNC flag from WRITE_FUA implementation. Since REQ_FUA and REQ_FLUSH flags are stripped from submitted IO when the dis

[GIT PULL] Btrfs

2017-04-27 Thread Chris Mason
Hi Linus, We have one more for btrfs: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.11 This is dropping a new WARN_ON from rc1 that ended up making more noise than we really want. The larger fix for the underflow got delayed a bit and it's better for now to

Re: [PATCH 2/2] sched/fair: Always propagate runnable_load_avg

2017-04-25 Thread Chris Mason
On 04/25/2017 04:49 PM, Tejun Heo wrote: On Tue, Apr 25, 2017 at 11:49:41AM -0700, Tejun Heo wrote: Will try that too. I can't see why HT would change it because I see single CPU queues misevaluated. Just in case, you need to tune the test params so that it doesn't load the machine too much

[GIT PULL] Btrfs

2017-04-14 Thread Chris Mason
Hi Linus Dave Sterba collected a few more fixes for the last rc: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.11 These aren't marked for stable, but I'm putting them in with a batch were testing/sending by hand for this release. Liu Bo (3) commits (+11/-13

[GIT PULL] Btrfs

2017-03-31 Thread Chris Mason
Hi Linus, We have 3 small fixes queued up in my for-linus-4.11 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.11 Goldwyn Rodrigues (1) commits (+7/-7): btrfs: Change qgroup_meta_rsv to 64bit Dan Carpenter (1) commits (+6/-1): Btrfs: fix an integ

[GIT PULL] Btrfs

2017-03-23 Thread Chris Mason
Hi Linus We have a small set of fixes for the next RC: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.11 Zygo tracked down a very old bug with inline compressed extents. I didn't tag this one for stable because I want to do individual tested backports. It's a

Re: [PATCH] jump_label: Fix anonymous union initialization

2017-03-02 Thread Chris Mason
asm get added into 4.5? Did someone backport it to the gcc 4.4 compilers? I believe 4.5 handles anonymous unions. Since the broken commit went through my tree, I'll take this patch. I'm getting ready for another git pull request to Linus. Compiled-by: Chris Mason -chris

[GIT PULL] Btrfs

2017-03-02 Thread Chris Mason
Hi Linus, My for-linus-4.11 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.11 Has Btrfs round two. These are mostly a continuation of Dave Sterba's collection of cleanups, but Filipe also has some bug fixes and performance improvements. Nikolay Boriso

[GIT PULL] Btrfs

2017-02-24 Thread Chris Mason
Hi Linus, My for-linus-4.11 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.11 Has a series of fixes and cleanups that Dave Sterba has been collecting: There is a pretty big variety here, cleaning up internal APIs and fixing corner cases. David Sterba

[GIT PULL] Btrfs

2017-02-11 Thread Chris Mason
Hi Linus, My for-linus-4.10 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.10 Has two last minute fixes. The highest priority here is a regression fix for the decompression code, but we also fixed up a problem with the 32 bit compat ioctls. The decom

[GIT PULL] Btrfs

2017-01-27 Thread Chris Mason
Hi Linus, My for-linus-4.10 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.10 Has some fixes that we've collected from the list. We still have one more pending to nail down a regression in lzo compression, but I wanted to get this batch out the door.

[GIT PULL] Btrfs fixes

2017-01-13 Thread Chris Mason
Hi Linus, Dave Sterba queued up a few fixes for btrfs. I have them in my for-linus-4.10 branch: These are all over the place. The tracepoint part of the pull fixes a crash and adds a little more information to two tracepoints, while the rest are good old fashioned fixes. git://git.kernel.org/p

Re: [Regression 4.7-rc1] btrfs: bugfix: handle FS_IOC32_{GETFLAGS,SETFLAGS,GETVERSION} in btrfs_ioctl

2017-01-06 Thread Chris Mason
On 01/06/2017 12:22 PM, Joseph Salisbury wrote: Hi Luke, A kernel bug report was opened against Ubuntu [0]. This bug was fixed by the following commit in v4.7-rc1: commit 4c63c2454eff996c5e27991221106eb511f7db38 Author: Luke Dashjr Date: Thu Oct 29 08:22:21 2015 + btrfs: bugfix:

Re: OOM: Better, but still there on

2016-12-21 Thread Chris Mason
On Wed, Dec 21, 2016 at 12:16:53PM +0100, Michal Hocko wrote: On Wed 21-12-16 20:00:38, Tetsuo Handa wrote: One thing to note here, when we are talking about 32b kernel, things have changed in 4.8 when we moved from the zone based to node based reclaim (see b2e18757f2c9 ("mm, vmscan: begin recla

Re: OOM: Better, but still there on 4.9

2016-12-16 Thread Chris Mason
On 12/16/2016 05:14 PM, Michal Hocko wrote: On Fri 16-12-16 13:15:18, Chris Mason wrote: On 12/16/2016 02:39 AM, Michal Hocko wrote: [...] I believe the right way to go around this is to pursue what I've started in [1]. I will try to prepare something for testing today for you. Stay

Re: OOM: Better, but still there on 4.9

2016-12-16 Thread Chris Mason
On 12/16/2016 02:39 AM, Michal Hocko wrote: [CC linux-mm and btrfs guys] On Thu 15-12-16 23:57:04, Nils Holland wrote: [...] Of course, none of this are workloads that are new / special in any way - prior to 4.8, I never experienced any issues doing the exact same things. Dec 15 19:02:16 teela

Re: OOM: Better, but still there on 4.9

2016-12-16 Thread Chris Mason
On 12/16/2016 02:39 AM, Michal Hocko wrote: [CC linux-mm and btrfs guys] On Thu 15-12-16 23:57:04, Nils Holland wrote: [...] Of course, none of this are workloads that are new / special in any way - prior to 4.8, I never experienced any issues doing the exact same things. Dec 15 19:02:16 teela

[GIT PULL] Btrfs

2016-12-16 Thread Chris Mason
ady calculated value in btrfs_should_throttle_delayed_refs() (+1/-1) btrfs: add necessary comments about tickets_id (+4/-0) btrfs: improve delayed refs iterations (+37/-6) Liu Bo (2) commits (+12/-6): Btrfs: adjust len of writes if following a preallocated extent (+5/-3) Btrfs: fi

Re: [PATCH] btrfs: limit async_work allocation and worker func duration

2016-12-13 Thread Chris Mason
On 12/12/2016 03:35 PM, Maxim Patlasov wrote: On 12/12/2016 06:54 AM, David Sterba wrote: As far as we don't have any NO_THRESHOLD users of btrfs_workqueue_normal_congested for now, I tend to think it's better to add a descriptive comment and simply return "false" from btrfs_workqueue_normal_con

Re: btrfs: still lockdep splat for 4.9-rc5+ (btrfs_log_inode)

2016-11-26 Thread Chris Mason
On Fri, Nov 25, 2016 at 10:03:25AM +0100, Christian Borntraeger wrote: FWIW, I still see the lockdep splat in btrfs in 4.9-rc5+ Filipe reworked the code to avoid taking the same lock twice. As far as I can tell, this just needs some annotation. -chris

Re: btrfs btree_ctree_super fault

2016-11-10 Thread Chris Mason
On 11/10/2016 09:35 AM, Dave Jones wrote: On Tue, Nov 08, 2016 at 10:08:04AM -0500, Chris Mason wrote: > > And another new one: > > > > kernel BUG at fs/btrfs/ctree.c:3172! > > > > Call Trace: > > [] __btrfs_drop_extents+0xb00/0xe30 [btrfs] > >

Re: btrfs btree_ctree_super fault

2016-11-08 Thread Chris Mason
On 11/08/2016 09:59 AM, Dave Jones wrote: On Sun, Nov 06, 2016 at 11:55:39AM -0500, Dave Jones wrote: > > > On Mon, Oct 31, 2016 at 01:44:55PM -0600, Chris Mason wrote: > > On Mon, Oct 31, 2016 at 12:35:16PM -0700, Linus Torvalds wrote: > > >On Mon, Oct 31, 2016

[GIT PULL] Btrfs

2016-11-04 Thread Chris Mason
Hi Linus, My for-linus-4.9 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.9 Has some fixes that Dave Sterba collected. We held off on these last week because I was focused on the memory corruption testing. I had asked you about pulling this directly f

Re: [Ksummit-discuss] Results: Linux Foundation Technical Advisory Board Election 2016

2016-11-04 Thread Chris Mason
On Thu, Nov 03, 2016 at 08:38:44PM +0200, Laurent Pinchart wrote: Hi Chris, On Thursday 03 Nov 2016 10:47:03 Chris Mason wrote: On Thu, Nov 03, 2016 at 06:06:35PM +0200, Laurent Pinchart wrote: > On Thursday 03 Nov 2016 11:39:51 Steven Rostedt wrote: >> The TAB elections are now

Re: Linux Foundation Technical Advisory Board Elections updates and location

2016-11-03 Thread Chris Mason
On Thu, Nov 03, 2016 at 10:19:50AM -0700, Randy Dunlap wrote: On 10/28/16 16:13, Frank Rowand wrote: Hi Chris, It's time for the annual question of: where do I find the TAB minutes? I was sure I had a bookmark of the link, but I seem to have misplaced it. Thanks, Frank and the answer is ?

Re: [Ksummit-discuss] Results: Linux Foundation Technical Advisory Board Election 2016

2016-11-03 Thread Chris Mason
, H. Peter Anvin, Chris Mason and the Linux Foundation staff who helped handle the election logistics. With 108 ballots cast, the top 5 candidates received: The next highest voted candidate received 44 votes. Full results are available on request. Just curious, is there any particular reason to

Re: bio linked list corruption.

2016-10-31 Thread Chris Mason
On Mon, Oct 31, 2016 at 12:35:16PM -0700, Linus Torvalds wrote: On Mon, Oct 31, 2016 at 11:55 AM, Dave Jones wrote: BUG: Bad page state in process kworker/u8:12 pfn:4e0e39 page:ea0013838e40 count:0 mapcount:0 mapping:8804a20310e0 index:0x100c flags: 0x400c(referenced|uptod

Re: [PATCH 26/60] btrfs: set NO_MP for request queues behind BTRFS

2016-10-31 Thread Chris Mason
On Mon, Oct 31, 2016 at 08:36:44AM -0700, Christoph Hellwig wrote: On Sat, Oct 29, 2016 at 04:08:25PM +0800, Ming Lei wrote: There are lots of direct access to .bi_vcnt & .bi_io_vec of bio, and it isn't ready to support multipage bvecs for BTRFS, so set NO_MP for these request queues. For one

Linux Foundation Technical Advisory Board Elections updates and location

2016-10-28 Thread Chris Mason
The nominees so far: Josh Triplett Rik van Riel Dave Taht Chris Mason Dan Williams Steve Rostedt is maintaining a list of the nominees and their statements at the URL below. He promises to stay at the keyboard and keep updating it until 12pm EDT Oct 30th: https://goo.gl/xlAoJl The election

[GIT PULL] Btrfs

2016-10-28 Thread Chris Mason
'm no longer able to trigger problems. Filipe is fixing a difficult old bug between snapshots, balance and send. Dave is cooking a few more for the next rc, but these are tested and ready: Chris Mason (1) commits (+6/-14): btrfs: fix races on root_log_ctx lists Filipe Manana (1) commi

Re: bio linked list corruption.

2016-10-27 Thread Chris Mason
On 10/26/2016 08:00 PM, Jens Axboe wrote: > On 10/26/2016 05:47 PM, Dave Jones wrote: >> On Wed, Oct 26, 2016 at 07:38:08PM -0400, Chris Mason wrote: >> >> > >-hctx->queued++; >> > >-data->hctx = hctx; >> > >-

Re: bio linked list corruption.

2016-10-26 Thread Chris Mason
On Wed, Oct 26, 2016 at 05:20:01PM -0600, Jens Axboe wrote: On 10/26/2016 05:08 PM, Linus Torvalds wrote: On Wed, Oct 26, 2016 at 4:03 PM, Jens Axboe wrote: Actually, I think I see what might trigger it. You are on nvme, iirc, and that has a deep queue. Yes. I have long since moved on from

Re: bio linked list corruption.

2016-10-26 Thread Chris Mason
On Wed, Oct 26, 2016 at 05:03:45PM -0600, Jens Axboe wrote: On 10/26/2016 04:58 PM, Linus Torvalds wrote: On Wed, Oct 26, 2016 at 3:51 PM, Linus Torvalds wrote: Dave: it might be a good idea to split that "WARN_ON_ONCE()" in blk_mq_merge_queue_io() into two I did that myself too, since Dave

Re: bio linked list corruption.

2016-10-26 Thread Chris Mason
On Wed, Oct 26, 2016 at 03:07:10PM -0700, Linus Torvalds wrote: On Wed, Oct 26, 2016 at 1:00 PM, Chris Mason wrote: Today I turned off every CONFIG_DEBUG_* except for list debugging, and ran dbench 2048: [ 2759.118711] WARNING: CPU: 2 PID: 31039 at lib/list_debug.c:33 __list_add+0xbe/0xd0

Re: bio linked list corruption.

2016-10-26 Thread Chris Mason
On 10/26/2016 04:00 PM, Chris Mason wrote: > > > On 10/26/2016 03:06 PM, Linus Torvalds wrote: >> On Wed, Oct 26, 2016 at 11:42 AM, Dave Jones wrote: >>> >>> The stacks show nearly all of them are stuck in sync_inodes_sb >> >> That's just w

Re: bio linked list corruption.

2016-10-26 Thread Chris Mason
On 10/26/2016 03:06 PM, Linus Torvalds wrote: > On Wed, Oct 26, 2016 at 11:42 AM, Dave Jones wrote: >> >> The stacks show nearly all of them are stuck in sync_inodes_sb > > That's just wb_wait_for_completion(), and it means that some IO isn't > completing. > > There's also a lot of processes w

Re: bio linked list corruption.

2016-10-24 Thread Chris Mason
On 10/24/2016 05:50 PM, Linus Torvalds wrote: On Mon, Oct 24, 2016 at 2:17 PM, Linus Torvalds wrote: The vmalloc/vfree code itself is a bit scary. In particular, we have a rather insane model of TLB flushing. We leave the virtual area on a lazy purge-list, and we delay flushing the TLB and act

Reminder: Linux Foundation Technical Advisory Board Elections and Nomination process

2016-10-24 Thread Chris Mason
tworks and mailing lists, so get your nomination in early). Chris Mason, TAB Chair [1] TAB members sit for a term of two years, and half of the board is up for election every year. Five of the seats are up for election now. The other five are halfway through their term and will be up for election next year.

Re: bio linked list corruption.

2016-10-24 Thread Chris Mason
On 10/24/2016 12:40 AM, Dave Jones wrote: On Sun, Oct 23, 2016 at 05:32:21PM -0400, Chris Mason wrote: > > > On 10/22/2016 11:20 AM, Dave Jones wrote: > > On Fri, Oct 21, 2016 at 04:02:45PM -0400, Dave Jones wrote: > > > > > > I

Re: bio linked list corruption.

2016-10-23 Thread Chris Mason
On 10/22/2016 11:20 AM, Dave Jones wrote: On Fri, Oct 21, 2016 at 04:02:45PM -0400, Dave Jones wrote: > > It could be worth trying this, too: > > > > https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commit/?h=x86/vmap_stack&id=174531fef4e8 > > > > It occurred to me that t

Re: bio linked list corruption.

2016-10-21 Thread Chris Mason
On 10/21/2016 04:23 PM, Dave Jones wrote: On Fri, Oct 21, 2016 at 04:17:48PM -0400, Chris Mason wrote: > > BTRFS warning (device sda3): csum failed ino 130654 off 0 csum 2566472073 expected csum 3008371513 > > BTRFS warning (device sda3): csum failed ino 131057 off 4096 csum

Re: bio linked list corruption.

2016-10-21 Thread Chris Mason
On 10/21/2016 04:02 PM, Dave Jones wrote: On Thu, Oct 20, 2016 at 04:23:32PM -0700, Andy Lutomirski wrote: > On Thu, Oct 20, 2016 at 4:03 PM, Dave Jones wrote: > > On Thu, Oct 20, 2016 at 04:01:12PM -0700, Andy Lutomirski wrote: > > > On Thu, Oct 20, 2016 at 3:50 PM, Dave Jones wrote: >

Re: bio linked list corruption.

2016-10-18 Thread Chris Mason
On Tue, Oct 18, 2016 at 05:10:56PM -0700, Linus Torvalds wrote: On Tue, Oct 18, 2016 at 4:42 PM, Chris Mason wrote: Seems to be the whole thing: Ahh. On lkml, so I do have it in my mailbox, but Dave changed the subject line when he tested on ext4 rather than btrfs.. Anyway, the corrupted

Re: bio linked list corruption.

2016-10-18 Thread Chris Mason
On Tue, Oct 18, 2016 at 04:39:22PM -0700, Linus Torvalds wrote: On Tue, Oct 18, 2016 at 4:31 PM, Chris Mason wrote: Jens, not sure if you saw the whole thread. This has triggered bad page state errors, and also corrupted a btrfs list. It hurts me to say, but it might not actually be your

Re: bio linked list corruption.

2016-10-18 Thread Chris Mason
On Tue, Oct 18, 2016 at 05:12:41PM -0600, Jens Axboe wrote: On 10/18/2016 04:42 PM, Dave Jones wrote: So Chris had me do a run on ext4 just for giggles. It took a while, but eventually this fell out... WARNING: CPU: 3 PID: 21324 at lib/list_debug.c:33 __list_add+0x89/0xb0 list_add corruption.

Re: btrfs bio linked list corruption.

2016-10-17 Thread Chris Mason
On Sat, Oct 15, 2016 at 08:42:40PM -0400, Dave Jones wrote: On Thu, Oct 13, 2016 at 05:18:46PM -0400, Chris Mason wrote: > > > > .. and of course the first thing that happens is a completely different > > > > btrfs trace.. > > > > > > > >

Linux Foundation Technical Advisory Board Elections and Nomination process

2016-10-14 Thread Chris Mason
tworks and mailing lists, so get your nomination in early). Chris Mason, TAB Chair [1] TAB members sit for a term of two years, and half of the board is up for election every year. Five of the seats are up for election now. The other five are halfway through their term and will be up for election next year.

[GIT PULL] Btrfs

2016-10-14 Thread Chris Mason
Hi Linus, My for-linus-4.9 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.9 Has some fixes from Omar and Dave Sterba for our new free space tree. This isn't heavily used yet, but as we move toward making it the new default we wanted to nail down an endia

Re: btrfs bio linked list corruption.

2016-10-13 Thread Chris Mason
On 10/13/2016 02:16 PM, Dave Jones wrote: On Wed, Oct 12, 2016 at 10:42:46AM -0400, Chris Mason wrote: > On 10/12/2016 10:40 AM, Dave Jones wrote: > > On Wed, Oct 12, 2016 at 09:47:17AM -0400, Dave Jones wrote: > > > On Tue, Oct 11, 2016 at 11:54:09AM -0400,

Re: btrfs bio linked list corruption.

2016-10-12 Thread Chris Mason
On 10/12/2016 10:40 AM, Dave Jones wrote: On Wed, Oct 12, 2016 at 09:47:17AM -0400, Dave Jones wrote: > On Tue, Oct 11, 2016 at 11:54:09AM -0400, Chris Mason wrote: > > > > > > On 10/11/2016 10:45 AM, Dave Jones wrote: > > > This is from Linus' curr

Re: btrfs bio linked list corruption.

2016-10-11 Thread Chris Mason
On 10/11/2016 10:45 AM, Dave Jones wrote: > This is from Linus' current tree, with Al's iovec fixups on top. > > [ cut here ] > WARNING: CPU: 1 PID: 3673 at lib/list_debug.c:33 __list_add+0x89/0xb0 > list_add corruption. prev->next should be next (e8806648), but w

[GIT PULL] Btrfs

2016-10-11 Thread Chris Mason
(1) commits (+20/-6): btrfs: fix a possible umount deadlock Lu Fengqi (1) commits (+369/-10): btrfs: fix check_shared for fiemap ioctl Chris Mason (1) commits (+15/-11): Revert "btrfs: let btrfs_delete_unused_bgs() to clean relocated bgs" Masahiro Yamada (1) commits (+8/-28)

Re: btrfs bio linked list corruption.

2016-10-11 Thread Chris Mason
On 10/11/2016 11:19 AM, Dave Jones wrote: On Tue, Oct 11, 2016 at 04:11:39PM +0100, Al Viro wrote: > On Tue, Oct 11, 2016 at 10:45:08AM -0400, Dave Jones wrote: > > This is from Linus' current tree, with Al's iovec fixups on top. > > Those iovec fixups are in the current tree... ah yeah, g

  1   2   3   4   5   6   7   8   >