Re: [PATCH] selftests: riscv: fix v_exec_initval_nolibc.c

On Thu, Mar 06, 2025 at 07:31:22AM +0100, Ignacio Encinas Rubio wrote: > > > On 5/3/25 22:49, Charlie Jenkins wrote: > > On Wed, Mar 05, 2025 at 05:39:28PM +0100, Ignacio Encinas wrote: > >> Vector registers are zero initialized by the kernel. Stop accepting > >

Re: [PATCH] selftests: riscv: fix v_exec_initval_nolibc.c

ined in the ABI. Since linux does always set this value to zero (currently) we can safely remove this check. Reviewed-by: Charlie Jenkins Tested-by: Charlie Jenkins > > Signed-off-by: Ignacio Encinas > --- > I tried looking why "all ones" was previously deemed a &quo

Re: [PATCH 5/6] selftests/nolibc: rename riscv to riscv64

: Charlie Jenkins Tested-by: Charlie Jenkins > > Signed-off-by: Thomas Weißschuh > --- > tools/testing/selftests/nolibc/Makefile | 6 ++ > tools/testing/selftests/nolibc/run-tests.sh | 2 +- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/tools/

Re: [PATCH 6/6] selftests/nolibc: add configurations for riscv32

On Sat, Dec 21, 2024 at 03:44:33PM +0100, Thomas Weißschuh wrote: > nolibc already supports riscv32. Wire it up in the testsuite. Good addition! Reviewed-by: Charlie Jenkins Tested-by: Charlie Jenkins > > Signed-off-by: Thomas Weißschuh > --- > tools/testing/selftests/

Re: [PATCH v2 4/7] syscall.h: introduce syscall_set_nr()

uct task_struct *task, struct pt_regs > *regs, int nr) > +{ > + /* > + * Unlike syscall_get_nr(), syscall_set_nr() can be called only when > + * the target task is stopped for tracing on entering syscall, so > + * there is no need to have the same check syscall_get

Re: [PATCH v6 0/3] riscv/ptrace: add new regset to access original a0 register

On Wed, Jan 15, 2025 at 07:13:26PM +0800, Celeste Liu wrote: > The orig_a0 is missing in struct user_regs_struct of riscv, and there is > no way to add it without breaking UAPI. (See Link tag below) > > Like NT_ARM_SYSTEM_CALL do, we add a new regset name NT_RISCV_ORIG_A0 to > access original a0 r

Re: [PATCH v6 2/3] tools: copy include/linux/stddef.h to tools/include

and true/false to be suitable to > non-kernel environment. > > Signed-off-by: Celeste Liu Reviewed-by: Charlie Jenkins Tested-by: Charlie Jenkins > --- > tools/include/linux/stddef.h | 85 > +++ > tools/include/uapi/linux

Re: [PATCH v6 1/3] riscv/ptrace: add new regset to access original a0 register

Celeste Liu Thank you! Reviewed-by: Charlie Jenkins Tested-by: Charlie Jenkins > --- > arch/riscv/kernel/ptrace.c | 32 > include/uapi/linux/elf.h | 1 + > 2 files changed, 33 insertions(+) > > diff --git a

Re: [PATCH v4 2/2] riscv: selftests: Add a ptrace test to verify syscall parameter modification

hanging a0 does not change the syscall argument. > >> > >> Co-developed-by: Quan Zhou > >> Signed-off-by: Quan Zhou > >> Co-developed-by: Charlie Jenkins > >> Signed-off-by: Charlie Jenkins > >> Reviewed-by: Björn Töpel > >> Signe

Re: [PATCH] rseq/selftests: Fix riscv rseq_offset_deref_addv inline asm

opied from the x86 port. Fix this by just using an "r" constraint. > > I have compile tested this only for riscv. However, the same fixes I > use in the OpenRISC rseq selftests and everything passes with no issues. Thank you for these changes! I suppose these tests hadn't b

Re: [PATCH 0/2] selftest: fix riscv/vector tests

On Fri, Dec 20, 2024 at 05:17:25PM +0800, Yong-Xuan Wang wrote: > Add test counts and pass message to remove warning of riscv/vector tests. A similar patch has been staged on Palmers for-next tree that I sent out a long time ago. I also reworked these tests so that they use the kselftest_harness [

Re: [PATCH v2 2/2] riscv: selftests: Add a ptrace test to verify syscall parameter modification

On Fri, Dec 20, 2024 at 05:29:45AM +0800, Celeste Liu wrote: > > On 2024-12-20 02:26, Charlie Jenkins wrote: > > On Tue, Dec 03, 2024 at 01:55:07PM +0100, Andrew Jones wrote: > >> On Tue, Dec 03, 2024 at 05:30:05PM +0800, Celeste Liu wrote: > >>> From: Charl

Re: [PATCH v2 2/2] riscv: selftests: Add a ptrace test to verify syscall parameter modification

On Tue, Dec 03, 2024 at 01:55:07PM +0100, Andrew Jones wrote: > On Tue, Dec 03, 2024 at 05:30:05PM +0800, Celeste Liu wrote: > > From: Charlie Jenkins > > > > This test checks that orig_a0 allows a syscall argument to be modified, > > and that changing a0 does not

[PATCH v6] riscv: selftests: Fix warnings pointer masking test

u1~22.04). Fix this by checking that the number of bytes written equal the expected number of bytes written. Fixes: 7470b5afd150 ("riscv: selftests: Add a pointer masking test") Signed-off-by: Charlie Jenkins Reviewed-by: Andrew Jones --- Changes in v6: - Add back ksft_test_result() (Sa

[PATCH] selftests/hid: Add host-tools to .gitignore

When compiling these selftests the host-tools directory is generated. Add it to the .gitignore so git doesn't see these files as trackable. Signed-off-by: Charlie Jenkins --- tools/testing/selftests/hid/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftest

[PATCH v5] riscv: selftests: Fix warnings pointer masking test

u1~22.04). Fix this by checking that the number of bytes written equal the expected number of bytes written. Fixes: 7470b5afd150 ("riscv: selftests: Add a pointer masking test") Signed-off-by: Charlie Jenkins --- Changes in v5: - No longer skip second pwrite if first one fails - Use wrappe

Re: [PATCH for-next v3] selftests/filesystems: Add missing gitignore file

100644 > --- a/tools/testing/selftests/filesystems/statmount/.gitignore > +++ b/tools/testing/selftests/filesystems/statmount/.gitignore > @@ -1,2 +1,3 @@ > # SPDX-License-Identifier: GPL-2.0-only > +statmount_test_ns Thank you! This is still an issue in 6.13-rc1. Reviewed-by: Charlie Jenkins Tested-by: Charlie Jenkins > /*_test > -- > 2.44.0 > >

Re: [PATCH v4] riscv: selftests: Fix warnings pointer masking test

On Fri, Dec 06, 2024 at 09:21:50AM -0800, Charlie Jenkins wrote: > On Fri, Dec 06, 2024 at 10:15:17AM +0100, Andrew Jones wrote: > > On Thu, Dec 05, 2024 at 01:49:31PM -0800, Charlie Jenkins wrote: > > > When compiling the pointer masking tests with -Wall this warnin

Re: [PATCH v4] riscv: selftests: Fix warnings pointer masking test

On Fri, Dec 06, 2024 at 10:15:17AM +0100, Andrew Jones wrote: > On Thu, Dec 05, 2024 at 01:49:31PM -0800, Charlie Jenkins wrote: > > When compiling the pointer masking tests with -Wall this warning > > is present: > > > > pointer_masking.c: In function ‘

[PATCH v4] riscv: selftests: Fix warnings pointer masking test

u1~22.04). Fix this by checking that the number of bytes written equal the expected number of bytes written. Fixes: 7470b5afd150 ("riscv: selftests: Add a pointer masking test") Signed-off-by: Charlie Jenkins --- Changes in v4: - Skip sysctl_enabled test if first pwrite failed -

Re: [PATCH v2] riscv: selftests: Fix warnings pointer masking test

On Thu, Dec 05, 2024 at 01:30:59PM -0800, Charlie Jenkins wrote: > On Thu, Dec 05, 2024 at 09:04:12AM +0100, Andrew Jones wrote: > > On Wed, Dec 04, 2024 at 06:57:10PM -0800, Charlie Jenkins wrote: > > > When compiling the pointer masking tests with -Wall this warnin

[PATCH v3] riscv: selftests: Fix warnings pointer masking test

u1~22.04). Fix this by checking that the number of bytes written equal the expected number of bytes written. Fixes: 7470b5afd150 ("riscv: selftests: Add a pointer masking test") Signed-off-by: Charlie Jenkins --- Changes in v3: - Fix sysctl enabled test case (Drew/Alex) - Move pwrite err c

Re: [PATCH v2] riscv: selftests: Fix warnings pointer masking test

On Thu, Dec 05, 2024 at 09:11:46AM +0100, Alexandre Ghiti wrote: > Hi Charlie, > > On 05/12/2024 03:57, Charlie Jenkins wrote: > > When compiling the pointer masking tests with -Wall this warning > > is present: > > > > pointer_masking.c: In func

Re: [PATCH v2] riscv: selftests: Fix warnings pointer masking test

On Thu, Dec 05, 2024 at 09:04:12AM +0100, Andrew Jones wrote: > On Wed, Dec 04, 2024 at 06:57:10PM -0800, Charlie Jenkins wrote: > > When compiling the pointer masking tests with -Wall this warning > > is present: > > > > pointer_masking.c: In function ‘

[PATCH v2] riscv: selftests: Fix warnings pointer masking test

u1~22.04). Fix this by checking that the number of bytes written equal the expected number of bytes written. Fixes: 7470b5afd150 ("riscv: selftests: Add a pointer masking test") Signed-off-by: Charlie Jenkins --- Changes in v2: - I had ret != 2 for testing, I changed it to be ret != 1. -

[PATCH] riscv: selftests: Fix warnings pointer masking test

u1~22.04). Fix this by checking that the number of bytes written equal the expected number of bytes written. Fixes: 7470b5afd150 ("riscv: selftests: Add a pointer masking test") Signed-off-by: Charlie Jenkins --- tools/testing/selftests/riscv/abi/pointer_masking.c | 19 +++

Re: [PATCH 2/2] selftests/mm: skip virtual_address_range tests on riscv

Anyways, the content of this patch looks good! Reviewed-by: Charlie Jenkins > --- > tools/testing/selftests/mm/Makefile | 2 ++ > tools/testing/selftests/mm/run_vmtests.sh | 10 ++ > 2 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/tools/testing

Re: [PATCH 1/2] selftest/mm: Fix typo in virtual_address_range

On Fri, Sep 13, 2024 at 10:26:34AM +0800, Chunyan Zhang wrote: > The function name should be *hint* address, so correct it. > > Signed-off-by: Chunyan Zhang Reviewed-by: Charlie Jenkins > --- > tools/testing/selftests/mm/virtual_address_range.c | 4 ++-- > 1 file changed,

Re: [PATCH] selftest/mm: Do not use hint for riscv mmap

On Thu, Sep 12, 2024 at 06:00:18PM +0800, Chunyan Zhang wrote: > When the virtual address range selftest is run on RISC-V platforms, > it is observed that using the hint address when calling mmap cannot > get the address in the range of that validate_addr() checks, also > that will cause '/proc/sel