patch fixes the issue.
Thank you,
--
Carlo Caione
Log:
https://termbin.com/icix
Cheers!
--
Carlo Caione
On 25/01/2019 15:00, Andrew Lunn wrote:
On Fri, Jan 25, 2019 at 12:35:10PM +, Carlo Caione wrote:
Libphy provides a standard set of helpers to access the MMD PHY
registers. Use those instead of relying on custom driver-specific
functions.
Hi Carlo
Hey Andrew,
Maybe deja vu, but i
Libphy provides a standard set of helpers to access the MMD PHY
registers. Use those instead of relying on custom driver-specific
functions.
Signed-off-by: Carlo Caione
---
drivers/net/phy/at803x.c | 16 +++-
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/drivers/net
On Mon, 2018-12-03 at 11:21 +0100, Neil Armstrong wrote:
> On 01/12/2018 16:17, Carlo Caione wrote:
> > Kevin is basically doing all the work. Remove my name as co-
> > maintainer.
>
> Sure, but couldn't we move you as reviewer and add Martin as reviewer
> aswell
Kevin is basically doing all the work. Remove my name as co-maintainer.
Signed-off-by: Carlo Caione
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 01645edc2388..63a2ad093524 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1297,7 +1297,6 @@ F
p my Reviewed-by for the v4.
No problem. Thank you both for the reviews.
Cheers,
--
Carlo Caione | +44.7384.69.16.04 | Endless
From: Carlo Caione
The ECS EF20EA laptop ships an AXP288 but it is actually using a
different, separate FG chip for AC and battery monitoring. On this
laptop we need to keep using the regular ACPI driver and disable the
AXP288 FG to avoid reporting two batteries to userspace.
Signed-off-by
From: Carlo Caione
With commits af3ec837 and dccfae6d a blacklist was introduced to avoid
using the ACPI drivers for AC and battery when a native PMIC driver was
already present. While this is in general a good idea (because of broken
DSDT or proprietary and undocumented ACPI opregions for the
From: Carlo Caione
With commits af3ec837 and dccfae6d a blacklist was introduced to avoid
using the ACPI drivers for AC and battery when a native PMIC driver was
already present. While this is in general a good idea (because of broken
DSDT or proprietary and undocumented ACPI opregions for the
From: Carlo Caione
On the ECS EF20EA laptop we need to move away from the AXP288 FG driver
and enable again the ACPI AC/battery drivers. Add the required quirks to
do that. We rely only on the product name because all the other DMI
entries are dummy or not filled in on this platform.
Signed-off
On Fri, Feb 9, 2018 at 2:23 PM, Carlo Caione wrote:
> From: Carlo Caione
>
> On at least one notebook (ECS EF20EA) the 'hp-detect' GPIO is defined in
> the DSDT table by the ACPI GpioIo resources in _CRS. Add this mapping to
> the rt5645 driver to enable the jack
From: Carlo Caione
With commits af3ec837 and dccfae6d a blacklist was introduced to avoid
using the ACPI drivers for AC and battery when a native PMIC driver was
already present. While this is in general a good idea (because of broken
DSDT or proprietary and undocumented ACPI opregions for the
From: Carlo Caione
On the ECS EF20EA laptop we need to move away from the AXP288 FG driver
and enable again the ACPI AC/battery drivers. Add the required quirks to
do that. We rely only on the product name because all the other DMI
entries are dummy or not filled in on this platform.
Signed-off
From: Carlo Caione
With commits af3ec837 and dccfae6d a blacklist was introduced to avoid
using the ACPI drivers for AC and battery when a native PMIC driver was
already present. While this is in general a good idea (because of broken
DSDT or proprietary and undocumented ACPI opregions for the
From: Carlo Caione
On at least one notebook (ECS EF20EA) the 'hp-detect' GPIO is defined in
the DSDT table by the ACPI GpioIo resources in _CRS. Add this mapping to
the rt5645 driver to enable the jack detection also on non-DT platforms.
Method (_CRS, 0, NotSerialized)
{
From: Carlo Caione
On at least one notebook (ECS EF20EA) the 'hp-detect' GPIO is defined in
the DSDT table by the ACPI GpioIo resources in _CRS. Add this mapping to
the rt5645 driver to enable the jack detection also on non-DT platforms.
Method (_CRS, 0, NotSerialized)
{
tually
related to the issue you are fixing with this commit (and if now,
sorry to have hijacked this thread).
Any idea on that?
Thank you,
[0] https://gist.github.com/carlocaione/82bff95ababb67dd33f52a86e94ce3ff
--
Carlo Caione | +39.340.80.30.096 | Endless
On Tue, Nov 21, 2017 at 5:15 PM, Carlo Caione wrote:
> From: Carlo Caione
>
> The RT5651 codec has 3 analog input ports. Some laptops (like the KIANO
> laptop)
> have two different analog mics on two ports, leaving the headset on the
> remaining one. We need to add a new qui
From: Carlo Caione
The RT5651 codec has 3 analog inputs. Some laptops have two different
internal analog microphones on the external case.
Add a new custom quirk mapping the two internal mics on IN1P / IN2P,
leaving the headset mic on IN3P.
Signed-off-by: Carlo Caione
---
sound/soc/intel
From: Carlo Caione
The RT5651 codec has 3 analog input ports. Some laptops (like the KIANO laptop)
have two different analog mics on two ports, leaving the headset on the
remaining one. We need to add a new quirk to support also this configuration.
Carlo Caione (2):
ASoC: intel: byt
From: Carlo Caione
This laptop has actually two different analog mics, no just one. Fix the
quirk to reflect the correct configuration.
Signed-off-by: Carlo Caione
---
sound/soc/intel/boards/bytcr_rt5651.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel
On Thu, Nov 16, 2017 at 1:53 PM, Carlo Caione wrote:
> On Wed, Oct 18, 2017 at 7:05 PM, Pierre-Louis Bossart
> wrote:
>> On 10/18/17 11:49 AM, Carlo Caione wrote:
>>>
>>> From: Carlo Caione
>>>
>>> Introduce a new custom dapm routes map to quirk
On Wed, Oct 18, 2017 at 7:05 PM, Pierre-Louis Bossart
wrote:
> On 10/18/17 11:49 AM, Carlo Caione wrote:
>>
>> From: Carlo Caione
>>
>> Introduce a new custom dapm routes map to quirk platforms with the
>> internal mic connected to IN2P.
>
>
> LGTM. If w
On Sat, Oct 21, 2017 at 11:09 AM, Mark Brown wrote:
> On Wed, Oct 18, 2017 at 06:06:31PM +0100, Carlo Caione wrote:
>> From: Carlo Caione
>>
>> MICBIAS widget type has been deprecated. Convert it to a SUPPLY widget.
>
> Do we have any machine drivers using thi
From: Carlo Caione
This cherry-trails laptop has the internal mic connected to the IN2
input pins. Enable the quirk to correctly map the routes.
Signed-off-by: Carlo Caione
---
sound/soc/intel/boards/bytcr_rt5651.c | 8
1 file changed, 8 insertions(+)
diff --git a/sound/soc/intel
From: Carlo Caione
Introduce an headset jack in the machine driver and register it to the
codec driver.
Signed-off-by: Carlo Caione
---
sound/soc/intel/boards/bytcr_rt5651.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/sound/soc/intel/boards/bytcr_rt5651.c
b
From: Carlo Caione
Rework a bit the quirk logic in the codec driver to simplify the
DMI-based quirk assignment for non-DT platforms.
Signed-off-by: Carlo Caione
---
sound/soc/codecs/rt5651.c | 39 +++
1 file changed, 35 insertions(+), 4 deletions(-)
diff
From: Carlo Caione
The KIANO SlimNote 14.2 laptop uses the JD1_1 input pin for jack
detection. Set the correct quirk in the codec driver.
Signed-off-by: Carlo Caione
---
sound/soc/codecs/rt5651.c | 8
1 file changed, 8 insertions(+)
diff --git a/sound/soc/codecs/rt5651.c b/sound/soc
From: Carlo Caione
Patchset to support jack detection for the rt5651 codec on the JD* pins
and enable it on the KIANO cherry-trail laptop.
Changelog:
v2:
- Added quirks for the KIANO laptop
- Extended support to JD1_2 and JD2 pins
- Reworked quirk logic in the codec driver
- Codec driver
From: Carlo Caione
Enable jack detection for the RT5651 codec on the JD* pins.
Signed-off-by: Carlo Caione
---
include/sound/rt5651.h| 8 +++
sound/soc/codecs/rt5651.c | 168 +-
sound/soc/codecs/rt5651.h | 4 ++
3 files changed, 178
On Thu, Oct 19, 2017 at 4:47 PM, Pierre-Louis Bossart
wrote:
> On 10/19/17 6:03 AM, Carlo Caione wrote:
>>
>> From: Carlo Caione
>>
>> Enable jack detection or the RT5651 codec on the JD1_1 pin.
>
> Nice, but the codec supports a second jack detection on JD1 a
From: Carlo Caione
Small set of patches to enable jack detection for the rt5651 codec.
Please note that:
- The jack detection is restricted to the JD1_1 pin only (the only
hardware I have uses this pin for jack detection)
- AFAICT (reading the rt5651 datasheet) there is no way to detect
From: Carlo Caione
Introduce an headset jack in the machine driver and register it to the
codec driver.
Signed-off-by: Carlo Caione
---
sound/soc/intel/boards/bytcr_rt5651.c | 24
1 file changed, 24 insertions(+)
diff --git a/sound/soc/intel/boards/bytcr_rt5651.c
b
From: Carlo Caione
Enable jack detection or the RT5651 codec on the JD1_1 pin.
The codec has no means to detect the type of the jack connected so we
assume that the jack is always an headset jack.
Signed-off-by: Carlo Caione
---
include/sound/rt5651.h| 7
sound/soc/codecs/rt5651.c
From: Carlo Caione
MICBIAS widget type has been deprecated. Convert it to a SUPPLY widget.
Signed-off-by: Carlo Caione
---
sound/soc/codecs/rt5651.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c
index da60b28ba3df
From: Carlo Caione
Introduce a new custom dapm routes map to quirk platforms with the
internal mic connected to IN2P.
Signed-off-by: Carlo Caione
---
sound/soc/intel/boards/bytcr_rt5651.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/sound/soc/intel
On Wed, Oct 18, 2017 at 5:19 PM, Pierre-Louis Bossart
wrote:
> On 10/18/17 11:07 AM, Carlo Caione wrote:
>>
>> From: Carlo Caione
>>
>> While working on enabling a cherry-trail laptop shipping the rt5651
>> codec I realized that the machine driver needed so
From: Carlo Caione
Introduce a new custom dapm routes map to quirk platforms with the
internal mic connected to IN2P.
Signed-off-by: Carlo Caione
---
sound/soc/intel/boards/bytcr_rt5651.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/sound/soc/intel
From: Carlo Caione
While working on enabling a cherry-trail laptop shipping the rt5651
codec I realized that the machine driver needed some fixup.
In particular the laptop I'm working on (KIANO SlimNote 14.2) has the
internal mic connected to the IN2 port.
All the laptop-specific work wit
From: Carlo Caione
Enable again the quirk logic for the custom dapm routes.
Signed-off-by: Carlo Caione
---
sound/soc/intel/boards/bytcr_rt5651.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/sound/soc/intel/boards/bytcr_rt5651.c
b/sound/soc/intel/boards/bytcr_rt5651.c
index
On Mon, Aug 21, 2017 at 9:27 AM, Carlo Caione wrote:
> On Mon, Aug 7, 2017 at 10:01 AM, Carlo Caione wrote:
>> From: Carlo Caione
>>
>> We have found some ACER laptops shipping with certificates signed using
>> the 1.3.14.3.2.29 OID. This is causing the mess
On Mon, Aug 7, 2017 at 10:01 AM, Carlo Caione wrote:
> From: Carlo Caione
>
> We have found some ACER laptops shipping with certificates signed using
> the 1.3.14.3.2.29 OID. This is causing the message
/cut
Ping on this (literally) two lines patch.
--
Carlo Caione
From: Carlo Caione
We have found some ACER laptops shipping with certificates signed using
the 1.3.14.3.2.29 OID. This is causing the message
EFI: Problem loading in-kernel X.509 certificate (-65)
to be printed at boot.
This OID is Rivest, Shamir and Adleman (RSA) algorithm that uses the
From: Carlo Caione
sha1WithRSASignature is a deprecated equivalent of
sha1WithRSAEncryption. It originates from the NIST Open Systems
Environment (OSE) Implementor's Workshop (OIW).
It is supported for compatibility with Microsoft's certificate APIs
and tools, particularly makecert.
From: Carlo Caione
We are missing a call to hid_hw_stop() on the remove hook.
Among other things this is causing an Oops when (re-)starting GNOME /
upowerd / ... after the module has been already rmmod-ed.
Signed-off-by: Carlo Caione
---
drivers/hid/hid-asus.c | 2 ++
1 file changed, 2
27;s actions - who is neither author
> nor maintainer here - of copying an opinionated personal and partially
Uhm, probably we can fix at least this by making Neil maintainer
instead of me given that Neil and BayLibre did much of the work on
this platform.
--
Carlo Caione
s reduced in size by 37 lines (3.6%).
>
> I do not have an HP laptop, so I'm hoping Carlo can help out with some
> testing.
> In particular we need to verify that hotkeys and sysfs continue to work as
> before.
On my HP 240 G5:
Tested-by: Carlo Caione
Cheers,
--
Carlo Caione
From: Carlo Caione
All the helper functions (i.e. hp_wmi_dock_state, hp_wmi_tablet_state,
...) using hp_wmi_perform_query to perform an HP WMI query shadow the
returned value in case of error.
We return -EINVAL only when the HP WMI query returns a positive value
(the specific error code) to not
On Wed, Apr 19, 2017 at 10:11 PM, Darren Hart wrote:
> On Wed, Apr 19, 2017 at 07:41:53PM +0200, Carlo Caione wrote:
>> From: Carlo Caione
>>
>> All the helper functions (i.e. hp_wmi_dock_state, hp_wmi_tablet_state,
>> ...) using hp_wmi_perform_query to perform
From: Carlo Caione
Several HP laptops cannot be put to sleep using the LID since systemd complains
that the system is docked even though the laptop is not even dockable (see
[1]).
This is due to a bug in hp-wmi where the driver is failing to check for errors
before creating the input switches
From: Carlo Caione
All the helper functions (i.e. hp_wmi_dock_state, hp_wmi_tablet_state,
...) using hp_wmi_perform_query to perform an HP WMI query shadow the
returned value in case of error.
We return -EINVAL only when the HP WMI query returns a positive value
(the specific error code) to not
From: Carlo Caione
The current driver code is not checking for the error values returned by
'hp_wmi_dock_state()' and 'hp_wmi_tablet_state()' before passing the
returned values down to 'input_report_switch()'. This error code is
being translated to '1' in
On Wed, Apr 19, 2017 at 6:21 PM, Andy Shevchenko
wrote:
> On Sun, Apr 9, 2017 at 4:56 PM, Carlo Caione wrote:
>> From: Carlo Caione
>>
>> hp_wmi_tablet_state() fails to return the correct error code when
>> hp_wmi_perform_query() returns the HP WMI query speci
On Thu, Apr 13, 2017 at 8:21 PM, Darren Hart wrote:
> On Sun, Apr 09, 2017 at 03:56:08PM +0200, Carlo Caione wrote:
>> From: Carlo Caione
/cut
>> @@ -644,6 +646,7 @@ static int __init hp_wmi_input_setup(void)
>> {
>> acpi_status status;
>>
On Sun, Apr 9, 2017 at 3:56 PM, Carlo Caione wrote:
> From: Carlo Caione
>
> Several HP laptops cannot be put to sleep using the LID since systemd
> complains
> that the system is docked even though the laptop is not even dockable (see
> [1]).
>
> This is due to a bug in
On Wed, Apr 12, 2017 at 10:12 PM, Jiri Kosina wrote:
> On Wed, 12 Apr 2017, Carlo Caione wrote:
>
>> >> + ret = devm_led_classdev_register(&hdev->dev,
>> >> &drvdata->kbd_backlight->cdev);
>> >> + if (ret <
On Mon, Apr 10, 2017 at 8:39 AM, Benjamin Tissoires
wrote:
> On Apr 06 2017 or thereabouts, Carlo Caione wrote:
>> + ret = devm_led_classdev_register(&hdev->dev,
>> &drvdata->kbd_backlight->cdev);
>> + if (ret < 0) {
>> +
From: Carlo Caione
The current driver code is not checking for the error values returned by
'hp_wmi_dock_state()' and 'hp_wmi_tablet_state()' before passing the
returned values down to 'input_report_switch()'. This error code is
being translated to '1' in
From: Carlo Caione
Several HP laptops cannot be put to sleep using the LID since systemd complains
that the system is docked even though the laptop is not even dockable (see
[1]).
This is due to a bug in hp-wmi where the driver is failing to check for errors
before creating the input switches
From: Carlo Caione
hp_wmi_tablet_state() fails to return the correct error code when
hp_wmi_perform_query() returns the HP WMI query specific error code
that is a positive value.
Signed-off-by: Carlo Caione
---
drivers/platform/x86/hp-wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
From: Carlo Caione
The latest USB keyboards shipped on several ASUS laptop models
(including ROG laptop models such as GL702VMK) have the keyboards
backlight controlled by the keyboard firmware.
The firmware implements at least 3 different commands:
- Init command (to use when the system starts
vdata *drvdata = hid_get_drvdata(hdev);
>> +
>> + if (drvdata->kbd_backlight)
>> + drvdata->kbd_backlight->removed = true;
>
> Add a cancel_work_sync() here too to terminate currently working
> workers. Bonus point, you don't need the mutex if you call
> cancel_work_sync().
I'll do.
Thanks for the quick review.
--
Carlo Caione | +39.340.80.30.096 | Endless
From: Carlo Caione
The latest USB keyboards shipped on several ASUS laptop models
(including ROG laptop models such as GL702VMK) have the keyboards
backlight controlled by the keyboard firmware.
The firmware implements at least 3 different commands:
- Init command (to use when the system starts
ASUS keyboard with that PID:VID
have the leds. So for such keyboard we would create a useless (and
probably confusing) sysfs entry for a non-existent backlight.
Otherwise we could do the opposite if you agree: delete the QUIRK and
just using this test to decide whether to create the led class or not.
>> +
>> + if (kbd_func & SUPPORT_BKD_BACKLIGHT)
>> + asus_register_kbd_leds(hdev);
>
> Don't you need to check for the return value here?
As written before, I guess if we fail to register the leds it's just
ok to continue (given that we already printed the error message).
Cheers,
--
Carlo Caione | +39.340.80.30.096 | Endless
From: Carlo Caione
The latest USB keyboards shipped on several ASUS laptop models
(including ROG laptop models such as GL702VMK) have the keyboards
backlight controlled by the keyboard firmware.
The firmware implements at least 3 different commands:
- Init command (to use when the system starts
uot;amlogic,s905x". Simple. We
> never match partial strings, so there is no sense in a hardcoded prefix
> that is duplicating information already available.
Ok, then. Fine with me.
Neil, do you want to resend my patch or you can take care of the fixes
for the whole patchset?
Thanks,
--
Carlo Caione
+
>> +/* This UART is brought out to the DB9 connector */
>> +&uart_AO {
>> + status = "okay";
>> +};
>> +
>
> Trailing white line - please watch out for that, git-am will complain.
Right.
[cut]
>> +#include "meson-gxl.dtsi"
>> +
>> +/ {
>> + compatible = "amlogic,meson-gxl", "amlogic,meson-gxl-s905x";
>
> This needs to be reversed.
Agree.
Cheers,
--
Carlo Caione
On 29/08/16 20:38, Andreas Färber wrote:
> Am 29.08.2016 um 10:01 schrieb Carlo Caione:
> > On Mon, Aug 29, 2016 at 9:56 AM, Neil Armstrong
> > wrote:
> >> The new Amlogic GLX SoCs (S905X and S905D) are part of the Meson GX family
> >> so
> >> they s
hset introduces the common dtsi and switches the GLX and GXBB to use
> the common dtsi, the GXBB dtsi is reformated to handle this situation.
>
> This patchset depends on Carlo Caione "ARM64: dts: amlogic: Add basic support
> for Amlogic S905X" [1]
>
> [1]
> http:/
On 25/06/16 18:15, Stefan Agner wrote:
> The PMIC driver used to register itself as poweroff controller by
> default, hence assuming that this device is using the PMIC as
> system power controller.
>
> Signed-off-by: Stefan Agner
> Reviewed-by: Marcel Ziswiler
Acke
finity bits on ThunderX, and their complete
> absence on ls1043a (both of which seem to be related to copy-pasting
> from other DTs).
>
> Signed-off-by: Marc Zyngier
For meson-gxbb.dtsi:
Acked-by: Carlo Caione
--
Carlo Caione
0 BIT(16)
> +#define GXBB_WDT_CTRL1_GPIO_POL_RESET_1 (0)
> +#define GXBB_WDT_CTRL1_GPIO_PULSE_CNT(BIT(16) - 1)
nit: all these defines are not used at all in the driver. You can remove them
Thanks!
--
Carlo Caione
il Armstrong (3):
> watchdog: Add Meson GXBB Watchdog Driver
> dt-bindings: watchdog: Add Meson GXBB Watchdog bindings
> ARM64: dts: amlogic: meson-gxbb: Add watchdog node
I'm missing [PATCH 2/3]
--
Carlo Caione
n-gxbb-wdt.txt
> @@ -0,0 +1,13 @@
> +Meson GXBB SoCs Watchdog timer
> +
> +Required properties:
> +
> +- compatible : should be "amlogic,meson-gxbb-wdt"
> +- reg : Specifies base physical address and size of the registers.
'clocks' is also required IIRC.
Thanks,
--
Carlo Caione
wdt_stop(wdt_dev);
> +
> + meson_gxbb_wdt_ping(wdt_dev);
> +
> + writel(timeout*1000, data->reg_base + GXBB_WDT_TCNT_REG);
nit: spaces around "*"
[...]
> + data->clk = devm_clk_get(&pdev->dev, NULL);
> + if (IS_ERR(data->clk))
> + return PTR_ERR(data->clk);
> +
> + clk_prepare_enable(data->clk);
Do we need to merge the clock controller driver before this?
Cheers,
--
Carlo Caione
On 20/05/16 14:20, Neil Armstrong wrote:
> On 05/20/2016 12:04 PM, Carlo Caione wrote:
> > On 20/05/16 11:10, Neil Armstrong wrote:
> >> On 05/20/2016 11:04 AM, Carlo Caione wrote:
> >>> On 20/05/16 10:27, Neil Armstrong wrote:
> >>>> This patch adds t
will post it with the Ethernet nodes.
> >
> > Why? The header file is related to the reset controller. Better add it
> > now with this patchset.
> >
> > Cheers,
> >
>
> OK, I will add it in gxbb and meson8b dtsi files.
Why also meson8b DTSI?
--
Carlo Caione
On 20/05/16 11:10, Neil Armstrong wrote:
> On 05/20/2016 11:04 AM, Carlo Caione wrote:
> > On 20/05/16 10:27, Neil Armstrong wrote:
> >> This patch adds the platform driver for the Amlogic Meson GXBB Reset
> >> Controller.
> >>
> >> Signed-off-by:
On 20/05/16 10:53, Neil Armstrong wrote:
> On 05/20/2016 10:47 AM, Carlo Caione wrote:
> > On 20/05/16 10:27, Neil Armstrong wrote:
> >> Update DTSI file to add the reset controller node.
> >>
> >> Signed-off-by: Neil Armstrong
> >> ---
> >
On 20/05/16 10:51, Neil Armstrong wrote:
> On 05/20/2016 10:46 AM, Carlo Caione wrote:
> > On 20/05/16 10:27, Neil Armstrong wrote:
> >> Add DT bindings for the Meson GXBB SoC Reset Controller documentation and
> >> the
> >> associated include fil
{
> + .probe = meson_gxbb_reset_probe,
> + .remove = meson_gxbb_reset_remove,
> + .driver = {
> + .name = "meson_gxbb_reset",
> + .of_match_table = meson_gxbb_reset_dt_ids,
> + },
> +};
> +
> +module_platform_driver(meson_gxbb_reset_driver);
No MODULE_AUTHOR, MODULE_LICENSE, etc... ?
--
Carlo Caione
reg = <0x0 0x04404 0x0 0x20>;
> + #reset-cells = <1>;
> + };
> +
> uart_A: serial@84c0 {
> compatible = "amlogic,meson-uart";
> reg = <0x0 0x084c0 0x0 0x14>;
Missing #include ?
Thanks,
--
Carlo Caione
C_ARB 229
> +/* 230 */
> +#define RESET_VID_LOCK 231
> +#define RESET_A9_DMC_PIPEL 232
> +/* 233-255 */
> +
> +#endif
Indentation looks really messy. Can you just shift the numbers to the
right so that they are on the same column?
--
Carlo Caione
On Fri, May 6, 2016 at 3:59 PM, Kevin Hilman wrote:
> Add myself as co-maintainer, update mailing list entry and add a couple
> more directories.
>
> Signed-off-by: Kevin Hilman
Acked-by: Carlo Caione
Thank you!
--
Carlo Caione
n add this kind of information in Documentation/arm/meson/.
Probably it could be handy until we have a proper u-boot porting.
--
Carlo Caione
44
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-telos.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-telos.dts
> @@ -48,7 +48,7 @@
> compatible = "tronsmart,vega-s95-telos", "tronsmart,vega-s95",
> "amlogic,meson-gxbb";
> model = "Tronsmart Vega S95 Telos";
>
> - memory {
> + memory@0 {
> device_type = "memory";
> reg = <0x0 0x0 0x0 0x8000>;
> };
Acked-by: Carlo Caione
Thanks,
--
Carlo Caione
e whole series up.
Cheers,
--
Carlo Caione
name, courtesy of Nicolas.
>
> Signed-off-by: Nicolas Saenz Julienne
> Signed-off-by: Andreas Färber
Acked-by: Carlo Caione
Thanks,
--
Carlo Caione
re and the peripherals that you describe in
> there are clearly within the SoC.
> So something like meson-s905.dtsi or the like?
When I first submitted support for the meson8 and meson8b I picked up
the names according to the Amlogic SDK.
In the latest Amlogic drop this SoC is identified as meson-gxbb so
probably we should stick to this name.
--
Carlo Caione
On Wed, Feb 24, 2016 at 2:15 PM, Laxman Dewangan wrote:
> Use devm_pinctrl_register() for pin control registration.
>
> Signed-off-by: Laxman Dewangan
> Cc: Carlo Caione
> Cc: Beniamino Galvani
> Cc: Lee Jones
Acked-by:
--
Carlo Caione
From: Carlo Caione
Add missing DAPM pins and enable jack detection on those pins for
Cherrytrail and Braswell.
Signed-off-by: Carlo Caione
---
sound/soc/intel/boards/cht_bsw_rt5645.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/sound/soc/intel/boards
On Mon, Feb 8, 2016 at 1:49 PM, Andreas Färber wrote:
> Fix the baudrate calculation for 24 MHz XTAL clock found on gxbb platforms.
>
> Signed-off-by: Andreas Färber
Acked-by: Carlo Caione
Thanks!
--
Carlo Caione
On Mon, Feb 8, 2016 at 9:34 AM, Carlo Caione wrote:
> On Sun, Feb 7, 2016 at 10:13 PM, Andreas Färber wrote:
>> As preparation for arm64 based mesongxbb, which pulls in this code once
>> enabling ARCH_MESON, fix a size_t vs. unsigned int type mismatch.
>> The loop uses
c.h with
size_t since we are going to use it for array indexing.
Also please, CC linux-me...@googlegroups.com on meson related patches.
Thanks!
--
Carlo Caione
ght but I'll
modify it myself and I'll push a PR.
Cheers,
--
Carlo Caione
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
/*
> * Copyright 2015 Endless Mobile, Inc.
> * Author: Carlo Caione
> + * Copyright 2015 Codethink Ltd.
> + * Author: Edward Cragg
Usually we do not add a copyright line for each small addition to the DTS.
> *
> * This file is dual-licensed: you can use it either unde
On Mon, Aug 3, 2015 at 9:48 AM, Chen-Yu Tsai wrote:
> Add a proper module alias so the driver can be autoloaded when the
> parent axp20x mfd driver registers its cells.
>
> Signed-off-by: Chen-Yu Tsai
Acked-by: Carlo Caione
Thanks,
--
Carlo Caione
--
To unsubscribe from this li
states of clockevent
> devices, for example: ONESHOT_STOPPED.
>
> Cc: Carlo Caione
> Signed-off-by: Viresh Kumar
> ---
> drivers/clocksource/meson6_timer.c | 50
> --
> 1 file changed, 27 insertions(+), 23 deletions(-)
Acked-by: Carlo
, flow_type);
>
> - for (i = 0; i <= gc->num_ct; i++, ct++)
> + for (i = 0; i < gc->num_ct; i++, ct++)
> if (ct->type & flow_type)
> ctrl_off = ct->regs.type;
Acked-by: Carlo Caione
--
Carlo Caione
--
To unsu
1 - 100 of 121 matches
Mail list logo
