[PATCH v3] lkdtm: fix memory copy size for WRITE_KERN

From: Candle Sun Though do_overwritten() follows do_nothing() in source code, the final memory address order is determined by the compiler. We can't always assume address of do_overwritten() is bigger than do_nothing(). At least the Clang we are using places do_overwritten() before do_no

Re: [PATCH v2] lkdtm: fix memory copy size for WRITE_KERN

On Thu, Jan 28, 2021 at 1:40 AM Nick Desaulniers wrote: > > On Wed, Jan 27, 2021 at 3:05 AM Candle Sun wrote: > > > > From: Candle Sun > > > > Though do_overwritten() follows do_nothing() in source code, the final > > memory address order is determined

Re: [PATCH] lkdtm: fix memory copy size for WRITE_KERN

ue, Jan 26, 2021 at 6:13 AM Candle Sun wrote: > > > > > > On Mon, Jan 25, 2021 at 6:37 PM David Laight > > > wrote: > > > > > > > > From: Candle Sun > > > > > Sent: 25 January 2021 08:56 > > > > > > > >

[PATCH v2] lkdtm: fix memory copy size for WRITE_KERN

From: Candle Sun Though do_overwritten() follows do_nothing() in source code, the final memory address order is determined by compiler. We can't always assume address of do_overwritten() is bigger than do_nothing(). At least the Clang we are using places do_overwritten() before do_nothing

Re: [PATCH] lkdtm: fix memory copy size for WRITE_KERN

On Tue, Jan 26, 2021 at 5:16 AM Nick Desaulniers wrote: > > On Mon, Jan 25, 2021 at 12:56 AM Candle Sun wrote: > > > > From: Candle Sun > > > > Though do_overwritten() follows do_nothing() in source code, the final > > memory address order is determined

Re: [PATCH] lkdtm: fix memory copy size for WRITE_KERN

On Mon, Jan 25, 2021 at 6:37 PM David Laight wrote: > > From: Candle Sun > > Sent: 25 January 2021 08:56 > > > > From: Candle Sun > > > > Though do_overwritten() follows do_nothing() in source code, the final > > memory address order is determined by co

[PATCH] lkdtm: fix memory copy size for WRITE_KERN

From: Candle Sun Though do_overwritten() follows do_nothing() in source code, the final memory address order is determined by compiler. We can't always assume address of do_overwritten() is bigger than do_nothing(). At least the Clang we are using places do_overwritten() before do_nothing

[PATCH v4] HID: core: check whether Usage Page item is after Usage ID items

From: Candle Sun Upstream commit 58e75155009c ("HID: core: move Usage Page concatenation to Main item") adds support for Usage Page item after Usage ID items (such as keyboards manufactured by Primax). Usage Page concatenation in Main item works well for following report descripto

Re: [RESEND PATCH] ARM/hw_breakpoint: add ARMv8.1/ARMv8.2 debug architecutre versions support in enable_monitor_mode()

On Tue, Oct 22, 2019 at 8:25 PM Will Deacon wrote: > > On Thu, Sep 26, 2019 at 03:38:28PM +0800, Candle Sun wrote: > > From: Candle Sun > > > > When ARMv8.1/ARMv8.2 cores are used in AArch32 mode, > > arch_hw_breakpoint_init() in arch/arm/kernel/hw_breakpoint.c wi

Re: [PATCH v3] HID: core: check whether usage page item is after usage id item

Hi Benjamin, On Tue, Oct 22, 2019 at 5:48 PM Benjamin Tissoires wrote: > > Hi Candle, > > On Mon, Oct 21, 2019 at 9:54 AM Candle Sun wrote: > > > > Hi, > > > > > > On Mon, Oct 21, 2019 at 3:38 PM Candle Sun wrote: > > > > > > From

Re: [PATCH v3] HID: core: check whether usage page item is after usage id item

Hi, On Mon, Oct 21, 2019 at 3:38 PM Candle Sun wrote: > > From: Candle Sun > > Upstream commit 58e75155009c ("HID: core: move Usage Page concatenation > to Main item") adds support for Usage Page item after Usage ID items > (such as keyboards manufacture

[PATCH v3] HID: core: check whether usage page item is after usage id item

From: Candle Sun Upstream commit 58e75155009c ("HID: core: move Usage Page concatenation to Main item") adds support for Usage Page item after Usage ID items (such as keyboards manufactured by Primax). Usage Page concatenation in Main item works well for following report descripto

Re: [RESEND PATCH] ARM/hw_breakpoint: add ARMv8.1/ARMv8.2 debug architecutre versions support in enable_monitor_mode()

Thanks Uwe for pointing out my typing error. Will, Is the patch ok? Do I need to send another version? Candle Candle On Fri, Oct 11, 2019 at 2:00 PM Uwe Kleine-König wrote: > > Hello, > > just noticed a typo in the subject line while going through my lakml > mailbox: > > s/architecutr

Re: [RESEND PATCH] ARM/hw_breakpoint: add ARMv8.1/ARMv8.2 debug architecutre versions support in enable_monitor_mode()

Will, Is the patch useful for you? Would you please give me some suggestions? Thank you. Regards, Candle On Tue, Oct 8, 2019 at 3:20 PM Candle Sun wrote: > > Hi Will, > Sorry for not instant respond. > > > On Mon, Sep 30, 2019 at 11:34 PM Will Deacon wrote: > > > &

Re: [PATCH v2] HID: core: check whether usage page item is after usage id item

On Thu, Oct 10, 2019 at 8:24 PM Benjamin Tissoires wrote: > > On Wed, Oct 9, 2019 at 2:54 PM Candle Sun wrote: > > > > From: Candle Sun > > > > Upstream commit 58e75155009c ("HID: core: move Usage Page concatenation > > to Main item") adds su

Re: [PATCH v2] HID: core: check whether usage page item is after usage id item

On Thu, Oct 10, 2019 at 8:17 PM Benjamin Tissoires wrote: > > On Thu, Oct 10, 2019 at 5:19 AM Candle Sun wrote: > > > > On Thu, Oct 10, 2019 at 2:00 AM Jiri Kosina wrote: > > > > > > On Wed, 9 Oct 2019, Nicolas Saenz Julienne wrote: > > > > >

Re: [PATCH v2] HID: core: check whether usage page item is after usage id item

On Thu, Oct 10, 2019 at 2:00 AM Jiri Kosina wrote: > > On Wed, 9 Oct 2019, Nicolas Saenz Julienne wrote: > > > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > > > index 3eaee2c..3394222 100644 > > > --- a/drivers/hid/hid-core.c > > > +++ b/drivers/hid/hid-core.c > > > @@ -35,6 +35

Re: [PATCH v2] HID: core: check whether usage page item is after usage id item

On Thu, Oct 10, 2019 at 1:01 AM Nicolas Saenz Julienne wrote: > > On Wed, 2019-10-09 at 20:53 +0800, Candle Sun wrote: > > From: Candle Sun > > > > Upstream commit 58e75155009c ("HID: core: move Usage Page concatenation > > to Main item") adds support

[PATCH v2] HID: core: check whether usage page item is after usage id item

From: Candle Sun Upstream commit 58e75155009c ("HID: core: move Usage Page concatenation to Main item") adds support for Usage Page item after Usage ID items (such as keyboards manufactured by Primax). Usage Page concatenation in Main item works well for following report descripto

Re: [RESEND PATCH] ARM/hw_breakpoint: add ARMv8.1/ARMv8.2 debug architecutre versions support in enable_monitor_mode()

Hi Will, Sorry for not instant respond. On Mon, Sep 30, 2019 at 11:34 PM Will Deacon wrote: > > On Thu, Sep 26, 2019 at 03:38:28PM +0800, Candle Sun wrote: > > From: Candle Sun > > > > When ARMv8.1/ARMv8.2 cores are used in AArch32 mode, > > arch_hw_breakp

Re: [PATCH] HID: core: add usage_page_preceding flag for hid_concatenate_usage_page()

Hi Benjamin, Thank you very much for the detailed review. On Mon, Sep 30, 2019 at 5:36 PM Benjamin Tissoires wrote: > > Hi, > > [also addingg Nicolas, the author of 58e75155009c] > > On Mon, Sep 30, 2019 at 10:10 AM Candle Sun wrote: > > > > From: Candl

[PATCH] HID: core: add usage_page_preceding flag for hid_concatenate_usage_page()

From: Candle Sun Upstream commit 58e75155009c ("HID: core: move Usage Page concatenation to Main item") adds support for Usage Page item following Usage items (such as keyboards manufactured by Primax). Usage Page concatenation in Main item works well for following report descripto

[RESEND PATCH] ARM/hw_breakpoint: add ARMv8.1/ARMv8.2 debug architecutre versions support in enable_monitor_mode()

From: Candle Sun When ARMv8.1/ARMv8.2 cores are used in AArch32 mode, arch_hw_breakpoint_init() in arch/arm/kernel/hw_breakpoint.c will be used. >From ARMv8 specification, different debug architecture versions defined: * 0110 ARMv8, v8 Debug architecture. * 0111 ARMv8.1, v8 Debug architect