Re: [PATCH 05/16] arch: remove blackfin port

2018-03-15 Thread Bryan Wu
Personally Blackfin Linux is my most special memory. Thanks a lot for the folks from community and contributors from all over the world. Acked-by: Bryan Wu On Wed, Mar 14, 2018 at 10:36 PM, Arnd Bergmann wrote: > The Analog Devices Blackfin port was added in 2007 and was rather > active

Re: [PATCH] MAINTAINERS: Change LED subsystem git tree URL

2015-08-19 Thread Bryan Wu
On Wed, Aug 19, 2015 at 3:47 AM, Jacek Anaszewski wrote: > This patch removes Bryan Wu from the list of LED subsystem > maintainers and replaces related git tree URL with the one > maintained by Jacek Anaszewski. > > Signed-off-by: Jacek Anaszewski > Cc: Bryan Wu > Cc: Rich

[GIT PULL] LED subsystem updates for 4.2

2015-06-30 Thread Bryan Wu
Hi Linus, In this cycle, we finished to merge patches for LED Flash class driver. Other than that we have some bug fixes and new drivers for LED controllers. So please consider to pull the following changes since commit 5ebe6afaf0057ac3eaeb98defd5456894b446d22: Linux 4.1-rc2 (2015-05-03 19:22:

Re: [PATCH -next] leds: fix aat1290 build errors

2015-06-29 Thread Bryan Wu
>> leds-aat1290.c:(.text+0xe6494): undefined reference to `v4l2_flash_init' >> >> Signed-off-by: Randy Dunlap >> Cc: Jacek Anaszewski >> Cc: Bryan Wu >> Cc: Richard Purdie >> --- >> drivers/leds/Kconfig |1 + >> 1 file cha

Re: [PATCH] drivers/leds: don't use module_init in non-modular leds-cobalt-raq.c

2015-06-16 Thread Bryan Wu
hat the runtime impact is >> zero -- it will remain at level 6 in initcall ordering. >> >> And since it can't be modular, we remove all the __exitcall >> stuff related to module_exit() -- it is dead code that won't >> ever be executed. >> >> Cc:

Re: [PATCH v2] leds: fix brightness changing when software blinking is active

2015-05-19 Thread Bryan Wu
On Fri, May 15, 2015 at 7:41 AM, Jacek Anaszewski wrote: > On 05/15/2015 04:11 PM, Stas Sergeev wrote: >> >> 15.05.2015 17:09, Jacek Anaszewski пишет: >>> >>> On 05/15/2015 10:12 AM, Jacek Anaszewski wrote: Hi Stas, On 05/14/2015 05:24 PM, Stas Sergeev wrote: > > >

Re: [PATCH] leds: remove redundant SET_BRIGHTNESS_SYNC flag

2015-05-14 Thread Bryan Wu
nt I think it's still make code more clear and easy to understand. Thanks, -Bryan > > On 05/13/2015 05:41 PM, Stas Sergeev wrote: >> >> >> There is a complimentary flag called SET_BRIGHTNESS_ASYNC. >> Having both is redundant. This patch removes the unneeded

Re: [PATCH] Documentation: leds-lp5523: describe master fader attributes

2015-05-13 Thread Bryan Wu
On Wed, May 13, 2015 at 2:57 AM, Jacek Anaszewski wrote: > Hi Toshi, > > On 05/13/2015 03:15 AM, Toshi Kikuchi wrote: >> >> Add the usage of the new attributes for master faders. >> >> Signed-off-by: Toshi Kikuchi >> --- >> Documentation/leds/leds-lp5523.txt | 30 ++

Re: [PATCH] leds: lp5523: add master_fader support

2015-05-12 Thread Bryan Wu
On Tue, May 12, 2015 at 1:51 AM, Jacek Anaszewski wrote: > On 05/12/2015 10:25 AM, Kim, Milo wrote: >> >> Hi Jacek and Toshi, >> >> On 5/12/2015 4:25 PM, Jacek Anaszewski wrote: >>> >>> Hi Toshi, >>> >>> On 05/11/2015 09:10 PM, Toshi Kikuchi wrote: This patch introduces 4 new attributes:

Re: [PATCH 3/3] leds: leds-gpio: Allow compile test if !GPIOLIB

2015-05-12 Thread Bryan Wu
On Tue, May 12, 2015 at 3:23 AM, Linus Walleij wrote: > On Thu, May 7, 2015 at 10:08 AM, Geert Uytterhoeven > wrote: > >> The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is >> not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer >> functionality only, can

Re: [PATCH 2/3] leds: leds-gpio: Add missing #include

2015-05-12 Thread Bryan Wu
On Thu, May 7, 2015 at 5:15 AM, Jacek Anaszewski wrote: > On 05/07/2015 10:08 AM, Geert Uytterhoeven wrote: >> >> drivers/leds/leds-gpio.c: In function ‘gpio_leds_create’: >> drivers/leds/leds-gpio.c:194: error: implicit declaration of function >> ‘of_node’ >> drivers/leds/leds-gpio.c:194: warning

Re: [PATCH 1/3] gpiolib: Add missing dummies for the unified device properties interface

2015-05-12 Thread Bryan Wu
On Tue, May 12, 2015 at 3:31 AM, Linus Walleij wrote: > On Thu, May 7, 2015 at 10:08 AM, Geert Uytterhoeven > wrote: > >> If GPIOLIB=n: >> >> drivers/leds/leds-gpio.c: In function ‘gpio_leds_create’: >> drivers/leds/leds-gpio.c:187: error: implicit declaration of function >> ‘devm_get_gp

Re: [PATCH v9 1/3] of: Add vendor prefix for Kinetic technologies

2015-05-12 Thread Bryan Wu
On Tue, May 12, 2015 at 1:37 AM, Ingi Kim wrote: > This patch adds vendor prefix for Kinetic technologies > > Signed-off-by: Ingi Kim > Acked-by: Rob Herring > Acked-by: Seung-Woo Kim > Reviewed-by: Varka Bhadram Merged into my tree with DT reviewer's acks. Thanks, -Bryan > --- > Documentat

Re: [PATCH v9 3/3] leds: Add ktd2692 flash LED driver

2015-05-12 Thread Bryan Wu
On Tue, May 12, 2015 at 5:40 AM, Jacek Anaszewski wrote: > Hi Ingi, > > On 05/12/2015 10:37 AM, Ingi Kim wrote: >> >> This patch adds a driver to support the ktd2692 flash LEDs. >> ktd2692 can control flash current by ExpressWire interface. >> >> Signed-off-by: Ingi Kim >> Acked-by: Seung-Woo Kim

Re: [PATCH v9 2/3] leds: ktd2692: add device tree bindings for ktd2692

2015-05-12 Thread Bryan Wu
On Tue, May 12, 2015 at 5:39 AM, Jacek Anaszewski wrote: > Hi Ingi, > > On 05/12/2015 10:37 AM, Ingi Kim wrote: >> >> This patch adds the device tree bindings for ktd2692 flash LEDs. >> Add Optional properties of child node for Flash LED >> >> Signed-off-by: Ingi Kim >> Acked-by: Seung-Woo Kim >

Re: [PATCH 1/3] gpiolib: Add missing dummies for the unified device properties interface

2015-05-08 Thread Bryan Wu
On Thu, May 7, 2015 at 1:08 AM, Geert Uytterhoeven wrote: > If GPIOLIB=n: > > drivers/leds/leds-gpio.c: In function ‘gpio_leds_create’: > drivers/leds/leds-gpio.c:187: error: implicit declaration of function > ‘devm_get_gpiod_from_child’ > drivers/leds/leds-gpio.c:187: warning: assign

Re: [PATCH] MAINTAINERS: Add co-maintainer for LED subsystem

2015-04-24 Thread Bryan Wu
On Thu, Apr 16, 2015 at 10:09 AM, Bryan Wu wrote: > On Thu, Apr 9, 2015 at 10:30 AM, Bryan Wu wrote: >> On Thu, Apr 9, 2015 at 1:01 AM, Jacek Anaszewski >> wrote: >>> This patch adds myself (Jacek Anaszewski) as a co-maintainer for >>> LED subsystem. >>&g

Re: [PATCH] leds: gpio: Fix device teardown on probe deferral

2015-04-20 Thread Bryan Wu
lready >> registered led is not torn down properly. This causes create_gpio_led() >> to fail for the first led on re-probe(). >> >> Fix this misbehaviour by incrementing num_leds only if all >> potentially failing calls completed successfully. >> >> Signed-

Re: [PATCH] MAINTAINERS: Add co-maintainer for LED subsystem

2015-04-16 Thread Bryan Wu
On Thu, Apr 9, 2015 at 10:30 AM, Bryan Wu wrote: > On Thu, Apr 9, 2015 at 1:01 AM, Jacek Anaszewski > wrote: >> This patch adds myself (Jacek Anaszewski) as a co-maintainer for >> LED subsystem. >> > > Jacek will start to help maintain LED subsystem. > > Acke

[GIT PULL] LED subsystem updates for 4.1

2015-04-15 Thread Bryan Wu
Hi Linus, In this cycle, we merged some fix and update for LED Flash class driver. Then the core code of LED Flash class driver is in the kernel now. Moreover, we also got some bug fixes, code cleanup and new drivers for LED controllers. So please consider to pull the following changes since comm

Re: [PATCH v2] leds: fix redundant trigger API #ifdef

2015-04-09 Thread Bryan Wu
On Thu, Apr 9, 2015 at 8:37 AM, Valentin Rothberg wrote: > Commit 5a15d172057c ("leds: unify the location of led-trigger API") > moved the leds trigger API to led.h. Moving the function definitions > caused a logical problem regarding the visibility of #idef blocks. As > listed in the code snipp

Re: [PATCH -next] leds: Fix build failure seen if LEDS_TRIGGERS is not configured

2015-04-09 Thread Bryan Wu
On Thu, Apr 9, 2015 at 8:42 AM, Guenter Roeck wrote: > Fix: > > drivers/leds/led-class.c: In function 'brightness_store': > drivers/leds/led-class.c:57: error: > implicit declaration of function 'led_trigger_remove' > > seen if LEDS_TRIGGERS is not configured. > Thanks for

Re: [PATCH] MAINTAINERS: Add co-maintainer for LED subsystem

2015-04-09 Thread Bryan Wu
On Thu, Apr 9, 2015 at 1:01 AM, Jacek Anaszewski wrote: > This patch adds myself (Jacek Anaszewski) as a co-maintainer for > LED subsystem. > Jacek will start to help maintain LED subsystem. Acked-by: Bryan Wu > Signed-off-by: Jacek Anaszewski > --- > MAINTAINERS |1 +

Re: [PATCH] leds-gpio: Fix error handling and memory leak

2015-03-30 Thread Bryan Wu
On Thu, Mar 26, 2015 at 8:08 PM, Corey Minyard wrote: > On 03/26/2015 08:20 PM, Bryan Wu wrote: >> On Mon, Mar 9, 2015 at 5:43 PM, wrote: >>> From: Corey Minyard >>> >>> The leds-gpio driver would not clean up properly if it failed in some >>> p

Re: [PATCH 0/3] Handle LEDs with the same name

2015-03-30 Thread Bryan Wu
On Mon, Mar 30, 2015 at 10:45 AM, Ricardo Ribalda Delgado wrote: > This is a rework of the original patch + 3 fixup patches from me. > Contains a lot of feedback from Geert Uytterhoeven > Thanks! > > Ricardo Ribalda Delgado (1): > leds/led-class: Handle LEDs with the same name > > Sakari Ailus

Re: [PATCH 0/3] leds/class: Fix string handling

2015-03-30 Thread Bryan Wu
On Mon, Mar 30, 2015 at 10:46 AM, Ricardo Ribalda Delgado wrote: > Hello Bryan > > On Mon, Mar 30, 2015 at 7:15 PM, Bryan Wu wrote: >> Thanks, Geert and Ricardo. >> Ricardo, do you mind folding your fixing patches with original one >> together and send it out again

Re: [PATCH 0/3] leds/class: Fix string handling

2015-03-30 Thread Bryan Wu
On Mon, Mar 30, 2015 at 1:55 AM, Ricardo Ribalda Delgado wrote: > Fix errors reported by Geert Uytterhoeven. > > I didn't have the chance to test the changes it in real hardware. > > Thanks, Geert and Ricardo. Ricardo, do you mind folding your fixing patches with original one together and send it

Re: [PATCH v3] led/led-class: Handle LEDs with the same name

2015-03-27 Thread Bryan Wu
On Fri, Mar 27, 2015 at 1:09 AM, Ricardo Ribalda Delgado wrote: > Hi Sakari > > cc: adding Greg (core and FormatGuard) and Chistopher (sparse) >> >> I just realised there was another issue --- the name is now interpreted as >> format string. Bad things will happen if there's e.g. %s in the name it

Re: [PATCH] leds-gpio: Fix error handling and memory leak

2015-03-26 Thread Bryan Wu
On Mon, Mar 9, 2015 at 5:43 PM, wrote: > From: Corey Minyard > > The leds-gpio driver would not clean up properly if it failed in some > places, and it wasn't freeing its private data. > > Signed-off-by: Corey Minyard > --- > drivers/leds/leds-gpio.c | 13 + > 1 file changed, 9 ins

Re: [PATCH v3] led/led-class: Handle LEDs with the same name

2015-03-25 Thread Bryan Wu
On Wed, Mar 25, 2015 at 6:53 AM, Sakari Ailus wrote: > On Wed, Mar 25, 2015 at 02:22:53PM +0100, Ricardo Ribalda Delgado wrote: >> Hi Sakari! >> >> Regarding s/dev_info/dev_warn : Do you want to send the patch or I should >> >> do it? >> > >> > Is this one merged already? If yes, sure I can. Othe

Re: [PATCH v2] leds: Add arbitrary pattern trigger

2015-03-20 Thread Bryan Wu
On Fri, Mar 20, 2015 at 7:42 AM, Raphaël Teysseyre wrote: > Hi all, > > Following your comments about [PATCH] leds: Add arbitrary pattern trigger, > here is a revised version of this patch. > > This is intended for embedded systems without screen or network access > to show a status (or error) cod

Re: [PATCH/RFC v13 02/13] dt-binding: leds: Add common LED DT bindings macros

2015-03-17 Thread Bryan Wu
On Thu, Mar 12, 2015 at 8:45 AM, Jacek Anaszewski wrote: > Add macros for defining boost mode and trigger type properties > of flash LED devices. > Applied, thanks, -Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie

Re: [PATCH] leds: fix semicolon.cocci warnings

2015-03-17 Thread Bryan Wu
On Tue, Mar 17, 2015 at 12:42 PM, kbuild test robot wrote: > drivers/leds/leds-pm8941-wled.c:368:2-3: Unneeded semicolon > > > Removes unneeded semicolon. I fixed it and pushed again. Thanks, -Bryan > > Generated by: scripts/coccinelle/misc/semicolon.cocci > > CC: Courtney Cavin > Signed-off-b

Re: [PATCH v4 2/2] leds: add Qualcomm PM8941 WLED driver

2015-03-17 Thread Bryan Wu
On Thu, Mar 12, 2015 at 8:47 AM, Bjorn Andersson wrote: > > From: Courtney Cavin > > This adds support for the WLED ('White' LED) block on Qualcomm's > PM8941 PMICs. > Thanks, applied! -Bryan > Signed-off-by: Courtney Cavin > Signed-off-by: Bjorn Andersson > --- > Changes since v3: > - Use de

Re: [PATCH/RFC v12 04/19] dt-binding: leds: Add common LED DT bindings macros

2015-03-09 Thread Bryan Wu
On Wed, Mar 4, 2015 at 11:56 PM, Jacek Anaszewski wrote: > On 03/04/2015 05:14 PM, Jacek Anaszewski wrote: >> >> Add macros for defining boost mode and trigger type properties >> of flash LED devices. >> >> Signed-off-by: Jacek Anaszewski >> Acked-by

Re: [PATCH/RFC v12 03/19] Documentation: leds: Add description of LED Flash class extension

2015-03-09 Thread Bryan Wu
On Wed, Mar 4, 2015 at 8:14 AM, Jacek Anaszewski wrote: > The documentation being added contains overall description of the > LED Flash Class and the related sysfs attributes. > Thanks, merged! -Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan

Re: [PATCH/RFC v12 02/19] leds: flash: document sysfs interface

2015-03-09 Thread Bryan Wu
On Wed, Mar 4, 2015 at 8:14 AM, Jacek Anaszewski wrote: > Add a documentation of LED Flash class specific sysfs attributes. > Thanks, merged! -Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > --- > Documentation

Re: [PATCH/RFC v12 01/19] leds: flash: Remove synchronized flash strobe feature

2015-03-09 Thread Bryan Wu
On Wed, Mar 4, 2015 at 8:14 AM, Jacek Anaszewski wrote: > Synchronized flash strobe feature has been considered not fitting > for LED subsystem sysfs interface and thus is being removed. > OK, I will merge this. -Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Pa

Re: [PATCH RFC] leds: Add status code trigger

2015-03-09 Thread Bryan Wu
On Thu, Feb 19, 2015 at 12:26 AM, Raphaël Teysseyre wrote: > Hi all, > > Here is a new trigger. It would allow userspace to make an LED > blink with a pattern to show a status (or error) code to a human. > This is useful for embedded systems without screen or network > access. Obviously, the LED w

Re: [PATCH v3 2/2] leds: add Qualcomm PM8941 WLED driver

2015-03-09 Thread Bryan Wu
On Tue, Feb 24, 2015 at 7:49 PM, Bjorn Andersson wrote: > From: Courtney Cavin > > This adds support for the WLED ('White' LED) block on Qualcomm's > PM8941 PMICs. > > Signed-off-by: Courtney Cavin > Signed-off-by: Bjorn Andersson > --- > > The details surrounding the OVP spike issue that Steph

Re: [PATCH v2] leds: Introduce devres helper for led_classdev_register

2015-03-09 Thread Bryan Wu
On Mon, Feb 23, 2015 at 4:11 PM, Bjorn Andersson wrote: > Suggested-by: Stephen Boyd > Signed-off-by: Bjorn Andersson > --- > Changes since v1: > - updating devres.txt > - unregister function I merged this patch into my tree and added _unregister function into document. Thanks, -Bryan > > Do

Re: [PATCH 0/3] Add ktd2692 Flash LED driver

2015-03-02 Thread Bryan Wu
On Mon, Mar 2, 2015 at 1:15 AM, Sakari Ailus wrote: > H Ingi, > > On Mon, Mar 02, 2015 at 04:14:39PM +0900, Ingi Kim wrote: >> Hi Jacek >> >> On 2015년 02월 27일 17:42, Jacek Anaszewski wrote: >> > Hi Ingi, >> > >> > On 02/27/2015 02:01 AM, Ingi Kim wrote: >> >> This patch supports KTD2692 flash LED

Re: [PATCH v2 3/4] leds: Let the binding document example for leds-gpio follow the gpio bindings

2015-03-02 Thread Bryan Wu
On Mon, Mar 2, 2015 at 3:24 AM, Linus Walleij wrote: > On Wed, Jan 21, 2015 at 10:33 PM, Olliver Schinagl > wrote: > >> From: Olliver Schinagl >> >> In the gpio bindings documents it is requested to use the marco's in >> include/dt-bindings/gpio/gpio.h whenever possible. The gpios in the led >>

Re: [PATCH] led/led-class: Handle LEDs with the same name

2015-02-19 Thread Bryan Wu
On Tue, Feb 17, 2015 at 10:55 PM, Ricardo Ribalda Delgado wrote: > Hi > > On Wed, Feb 18, 2015 at 2:36 AM, Bryan Wu wrote: > >>> >> >> I got it. In this case we need to give the leds device a unique name. >> Go back to your patch, you're adding 0, 1 at

Re: [PATCH] led/led-class: Handle LEDs with the same name

2015-02-17 Thread Bryan Wu
> Thanks! On Tue, Feb 17, 2015 at 5:11 PM, Ricardo Ribalda Delgado wrote: > Hello Bryan > > On Wed, Feb 18, 2015 at 1:52 AM, Bryan Wu wrote: >>> >>> Lets say that we have a type of add-on card. Described by this DT >>> overlay (card.dtb): >>&

Re: [PATCH] led/led-class: Handle LEDs with the same name

2015-02-17 Thread Bryan Wu
On Tue, Feb 17, 2015 at 4:32 PM, Ricardo Ribalda Delgado wrote: > Hello Bryan > > On Wed, Feb 18, 2015 at 12:59 AM, Bryan Wu wrote: >> >> DT just describe the hardware, so if it's a different hardware, they >> should have different name. >> red0 for GPIO 0

Re: [PATCH] led/led-class: Handle LEDs with the same name

2015-02-17 Thread Bryan Wu
On Tue, Feb 17, 2015 at 3:47 PM, Ricardo Ribalda Delgado wrote: > Hi > > On Wed, Feb 18, 2015 at 12:35 AM, Bryan Wu wrote: > >> So why not use name "red0" and name another one "red1"? since you have >> multiple different red leds here any way. > &g

Re: [PATCH] led/led-class: Handle LEDs with the same name

2015-02-17 Thread Bryan Wu
On Tue, Feb 17, 2015 at 2:54 PM, Ricardo Ribalda Delgado wrote: > Hello Bryan > > On Tue, Feb 17, 2015 at 11:34 PM, Bryan Wu wrote: >> >> Can you show me your device tree code for overlaying describing a camera? >> > > The camera is composed by fpga modules. T

Re: [PATCH v2 2/2] leds: add Qualcomm PM8941 WLED driver

2015-02-17 Thread Bryan Wu
On Tue, Feb 17, 2015 at 2:30 PM, Bjorn Andersson wrote: > On Tue, Feb 17, 2015 at 2:14 PM, Bryan Wu wrote: >> On Thu, Feb 12, 2015 at 8:04 PM, Stephen Boyd wrote: >>> On 01/23/15 16:54, Bjorn Andersson wrote: >> >> Thanks for the review, Stephen. >> Bjorn

Re: [PATCH] led/led-class: Handle LEDs with the same name

2015-02-17 Thread Bryan Wu
On Thu, Feb 12, 2015 at 12:45 PM, Ricardo Ribalda Delgado wrote: > Hello Bryan > > On Thu, Feb 12, 2015 at 8:48 PM, Bryan Wu wrote: >> >> Could you please give me some real error message or example about this >> device tree overlays? Looks like it's not only fo

Re: [PATCH v2 2/2] leds: add Qualcomm PM8941 WLED driver

2015-02-17 Thread Bryan Wu
On Thu, Feb 12, 2015 at 8:04 PM, Stephen Boyd wrote: > On 01/23/15 16:54, Bjorn Andersson wrote: Thanks for the review, Stephen. Bjorn, could you please update your patch according to Stephen's review. -Bryan >> + >> +static int pm8941_wled_configure(struct pm8941_wled *wled, struct device >>

Re: [PATCH] led/led-class: Handle LEDs with the same name

2015-02-12 Thread Bryan Wu
On Wed, Feb 11, 2015 at 4:26 AM, Ricardo Ribalda Delgado wrote: > The current code expected that every LED had an unique name. This is a > legit expectation when the device tree can no be modified or extended. > But with device tree overlays this requirement can be easily broken. > Could you plea

Re: [PATCH v2 2/2] leds: add Qualcomm PM8941 WLED driver

2015-02-12 Thread Bryan Wu
On Thu, Jan 29, 2015 at 11:07 AM, Bjorn Andersson wrote: > On Thu 29 Jan 04:48 PST 2015, Ivan T. Ivanov wrote: > >> >> Hi Bjorn, >> >> Just few nitpick comments. >> > > Thanks. > >> On Fri, 2015-01-23 at 16:54 -0800, Bjorn Andersson wrote: >> > From: Courtney Cavin ca...@sonymobile.com> >> > >> >

Re: [PATCH v2 1/2] leds: add DT binding for Qualcomm PM8941 WLED block

2015-02-12 Thread Bryan Wu
On Fri, Jan 23, 2015 at 4:54 PM, Bjorn Andersson wrote: > From: Courtney Cavin > > This adds device tree binding documentation for the WLED ('White' LED) > block on Qualcomm's PM8941 PMICs. > > Signed-off-by: Courtney Cavin > Signed-off-by: Bjorn Andersson I will merge this into my branch for

[GIT PULL] LED subsystem for 3.20 merge window

2015-02-12 Thread Bryan Wu
Hi Linus, The big change of LED subsystem is introducing a new LED class for Flash type LEDs which will be used for V4L2 subsystem. Also we got some cleanup and fixes. So please conside the following changes since commit 188c901941efd43cbf21e8f4f9e9a276536b989c: Merge branch 'leds-fixes-for-3

Re: [PATCH] leds: leds-gpio: Pass on error codes unmodified

2015-02-02 Thread Bryan Wu
On Sun, Feb 1, 2015 at 8:59 AM, Sören Brinkmann wrote: > + Andreas who actually reported this issue and also tested the patch. > > On Sat, 2015-01-31 at 07:15PM -0800, Soren Brinkmann wrote: >> Instead of overriding error codes, pass them on unmodified. This >> way a EPROBE_DEFER is correctly pass

Re: [PATCH v2 2/4] gpio: add parameter to allow the use named gpios

2015-01-30 Thread Bryan Wu
s match your vision of how it should work, i.e. ACK? > > Bryan/Dmitry: can you ACK the oneliners in your subsystems? Sure, please take my Ack Acked-by: Bryan Wu > > Yours, > Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH/RFC v10 02/19] Documentation: leds: Add description of LED Flash class extension

2015-01-26 Thread Bryan Wu
ss and the related sysfs attributes. >>> >>> Signed-off-by: Jacek Anaszewski >>> Acked-by: Kyungmin Park >>> Cc: Bryan Wu >>> Cc: Richard Purdie >> >> >>> +In order to enable support for flash LEDs CONFIG_LEDS_CLASS_FL

Re: [PATCH/RFC v10 01/19] leds: Add LED Flash class extension to the LED subsystem

2015-01-26 Thread Bryan Wu
ernel internal interface. When V4L2 Flash sub-device >> file is opened, the LED class device sysfs interface is made >> unavailable. >> >> Signed-off-by: Jacek Anaszewski >> Acked-by: Kyungmin Park >> Cc: Bryan Wu >> Cc: Richard Purdie > > Acke

Re: [PATCH 2/3] leds: leds-mc13783: Use of_get_child_by_name() instead of refcount hack

2015-01-14 Thread Bryan Wu
On Wed, Jan 14, 2015 at 5:51 AM, Geert Uytterhoeven wrote: > of_find_node_by_name() calls of_node_put() on its "from" parameter. > To counter this, mc13xxx_led_probe_dt() calls of_node_get() first. > > Use of_get_child_by_name() instead to get rid of the refcount hack. > > Signed-off-by: Geert Uyt

[GIT PULL] LED fix for 3.19

2015-01-13 Thread Bryan Wu
Hi Linus, Please consider the following changes since commit eaa27f34e91a14cdceed26ed6c6793ec1d186115: linux 3.19-rc4 (2015-01-11 12:44:53 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux-leds.git leds-fixes-for-3.19 for you to fet

Re: LED: inform userspace about brightness change

2015-01-06 Thread Bryan Wu
On Wed, Dec 24, 2014 at 12:06 PM, Pali Rohár wrote: > Hello! > > What is preferred way from kernel driver to inform userspace > about LED device brightness change? In /sys/class/leds// > is file brightness which can be used to read current brightness > or set write new value. But sometimes also fi

Re: [PATCH 14/27] leds: Use setup_timer

2015-01-05 Thread Bryan Wu
On Fri, Dec 26, 2014 at 6:35 AM, Julia Lawall wrote: > Convert a call to init_timer and accompanying intializations of > the timer's data and function fields to a call to setup_timer. > > A simplified version of the semantic match that fixes this problem is as > follows: (http://coccinelle.lip6.fr

Re: [PATCH] leds: Don't allow brightness values greater than max_brightness

2014-12-23 Thread Bryan Wu
On Tue, Dec 23, 2014 at 10:59 AM, Gabriele Mazzotta wrote: > Since commit 4d71a4a12b13 ("leds: Add support for setting brightness in > a synchronous way") the value passed to brightness_set() is no longer > limited to max_brightness and can be different from the internally saved > brightness value

Re: [PATCH 1/2] leds: add DT binding for Qualcomm PM8941 WLED block

2014-12-16 Thread Bryan Wu
On Tue, Dec 9, 2014 at 5:19 PM, Bryan Wu wrote: > On Mon, Dec 8, 2014 at 4:22 PM, Bjorn Andersson > wrote: >> From: Courtney Cavin >> >> This adds device tree binding documentation for the WLED ('White' LED) >> block on Qualcomm's PM8941 PMICs

Re: [PATCH 2/2] leds: add Qualcomm PM8941 WLED driver

2014-12-16 Thread Bryan Wu
On Mon, Dec 8, 2014 at 4:22 PM, Bjorn Andersson wrote: > From: Courtney Cavin > > This adds support for the WLED ('White' LED) block on Qualcomm's > PM8941 PMICs. > > Signed-off-by: Courtney Cavin > Signed-off-by: Bjorn Andersson > --- > drivers/leds/Kconfig| 8 + > drivers/leds/

[GIT PULL] LED subsystem for 3.19 merge window

2014-12-15 Thread Bryan Wu
Hi Linus, We got some cleanup and driver for LP8860 as well as some patches for LED Flash Class. So please consider the following changes since commit 206c5f60a3d902bc4b56dab2de3e88de5eb06108: Linux 3.18-rc4 (2014-11-09 14:55:29 -0800) are available in the git repository at: git://git.kerne

Re: [PATCH 1/2] leds: add DT binding for Qualcomm PM8941 WLED block

2014-12-09 Thread Bryan Wu
On Mon, Dec 8, 2014 at 4:22 PM, Bjorn Andersson wrote: > From: Courtney Cavin > > This adds device tree binding documentation for the WLED ('White' LED) > block on Qualcomm's PM8941 PMICs. > Looks good to me, I need device tree reviewer's Ack to merge it. Thanks, -Bryan > Signed-off-by: Courtn

Re: [PATCH] leds: leds-gpio: Fix the "default-state" property check

2014-12-09 Thread Bryan Wu
k to restore the original behaviour. > > Fixes: a43f2cbbb009 (leds: leds-gpio: Make use of device property API) Thanks, please take my Ack Acked-by: Bryan Wu I think Rafael will take this fix with other patches through his tree. > Reported-by: Jean-Michel Hautbois > Signed-off-by: Fabio

Re: [PATCH/RFC v8 03/14] Documentation: leds: Add description of v4l2-flash sub-device

2014-12-05 Thread Bryan Wu
On Fri, Nov 28, 2014 at 1:17 AM, Jacek Anaszewski wrote: > This patch extends LED Flash class documention by > the description of interactions with v4l2-flash sub-device. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie &g

Re: [PATCH/RFC v8 02/14] Documentation: leds: Add description of LED Flash class extension

2014-12-05 Thread Bryan Wu
On Mon, Dec 1, 2014 at 5:58 AM, Jacek Anaszewski wrote: > Hi Pavel, > > On 12/01/2014 02:04 PM, Pavel Machek wrote: >> >> Hi! >> How are faults cleared? Should it be list of strings, instead of bitmask? We may want to add new fault modes in future... >>> >>> >>> Faults are cleared by rea

[PATCH] MAINTAINERS: remove my name from Backlight subsystem

2014-12-03 Thread Bryan Wu
Signed-off-by: Bryan Wu --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ea4d005..1cb460f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1862,7 +1862,6 @@ F:drivers/net/wireless/b43legacy/ BACKLIGHT CLASS/SUBSYSTEM M: Jingoo Han

Re: [PATCH v9 4/8] devicetree: backlight: Add new SKY81452 backlight binding

2014-12-02 Thread Bryan Wu
On Tue, Dec 2, 2014 at 12:05 AM, wrote: > From: Gyungoh Yoo > > Signed-off-by: Gyungoh Yoo Acked-by: Bryan Wu Thanks, -Bryan > --- > Changes v9: > Nothing > > Changes v8: > Renamed property names for backlight with vendor prefix > Modified gpio-enable propert

Re: [PATCH v9 2/8] backlight: Add support Skyworks SKY81452 backlight driver

2014-12-02 Thread Bryan Wu
On Tue, Dec 2, 2014 at 12:05 AM, wrote: > From: Gyungoh Yoo > > Signed-off-by: Gyungoh Yoo This patch looks good to me and I think Jingoo reviewed it already. So please take my Ack here: Acked-by: Bryan Wu Lee, can you apply this patch? Thanks, -Bryan > --- > Change

Re: [PATCH v3] leds: lp8860: Introduce TI lp8860 4 channel LED driver

2014-11-19 Thread Bryan Wu
On Wed, Nov 19, 2014 at 4:48 AM, Dan Murphy wrote: > Introduce the Texas Instruments lp8860 > 4 channel LED driver. > > This driver configures the device in display cluster mode > as this seems to be the most used configuration at the > time of the driver configuration. > > For more product inform

Re: [PATCH v2] leds: lp8860: Introduce TI lp8860 4 channel LED driver

2014-11-18 Thread Bryan Wu
On Tue, Nov 18, 2014 at 3:50 PM, Dan Murphy wrote: > Bryan > > On 11/18/2014 04:56 PM, Bryan Wu wrote: >> On Tue, Nov 18, 2014 at 6:43 AM, Dan Murphy wrote: >>> Introduce the Texas Instruments lp8860 >>> 4 channel LED driver. >>> >>> This d

Re: [PATCH v2] leds: lp8860: Introduce TI lp8860 4 channel LED driver

2014-11-18 Thread Bryan Wu
On Tue, Nov 18, 2014 at 6:43 AM, Dan Murphy wrote: > Introduce the Texas Instruments lp8860 > 4 channel LED driver. > > This driver configures the device in display cluster mode > as this seems to be the most used configuration at the > time of the driver configuration. > > For more product inform

Re: [PATCH] leds: lp8860: Introduce TI lp8860 4 channel LED driver

2014-11-13 Thread Bryan Wu
On Thu, Nov 13, 2014 at 4:35 AM, Dan Murphy wrote: > Introduce the Texas Instruments lp8860 > 4 channel LED driver. > > This driver configures the device in display custer mode custer or cluster? > as this seems to be the most used configuration at the > time of the driver configuration. > > For

[GIT PULL] LED subsystem for 3.18 merge window

2014-10-20 Thread Bryan Wu
driver hwmon: (menf21bmc) Introduce MEN14F021P00 BMC HWMON driver Bryan Wu (1): Merge tag 'mfd-hwmon-leds-watchdog-v3.18' into devel Jacek Anaszewski (5): leds: Reorder include directives leds: make brightness type consistent across whole subsystem leds: a

Re: [PATCH 12/13] leds: leds-gpio: Make use of device property API

2014-10-08 Thread Bryan Wu
ious versions if I remember correctly, > but it's changed quite a bit since then, so can you please check this new > version too? > Sure, the new one is even better than before. Please go ahead with my Ack Acked-by: Bryan Wu Thanks, -Bryan >> --- >> drivers/led

Re: [PATCH 2/2] led: remove use of gpiochip_remove() retval

2014-10-03 Thread Bryan Wu
On Thu, Oct 2, 2014 at 12:12 AM, Linus Walleij wrote: > On Tue, Sep 30, 2014 at 11:21 PM, Bryan Wu wrote: >> On Tue, Sep 30, 2014 at 7:35 AM, Pramod Gurav >> wrote: >>> Get rid of using return value from gpiochip_remove() as it returns >>> void. >&g

Re: [PATCH 2/2] led: remove use of gpiochip_remove() retval

2014-09-30 Thread Bryan Wu
> Cc: Alexandre Courbot > Cc: Bryan Wu > Cc: Richard Purdie > Cc: linux-l...@vger.kernel.org > > Cc: linux-g...@vger.kernel.org > > Signed-off-by: Pramod Gurav > --- > drivers/leds/leds-pca9532.c | 10 ++ > drivers/leds/leds-tca6507.c |7 ++-

Re: [PATCH v6 0/4] Introduce MEN 14F021P00 BMC driver series

2014-09-24 Thread Bryan Wu
On Wed, Sep 24, 2014 at 9:57 AM, Guenter Roeck wrote: > On Wed, Sep 24, 2014 at 09:33:32AM -0700, Bryan Wu wrote: >> On Wed, Sep 24, 2014 at 9:18 AM, Lee Jones wrote: >> > On Wed, 24 Sep 2014, Guenter Roeck wrote: >> > >> >> On Wed, Sep 24, 20

Re: [PATCH v6 0/4] Introduce MEN 14F021P00 BMC driver series

2014-09-24 Thread Bryan Wu
On Wed, Sep 24, 2014 at 9:18 AM, Lee Jones wrote: > On Wed, 24 Sep 2014, Guenter Roeck wrote: > >> On Wed, Sep 24, 2014 at 03:48:29PM +0100, Lee Jones wrote: >> > Guenter, Bryan, Wim, >> > >> > The following changes since commit >> > 52addcf9d6669fa439387610bc65c92fa0980cef: >> > >> > Linux 3.1

Re: [PATCH v3] leds: Add DT support for leds-pca9532

2014-09-22 Thread Bryan Wu
On Wed, Sep 10, 2014 at 8:29 AM, Roland Stigge wrote: > This patch adds DT support for leds-pca9532. > > Signed-off-by: Roland Stigge > > --- > Applies to v3.17-rc4 > > v3: Removed superfluous whitespace > v2: Removed #ifdef statements > > Documentation/devicetree/bindings/leds/leds-pca9532.tx

Re: [RFC PATCH v2 00/16] Add ACPI _DSD and unified device properties support

2014-09-22 Thread Bryan Wu
> leds: leds-gpio: Add support for GPIO descriptors > input: gpio_keys_polled - Add ACPI probing support > misc: at25: Make use of device property API > misc: at25: Add ACPI probing support > > Rafael J. Wysocki (1): > Driver core: Unified device properties interf

Re: [PATCH/RFC v5 1/4] leds: Improve and export led_update_brightness

2014-09-12 Thread Bryan Wu
On Fri, Sep 5, 2014 at 2:03 PM, Bryan Wu wrote: > On Wed, Aug 20, 2014 at 6:41 AM, Jacek Anaszewski > wrote: >> led_update_brightness helper function used to be exploited only locally >> in the led-class.c module, where its result was being passed to the >> brightness_s

Re: [PATCH 2/2] leds: trigger: gpio: make ledtrig-gpio useable with GPIO drivers requiring threaded irqs

2014-09-12 Thread Bryan Wu
On Fri, Sep 12, 2014 at 12:09 AM, Lothar Waßmann wrote: > Hi, > > Bryan Wu wrote: >> On Tue, Sep 9, 2014 at 12:40 AM, Lothar Waßmann >> wrote: >> > When trying to use the LED GPIO trigger with e.g. the PCA953x GPIO >> > driver, request_irq() fail

Re: [PATCH/RFC v5 2/4] leds: implement sysfs interface locking mechanism

2014-09-11 Thread Bryan Wu
sh > sub-device control. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > --- > drivers/leds/led-class.c| 23 --- > drivers/leds/led-core.c | 18 ++ > drivers/leds/led

Re: [PATCH 2/2] leds: trigger: gpio: make ledtrig-gpio useable with GPIO drivers requiring threaded irqs

2014-09-11 Thread Bryan Wu
On Tue, Sep 9, 2014 at 12:40 AM, Lothar Waßmann wrote: > When trying to use the LED GPIO trigger with e.g. the PCA953x GPIO > driver, request_irq() fails with -EINVAL, because the GPIO driver > requires a nested interrupt handler. > > Use request_any_context_irq() to be able to use any GPIO drive

Re: [PATCH 1/2] leds: trigger: gpio: fix warning in gpio trigger for gpios whose accessor function may sleep

2014-09-11 Thread Bryan Wu
On Tue, Sep 9, 2014 at 12:40 AM, Lothar Waßmann wrote: > When using a GPIO driver whose accessor functions may sleep (e.g. an > I2C GPIO extender like PCA9554) the following warning is issued: > WARNING: CPU: 0 PID: 665 at drivers/gpio/gpiolib.c:2274 > gpiod_get_raw_value+0x3c/0x48() > Modules l

Re: [PATCH/RFC v5 1/4] leds: Improve and export led_update_brightness

2014-09-05 Thread Bryan Wu
-Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > --- > drivers/leds/led-class.c |6 -- > drivers/leds/led-core.c | 16 > include/linux/leds.h | 10 ++ > 3 files changed

[GIT PULL] LED fix for 3.17

2014-09-02 Thread Bryan Wu
Hi Linus, Hugh, Jiri and many other people found a kernel oops due to a LED change merged recently. Now the right fix might just revert it and unblock the kernel oops. Please check the bug report in the patch commit message and consider merge the following changes since commit 69e273c0b0a3c337a521

Re: [PATCH] Revert "leds: convert blink timer to workqueue"

2014-09-02 Thread Bryan Wu
> [] call_timer_fn+0x75/0x180 > [] ? process_timeout+0x10/0x10 > [] ? __ieee80211_get_rx_led_name+0x10/0x10 [mac80211] > [] run_timer_softirq+0x1fc/0x2f0 > [] __do_softirq+0x115/0x2e0 > [] irq_exit+0xa5/0xb0 > [] do_IRQ+0x53/0xf0 > [] common_interrupt+0x6f/0x6f

Re: [PATCH] Revert "leds: convert blink timer to workqueue"

2014-09-02 Thread Bryan Wu
On Tue, Sep 2, 2014 at 8:55 AM, Josh Boyer wrote: > On Tue, Sep 2, 2014 at 5:03 AM, Jiri Kosina wrote: >> This reverts commit 8b37e1bef5a6b60e949e28a4db3006e4b00bd758. >> >> It's broken as it changes led_blink_set() in a way that it can now sleep >> (while synchronously waiting for workqueue to b

Re: [PATCH v6 3/4] drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver

2014-08-28 Thread Bryan Wu
On Wed, Aug 27, 2014 at 10:52 AM, Andreas Werner wrote: > Added driver to support the 14F021P00 BMC LEDs. > The BMC is a Board Management Controller including four LEDs which > can be switched on and off. > Please go ahead with my Ack Acked-by: Bryan Wu Lee, will you merge this

Re: [PATCH v2 2/3] usb: Add LED trigger for USB host activity

2014-08-25 Thread Bryan Wu
On Sat, Aug 23, 2014 at 2:52 AM, Michal Sojka wrote: > Hi Bryan, > > thanks for the review. See some comments below. > > On Sat, Aug 23 2014, Bryan Wu wrote: >> On Fri, Aug 22, 2014 at 5:08 PM, Michal Sojka wrote: >>> With this patch, USB host activity can

Re: [PATCH v4 3/4] drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver

2014-08-25 Thread Bryan Wu
On Wed, Aug 13, 2014 at 1:40 AM, Andreas Werner wrote: > Added driver to support the 14F021P00 BMC LEDs. > The BMC is a Board Management Controller including four LEDs which > can be switched on and off. > > Signed-off-by: Andreas Werner > --- > drivers/leds/Kconfig | 6 ++ > drivers/

Re: [PATCH v2 2/3] usb: Add LED trigger for USB host activity

2014-08-22 Thread Bryan Wu
On Fri, Aug 22, 2014 at 5:08 PM, Michal Sojka wrote: > With this patch, USB host activity can be signaled by blinking a LED. > > This should work with all host controllers. Tested only with musb. > > Signed-off-by: Michal Sojka > --- > drivers/usb/core/Kconfig | 9 + > drivers/usb/core

Re: [PATCH v2 0/3] LED triggers for USB host and device

2014-08-22 Thread Bryan Wu
On Fri, Aug 22, 2014 at 5:08 PM, Michal Sojka wrote: > This adds LED triggers for USB host and device. > > Changes from v1: > - Moved from drivers/leds/ to drivers/usb/ > - Improved Kconfig help > - Linked with other modules rather than being standalone modules > > Michal Sojka (3): > usb: Add m

  1   2   3   4   5   6   7   8   >