On 26/06/2025 12:17, Vladimir Zapolskiy wrote:
What's about MSM8953 then?
Should be fixed up to match 8916. We don't have an upstream user and we,
I, did the wrong thing.
Please see commit c830aff08d51 ("media: dt-bindings: Add qcom,msm8953-
camss").
x1e has a particular order if a new de
On 13/06/2025 10:33, Vincent Knecht via B4 Relay wrote:
From: Vincent Knecht
Add bindings for qcom,msm8939-camss in order to support the camera
subsystem for MSM8939.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Vincent Knecht
---
.../bindings/media/qcom,msm8939-camss.yaml | 254
On 26/06/2025 11:28, Krzysztof Kozlowski wrote:
On 26/06/2025 12:19, Bryan O'Donoghue wrote:
On 26/06/2025 11:00, Krzysztof Kozlowski wrote:
+ reg-names:
+items:
+ - const: csi_clk_mux
No, I already provided arguments in two lengthy discussions - this is
not sorted by name.
uthor: Bryan O'Donoghue
Date: Fri Mar 14 13:14:00 2025 +
dt-bindings: media: Add qcom,x1e80100-camss
commit c35ad8e3c59714e9cef96036edad1529e70d1a7a
Author: Depeng Shao
Date: Mon Jan 13 10:01:29 2025 +0530
dt-bindings: media: camss: Add qcom,sm8550-camss bindi
,
+ ;
+
+interrupt-names = "csid0",
+ "csid1",
+ "csid2",
+ "csiphy0",
+ "csiphy1",
+ "ispif",
+ "vfe0";
+
+iommus = <&apps_iommu 3>;
+
+power-domains = <&gcc VFE_GDSC>;
+
+vdda-supply = <®_1v2>;
+
+ports {
+#address-cells = <1>;
+#size-cells = <0>;
+
+port@1 {
+reg = <1>;
+
+csiphy1_ep: endpoint {
+data-lanes = <0 2>;
+remote-endpoint = <&sensor_ep>;
+};
+};
+};
+};
Reviewed-by: Bryan O'Donoghue
On 13/06/2025 09:28, Vincent Knecht wrote:
Le vendredi 13 juin 2025 à 09:06 +0100, Bryan O'Donoghue a écrit :
On 07/06/2025 22:43, Vincent Knecht wrote:
Le vendredi 06 juin 2025 à 13:59 +0300, Vladimir Zapolskiy a écrit :
Hello Vincent.
On 6/2/25 20:27, Vincent Knecht via B4 Relay
: Bryan O'Donoghue
Signed-off-by: Vincent Knecht
There was a preceding and partially reviewed changeset published on
linux-media [1] before v1 of the MSM8939 platform support in CAMSS,
due to a merge conflict this platform changeset should be rebased IMHO.
[1]
https://lore.kernel.or
On 30/05/2025 12:49, Bryan O'Donoghue wrote:
On 30/05/2025 10:00, Vincent Knecht via B4 Relay wrote:
+ camss->res->version == CAMSS_8x39 ||
This is not correct - it should be 893x since 8939 and 8936 are ~ the
same SoC - probably 36 is just a binned version of 39.
Anyw
On 30/05/2025 10:00, Vincent Knecht via B4 Relay wrote:
> + camss->res->version == CAMSS_8x39 ||
This is not correct - it should be 893x since 8939 and 8936 are ~ the
same SoC - probably 36 is just a binned version of 39.
Anyway the x is the least significant digit.
Please fix
---
bod
s/camss-vfe.h
> b/drivers/media/platform/qcom/camss/camss-vfe.h
> index
> a23f666be7531e0366c73faea44ed245e7a8e30f..614e932c33da78e02e0800ce6534af7b14822f83
> 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe.h
> +++ b/drivers/media/platform/qcom/camss/camss-vfe.h
> @@ -136,6 +136,8 @@ struct vfe_subdev_resources {
> u8 line_num;
> bool has_pd;
> char *pd_name;
> + bool has_vbif;
> + char *vbif_name;
> const struct vfe_hw_ops *hw_ops;
> const struct camss_formats *formats_rdi;
> const struct camss_formats *formats_pix;
> @@ -145,6 +147,7 @@ struct vfe_device {
> struct camss *camss;
> u8 id;
> void __iomem *base;
> + void __iomem *vbif_base;
> u32 irq;
> char irq_name[30];
> struct camss_clock *clock;
>
> --
> 2.49.0
>
>
>Reviewed-by: Bryan O'Donoghue
On 26/05/2025 17:23, Vincent Knecht wrote:
Do you mean to just rename to vfe_vbif_write_reg()
Yep, its more natural language.
---
bod
On 26/05/2025 17:20, Vincent Knecht wrote:
You have both
if (vfe->res->has_vbif) {
and the above switch, there's no point in checking this twice in two
different ways.
Choose one, suggest has_vbif is enough.
I think the switch is still needed, so that distinct settings
can be applied for diff
On 25/05/2025 20:25, Vincent Knecht via B4 Relay wrote:
From: Vincent Knecht
Some devices need writing values to VFE VBIF registers.
Add helper functions to do this.
Signed-off-by: Vincent Knecht
---
drivers/media/platform/qcom/camss/Makefile | 1 +
drivers/media/platform/qcom/cam
On 25/05/2025 20:25, Vincent Knecht via B4 Relay wrote:
+void vfe_vbif_reg_write(struct vfe_device *vfe, u32 reg, u32 val);
write_reg() / read_reg()
---
bod
On 25/05/2025 20:25, Vincent Knecht via B4 Relay wrote:
From: Vincent Knecht
The camera subsystem for the MSM8939 is the same as MSM8916 except with
3 CSID instead of 2, and some higher clock rates.
As a quirk, this SoC needs writing values to 2 VFE VBIF registers
(see downstream msm8939-camer
On 20/05/2025 20:53, Dmitry Baryshkov wrote:
<0x01b0ac00 0x0 0x200 0x0>
No.
Ah you're right I see we are only doing this for new SoCs.
---
bod
On 20/05/2025 19:39, Vincent Knecht via B4 Relay wrote:
From: Vincent Knecht
Add the camera subsystem and CCI used to interface with cameras on the
Snapdragon 615.
Signed-off-by: Vincent Knecht
---
arch/arm64/boot/dts/qcom/msm8939-pm8916.dtsi | 4 +
arch/arm64/boot/dts/qcom/msm8939.dtsi
On 20/05/2025 19:39, Vincent Knecht via B4 Relay wrote:
From: Vincent Knecht
Add bindings for qcom,msm8939-camss in order to support the camera
subsystem for MSM8939.
Signed-off-by: Vincent Knecht
---
.../bindings/media/qcom,msm8939-camss.yaml | 269 +
1 file ch
On 20/05/2025 19:39, Vincent Knecht via B4 Relay wrote:
+static const struct camss_subdev_resources csiphy_res_8x39[] = {
+ /* CSIPHY0 */
+ {
+ .regulators = {},
Regulators should be declared with the PHY not the CSID.
---
bod
On 17/03/2025 07:45, Luca Weiss wrote:
On Wed Feb 26, 2025 at 3:47 PM CET, Bryan O'Donoghue wrote:
On 26/02/2025 14:13, Luca Weiss wrote:
Hi all,
On Mon Dec 9, 2024 at 1:01 PM CET, Luca Weiss wrote:
Since the hardware blocks on the SoCs generally support both D-PHY and
C-PHY standard
On 26/02/2025 14:13, Luca Weiss wrote:
Hi all,
On Mon Dec 9, 2024 at 1:01 PM CET, Luca Weiss wrote:
Since the hardware blocks on the SoCs generally support both D-PHY and
C-PHY standards for camera, but the camss driver currently is only
supporting D-PHY, do some preparations in order to add C-
On 13/12/2024 11:54, Vladimir Zapolskiy wrote:
New additions should include this bus-type number as we will need it
when we add CPHY support and the subsequently move to the PHY API for
CAMSS PHYs.
This particular reason is invalid IMO, since dtb changes are not relied on
drivers and shall be
On 13/12/2024 11:24, Luca Weiss wrote:
On Fri Dec 13, 2024 at 11:50 AM CET, Vladimir Zapolskiy wrote:
On 12/13/24 11:34, Krzysztof Kozlowski wrote:
On Mon, Dec 09, 2024 at 01:01:05PM +0100, Luca Weiss wrote:
The CSIPHY of Qualcomm SoCs support both D-PHY and C-PHY standards for
CSI-2, but not
&vep.bus.mipi_csi2;
Reviewed-by: Bryan O'Donoghue
with newer SoCs.
Do note, that currently the Linux driver only supports D-PHY.
Signed-off-by: Luca Weiss
Reviewed-by: Bryan O'Donoghue
On 13/04/2024 18:03, Adam Skladowski wrote:
This patch series provide support for display subsystem, gpu
and also adds wireless connectivity subsystem support.
Changes since v2
1. Disabled mdss_dsi nodes by default
2. Changed reg size of mdss_dsi0 to be equal on both
3. Added op
On 01/04/2024 18:21, Adam Skladowski wrote:
Add node describing wireless connectivity subsystem.
Signed-off-by: Adam Skladowski
---
arch/arm64/boot/dts/qcom/msm8976.dtsi | 104 ++
1 file changed, 104 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8976.dtsi
b
remote-endpoint = <&pm7250b_role_switch_in>;
};
&usb_1_hsphy {
@@ -740,10 +790,15 @@ &usb_1_hsphy {
&usb_1_qmpphy {
vdda-phy-supply = <&vreg_l22a>;
vdda-pll-supply = <&vreg_l16a>;
+ orientation-switch;
status = "okay";
};
+&usb_1_qmpphy_out {
+ remote-endpoint = <&pm7250b_typec_mux_in>;
+};
+
&wifi {
vdd-0.8-cx-mx-supply = <&vreg_l4a>;
vdd-1.8-xo-supply = <&vreg_l7a>;
This looks consistent with 8250
Reviewed-by: Bryan O'Donoghue
swap";
+ vdd-vbus-supply = <&pm7250b_vbus>;
+ };
+
pm7250b_temp: temp-alarm@2400 {
compatible = "qcom,spmi-temp-alarm";
reg = <0x2400>;
Reviewed-by: Bryan O'Donoghue
ot;;
+ reg = <0x1100>;
+ };
+
pm7250b_temp: temp-alarm@2400 {
compatible = "qcom,spmi-temp-alarm";
reg = <0x2400>;
Reviewed-by: Bryan O'Donoghue
- qcom,pmi632-vbus-reg
- const: qcom,pm8150b-vbus-reg
Reviewed-by: Bryan O'Donoghue
On 28/12/2023 11:41, Ulf Hansson wrote:
Let's avoid some of the boilerplate code to manage the vcodec PM domains,
by converting into using dev_pm_domain_attach|detach_list().
Cc: Mauro Carvalho Chehab
Cc: Stanimir Varbanov
Cc: Vikash Garodia
Cc: "Bryan O'Donoghue"
Cc:
..946365f15a59 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
lgtm
Reviewed-by: Bryan O'Donoghue
On 29/09/2023 16:25, Konrad Dybcio wrote:
Not actually a required clock for the clock controller.
I suspect the same is true for dispcc and videocc though it would also mean the respective drivers
would need to switch on <&gcc DISPx_CAMERA_AHB_CLK> or <&gcc GCC_VIDEO_AHB_CLK>
prior to accessin
On 29/09/2023 15:18, Konrad Dybcio wrote:
On 29.09.2023 16:15, Bryan O'Donoghue wrote:
On 29/09/2023 14:35, Konrad Dybcio wrote:
On 9/29/23 10:01, Luca Weiss wrote:
Add the CCI busses found on sc7280 and their pinctrl states.
Signed-off-by: Luca Weiss
---
arch/arm64/boot/dts
:
+ - qcom,sc7280-cci
- qcom,sdm845-cci
- qcom,sm6350-cci
- qcom,sm8250-cci
Reviewed-by: Bryan O'Donoghue
:
+ - qcom,sc7280-cci
- qcom,sdm845-cci
- qcom,sm6350-cci
- qcom,sm8250-cci
Reviewed-by: Bryan O'Donoghue
<&clock_camcc CAM_CC_CCI_CLK_SRC>;
clock-names = "camnoc_axi",
"soc_ahb",
"slow_ahb_src",
- "cpas_ahb",
"cci",
"cci_src";
I think the list is good tbh
Reviewed-by: Bryan O'Donoghue
};
+
+&venus {
+ firmware-name = "qcom/qcm6490/fairphone5/venus.mbn";
+ status = "okay";
+};
Reviewed-by: Bryan O'Donoghue
};
- video-firmware {
- iommus = <&apps_smmu 0x21a2 0x0>;
- };
-
venus_opp_table: opp-table {
compatible = "operating-points-v2";
Reviewed-by: Bryan O'Donoghue
,
+ .cp_nonpixel_size = 0x2480,
.fwname = "qcom/vpu-2.0/venus.mbn",
};
Reviewed-by: Bryan O'Donoghue
On 16/09/2023 14:41, Lukas Walter wrote:
+ +&wcnss_iris { + compatible = "qcom,wcn3620"; +}; +
Are you sure this is 3620, have you tried wcn3660 and/or wcn3680 ?
---
bod
On 18/03/2021 14:50, Bjorn Andersson wrote:
On Mon 15 Mar 07:01 CDT 2021, Bryan O'Donoghue wrote:
On 12/03/2021 00:33, Bjorn Andersson wrote:
Enable the modem and WiFi subsystems and specify msm8916 specific
firmware path for these and the WCNSS control service.
Signed-off-by:
On 12/03/2021 00:33, Bjorn Andersson wrote:
Enable the modem and WiFi subsystems and specify msm8916 specific
firmware path for these and the WCNSS control service.
Signed-off-by: Bjorn Andersson
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 12
arch/arm64/boot/dts/qcom/msm891
t device *dev;
struct list_headvif_list;
+ const char *nv_file;
const struct firmware *nv;
u8 fw_revision;
Tested-by: Bryan O'Donoghue
t; 0) {
- dev_err(dev, "Failed to load nv file %s: %d\n",
- NVBIN_FILE, ret);
+ dev_err(dev, "Failed to load nv file %s: %d\n", nvbin, ret);
goto free_req;
}
Tested-by: Bryan O'Donoghue
On 12/03/2021 00:33, Bjorn Andersson wrote:
firmware-name = "qcom/msm8916/WCNSS_qcom_wlan_nv.bin";
On the Linaro debian build I have to do this
+ firmware-name = "wlan/prima/WCNSS_qcom_wlan_nv.bin";
---
bod
d, 39 insertions(+), 19 deletions(-)
Tested-by: Bryan O'Donoghue
Enable the building of the sm8250 video clock controller by default.
Signed-off-by: Bryan O'Donoghue
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index d612f633b771..292f1edd78e6 100644
We already switch on the sdm845 display and video clock controllers. The
sm8250 display clock controller is similarly switched on by default.
Lets switch on the sm8250 videocc too.
Bryan O'Donoghue (1):
arm64: defconfig: Enable SM8250 video clock controller
arch/arm64/configs/defconfi
kernel build robot fired this email at me about an hour ago
https://lkml.org/lkml/2020/11/13/414
The build robot has flagged the super-speed PHY driver but both Kconfig
entries have the same error. Fix those now.
verified with "make menuconfig ARCH=s390"
Bryan O'Donoghue (2):
This Kconfig entry should declare a dependency on OF
Fixes: 6076967a500c ("phy: qualcomm: usb: Add SuperSpeed PHY driver")
Reported-by: kernel test robot
Link: https://lkml.org/lkml/2020/11/13/414
Signed-off-by: Bryan O'Donoghue
---
drivers/phy/qualcomm/Kconfig | 2 +-
1
This Kconfig entry should declare a dependency on OF
Fixes: 67b27dbeac4d ("phy: qualcomm: Add Synopsys 28nm Hi-Speed USB PHY driver")
Signed-off-by: Bryan O'Donoghue
---
drivers/phy/qualcomm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/q
On 31/05/2020 18:46, Konrad Dybcio wrote:
+static struct clk_fixed_factor xo = {
+ .mult = 1,
+ .div = 1,
+ .hw.init = &(struct clk_init_data)
+ {
+ .name = "xo",
+ .parent_names = (const char *[]) { "xo_board" },
+ .num_parents =
On 17/05/2020 14:13, Bryan O'Donoghue wrote:
This patch adds support for the MSM8939 GCC. The MSM8939 is based on the
MSM8916. MSM8939 is compatible in several ways with MSM8916 but, has
additional functional blocks added which require additional PLL sources. In
some cases functional blocks
...@vger.kernel.org
Signed-off-by: Bryan O'Donoghue
---
Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.txt | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.txt
b/Documentation/devicetree/bindings/phy/qcom,usb-hs-phy.txt
t;.
Cc: Andy Gross
Cc: Bjorn Andersson
Cc: Kishon Vijay Abraham I
Cc: Vinod Koul
Cc: Philipp Zabel
Cc: linux-arm-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Stephen Boyd
Signed-off-by: Bryan O'Donoghue
---
drivers/phy/qualcomm/phy-qcom-usb-hs.c | 36 ++
th of the
PHY.
I've opted to unset the bits on PHY poweroff though in downstream the bits
are only ever switched on if the flag is present, downstream never switches
the bits off again. I think though, setting the bits off on PHY power-off
is the right thing to do, so I've done it.
Brya
On 18/05/2020 17:14, Bryan O'Donoghue wrote:
Right now we don't report to user-space a role switch when doing a
usb_role_switch_set_role() despite having registered the uevent callbacks.
This patch switches on the notifications allowing user-space to see
role-switch change notific
drc.0-role-switch
SEQNUM=2432
Cc: Heikki Krogerus
Cc: Greg Kroah-Hartman
Cc: Chunfeng Yun
Cc: Suzuki K Poulose
Cc: Alexandre Belloni
Cc: Wen Yang
Cc: chenqiwu
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Bryan O'Donoghue
Link:
https://lore.kernel.org/r/20200508162937.2566818-1-br
ng MSM8939 differes from MSM8916 in two key ways.
- New and higher clock frequencies for existing IP blocks.
- New PLLs to drive those higher frequencies
Bryan O'Donoghue (2):
clk: qcom: Add DT bindings for MSM8939 GCC
clk: qcom: gcc-msm8939: Add MSM8939 Generic Clock Controller
...
Signed-off-by: Shawn Guo
Tested-by: Vincent Knecht
Signed-off-by: Bryan O'Donoghue
---
drivers/clk/qcom/Kconfig |8 +
drivers/clk/qcom/Makefile |1 +
drivers/clk/qcom/gcc-msm8939.c | 3989
3 files changed, 3998 insertions(+)
create
-by: Vincent Knecht
Signed-off-by: Bryan O'Donoghue
---
.../devicetree/bindings/clock/qcom,gcc.yaml | 3 +
include/dt-bindings/clock/qcom,gcc-msm8939.h | 206 ++
include/dt-bindings/reset/qcom,gcc-msm8939.h | 110 ++
3 files changed, 319 insertions(+)
create
On 14/05/2020 22:31, Stephen Boyd wrote:
Quoting Bryan O'Donoghue (2020-05-12 04:50:23)
This patch adds support for the MSM8939 GCC. The MSM8939 is based on the
MSM8916. MSM8939 is compatible in several ways with MSM8916 but, has
additional functional blocks added which require additiona
Tested-by: Vincent Knecht
Signed-off-by: Bryan O'Donoghue
---
drivers/clk/qcom/Kconfig |8 +
drivers/clk/qcom/Makefile |1 +
drivers/clk/qcom/gcc-msm8939.c | 3999
3 files changed, 4008 insertions(+)
create mode 100644 drivers/clk/qco
-by: Vincent Knecht
Signed-off-by: Bryan O'Donoghue
---
.../devicetree/bindings/clock/qcom,gcc.yaml | 3 +
include/dt-bindings/clock/qcom,gcc-msm8939.h | 206 ++
include/dt-bindings/reset/qcom,gcc-msm8939.h | 110 ++
3 files changed, 319 insertions(+)
create
ere:
https://github.com/bryanodonoghue/linux/pull/new/msm8939-clk-next-reference-log
Generally speaking MSM8939 differes from MSM8916 in two key ways.
- New and higher clock frequencies for existing IP blocks.
- New PLLs to drive those higher frequencies
Bryan O'Donoghue (2):
clk: qcom: Add
linux-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Bryan O'Donoghue
---
drivers/usb/typec/tps6598x.c | 57 +++-
1 file changed, 50 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/typec/tps6598x.c b/drivers/usb/typec/tps6598x.c
index de
On 09/05/2020 04:24, Wen Yang wrote:
在 2020/5/9 上午12:29, Bryan O'Donoghue 写道:
Right now we don't report to user-space a role switch when doing a
usb_role_switch_set_role() despite having registered the uevent
callbacks.
This patch switches on the notifications allowing user-sp
drc.0-role-switch
SEQNUM=2432
Cc: Heikki Krogerus
Cc: Greg Kroah-Hartman
Cc: Chunfeng Yun
Cc: Suzuki K Poulose
Cc: Alexandre Belloni
Cc: Wen Yang
Cc: chenqiwu
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Bryan O'Donoghue
---
drivers/usb/roles/class.c | 4 +++-
1 file changed, 3
On 08/05/2020 15:22, Angus Ainslie wrote:
Hi,
On 2020-05-08 07:01, Heikki Krogerus wrote:
Hi,
On Thu, May 07, 2020 at 10:47:31PM +0100, Bryan O'Donoghue wrote:
V2:
- Put myself down as sole schema maintainer as suggested - Andy
- Fixed whitespace typo - Andy
- Removed ifdef and of_matc
linux-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Bryan O'Donoghue
---
drivers/usb/typec/tps6598x.c | 56 +++-
1 file changed, 49 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/typec/tps6598x.c b/drivers/usb/typec/tps6598x.c
index de
t with
the reference hardware.
As-is this code will do role-swappping nicely for me, and I think should be
safe on existing ACPI systems.
Bryan O'Donoghue (1):
usb: typec: tps6598x: Add USB role switching logic
drivers/usb/typec/tps6598x.c | 56 +++-
1 f
Adds a MODULE_DEVICE_TABLE() to allow probing of this driver from a DTS
setting.
Cc: Heikki Krogerus
Cc: Greg Kroah-Hartman
Cc: Nikolaus Voss
Cc: Andy Shevchenko
Cc: Gustavo A. R. Silva
Cc: Kees Cook
Cc: linux-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Bryan
= "ti,tps6598x"
and probe that way, however I think it is worthwhile adding a specific OF
way of doing it and having an accompanying yaml as an example.
Bryan O'Donoghue (2):
dt-bindings: usb: Add TI tps6598x device tree binding documentation
usb: typec: tps6598x: Add OF probe bind
Add device tree binding documentation for the Texas Instruments tps6598x
Type-C chip driver.
Cc: Rob Herring
Cc: Heikki Krogerus
Cc: Greg Kroah-Hartman
Cc: linux-...@vger.kernel.org
Cc: devicet...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Bryan O'Don
On 07/05/2020 16:57, Bryan O'Donoghue wrote:
On 23/04/2020 11:34, Bryan O'Donoghue wrote:
V3:
This update removes the old clock name arrays which I forgot to prune in
the previous V2.
git diff bod/clk-next+msm8939 bod/clk-next+msm8939-v2.1
I should have mentioned.
If you want to
On 23/04/2020 11:34, Bryan O'Donoghue wrote:
V3:
This update removes the old clock name arrays which I forgot to prune in
the previous V2.
git diff bod/clk-next+msm8939 bod/clk-next+msm8939-v2.1
I should have mentioned.
If you want to test this you'll need to do the followi
On 07/05/2020 14:41, Andy Shevchenko wrote:
On Thu, May 07, 2020 at 01:45:55PM +0100, Bryan O'Donoghue wrote:
This patch - adds USB role switching to the TI TPS6598x. It has been tested
out with a ChipIdea controller inside a Qualcomm MSM8939.
Right now you need to have configured th
-off-by: Bryan O'Donoghue
---
drivers/usb/typec/tps6598x.c | 56 +++-
1 file changed, 49 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/typec/tps6598x.c b/drivers/usb/typec/tps6598x.c
index 61c6761072c9..b323d82bbd51 100644
--- a/drivers/usb/
roles that I don't need or necessarily support with
the reference hardware.
As-is this code will do role-swappping nicely for me, and I think should be
safe on existing ACPI systems.
Bryan O'Donoghue (1):
usb: typec: tps6598x: Add USB role switching logic
drivers/usb/typec/
Add device tree binding documentation for the Texas Instruments tps6598x
Type-C chip driver.
Cc: Rob Herring
Cc: Heikki Krogerus
Cc: Greg Kroah-Hartman
Cc: linux-...@vger.kernel.org
Cc: devicet...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Bryan O'Don
This simple series adds DT binding yaml and a DT lookup table for the
tps6598x.
Its possible to use i2c id_table to match the 'compatible = "ti,tps6598x"
and probe that way, however I think it is worthwhile adding a specific OF
way of doing it and having an accompanying yaml as an
Adds a MODULE_DEVICE_TABLE() to allow probing of this driver from a DTS
setting.
Cc: Heikki Krogerus
Cc: Greg Kroah-Hartman
Cc: Nikolaus Voss
Cc: Andy Shevchenko
Cc: Gustavo A. R. Silva
Cc: Kees Cook
Cc: linux-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Bryan
happens if
role-switching is true.
Fixes: 05559f10ed79 ("usb: chipidea: add role switch class support")
Cc: Peter Chen
Cc: Greg Kroah-Hartman
Cc: Philipp Zabel
Cc: linux-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Stephen Boyd
Signed-off-by: Bryan O'Donoghue
-
Liam Girdwood
Cc: Mark Brown
Cc: linux-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Stephen Boyd
Signed-off-by: Bryan O'Donoghue
---
drivers/usb/chipidea/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index ae
On 06/12/2018 16:23, Greg Kroah-Hartman wrote:
On Thu, Dec 06, 2018 at 04:14:53PM +, Bryan O'Donoghue wrote:
On 06/12/2018 15:05, Greg Kroah-Hartman wrote:
On Thu, Dec 06, 2018 at 09:43:46AM +0000, Bryan O'Donoghue wrote:
On 05/12/2018 21:00, Sicilia Cristian wrote:
It doesn&#x
On 06/12/2018 15:05, Greg Kroah-Hartman wrote:
On Thu, Dec 06, 2018 at 09:43:46AM +, Bryan O'Donoghue wrote:
On 05/12/2018 21:00, Sicilia Cristian wrote:
It doesn't change the result string
So why do it then ?
Because it is easier to read this way and odds are checkpatch
On 05/12/2018 21:00, Sicilia Cristian wrote:
It doesn't change the result string
So why do it then ?
On 04/12/2018 20:58, Cristian Sicilia wrote:
Some concatenated strings are now spaced.
Signed-off-by: Cristian Sicilia
---
drivers/staging/greybus/loopback.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greybus/loopback.c
b/drivers/staging/greybu
On 23/10/2018 17:20, Rasmus Villemoes wrote:
On 2018-10-11 01:03, Bryan O'Donoghue wrote:
On 05/10/2018 15:28, Rasmus Villemoes wrote:
Signed-off-by: Rasmus Villemoes
---
I have no idea if the performance matters (it probably doesn't). Feel
free to ignore this and the follow
On 05/10/2018 15:28, Rasmus Villemoes wrote:
Signed-off-by: Rasmus Villemoes
---
I have no idea if the performance matters (it probably doesn't). Feel
free to ignore this and the followup cleanup.
What's the problem you're fixing here ?
Is it tested ?
On 05/10/2018 15:28, Rasmus Villemoes wrote:
Since lbid isn't mentioned anywhere else in greybus/, it's hard to
figure out how it was meant to be used. It does seem like entirely
dead (write-only) code.
yep, dead code
Reviewed-by: Bryan O'Donoghue
On 30/03/18 23:59, Trent Piepho wrote:
However, I think that even if the driver fails to probe if there is a
timeout at probe time, it's still possible to hang later if there are
not limits to the hardware polling loops, such as the ones I added.
I agree with your patch in principle for this th
On 29/03/18 01:12, Trent Piepho wrote:
I sent a patch a couple weeks ago that addressed a similar issue, see
https://patchwork.ozlabs.org/patch/887090/
Does this also fix the problem you see?
It breaks the endless loop that happens later on in the RTC read path.
This patch though is about fi
t get into this loop mess later
on.
Fixes: 179a502f8c46 ("rtc: snvs: add Freescale rtc-snvs driver")
Signed-off-by: Bryan O'Donoghue
Cc: a.zu...@towertech.it
Cc: alexandre.bell...@free-electrons.com
Cc: Pan Bian
Cc: Guy Shapiro
Cc: Stefan Agner
Cc: Frank Li
Cc: Shawn Guo
t get into this loop mess later
on.
Fixes: 179a502f8c46 ("rtc: snvs: add Freescale rtc-snvs driver")
Signed-off-by: Bryan O'Donoghue
Cc: a.zu...@towertech.it
Cc: alexandre.bell...@free-electrons.com
Cc: linux-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: # v3.16+
---
On 01/02/18 12:16, Horia Geantă wrote:
If the loop cannot exit based on value of "ret" != -EAGAIN, then it means
caam_probe() will eventually fail due to ret == -EAGAIN:
if (ret) {
dev_err(dev, "failed to instantiate RNG");
goto caam_remove;
}
For
ag]
Fixes: 67c2315def06 ("crypto: caam - add Queue Interface (QI) backend
support")
Tested-by: Ryan Harkin
Signed-off-by: Rui Miguel Silva
Cc: "Horia Geantă"
Cc: Aymen Sghaier
Cc: Fabio Estevam
Cc: Peng Fan
Cc: "David S. Miller"
Cc: Lukas Auer
Cc: # 4.12+
Reviewe
Sghaier
Cc: Fabio Estevam
Cc: Peng Fan
Cc: "David S. Miller"
Cc: Lukas Auer
Cc: # 4.12+
Signed-off-by: Bryan O'Donoghue
---
drivers/crypto/caam/ctrl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
index 98986d3..0a
1 - 100 of 572 matches
Mail list logo
