Re: [PATCH] drm/msm/mdp5: Fix wait-for-commit for cmd panels

2021-01-31 Thread Brian Masney
Rob Clark > Fixes: 2d99ced787e3d ("drm/msm: async commit support") Nice job tracking down this fix! Reviewed-by: Brian Masney Tested-by: Brian Masney

Re: [PATCH] soc: qcom: ocmem: don't return NULL in of_get_ocmem

2021-01-31 Thread Brian Masney
> leading to a NULL pointer dereference. > > Fixes: 88c1e9404f1d ("soc: qcom: add OCMEM driver") > Signed-off-by: Luca Weiss Reviewed-by: Brian Masney

Re: [PATCH 1/4] ARM: dts: qcom: msm8974: add gpu support

2021-01-24 Thread Brian Masney
On Sun, Jan 24, 2021 at 03:56:06PM +0100, Konrad Dybcio wrote: > Hi, > > > > + gpu_opp_table: opp_table { > > + status = "disabled"; > > > Is there a good reason to disable this? > > > > + opp-8 { > > + opp-hz = /

Re: [PATCH 1/4] ARM: dts: qcom: msm8974: add gpu support

2020-12-30 Thread Brian Masney
On Wed, Dec 30, 2020 at 05:51:29PM +0200, Iskren Chernev wrote: > From: Brian Masney > > Add support for the a3xx GPU > > Signed-off-by: Brian Masney Reviewed-by: Brian Masney

Re: [PATCH 1/2] drm/msm: Call msm_init_vram before binding the gpu

2020-12-30 Thread Brian Masney
On Wed, Dec 30, 2020 at 05:29:42PM +0200, Iskren Chernev wrote: > From: Craig Tatlor > > vram.size is needed when binding a gpu without an iommu and is defined > in msm_init_vram(), so run that before binding it. > > Signed-off-by: Craig Tatlor For the series: Reviewe

[PATCH v2] x86/xen: don't unbind uninitialized lock_kicker_irq

2020-11-06 Thread Brian Masney
mportantly xen_init_lock_cpu(), is not called, so the lock_kicker_irq is not initialized for the secondary CPUs. Let's fix this by exiting early in xen_uninit_lock_cpu() if the irq is not set to avoid the warning from above for each secondary CPU. Signed-off-by: Brian Masney --- Changes sin

Re: [PATCH] interconnect: qcom: msm8974: Prevent integer overflow in rate

2020-11-06 Thread Brian Masney
pport") > Signed-off-by: Georgi Djakov Reviewed-by: Brian Masney

Re: [PATCH] x86/xen: fix warning when running with nosmt mitigations

2020-11-05 Thread Brian Masney
On Thu, Nov 05, 2020 at 07:35:29PM -0500, Brian Masney wrote: > diff --git a/arch/x86/xen/spinlock.c b/arch/x86/xen/spinlock.c > index 799f4eba0a62..4a052459a08e 100644 > --- a/arch/x86/xen/spinlock.c > +++ b/arch/x86/xen/spinlock.c > @@ -93,9 +93,24 @@ void xen_init_lock_cpu(int c

[PATCH] x86/xen: fix warning when running with nosmt mitigations

2020-11-05 Thread Brian Masney
mportantly xen_init_lock_cpu(), is not called, so the lock_kicker_irq is not initialized for the secondary CPUs. Let's fix this by exiting early in xen_uninit_lock_cpu() if the irq is not set to avoid the warning from above for each secondary CPU. Signed-off-by: Brian Masney --- arch/x86/xen/

Re: [PATCH 0/7] ARM: dts: qcom: msm8974: klte: Enable some hardware

2020-07-01 Thread Brian Masney
Hi Iskren, On Tue, Jun 30, 2020 at 05:09:05PM +0300, Iskren Chernev wrote: > Enable support for various hw found on the Samsung Galaxy S5: > - touchkey (the two buttons around the home button) > - touchscreen > - notification led > - wifi > - external SD card > > Please note that for working wifi

[PATCH v2 RESEND 0/2] Input: remove msm-vibrator driver and bindings

2020-05-12 Thread Brian Masney
to either post a patch to support setting the clock duty cycle or someone to post information about the m,n,d registers for the clocks. Once that's done, no other changes will be needed in the input subsystem. Brian Masney (2): dt-bindings: Input: remove msm-vibrator Input: remove msm-

[PATCH v2 RESEND 2/2] Input: remove msm-vibrator driver

2020-05-12 Thread Brian Masney
The address referenced by this driver is within the Qualcomm Clock namespace so let's drop the msm-vibrator bindings so that a more generic solution can be used instead. No one is currently using driver so this won't affect any users. Signed-off-by: Brian Masney --- drivers/input/mi

[PATCH v2 RESEND 1/2] dt-bindings: Input: remove msm-vibrator

2020-05-12 Thread Brian Masney
The address referenced in this binding is within the Qualcomm Clock namespace so let's drop the msm-vibrator bindings so that a more generic solution can be used instead. No one is currently using these bindings so this won't affect any users. Signed-off-by: Brian Masney Acked-by: R

Re: [PATCH 5/5] ARM: dts: qcom: msm8974: add interconnect nodes

2019-10-23 Thread Brian Masney
On Wed, Oct 23, 2019 at 02:50:19PM +0300, Georgi Djakov wrote: > On 13.10.19 г. 11:08 ч., Brian Masney wrote: > > Add interconnect nodes that's needed to support bus scaling. > > > > Signed-off-by: Brian Masney > > --- > > ar

[PATCH 5/5] ARM: dts: qcom: msm8974: add interconnect nodes

2019-10-13 Thread Brian Masney
Add interconnect nodes that's needed to support bus scaling. Signed-off-by: Brian Masney --- arch/arm/boot/dts/qcom-msm8974.dtsi | 60 + 1 file changed, 60 insertions(+) diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi

[PATCH 1/5] ARM: qcom_defconfig: add ocmem support

2019-10-13 Thread Brian Masney
Add ocmem driver that's needed to support the GPU on a3xx and a4xx based systems. Signed-off-by: Brian Masney --- arch/arm/configs/qcom_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig index 02f1e7b

[PATCH 2/5] ARM: qcom_defconfig: add msm8974 interconnect support

2019-10-13 Thread Brian Masney
Add interconnect support for msm8974-based SoCs in order to support the GPU on this platform. Signed-off-by: Brian Masney --- arch/arm/configs/qcom_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig index

[PATCH 0/5] ARM: qcom: add defconfig items and dts nodes

2019-10-13 Thread Brian Masney
/lkml/20191005114605.5279-1-masn...@onstation.org/ I have some work in progress patches for the HDMI bridge that's found on the Nexus 5 and this series adds the necessary driver to qcom_defconfig. Brian Masney (5): ARM: qcom_defconfig: add ocmem support ARM: qcom_defconfig: add msm8974 interconne

[PATCH 4/5] ARM: dts: qcom: msm8974: add ocmem node

2019-10-13 Thread Brian Masney
Add ocmem node that is needed in order to support the GPU upstream. Signed-off-by: Brian Masney --- arch/arm/boot/dts/qcom-msm8974.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi index

[PATCH 3/5] ARM: qcom_defconfig: add anx78xx HDMI bridge support

2019-10-13 Thread Brian Masney
Add the Analogix anx78xx driver so that the external display over HDMI can be used on Nexus 5 phones. Signed-off-by: Brian Masney --- arch/arm/configs/qcom_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig index

Re: [PATCH v2 2/2] interconnect: qcom: add msm8974 driver

2019-10-12 Thread Brian Masney
On Fri, Oct 11, 2019 at 10:05:06AM -0700, Bjorn Andersson wrote: > On Sat 05 Oct 04:46 PDT 2019, Brian Masney wrote: > > diff --git a/drivers/interconnect/qcom/msm8974.c > > b/drivers/interconnect/qcom/msm8974.c > [..] > > +static void msm8974_icc_rpm_smd_send(struct d

Re: msm8996: sdhci-msm: apq8096-db820c sdhci fails to init - "Timeout waiting for hardware interrupt."

2019-10-10 Thread Brian Masney
Hi Paolo, On Thu, Oct 10, 2019 at 04:32:32PM +0200, Paolo Pisati wrote: > Sdhci consistenlty fails to initialize (and thus work) on my apq8096-db820c. > > The issue is present since v5.0[*] mainline up to latest v5.4-rc2, using > defconfig and: > > CONFIG_SCSI_UFS_QCOM=y > CONFIG_PHY_QCOM_QMP=y

Re: [PATCH v4 2/5] soc: qcom: smd-rpm: Create RPM interconnect proxy child device

2019-10-06 Thread Brian Masney
proxy > child device to represent the bus throughput functionality that is provided > by the RPM. > > Signed-off-by: Georgi Djakov Reviewed-by: Brian Masney Tested-by: Brian Masney # msm8974 I think this patch may have fell through the cracks since I don't see it in linux-n

[PATCH] clk: qcom: mmcc8974: add frequency table for gfx3d

2019-10-05 Thread Brian Masney
From: Jonathan Marek Add frequency table for the gfx3d clock that's needed in order to support the GPU upstream on msm8974-based systems. Signed-off-by: Jonathan Marek Signed-off-by: Brian Masney --- drivers/clk/qcom/mmcc-msm8974.c | 7 +++ 1 file changed, 7 insertions(+) diff --

[PATCH v2 1/2] dt-bindings: interconnect: qcom: add msm8974 bindings

2019-10-05 Thread Brian Masney
Add device tree bindings for the Qualcomm MSM8974 interconnect providers that support setting system bandwidth requirements between various network-on-chip fabrics. Signed-off-by: Brian Masney --- Rob: I included in the next patch at the top a rough diagram showing the relationship between

[PATCH v2 0/2] interconnect: qcom: add msm8974 support

2019-10-05 Thread Brian Masney
t;; clocks = <&rpmcc RPM_SMD_PNOC_CLK>, <&rpmcc RPM_SMD_PNOC_A_CLK>; }; snoc: interconnect@fc46 { reg = <0xfc46 0x4000>; compatible = "qcom,msm8974-snoc"; #interconnect-cells = <1

[PATCH v2 2/2] interconnect: qcom: add msm8974 driver

2019-10-05 Thread Brian Masney
Add driver for the Qualcomm MSM8974 interconnect providers that support setting system bandwidth requirements between various network-on-chip fabrics. Signed-off-by: Brian Masney --- Chages since v1: - Introduce msm8974_icc_rpm_smd_send(). Ignore error if setting the bandwidth for a single

Re: What populates /proc/partitions ?

2019-09-30 Thread Brian Masney
On Mon, Sep 30, 2019 at 03:47:21PM -0700, David F. wrote: > Hi, > > I want to find out why fd0 is being added to /proc/partitions and stop > that for my build. I've searched "/proc/partitions" and "partitions", > not finding anything that matters. It looks like it is done in block/genhd.c with t

Re: [PATCH RFC 2/2] interconnect: qcom: add msm8974 driver

2019-09-28 Thread Brian Masney
On Mon, Sep 02, 2019 at 05:19:25PM -0400, Brian Masney wrote: > Add driver for the Qualcomm MSM8974 interconnect providers that support > setting system bandwidth requirements between various network-on-chip > fabrics. > > I marked this as a PATCH RFC since I'm not able to

Re: [PATCH] qcom: ssbi-gpio: convert to hierarchical IRQ helpers in gpio core

2019-09-17 Thread Brian Masney
ase drop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Brian-Masney/qcom-ssbi-gpio-convert-to-hierarchical-IRQ-helpers-in-gpio-core/20190916-134112 > config: arm-allmodconfig (attached as .config) > compiler: arm-linux-gnueabi-gcc

Re: [PATCH 05/11] drm/bridge: analogix-anx78xx: correct value of TX_P0

2019-09-16 Thread Brian Masney
On Mon, Sep 16, 2019 at 12:02:09PM +0200, Andrzej Hajda wrote: > On 15.08.2019 02:48, Brian Masney wrote: > > When attempting to configure this driver on a Nexus 5 phone (msm8974), > > setting up the dummy i2c bus for TX_P0 would fail due to an -EBUSY > > error. The downstre

[PATCH] qcom: ssbi-gpio: convert to hierarchical IRQ helpers in gpio core

2019-09-14 Thread Brian Masney
Now that the GPIO core has support for hierarchical IRQ chips, convert Qualcomm's ssbi-gpio over to use these new helpers to reduce duplicated code across drivers. Signed-off-by: Brian Masney --- Linus: I've only compile tested this driver. Hopefully you have time to test th

Re: [PATCH] gpio: fix incorrect merge of linux/gpio/driver.h

2019-09-09 Thread Brian Masney
gpio: remove less important #ifdef around declarations") > Fixes: c7663fa2a663 ("gpio: Move gpiochip_lock/unlock_as_irq to > gpio/driver.h") > Signed-off-by: Arnd Bergmann Reviewed-by: Brian Masney

Re: [PATCH RFC 1/2] dt-bindings: interconnect: qcom: add msm8974 bindings

2019-09-04 Thread Brian Masney
On Tue, Sep 03, 2019 at 10:01:03PM -0700, Bjorn Andersson wrote: > On Mon 02 Sep 14:19 PDT 2019, Brian Masney wrote: > > + mmssnoc: interconnect@fc478000 { > > + reg = <0xfc478000 0x4000>; > > + compatible = "qcom,msm8974-mmssnoc&qu

[PATCH RFC 1/2] dt-bindings: interconnect: qcom: add msm8974 bindings

2019-09-02 Thread Brian Masney
Add device tree bindings for the Qualcomm MSM8974 interconnect providers that support setting system bandwidth requirements between various network-on-chip fabrics. Signed-off-by: Brian Masney --- .../bindings/interconnect/qcom,msm8974.yaml | 163 ++ .../dt-bindings

[PATCH RFC 2/2] interconnect: qcom: add msm8974 driver

2019-09-02 Thread Brian Masney
178) [] (__device_attach) from [] (bus_probe_device+0x84/0x8c) [] (bus_probe_device) from [] (deferred_probe_work_func+0x84/0xc4) [] (deferred_probe_work_func) from [] (process_one_work+0x1dc/0x538) [] (process_one_work) from [] (worker_thread+0x44/0x508) [] (worker_thread) from [] (kthread+0x120/0x

[PATCH RFC 0/2] interconnect: qcom: add msm8974 driver

2019-09-02 Thread Brian Masney
ng this working fully and would appreciate any feedback on this series. Brian Masney (2): dt-bindings: interconnect: qcom: add msm8974 bindings interconnect: qcom: add msm8974 driver .../bindings/interconnect/qcom,msm8974.yaml | 163 drivers/interconnect/qcom/Kconfig |

[PATCH] soc: qcom: ocmem: add missing includes

2019-09-01 Thread Brian Masney
function 'ERR_PTR' [-Werror=implicit-function-declaration] return ERR_PTR(-ENODEV); ^~~ >> include/soc/qcom/ocmem.h:45:18: error: 'ENODEV' undeclared (first use in this function) return ERR_PTR(-ENODEV); Add the proper include

[PATCH v7 2/7] dt-bindings: display: msm: gmu: add optional ocmem property

2019-08-23 Thread Brian Masney
Some A3xx and A4xx Adreno GPUs do not have GMEM inside the GPU core and must use the On Chip MEMory (OCMEM) in order to be functional. Add the optional ocmem property to the Adreno Graphics Management Unit bindings. Signed-off-by: Brian Masney --- Changes since v6: - link to gmu-sram in example

[PATCH v7 6/7] drm/msm/gpu: add ocmem init/cleanup functions

2019-08-23 Thread Brian Masney
The files a3xx_gpu.c and a4xx_gpu.c have ifdefs for the OCMEM support that was missing upstream. Add two new functions (adreno_gpu_ocmem_init and adreno_gpu_ocmem_cleanup) that removes some duplicated code. Signed-off-by: Brian Masney --- Changes since v6: - None Changes since v5: - None

[PATCH v7 7/7] ARM: qcom_defconfig: add ocmem support

2019-08-23 Thread Brian Masney
Add ocmem driver that's needed for some a3xx and a4xx based systems. Signed-off-by: Brian Masney --- Changes since v6: - None Changes since v5: - None This patch was introduced in v5. arch/arm/configs/qcom_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/co

[PATCH v7 0/7] qcom: add OCMEM support

2019-08-23 Thread Brian Masney
v6: - link to gmu-sram child node in device tree - add ranges property to ocmem example in adreno GMU example (patch 2) to match bindings in patch 1 See individual patches for changelogs for previous versions. Brian Masney (5): dt-bindings: soc: qcom: add On Chip MEMory (OCMEM) bindings d

[PATCH v7 3/7] firmware: qcom: scm: add OCMEM lock/unlock interface

2019-08-23 Thread Brian Masney
From: Rob Clark Add support for the OCMEM lock/unlock interface that is needed by the On Chip MEMory (OCMEM) that is present on some Snapdragon devices. Signed-off-by: Rob Clark [masn...@onstation.org: ported to latest kernel; minor reformatting.] Signed-off-by: Brian Masney Reviewed-by

[PATCH v7 5/7] soc: qcom: add OCMEM driver

2019-08-23 Thread Brian Masney
ed to zero to match what the hardware expects. The driver can be updated to read the reserved memory regions from device tree once other users of OCMEM are added upstream. Signed-off-by: Brian Masney Co-developed-by: Rob Clark Signed-off-by: Rob Clark Reviewed-by: Bjorn Andersson --- Change

[PATCH v7 1/7] dt-bindings: soc: qcom: add On Chip MEMory (OCMEM) bindings

2019-08-23 Thread Brian Masney
Add device tree bindings for the On Chip Memory (OCMEM) that is present on some Qualcomm Snapdragon SoCs. Signed-off-by: Brian Masney Reviewed-by: Rob Herring --- Changes since v6: - None Changes since v5: - None Changes since v4: - remove qcom from path in $id Changes since v3: - add ranges

[PATCH v7 4/7] firmware: qcom: scm: add support to restore secure config to qcm_scm-32

2019-08-23 Thread Brian Masney
-by: Brian Masney Reviewed-by: Bjorn Andersson --- Changes since v6: - None Changes since v5: - None Changes since v4: - None Changes since v3: - None Changes since v2: - None Changes since v1: - Use existing __qcom_scm_restore_sec_cfg() function stub in qcom_scm-32.c that was unimplemented

Re: [PATCH RFC 06/11] drm/bridge: analogix-anx78xx: add support for avdd33 regulator

2019-08-15 Thread Brian Masney
On Thu, Aug 15, 2019 at 10:22:45AM +0200, Linus Walleij wrote: > On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > > > Add support for the avdd33 regulator to the analogix-anx78xx driver. > > Note that the regulator is currently enabled during driver probe and > > dis

Re: [PATCH 12/15] arm64: dts: msm8974: thermal: Add interrupt support

2019-08-08 Thread Brian Masney
On Fri, Jul 26, 2019 at 03:48:47AM +0530, Amit Kucheria wrote: > Register upper-lower interrupt for the tsens controller. > > Signed-off-by: Amit Kucheria Tested-by: Brian Masney

Re: [PATCH 05/15] arm: dts: msm8974: thermal: Add thermal zones for each sensor

2019-08-08 Thread Brian Masney
On Fri, Jul 26, 2019 at 03:48:40AM +0530, Amit Kucheria wrote: > msm8974 has 11 sensors connected to a single TSENS IP. Define a thermal > zone for each of those sensors to expose the temperature of each zone. > > Signed-off-by: Amit Kucheria Tested-by: Brian Masney # msm8974

Re: [PATCH 0/4] gpio: hierarchical IRQ improvements

2019-08-07 Thread Brian Masney
On Wed, Aug 07, 2019 at 03:41:05PM +0200, Linus Walleij wrote: > On Mon, Jul 8, 2019 at 1:01 PM Brian Masney wrote: > > > This builds on top of Linus Walleij's existing patches that adds > > hierarchical IRQ support to the GPIO core [1] so that Qualcomm's > &

Mainline status update for the Nexus 5 phone (qcom msm8974 SoC)

2019-08-04 Thread Brian Masney
Hi, There's been a fair bit of development effort to get the LG Nexus 5 working with a mainline kernel. Here is a brief summary of what's working upstream as of this week: - Display - X11, Wayland, and text mode work. No GPU yet however out of tree patches are available. I'm slowly working on p

Re: [PATCH v4 1/4] iio: tsl2772: Use devm_add_action_or_reset

2019-08-01 Thread Brian Masney
On Thu, Aug 01, 2019 at 05:33:47AM -0400, Brian Masney wrote: > On Thu, Aug 01, 2019 at 03:35:57PM +0800, Chuhong Yuan wrote: > > Use devm_add_action_or_reset to remove the call to > > tsl2772_disable_regulators_action to simplify the error path. > > > > Signed-off-by:

Re: [PATCH v4 2/4] iio: tsl2772: Use devm_add_action_or_reset for tsl2772_chip_off

2019-08-01 Thread Brian Masney
On Thu, Aug 01, 2019 at 03:36:05PM +0800, Chuhong Yuan wrote: > Use devm_add_action_or_reset to call tsl2772_chip_off > when the device is removed. > This also fixes the issue that the chip is turned off > before the device is unregistered. > > Fixes: 4e24c1719f34 ("staging: iio: tsl2x7x: rename d

Re: [PATCH v4 1/4] iio: tsl2772: Use devm_add_action_or_reset

2019-08-01 Thread Brian Masney
On Thu, Aug 01, 2019 at 03:35:57PM +0800, Chuhong Yuan wrote: > Use devm_add_action_or_reset to remove the call to > tsl2772_disable_regulators_action to simplify the error path. > > Signed-off-by: Chuhong Yuan For the whole series: Reviewed-by: Brian Masney I forgot to mention

Re: [PATCH v3 2/2] iio: tsl2772: Use regulator_bulk_() APIs

2019-07-31 Thread Brian Masney
Hi Chuhong, On Wed, Jul 31, 2019 at 11:04:23AM +0800, Chuhong Yuan wrote: > Use regulator_bulk_() APIs to shrink driver size. > > Signed-off-by: Chuhong Yuan Just a few minor nitpicks below. Overall, this is looking nice. > --- > Changes in v3: > - Split v2 into two patches. > - Add dev_er

Re: [PATCH v3 1/2] iio: tsl2772: Use device-managed API

2019-07-31 Thread Brian Masney
Hi Chuhong, On Wed, Jul 31, 2019 at 11:04:15AM +0800, Chuhong Yuan wrote: > Use devm_() APIs to simplify the code. > > Signed-off-by: Chuhong Yuan There needs to be more of a changelog associated with this patch since this doesn't describe what all is done below. I see the following distinct th

Re: [PATCH] iio: tsl2772: Use device-managed API

2019-07-29 Thread Brian Masney
On Mon, Jul 29, 2019 at 12:08:02PM +0100, Jonathan Cameron wrote: > On Mon, 29 Jul 2019 04:03:07 -0400 > Brian Masney wrote: > > There are devm_regulator_*() variants of the regulator API available > > that you can use. Lots of other APIs in the kernel have devm variants >

Re: [PATCH v2] iio: tsl2772: Use device-managed API

2019-07-29 Thread Brian Masney
Hi Chuhong, On Mon, Jul 29, 2019 at 06:03:39PM +0800, Chuhong Yuan wrote: > Use devm_iio_device_register to simplify > the code. > > Signed-off-by: Chuhong Yuan Thank you for the patch. The patch description doesn't match what all is done below. This should also be broken up into multiple patch

Re: [PATCH 00/15] thermal: qcom: tsens: Add interrupt support

2019-07-29 Thread Brian Masney
On Sat, Jul 27, 2019 at 12:58:54PM +0530, Amit Kucheria wrote: > On Fri, Jul 26, 2019 at 4:59 PM Brian Masney wrote: > > On Fri, Jul 26, 2019 at 04:40:16PM +0530, Amit Kucheria wrote: > > > How well does cpufreq work on 8974? I haven't looked at it yet but > >

Re: [PATCH] iio: tsl2772: Use device-managed API

2019-07-29 Thread Brian Masney
On Mon, Jul 29, 2019 at 11:03:00AM +0800, Chuhong Yuan wrote: > Brian Masney 于2019年7月28日周日 下午4:31写道: > > devm_add_action() could be used in the probe function to schedule the call > > to tsl2772_chip_off(). That would eliminate the need for > >

Re: [PATCH 2/4] gpio: allow customizing hierarchical IRQ chips

2019-07-28 Thread Brian Masney
On Mon, Jul 29, 2019 at 12:49:55AM +0200, Linus Walleij wrote: > On Mon, Jul 8, 2019 at 1:01 PM Brian Masney wrote: > > +static void gpiochip_add_default_irq_domain_ops(struct irq_domain_ops *ops) > > +{ > > + if (!ops->activate) > >

Re: [PATCH] iio: tsl2772: Use device-managed API

2019-07-28 Thread Brian Masney
On Sat, Jul 27, 2019 at 12:57:49PM +0100, Jonathan Cameron wrote: > On Fri, 26 Jul 2019 20:30:58 +0800 > Chuhong Yuan wrote: > > > Use devm_iio_device_register to simplify > > the code. > > > > Signed-off-by: Chuhong Yuan > > Please try to pick up on likely reviewers in your cc list. In this

Re: [PATCH 00/15] thermal: qcom: tsens: Add interrupt support

2019-07-26 Thread Brian Masney
Hi Amit, On Fri, Jul 26, 2019 at 04:40:16PM +0530, Amit Kucheria wrote: > > The device tree nodes appear in sysfs: > > > > / # ls -1 /sys/class/thermal/ > > cooling_device0 > > cooling_device1 > > thermal_zone0 > > thermal_zone1 > > thermal_zone2 > > thermal_zone3 > > thermal_zone4 > > thermal_zon

Re: [PATCH 00/15] thermal: qcom: tsens: Add interrupt support

2019-07-26 Thread Brian Masney
Hi Amit, On Fri, Jul 26, 2019 at 03:48:35AM +0530, Amit Kucheria wrote: > Add interrupt support to TSENS. The first 6 patches are general fixes and > cleanups to the driver before interrupt support is introduced. > > This series has been developed against qcs404 and sdm845 and then tested on > ms

Re: [PATCH] ARM: dts: msm8974-FP2: add reboot-mode node

2019-07-13 Thread Brian Masney
fd"; > + reg = <0xfe805000 0x1000>; > + > + reboot-mode { > + compatible = "syscon-reboot-mode"; > + offset = <0x65c>; > + }; > + }; > }; > > smd { I think this sounds reasonable. Reviewed-by: Brian Masney You should resend this out with git send-email and see what Bjorn says. Brian

[PATCH 3/4] gpio: use handler in gpio_irq_chip instead of handle_bad_irq

2019-07-08 Thread Brian Masney
Use the IRQ handler field that's available in the struct gpio_irq_chip when allocating an IRQ rather than hardcoding the handler to handle_bad_irq(). The kernel reboots without any messages when testing this using spmi-gpio on the Nexus 5. Signed-off-by: Brian Masney --- I didn't ha

[PATCH 2/4] gpio: allow customizing hierarchical IRQ chips

2019-07-08 Thread Brian Masney
archy. Some drivers need to supply their own translate function. These will be initially used by Qualcomm's spmi-gpio and ssbi-gpio. Signed-off-by: Brian Masney --- Note: checkpatch doesn't like that child_irq_domain_ops is not const. dri

[PATCH 0/4] gpio: hierarchical IRQ improvements

2019-07-08 Thread Brian Masney
ny of this code. Just give me some kind of mention in the commit description. [1] https://lore.kernel.org/linux-gpio/20190624132531.6184-1-linus.wall...@linaro.org/ Brian Masney (4): gpio: introduce gpiochip_populate_parent_fwspec_{two,four}cell functions gpio: allow customizing hierarc

[PATCH 4/4] qcom: spmi-gpio: convert to hierarchical IRQ helpers in gpio core

2019-07-08 Thread Brian Masney
Now that the GPIO core has support for hierarchical IRQ chips, convert Qualcomm's spmi-gpio over to use these new helpers to reduce duplicated code across drivers. This change was tested on a LG Nexus 5 (hammerhead) phone. Signed-off-by: Brian Masney --- drivers/pinctrl/qcom/Kc

[PATCH 1/4] gpio: introduce gpiochip_populate_parent_fwspec_{two,four}cell functions

2019-07-08 Thread Brian Masney
Introduce the functions gpiochip_populate_parent_fwspec_{two,four}cell that will be used for hierarchical IRQ support in GPIO drivers. Signed-off-by: Brian Masney --- drivers/gpio/gpiolib.c | 24 include/linux/gpio/driver.h | 30 ++ 2

Re: [PATCH RESEND] ARM: dts: qcom: msm8974-hammerhead: add device tree bindings for vibrator

2019-06-24 Thread Brian Masney
On Tue, Jun 25, 2019 at 12:29:29AM +0200, Linus Walleij wrote: > On Sun, Jun 23, 2019 at 12:53 PM Brian Masney wrote: > > > 2) Do what Linus suggests above. We can use v1 of this series from last > >September (see below for link) that adds this to the pwm subsystem. > &

Re: [PATCH RESEND] ARM: dts: qcom: msm8974-hammerhead: add device tree bindings for vibrator

2019-06-23 Thread Brian Masney
Hi Stephen and Thierry, On Fri, May 31, 2019 at 12:51:38PM +0200, Linus Walleij wrote: > On Wed, May 29, 2019 at 12:12 PM Brian Masney wrote: > > > My first revision of this vibrator driver used the Linux PWM framework > > due to the variable duty cycle: > > So what

Re: [PATCH] ARM: dts: msm8974-FP2: add reboot-mode node

2019-06-21 Thread Brian Masney
On Fri, Jun 21, 2019 at 09:25:17PM +0200, Luca Weiss wrote: > On Freitag, 21. Juni 2019 02:01:22 CEST you wrote: > > I think that it makes sense to put this snippet in qcom-msm8974.dtsi > > with a status of disabled, and then enable it in > > qcom-msm8974-fairphone-fp2.dts like so: > > > > imem@fe

Re: [PATCH] ARM: dts: msm8974-FP2: add reboot-mode node

2019-06-20 Thread Brian Masney
Hi Luca, On Fri, Jun 21, 2019 at 12:58:24AM +0200, Luca Weiss wrote: > This enables userspace to signal the bootloader to go into the > bootloader or recovery mode. > > The magic values can be found in both the downstream kernel and the LK > kernel (bootloader). > > Signed-off-by: Luca Weiss >

[PATCH 1/2] ARM: dts: qcom: msm8974-hammerhead: add touchscreen support

2019-06-02 Thread Brian Masney
From: Jonathan Marek Add support for the Synaptics RMI4 touchscreen that is found on the Nexus 5. Signed-off-by: Jonathan Marek Signed-off-by: Brian Masney --- This is to be applied on top of the display patch series: https://lore.kernel.org/lkml/20190531094619.31704-1-masn...@onstation.org

[PATCH 2/2] ARM: qcom_defconfig: add support for USB networking

2019-06-02 Thread Brian Masney
Add support for USB networking as a module to qcom_defconfig since its a useful feature to have for development purposes. Signed-off-by: Brian Masney --- This is to be applied on top of the display patch series: https://lore.kernel.org/lkml/20190531094619.31704-1-masn...@onstation.org/ arch

Re: [PATCH RESEND] ARM: dts: qcom: msm8974-hammerhead: add device tree bindings for vibrator

2019-05-29 Thread Brian Masney
On Wed, May 29, 2019 at 11:13:15AM +0200, Linus Walleij wrote: > On Mon, May 20, 2019 at 4:21 PM Stephen Boyd wrote: > > > > + vibrator@fd8c3450 { > > > + compatible = "qcom,msm8974-vibrator"; > > > + reg = <0xfd8c3450 0x400>; > > > > This is inside the multimedi

Re: Issue with Broadcom wireless in 5.2rc1 (was Re: [PATCH] mmc: sdhci: queue work after sdhci_defer_done())

2019-05-27 Thread Brian Masney
On Mon, May 27, 2019 at 03:08:07PM +0300, Adrian Hunter wrote: > On 27/05/19 12:37 PM, Brian Masney wrote: > > On Sun, May 26, 2019 at 03:58:19PM -0400, Brian Masney wrote: > >> I attached a patch that shows how I was able to determine what had > >> already claimed t

Re: Issue with Broadcom wireless in 5.2rc1 (was Re: [PATCH] mmc: sdhci: queue work after sdhci_defer_done())

2019-05-27 Thread Brian Masney
On Sun, May 26, 2019 at 03:58:19PM -0400, Brian Masney wrote: > I attached a patch that shows how I was able to determine what had > already claimed the host. I realized this morning that I had a flaw with my test patch that diagnosed what was deadlocked. The mmc_ctx structure was alloca

Re: Issue with Broadcom wireless in 5.2rc1 (was Re: [PATCH] mmc: sdhci: queue work after sdhci_defer_done())

2019-05-26 Thread Brian Masney
On Sun, May 26, 2019 at 08:42:21PM +0200, Arend Van Spriel wrote: > On 5/26/2019 2:21 PM, Brian Masney wrote: > > + Broadcom wireless maintainers > > > > On Fri, May 24, 2019 at 11:49:58AM -0400, Brian Masney wrote: > > > On Fri, May 24, 2019 at 03:17:13PM +0300, A

Issue with Broadcom wireless in 5.2rc1 (was Re: [PATCH] mmc: sdhci: queue work after sdhci_defer_done())

2019-05-26 Thread Brian Masney
+ Broadcom wireless maintainers On Fri, May 24, 2019 at 11:49:58AM -0400, Brian Masney wrote: > On Fri, May 24, 2019 at 03:17:13PM +0300, Adrian Hunter wrote: > > On 24/05/19 2:10 PM, Brian Masney wrote: > > > WiFi stopped working on the LG Nexus 5 phone and the issue was bis

Re: [PATCH] mmc: sdhci: queue work after sdhci_defer_done()

2019-05-24 Thread Brian Masney
On Fri, May 24, 2019 at 03:17:13PM +0300, Adrian Hunter wrote: > On 24/05/19 2:10 PM, Brian Masney wrote: > > WiFi stopped working on the LG Nexus 5 phone and the issue was bisected > > to the commit c07a48c26519 ("mmc: sdhci: Remove finish_tasklet") that > > moved

Re: [PATCH] mmc: sdhci: queue work after sdhci_defer_done()

2019-05-24 Thread Brian Masney
On Fri, May 24, 2019 at 03:17:13PM +0300, Adrian Hunter wrote: > On 24/05/19 2:10 PM, Brian Masney wrote: > > WiFi stopped working on the LG Nexus 5 phone and the issue was bisected > > to the commit c07a48c26519 ("mmc: sdhci: Remove finish_tasklet") that > > moved

[PATCH] mmc: sdhci: queue work after sdhci_defer_done()

2019-05-24 Thread Brian Masney
work when sdhci_defer_done() is true. Change it to queue work to the complete work queue if sdhci_defer_done() is true so that the functionality is equilivent to what was there when the finish_tasklet was present. This corrects the WiFi breakage on the Nexus 5 phone. Signed-off-by: Brian Masney Fixes: c07a48c2

Re: [PATCH RESEND] ARM: dts: qcom: msm8974-hammerhead: add device tree bindings for vibrator

2019-05-22 Thread Brian Masney
Hi Stephen, On Mon, May 20, 2019 at 07:21:49AM -0700, Stephen Boyd wrote: > Quoting Brian Masney (2019-05-16 01:50:18) > > @@ -306,6 +307,36 @@ > > input-enable; > > }; > > }; > > + > >

[PATCH] dt-bindings: backlight: lm3630a: correct schema validation

2019-05-20 Thread Brian Masney
lidation error: Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.example.dt.yaml: led@0: 'ti,linear-mapping-mode' does not match any of the regexes: 'pinctrl-[0-9]+' Fixes: 32fcb75c66a0 ("dt-bindings: backlight: Add lm3630a bindings") Signed-off-by:

[PATCH RESEND] ARM: dts: qcom: msm8974-hammerhead: add device tree bindings for vibrator

2019-05-16 Thread Brian Masney
This patch adds device device tree bindings for the vibrator found on the LG Nexus 5 (hammerhead) phone. Signed-off-by: Brian Masney --- This is a resend of the following patch that has missed the last two merge windows: https://lore.kernel.org/lkml/20190206013329.18195-4-masn...@onstation.org

Re: [PATCH RFC 4/6] ARM: dts: msm8974: add display support

2019-05-08 Thread Brian Masney
On Mon, May 06, 2019 at 11:39:02PM -0700, Bjorn Andersson wrote: > On Sun 05 May 06:04 PDT 2019, Brian Masney wrote: > > diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi > > b/arch/arm/boot/dts/qcom-msm8974.dtsi > [..] > > + cloc

Re: [GIT PULL] spi updates for v5.2

2019-05-08 Thread Brian Masney
On Wed, May 08, 2019 at 03:09:36PM +0900, Mark Brown wrote: > On Tue, May 07, 2019 at 02:07:30PM +0200, Sebastian Reichel wrote: > > > FWIW, I send out kernel.org mails via mail.kernel.org. Konstantin > > added that service in 2014. You can get a password with > > > ssh g...@gitolite.kernel.org g

Re: [PATCH v6 3/3] backlight: lm3630a: add firmware node support

2019-05-02 Thread Brian Masney
On Thu, May 02, 2019 at 11:19:50AM +0100, Daniel Thompson wrote: > On 24/04/2019 10:25, Brian Masney wrote: > > Add fwnode support to the lm3630a driver and optionally allow > > configuring the label, default brightness level, and maximum brightness > > level. The two outputs

[PATCH] dt-bindings: iio: isl29018: convert bindings to YAML format

2019-04-27 Thread Brian Masney
Convert the isl29018 device tree bindings to the new YAML format. Signed-off-by: Brian Masney --- I'm willing to be listed as the maintainer since this is one of the drivers that I moved out out of staging unless one of the original authors wants to be listed instead. I added the BSD-2-C

Re: [PATCH 0/8] qcom: spmi/ssbi gpio: correct gpio hogging

2019-04-27 Thread Brian Masney
Hi Bjorn, On Fri, Apr 26, 2019 at 10:30:34PM -0700, Bjorn Andersson wrote: > On Tue 05 Mar 16:53 PST 2019, Brian Masney wrote: > > > Here are some patches that fix gpio hogging for all boards that use > > spmi-gpio and ssbi-gpio. These depend on the following two patches >

[PATCH v3 2/2] dt-bindings: iio: tsl2583: convert bindings to YAML format

2019-04-25 Thread Brian Masney
Convert the tsl2583 device tree bindings to the new YAML format. Signed-off-by: Brian Masney Reviewed-by: Rob Herring --- Changes since v2: - Changed 'als-sensor@29' in example to 'light-sensor@29' Changes since v1: - Dropped description from reg and interrupts properties.

[PATCH v3 1/2] dt-bindings: iio: tsl2772: convert bindings to YAML format

2019-04-25 Thread Brian Masney
Convert the tsl2772 device tree bindings to the new YAML format. Signed-off-by: Brian Masney --- Changes since v2: - Remove allof from led-max-microamp. Split out enum list from [] to individual lines for consistency with the compatible attribute. - Change 'proximity-sensor@39' in

Re: [PATCH v2 1/2] dt-bindings: iio: tsl2772: convert bindings to YAML format

2019-04-24 Thread Brian Masney
On Wed, Apr 24, 2019 at 05:22:37AM -0400, Brian Masney wrote: > Convert the tsl2772 device tree bindings to the new YAML format. > > Signed-off-by: Brian Masney > --- > Changes since v1: > - Dropped description from reg and interrupts properties. > - Dropped $ref from

[PATCH v2 2/2] dt-bindings: iio: tsl2583: convert bindings to YAML format

2019-04-24 Thread Brian Masney
Convert the tsl2583 device tree bindings to the new YAML format. Signed-off-by: Brian Masney --- Changes since v1: - Dropped description from reg and interrupts properties. - Dropped $ref from vcc-supply property. - Changed 'tsl2581@29' in example to 'als-sensor@29' I ca

[PATCH v2 1/2] dt-bindings: iio: tsl2772: convert bindings to YAML format

2019-04-24 Thread Brian Masney
Convert the tsl2772 device tree bindings to the new YAML format. Signed-off-by: Brian Masney --- Changes since v1: - Dropped description from reg and interrupts properties. - Dropped $ref from led-max-microamp, vdd-supply, and vddio-supply. - Changed 'tsl2772@39' in example to 'p

Re: [PATCH 1/2] dt-bindings: iio: tsl2772: convert bindings to YAML format

2019-04-24 Thread Brian Masney
On Tue, Apr 23, 2019 at 08:34:13PM -0500, Rob Herring wrote: > On Mon, Apr 22, 2019 at 7:52 AM Jonathan Cameron wrote: > > > diff --git a/Documentation/devicetree/bindings/iio/light/tsl2772.yaml > > > b/Documentation/devicetree/bindings/iio/light/tsl2772.yaml > > > new file mode 100644 > > > inde

[PATCH 2/2] dt-bindings: iio: tsl2583: convert bindings to YAML format

2019-04-16 Thread Brian Masney
Convert the tsl2583 device tree bindings to the new YAML format. Signed-off-by: Brian Masney --- I can no longer find the data sheet for this device linked on AMS's site. The datasheet is still on Digikey [1], however I didn't include it in the binding document since I assume that we s

[PATCH 1/2] dt-bindings: iio: tsl2772: convert bindings to YAML format

2019-04-16 Thread Brian Masney
Convert the tsl2772 device tree bindings to the new YAML format. Signed-off-by: Brian Masney --- .../devicetree/bindings/iio/light/tsl2772.txt | 42 - .../bindings/iio/light/tsl2772.yaml | 85 +++ 2 files changed, 85 insertions(+), 42 deletions(-) delete mode

  1   2   3   4   5   6   >