Re: [PATCH 16/29] scsi: esas2r: constify pci_device_id.

2017-08-10 Thread Bradley Grove
Looks good. Acked-by: Bradley Grove On 07/30/2017 04:40 AM, Arvind Yadav wrote: pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. Signed-off-by: Arvind Yadav

Re: [PATCH] [SCSI] esas2r: remove redundant NULL check on buffer

2017-03-16 Thread Bradley Grove
memset(buffer, 0, buflen); /* Thanks, Acked-by: Bradley Grove This electronic transmission and any attachments hereto are intended only for the use of the individual or entity to which it is addressed and may contain confidential information belonging to ATTO Technology, Inc.

[PATCH] MAINTAINERS: Updated esas2r entry

2016-09-09 Thread Bradley Grove
Entry updated to include Bradley Grove as a maintainer with a personal email address, rather than depended on an exploder. Signed-off-by: Bradley Grove --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index db814a8..fc3b638 100644

Re: [PATCH] scsi: not need to alloc zero buffer for local_atto_ioctl

2016-08-25 Thread Bradley Grove
Acked-by: Bradley Grove On 08/20/2016 10:33 PM, Shawn Lin wrote: We don't need to use kzalloc as we will always memset the local_atto_ioctl later. Signed-off-by: Shawn Lin --- drivers/scsi/esas2r/esas2r_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH] scsi: don't reinitialize adapter's req_table

2016-08-25 Thread Bradley Grove
Acked-by: Bradley Grove On 08/20/2016 10:39 PM, Shawn Lin wrote: req_table is allocate by kzalloc, so we don't need to zero it again anyway. Signed-off-by: Shawn Lin --- drivers/scsi/esas2r/esas2r_init.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/scsi/e

Re: [PATCH 1/1] esas2r: Correct typos of "validate" in a comment

2014-12-02 Thread Bradley Grove
Acked-by: Bradley Grove Thanks, Brad On 11/27/2014 11:13 AM, Boris Bodemann wrote: From: Boris Bodemann Correct typos of "validate" in a comment Signed-off-by: Boris Bodemann --- diff -up a/drivers/scsi/esas2r/esas2r_flash.c b/drivers/scsi/esas2r/esas2r_flash.c --- a/drivers/s

Re: [RESEND][PATCH] scsi: esas2r: fix potential format string flaw

2013-12-17 Thread Bradley Grove
Acked-by: Bradley Grove On 12/17/2013 01:27 PM, Kees Cook wrote: This makes sure format strings cannot leak into the printk call via the constructed buffer. Signed-off-by: Kees Cook --- drivers/scsi/esas2r/esas2r_log.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] scsi: esas2r: fix potential format string flaw

2013-09-11 Thread Bradley Grove
On 09/11/2013 12:38 AM, Kees Cook wrote: This makes sure format strings cannot leak into the printk call via the constructed buffer. Signed-off-by: Kees Cook --- Acked-by: Bradley Grove Brad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the