Re: [PATCH-next] fs/btrfs: Fix uninitialized variable

On Tue, Apr 13, 2021 at 02:06:04PM +0100, Khaled ROMDHANI wrote: > The variable zone is not initialized. It > may causes a failed assertion. > > Addresses-Coverity: ("Uninitialized variables") > > Signed-off-by: Khaled ROMDHANI Reviewed-by: Boris Burkov > ---

[PATCH v2] btrfs: fix mount failure caused by race with umount

g over it, which this patch breaks. I will be sending a subsequent fix for the seed replace issue which will also fix btrfs/163. Signed-off-by: Boris Burkov --- fs/btrfs/volumes.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volume

[PATCH] btrfs: fix mount failure caused by race with umount

g over it, which this patch breaks. I will be sending a subsequent fix for the seed replace issue which will also fix btrfs/163. Signed-off-by: Boris Burkov --- fs/btrfs/volumes.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volume

[PATCH v2 btrfs/for-next] btrfs: fix fatal extent_buffer readahead vs releasepage race

7f5a94aecc78 R14: 7f5a94aecc90 R15: 7f5a94aecc40 Signed-off-by: Boris Burkov --- fs/btrfs/extent_io.c | 40 1 file changed, 24 insertions(+), 16 deletions(-) diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index c59e07360083..95313bb7fe40

[PATCH btrfs/for-next] btrfs: fix fatal extent_buffer readahead vs releasepage race

ossibly be unset by a competing task: after io_pages has been incremented. There is no race in write_one_eb, that we know of, but for consistency, apply it there too. All the codepaths that clear TREE_REF check for io, so they would not be able to clear it after this point. Signed-off-by: Boris

[PATCH] blk-cgroup: don't account iostat for root cgroup

This data is never flushed by rstat, so it is never used. We shouldn't bother collecting it. We can access global disk stats to compute io statistics for the root cgroup. Signed-off-by: Boris Burkov --- include/linux/blk-cgroup.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 2/2 blk-cgroup/for-5.8] blk-cgroup: show global disk stats in root cgroup io.stat

/proc/diskstats and io.stat. Note that in order to collect the disk stats, we needed to iterate over devices. To facilitate that, we had to change the linkage of a disk_type to external so that it can be used from blk-cgroup.c to iterate over disks. Signed-off-by: Boris Burkov Suggeste

[PATCH 1/2 blk-cgroup/for-5.8] blk-cgroup: make iostat functions visible to stat printing

practice in this file, simply move the iostat functions up. We only plan to use blkg_iostat_set, but it seems better to keep them all together. Signed-off-by: Boris Burkov --- block/blk-cgroup.c | 142 ++--- 1 file changed, 71 insertions(+), 71 deletions

[PATCH blk-cgroup/for-5.8] blk-cgroup: show global disk stats in root cgroup io.stat

/proc/diskstats and io.stat. Signed-off-by: Boris Burkov Suggested-by: Tejun Heo --- Documentation/admin-guide/cgroup-v2.rst | 3 +- block/blk-cgroup.c | 199 +++- block/genhd.c | 4 +- include/linux/genhd.h

[PATCH v2 cgroup/for-5.8] cgroup: add cpu.stat file to root cgroup

f cpu.stat from existing data collected for /proc/stat anyway. Signed-off-by: Boris Burkov Suggested-by: Tejun Heo --- Documentation/admin-guide/cgroup-v2.rst | 6 +-- kernel/cgroup/cgroup.c | 1 - kernel/cgroup/rstat.c | 60 + 3 fil

[PATCH cgroup/for-5.8] cgroup: add cpu.stat file to root cgroup

f cpu.stat from existing data collected for /proc/stat anyway. Signed-off-by: Boris Burkov Suggested-by: Tejun Heo --- kernel/cgroup/cgroup.c | 1 - kernel/cgroup/rstat.c | 60 -- 2 files changed, 52 insertions(+), 9 deletions(-) diff --git a/ker