RE: [patch V2] wireless: mwifiex: Use the proper interfaces

> > + u32 queue_delay = ktime_to_ms(net_timedelta(skb->tstamp)); > > FWIW, I think the same as patch 12 applies here. net_timedelta() doesn't > really seem to be a good way to calculate time deltas. Shall we change net_timedelta to ktime_sub() using ktime_get()? + u32 queue_delay = ktim

RE: [patch 11/13] wireless: mwifiex: Use the proper interfaces

Hi Thomas, Thanks for your patch. > Why is converting time formats so desired if there are proper > interfaces for this? > > Signed-off-by: Thomas Gleixner > Cc: Bing Zhao > Cc: "John W. Linville" > Cc: linux-wirel...@vger.kernel.org [...] > Index: linux/d

RE: [PATCH] mwifiex: use time_after()

Hi Manuel, Thanks for the patch. > To be future-proof and for better readability the time comparisons are > modified to use time_after() instead of plain, error-prone math. > > Signed-off-by: Manuel Schölling Acked-by: Bing Zhao Regards, Bing > --- > drivers/net/wirel

RE: [PATCH][linux-next] wireless: fixed bad dev_info integer type warning

Hi Jan, Thanks for the patch. > The pointer difference (ptrdiff_t) should be formatted by %tx, not %lx. > > Signed-off-by: Jan Moskyto Matejka Acked-by: Bing Zhao Regards, Bing > --- > drivers/net/wireless/mwifiex/pcie.c | 2 +- > 1 file changed, 1 insertion(+), 1 del

RE: linux-next: build failure after merge of the wireless-next tree

Hi Stephen, > Hi John, > > After merging the wireless-next tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/net/wireless/mwifiex/pcie.c: In function 'mwifiex_pcie_fw_dump_work': > drivers/net/wireless/mwifiex/pcie.c:2290:3: error: implicit declaration of > f

RE: [PATCH net-next 6/7] mwifiex: Remove casts of pointer to same type

; > Signed-off-by: Joe Perches Acked-by: Bing Zhao Thanks, Bing > --- > drivers/net/wireless/mwifiex/pcie.c | 6 +++--- > drivers/net/wireless/mwifiex/scan.c | 2 +- > drivers/net/wireless/mwifiex/tdls.c | 6 +++--- > 3 files changed, 7 insertions(+), 7 deletions(-) >

[PATCH 3.14] mwifiex: rename usb driver name registerring to usb core

renaming mwifiex_usb driver's name. Reported-by: Fengguang Wu Signed-off-by: Bing Zhao --- drivers/net/wireless/mwifiex/usb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/mwifiex/usb.c b/drivers/net/wireless/mwifiex/usb.c index e8ebbd4..cb6b70a

RE: [mwifiex/USB8897] Error: Driver 'usb8xxx' is already registered, aborting...

Hi Fengguang, > Greetings, > > I got the below dmesg and the first bad commit is > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > commit 68458dede7e0055198318dcb0318df3b4f419507 > CommitDate: Mon Jan 13 14:46:59 2014 -0500 > > mwifiex: add USB8897 support > > [

RE: [PATCH v3.6 17/19] mwifiex: slight optimization of addr compare

Hi Ding, > - if (memcmp(priv->curr_bss_params.bss_descriptor.mac_address, > -ibss_coal_resp->bssid, ETH_ALEN)) { > + if (!ether_addr_equal(priv->curr_bss_params.bss_descriptor.mac_address, > ibss_coal_resp->bssid)) Still wrong... ;) Have you actually run the checkpatch.p

RE: [PATCH v3.5 17/19] mwifiex: slight optimization of addr compare

Hi Ding, > Use possibly more efficient ether_addr_equal > instead of memcmp. > @@ -782,8 +782,7 @@ static int mwifiex_ret_ibss_coalescing_status(struct > mwifiex_private *priv, > } > > /* If BSSID is diff, modify current BSS parameters */ > - if (memcmp(priv->curr_bss_params.bss

RE: [PATCH 15/21] mwifiex: slight optimization of addr compare

Hi Ding, > diff --git a/drivers/net/wireless/mwifiex/11n_rxreorder.c > b/drivers/net/wireless/mwifiex/11n_rxreorder.c > index ada809f..a180298 100644 > --- a/drivers/net/wireless/mwifiex/11n_rxreorder.c > +++ b/drivers/net/wireless/mwifiex/11n_rxreorder.c > @@ -164,7 +164,7 @@ mwifiex_11n_get_rx_r

RE: [PATCH 09/11] mwifiex: Remove extern from function prototypes

ompiler. Its use is as unnecessary as > using auto to declare automatic/local variables in a block. > > Signed-off-by: Joe Perches Acked-by: Bing Zhao Thanks, Bing > --- > drivers/net/wireless/mwifiex/wmm.h | 24 ++-- > 1 file changed, 10 insertions(+)

RE: [PATCH 11/19] wireless: Change variable type to bool

): > > @exists@ > type T; > identifier b; > @@ > - T > + bool > b = ...; > ... when any > b = \(true\|false\) > > Signed-off-by: Peter Senna Tschudin Acked-by: Bing Zhao Thanks, Bing > --- > drivers/net/wireless/mwifiex/cmdevt.c | 2 +- >

RE: [PATCH] wireless: Convert mwifiex/pcie to dev_pm_ops from legacy pm_ops

> Signed-off-by: Shuah Khan Acked-by: Bing Zhao Thanks, Bing -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

RE: [PATCH] wireless: Convert mwifiex/pcie to dev_pm_ops from legacy pm ops

Hi Hauke, Thanks for your comments. > > @@ -213,7 +227,7 @@ static void mwifiex_pcie_remove(struct pci_dev *pdev) > > if (user_rmmod) { > > #ifdef CONFIG_PM > > if (adapter->is_suspended) > > - mwifiex_pcie_resume(pdev); > > + __mwifiex_pcie_re

RE: [PATCH] wireless: Convert mwifiex/pcie to dev_pm_ops from legacy pm ops

Hi Shuah, Thanks for the patch. > Convert the mwifiex/pci driver to use dev_pm_ops for power management and > remove Legacy PM handling. This change re-uses existing suspend and resume > interfaces for dev_pm_ops. > > Signed-off-by: Shuah Khan Acked-by: Bing Zhao Than

RE: [PATCH V2 1/1] mwifiex: add tx info to skb when forming mgmt frame

Hi Harvey, > From: Huawei Yang > > In function 'mwifiex_write_data_complete' it need tx info to find the > mwifiex_private to updates statistics and wake up tx queues. > Or we may trigger tx queues timeout when transmitting lots of mgmt frames. > > Signed-off-by: Huawei Yang > --- > drivers/n

RE: [PATCH 1/1] mwifiex: add tx info to skb when forming mgmt frame

Hi Harvey, Thanks for your patch. > From: Huawei Yang > > In function 'mwifiex_write_data_complete' it need tx info to find the > mwifiex_private to updates > statistics and wake up tx queues. Or we may trigger tx queues timeout when > transmitting lots of mgmt > frames burstly. Please short

RE: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

> I didn't get the same result..In my case, it's working fine. > But as Bing's result, i will check more and share the result. I want to add that my kernel is from "cros/release-R26-3701.B" branch with this HEAD: 4e13a9c CHERRY-PICK: UPSTREAM: loop: prevent bdev freeing while device in use Tha

RE: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

> I think the proposal on the table is to take Seungwon's patches > instead of mine. Assuming they solve your problems, I'm OK with that. > I think he was requesting testing the first of his two patches alone > and then both of his two patches together. Test #1: Swungwon's patch #1 alone [1] Te

RE: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

Hi Doug, > > I tested Doug's patch on my failing unit. > > > > Without this patch, mmc got hung_task and rebooted eventually. > > With this patch applied, mmc returns CRC error instead of hung_task, and > > the error is handled > gracefully. > > Have you tried one or both or Seungwon's fixes wit

RE: [PATCH] RFC: mmc: dw_mmc: Always go to STATE_DATA_BUSY from STATE_DATA_ERROR

Hi Seungwon, > > I don't have the failing unit myself, so we'll have to get Bing to try > > the patches. You are suggesting that we try applying both of your > > patches, right? > Did you test the patch? > I wonder that both are good for your side. I tested Doug's patch on my failing unit. With

RE: [RFC PATCH 1/1] mwifiex: Remove stop_net_dev_queue operation when uap handling packets forwarding.

as such kind of check when transmitting > packets and it's not proper > to have forwarding affect local transmitting. > > Signed-off-by: Huawei Yang Reviewed-by: Avinash Patil Acked-by: Bing Zhao Thanks, Bing > --- > drivers/net/wireless/mwifiex/uap_txrx.c |

RE: [RFC PATCH] net/wireless/mwifiex/pcie: Convert to dev_pm_ops from legacy pm ops

Hi Shuah, > Convert the driver to use dev_pm_ops for power management and remove Legacy PM > handling. This change re-uses existing suspend and resume interfaces for > dev_pm_ops. > > Signed-off-by: Shuah Khan > Cc: Shuah Khan > Suggested-by: rafael.j.wyso...@intel.com

RE: [PATCH] net-sysfs: Add entry for nl80211 interface type

Hi Marcel, > Hi Bing, > > > Add a "wireless/nl80211_iftype" entry in the net device sysfs > > file structure to indicate the mode of the wireless device so > > it can be discovered easily from userspace. > > I do question a little bit the usefulness for this one. > It would only work on netdev a

[PATCH] net-sysfs: Add entry for nl80211 interface type

Add a "wireless/nl80211_iftype" entry in the net device sysfs file structure to indicate the mode of the wireless device so it can be discovered easily from userspace. Signed-off-by: Paul Stewart Signed-off-by: Bing Zhao --- net/core/net-sysfs.c | 18 ++ 1 files c

RE: [ 099/171 ] mwifiex: fix race when queuing commands

Hi Steven, > 3.6.11.2 stable review patch. > If anyone has any objections, please let me know. > > -- > > From: Amitkumar Karwar > > [ Upstream commit 00d7ea11ff0783e24fe70778f3141270b561aaa1 ] > > Running the following script repeatedly on XO-4 with SD8787 > produces command

RE: [PATCH 054/102] mwifiex: cancel cmd timer and free curr_cmd in shutdown process

Hi Luis, > 3.5.7.10 -stable review patch. If anyone has any objections, please let me > know. > > -- > > From: Bing Zhao > > commit 084c7189acb3f969c855536166042e27f5dd703f upstream. > > curr_cmd points to the command that is in processin

RE: [ 14/56] mwifiex: cancel cmd timer and free curr_cmd in shutdown process

Hi Ben, Greg, > > From: Bing Zhao > > > > commit 084c7189acb3f969c855536166042e27f5dd703f upstream. > > > > curr_cmd points to the command that is in processing or waiting > > for its command response from firmware. If the function shutdown > > happens

RE: [ 25/68] mwifiex: cancel cmd timer and free curr_cmd in shutdown process

Hi Greg, > 3.4-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Bing Zhao > > commit 084c7189acb3f969c855536166042e27f5dd703f upstream. > > curr_cmd points to the command that is in processing or waiting >

RE: [PATCH] libertas sdio: remove CMD_FUNC_INIT call

Hi Daniel, > > Do you have any concern for OLPC platforms with above change? If it doesn't > > seem to break OLPC I > will send a patch to the list. > > Looks fine to me. Thanks for investigating. Thanks. I've just sent the patch. Regards, Bing -- To unsubscribe from this list: send the line "

[PATCH 3.9] libertas: fix crash for SD8688

[] (sys_init_module+0x104/0x128) [ 209.484632] [] (sys_init_module+0x104/0x128) from [] (ret_fast_syscall+0x0/0x38) Fix it by setting fw_ready flag prior to queuing FUNC_INIT command. Cc: # 3.5+ Reported-by: Lubomir Rintel Tested-by: Lubomir Rintel Signed-off-by: Bing Zhao --- drivers/net

RE: [PATCH] libertas sdio: remove CMD_FUNC_INIT call

Hi Daniel, > > There seems to be a race condition in lbs_thread(). > > > > At line 582: > > 582 if (!priv->fw_ready) > > 583 continue; > > > > The fw_ready is 0, so you never get the chance to execute the FUNC_INIT > > command. > > > > 617

RE: [PATCH] libertas sdio: remove CMD_FUNC_INIT call

Hi Lubomir, > > > @@ -825,20 +825,6 @@ static void if_sdio_finish_power_on(struct > > > if_sdio_card *card) > > > > > > sdio_release_host(func); > > > > > > - /* > > > - * FUNC_INIT is required for SD8688 WLAN/BT multiple functions > > > - */ > > > - if (card->model == MODEL_8688) { > > > -

RE: [ 014/128] mwifiex: wakeup and stop multiple tx queues in net_device

Hi Ben, > > Right, I've managed to pick up 3 changes to mwifiex that it looks like I > > shouldn't have included. Firstly: > > > > 9c969d8ccb1e mwifiex: check wait_event_interruptible return value > > > > This had "3.6+" to the left of , whereas I > > expect version qualifiers to be on the right.

RE: [ 014/128] mwifiex: wakeup and stop multiple tx queues in net_device

Hi Ben, > On Mon, 2013-02-04 at 11:43 -0800, Bing Zhao wrote: > > Hi Ben, > > > > > 3.2-stable review patch. If anyone has any objections, please let me > > > know. > > > > > > -- > > > > > > From: Avina

RE: [ 014/128] mwifiex: wakeup and stop multiple tx queues in net_device

e queue function calls with equivalent multiple queue > functions. Wakeup queue and stop queue calls are guarded by spin lock. > > Signed-off-by: Avinash Patil > Signed-off-by: Kiran Divekar > Signed-off-by: Bing Zhao > Signed-off-by: John W. Linville > Signed-off-by: Ben

RE: [ 26/89] mwifiex: update config_bands during infra association

ious IBSS network history, > > which leads to association failure. > > > > This patch fixes the problem by correctly updating config_bands. > > > > Signed-off-by: Amitkumar Karwar > > Signed-off-by: Bing Zhao > > Signed-off-by: John W. Linville > &

RE: [PATCH] mwifiex: avoid out of bounds access in mwifiex_get_common_rates.

or (... ; <+... t[idx] ...+> && idx < E ; ...) > S > > > Signed-off-by: Cyril Roelandt Acked-by: Bing Zhao Thanks, Bing > --- > drivers/net/wireless/mwifiex/join.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/d

RE: [PATCH] mwifiex: don't return zero on failure paths in mwifiex_pcie_init()

; > Signed-off-by: Alexey Khoroshilov Acked-by: Bing Zhao Thanks, Bing > --- > drivers/net/wireless/mwifiex/pcie.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/wireless/mwifiex/pcie.c > b/drivers/net/wireless/mwifiex/pcie.c > index 1

RE: [PATCH] libertas sdio: remove CMD_FUNC_INIT call

Hi Lubomir, > It actually times out on a 8688 present in GuruPlug with sd8688.bin > (md5=7233401e9687f8c880da547beed4324e) firmware (that's present in > linux-firmware tree), but the adapter works fine. > > For that firmware times out with libertas_uap [1] as well, though it succeeds > with sd868

RE: sd8688 firmware location

Hi Dan, > > btmrvl_sdio and libertas_sdio both use firmware files sd8688.bin and > > sd8688_helper.bin. In linux-firmware, they're present in libertas/ tree and > > (since 3d32a58b) libertas_sdio perfers loading it from there, while it is > > able > > to fallback to load it from linux-firmware ro

RE: [PATCH] Bluetooth: btmrvl_sdio: look for sd8688 firmware in alternate place

> > linux-firmware ships the sd8688* firmware images that are shared with > > libertas_sdio WiFi driver under libertas/. libertas_sdio looks in both > > places > > and so should we. > > > > Signed-off-by: Lubomir Rintel > > --- > > drivers/bluetooth/btmrvl_sdio.c | 24 ++--

RE: [PATCH -v2 18/26] drivers/net: rename random32() to prandom_u32()

Hi Akinobu, > Use more preferable function name which implies using a pseudo-random > number generator. > > Signed-off-by: Akinobu Mita > Acked-by: Thomas Sailer > Cc: "David S. Miller" > Cc: Michael Chan > Cc: Thomas Sailer > Cc: Jean-Paul

RE: [PATCH 07/25] mwifiex: don't use [delayed_]work_pending()

add_host(). Make > sdio_card_reset_worker() cache the target mmc_host so that it isn't > affected by mwifiex_sdio_card_reset() racing with it. > > Only compile tested. > > Signed-off-by: Tejun Heo > Cc: Bing Zhao > Cc: linux-wirel...@vger.kernel.org Acked-by: Bing Zh

RE: [PATCH] wireless: mwifiex: remove unreachable paths

Hi Sasha, Thanks for the patch. > We know 'firmware' is non-NULL from the beginning of mwifiex_prog_fw_w_helper, > remove all !firmware paths from the rest of the function. After removing all !firmware paths the function 'mwifiex_get_fw_data' becomes an orphan. Could you please remove that fun

RE: [PATCH] [trivial] wireless: mwifiex: Fix typo in wireless/mwifiex driver

Hi Masanari, Thanks for your patch. > Subject: [PATCH] [trivial] wireless: mwifiex: Fix typo in wireless/mwifiex > driver > > Correct spelling typo in wireless/mwifiex driver. > > Signed-off-by: Masanari Iida Acked-by: Bing Zhao Regards, Bing > --- > driv

RE: [PATCH net-next 04/21] wireless: Convert is__ether_addr uses to eth_addr_

Hi Joe, > Subject: [PATCH net-next 04/21] wireless: Convert is__ether_addr uses to > eth_addr_ > > Convert the old ether_addr tests to eth_addr_. > Adds api consistency. > > Signed-off-by: Joe Perches Acked-by: Bing Zhao [mwifiex] Thanks, Bing -- To unsubscribe fro