Re: [Patch v2 0/2] Move Digi Neo card support from dgnc to jsm

2014-09-08 Thread Bill Pemberton
On 09/08/2014 04:17 PM, Greg KH wrote: On Sat, Aug 30, 2014 at 04:35:56PM -0400, wf...@worldbroken.com wrote: From: Bill Pemberton The jsm driver (drivers/tty/serial/jsm) already supports the Digi Neo cards that dgnc (staging) supports. In fact, it appears that jsm was based on dgnc. The

Re: [PATCH 1/2] jsm: add support for additional Neo cards

2014-08-30 Thread Bill Pemberton
On 08/30/2014 02:59 PM, Greg KH wrote: On Sat, Aug 30, 2014 at 02:54:36PM -0400, wf...@worldbroken.com wrote: From: Bill Pemberton Add device ids for additional Neo cards. The ids come from the dgnc driver. Signed-off-by: Bill Pemberton --- drivers/tty/serial/jsm/jsm_driver.c | 38

Re: linux-next: build failure after merge of the tty tree

2013-03-20 Thread Bill Pemberton
Jiri Slaby writes: > > On 03/20/2013 03:42 PM, Bill Pemberton wrote: > > Ok, for the unopened ports there *should* never be any actual data to > > push so the push is really doing nothing anyhow in these cases. It's > > coming from the device sending a

Re: linux-next: build failure after merge of the tty tree

2013-03-20 Thread Bill Pemberton
Jiri Slaby writes: > > On 03/20/2013 01:51 PM, Bill Pemberton wrote: > > Jiri Slaby writes: > >> > >>> drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': > >>> drivers/usb/serial/quatech2.c:661:18: error: '

Re: linux-next: build failure after merge of the tty tree

2013-03-20 Thread Bill Pemberton
Jiri Slaby writes: > > > drivers/usb/serial/quatech2.c: In function 'qt2_process_read_urb': > > drivers/usb/serial/quatech2.c:661:18: error: 'struct > > qt2_port_private' has no member named 'is_open' > > drivers/usb/serial/quatech2.c:705:15: error: 'struct > > qt2_port_private' has no member na

Re: [PATCH 07/16] TTY: quatech2, remove unneeded is_open

2013-03-13 Thread Bill Pemberton
Jiri Slaby writes: > > On 03/13/2013 02:46 PM, Bill Pemberton wrote: > > Jiri Slaby writes: > >> > >> tty->ops->break_ctl cannot be called outside the gap between open and > >> close. So there is no need to check whether the port is open in > >

Re: [PATCH 07/16] TTY: quatech2, remove unneeded is_open

2013-03-13 Thread Bill Pemberton
Jiri Slaby writes: > > tty->ops->break_ctl cannot be called outside the gap between open and > close. So there is no need to check whether the port is open in > break_ctl in quatech2. Remove the check and also that member > completely. > We can't get rid of is_open. The devices use 1 read urb f

Re: [PATCH 1/2] init.h: Remove __dev* sections from the kernel

2012-11-30 Thread Bill Pemberton
H. Peter Anvin writes: > > On 11/29/2012 10:43 AM, Greg Kroah-Hartman wrote: > > From: Greg Kroah-Hartman > > > > With the recent work to remove CONFIG_HOTPLUG, we are starting to get a > > bunch of __devinit section warnings, despite CONFIG_HOTPLUG always being > > enabled. So, stop marking the

Re: new warnings from partial __devexit removal

2012-11-27 Thread Bill Pemberton
gre...@linuxfoundation.org writes: > > On Mon, Nov 26, 2012 at 08:38:32PM +, Arnd Bergmann wrote: > > This is probably known and fixed already, but in case it's not, let me just > > mention that I saw two new warnings with ARM allyesconfig about a > > __devexit being removed but the __devexit_

Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option

2012-11-22 Thread Bill Pemberton
Grant Likely writes: > > You mean this series wasn't created with a script? You did this by > hand? If so then I must say kudos on your dedication! > > But it makes me more nervous about the series. Too easy to fat > finger many things when touching that many files. > No, I didn't do them by hand

Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option

2012-11-21 Thread Bill Pemberton
Andrew Morton writes: > > On Tue, 20 Nov 2012 10:46:11 + Grant Likely > wrote: > > > On Sat, Nov 17, 2012 at 12:19 AM, Bill Pemberton wrote: > > > CONFIG_HOTPLUG is no longer an optional setting. In order to remove > > > it as on option code paths th