Re: [PATCH v2] tracing: Allow changing default ring buffer size for ftrace instances.

2014-04-29 Thread Bharath Ravi
ld go back to that though if you think that's okay, but I think your previous reasoning still makes sense: it's useful for the user to know if there will be an allocation failure before enabling tracing. What are your thoughts? Bharath Ravi | rbhar...@google.com On Fri, Apr 25, 2014

[PATCH 0/3] Allow instances to independently set trace options.

2014-03-24 Thread Bharath Ravi
the trace_array. Divide the set of trace options into global options, and instance options (that may be set independently by instances). 3. Make trace_overwrite an instance specific option. Bharath Ravi (3): tracing: Replace usage of trace_flags with new accessors. tracing: Allow

[PATCH 1/3] tracing: Replace usage of trace_flags with new accessors.

2014-03-24 Thread Bharath Ravi
instance specific (local) trace_flags, allowing each instance to set trace_flags independently. Signed-off-by: Bharath Ravi --- kernel/trace/blktrace.c | 3 +- kernel/trace/ftrace.c| 4 +-- kernel/trace/trace.c | 64

[PATCH 3/3] tracing: Allow instances to independently set trace_overwrite.

2014-03-24 Thread Bharath Ravi
ions array. Signed-off-by: Bharath Ravi --- kernel/trace/trace.c | 6 -- kernel/trace/trace.h | 44 +++ kernel/trace/trace_irqsoff.c | 2 +- kernel/trace/trace_sched_wakeup.c | 2 +- 4 files changed, 28 insertions(+), 26 deletion

[PATCH 2/3] tracing: Allow instances to have independent trace flags/trace options.

2014-03-24 Thread Bharath Ravi
option to a position less than global_flags_start in the trace_options list. Signed-off-by: Bharath Ravi --- kernel/trace/trace.c | 73 kernel/trace/trace.h | 2 +- 2 files changed, 57 insertions(+), 18 deletions(-) diff --git a/kernel/trace

Re: [PATCH] tracing: Allow instances to have independent trace flags/trace options.

2014-02-14 Thread Bharath Ravi
Hi Steven, What are your thoughts on this patch? -- Bharath Ravi | rbhar...@google.com On Thu, Jan 23, 2014 at 11:46 AM, Bharath Ravi wrote: > Hi Steven, > > This patch allows instances to have their own independent trace > options (as opposed to the current globally shared t

Re: [PATCH v2] tracing: Allow changing default ring buffer size for ftrace instances.

2014-02-14 Thread Bharath Ravi
Hi Steven, Does this version of the patch look reasonable? -- Bharath Ravi | rbhar...@google.com On Thu, Jan 23, 2014 at 11:37 AM, Bharath Ravi wrote: > > It is often memory efficient to start instances off with a smaller ring > buffer size than the current default. This is particul

Re: [PATCH] tracing: Allow instances to have independent trace flags/trace options.

2014-01-23 Thread Bharath Ravi
Hi Steven, This patch allows instances to have their own independent trace options (as opposed to the current globally shared trace options) Does this look like a reasonable change? Bharath Ravi | rbhar...@google.com On Fri, Nov 22, 2013 at 10:51 AM, Bharath Ravi wrote: > Currently,

[PATCH v2] tracing: Allow changing default ring buffer size for ftrace instances.

2014-01-23 Thread Bharath Ravi
the appropriate size while initializing their ring buffers. Signed-off-by: Bharath Ravi --- kernel/trace/trace.c | 13 ++--- kernel/trace/trace.h | 1 + 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 9d20cd9..c17c12f 10064

[PATCH] tracing: Allow instances to have independent trace flags/trace options.

2013-11-22 Thread Bharath Ravi
the global trace_flags variable is replaced by instance specific trace_flags in trace_array. References to the old global flags variable are replaced with accessors to the global_tracer's trace_flags. Signed-off-by: Bharath Ravi --- kernel/trace/blktrace.c | 5 +- kernel

[PATCH] tracing: Allow changing default ring buffer size for ftrace instances.

2013-11-06 Thread Bharath Ravi
the new file. Ensured that new ftrace instances created used the size specified in instance_default_buffer_size_kb as their initial ring buffer size. Signed-off-by: Bharath Ravi --- kernel/trace/trace.c | 57 +--- 1 file changed, 54 insertions(+)