On Thu, 28 Nov 2024 14:27:16 +0100, Benjamin Tissoires wrote:
> bpftool now embeds the kfuncs definitions directly in the generated
> vmlinux.h
>
> This is great, but because the selftests dir might be compiled with
> HID_BPF disabled, we have no guarantees to be able to compil
e
Cheers,
--
Benjamin Tissoires
`__not_used` hack, the newly
defined kfuncs do not match the ones from vmlinux.h and things go wrong.
Prevent vmlinux.h to define its kfuncs and also add the missing `__weak`
symbols for our custom kfuncs definitions
Signed-off-by: Benjamin Tissoires
---
This was noticed while bumping the CI to fedora
On Oct 29 2024, Shuah Khan wrote:
> On 10/29/24 03:07, Yun Lu wrote:
> > If running hid testcases with command "./run_kselftest.sh -c hid",
>
> NIT - When inestead of "If"
> > the following tests will take longer than the kselftest framework
> > timeout (now 200 seconds) to run and thus got termin
.
>
> v2: add the error message
>
> Fixes: ffb85d5c9e80 ("selftests: hid: import hid-tools hid-core tests")
> Cc: sta...@vger.kernel.org
> Signed-off-by: Yun Lu
Acked-by: Benjamin Tissoires
Shuah, I guess you'll want to take this one through your tree given tha
On Tue, 01 Oct 2024 16:30:04 +0200, Benjamin Tissoires wrote:
> This is a slight change from the fundamentals of HID-BPF.
> In theory, HID-BPF is abstract to the kernel itself, and makes
> only changes at the HID level (through report descriptors or
> events emitted to/fro
Allows to have an abstract class uhid_device which handles all of the
uhid part without having to mess up with individual fds.
struct attach_prog_args is now never used in hid_bpf.c, so drop it as well
Signed-off-by: Benjamin Tissoires
---
no changes in v3
no changes in v2
---
tools/testing
which would unwind everything that is done there.
Reviewed-by: Peter Hutterer
Signed-off-by: Benjamin Tissoires
---
no changes in v3
changes in v2:
- rely on hdev->quirks for that instead of a new struct for hid_driver
---
drivers/hid/hid-core.c| 5 +++--
drivers/hid/hid-generic.c | 3 +++
This will be useful to introduce variants in tests to test the
interactions between HID-BPF and some kernel modules.
Reviewed-by: Peter Hutterer
Signed-off-by: Benjamin Tissoires
---
no changes in v3
no changes in v2
---
tools/testing/selftests/hid/hid_bpf.c| 2 +-
tools/testing
Allows to recompile the C tests when that file changes
Reviewed-by: Peter Hutterer
Signed-off-by: Benjamin Tissoires
---
no changes in v3
no changes in v2
---
tools/testing/selftests/hid/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/hid
by the new pointer and the new unsigned int we need.
In terms of code allocation, when not using HID-BPF, we are back to kernel
v6.2 in hid_open_report(). These multiple kmemdup() calls will be fixed
in a later commit.
Signed-off-by: Benjamin Tissoires
---
changes in v3:
- consider ->bpf_rdes
This allows to give more control from BPF during report descriptor fixup.
We already reset the quirks before calling ->probe(), so now we reset
it once before calling hid_bpf_rdesc_fixup().
Reviewed-by: Peter Hutterer
Signed-off-by: Benjamin Tissoires
---
no changes in v3
new in
y: Peter Hutterer
Signed-off-by: Benjamin Tissoires
---
no changes in v3
new in v2
---
drivers/hid/hid-core.c | 28
1 file changed, 20 insertions(+), 8 deletions(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 6053e7cdc0c1..b0a22e173502 1006
Turns out the first kmemdup is only required for the .report_fixup()
driver callback. There is no need to do two kmemdup() in a row in case
.report_fixup() is not present.
Reviewed-by: Peter Hutterer
Signed-off-by: Benjamin Tissoires
---
no changes in v3
new in v2
---
drivers/hid/hid-core.c
ls-tests.sh script to the TEST_FILES in the Makefile.
>
I assume we probably also want:
Cc: sta...@vger.kernel.org
> Signed-off-by: Yun Lu
Not sure about the timing regarding our next PR to Linus, so in any cases:
Acked-by: Benjamin Tissoires
Cheers,
Benjamin
> ---
> tools/testi
On Sep 13 2024, Benjamin Tissoires wrote:
> On Sep 13 2024, Benjamin Tissoires wrote:
> > On Tue, 10 Sep 2024 23:43:36 +0900, Benjamin Tissoires wrote:
> > > This is a slight change from the fundamentals of HID-BPF.
> > > In theory, HID-BPF is abstract to the kernel i
On Sep 13 2024, Benjamin Tissoires wrote:
> On Tue, 10 Sep 2024 23:43:36 +0900, Benjamin Tissoires wrote:
> > This is a slight change from the fundamentals of HID-BPF.
> > In theory, HID-BPF is abstract to the kernel itself, and makes
> > only changes at the HID level (throu
On Tue, 10 Sep 2024 23:43:36 +0900, Benjamin Tissoires wrote:
> This is a slight change from the fundamentals of HID-BPF.
> In theory, HID-BPF is abstract to the kernel itself, and makes
> only changes at the HID level (through report descriptors or
> events emitted to/fro
Add a test for the newly enabled feature to control the connect_mask
of hid-generic.
Signed-off-by: Benjamin Tissoires
---
changes in v2:
- amended for the new API
---
tools/testing/selftests/hid/hid_bpf.c | 60 +-
tools/testing/selftests/hid/progs/hid.c
m can load a BPF program that instructs
hid-generic to rebind on the device with hidraw only and then open the
hidraw node itself.
When the application is closed, the BPF program is unloaded and the normal
driver takes back the control of the device.
Signed-off-by: Benjamin Tissoires
---
changes
We use a well known VID/PID on a driver that doesn't need to talk to
the device, ensures we created the device against the target driver,
then load our program and ensure we have unbound to this driver and use
hid-generic instead.
Signed-off-by: Benjamin Tissoires
---
changes in v2:
- am
which would unwind everything that is done there.
Signed-off-by: Benjamin Tissoires
---
changes in v2:
- rely on hdev->quirks for that instead of a new struct for hid_driver
---
drivers/hid/hid-core.c| 5 +++--
drivers/hid/hid-generic.c | 3 +++
include/linux/hid.h | 2 ++
3 files ch
This will be useful to introduce variants in tests to test the
interactions between HID-BPF and some kernel modules.
Signed-off-by: Benjamin Tissoires
---
no changes in v2
---
tools/testing/selftests/hid/hid_bpf.c| 2 +-
tools/testing/selftests/hid/hid_common.h | 46
Allows to have an abstract class uhid_device which handles all of the
uhid part without having to mess up with individual fds.
struct attach_prog_args is now never used in hid_bpf.c, so drop it as well
Signed-off-by: Benjamin Tissoires
---
no changes in v2
---
tools/testing/selftests/hid
Allows to recompile the C tests when that file changes
Signed-off-by: Benjamin Tissoires
---
no changes in v2
---
tools/testing/selftests/hid/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/hid/Makefile
b/tools/testing/selftests/hid
This allows to give more control from BPF during report descriptor fixup.
We already reset the quirks before calling ->probe(), so now we reset
it once before calling hid_bpf_rdesc_fixup().
Signed-off-by: Benjamin Tissoires
---
new in v2
---
drivers/hid/bpf/hid_bpf_struct_ops.c |
That last kmemdup while opening the report descriptor was required to
have a common kfree() on it.
Move that kmemdup in the only special case it's required (if there is a
.report_fixup()), and add a more elaborated check before freeing
hdev->rdesc, to avoid a double free.
Signed-off-by:
Turns out the first kmemdup is only required for the .report_fixup()
driver callback. There is no need to do two kmemdup() in a raw in case
.report_fixup() is not present.
Signed-off-by: Benjamin Tissoires
---
new in v2
---
drivers/hid/hid-core.c | 18 +++---
1 file changed, 11
int we need.
In terms of code allocation, when not using HID-BPF, we are back to kernel
v6.2 in hid_open_report(). These multiple kmemdup() calls will be fixed
in a later commit.
Signed-off-by: Benjamin Tissoires
---
new in v2
---
drivers/hid/bpf/hid_bpf_dispatch.c | 8 ++--
drivers/hid/
[0] https://gitlab.freedesktop.org/libinput/libinput/-/issues/1014
Signed-off-by: Benjamin Tissoires
---
Changes in v2:
- Refactored the API to not use a new hook but hid_bpf_rdesc_fixup
instead
- Some cleanups in hid-core.c probe() device to not kmemdup multiple
time the report descriptor w
On Thu, Apr 8, 2021 at 9:06 AM Lee Jones wrote:
>
> On Wed, 07 Apr 2021, Benjamin Tissoires wrote:
>
> > On Tue, Apr 6, 2021 at 10:56 AM Lee Jones wrote:
> > >
> > > On Fri, 26 Mar 2021, Lee Jones wrote:
> > >
> > > > This set is part of a l
On Fri, Mar 26, 2021 at 3:35 PM Lee Jones wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/hid/usbhid/usbkbd.c:66: warning: bad line: should be
> on
>
> Cc: Jiri Kosina
> Cc: Benjamin Tissoires
> Cc: message to
> Cc:
On Tue, Apr 6, 2021 at 10:56 AM Lee Jones wrote:
>
> On Fri, 26 Mar 2021, Lee Jones wrote:
>
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > Lee Jones (25):
> > HID: intel-is
Hi Jiri,
On Mon, Mar 8, 2021 at 11:15 AM Jiri Kosina wrote:
>
> On Wed, 17 Feb 2021, наб wrote:
>
> > This patchset adds support for stylus-on-touchscreen devices as found on
> > the OneMix 3 Pro and Dell Inspiron 15 7000 2-in-1 (7591), among others;
> > with it, they properly behave like a drawi
On Sat, Jan 23, 2021 at 7:03 PM Filipe Laíns wrote:
>
> From: Filipe Laíns
>
> Tested with the G Pro X Superlight. libratbag sees the device, as
> expected, and input events are passing trough.
>
> https://github.com/libratbag/libratbag/pull/1122
>
> The receiver has a quirk where the moused inte
driver.
>
> Signed-off-by: Andy Shevchenko
Thanks a lot for the series. This indeed cleans things up.
For the series:
Acked-by: Benjamin Tissoires
Jiri, I wonder where we want to land this one. This is not strictly
bug fixes, but we could definitively sneak this one in 5.12-rc1.
Well, I
On Mon, Mar 1, 2021 at 3:18 PM Andy Shevchenko
wrote:
>
> On Sun, Feb 28, 2021 at 3:30 AM Ronald Tschalär wrote:
> >
> > These are useful to drivers that need to scan or parse reports
> > themselves.
>
> ...
>
> > - while ((start = fetch_item(start, end, &item)) != NULL)
> > + while (
On Wed, Feb 17, 2021 at 6:32 PM Benjamin Tissoires
wrote:
>
> [sending those patches on behalf of Roderick]
>
> There is a current thread on LED LKML which basically means that
> we have to revert the LED class exposure until things are settled.
>
> I am sending here the full
On Mon, Feb 15, 2021 at 5:39 PM Colin King wrote:
>
> From: Colin Ian King
>
> The comparison of value with the array size ps_gamepad_hat_mapping
> appears to be off-by-one. Fix this by using >= rather than > for the
> size comparison.
>
> Addresses-Coverity: ("Out-of-bounds read")
> Fixes: bc2e1
and schedules an output report
to mute/unmute the audio stream as well as toggle the mute LED.
Signed-off-by: Roderick Colenbrander
Reviewed-by: Barnabás Pőcze
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-playstation.c | 44 +++
1 file changed, 44
From: Roderick Colenbrander
Provide initial support for the DualSense lightbar and configure it
with a default PlayStation blue color.
Signed-off-by: Roderick Colenbrander
Reviewed-by: Barnabás Pőcze
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-playstation.c | 65
original patches
minus use of LED framework APIs:
- HID: playstation: add DualSense player LEDs support.
- HID: playstation: DualSense set LEDs to default player id.
Signed-off-by: Roderick Colenbrander
Reviewed-by: Barnabás Pőcze
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-playstation.c
From: Roderick Colenbrander
The ret variable in ps_battery_get_property is set in an error path,
but never actually returned. Change the function to return ret.
Reported-by: kernel test robot
Signed-off-by: Roderick Colenbrander
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid
: Barnabás Pőcze
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-playstation.c | 81 +++
1 file changed, 81 insertions(+)
diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c
index 64193fdeaa0d..84f484fce1ee 100644
--- a/drivers/hid/hid
a big deal, they are still not pushed to Linus.
Signed-off-by: Roderick Colenbrander
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-playstation.c | 70 +--
1 file changed, 1 insertion(+), 69 deletions(-)
diff --git a/drivers/hid/hid-playstation.c b/drive
th the new version, we also revert
all patches on top of the LED ones.
This is not a big deal, they are still not pushed to Linus.
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-playstation.c | 81 ---
1 file changed, 81 deletions(-)
diff --git a/drive
, they are still not pushed to Linus.
Signed-off-by: Roderick Colenbrander
Signed-off-by: Benjamin Tissoires
---
drivers/hid/Kconfig | 1 -
drivers/hid/hid-playstation.c | 118 --
2 files changed, 119 deletions(-)
diff --git a/drivers/hid/Kconfig b/d
deal, they are still not pushed to Linus.
Signed-off-by: Roderick Colenbrander
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-playstation.c | 60 +--
1 file changed, 1 insertion(+), 59 deletions(-)
diff --git a/drivers/hid/hid-playstation.c b/drive
not a big deal, they are still not pushed to Linus.
Signed-off-by: Roderick Colenbrander
Signed-off-by: Benjamin Tissoires
---
drivers/hid/Kconfig | 2 -
drivers/hid/hid-playstation.c | 99 ---
2 files changed, 101 deletions(-)
diff --git a/drivers/hid
th the new version, we also revert
all patches on top of the LED ones.
This is not a big deal, they are still not pushed to Linus.
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-playstation.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-playstation.c
ker()` to match was was in linux-next
- removed an extra new line to match the current linux-next tree.
Cheers,
Benjamin
Benjamin Tissoires (2):
Revert "HID: playstation: fix unused variable in
ps_battery_get_property."
Revert "HID: playstation: report DualSense hardware and fi
Hi Nikolai,
On Mon, Feb 8, 2021 at 9:01 AM Nikolai Kostrigin wrote:
>
> ThinkPad L13 Gen2 has both touchpad and trackpoint.
> PNP: LEN2146 PNP0f13
> With the default protocol (elantech-smbus) trackpoint is not operating,
> while touchpad does. Changing to elantech renders both operational.
>
> Si
On Mon, Jan 18, 2021 at 2:45 PM Kai-Heng Feng
wrote:
>
> Palm ejection stops working on some Elan and Synaptics touchpad after
> commit 40d5bb87377a ("HID: multitouch: enable multi-input as a quirk for
> some devices").
>
> The commit changes the mt_class from MT_CLS_WIN_8 to
> MT_CLS_WIN_8_FORCE_
On Fri, Jan 15, 2021 at 6:07 PM Douglas Anderson wrote:
>
>
> The goal of this series is to support the Goodix GT7375P touchscreen.
> This touchscreen is special because it has power sequencing
> requirements that necessitate driving a reset GPIO.
>
> To do this, we totally rejigger the way i2c-hi
Hi,
On Mon, Jan 18, 2021 at 2:45 PM Kai-Heng Feng
wrote:
>
> Palm ejection stops working on some Elan and Synaptics touchpad after
> commit 40d5bb87377a ("HID: multitouch: enable multi-input as a quirk for
> some devices").
>
> The commit changes the mt_class from MT_CLS_WIN_8 to
> MT_CLS_WIN_8_F
Hi,
On Wed, Jan 13, 2021 at 8:35 PM Benjamin Tissoires
wrote:
On Wed, Jan 13, 2021 at 5:05 PM Doug Anderson wrote:
>
> Hi,
>
> On Wed, Jan 13, 2021 at 7:09 AM Benjamin Tissoires
> wrote:
> >
> > > I wanted to apply the series yesterday, but for these kinds of
> set but not used [-Wunused-but-set-variable]
>
> Cc: Dmitry Torokhov
> Cc: Henrik Rydberg
> Cc: Benjamin Tissoires
> Cc: linux-in...@vger.kernel.org
> Signed-off-by: Lee Jones
Reviewed-by: Benjamin Tissoires
Thanks for the cleanup :)
Cheers,
Benjamin
> ---
>
Hi Dmitry,
On Thu, Jan 14, 2021 at 7:24 AM Dmitry Torokhov
wrote:
>
> A typical USB keyboard usually splits its keys into several reports:
>
> - one for the basic alphanumeric keys, modifier keys, F keys, six pack
> keys and keypad. This report's application is normally listed as
> GenericDes
On Wed, Jan 13, 2021 at 5:05 PM Doug Anderson wrote:
>
> Hi,
>
> On Wed, Jan 13, 2021 at 7:09 AM Benjamin Tissoires
> wrote:
> >
> > > I wanted to apply the series yesterday, but for these kinds of changes
> > > I like giving it a spin on actual hardware.
On Fri, Jan 8, 2021 at 6:52 PM Benjamin Tissoires
wrote:
>
> Hi Doug,
>
> On Wed, Jan 6, 2021 at 2:35 AM Doug Anderson wrote:
> >
> > Benjamin,
> >
> > On Fri, Dec 11, 2020 at 2:24 PM Douglas Anderson
> > wrote:
> > >
> > > The goal
rtise false pressure.
>
> [1]
> https://docs.microsoft.com/en-us/windows-hardware/design/component-guidelines/windows-precision-touchpad-required-hid-top-level-collections#windows-precision-touchpad-input-reports
> [2] https://gitlab.freedesktop.org/libinput/libinput/-/issues/562
>
Hi Doug,
On Wed, Jan 6, 2021 at 2:35 AM Doug Anderson wrote:
>
> Benjamin,
>
> On Fri, Dec 11, 2020 at 2:24 PM Douglas Anderson
> wrote:
> >
> > The goal of this series is to support the Goodix GT7375P touchscreen.
> > This touchscreen is special because it has power sequencing
> > requirements
Hi Doug,
On Tue, Dec 1, 2020 at 10:12 PM Doug Anderson wrote:
>
> Hi,
>
> On Wed, Nov 11, 2020 at 4:41 PM Douglas Anderson
> wrote:
> >
> > The goal of this series is to support the Goodix GT7375P touchscreen.
> > This touchscreen is special because it has power sequencing
> > requirements that
ess_touch’:
> > drivers/input/touchscreen/surface3_spi.c:97:6: warning: variable
> > ‘timestamp’ set but not used [-Wunused-but-set-variable]
> >
> > Cc: Dmitry Torokhov
> > Cc: Henrik Rydberg
> > Cc: Benjamin Tissoires
> > Cc: linux-in...@vger.kernel.
e (in a separate commit as that is a behavioral
> >> change).
> >
> > I don't think this is the point of shutdown, but I could be corrected.
> > Shutdown isn't really supposed to be the same as driver remove or
> > anything. IIUC the main point of shutdo
Hat1Y as the HatDir is 0, even no DPAD
> buttons pressed. When you send HID report with D-DPAD buttons with
> different state, it doesn't generate any axis events because the HatDir
> internally is still 0 regardless the report value of the 4 DPAD usages.
That's the part I am
Hi,
On Tue, Nov 3, 2020 at 10:09 AM Hans de Goede wrote:
>
> Hi,
>
> On 11/3/20 2:46 AM, Rob Herring wrote:
> > On Mon, Nov 2, 2020 at 6:13 PM Douglas Anderson
> > wrote:
> >>
> >> This exports some things from i2c-hid so that we can have a driver
> >> that's effectively a subclass of it and th
Hi Chris,
On Sun, Nov 1, 2020 at 8:35 PM Chris Ye wrote:
>
> Generic Desktop DPAD usage is mapped by hid-input, that only the first
> DPAD usage maps to usage type EV_ABS and code of an axis. If HID
> descriptor has DPAD UP/DOWN/LEFT/RIGHT HID usages and each of usage size
> is 1 bit, then only
On Fri, Oct 30, 2020 at 7:00 PM Rob Herring wrote:
>
> On Fri, Oct 30, 2020 at 11:51:53AM +0100, Benjamin Tissoires wrote:
> > Hi Doug,
> >
> > Foreword: I was about to say "yeah, whatever" to please Rob for once.
>
> Read my other reply first... I t
Hi Doug,
On Sat, Oct 24, 2020 at 1:23 AM Douglas Anderson wrote:
>
> The Goodix GT7375P touchscreen uses i2c-hid so we can support it with
> just a few changes to the i2c-hid driver. Specifically this
> touchscreen needs to control a reset GPIO during its power sequencing.
>
> The Goodix timing
@@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/goodix,gt7375p.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Goodix GT7375P touchscreen
> +
>
Hi Doug,
Foreword: I was about to say "yeah, whatever" to please Rob for once.
But after re-reading this and more specifically patch 3 of the series,
that won't do. More comments inlined.
On Sat, Oct 24, 2020 at 1:23 AM Douglas Anderson wrote:
>
> As pointed out by Rob Herring [1], we should hav
...@vger.kernel.org # 5.3+
Signed-off-by: Benjamin Tissoires
---
drivers/input/mouse/elantech.c | 161 +++--
1 file changed, 91 insertions(+), 70 deletions(-)
diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index 90f8765f9efc..ff8e5fb61dab 100644
--- a
On Tue, Sep 1, 2020 at 11:52 AM Marc Zyngier wrote:
>
> When calling into hid_map_usage(), the passed event code is
> blindly stored as is, even if it doesn't fit in the associated bitmap.
>
> This event code can come from a variety of sources, including devices
> masquerading as input devices, on
On Thu, Aug 27, 2020 at 11:33 AM Jiri Kosina wrote:
>
> On Wed, 26 Aug 2020, Marc Zyngier wrote:
>
> > When calling into hid_map_usage(), the passed event code is
> > blindly stored as is, even if it doesn't fit in the associated bitmap.
> >
> > This event code can come from a variety of sources,
On Tue, Sep 1, 2020 at 10:14 AM Jiri Kosina wrote:
>
> On Sat, 29 Aug 2020, Marc Zyngier wrote:
>
> > It appears that a ReportSize value of zero is legal, even if a bit
> > non-sensical. Most of the HID code seems to handle that gracefully,
> > except when computing the total size in bytes. When f
seem to be in some presets.)
> > >
> > > This is based on the staging/hwmon tree.
> > >
> > > Signed-off-by: Marius Zachmann
> >
> > For my reference:
> >
> > Reviewed-by: Guenter Roeck
> >
> > Waiting for Ack from HID mai
Hi Marius,
On Wed, Jun 24, 2020 at 10:16 AM Marius Zachmann wrote:
>
> Signed-off-by: Marius Zachmann
I wasn't Cc-ed on the cover letter (0/3) if any, but there are a few
things to improve here (not code wise, I haven't reviewed the series,
but on the form).
Every commit needs a commit message
[adding Cristian, the author of the patch]
On Tue, Jun 23, 2020 at 2:37 AM Stephen Rothwell wrote:
>
> Hi all,
>
> On Sun, 21 Jun 2020 14:04:21 +1000 Stephen Rothwell
> wrote:
> >
> > After merging the hid tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> >
> > drive
On Mon, Jun 1, 2020 at 7:13 PM Jiri Kosina wrote:
>
> On Fri, 29 May 2020, Dmitry Torokhov wrote:
>
> > > > > > > usbhid tries to give the device 50 milliseconds to drain its
> > > > > > > queues
> > > > > > > when opening the device, but does it naively by simply sleeping
> > > > > > > in open
On Wed, May 27, 2020 at 11:24 AM Benjamin Tissoires
wrote:
>
> On Wed, May 27, 2020 at 8:19 AM Kai-Heng Feng
> wrote:
> >
> >
> >
> > > On May 26, 2020, at 16:43, Benjamin Tissoires
> > > wrote:
> > >
> > > On Tue, May 26, 2020 at
On Wed, May 27, 2020 at 11:22 AM Benjamin Tissoires
wrote:
>
> On Wed, May 27, 2020 at 8:18 AM Kai-Heng Feng
> wrote:
> >
> >
> >
> > > On May 26, 2020, at 23:07, Benjamin Tissoires
> > > wrote:
> > >
> > > Two touchpad/trackstick
On Wed, May 27, 2020 at 8:19 AM Kai-Heng Feng
wrote:
>
>
>
> > On May 26, 2020, at 16:43, Benjamin Tissoires
> > wrote:
> >
> > On Tue, May 26, 2020 at 10:24 AM Jiri Kosina wrote:
> >>
> >> On Tue, 14 Apr 2020, Kai-Heng Feng wrote:
> >&g
On Wed, May 27, 2020 at 8:18 AM Kai-Heng Feng
wrote:
>
>
>
> > On May 26, 2020, at 23:07, Benjamin Tissoires
> > wrote:
> >
> > Two touchpad/trackstick combos are currently not behaving properly.
> > They define a mouse emulation collection, as per W
for it, and manually add the 2 devices we know about.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=207235
Cc: sta...@vger.kernel.org
Signed-off-by: Benjamin Tissoires
---
drivers/hid/hid-multitouch.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/drivers/hid
On Tue, May 26, 2020 at 10:24 AM Jiri Kosina wrote:
>
> On Tue, 14 Apr 2020, Kai-Heng Feng wrote:
>
> > After commit c23e2043d5f7 ("HID: multitouch: do not filter mice nodes"),
> > MT_CLS_WIN_8 also supports mouse nodes, hence make MT_CLS_WIN_8_DUAL
> > redundant.
> >
> > Remove MT_CLS_WIN_8_DUAL
Hi Mazin
On Sun, Oct 20, 2019 at 6:43 AM Mazin Rezk wrote:
>
> This patch allows hidpp_report_is_connect_event to support
> WirelessDeviceStatus connect events.
>
> The WirelessDeviceStatus feature index is stored in hidpp_device when
> probed. The connect event's fap feature_index is compared ag
Hi Mazin,
On Sun, Oct 20, 2019 at 6:41 AM Mazin Rezk wrote:
>
> This patch allows short reports to be translated into long reports.
>
> hidpp_validate_device now returns a u8 instead of a bool which represents
> the supported reports. The corresponding bits (i.e.
> HIDPP_REPORT_*_SUPPORTED) are s
Hi Candle,
On Mon, Oct 21, 2019 at 9:54 AM Candle Sun wrote:
>
> Hi,
>
>
> On Mon, Oct 21, 2019 at 3:38 PM Candle Sun wrote:
> >
> > From: Candle Sun
> >
> > Upstream commit 58e75155009c ("HID: core: move Usage Page concatenation
> > to Main item") adds support for Usage Page item after Usage I
On Mon, Oct 14, 2019 at 8:36 PM Mazin Rezk wrote:
>
> This patch allows WirelessDeviceStatus (0x1d4b) events to be detected as
> connection events in the hid-logitech-hidpp module.
>
> Devices with HIDPP_QUIRK_WIRELESS_DEVICE_STATUS use WirelessDeviceStatus
> instead of traditional connect events.
Hi Mazin,
On Mon, Oct 14, 2019 at 8:36 PM Mazin Rezk wrote:
>
> This patch adds support for the MX Master (b01e and b012) and also adds
> foundational code for other Bluetooth LE HID++ devices to be added.
>
> Some devices do not support short reports and thus have a quirk
> (HIDPP_QUIRK_MISSING_
On Wed, Oct 16, 2019 at 5:12 PM Kai-Heng Feng
wrote:
>
> Runtime power management in i2c-hid brings lots of issues, such as:
> - When transitioning from display manager to desktop session, i2c-hid
> was closed and opened, so the device was set to SLEEP and ON in a short
> period. Vendors confirmed
y attempt to
> trun) as well as missing support for any FF action.
>
> Thanks,
> Andrey Smirnov
>
> Changes since [v2]:
>
> - Fixes a buggy validity check "HID: logitech-hidpp: rework
> device validation" as pointed out by Benjamin Tisso
On Wed, Oct 16, 2019 at 9:38 PM Andrey Smirnov wrote:
>
> On Wed, Oct 16, 2019 at 12:24 PM Benjamin Tissoires
> wrote:
> >
> > Hi Andrey,
> >
> > On Wed, Oct 16, 2019 at 8:30 PM Andrey Smirnov
> > wrote:
> > >
> >
ps://bugzilla.kernel.org/show_bug.cgi?id=204191
> Reported-by: Sam Bazely
> Signed-off-by: Andrey Smirnov
> Cc: Jiri Kosina
> Cc: Benjamin Tissoires
> Cc: Henrik Rydberg
> Cc: Pierre-Loup A. Griffais
> Cc: Austin Palmer
> Cc: linux-in.
On Sat, Oct 12, 2019 at 1:33 AM Andrey Smirnov wrote:
>
> On Fri, Oct 11, 2019 at 3:33 PM Benjamin Tissoires
> wrote:
> >
> > On Fri, Oct 11, 2019 at 9:39 PM Andrey Smirnov
> > wrote:
> > >
> > > On Fri, Oct 11, 2019 at 7:56 AM Benjamin Tissoire
On Sat, Oct 12, 2019 at 1:24 AM Dmitry Torokhov
wrote:
>
> On Sat, Oct 12, 2019 at 12:48:42AM +0200, Benjamin Tissoires wrote:
> > On Fri, Oct 11, 2019 at 11:34 PM Dmitry Torokhov
> > wrote:
> > >
> > > On Fri, Oct 11, 2019 at 01:35:09PM -0700, Dmitry Torokhov
gitech-hidpp.c:85:40: note: in expansion of macro
> > 'HIDPP_QUIRK_MISSING_SHORT_REPORTS'
> > #define HIDPP_QUIRK_CLASS_BLUETOOTH_LE HIDPP_QUIRK_MISSING_SHORT_REPORTS
> > ^~~~~
> > drivers//hid/hid-logitech-hidpp.c:3794:5: note: in expan
On Fri, Oct 11, 2019 at 11:34 PM Dmitry Torokhov
wrote:
>
> On Fri, Oct 11, 2019 at 01:35:09PM -0700, Dmitry Torokhov wrote:
> > On Fri, Oct 11, 2019 at 01:33:03PM -0700, Dmitry Torokhov wrote:
> > > On Fri, Oct 11, 2019 at 09:25:52PM +0200, Benjamin Tissoires wrote:
> &g
On Fri, Oct 11, 2019 at 10:33 PM Dmitry Torokhov
wrote:
>
> On Fri, Oct 11, 2019 at 09:25:52PM +0200, Benjamin Tissoires wrote:
> > On Fri, Oct 11, 2019 at 8:26 PM Dmitry Torokhov
> > wrote:
> > >
> > > On Fri, Oct 11, 2019 at 04:52:04PM +0200, Benjami
1 - 100 of 1123 matches
Mail list logo
