RE: [PATCH net-next] net/ncsi: support unaligned payload size in NC-SI cmd handler

ase of payload > > > > size is not 32-bit aligned). > > > > > > > > The checksum field follows payload field, without taking payload > > > > padding into account can cause checksum being truncated, leading to > > > > dropped packets. > &g

RE: [PATCH net-next] net/ncsi: support unaligned payload size in NC-SI cmd handler

nto account can cause checksum being truncated, leading to > > dropped packets. > > > > Signed-off-by: Ben Wei > > If you have to align and add padding, I do not see where you are > clearing out that padding memory to make sure it is initialized. > > You do compa

[PATCH net-next] net/ncsi: support unaligned payload size in NC-SI cmd handler

dropped packets. Signed-off-by: Ben Wei --- net/ncsi/ncsi-cmd.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c index 0187e65176c0..42636ed3cf3a 100644 --- a/net/ncsi/ncsi-cmd.c +++ b/net/ncsi/ncsi-cmd.c @@ -213,17

Re: [PATCH net-next] net/ncsi: add response handlers for PLDM over NC-SI

now, but can be passed > > back to user space via Netlink for further handling. > > > > Signed-off-by: Ben Wei > > I don't know why but patchwork puts part of your patch into the commit > message, see: > > https://urldefense.proofpoint.com/v2/url?u=https-3A_

[PATCH v2 net-next] net/ncsi: add response handlers for PLDM over NC-SI

rther handling. Signed-off-by: Ben Wei --- Changes in v2 - fix function definition spacing net/ncsi/ncsi-pkt.h | 5 + net/ncsi/ncsi-rsp.c | 11 +-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/net/ncsi/ncsi-pkt.h b/net/ncsi/ncsi-pkt.h index a8e9def593f2..80938b3

[PATCH net-next] net/ncsi: add response handlers for PLDM over NC-SI

rther handling. Signed-off-by: Ben Wei --- net/ncsi/ncsi-pkt.h | 5 + net/ncsi/ncsi-rsp.c | 11 +-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/net/ncsi/ncsi-pkt.h b/net/ncsi/ncsi-pkt.h index a8e9def593f2..80938b338fee 100644 --- a/net/ncsi/ncsi-pkt.h +++ b/net

[PATCH net-next] net/ncsi: update response packet length for GCPS/GNS/GNPTS commands

Update response packet length for the following commands per NC-SI spec - Get Controller Packet Statistics - Get NC-SI Statistics - Get NC-SI Pass-through Statistics command Signed-off-by: Ben Wei --- net/ncsi/ncsi-rsp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a

RE: [PATCH] net/ncsi: add control packet payload to NC-SI commands from netlink

> Hi Ben, > > > Hi Justin, > > > > > Hi Ben, > > > > > > I have similar fix locally with different approach as the command handler > > > may have some expectation for those byes. > > > We can use NCSI_PKT_CMD_OEM handler as it only copies data based on the > > > payload length. > > > > Great!

RE: [PATCH] net/ncsi: add control packet payload to NC-SI commands from netlink

Hi Justin, > Hi Ben, > > I have similar fix locally with different approach as the command handler may > have some expectation for those byes. > We can use NCSI_PKT_CMD_OEM handler as it only copies data based on the > payload length. Great! Yes I was thinking the same, we just need some way t

[PATCH] net/ncsi: add control packet payload to NC-SI commands from netlink

This patch adds support for NCSI_CMD_SEND_CMD netlink command to load packet data payload (up to 16 bytes) to standard NC-SI commands. Packet data will be loaded from NCSI_ATTR_DATA attribute similar to NC-SI OEM commands Signed-off-by: Ben Wei --- net/ncsi/internal.h | 7 --- net