[PATCH] HID: multitouch: fix calculation of last slot field in multi-touch reports

ouch: forward MSC_TIMESTAMP") Signed-off-by: Ben Chan --- drivers/hid/hid-multitouch.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index dad2fbb0e3f8..161551aab496 100644 --- a/drivers/hid/hid-multitouch.c

[PATCH 1/1] staging: skein: Delete a useless white space line

From: Kroderia Delete a useless white space line according to the coding style. Signed-off-by: Ben Chan --- drivers/staging/skein/skein_generic.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c index 85bd7d0

[PATCH] staging: gdm72xx: add help text to Kconfig

The descriptions are provided by GCT Semiconductor, Inc. Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/Kconfig | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig index dd8a391..5836503

Re: [PATCH] staging: gdm72xx: move T_CAPABILITY bit definitions to hci.h

On Tue, Jul 1, 2014 at 6:00 AM, Michalis Pappas wrote: > Signed-off-by: Michalis Pappas > --- > drivers/staging/gdm72xx/gdm_wimax.c | 10 +++--- > drivers/staging/gdm72xx/hci.h | 6 ++ > 2 files changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/gdm72xx/gdm_

[PATCH] staging: gdm72xx: clean up endianness conversions

annotations. Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_qos.c | 4 +-- drivers/staging/gdm72xx/gdm_sdio.c | 5 +-- drivers/staging/gdm72xx/gdm_usb.c | 12 +++ drivers/staging/gdm72xx/gdm_wimax.c | 64 +++-- drivers/staging/gdm72xx/gdm_wimax.h | 10

[PATCH v2] staging: gdm72xx: use consistent style for header guards

Signed-off-by: Ben Chan --- I forgot to add the Signed-off-by stanza in the original patch. drivers/staging/gdm72xx/gdm_qos.h | 6 +++--- drivers/staging/gdm72xx/gdm_sdio.h | 6 +++--- drivers/staging/gdm72xx/gdm_usb.h | 6 +++--- drivers/staging/gdm72xx/gdm_wimax.h | 6 +++--- drivers

[PATCH] staging: gdm72xx: use consistent style for header guards

--- drivers/staging/gdm72xx/gdm_qos.h | 6 +++--- drivers/staging/gdm72xx/gdm_sdio.h | 6 +++--- drivers/staging/gdm72xx/gdm_usb.h | 6 +++--- drivers/staging/gdm72xx/gdm_wimax.h | 6 +++--- drivers/staging/gdm72xx/hci.h | 6 +++--- drivers/staging/gdm72xx/netlink_k.h | 7 --- drive

[PATCH 4/4] staging: gdm72xx: use lower case for variable names for consistency

Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_qos.c | 38 +++--- drivers/staging/gdm72xx/gdm_qos.h | 2 +- 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c index

[PATCH 3/4] staging: gdm72xx: use int instead of u32 whenever makes sense

This patch addresses the following issues: - Use int instead of u32 whenever makes sense - Turn extract_qos_list() in gdm_qos.c, which previously always returned 0, into a void function. Reported-by: Dan Carpenter Reported-by: Michalis Pappas Signed-off-by: Ben Chan --- drivers/staging

[PATCH 1/4] staging: gdm72xx: return -EINVAL instead of BUG_ON for invalid data length

This patch changes gdm_usb_send() and gdm_sdio_send() to return -EINVAL instead of calling BUG_ON if an invalid data length is passed to the functions. Reported-by: Dan Carpenter Reported-by: Michalis Pappas Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_sdio.c | 3 ++- drivers

[PATCH 2/4] staging: gdm72xx: use bool instead of custom-defined BOOLEAN

Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_qos.c | 10 +- drivers/staging/gdm72xx/gdm_qos.h | 4 +--- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c index df6f000..732f009 100644 --- a

[PATCH] staging: gdm72xx: check return value of sscanf

Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_wimax.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c index e5e5115..3081fd4 100644 --- a/drivers/staging/gdm72xx/gdm_wimax.c +++ b

[PATCH] MIPS: ZBOOT: implement stack protector in compressed boot phase

This patch implements the stack protector code in MIPS compressed boot phase based on the same code added to arm in commit 8779657d29c0ebcc0c94ede4df2f497baf1b563f "stackprotector: Introduce CONFIG_CC_STACKPROTECTOR_STRONG" by Kees Cook Signed-off-by: Ben Chan Cc: Kees Cook Cc: Olof

[PATCH staging-next] staging: gdm72xx: fix block comment style

lines WARNING: networking block comments put the trailing */ on a separate line Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_sdio.c | 7 ++- drivers/staging/gdm72xx/gdm_usb.c | 6 ++ drivers/staging/gdm72xx/gdm_wimax.c | 5 +++-- drivers/staging/gdm72xx/hci.h | 4 +-

[PATCH staging-next] staging: gdm72xx: remove blank lines after an open brace

This patch fixes the following checkpatch warning: CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_usb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_usb.c b/drivers/

[PATCH net-next v4 2/2] net: cdc_ncm: respect operator preferred MTU reported by MBIM

h modifies cdc_ncm_setup to ensure that the MTU value set on the usbnet device does not exceed the operator preferred MTU indicated by wMTU if the MBIM device exposes a MBIM extended functional descriptor. Signed-off-by: Ben Chan --- drivers/net/usb/cdc_ncm.c | 17 + include

[PATCH net-next v4 0/2] adjust MTU as indicated by MBIM extended functional descriptor

tch 1/2 as suggested by David Miller v4: No code changes. Resubmitted as suggested by David Miller: - Added a summary of the patch set - Carried the ACK from Greg Kroah-Hartman - Added a specified the tree (net-next) to apply the patch set to Ben Chan (2): USB: cdc: add MBI

[PATCH net-next v4 1/2] USB: cdc: add MBIM extended functional descriptor structure

This patch adds the MBIM extended functional descriptor structure defined in "Universal Serial Bus Communications Class Subclass Specification for Mobile Broadband Interface Model, Revision 1.0, Errata-1" published by USB-IF. Signed-off-by: Ben Chan Acked-by: Greg Kroah-Hartman --

Re: [PATCH 2/2] net: cdc_ncm: respect operator preferred MTU reported by MBIM

On Mon, Mar 17, 2014 at 6:41 PM, David Miller wrote: > From: Ben Chan > Date: Mon, 17 Mar 2014 17:46:27 -0700 > >> Thanks again for the review and tip. I've submitted patch v2 to >> address the le16_to_cpu conversion. > > When you update a patch from a seri

[PATCH v3 1/2] USB: cdc: add MBIM extended functional descriptor structure

This patch adds the MBIM extended functional descriptor structure defined in "Universal Serial Bus Communications Class Subclass Specification for Mobile Broadband Interface Model, Revision 1.0, Errata-1" published by USB-IF. Signed-off-by: Ben Chan --- No changes from patch v1. in

[PATCH v3 2/2] net: cdc_ncm: respect operator preferred MTU reported by MBIM

h modifies cdc_ncm_setup to ensure that the MTU value set on the usbnet device does not exceed the operator preferred MTU indicated by wMTU if the MBIM device exposes a MBIM extended functional descriptor. Signed-off-by: Ben Chan --- Patch v3 (which is same as v2) adds the le16_to_cpu convers

Re: [PATCH 2/2] net: cdc_ncm: respect operator preferred MTU reported by MBIM

On Mon, Mar 17, 2014 at 2:27 PM, Bjørn Mork wrote: > > This sounds all reasonable to me. Thanks for taking the time to explain > it in such detail. I did know that some vendors set wMaxSegmentSize too > low, but had no idea that vendors were using the extended descriptor > instead of MBIM_CID_IP_

[PATCH v2 2/2] net: cdc_ncm: respect operator preferred MTU reported by MBIM

h modifies cdc_ncm_setup to ensure that the MTU value set on the usbnet device does not exceed the operator preferred MTU indicated by wMTU if the MBIM device exposes a MBIM extended functional descriptor. Signed-off-by: Ben Chan --- Patch v2 adds the le16_to_cpu conversion on ctx->mbim_extend

Re: [PATCH 2/2] net: cdc_ncm: respect operator preferred MTU reported by MBIM

On Mon, Mar 17, 2014 at 2:42 AM, Bjørn Mork wrote: > Is this *really* driver material, or should we just leave the IP MTU > hint handling up to the userspace management application? > > There are no less than 3(!) different ways for a device to specify the > MBIM MTU: > > 1) wMaxSegmentSize field

[PATCH 1/2] USB: cdc: add MBIM extended functional descriptor structure

This patch adds the MBIM extended functional descriptor structure defined in "Universal Serial Bus Communications Class Subclass Specification for Mobile Broadband Interface Model, Revision 1.0, Errata-1" published by USB-IF. Signed-off-by: Ben Chan --- include/uapi/linux/usb/

[PATCH 2/2] net: cdc_ncm: respect operator preferred MTU reported by MBIM

h modifies cdc_ncm_setup to ensure that the MTU value set on the usbnet device does not exceed the operator preferred MTU indicated by wMTU if the MBIM device exposes a MBIM extended functional descriptor. Signed-off-by: Ben Chan --- drivers/net/usb/cdc_ncm.c | 15 +++ include

[PATCH v2 2/2] staging: gdm72xx: fix typos in Kconfig

Signed-off-by: Ben Chan Cc: Sage Ahn --- drivers/staging/gdm72xx/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig index dd47bd1..dd8a391 100644 --- a/drivers/staging/gdm72xx/Kconfig +++ b/drivers

[PATCH v2 1/2] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

interface, either USB or MMC, is built as a module. This patch enforces that in the WIMAX_GDM72XX_USB and WIMAX_GDM72XX_SDIO dependency. Reported-by: Alan Stern Signed-off-by: Ben Chan Cc: Sage Ahn --- drivers/staging/gdm72xx/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

No worries. I've attached a revised patch to the original email thread, which includes Alan. Thanks again, Ben -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-i

Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

Nope... I didn't resend the patch but replied to the thread. Ben On Mon, Jun 3, 2013 at 11:18 AM, Ben Chan wrote: > Sorry, I meant to send the revised patch but got the wrong file. > > I'll add the Reported-by field. > > Thanks, > Ben > -- To unsubscrib

Re: [PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

Sorry, I meant to send the revised patch but got the wrong file. I'll add the Reported-by field. Thanks, Ben On Mon, Jun 3, 2013 at 10:48 AM, Greg Kroah-Hartman wrote: > On Mon, Jun 03, 2013 at 10:23:45AM -0700, Ben Chan wrote: >> The gdm72xx driver needs to have either t

[PATCH] staging: gdm72xx: WIMAX_GDM72XX should depend on either USB or MMC

The gdm72xx driver needs to have either the USB or SDIO implementation enabled to provide useful functionalities, so the driver should depend on either USB or MMC. Signed-off-by: Ben Chan Cc: Sage Ahn --- drivers/staging/gdm72xx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] staging: gdm72xx: fix unused variable warning in gdm_usb_send

This patch fixes an unused variable warning in gdm_usb_send (when CONFIG_WIMAX_GDM72XX_K_MODE=n), which was introduced in commit 1a276b80466bbd195cf94ec7178f68f2ab351467 (staging: gdm72xx: protect access of rx / tx structs). Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_usb.c |5

[PATCH] staging: gdm72xx: protect access of rx / tx structs

om [<8004a43c>] (kthread+0x9c/0xa8) <5>[ 4996.815270] [<8004a43c>] (kthread+0x9c/0xa8) from [<8000f160>] (kernel_thread_exit+0x0/0x8) <0>[ 4996.815295] Code: e92d4000 e8bd4000 e2800020 eb4ab9a1 (e5905000) Signed-off-by: Ben Chan Signed-off-by: Sameer Nanda --- drivers/stag

Re: [PATCH] drivers/staging/gdm72xx/gdm_sdio.c: Replace kmalloc+memset for kzalloc

FYI, a similar patch has already been applied: "staging: gdm72xx: simplify alloc_tx_struct and alloc_rx_struct (commit 129575f2a8958a1e90780b0d5b80702bb45b5aac)" Thanks, Ben On Mon, Sep 17, 2012 at 6:45 AM, Peter Senna Tschudin wrote: > Replace kmalloc+memset for kzalloc and cleanup related code

[PATCH] staging: gdm72xx: simplify alloc_tx_struct and alloc_rx_struct

This patch simplifies alloc_tx_struct and alloc_rx_struct in gdm_sdio.c and gdm_usb.c by replacing kmalloc+memset with kzalloc and reorganizing the code. Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_sdio.c | 30 drivers/staging/gdm72xx/gdm_usb.c | 44

Re: [PATCH v2] staging: gdm72xx: fix reference counting in gdm_wimax_event_init

Hi Dan, I manually walked through the driver code and spotted the issue. But this morning I was able to get an extra module to verify my patch on hardware. I tested the following patterns using two identical modules, and checked the creation/destruction/ref_cnt of wm_event: - insert module A, rem

Re: [PATCH v2] staging: gdm72xx: fix reference counting in gdm_wimax_event_init

Hi, Does patch v2 make sense? Thanks, Ben On Wed, Jul 25, 2012 at 6:53 AM, Ben Chan wrote: > Hi Devendra, > > Thanks for cleaning up the driver. If I understand the code > correctly, the original author wanted to initialize wm_event once and > reuse it for multiple devices, and

Re: [PATCH v2] staging: gdm72xx: fix reference counting in gdm_wimax_event_init

could be disposed even when there is an active device). Thanks, Ben On Tue, Jul 24, 2012 at 9:50 PM, devendra.aaru wrote: > On Tue, Jul 24, 2012 at 8:34 PM, Ben Chan wrote: >> This patch fixes the commit "staging/gdm72xx: cleanup little at >>

[PATCH v2] staging: gdm72xx: fix reference counting in gdm_wimax_event_init

This patch fixes the commit "staging/gdm72xx: cleanup little at gdm_wimax_event_rcv" (8df858ea76b76dde9a39d4edd9aaded983582cfe), which mishandles the reference counting of wm_event. Signed-off-by: Ben Chan --- Fixed the commit message as suggested by Dan Carpenter. drivers/stagi

[PATCH] staging: gdm72xx: fix reference counting in gdm_wimax_event_init

This patch fixes commit 8df858ea76b76dde9a39d4edd9aaded983582cfe, which mishandles the reference counting of wm_event. Signed-off-by: Ben Chan --- drivers/staging/gdm72xx/gdm_wimax.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gdm72xx