RE: [Openipmi-developer] [PATCH 9/12] IPMI: add pigeonpoint poweroff

2006-12-05 Thread Bela Lubkin
Corey Minyard wrote: > Randy Dunlap wrote: >> Randy Dunlap wrote: >>> Bela Lubkin wrote: >>>> Andrew Morton wrote: >>>> >>>>>> Sometime, please go through the IPMI code looking for all these >>>>>> statically-a

RE: [Openipmi-developer] [PATCH 9/12] IPMI: add pigeonpoint poweroff

2006-12-03 Thread Bela Lubkin
Randy Dunlap wrote: > Bela Lubkin wrote: >> Andrew Morton wrote: >> >>> Sometime, please go through the IPMI code looking for all these >>> statically-allocated things which are initialised to 0 or NULL and remove >>> all those intialisations? T

RE: [Openipmi-developer] [PATCH 11/12] IPMI: Fix BT long busy

2006-12-03 Thread Bela Lubkin
Andrew Morton wrote: > Corey Minyard <[EMAIL PROTECTED]> wrote: >> +BT_CONTROL(BT_CLR_WR_PTR); /* always reset */ > argh. >> #define BT_STATUSbt->io->inputb(bt->io, 0) >> #define BT_CONTROL(x)bt->io->outputb(bt->io, 0, x) >> >> #define BMC2HOST bt->io->inputb(bt->io, 1)

RE: [Openipmi-developer] [PATCH 9/12] IPMI: add pigeonpoint poweroff

2006-12-03 Thread Bela Lubkin
Andrew Morton wrote: > > Sometime, please go through the IPMI code looking for all these > > statically-allocated things which are initialised to 0 or NULL and remove > > all those intialisations? They're unneeded, they increase the vmlinux > > image size and there are quite a number of them. Th