Re: [PATCH] [v4] Input: Add "Select" button to Microsoft Xbox One controller.

2021-04-13 Thread Bastien Nocera
On Tue, 2021-04-13 at 01:02 +, Chris Ye wrote: > Add "Select" button input capability and input event mapping for > Microsoft Xbox One controller. From product site this is also > referred as > "Share" button. > Fixed Microsoft Xbox One controller select button not working under > USB > connect

Re: [PATCH] [v2] Input: Add "Share" button to Microsoft Xbox One controller.

2021-03-04 Thread Bastien Nocera
oth interface, which the HID > > > usage > > > is: > > > consumer 0xB2: > > > 0x05, 0x0C,    //   Usage Page (Consumer) > > > 0x0A, 0xB2, 0x00,  //   Usage (Record) > > > Microsoft wants the same key code to be generated cons

Re: [PATCH] [v2] Input: Add "Share" button to Microsoft Xbox One controller.

2021-03-02 Thread Bastien Nocera
On Thu, 2021-02-25 at 05:32 +, Chris Ye wrote: > Add "Share" button input capability and input event mapping for > Microsoft Xbox One controller. > Fixed Microsoft Xbox One controller share button not working under USB > connection. > > Signed-off-by: Chris Ye > --- >  drivers/input/joystick/

Re: linux-next: Signed-off-by missing for commit in the bluetooth tree

2021-01-26 Thread Bastien Nocera
add my Signed-off-by? Signed-off-by: Bastien Nocera Cheers

Re: [PATCH 0/2] Add support for Goodix GT9286 chip

2021-01-09 Thread Bastien Nocera
On Sat, 2021-01-09 at 14:55 +0100, AngeloGioacchino Del Regno wrote: > Add support for the GT9286 chip, tested on F(x)Tec Pro1 (MSM8998). Can you please add this test information to the commit message for the goodix.c patch? Feel free to add my: Reviewed-by: Bastien Nocera to both patches w

Re: [PATCH] HID: logitech-hidpp: add support for Unified Battery (1004) feature

2021-01-06 Thread Bastien Nocera
On Wed, 2021-01-06 at 18:48 +, Filipe Laíns wrote: > On Wed, 2021-01-06 at 10:34 +0100, Bastien Nocera wrote: > > On Mon, 2021-01-04 at 18:29 +, la...@archlinux.org wrote: > > > From: Filipe Laíns > > > > > > This new feature present in new devices

Re: [PATCH] HID: logitech-hidpp: add support for Unified Battery (1004) feature

2021-01-06 Thread Bastien Nocera
On Mon, 2021-01-04 at 18:29 +, la...@archlinux.org wrote: > From: Filipe Laíns > > This new feature present in new devices replaces the old Battery > Level > Status (0x1000) feature. It keeps essentially the same information > for > levels (reporting critical, low, good and full) but makes th

Re: How to enable auto-suspend by default

2020-11-24 Thread Bastien Nocera
On Wed, 2020-11-11 at 17:32 +0100, Greg KH wrote: > On Wed, Nov 11, 2020 at 04:03:30PM +, Limonciello, Mario wrote: > > > > > Given we're effectively ending up with the combination of > > > > > runtime PM turned > > > > > on by udev rules, do we need something like this for that ID: > > > > >

Re: How to enable auto-suspend by default

2020-11-24 Thread Bastien Nocera
On Tue, 2020-11-24 at 14:37 +0200, Mathias Nyman wrote: > > I don't think we are ready to enable runtime pm as default for all > Intel xHCI controllers. > The risk of xHCI not waking up when user plugs a mouse/keyboard, > making the system unusable > just seems too high compared to the powersaving

How to enable auto-suspend by default

2020-11-10 Thread Bastien Nocera
Hey, systemd has been shipping this script to enable auto-suspend on a number of USB and PCI devices: https://github.com/systemd/systemd/blob/master/tools/chromiumos/gen_autosuspend_rules.py The problem here is twofold. First, the list of devices is updated from ChromeOS, and the original list ob

Re: [External] Re: [PATCH] Documentation: Add documentation for new platform_profile sysfs attribute

2020-10-29 Thread Bastien Nocera
On Thu, 2020-10-29 at 10:46 +0100, Hans de Goede wrote: > < > > IMHO it does not belong in the sysfs API docs for the > platform_profile > stuff. But I guess it would be good to document it somewhere in some > generic syfs API rules/expectations document (with a note that their > might be excepti

Re: [PATCH] Documentation: Add documentation for new platform_profile sysfs attribute

2020-10-29 Thread Bastien Nocera
On Wed, 2020-10-28 at 18:23 +0100, Hans de Goede wrote: > > > It's not meaningless, but rather ambiguous. For a range of 1 to 5, > > is 1 > > high performance, and 5 low power, or vice-versa? > > It is meaningless because the space we are trying to describe with > the > profile-names is not 1 dim

Re: [PATCH] Documentation: Add documentation for new platform_profile sysfs attribute

2020-10-28 Thread Bastien Nocera
Hey Hans, Mark, On Tue, 2020-10-27 at 12:42 -0400, Mark Pearson wrote: > From: Hans de Goede > > On modern systems the platform performance, temperature, fan and > other > hardware related characteristics are often dynamically configurable. > The > profile is often automatically adjusted to the

Re: [RFC] Documentation: Add documentation for new performance_profile sysfs class

2020-10-07 Thread Bastien Nocera
On Wed, 2020-10-07 at 15:58 +, Limonciello, Mario wrote: >   > > On Mon, 2020-10-05 at 12:58 +, Limonciello, Mario wrote: > > > > On modern systems CPU/GPU/... performance is often dynamically > > > > configurable > > > > in the form of e.g. variable clock-speeds and TPD. The > > > > perfor

Re: [RFC] Documentation: Add documentation for new performance_profile sysfs class

2020-10-07 Thread Bastien Nocera
On Mon, 2020-10-05 at 12:58 +, Limonciello, Mario wrote: > > On modern systems CPU/GPU/... performance is often dynamically > > configurable > > in the form of e.g. variable clock-speeds and TPD. The performance > > is often > > automatically adjusted to the load by some automatic-mechanism > >

Re: [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist"

2020-10-04 Thread Bastien Nocera
On Sun, 2020-10-04 at 15:18 +0200, Greg Kroah-Hartman wrote: > On Sun, Oct 04, 2020 at 02:17:06PM +0200, Bastien Nocera wrote: > > On Sun, 2020-10-04 at 12:51 +0200, Greg Kroah-Hartman wrote: > > > On Sat, Oct 03, 2020 at 08:33:18PM +0200, Marcel Holtmann wrot

Re: [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist"

2020-10-04 Thread Bastien Nocera
On Sun, 2020-10-04 at 12:51 +0200, Greg Kroah-Hartman wrote: > On Sat, Oct 03, 2020 at 08:33:18PM +0200, Marcel Holtmann wrote: > > Hi Greg, > > > > > > > This reverts commit 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 > > > > > as it > > > > > breaks all bluetooth connections on my machine. > > > >

Re: [PATCH] HID: udraw-ps3: Replace HTTP links with HTTPS ones

2020-07-18 Thread Bastien Nocera
ent: > Replace HTTP with HTTPS. > > Signed-off-by: Alexander A. Klimov Looks good! Acked-by: Bastien Nocera

Re: [PATCH 3/3] platform/x86: thinkpad_acpi: Map Clipping tool hotkey to KEY_SELECTIVE_SCREENSHOT

2020-07-17 Thread Bastien Nocera
hotkey to the new > KEY_SELECTIVE_SCREENSHOT key-code. > > Signed-off-by: Hans de Goede Added 5 years ago for the Carbon X1 2014, and finally getting a keycode ;) Reviewed-by: Bastien Nocera > --- > drivers/platform/x86/thinkpad_acpi.c | 2 +- > 1 file changed, 1 insertion

Re: [PATCH 1/8] USB: rename USB quirk to USB_QUIRK_ENDPOINT_IGNORE

2020-06-19 Thread Bastien Nocera
On Fri, 2020-06-19 at 12:53 +0200, Hans de Goede wrote: > A note for future reference, not sure what you mean with driver > > API here. If you mean the in kernel API, the kernel rules are > > that we are always free to change that (Linux does not have a > > stable driver API). > > > > So if a

Re: [PATCH 1/8] USB: rename USB quirk to USB_QUIRK_ENDPOINT_IGNORE

2020-06-19 Thread Bastien Nocera
Jonathan Cox > Cc: Bastien Nocera > Cc: "Thiébaud Weksteen" > Cc: Nishad Kamdar > Signed-off-by: Greg Kroah-Hartman If the driver API change below is agreeable, you can add my: Reviewed-by: Bastien Nocera Good job. > diff --git a/include/linux/usb/quirks

Re: [PATCH v6] HID: sb0540: add support for Creative SB0540 IR receivers

2019-09-03 Thread Bastien Nocera
Hey, On Tue, 2019-07-02 at 10:39 +0200, Bastien Nocera wrote: > From: Bastien Nocera > > Add a new hid driver for the Creative SB0540 IR receiver. This > receiver > is usually coupled with an RM-1500 or an RM-1800 remote control. > > The scrollwheels on the RM-1800 rem

Re: [PATCH v5] hid-logitech-hidpp: read battery voltage from newer devices

2019-09-02 Thread Bastien Nocera
On Sat, 2019-08-31 at 13:56 -0400, Pedro Vanzella wrote: > Newer Logitech mice report their battery voltage through feature > 0x1001 > instead of the battery levels through feature 0x1000. > > When the device is brought up and we try to query the battery, figure > out if it supports the old or the

[PATCH v6] HID: sb0540: add support for Creative SB0540 IR receivers

2019-07-02 Thread Bastien Nocera
From: Bastien Nocera Add a new hid driver for the Creative SB0540 IR receiver. This receiver is usually coupled with an RM-1500 or an RM-1800 remote control. The scrollwheels on the RM-1800 remote are not bound, as they are labelled for specific audio controls that don't usually exist on

Re: [PATCH v5] HID: sb0540: add support for Creative SB0540 IR receivers

2019-07-02 Thread Bastien Nocera
On Tue, 2019-07-02 at 10:29 +0200, Benjamin Tissoires wrote: > drivers/hid/hid-creative-sb0540.c: In function > 'creative_sb0540_raw_event': > drivers/hid/hid-creative-sb0540.c:157:3: error: label 'out' used but > not defined > 157 | goto out; > | ^~~~ > > It would have been nice to at

Re: [PATCH v4] HID: sb0540: add support for Creative SB0540 IR receivers

2019-07-01 Thread Bastien Nocera
On Mon, 2019-07-01 at 12:15 +0200, Benjamin Tissoires wrote: > > I forgot to mention that sparse was complaining about: > > scripts/Makefile.build:283: target 'drivers/hid/hid-creative- > sb0540.c' > doesn't match the target pattern > > And it turns out your line should read `hid-creative-sb054

[PATCH v5] HID: sb0540: add support for Creative SB0540 IR receivers

2019-07-01 Thread Bastien Nocera
From: Bastien Nocera Add a new hid driver for the Creative SB0540 IR receiver. This receiver is usually coupled with an RM-1500 or an RM-1800 remote control. The scrollwheels on the RM-1800 remote are not bound, as they are labelled for specific audio controls that don't usually exist on

Re: [PATCH v3] HID: sb0540: add support for Creative SB0540 IR receivers

2019-07-01 Thread Bastien Nocera
On Mon, 2019-07-01 at 11:45 +0200, Benjamin Tissoires wrote: > Hi Bastien, > > On Wed, Jun 26, 2019 at 4:07 PM Bastien Nocera > wrote: > > From: Bastien Nocera > > > > Add a new hid driver for the Creative SB0540 IR receiver. This > > receiver > > i

[PATCH v4] HID: sb0540: add support for Creative SB0540 IR receivers

2019-07-01 Thread Bastien Nocera
From: Bastien Nocera Add a new hid driver for the Creative SB0540 IR receiver. This receiver is usually coupled with an RM-1500 or an RM-1800 remote control. The scrollwheels on the RM-1800 remote are not bound, as they are labelled for specific audio controls that don't usually exist on

[PATCH v3] HID: sb0540: add support for Creative SB0540 IR receivers

2019-06-26 Thread Bastien Nocera
From: Bastien Nocera Add a new hid driver for the Creative SB0540 IR receiver. This receiver is usually coupled with an RM-1500 or an RM-1800 remote control. The scrollwheels on the RM-1800 remote are not bound, as they are labelled for specific audio controls that don't usually exist on

Re: [PATCH] Revert "Bluetooth: Align minimum encryption key size for LE and BR/EDR connections"

2019-06-12 Thread Bastien Nocera
On Wed, 2019-06-12 at 09:07 +0200, Greg Kroah-Hartman wrote: > On Tue, Jun 11, 2019 at 11:36:26PM +0200, Marcel Holtmann wrote: > > Hi Vasily, > > > > > Can we get this revert merged into stable branches? Bluetooth HID > > > has > > > been broken for many devices for quite a while now and RFC patc

Re: [PATCH] staging: rtl8723bs: Fix Unneeded variable: "ret". Return "0"

2019-06-06 Thread Bastien Nocera
it Kukreti Looks good, thanks. Reviewed-by: Bastien Nocera

Re: [RFC v2] iio: input-bridge: optionally bridge iio acceleometers to create a /dev/input interface

2019-05-10 Thread Bastien Nocera
On Fri, 2019-05-10 at 11:33 +0200, H. Nikolaus Schaller wrote: > > > It does through "Input device name:" starting with "iio-bridge:" as > you can see in the commit message of [RFC v3]: This makes it ABI, right? Big fat warnings around the code that declares it would be appreciated.

Re: [RFC v2] iio: input-bridge: optionally bridge iio acceleometers to create a /dev/input interface

2019-05-10 Thread Bastien Nocera
On Sun, 2019-04-14 at 09:26 -0700, Roderick Colenbrander wrote: > > We at the time were one of the first to expose acceleration and gyro > data through /dev/input for DualShock 4 as supported by hid-sony. We > report acceleration in 'g' and angular velocity in 'degree / s'. We > set the resolutio

Re: [RFC v2] iio: input-bridge: optionally bridge iio acceleometers to create a /dev/input interface

2019-05-10 Thread Bastien Nocera
On Mon, 2019-04-22 at 15:20 +0100, Jonathan Cameron wrote: > > Different goals usually lead to different solution architectures. > > Indeed, but in this case we have your proposal which is a subset of > what > I am suggesting. One architecture can fulfil both requirements. > > I'll leave it for

Re: [RFC v3] iio: input-bridge: optionally bridge iio acceleometers to create a /dev/input interface

2019-05-10 Thread Bastien Nocera
On Tue, 2019-04-16 at 21:33 +0200, H. Nikolaus Schaller wrote: > Hi Bastien, > > > Am 16.04.2019 um 18:04 schrieb Bastien Nocera : > > This can be done in user-space, reading the data from the IIO driver, > > and using uinput to feed it back. Why is doing this at the

Re: [RFC v3] iio: input-bridge: optionally bridge iio acceleometers to create a /dev/input interface

2019-04-16 Thread Bastien Nocera
Having written a "bridge" myself (I called it a "proxy"[1]), I have a few comments. [1]: https://github.com/hadess/iio-sensor-proxy Let's start with the easy ones ;) there's a typo in the subject line. The subject line also says "optionally" but there doesn't seem to be any ways to disable the f

Re: [PATCH v2] input: goodix - support Goodix gt5688

2019-01-29 Thread Bastien Nocera
drivers/input/touchscreen/mediatek/GT5688 > > Signed-off-by: Guido Günther Not super fond of the casual commit message, but the code and explanation are fine. Reviewed-by: Bastien Nocera > --- > Changes from v1: > * Add tested board to commit message > > Documentation/de

Re: [PATCH] input: goodix - support Goodix gt5688

2019-01-29 Thread Bastien Nocera
On Tue, 2019-01-29 at 10:16 +0100, Guido Günther wrote: > Hi, > On Mon, Jan 28, 2019 at 07:24:33PM +0100, Bastien Nocera wrote: > > On Mon, 2019-01-28 at 18:03 +0100, Guido Günther wrote: > > > From what I've seen in vendor trees it's fine to treat this

Re: [PATCH] input: goodix - support Goodix gt5688

2019-01-28 Thread Bastien Nocera
On Mon, 2019-01-28 at 18:03 +0100, Guido Günther wrote: > From what I've seen in vendor trees it's fine to treat this as gt1x¹. > > [1]: > https://github.com/TadiT7/android_kernel_mtk-4.4/tree/master/drivers/input/touchscreen/mediatek/GT5688 Can you please point to the exact line of code that ma

Re: [PATCH] Input: goodix - decouple irq and reset lines

2019-01-07 Thread Bastien Nocera
On Mon, 2019-01-07 at 16:56 +0100, Bastien Nocera wrote: > Given that we do have access to the datasheet, it would also be > useful > for the patch to mention where in the datasheet it says that the > reset > line can be left pulled-up, or mention on which shipping device this >

Re: [PATCH] Input: goodix - decouple irq and reset lines

2019-01-07 Thread Bastien Nocera
On Sat, 2019-01-05 at 22:51 +, Dmitry Torokhov wrote: > Hi Alex, > > On Fri, Jan 04, 2019 at 05:00:48PM +0100, Alex Gonzalez wrote: > > The Goodix touch controller allows the use of two optional GPIOs > > (RESET > > and INT) to reset the touch controller, select the I2C address of > > the > >

XBox One S controller, Bluetooth support (was Re: hid: microsoft: Add rumble support for Xbox One S controller)

2018-09-26 Thread Bastien Nocera
(Resend to the correct Bluetooth list, sorry for the dupes) On Wed, 2018-09-26 at 15:45 +0200, Bastien Nocera wrote: > Hey Florian, > > On Wed, 2018-09-26 at 14:51 +0200, Dollinger Florian wrote: > > From: Florian Dollinger > > > > Hi there! Why do you re-engi

Re: AW: hid: microsoft: Add rumble support for Xbox One S controller

2018-09-26 Thread Bastien Nocera
On Wed, 2018-09-26 at 17:15 +0200, dollinger.flor...@gmx.de wrote: > Hey Bastien, > > > Probably because he didn't know about it, and how would he? > > Hum, it's the first hit when you search for something like 'xbox one > s driver linux' since half an year or longer 😊 Sure it is, but: - it's no

XBox One S controller, Bluetooth support (was Re: hid: microsoft: Add rumble support for Xbox One S controller)

2018-09-26 Thread Bastien Nocera
On Wed, 2018-09-26 at 15:45 +0200, Bastien Nocera wrote: > Hey Florian, > > On Wed, 2018-09-26 at 14:51 +0200, Dollinger Florian wrote: > > From: Florian Dollinger > > > > Hi there! Why do you re-engineer the wheel? :) There is already a > > fully funct

Re: hid: microsoft: Add rumble support for Xbox One S controller

2018-09-26 Thread Bastien Nocera
Hey Florian, On Wed, 2018-09-26 at 14:51 +0200, Dollinger Florian wrote: > From: Florian Dollinger > > Hi there! Why do you re-engineer the wheel? :) There is already a > fully functional and tested driver out there ( > https://github.com/atar-axis/xpadneo). Would be much easier to help > me (th

Re: [PATCH] hid: microsoft: Add rumble support for Xbox One S controller

2018-08-13 Thread Bastien Nocera
On Mon, 2018-08-13 at 07:37 -0700, Andrey Smirnov wrote: > On Fri, Aug 10, 2018 at 4:38 AM Bastien Nocera > wrote: > > > > On Thu, 2018-08-09 at 17:17 -0700, Andrey Smirnov wrote: > > > Add HID quirk driver for Xbox One S controller over bluetooth. > > > >

Re: [PATCH] hid: microsoft: Add rumble support for Xbox One S controller

2018-08-10 Thread Bastien Nocera
On Thu, 2018-08-09 at 17:17 -0700, Andrey Smirnov wrote: > Add HID quirk driver for Xbox One S controller over bluetooth. > > This driver only adds support for rumble. Standard controller > functionality is exposed by default HID driver. Did you manage to make the joypad work without hacks in the

Re: staging: rtl8723bs: bug or pointless if else ?

2018-06-28 Thread Bastien Nocera
On Thu, 2018-06-28 at 10:22 +0200, Hans de Goede wrote: > Hi, > > On 28-06-18 09:43, Michael Straube wrote: > > Hi, > > > > I stumbled upon the following if else construct in > > drivers/staging/rtl8723bs/os_dep/sdio_intf.c:618 > > > > if (pwrpriv->bInternalAutoSuspend) > > { >

Re: [PATCH 1/2] platform/x86: asus-wmi: Call new led hw_changed API on kbd brightness change

2018-06-05 Thread Bastien Nocera
On Tue, 2018-06-05 at 12:05 +0200, Hans de Goede wrote: > Hi, > > On 05-06-18 11:58, Bastien Nocera wrote: > > On Tue, 2018-06-05 at 09:37 +0200, Hans de Goede wrote: > > > Hi, > > > > > > On 05-06-18 05:18, Chris Chiu wrote: > > > > O

Re: [PATCH 1/2] platform/x86: asus-wmi: Call new led hw_changed API on kbd brightness change

2018-06-05 Thread Bastien Nocera
> right keyboard events and export a led interface and then > > > > > > userspace > > > > > > will do the right thing (and be able to offer flexible > > > > > > policies > > > > > > to the user). > > > > >

Re: [PATCH][staging-next] staging: rtl8723bs: spelling mistake: "dismatch" -> "mismatch"

2018-04-30 Thread Bastien Nocera
On Mon, 2018-04-30 at 15:19 +0100, Colin King wrote: > + P2P_STATE_RECV_INVITE_REQ_DISMATCH = > 17,/* receiving the P2P Inviation request and mismatch > with the profile. */ Might as well fix the "inviation" as well, no? :) Thanks

Re: [PATCH] Resolve RF Type mismatch

2018-02-06 Thread Bastien Nocera
On Wed, 2018-02-07 at 00:57 +0900, Kangmin Park wrote: > From: pr0gr4m This needs a commit message. I don't understand what the code is trying to do.

Re: [RFC PATCH] input: Add disable sysfs entry for every input device

2018-01-02 Thread Bastien Nocera
On Tue, 2018-01-02 at 22:54 +0100, Pali Rohár wrote: > On Wednesday 04 January 2017 15:37:35 Bastien Nocera wrote: > > I don't doubt that the use cases should be catered for, I > > essentially > > did that same work without kernel changes for GNOME. What I doubt > >

Re: [RFC PATCH] input: Add disable sysfs entry for every input device

2018-01-02 Thread Bastien Nocera
On Tue, 2018-01-02 at 22:48 +0100, Pali Rohár wrote: > On Tuesday 03 January 2017 12:21:21 Bastien Nocera wrote: > > On Mon, 2017-01-02 at 18:09 +0100, Pali Rohár wrote: > > > On Monday 02 January 2017 16:27:05 Bastien Nocera wrote: > > > > On Sun, 2016-12-25 at

Re: [RFC PATCH] input: Add disable sysfs entry for every input device

2018-01-02 Thread Bastien Nocera
On Tue, 2017-01-17 at 12:07 +0100, Pavel Machek wrote: > > We'd really like it to work on plain old text console, too, because > that's what > I'm using on n900, and with old maemo userspace, because that's what > everyone > else uses. > > You mentioned you think X.org can do this kind of device

Re: [PATCH] Bluettoth: btusb: Prevent USB devices to autosuspend while setting interface

2017-11-15 Thread Bastien Nocera
On Wed, 2017-11-15 at 14:54 +0100, Marcel Holtmann wrote: > Hi Abhijeet, > > > Runtime resume USB device in order to ensure that PM framework > > knows > > that the we might be using the device in a short time and doesn't > > autosuspend the device while we update it's interface. > > > > Signed-o

Re: [PATCH v2 4/5] platform/x86: intel-vbtn: support KEY_ROTATE_LOCK_TOGGLE

2017-11-09 Thread Bastien Nocera
On Fri, 2017-11-10 at 01:15 +0100, Stefan Brüns wrote: > On Friday, November 10, 2017 12:30:46 AM CET Bastien Nocera wrote: > > On Thu, 2017-11-09 at 23:44 +0100, Stefan Brüns wrote: > > > The Rotate Lock button event is emitted on the XPS 12 (BIOS A8, > > > but

Re: [PATCH v2 5/5] platform/x86: intel-vbtn: support panel front button

2017-11-09 Thread Bastien Nocera
On Thu, 2017-11-09 at 23:44 +0100, Stefan Brüns wrote: > The Lenovo Helix 2 and Dell XPS 12 (9Q33) have an extra button on the > front showing a 'Windows' logo, both reporting event codes 0xC2/0xC3 > on press/release. On the Dell, both press/release are distinct events > while on the Helix 2 both e

Re: [PATCH v2 3/5] Input: add KEY_ROTATE_LOCK_TOGGLE

2017-11-09 Thread Bastien Nocera
On Thu, 2017-11-09 at 23:44 +0100, Stefan Brüns wrote: > The key has the same use as the SW_ROTATE_LOCK, but is used on > devices > where the state is not tracked by the hardware but has to be handled > in software. I'll let the input and hid subsystem maintainers have the final say here, though I

Re: [PATCH v2 4/5] platform/x86: intel-vbtn: support KEY_ROTATE_LOCK_TOGGLE

2017-11-09 Thread Bastien Nocera
On Thu, 2017-11-09 at 23:44 +0100, Stefan Brüns wrote: > The Rotate Lock button event is emitted on the XPS 12 (BIOS A8, but > not > on BIOS A2). > > Signed-off-by: Stefan Brüns > --- > > Changes in v2: > - Emit KEY_ROTATE_LOCK_TOGGLE instead of KEY_ROTATE_DISPLAY > - Use separate up/down events

[PATCH] HID: sony: Fix SHANWAN pad rumbling on USB

2017-11-07 Thread Bastien Nocera
motors aren't started on plug. Signed-off-by: Bastien Nocera --- drivers/hid/hid-sony.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c index d03203a82e8f..b9dc3ac4d4aa 100644 --- a/drivers/hid/hid-sony.c

Re: [PATCH 0/4] platform/x86: intel-vbtn: Add support for several more switches/buttons

2017-11-06 Thread Bastien Nocera
On Mon, 2017-11-06 at 15:25 +, Brüns, Stefan wrote: > On Montag, 6. November 2017 13:54:25 CET Bastien Nocera wrote: > > On Sun, 2017-11-05 at 14:31 +0200, Andy Shevchenko wrote: > > > On Fri, Nov 3, 2017 at 9:03 PM, Stefan Brüns > > > > > > wrote: > &g

Re: [PATCH 0/4] platform/x86: intel-vbtn: Add support for several more switches/buttons

2017-11-06 Thread Bastien Nocera
On Sun, 2017-11-05 at 14:31 +0200, Andy Shevchenko wrote: > On Fri, Nov 3, 2017 at 9:03 PM, Stefan Brüns > wrote: > > Currently, intel-vbtn only supports the most relevant buttons, > > although > > there are several more events, mostly in use by convertibles. > > > > This series adds support for

Re: [PATCH 0/4] platform/x86: intel-vbtn: Add support for several more switches/buttons

2017-11-06 Thread Bastien Nocera
On Sun, 2017-11-05 at 14:31 +0200, Andy Shevchenko wrote: > On Fri, Nov 3, 2017 at 9:03 PM, Stefan Brüns > wrote: > > Currently, intel-vbtn only supports the most relevant buttons, > > although > > there are several more events, mostly in use by convertibles. > > > > This series adds support for

Re: [PATCH] fbdev: Fix typo in vfb comment

2017-10-12 Thread Bastien Nocera
On Thu, 2017-10-12 at 15:31 +0200, Jiri Kosina wrote: > On Tue, 20 Jun 2017, Bastien Nocera wrote: > > > Signed-off-by: Bastien Nocera > > --- > > drivers/video/fbdev/vfb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a

Re: [PATCH v3] Input: goodix: Add support for capacitive home button

2017-09-06 Thread Bastien Nocera
Hey, On Tue, 2017-06-20 at 18:08 +0200, Bastien Nocera wrote: > From: "Sergei A. Trusov" > > On some x86 tablets with a Goodix touchscreen, the Windows logo on > the > front is a capacitive home button. Touching this button results in a > touch > with bit 4 of the

Re: [RFT][PATCH] iio: hid-sensor-trigger: Fix the race with user space powering up sensors

2017-08-12 Thread Bastien Nocera
On Sat, 2017-08-12 at 13:16 +0100, Jonathan Cameron wrote: > On Fri, 11 Aug 2017 16:04:30 +0200 > Bastien Nocera wrote: > > > Woot! > > > > On Thu, 2017-08-10 at 16:24 -0700, Srinivas Pandruvada wrote: > > > It has been reported for a while that wit

Re: [RFT][PATCH] iio: hid-sensor-trigger: Fix the race with user space powering up sensors

2017-08-11 Thread Bastien Nocera
if the iio-sensor-proxy starts immediately it will > still work as the sensors are ON. > - Also move the autosuspend delay to place when user requested turn off > of sensors, like after user finished raw read or buffer disable > > Signed-off-by: Srinivas Pandruvada Tested-by: Bas

Re: [PATCH] HID: Add quirk for Lenovo Yoga 910 with ITE Chips

2017-07-17 Thread Bastien Nocera
On Mon, 2017-07-17 at 13:19 -0700, Srinivas Pandruvada wrote: > On Sat, 2017-07-15 at 22:05 +0200, Patrick wrote: > > On Sat, Jul 15, 2017 at 07:58:10PM +0200, Bastien Nocera wrote: > > > > > > On Sat, 2017-07-15 at 19:52 +0200, Patrick Pedersen wrote: > > >

Re: [PATCH] mfd: intel_soc_pmic_crc: Uniquify device name

2017-07-17 Thread Bastien Nocera
On Mon, 2017-07-17 at 12:58 +0100, Lee Jones wrote: > The commit log should not be empty. Fair. > Please provide information as to why this change is required, etc. SSIA. I also sent another patch to the same addresses labelled: [PATCH] gpio: crystalcove: Uniquify driver name

Re: [PATCH] HID: Add quirk for Lenovo Yoga 910 with ITE Chips

2017-07-15 Thread Bastien Nocera
On Sat, 2017-07-15 at 19:52 +0200, Patrick Pedersen wrote: > On Sat, Jul 15, 2017 at 4:29 PM, Bastien Nocera > wrote: > > On Sat, 2017-07-15 at 14:27 +0200, Patrick Pedersen wrote: > > > As with previous generations of this device (see https://patchwor > > k.ke > >

Re: [PATCH] HID: Add quirk for Lenovo Yoga 910 with ITE Chips

2017-07-15 Thread Bastien Nocera
On Sat, 2017-07-15 at 14:27 +0200, Patrick Pedersen wrote: > As with previous generations of this device (see https://patchwork.ke > rnel.org/patch/7887361/), the ITE > HID Sensor Hub, responsible for the accelerometer and als sensor, > requires a quirk entry. > > Without the entry, the Sensor Hub

Re: Spurious touchpad events with closed LID

2017-06-29 Thread Bastien Nocera
On Thu, 2017-06-29 at 09:31 +0200, Pali Rohár wrote: > On Thursday 29 June 2017 00:44:27 Bastien Nocera wrote: > > On Wed, 2017-06-28 at 22:15 +0200, Pavel Machek wrote: > > > > > > > > > > While policy normally belongs to userspace, I'd argue this is

Re: Spurious touchpad events with closed LID

2017-06-28 Thread Bastien Nocera
On Wed, 2017-06-28 at 22:15 +0200, Pavel Machek wrote: > > While policy normally belongs to userspace, I'd argue this is > workaround for a hardware bug, and in-kernel solution would be > acceptable. > > Anyway, disable attribute would be nice first step. It's already fixed for those of us on r

Re: [systemd-devel] [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI

2017-06-21 Thread Bastien Nocera
On Tue, 2017-06-20 at 02:45 +, Zheng, Lv wrote: > Hi, > > > From: Bastien Nocera [mailto:had...@hadess.net] > > Subject: Re: [systemd-devel] [WIP PATCH 0/4] Rework the unreliable > > LID switch exported by ACPI > > > > On Mon, 2017-0

[PATCH] mfd: intel_soc_pmic_crc: Uniquify device name

2017-06-20 Thread Bastien Nocera
--- drivers/mfd/intel_soc_pmic_crc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd/intel_soc_pmic_crc.c index 4a7494872da2..f47dadaf644c 100644 --- a/drivers/mfd/intel_soc_pmic_crc.c +++ b/drivers/mfd/intel_soc_pmic_crc.c @@ -147

[PATCH] gpio: crystalcove: Uniquify driver name

2017-06-20 Thread Bastien Nocera
--- drivers/gpio/gpio-crystalcove.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-crystalcove.c b/drivers/gpio/gpio-crystalcove.c index e60156ec0c18..4fb400150b03 100644 --- a/drivers/gpio/gpio-crystalcove.c +++ b/drivers/gpio/gpio-crystalcove.c @@ -267,7 +2

[PATCH] usb: plusb: Fix typo in Prolific's company name

2017-06-20 Thread Bastien Nocera
Signed-off-by: Bastien Nocera --- drivers/net/usb/plusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/plusb.c b/drivers/net/usb/plusb.c index 6fe59373cba9..f76c4947ed2b 100644 --- a/drivers/net/usb/plusb.c +++ b/drivers/net/usb/plusb.c @@ -112,7 +112,7

[PATCH] fbdev: Fix typo in vfb comment

2017-06-20 Thread Bastien Nocera
Signed-off-by: Bastien Nocera --- drivers/video/fbdev/vfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/vfb.c b/drivers/video/fbdev/vfb.c index da653a080394..59cd17bd9de6 100644 --- a/drivers/video/fbdev/vfb.c +++ b/drivers/video/fbdev/vfb.c @@ -374,7

[PATCH] MAINTAINERS: Correct path to uDraw PS3 driver

2017-06-20 Thread Bastien Nocera
Signed-off-by: Bastien Nocera --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 09b5ab6a8a5c..f4ac911eb7b4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13066,7 +13066,7 @@ UDRAW TABLET M: Bastien Nocera L: linux-in

[PATCH v5] HID: Add driver for Retrode2 joypad adapter

2017-06-20 Thread Bastien Nocera
SNES (Mario Paint) Mouse. Signed-off-by: Bastien Nocera --- New in v5: - Rebased - Mask out SNES mouse's middle button New in v4: - Add guard around special Retrode driver, so it still works as it used to if the driver isn't compiled in New in v3: - Use devm_kasprintf() - Return

[PATCH v3] Input: goodix: Add support for capacitive home button

2017-06-20 Thread Bastien Nocera
ergei A. Trusov Acked-by: Bastien Nocera --- Changes from v2: - commit message fixes - use BIT(4) instead of 0x10 drivers/input/touchscreen/goodix.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c index 2

Re: [PATCH] input: goodix: Poll the 'buffer status' bit before reading data

2017-06-19 Thread Bastien Nocera
Hey, Sorry I took this long to look into this. On Thu, 2017-03-30 at 15:33 +0200, Paul Cercueil wrote: > The Goodix panel triggers an interrupt on touch events. However, its > registers will contain the valid values a short time after the > interrupt, and not when it's raised. At that moment, the

Re: [systemd-devel] [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI

2017-06-19 Thread Bastien Nocera
On Mon, 2017-06-19 at 01:43 +, Zheng, Lv wrote: > > > > > If you implement it in such a way that GNOME settings daemon > > behaves weirdly, you'll get my revert > > request in the mail. Do. Not. Ever. Lie. > > First, I don't know what should be reverted... > I have 2 solutions here for revie

Re: [systemd-devel] [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI

2017-06-16 Thread Bastien Nocera
> On 16 Jun 2017, at 10:53, Zheng, Lv wrote: > > Hi, > >> From: Benjamin Tissoires [mailto:benjamin.tissoi...@redhat.com] >> Subject: Re: [systemd-devel] [WIP PATCH 0/4] Rework the unreliable LID >> switch exported by ACPI >> >>> On Jun 16 2017 or thereabouts, Zheng, Lv wrote: >>> Hi, Benjam

Re: [PATCH v3 00/19] Report power supply from hid-logitech-hidpp

2017-06-06 Thread Bastien Nocera
On Tue, 2017-06-06 at 09:25 +0200, Benjamin Tissoires wrote: > > Well, as Bastien said, the issue is that old user space is buggy, and > even if we postpone the switch to 4.13, there will always be someone > who > did not updated upower and who will complain. > > As soon as I started the develop

Re: [PATCH v3 00/19] Report power supply from hid-logitech-hidpp

2017-06-05 Thread Bastien Nocera
On Mon, 2017-06-05 at 07:53 -0700, Dave Hansen wrote: > On 06/05/2017 06:09 AM, Bastien Nocera wrote: > > > I agree with Dave. If there is no solution found in time for > > > -rc5, > > > reverting to previous state would be the proper way to go. > >

Re: [PATCH v3 00/19] Report power supply from hid-logitech-hidpp

2017-06-05 Thread Bastien Nocera
On Mon, 2017-06-05 at 10:01 +0200, Jiri Kosina wrote: > On Fri, 2 Jun 2017, Dave Hansen wrote: > > > > > > > This will allow upower to not handle those devices anymore > > > > > > and to > > > > > > have more > > > > > > immediate reportng of the device to the system. > > > > > > > > > > FWIW, I'

Re: [PATCH v3 00/19] Report power supply from hid-logitech-hidpp

2017-06-02 Thread Bastien Nocera
On Fri, 2017-06-02 at 09:29 +0200, Benjamin Tissoires wrote: > > Bastien, is is possible to have a simple udev rule that tells upower > to > ignore the battery device if builtin_power_supply is there? > That way we can tell people running old upower to use this to be sure > to > ignore the kernel

Re: [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI

2017-06-01 Thread Bastien Nocera
On Thu, 2017-06-01 at 20:46 +0200, Benjamin Tissoires wrote: > Hi, > > Sending this as a WIP as it still need a few changes, but it mostly > works as > expected (still not fully compliant yet). > > So this is based on Lennart's comment in [1]: if the LID state is not > reliable, > the kernel shou

Re: [PATCH v3 00/19] Report power supply from hid-logitech-hidpp

2017-06-01 Thread Bastien Nocera
On Thu, 2017-06-01 at 11:06 -0700, Dave Hansen wrote: > On 03/27/2017 07:59 AM, Benjamin Tissoires wrote: > > this is finally a rework of the series that provides kernel > > power_supply > > for hidpp devices. > > > > This will allow upower to not handle those devices anymore and to > > have more

Re: [PATCH] macintosh: move mac_hid driver to input/mouse.

2017-05-28 Thread Bastien Nocera
On Sun, 2017-05-28 at 11:47 +0200, Michal Suchanek wrote: > On Tue, 9 May 2017 17:43:27 -0700 > Dmitry Torokhov wrote: > > > Hi Michal, > > > > On Tue, May 09, 2017 at 09:14:18PM +0200, Michal Suchanek wrote: > > > There is nothing mac-specific about this driver. Non-mac hardware > > > with subo

Re: [PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as conditional

2017-05-06 Thread Bastien Nocera
On Fri, 2017-05-05 at 16:10 -0600, Justin Vreeland wrote: > > Sorry about blank email. > > I'm not 100% happy with it either.  Larry Finger suggested to fix the > overly long lines so I tried to find a decent way to shorten them.  I > think the best way would be to change the function names or p

Re: [PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as conditional

2017-05-04 Thread Bastien Nocera
On Mon, 2017-05-01 at 18:52 -0600, Justin Vreeland wrote: > Ensure checkpatch compliance > > > Signed-off-by: Justin Vreeland > --- > v2: >   - Added commit message >   - Fixed overly long lines > >  drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 18 -- >  drivers/staging/rtl87

Re: [PATCH v2 0/7] staging: rtl8732: Various checkpatch fixes

2017-05-04 Thread Bastien Nocera
ntical. > > Justin Vreeland (7): >   staging: rtl8723bs: Fix initialization of static variables >   staging: rtl8723bs: Wrap multi-line macros in do-while loop You can add: Reviewed-by: Bastien Nocera for those 2. Cheers

Re: [PATCH v2 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses

2017-05-04 Thread Bastien Nocera
*/ This does line up when applied, right? If so: Reviewed-by: Bastien Nocera

Re: [PATCH v5] Input: psxpad-spi - Add PSX (Play Station 1/2) pad SPI driver

2017-04-29 Thread Bastien Nocera
Hey, On Sat, 2017-04-29 at 11:16 -0700, Dmitry Torokhov wrote: > "Say Y here if you wish to connect PSX (PS1/2) pad via SPI > interface." It should say "PlayStation 1/2 joypads". Using "Play Station" is incorrect, PSX is a code name so you could mention it in between brackets. Saying "pads" is al

Re: [PATCH 0/7] staging: rtl8732: Various checkpatch fixes

2017-04-28 Thread Bastien Nocera
On Thu, 2017-04-27 at 18:09 -0600, Justin Vreeland wrote: > Justin Vreeland (7): > >   staging: rtl8723bs: Fix pointer style >   staging: rtl8723bs: Fix spacing around '<' >   staging: rtl8723bs: Do not use assignment in if condition You can add: Reviewed-By: Bast

Re: [PATCH v3 00/19] Report power supply from hid-logitech-hidpp

2017-03-27 Thread Bastien Nocera
On Mon, 2017-03-27 at 16:59 +0200, Benjamin Tissoires wrote: > Hi, > > this is finally a rework of the series that provides kernel > power_supply > for hidpp devices. > > This will allow upower to not handle those devices anymore and to > have more > immediate reportng of the device to the system

  1   2   3   4   >