Re: [PATCH] thermal/int340x_thermal: Prevent page fault on .set_mode() op

2020-07-09 Thread Bartosz Szczepanek
y the above fix, or rather revert the driver to its default behaviour of using uuid=0 if it wasn't set from userspace (this is how it was before Matthew's commit). What do you think? Best regards, Bartosz On Wed, Jul 8, 2020 at 3:46 PM Bartosz Szczepanek wrote: > > Starting

[PATCH] thermal/int340x_thermal: Prevent page fault on .set_mode() op

2020-07-08 Thread Bartosz Szczepanek
at index -1. This commit adds a check on uuid value to int3400_thermal_run_osc. Signed-off-by: Bartosz Szczepanek --- drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/intel/int340x_thermal/int3400_th

Re: [PATCH -next] efi/tpm: fix a compilation warning

2019-06-13 Thread Bartosz Szczepanek
On Thu, Jun 13, 2019 at 10:55 AM Arnd Bergmann wrote: > > - efi.tpm_final_log is a physical address that gets passed into > memremap() to return a pointer > - tpm2_calc_event_log_size() takes a pointer argument and > dereferences it. Where does it? It's passed with some added offset to __calc

Re: [PATCH -next] efi/tpm: fix a compilation warning

2019-06-13 Thread Bartosz Szczepanek
On Thu, Jun 13, 2019 at 2:40 PM Arnd Bergmann wrote: > > Would it be correct to change that to 'false' then (or completely remove > the additional remap, given that the other two callers pass false > already) and pass final_tbl? The problem is that we don't know the final_tbl size before running

Re: [PATCH V5 2/4] tpm: Reserve the TPM final events table

2019-05-06 Thread Bartosz Szczepanek
Nope, it doesn't work. It compiled (after correcting one more leftover mapping), but panicked the same way. I've came up with a set of changes that make it working in my setup, see attached patch. There was a problem with passing already remapped address to tpm2_calc_event_log_size(), which tried

Re: [PATCH V5 2/4] tpm: Reserve the TPM final events table

2019-05-01 Thread Bartosz Szczepanek
Second patch tries to unmap "mapping" which is not declared. I'm on top of jjs/master and your TPM_MEMREMAP patches are already there, so the first patch applied cleanly. Using it, kernel still panicked on boot: EFI stub: Booting Linux Kernel... EFI stub: EFI_RNG_PROTOCOL unavailable, no randomnes

Re: [PATCH 4/5] efi/libstub/tpm: Retrieve TPM event log in 2.0 format

2019-02-13 Thread Bartosz Szczepanek
On Wed, Feb 13, 2019 at 12:26 PM Jarkko Sakkinen wrote: > Collides with Matthew's changes. I want to land those change first > because they are almost production ready. > > Maybe you should consider reviewing those changes to make sure that > they make sense to you so that you can build these on t