Hi there
Let me add my two cents on the Toshiba side.
2018-06-04 8:23 GMT-06:00 Hans de Goede :
>
> 1) drivers/platform/x86/toshiba_acpi.c
>
> I don't know how the key on Toshiba's behaves on models where
> it is hardwired / under Windows
With Toshiba we have two types of hardware implementatio
Hi Darren,
2016-10-19 14:26 GMT-06:00 Darren Hart :
> On Wed, Oct 12, 2016 at 10:26:43AM -0600, Azael Avalos wrote:
>> *ping*
>>
>> 2016-08-28 11:00 GMT-06:00 Darren Hart :
>> > On Thu, Aug 25, 2016 at 12:50:55PM -0600, Azael Avalos wrote:
>> >> Bug 15
*ping*
2016-08-28 11:00 GMT-06:00 Darren Hart :
> On Thu, Aug 25, 2016 at 12:50:55PM -0600, Azael Avalos wrote:
>> Bug 150611 uncovered that the WMI ID used by the toshiba-wmi driver
>> is not Toshiba specific, and as such, the driver was being loaded
>> on non Toshiba la
Two of the internal functions are printing an info message, one
whenever the HDD protection level changes, and another when the
driver receives an ACPI event.
This patch changes those two prints to debug, as that information
is more pertaining to debuging purposes.
Signed-off-by: Azael Avalos
This patch simply decouples te error checking of the ACPI status and
the actual BT status, as those two were nested in an if/else check,
but are completely unrelated.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion
Currently the code checking for the ACPI status is mixed along with
the actual HDD protection status check.
This patch splits those two checks are they are not related, printing
an error string in case the ACPI call failed, and then check for
actual HDD protection status.
Signed-off-by: Azael
These two patches make some small changes to the driver code, the first
splits the error check fro the ACPI status and the HDD protection, and
the second simply changes the printing level of two strings from info
to debug.
Azael Avalos (2):
toshiba_haps: Split ACPI status error check from HDD
This patch moves all the multiple line variable declaration to a
single line declaration (except variables being initialized)
following the reverse tree order, to conform to the practices
of the kernel.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 33
This patch simply fixes a typo in the error string printed in such
function.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index
ng to Darren's comments
- Added a missing return on *eco_mode_available function
Azael Avalos (3):
toshiba_acpi: Clean up variable declaration
toshiba_acpi: Change error checking logic from TCI functions
toshiba_acpi: Fix typo in *_cooling_method_set function
drivers/platform/x86/tosh
acpi_status and
the tci_raw function call error check, as those two are completely
unrelated and were nested in if/else statements.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 226 ++--
1 file changed, 138 insertions(+), 88 deletions
Hi Darren,
2016-08-28 10:49 GMT-06:00 Darren Hart :
> On Tue, Aug 16, 2016 at 12:06:15PM -0600, Azael Avalos wrote:
>> This patch moves all the multiple line variable declaration to a
>> single line declaration (except variables being initialized)
>> following the reverse t
Hi Darren,
2016-08-28 10:56 GMT-06:00 Darren Hart :
> On Tue, Aug 16, 2016 at 12:06:16PM -0600, Azael Avalos wrote:
>> Currently the success/error checking logic is intermixed, making the
>> code a bit cumbersome to understand.
>>
>> This patch changes the affected f
, dropping the TOSHIBA_ prefix, to
better reflect that such GUID is not a Toshiba specific one.
Cc: # 4.4+
Signed-off-by: Azael Avalos
---
Hi Darren,
I was waiting on input from the bug above, but haven't received an
answer (as of yet), so I decided to send this to the mailing list
for feedba
These set of patches make some cleanup in some of the driver's functions.
The first patch changes the variables declaration, the second changes
the error checking logic and the third simply fixes a typo found while
making these changes.
Azael Avalos (3):
toshiba_acpi: Cleanup var
This patch simply fixes a typo in the error string printed in such
function.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index
acpi_status and
the tci_raw function call error check, as those two are completely
unrelated and were nested in if/else statements.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 222 ++--
1 file changed, 135 insertions(+), 87 deletions
This patch moves all the multiple line variable declaration to a
single line declaration (except variables being initialized)
following the reverse tree order, to conform to the practices
of the kernel.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 98
: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index 254a4d5..444f351 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b/drivers/platform/x86
2016-06-28 23:16 GMT-06:00 Darren Hart :
> On Tue, Jun 28, 2016 at 01:58:55PM -0600, Azael Avalos wrote:
>> The toshiba_acpi driver added support to the accelerometer axis
>> via the IIO subsystem, but failed to add the dependency to the
>> Kconfig file, making the driver f
Kconfig to avoid such build failure.
Signed-off-by: Azael Avalos
---
Darren, Jonathan:
I just received a few mails from the kbuild test robot informing
the build failure, as a fix for this I just added a hard dependency
to IIO, but maybe Jonathan can weigh in and provide me with a better
alternative
This patch adds the accelerometer axis data to the IIO subsystem.
Currently reporting the X, Y and Z values, as no other data can be
queried given the fact that the accelerometer chip itself is hidden
behind the Toshiba proprietary interface.
Signed-off-by: Azael Avalos
---
drivers/platform
Now that we have proper support for the acceleromeer under the IIO
subsystem, the _position_ sysfs file is now deprecated.
This patch removes all code related to the position sysfs entry.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 25 -
1 file
After several fixes, and added support for more features (WWAN,
Cooling Method and IIO accelometer axis data), bump the driver
version to 0.24.
Also update the copyright year.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 4 ++--
1 file changed, 2 insertions(+), 2
- Changed the iio code according to feedback from Jonathan Cameron
Azael Avalos (3):
toshiba_acpi: Add IIO interface for accelerometer axis data
toshiba_acpi: Remove the position sysfs entry
toshiba_acpi: Bump driver version and update copyright year
drivers/platform/x86/toshiba_acpi.c
Hi Darren,
2016-06-27 18:19 GMT-06:00 Darren Hart :
> On Sun, Jun 19, 2016 at 05:28:04PM -0600, Azael Avalos wrote:
>> This patch adds the accelerometer axis data to the IIO subsystem.
>>
>> Currently reporting the X, Y and Z values, as no other data can be
>> quer
Hi,
Thanks for the feedback, I just did a respin of the series with the
changes you mentioned.
Cheers
Azael
2016-06-19 14:16 GMT-06:00 Jonathan Cameron :
> On 11/06/16 19:57, Azael Avalos wrote:
>> This patch adds the accelerometer axis data to the IIO subsystem.
>>
>> Cu
This patch adds the accelerometer axis data to the IIO subsystem.
Currently reporting the X, Y and Z values, as no other data can be
queried given the fact that the accelerometer chip itself is hidden
behind the Toshiba proprietary interface.
Signed-off-by: Azael Avalos
---
drivers/platform
Now that we have proper support for the acceleromeer under the IIO
subsystem, the _position_ sysfs file is now deprecated.
This patch removes all code related to the position sysfs entry.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 25 -
1 file
Cameron
Azael Avalos (3):
toshiba_acpi: Add IIO interface for accelerometer axis data
toshiba_acpi: Remove the position sysfs entry
toshiba_acpi: Bump driver version and update copyright year
drivers/platform/x86/toshiba_acpi.c | 136 +---
1 file changed
After several fixes, and added support for more features (WWAN,
Cooling Method and IIO accelometer axis data), bump the driver
version to 0.24.
Also update the copyright year.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 4 ++--
1 file changed, 2 insertions(+), 2
This patch adds the accelerometer axis data to the IIO subsystem.
Currently reporting the X, Y and Z values, as no other data can be
queried given the fact that the accelerometer chip itself is hidden
behind the Toshiba proprietary interface.
Signed-off-by: Azael Avalos
---
All:
This is my
These series of patches update the accelerometer axis data
reporting to use the IIO subsystem, deprecating the custom
position sysfs entry, and finally bumping the driver version
to 0.24.
Azael Avalos (3):
toshiba_acpi: Add IIO interface for accelerometer axis data
toshiba_acpi: Remove the
Now that we have proper support for the acceleromeer under the IIO
subsystem, the _position_ sysfs file is now deprecated.
This patch removes all code related to the position sysfs entry.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 29 -
1
After several fixes, and added support for more features (WWAN,
Cooling Method and IIO accelometer axis data), bump the driver
version to 0.24.
Also update the copyright year.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 4 ++--
1 file changed, 2 insertions(+), 2
Hi Darren,
No problem with me, ohh and thanks, I forgot to include stable.
Cheers
Azael
2016-04-25 11:31 GMT-06:00 Darren Hart :
> On Fri, Apr 22, 2016 at 09:29:36AM -0600, Azael Avalos wrote:
>> Commit 52cbae0127ad ("toshiba_acpi: Change default Hotkey enabling value&qu
tch or the
pointing device toggle button.
This patch reverts such commit by changing the default hotkey enabling
value to 0x09, which enables hotkey events only, making the hardware
buttons working again.
Fixes bugs 113331 and 114941.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_
-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index 5ace1e0..df1f1a7 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b/drivers/platform/x86
.
Azael Avalos (3):
toshiba_acpi: Add support for cooling method feature
toshiba_acpi: Add sysfs entries for th Cooling Method feature
Documentation/ABI: Update sysfs-driver-toshiba_acpi file
.../ABI/testing/sysfs-driver-toshiba_acpi | 16
drivers/platform/x86/toshiba_acpi.c
This patch updates the documentation file adding the Cooling Method
entry.
Signed-off-by: Azael Avalos
---
Documentation/ABI/testing/sysfs-driver-toshiba_acpi | 16
1 file changed, 16 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-driver-toshiba_acpi
b
- Battery Optimized
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 54 +
1 file changed, 54 insertions(+)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index 7383307..c6f92ec 100644
--- a/driver
This patch adds the sysfs entry
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 51 +
1 file changed, 51 insertions(+)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index c6f92ec..5ace1e0 100644
the build issue.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 1089eaa..25a02f9 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -64
, to make userspace aware of such change.
Signed-off-by: Azael Avalos
---
Changes since v1:
- Moved the implementation of the toshiba_acpi_kbd_bl_work function further down
to make the file compile
drivers/platform/x86/toshiba_acpi.c | 47 +
1 file changed, 43
), the second queries WWAN support, and finally the third
(de)activates the device.
Signed-off-by: Fabian Koester
Signed-off-by: Azael Avalos ZZ
---
drivers/platform/x86/toshiba_acpi.c | 109
1 file changed, 109 insertions(+)
diff --git a/drivers/platform/x86
status.
Signed-off-by: Fabian Koester
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 79 +++--
1 file changed, 76 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index
to rfkill_unregister and rfkill_destroy functions
Azael Avalos (2):
toshiba_acpi: Add support for WWAN devices
toshiba_acpi: Add WWAN RFKill support
drivers/platform/x86/toshiba_acpi.c | 188 +++-
1 file changed, 185 insertions(+), 3 deletions(-)
--
2.6.3
Hi Darren,
2015-11-20 16:19 GMT-07:00 Darren Hart :
> On Sun, Nov 15, 2015 at 08:33:46PM -0700, Azael Avalos wrote:
>> The driver uses genetlink to inform userspace of events generated by
>> the system, but the data passed is always zero as there is no data to
>> pass, except
Hi Darren,
2015-11-20 16:39 GMT-07:00 Darren Hart :
> On Mon, Nov 16, 2015 at 12:59:31PM -0700, Azael Avalos wrote:
>> Certain Toshiba models with the second generation keyboard backlight
>> (type 2) do not generate the keyboard backlight changed event (0x92),
>> and thus,
Hi Darren,
2015-11-20 16:16 GMT-07:00 Darren Hart :
> On Sun, Nov 15, 2015 at 08:32:47PM -0700, Azael Avalos wrote:
>> If transflective backlight is supported and the brightness is zero
>> (lowest brightness level), the set_lcd_brightness function will activate
>> the tr
Hi Darren,
2015-11-20 15:50 GMT-07:00 Darren Hart :
> On Thu, Nov 19, 2015 at 08:49:25AM -0700, Azael Avalos wrote:
>
> Hi Azael,
>
>> A previuos patch added WWAN support to the driver, allowing to query
>> and set the device status.
>>
>> This patch
Hi Darren,
2015-11-20 15:49 GMT-07:00 Darren Hart :
> On Thu, Nov 19, 2015 at 08:49:24AM -0700, Azael Avalos wrote:
>> Toshiba laptops with WWAN devices installed cannot use the device unless
>> it is attached and powered, similar to how Toshiba Bluetooth devices
>> work.
), the second queries WWAN support, and finally the third
(de)activates the device.
Signed-off-by: Fabian Koester
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 92 +
1 file changed, 92 insertions(+)
diff --git a/drivers/platform/x86
These two patches add WWAN support to the driver, the first adds the actual
support functions and the second adds RFKill handler functions to set the
device status according to the killswitch.
Changes since v1:
- Added missing calls to rfkill_unregister and rfkill_destroy functions
Azael Avalos
status.
Signed-off-by: Fabian Koester
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 79 +
1 file changed, 79 insertions(+)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index 60d1ad9..d1315c5
, to make userspace aware of such change.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 45 +
1 file changed, 41 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index
This patch simply adds a missing newline in the error string printed
by the toshiba_bluetooth_present function.
This is just a cosmetic change, no functionality was changed.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_bluetooth.c | 2 +-
1 file changed, 1 insertion(+), 1
The driver uses genetlink to inform userspace of events generated by
the system, but the data passed is always zero as there is no data to
pass, except for the hotkey event.
This patch propagates the hotkey value via genetlink so userspace can
make use of it.
Signed-off-by: Azael Avalos
, avoiding the activation of the tranflective backlight.
Cc: # 4.3+
Reported-and-tested-by: Fabian Koester
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86
These two patches add WWAN support to the driver, the first adds the actual
support functions and the second adds RFKill handler functions to set the
device status according to the killswitch.
Azael Avalos (2):
toshiba_acpi: Add support for WWAN devices
toshiba_acpi: Add WWAN RFKill support
), the second queries WWAN support, and finally the third
(de)activates the device.
Signed-off-by: Fabian Koester
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 92 +
1 file changed, 92 insertions(+)
diff --git a/drivers/platform/x86
status.
Signed-off-by: Fabian Koester
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 74 +
1 file changed, 74 insertions(+)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index 60d1ad9..2da4dea
cts as the variable is being checked.
This patch initializes such variable to avoid such unwanted effects.
Cc: # 4.1+
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/tosh
Hi Darren,
2015-11-03 17:44 GMT-07:00 Darren Hart :
> On Sun, Nov 01, 2015 at 07:30:30PM -0700, Azael Avalos wrote:
>> Commit 23f8f4326a15 ("toshiba_acpi: Fix hotkeys registration on some
>> toshiba models") fixed an issue on some laptops regarding hotkeys
>> regi
cts as the variable is being checked.
This patch initializes such variable to avoid such unwanted effects.
Cc: # 4.1+
Signed-off-by: Azael Avalos
---
Darren,
Sorry for sending this patch this late, I had a really busy week :-(
drivers/platform/x86/toshiba_acpi.c | 1 +
1 file changed, 1 insertio
please let me know.
>> >
>> > ------
>> >
>> > From: Azael Avalos
>> >
>> > commit 53147b6cabee5e8d1997b5682fcc0c3b72ddf9c2 upstream.
>> >
>> > Commit a2b3471b5b13 ("toshiba_acpi: Use the Hotkey Event Type function
>
ated stuff.
Currently the driver is under the EXPERIMENTAL flag, as the keymap
and the notify function are incomplete (due to lack of hardware to test).
Signed-off-by: Azael Avalos
---
Changes since v3:
- Fixed Makefile entry, CONFIG_TOSHIBA_HAPS was doubled instead of one
of them being CONFIG_TOSHIBA
ated stuff.
Currently the driver is under the EXPERIMENTAL flag, as the keymap
and the notify function are incomplete (due to lack of hardware to test).
Signed-off-by: Azael Avalos
---
Changes since v2:
- Fixed typo in patch and Kconfig description as well as in a comment
Changes since v1:
- Changed t
Hi there
2015-09-19 10:48 GMT-06:00 Dmitry Torokhov :
> On Fri, Sep 18, 2015 at 2:59 PM, Darren Hart wrote:
>> On Wed, Sep 09, 2015 at 11:30:10AM -0600, Azael Avalos wrote:
>>> Toshiba laptops that feature WMI events for hotkeys were left unsupported
>>> by the t
ated stuff.
Currently the driver is under the EXPERIMENTAL flag, as the keymap
and the notify function are incomplete (due to lack of hardware to test).
Signed-off-by: Azael Avalos
---
Changes since v1:
- Changed the printed log level of the ACPI event type value from info
to debug
- Make the input_
STEM_EVENT
query can be checked directly from the function.
Signed-off-by: Azael Avalos
---
Changes since v1:
- Effectively remove unneeded braces to avoid compiler errors
I forgot to respin the patch with the changes when compile tested this
patch, sorry for the noise :-)
drivers/pl
Hi Darren,
2015-09-18 15:59 GMT-06:00 Darren Hart :
> On Wed, Sep 09, 2015 at 11:30:10AM -0600, Azael Avalos wrote:
>> Toshiba laptops that feature WMI events for hotkeys were left unsupported
>> by the toshiba_acpi driver, however, commit a88bc06e5aec ("toshiba_acpi:
>&g
Hi Darren,
2015-09-18 16:14 GMT-06:00 Darren Hart :
> On Fri, Sep 18, 2015 at 03:45:05PM -0600, Azael Avalos wrote:
>> Hi Darren,
>>
>> 2015-09-18 15:37 GMT-06:00 Darren Hart :
>> > On Wed, Sep 09, 2015 at 11:28:20AM -0600, Azael Avalos wrote:
>> >> The
Hi Darren,
2015-09-18 15:37 GMT-06:00 Darren Hart :
> On Wed, Sep 09, 2015 at 11:28:20AM -0600, Azael Avalos wrote:
>> The driver currently uses the hotkey enabling value of 0x09 to enable
>> hotkey events, but windows uses a different value (0x01).
>>
>> All Toshiba l
vents only.
0x0b - Disable (hotkey and system) events.
This patch changes the default hotkey enabling value from 0x09 to 0x01,
enabling both the hotkey and system events.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index 9f7ced1..50a2116 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b
STEM_EVENT
query can be checked directly from the function.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
ind
ated stuff.
Currently the driver is under the EXPERIMENTAL flag, as the keymap
and the notify function are incomplete (due to lack of hardware to test).
Signed-off-by: Azael Avalos
---
MAINTAINERS| 6 ++
drivers/platform/x86/Kconfig | 18 +
drivers/platform/x8
Currently the driver has two functions enabling hotkeys support,
but these two functions can be merged into one.
This patch merges these two functions, moving some checks to the
*enable_hotkeys function, simplifying code in the process.
Signed-off-by: Azael Avalos
---
drivers/platform/x86
These two patches make some changes to the hotkeys code, the first
patch unify the hotkey enabling code, and the second changes the default
hotkey enabling parameter.
Azael Avalos (2):
toshiba_acpi: Unify hotkey enabling functions
toshiba_acpi: Change default Hotkey enabling value
drivers
ignment to a comparison,
making the laptops with actual support for such feature to work again.
Signed-off-by: Azael Avalos
---
Darren,
Hopefully this patch can go into one of the 4.3 RCs, as the changes are
there and to avoid shipping a broken feature support.
drivers/platform/x86/toshiba_
to notice, making the function
responsible for registering the input device to continue.
This issue was found on a Toshiba Portege Z30-B, but there might be
some other models out there affected by this regression as well.
Cc: # 4.1+
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_
Hi Darren,
2015-08-05 17:21 GMT-06:00 Darren Hart :
> On Wed, Aug 05, 2015 at 04:23:49PM -0600, Azael Avalos wrote:
>> Hi Darren,
>>
>> 2015-08-05 14:21 GMT-06:00 Darren Hart :
>> >> @@ -1131,14 +1055,10 @@ static int toshiba_usb_three_set(struct
>&
Hi Darren,
2015-08-05 14:21 GMT-06:00 Darren Hart :
>> @@ -1131,14 +1055,10 @@ static int toshiba_usb_three_set(struct
>> toshiba_acpi_dev *dev, u32 state)
>>
>> result = sci_write(dev, SCI_USB_THREE, state);
>> sci_close(dev);
>> - if (result == TOS_FAILURE) {
>> + if (result
Hi Darren,
2015-08-05 3:38 GMT-06:00 Darren Hart :
> On Fri, Jul 31, 2015 at 09:58:13PM -0600, Azael Avalos wrote:
>> Currently the driver prints "*not supported" if any of the features
>> queried are in fact not supported, let us print the available
>> features in
As of March 31th 2015, the mailing-list service finished [1].
This patch simply removes such address.
[1] http://goo.gl/F6jS5r
Signed-off-by: Azael Avalos
---
Hi Darren,
I hope you can queue this patch through your tree, I ran the
"get_maintainer.pl" script but didn't come
lect these
changes to their parent HCI functions.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 177 +---
1 file changed, 104 insertions(+), 73 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_ac
Given that some features were added (/dev/toshiba_acpi device), some
clean-ups and minor (cosmetic) changes all over the driver code, bump
the driver version to 0.23 to reflect these overall changes.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 2 +-
1 file changed, 1
values other than
the ones currently checking for.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 169 ++--
1 file changed, 44 insertions(+), 125 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86
es", which will
print the available laptop features.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 72 +++--
1 file changed, 46 insertions(+), 26 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x8
accordingly to these changes and two new
variables were created and another was changed from uint to bool.
Also, the function toshiba_acceleremoter_supported was renamed to
toshiba_accelerometer_available to maintain the naming consistency on
the driver.
Signed-off-by: Azael Avalos
---
drivers
patch 03 to ensure we are not
breaking userspace and updated patch description
Azael Avalos (5):
toshiba_acpi: Change *available functions return type
toshiba_acpi: Remove "*not supported" feature prints
toshiba_acpi: Refactor *{get, set} functions return value
toshiba_ac
Given that some features were added (/dev/toshiba_acpi device), some
clean-ups and minor changes, bump the driver version to 0.23.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86
es", which will
print the available laptop features.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 69 +++--
1 file changed, 44 insertions(+), 25 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x8
to their parent HCI functions.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 432 ++--
1 file changed, 217 insertions(+), 215 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index
, video}_proc functions in patch 03 to ensure we are not
breaking userspace and updated patch description
Azael Avalos (4):
toshiba_acpi: Change *available functions return type
toshiba_acpi: Remove "*not supported" feature prints
toshiba_acpi: Refactor *{get, set} functions re
SUCCESS (to be on par with the rest of the
HCI/SCI functions), printing an error message, returning -ENODEV and
zero respectively.
The proc and sysfs functions were updated to reflect these changes as
well, returning -EIO for proc, and propagating the error value on the
sysfs functions.
Signed-off
*accelerometer_available.
Signed-off-by: Azael Avalos
---
drivers/platform/x86/toshiba_acpi.c | 142
1 file changed, 61 insertions(+), 81 deletions(-)
diff --git a/drivers/platform/x86/toshiba_acpi.c
b/drivers/platform/x86/toshiba_acpi.c
index f722898..e164926
Hi Darren,
2015-07-24 16:45 GMT-06:00 Darren Hart :
> On Wed, Jul 22, 2015 at 07:37:48PM -0600, Azael Avalos wrote:
>> This patch adds a new function named "set_fan_status" to complement
>> its get* counterpart, as well as to avoid code duplication between
>>
These patches changes the *{get, set} and available *functions,
changes the printed messages of the supported features and bumps the
driver version to 0.23.
Azael Avalos (4):
toshiba_acpi: Change *available functions return type
toshiba_acpi: Remove "*not supported" feat
1 - 100 of 316 matches
Mail list logo
