Re: [Qemu-devel] add multiple times opening support to a virtserialport

2015-08-27 Thread Asias He
Hello Christoffer, On Fri, Aug 28, 2015 at 2:30 AM, Christoffer Dall wrote: > On Thu, Aug 27, 2015 at 10:23:38AM -0400, Christopher Covington wrote: >> On 07/24/2015 08:00 AM, Matt Ma wrote: >> > Hi all, >> > >> > Linaro has developed the foundation for the new Android Emulator code >> > base bas

Re: [PATCH 2/2] virtio_blk: blk-mq support

2013-10-30 Thread Asias He
let me know what your position is, it'd be great to have > independent results. I'd love to run the test but I do not have fast devices around. It would be nice if Nick can give a try ;-) 1) Set .nr_hw_queues to 1 instead 4 for now. 2) Drop some more unused code in the other mail I s

Re: [PATCH] vhost/scsi: Fix incorrect usage of get_user_pages_fast write parameter

2013-10-27 Thread Asias He
irtio-scsi DMA_TO_DEVICE -> WRITE payload case. > > This bug would manifest itself as random process segmentation faults on > KVM host after repeated vhost starts + stops and/or with lots of vhost > endpoints + LUNs. > > Cc: Stefan Hajnoczi > Cc: Michael S. Tsirkin

Re: [PATCH 2/2] virtio_blk: blk-mq support

2013-10-25 Thread Asias He
On Fri, Oct 25, 2013 at 06:05:01AM -0700, Christoph Hellwig wrote: > Switch virtio-blk from the dual support for old-style requests and bios > to use the block-multiqueue. For now pretend to have 4 issue queues > as Jens pulled that out of his this hair and it worked. > > Signed-off-by: Jens Axbo

Re: [PATCH] vhost/scsi: use vmalloc for order-10 allocation

2013-09-17 Thread Asias He
AT > to kzalloc() flags to do this fallback only when really needed. > > Reported-by: Dan Aloni > Signed-off-by: Michael S. Tsirkin Reviewed-by: Asias He > --- > > I put this on my vhost fixes branch, intend to merge for 3.12. > Dan, could you please confirm this works f

Re: [PATCH-v5 2/6] target: Add transport_init_session_tags using per-cpu ida

2013-09-03 Thread Asias He
- Update to percpu-ida usage > > Cc: Kent Overstreet > Cc: Asias He > Cc: Michael S. Tsirkin > Signed-off-by: Nicholas Bellinger Reviewed-by: Asias He > --- > drivers/target/target_core_transport.c | 48 > > include/target/ta

Re: [PATCH-v5 4/6] vhost/scsi: Add pre-allocation for tv_cmd SGL + upages memory

2013-09-03 Thread Asias He
() code. > > This includes sanity checks within vhost_scsi_map_to_sgl() > to reject I/O that exceeds these initial hardcoded values, and > the necessary cleanup in tcm_vhost_make_nexus() failure path + > tcm_vhost_drop_nexus(). > > v3 changes: > - Rebase to v3.11-rc5 code &

Re: [PATCH 0/5] Enable Drivers for Intel MIC X100 Coprocessors.

2013-08-01 Thread Asias He
Hello Sudeep Dutt, On Wed, Jul 31, 2013 at 06:46:08PM -0700, Greg Kroah-Hartman wrote: > On Wed, Jul 24, 2013 at 08:31:31PM -0700, Sudeep Dutt wrote: > > An Intel MIC X100 device is a PCIe form factor add-in coprocessor > > card based on the Intel Many Integrated Core (MIC) architecture > > that r

Re: [PATCH 2/2] virtio_net: fix race in RX VQ processing

2013-07-09 Thread Asias He
using us to lose RX events. > > > > To fix, call virtqueue_enable_cb_prepare with NAPI_STATE_SCHED > > set (under napi lock), later call virtqueue_poll with > > NAPI_STATE_SCHED clear (outside the lock). > > > > Reported-by: Jason Wang > > Signed-off

Re: [PATCH 1/2] virtio: support unlocked queue poll

2013-07-09 Thread Asias He
which means we might be able to get rid of a > barrier here. Deferring this optimization until we do some > benchmarking. > > Signed-off-by: Michael S. Tsirkin Acked-by: Asias He > --- > drivers/virtio/virtio_ring.c | 56 > ++--

Re: [PATCH net] virtio-net: fix the race between channels setting and refill

2013-07-03 Thread Asias He
uling a refill work which can guarantee the > serialization of refill. > > Cc: Sasha Levin > Cc: Rusty Russell > Cc: Michael S. Tsirkin > Signed-off-by: Jason Wang Reviewed-by: Asias He > --- > drivers/net/virtio_net.c |5 + > 1 files changed, 1 insertio

Re: [PATCH net] vhost-net: fix use-after-free in vhost_net_flush

2013-06-21 Thread Asias He
r passing it > to vhost_net_ubuf_put_and_wait, this results > in use after free. > To fix, don't free the argument in vhost_net_ubuf_put_and_wait, > add an new API for callers that want to free ubufs. > > Signed-off-by: Michael S. Tsirkin Acked-by: Asias He > --- > > D

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-19 Thread Asias He
On Fri, May 17, 2013 at 04:25:49PM +0930, Rusty Russell wrote: > Randy Dunlap writes: > > On 05/16/13 16:42, Rusty Russell wrote: > >> Joe Perches writes: > >>> On Thu, 2013-05-16 at 13:04 +0930, Rusty Russell wrote: > >>>> Asias He writes: >

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Asias He
On Thu, May 16, 2013 at 01:04:58PM +0930, Rusty Russell wrote: > Asias He writes: > > On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote: > >> Asias He writes: > >> > scsi.c includes vhost.c which uses memcpy_fromiovec. > >> >

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Asias He
On Thu, May 16, 2013 at 09:05:38AM +0930, Rusty Russell wrote: > "Nicholas A. Bellinger" writes: > > On Wed, 2013-05-15 at 14:47 +0930, Rusty Russell wrote: > >> Asias He writes: > >> > scsi.c includes vhost.c which uses memcpy_fromiovec. > >

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Asias He
On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote: > Asias He writes: > > scsi.c includes vhost.c which uses memcpy_fromiovec. > > > > This patch fixes this build failure. > > > >From Randy Dunlap: > >''' > >on

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Asias He
On Wed, May 15, 2013 at 03:37:30PM -0700, Nicholas A. Bellinger wrote: > On Wed, 2013-05-15 at 14:47 +0930, Rusty Russell wrote: > > Asias He writes: > > > scsi.c includes vhost.c which uses memcpy_fromiovec. > > > > > > This patch fixes this build failu

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-14 Thread Asias He
On Tue, May 14, 2013 at 08:10:20PM -0700, Nicholas A. Bellinger wrote: > On Wed, 2013-05-15 at 08:59 +0800, Asias He wrote: > > scsi.c includes vhost.c which uses memcpy_fromiovec. > > > > This patch fixes this build failure. > > > >From Randy Du

[PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-14 Thread Asias He
tion. ''' Reported-by: Randy Dunlap Signed-off-by: Asias He --- drivers/vhost/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig index 8b9226d..0403323 100644 --- a/drivers/vhost/Kconfig +++ b/drivers/vhost/Kc

Re: [PATCH] vhost: drop virtio_net.h dependency

2013-05-06 Thread Asias He
On Mon, May 06, 2013 at 01:37:34PM +0300, Michael S. Tsirkin wrote: > There's no net specific code in vhost.c anymore, > don't include the virtio_net.h header. Did you push the it to your tree. I am not seeing it. > Signed-off-by: Michael S. Tsirkin > --- > > This is on top of Asias' patches, a

Re: [PATCH] vhost: drop virtio_net.h dependency

2013-05-06 Thread Asias He
On Mon, May 06, 2013 at 01:37:34PM +0300, Michael S. Tsirkin wrote: > There's no net specific code in vhost.c anymore, > don't include the virtio_net.h header. > > Signed-off-by: Michael S. Tsirkin Reviewed-by: Asias He > --- > > This is on top of Asias' p

Re: [PATCH 0/3] vhost-scsi: file renames

2013-05-01 Thread Asias He
l S. Tsirkin Reviewed-by: Asias He > > Michael S. Tsirkin (3): > vhost: src file renames > tcm_vhost: header split up > vhost_scsi: module rename > > drivers/vhost/Kconfig | 10 ++- > drivers/vhost/Kconfig.tcm | 6 -- > drivers

[PATCH] VSOCK: Fix misc device registration

2013-04-23 Thread Asias He
vice.minor to MISC_DYNAMIC_MINOR before we register. Cc: "David S. Miller" Cc: Andy King Cc: Dmitry Torokhov Cc: Reilly Grant Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Asias He --- net/vmw_vsock/af_vsock.c | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [PATCH V7 0/5] virtio-scsi multiqueue

2013-04-06 Thread Asias He
On Sat, Apr 06, 2013 at 09:40:13AM +0100, James Bottomley wrote: > On Fri, 2013-04-05 at 16:55 +0800, Wanlong Gao wrote: > > On 03/28/2013 10:22 AM, Wanlong Gao wrote: > > > On 03/23/2013 07:28 PM, Wanlong Gao wrote: > > >> This series implements virtio-scsi queue steering, which gives > > >> perfo

Re: [PATCH V6 1/5] virtio-scsi: redo allocation of target data

2013-03-20 Thread Asias He
nd no need to pass in the maximum target size as a parameter because > everything should now happen dynamically. > > Cc: James Bottomley > Cc: linux-s...@vger.kernel.org > Signed-off-by: Paolo Bonzini > Signed-off-by: Wanlong Gao Reviewed-by:

Re: [PATCH V6 5/5] virtio-scsi: reset virtqueue affinity when doing cpu hotplug

2013-03-20 Thread Asias He
On Wed, Mar 20, 2013 at 03:01:24PM +0800, Wanlong Gao wrote: > Add hot cpu notifier to reset the request virtqueue affinity > when doing cpu hotplug. > > Cc: linux-s...@vger.kernel.org > Signed-off-by: Paolo Bonzini > Signed-off-by: Wanlong Gao > Reviewed-by: Asias He

Re: [PATCH V4 0/5] virtio-scsi multiqueue

2013-03-18 Thread Asias He
-- > 1 file changed, 291 insertions(+), 73 deletions(-) > > -- > 1.8.2.rc2 > Patch 2-5 Reviewed-by: Asias He -- Asias -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH V4 1/5] virtio-scsi: redo allocation of target data

2013-03-18 Thread Asias He
On Mon, Mar 11, 2013 at 10:43:58AM +0800, Wanlong Gao wrote: > From: Paolo Bonzini > > virtio_scsi_target_state is now empty, but we will find new uses > for it in the next few patches. However, dropping the sglist lets > us turn the array-of-pointers into a simple array, which simplifies > the

Re: [ 04/21] target/pscsi: Fix page increment

2013-03-18 Thread Asias He
On Mon, Mar 18, 2013 at 11:30:47PM +, Ben Hutchings wrote: > On Mon, 2013-03-18 at 14:00 -0700, Nicholas A. Bellinger wrote: > > On Mon, 2013-03-18 at 13:35 +0800, Asias He wrote: > > > On Sat, Mar 16, 2013 at 02:10:22AM +, Ben Hutchings wrote: > > > > On

Re: [ 04/21] target/pscsi: Fix page increment

2013-03-17 Thread Asias He
On Sat, Mar 16, 2013 at 02:10:22AM +, Ben Hutchings wrote: > On Tue, 2013-03-12 at 15:44 -0700, Greg Kroah-Hartman wrote: > > 3.0-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > >

Re: [PATCH] virtio-blk: emit udev event when device is resized

2013-02-25 Thread Asias He
gt; revalidate_disk(vblk->disk); >>> + kobject_uevent_env(&disk_to_dev(vblk->disk)->kobj, KOBJ_CHANGE, envp); >>> done: >>> mutex_unlock(&vblk->config_lock); >>> } >>> >> >> I tried the following with y

Re: [PATCH] virtio-blk: emit udev event when device is resized

2013-02-24 Thread Asias He
On 02/22/2013 03:02 AM, Milos Vyletel wrote: > When virtio-blk device is resized from host (using block_resize from QEMU) > emit > KOBJ_CHANGE uevent to notify guest about such change. This allows user to have > custom udev rules which would take whatever action if such event occurs. As a > proof

Re: [PATCH 17/16 V2] virtio-scsi: use virtqueue_add_sgs for command buffers

2013-02-20 Thread Asias He
ed-off-by: Wanlong Gao Reviewed-by: Asias He > --- > V1->V2: > add the lost comments (Asias) > > drivers/scsi/virtio_scsi.c | 91 > +- > 1 file changed, 34 insertions(+), 57 deletions(-) > > diff --git a/drivers

Re: [PATCH 17/16] virtio-scsi: use virtqueue_add_sgs for command buffers

2013-02-20 Thread Asias He
On 02/20/2013 04:37 PM, Wanlong Gao wrote: > Using the new virtqueue_add_sgs function lets us simplify the queueing > path. In particular, all data protected by the tgt_lock is just gone > (multiqueue will find a new use for the lock). > > Signed-off-by: Paolo Bonzini > Signed-off-by: Wanlong Ga

Re: [PATCH 06/16] virtio_blk: remove nents member.

2013-02-20 Thread Asias He
On 02/19/2013 03:56 PM, Rusty Russell wrote: > It's simply a flag as to whether we have data now, so make it an > explicit function parameter rather than a member of struct > virtblk_req. > > Signed-off-by: Rusty Russell Reviewed-by: Asias He > --- > drivers

Re: [PATCH 05/16] virtio-blk: use virtqueue_add_sgs on req path

2013-02-20 Thread Asias He
olo Bonzini > Signed-off-by: Rusty Russell Reviewed-by: Asias He > --- > drivers/block/virtio_blk.c | 69 > +--- > 1 file changed, 33 insertions(+), 36 deletions(-) > > diff --git a/drivers/block/virtio_blk.c b/driv

Re: [PATCH 04/16] virtio-blk: use virtqueue_start_buf on bio path

2013-02-20 Thread Asias He
bio, vbr->sg + out); > - > - sg_set_buf(&vbr->sg[num + out + in++], &vbr->status, > -sizeof(vbr->status)); > - > - if (num) { > - if (bio->bi_rw & REQ_WRITE) { > + vbr->nents = blk_bio_map_sg(vblk->disk->queue, bio, vbr->sg);

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-20 Thread Asias He
On 02/19/2013 03:56 PM, Rusty Russell wrote: > virtio_scsi can really use this, to avoid the current hack of copying > the whole sg array. Some other things get slightly neater, too. > > Signed-off-by: Rusty Russell This simpler API makes more sense to me. Reviewed-

Re: [PATCH 3/9] virtio-blk: use virtqueue_start_buf on bio path

2013-02-16 Thread Asias He
> > With this change, virtio-blk (with use_bio) is not relying anymore on > the virtio functions ignoring the end markers in a scatterlist. > The next patch will do the same for the other path. > > Signed-off-by: Paolo Bonzini Reviewed-by: Asias He > ---

Re: [PATCH 2/9] virtio-blk: reorganize virtblk_add_req

2013-02-16 Thread Asias He
directly in virtblk_add_req. > > Signed-off-by: Paolo Bonzini Reviewed-by: Asias He > --- > drivers/block/virtio_blk.c | 55 > > 1 files changed, 20 insertions(+), 35 deletions(-) > > diff --git a/drivers/block/virtio_blk.c

Re: [PATCH 4/9] virtio-blk: use virtqueue_start_buf on req path

2013-02-16 Thread Asias He
On 02/12/2013 08:23 PM, Paolo Bonzini wrote: > This is similar to the previous patch, but a bit more radical > because the bio and req paths now share the buffer construction > code. Because the req path doesn't use vbr->sg, however, we > need to add a couple of arguments to __virtblk_add_req. >

Re: [PATCH] vhost-blk: Add vhost-blk support v6

2012-12-06 Thread Asias He
On 12/06/2012 09:00 PM, Michael S. Tsirkin wrote: > On Sun, Dec 02, 2012 at 09:33:53AM +0800, Asias He wrote: >> diff --git a/drivers/vhost/Kconfig.blk b/drivers/vhost/Kconfig.blk >> new file mode 100644 >> index 000..ff8ab76 >> --- /dev/null >> +++ b/drivers/v

[PATCH] vhost-blk: Add vhost-blk support v6

2012-12-01 Thread Asias He
ing REQ_FLUSH bio instead of vfs_fsync, thanks Christoph! - Check file passed by user is a raw block device file Acked-by: David S. Miller Signed-off-by: Asias He --- drivers/vhost/Kconfig | 1 + drivers/vhost/Kconfig.blk | 10 + drivers/vhost/Makefile| 2 + drivers/vhost/

Re: [PATCH] vhost-blk: Add vhost-blk support v5

2012-11-22 Thread Asias He
On 11/21/2012 07:57 PM, Michael S. Tsirkin wrote: > On Wed, Nov 21, 2012 at 12:24:55PM +0800, Asias He wrote: >> On 11/20/2012 09:37 PM, Michael S. Tsirkin wrote: >>> On Tue, Nov 20, 2012 at 02:39:40PM +0800, Asias He wrote: >>>> On 11/20/2012 04:26 AM, Michael S. Ts

Re: [PATCH] vhost-blk: Add vhost-blk support v5

2012-11-20 Thread Asias He
On 11/20/2012 09:37 PM, Michael S. Tsirkin wrote: > On Tue, Nov 20, 2012 at 02:39:40PM +0800, Asias He wrote: >> On 11/20/2012 04:26 AM, Michael S. Tsirkin wrote: >>> On Mon, Nov 19, 2012 at 04:53:42PM +0800, Asias He wrote: >>>> vhost-blk is an in-kernel

Re: [PATCH] vhost-blk: Add vhost-blk support v5

2012-11-19 Thread Asias He
On 11/20/2012 04:26 AM, Michael S. Tsirkin wrote: > On Mon, Nov 19, 2012 at 04:53:42PM +0800, Asias He wrote: >> vhost-blk is an in-kernel virito-blk device accelerator. >> >> Due to lack of proper in-kernel AIO interface, this version converts >> guest's I/O reques

Re: [PATCH 0/5] virtio-scsi: create a separate workqueue

2012-11-07 Thread Asias He
er.kernel.org > drivers/scsi/virtio_scsi.c | 43 +++ > 1 file changed, 23 insertions(+), 20 deletions(-) > > -- > 1.8.0 > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to ma

Re: [BUG] lkvm crash on crashkernel boot

2012-10-27 Thread Asias He
I've >> added it to my workqueue (unless someone deals with it first). > > Any reason I shouldn't apply Kirill's patch before someone find the time > to do that? Please apply it. -- Asias He -- To unsubscribe from this list: send the line "unsubscribe linux-

Re: [GIT PULL] Linux KVM tool for v3.7-rc0

2012-10-22 Thread Asias He
s we discussed replacing SLIRP with lkvm code for > userspace networking and decided (for reasons I do not remember) that it > lacks futures SLIRP has. Was it host port redirection? Yes. Currently, there is no host to guest port forward support in lkvm. However, it's faster than slirp. e.g. tcp

Re: [ 84/95] virtio_blk: fix config handler race

2012-09-09 Thread Asias He
On 09/10/2012 10:26 AM, Rusty Russell wrote: > Ben Hutchings writes: > >> 3.2-stable review patch. If anyone has any objections, please let me know. >> >> -- >> >> From: "Michael S. Tsirkin" >> >> commit 4678d6f970c2f7c0cbfefc0cc666432d153b321b upstream. >> >> Fix a theoretical

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-04 Thread Asias He
On 09/05/2012 01:48 PM, Michael S. Tsirkin wrote: > On Wed, Sep 05, 2012 at 12:22:58PM +0800, Asias He wrote: >> On 09/04/2012 02:23 PM, Rusty Russell wrote: >>> Kent Overstreet writes: >>> >>>> CONFIG_VIRTIO isn't exposed, everything else is supposed

Re: [PATCH] virtio-blk: Fix kconfig option

2012-09-04 Thread Asias He
On 09/04/2012 02:23 PM, Rusty Russell wrote: > Kent Overstreet writes: > >> CONFIG_VIRTIO isn't exposed, everything else is supposed to select it >> instead. > > This is a slight mis-understanding. It's supposed to be selected by > the particular driver, probably virtio_pci in your case. virti

[PATCH V7 1/2] virtio-blk: Add bio-based IO path for virtio-blk

2012-08-08 Thread Asias He
s.linux-foundation.org Signed-off-by: Christoph Hellwig Signed-off-by: Minchan Kim Signed-off-by: Asias He Acked-by: Rusty Russell --- drivers/block/virtio_blk.c | 203 - 1 file changed, 163 insertions(+), 40 deletions(-) diff --git a/drivers/block/virti

[PATCH V7 2/2] virtio-blk: Add REQ_FLUSH and REQ_FUA support to bio path

2012-08-08 Thread Asias He
v6: - Reworked REQ_FLUSH and REQ_FUA emulatation order Cc: Rusty Russell Cc: Jens Axboe Cc: Christoph Hellwig Cc: Tejun Heo Cc: Shaohua Li Cc: "Michael S. Tsirkin" Cc: k...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: virtualizat...@lists.linux-foundation.org Signed-off

[PATCH V7 0/2] Improve virtio-blk performance

2012-08-08 Thread Asias He
ead/write IOPS boost : 11%, 11%, 13%, 10% Latency improvement: 10%, 10%, 12%, 10% 3) Normal SATA device With bio-based IO path, sequential read/write, random read/write IOPS boost : -10%, -10%, 4.4%, 0.5% Latency improvement: -12%, -15%, 2.5%, 0.8% Asias He

Re: [PATCH V6 0/2] Improve virtio-blk performance

2012-08-07 Thread Asias He
On 08/08/2012 11:09 AM, Asias He wrote: On 08/07/2012 05:16 PM, Christoph Hellwig wrote: On Tue, Aug 07, 2012 at 04:47:13PM +0800, Asias He wrote: 1) Ramdisk device With bio-based IO path, sequential read/write, random read/write IOPS boost : 28%, 24%, 21%, 16

Re: [PATCH V6 2/2] virtio-blk: Add REQ_FLUSH and REQ_FUA support to bio path

2012-08-07 Thread Asias He
On 08/07/2012 05:15 PM, Christoph Hellwig wrote: At least after review is done I really think this patch sopuld be folded into the previous one. OK. Some more comments below: @@ -58,6 +58,12 @@ struct virtblk_req struct bio *bio; struct virtio_blk_outhdr out_hdr; str

Re: [PATCH V5 4/4] virtio-blk: Add REQ_FLUSH and REQ_FUA support to bio path

2012-08-07 Thread Asias He
On 08/06/2012 11:17 PM, Christoph Hellwig wrote: On Thu, Aug 02, 2012 at 02:43:04PM +0800, Asias He wrote: Even if it has a payload waiting is highly suboptimal and it should use a non-blocking sequencing like it is done in the request layer. So, for REQ_FLUSH, what we need is that send out

[PATCH V6 2/2] virtio-blk: Add REQ_FLUSH and REQ_FUA support to bio path

2012-08-07 Thread Asias He
nel.org Cc: virtualizat...@lists.linux-foundation.org Signed-off-by: Asias He --- drivers/block/virtio_blk.c | 259 - 1 file changed, 183 insertions(+), 76 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 95cfee

[PATCH V6 0/2] Improve virtio-blk performance

2012-08-07 Thread Asias He
/write, random read/write IOPS boost : 28%, 24%, 21%, 16% Latency improvement: 32%, 17%, 21%, 16% 2) Fusion IO device With bio-based IO path, sequential read/write, random read/write IOPS boost : 11%, 11%, 13%, 10% Latency improvement: 10%, 10%, 12%, 10% Asias

[PATCH V6 1/2] virtio-blk: Add bio-based IO path for virtio-blk

2012-08-07 Thread Asias He
rnel@vger.kernel.org Cc: virtualizat...@lists.linux-foundation.org Signed-off-by: Christoph Hellwig Signed-off-by: Minchan Kim Signed-off-by: Asias He Acked-by: Rusty Russell --- drivers/block/virtio_blk.c | 203 - 1 file changed, 163 insertions(+), 40 dele

Re: [PATCH V5 3/4] virtio-blk: Add bio-based IO path for virtio-blk

2012-08-03 Thread Asias He
On 08/03/2012 06:28 AM, Michael S. Tsirkin wrote: On Thu, Aug 02, 2012 at 02:25:55PM +0800, Asias He wrote: diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index c0bbeb4..95cfeed 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c @@ -14,6 +14,9

Re: [PATCH V5 0/4] Improve virtio-blk performance

2012-08-03 Thread Asias He
On 08/03/2012 05:40 AM, Jens Axboe wrote: On 08/02/2012 08:25 AM, Asias He wrote: Hi folks, This version added REQ_FLUSH and REQ_FUA support as suggested by Christoph and rebased against latest linus's tree. Jens, could you please consider picking up the dependencies 1/4 and 2/4 in your

Re: [PATCH V5 4/4] virtio-blk: Add REQ_FLUSH and REQ_FUA support to bio path

2012-08-01 Thread Asias He
On 08/02/2012 02:27 PM, Christoph Hellwig wrote: On Thu, Aug 02, 2012 at 02:25:56PM +0800, Asias He wrote: We need to support both REQ_FLUSH and REQ_FUA for bio based path since it does not get the sequencing of REQ_FUA into REQ_FLUSH that request based drivers can request. REQ_FLUSH is

Re: [PATCH V3 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-08-01 Thread Asias He
On 07/30/2012 09:44 PM, Christoph Hellwig wrote: On Mon, Jul 30, 2012 at 09:31:06AM +0200, Paolo Bonzini wrote: You only need to add REQ_FLUSH support. The virtio-blk protocol does not support REQ_FUA, because there's no easy way to do it in userspace. A bio-based driver needs to handle both

[PATCH V5 4/4] virtio-blk: Add REQ_FLUSH and REQ_FUA support to bio path

2012-08-01 Thread Asias He
" Cc: k...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: virtualizat...@lists.linux-foundation.org Signed-off-by: Asias He --- drivers/block/virtio_blk.c | 104 +++-- 1 file changed, 91 insertions(+), 13 deletions(-) diff --git a/dri

[PATCH V5 3/4] virtio-blk: Add bio-based IO path for virtio-blk

2012-08-01 Thread Asias He
rnel@vger.kernel.org Cc: virtualizat...@lists.linux-foundation.org Signed-off-by: Christoph Hellwig Signed-off-by: Minchan Kim Signed-off-by: Asias He Acked-by: Rusty Russell --- drivers/block/virtio_blk.c | 203 - 1 file changed, 163 insertions(+), 40 dele

[PATCH V5 2/4] block: Add blk_bio_map_sg() helper

2012-08-01 Thread Asias He
Cc: Rusty Russell Cc: Jens Axboe Cc: Christoph Hellwig Cc: Tejun Heo Cc: Shaohua Li Cc: "Michael S. Tsirkin" Cc: k...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: virtualizat...@lists.linux-foundation.org Signed-off-by: Christoph Hellwig Signed-off-by: Minchan Kim Signed-off

[PATCH V5 0/4] Improve virtio-blk performance

2012-08-01 Thread Asias He
h bio-based IO path, sequential read/write, random read/write IOPS boost : 11%, 11%, 13%, 10% Latency improvement: 10%, 10%, 12%, 10% Asias He (4): block: Introduce __blk_segment_map_sg() helper block: Add blk_bio_map_sg() helper virtio-blk: Add bio-based IO path for virti

[PATCH V5 1/4] block: Introduce __blk_segment_map_sg() helper

2012-08-01 Thread Asias He
nel.org Cc: linux-kernel@vger.kernel.org Cc: virtualizat...@lists.linux-foundation.org Suggested-by: Jens Axboe Suggested-by: Tejun Heo Signed-off-by: Asias He --- block/blk-merge.c | 80 +++ 1 file changed, 45 insertions(+), 35 deletions(-) di

Re: [PATCH V3 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-31 Thread Asias He
On 07/30/2012 09:43 PM, Christoph Hellwig wrote: On Mon, Jul 30, 2012 at 12:43:12PM +0800, Asias He wrote: I think we can add REQ_FLUSH & REQ_FUA support to bio path and that deserves another patch. Adding it is a requirement for merging the code. OK. Will add that. -- Asias -

Re: [PATCH V4 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-29 Thread Asias He
Hello Sasha, On 07/28/2012 02:35 PM, Sasha Levin wrote: On 07/28/2012 04:21 AM, Asias He wrote: This patch introduces bio-based IO path for virtio-blk. Compared to request-based IO path, bio-based IO path uses driver provided ->make_request_fn() method to bypasses the IO scheduler. It hand

Re: [PATCH V3 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-29 Thread Asias He
On 07/28/2012 02:42 PM, Paolo Bonzini wrote: I'm not sure what the correct behavior for bio & cacheflush is, if any. REQ_FLUSH is not supported in the bio path. Ouch, that's correct: @@ -414,7 +529,7 @@ static void virtblk_update_cache_mode(struct virtio_device *vdev) u8 writeback =

Re: [PATCH V4 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-29 Thread Asias He
On 07/29/2012 07:11 PM, Michael S. Tsirkin wrote: On Sat, Jul 28, 2012 at 10:21:05AM +0800, Asias He wrote: This patch introduces bio-based IO path for virtio-blk. Compared to request-based IO path, bio-based IO path uses driver provided ->make_request_fn() method to bypasses the IO schedu

Re: [PATCH V3 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-29 Thread Asias He
On 07/29/2012 08:59 PM, Michael S. Tsirkin wrote: On Sat, Jul 28, 2012 at 10:38:41AM +0800, Asias He wrote: On 07/27/2012 08:33 AM, Rusty Russell wrote: On Fri, 13 Jul 2012 16:38:51 +0800, Asias He wrote: Add 'virtio_blk.use_bio=1' to kernel cmdline or 'modprobe virtio_bl

Re: [PATCH V3 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-27 Thread Asias He
On 07/27/2012 08:33 AM, Rusty Russell wrote: On Fri, 13 Jul 2012 16:38:51 +0800, Asias He wrote: Add 'virtio_blk.use_bio=1' to kernel cmdline or 'modprobe virtio_blk use_bio=1' to enable ->make_request_fn() based I/O path. This patch conflicts with Paolo's

[PATCH V4 2/3] block: Add blk_bio_map_sg() helper

2012-07-27 Thread Asias He
ens Axboe Cc: Tejun Heo Cc: Shaohua Li Cc: Rusty Russell Cc: linux-kernel@vger.kernel.org Signed-off-by: Christoph Hellwig Signed-off-by: Minchan Kim Signed-off-by: Asias He --- block/blk-merge.c | 37 + include/linux/blkdev.h |2 ++ 2 fi

[PATCH V4 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-27 Thread Asias He
ked-by: Rusty Russell Signed-off-by: Christoph Hellwig Signed-off-by: Minchan Kim Signed-off-by: Asias He --- drivers/block/virtio_blk.c | 203 +++- 1 file changed, 163 insertions(+), 40 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio

[PATCH V4 1/3] block: Introduce __blk_segment_map_sg() helper

2012-07-27 Thread Asias He
Axboe Signed-off-by: Asias He --- block/blk-merge.c | 80 ++--- 1 file changed, 45 insertions(+), 35 deletions(-) diff --git a/block/blk-merge.c b/block/blk-merge.c index 160035f..576b68e 100644 --- a/block/blk-merge.c +++ b/block/blk-merge.c

[PATCH V4 0/3] Improve virtio-blk performance

2012-07-27 Thread Asias He
ad/write IOPS boost : 11%, 11%, 13%, 10% Latency improvement: 10%, 10%, 12%, 10% Asias He (3): block: Introduce __blk_segment_map_sg() helper block: Add blk_bio_map_sg() helper virtio-blk: Add bio-based IO path for virtio-blk block/blk-merge.c | 117

Re: [PATCH RESEND 5/5] vhost-blk: Add vhost-blk support

2012-07-20 Thread Asias He
On 07/21/2012 04:56 AM, Anthony Liguori wrote: "Michael S. Tsirkin" writes: On Thu, Jul 19, 2012 at 08:05:42AM -0500, Anthony Liguori wrote: Of course, the million dollar question is why would using AIO in the kernel be faster than using AIO in userspace? Actually for me a more important qu

Re: [PATCH RESEND 5/5] vhost-blk: Add vhost-blk support

2012-07-18 Thread Asias He
On 07/18/2012 10:31 PM, Jeff Moyer wrote: Asias He writes: On 07/18/2012 03:10 AM, Jeff Moyer wrote: Asias He writes: vhost-blk is a in kernel virito-blk device accelerator. This patch is based on Liu Yuan's implementation with various improvements and bug fixes. Notably, this

Re: [PATCH 0/5] Add vhost-blk support

2012-07-18 Thread Asias He
On 07/17/2012 09:02 PM, Paolo Bonzini wrote: Il 17/07/2012 14:48, Michael S. Tsirkin ha scritto: On Tue, Jul 17, 2012 at 01:03:39PM +0100, Stefan Hajnoczi wrote: On Tue, Jul 17, 2012 at 12:54 PM, Michael S. Tsirkin wrote: Knowing the answer to that is important before anyone can say whether t

Re: [PATCH 0/5] Add vhost-blk support

2012-07-18 Thread Asias He
On 07/17/2012 07:11 PM, Stefan Hajnoczi wrote: On Tue, Jul 17, 2012 at 10:21 AM, Asias He wrote: On 07/17/2012 04:52 PM, Paolo Bonzini wrote: Il 17/07/2012 10:29, Asias He ha scritto: So, vhost-blk at least saves ~6 syscalls for us in each request. Are they really 6? If I/O is

Re: [PATCH RESEND 0/5] Add vhost-blk support

2012-07-17 Thread Asias He
On 07/17/2012 11:09 PM, Michael S. Tsirkin wrote: On Fri, Jul 13, 2012 at 04:55:06PM +0800, Asias He wrote: Hi folks, [I am resending to fix the broken thread in the previous one.] This patchset adds vhost-blk support. vhost-blk is a in kernel virito-blk device accelerator. Compared to

Re: [PATCH RESEND 5/5] vhost-blk: Add vhost-blk support

2012-07-17 Thread Asias He
On 07/18/2012 03:10 AM, Jeff Moyer wrote: Asias He writes: vhost-blk is a in kernel virito-blk device accelerator. This patch is based on Liu Yuan's implementation with various improvements and bug fixes. Notably, this patch makes guest notify and host completion processing in parallel

Re: [PATCH 0/5] Add vhost-blk support

2012-07-17 Thread Asias He
On 07/17/2012 04:52 PM, Paolo Bonzini wrote: Il 17/07/2012 10:29, Asias He ha scritto: So, vhost-blk at least saves ~6 syscalls for us in each request. Are they really 6? If I/O is coalesced by a factor of 3, for example (i.e. each exit processes 3 requests), it's really 2 syscall

Re: [PATCH 0/5] Add vhost-blk support

2012-07-17 Thread Asias He
On 07/16/2012 07:58 PM, Stefan Hajnoczi wrote: On Thu, Jul 12, 2012 at 4:35 PM, Asias He wrote: This patchset adds vhost-blk support. vhost-blk is a in kernel virito-blk device accelerator. Compared to userspace virtio-blk implementation, vhost-blk gives about 5% to 15% performance improvement

Re: [PATCH RESEND 0/5] Add vhost-blk support

2012-07-16 Thread Asias He
Hi Christoph, On 07/14/2012 03:49 PM, Christoph Hellwig wrote: Please send a version that does direct block I/O similar to xen-blkback for now. Seems xen-blkback converts the guest IO request to host bio and submit them directly. I was wondering whether this has a performance gain compared t

[PATCH RESEND 3/5] vhost: Make vhost a separate module

2012-07-13 Thread Asias He
: Michael S. Tsirkin Cc: linux-kernel@vger.kernel.org Cc: k...@vger.kernel.org Cc: virtualizat...@lists.linux-foundation.org Signed-off-by: Asias He --- drivers/vhost/Kconfig | 10 +- drivers/vhost/Makefile |4 +++- drivers/vhost/vhost.c | 48

[PATCH RESEND 4/5] vhost-net: Use VHOST_NET_FEATURES for vhost-net

2012-07-13 Thread Asias He
vhost-net's feature does not deseve the name VHOST_FEATURES. Use VHOST_NET_FEATURES instead. Cc: Michael S. Tsirkin Cc: linux-kernel@vger.kernel.org Cc: k...@vger.kernel.org Cc: virtualizat...@lists.linux-foundation.org Signed-off-by: Asias He --- drivers/vhost/net.c |4 ++-- dr

[PATCH RESEND 1/5] aio: Export symbols and struct kiocb_batch for in kernel aio usage

2012-07-13 Thread Asias He
: virtualizat...@lists.linux-foundation.org Signed-off-by: Asias He --- fs/aio.c| 37 ++--- include/linux/aio.h | 21 + 2 files changed, 39 insertions(+), 19 deletions(-) diff --git a/fs/aio.c b/fs/aio.c index 55c4c76..93dfbdd

[PATCH RESEND 5/5] vhost-blk: Add vhost-blk support

2012-07-13 Thread Asias He
S. Tsirkin Cc: linux-kernel@vger.kernel.org Cc: k...@vger.kernel.org Cc: virtualizat...@lists.linux-foundation.org Signed-off-by: Asias He --- drivers/vhost/Kconfig | 10 + drivers/vhost/Makefile |2 + drivers/vhost/blk.c| 600 dri

[PATCH RESEND 2/5] eventfd: Export symbol eventfd_file_create()

2012-07-13 Thread Asias He
: Asias He --- fs/eventfd.c |1 + 1 file changed, 1 insertion(+) diff --git a/fs/eventfd.c b/fs/eventfd.c index d81b9f6..b288963 100644 --- a/fs/eventfd.c +++ b/fs/eventfd.c @@ -402,6 +402,7 @@ struct file *eventfd_file_create(unsigned int count, int flags) return file

[PATCH RESEND 0/5] Add vhost-blk support

2012-07-13 Thread Asias He
Hi folks, [I am resending to fix the broken thread in the previous one.] This patchset adds vhost-blk support. vhost-blk is a in kernel virito-blk device accelerator. Compared to userspace virtio-blk implementation, vhost-blk gives about 5% to 15% performance improvement. Asias He (5): aio

[PATCH V3 2/3] block: Add blk_bio_map_sg() helper

2012-07-13 Thread Asias He
ens Axboe Cc: Tejun Heo Cc: Shaohua Li Cc: linux-kernel@vger.kernel.org Signed-off-by: Christoph Hellwig Signed-off-by: Minchan Kim Signed-off-by: Asias He --- block/blk-merge.c | 37 + include/linux/blkdev.h |2 ++ 2 files changed, 39 inserti

[PATCH V3 1/3] block: Introduce __blk_segment_map_sg() helper

2012-07-13 Thread Asias He
: Asias He --- block/blk-merge.c | 80 ++--- 1 file changed, 45 insertions(+), 35 deletions(-) diff --git a/block/blk-merge.c b/block/blk-merge.c index 160035f..576b68e 100644 --- a/block/blk-merge.c +++ b/block/blk-merge.c @@ -110,6 +110,49

[PATCH V3 3/3] virtio-blk: Add bio-based IO path for virtio-blk

2012-07-13 Thread Asias He
by: Christoph Hellwig Signed-off-by: Minchan Kim Signed-off-by: Asias He --- drivers/block/virtio_blk.c | 203 +++- 1 file changed, 163 insertions(+), 40 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 774c31d

[PATCH V3 0/3] Improve virtio-blk performance

2012-07-13 Thread Asias He
% Latency improvement: 32%, 17%, 21%, 16% 2) Fusion IO device With bio-based IO path, sequential read/write, random read/write IOPS boost : 11%, 11%, 13%, 10% Latency improvement: 10%, 10%, 12%, 10% Asias He (3): block: Introduce __blk_segment_map_sg() helper block: Add

Re: [PATCH 1/5] aio: Export symbols and struct kiocb_batch for in kernel aio usage

2012-07-12 Thread Asias He
Hi James, On 07/13/2012 01:50 AM, James Bottomley wrote: On Thu, 2012-07-12 at 23:35 +0800, Asias He wrote: This is useful for people who want to use aio in kernel, e.g. vhost-blk. Signed-off-by: Asias He --- fs/aio.c| 37 ++--- include/linux

  1   2   >