RE: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-28 Thread Ashwin H
> -Original Message- > From: Ashwin H > Sent: Thursday, May 28, 2020 1:01 PM > To: Greg KH > Cc: x...@kernel.org; dri-de...@lists.freedesktop.org; intel- > g...@lists.freedesktop.org; linux-kernel@vger.kernel.org; sta...@kernel.org; > Srivatsa Bhat ; sriva...@

RE: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-28 Thread Ashwin H
> -Original Message- > From: Greg KH > Sent: Wednesday, May 27, 2020 9:02 PM > To: Ashwin H > Cc: x...@kernel.org; dri-de...@lists.freedesktop.org; intel- > g...@lists.freedesktop.org; linux-kernel@vger.kernel.org; sta...@kernel.org; > Srivatsa Bhat ; sriva...@

RE: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-13 Thread Ashwin H
. Thanks, Ashwin

Re: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-12 Thread Ashwin H
This patch fixes CVE-2018-20669 in 4.19 tree. On 13/05/20, 11:36 AM, "Greg KH" wrote: On Wed, May 13, 2020 at 07:19:21AM +0530, ashwin-h wrote: > From: Linus Torvalds > > commit 594cc251fdd0d231d342d88b2fdff4bc42fb0690 upstream. > > Origin

[PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-12 Thread ashwin-h
esses. We have way too long a history of people trying to avoid them. Signed-off-by: Linus Torvalds Signed-off-by: Ashwin H --- arch/x86/include/asm/uaccess.h | 11 ++- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 15 +-- include/linux/uacc

[PATCH 2/2] sctp: implement memory accounting on rx path

2020-05-05 Thread ashwin-h
k_rmem_schedule() is using datalen to make things easy there. Reported-by: Matteo Croce Tested-by: Matteo Croce Acked-by: Neil Horman Acked-by: Marcelo Ricardo Leitner Signed-off-by: Xin Long Signed-off-by: David S. Miller Signed-off-by: Ashwin H --- include/net/sctp/sctp.h | 2 +- net/sctp

[PATCH 0/2] Backport to 4.19 - sctp: fully support memory accounting

2020-05-05 Thread ashwin-h
Backport below upstream commits to 4.19 to address CVE-2019-3874. 1033990ac5b2ab6cee93734cb6d301aa3a35bcaa sctp: implement memory accounting on tx path 9dde27de3e5efa0d032f3c891a0ca833a0d31911 sctp: implement memory accounting on rx path Xin Long (2): sctp: implement memory accounting on tx pat

[PATCH 1/2] sctp: implement memory accounting on tx path

2020-05-05 Thread ashwin-h
emory accounting check is done with the whole msg_len before it too. Reported-by: Matteo Croce Tested-by: Matteo Croce Acked-by: Neil Horman Acked-by: Marcelo Ricardo Leitner Signed-off-by: Xin Long Signed-off-by: David S. Miller Signed-off-by: Ashwin H --- net/sctp/socket.c | 10 -- 1

[PATCH 1/5] ext4: avoid declaring fs inconsistent due to invalid file handles

2020-04-29 Thread ashwin-h
Theodore Ts'o Signed-off-by: Ashwin H Cc: sta...@kernel.org --- fs/ext4/ext4.h | 15 +-- fs/ext4/ialloc.c | 2 +- fs/ext4/inode.c | 44 +++- fs/ext4/ioctl.c | 2 +- fs/ext4/namei.c | 4 ++-- fs/ext4/resize.c

[PATCH 5/5] ext4: unsigned int compared against zero

2020-04-29 Thread ashwin-h
-Coverity: ("Unsigned compared against 0") Fixes: 345c0dbf3a30 ("ext4: protect journal inode's blocks using block_validity") Signed-off-by: Colin Ian King Signed-off-by: Theodore Ts'o Signed-off-by: Ashwin H --- fs/ext4/block_validity.c | 3 ++- 1 file change

[PATCH 4/5] ext4: fix block validity checks for journal inodes using indirect blocks

2020-04-29 Thread ashwin-h
uot;ext4: protect journal inode's blocks using block_validity") Reported-by: Arthur Marsh Signed-off-by: Theodore Ts'o Signed-off-by: Ashwin H --- fs/ext4/block_validity.c | 5 + 1 file changed, 5 insertions(+) diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.

[PATCH 3/5] ext4: don't perform block validity checks on the journal inode

2020-04-29 Thread ashwin-h
k_validity") Reported-by: Dan Rue Signed-off-by: Theodore Ts'o Tested-by: Naresh Kamboju Signed-off-by: Ashwin H --- fs/ext4/extents.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 8d98c9a..71492bf 100644 ---

[PATCH 2/5] ext4: protect journal inode's blocks using block_validity

2020-04-29 Thread ashwin-h
by another inode. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=202879 Signed-off-by: Theodore Ts'o Signed-off-by: Ashwin H Cc: sta...@kernel.org --- fs/ext4/block_validity.c | 48 fs/ext4/inode.c | 4 2 files changed

[PATCH 0/5] Backport to 4.4 - ext4: protect journal inode's blocks using block_validity

2020-04-29 Thread ashwin-h
[PATCH 1/5] ext4: avoid declaring fs inconsistent due to invalid file handles This patch is backported as functionality in this commit is used by Patch 2 in this patchset. [PATCH 2/5] ext4: protect journal inode's blocks using block_validity Backport to 4.4 [PATCH 3/5] ext4: don't perform block v

Re: [PATCH 0/5] Backport to 4.9- ext4: protect journal inode's blocks using block_validity

2020-04-29 Thread Ashwin H
I have sent patches for 4.14 tree Thanks, Ashwin On 29/04/20, 6:29 PM, "Greg KH" wrote: On Thu, Apr 30, 2020 at 12:51:34AM +0530, ashwin-h wrote: > [PATCH 1/5] ext4: avoid declaring fs inconsistent due to invalid file > handles > This patch is backported

[PATCH 4/5] ext4: fix block validity checks for journal inodes using indirect blocks

2020-04-29 Thread ashwin-h
uot;ext4: protect journal inode's blocks using block_validity") Reported-by: Arthur Marsh Signed-off-by: Theodore Ts'o Signed-off-by: Ashwin H --- fs/ext4/block_validity.c | 5 + 1 file changed, 5 insertions(+) diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.

[PATCH 1/5] ext4: avoid declaring fs inconsistent due to invalid file handles

2020-04-29 Thread ashwin-h
Theodore Ts'o Signed-off-by: Ashwin H Cc: sta...@kernel.org --- fs/ext4/ext4.h | 15 +-- fs/ext4/ialloc.c | 2 +- fs/ext4/inode.c | 49 ++--- fs/ext4/ioctl.c | 2 +- fs/ext4/namei.c | 4 ++-- fs/ext4/resize.c

[PATCH 0/5] Backport to 4.14 - ext4: protect journal inode's blocks using block_validity

2020-04-29 Thread ashwin-h
[PATCH 1/5] ext4: avoid declaring fs inconsistent due to invalid file handles This patch is backported as functionality in this commit is used by Patch 2 in this patchset. [PATCH 2/5] ext4: protect journal inode's blocks using block_validity Backport to 4.14 [PATCH 3/5] ext4: don't perform block

[PATCH 3/5] ext4: don't perform block validity checks on the journal inode

2020-04-29 Thread ashwin-h
k_validity") Reported-by: Dan Rue Signed-off-by: Theodore Ts'o Tested-by: Naresh Kamboju Signed-off-by: Ashwin H --- fs/ext4/extents.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index fa6ae90..100eb91 100644 ---

[PATCH 2/5] ext4: protect journal inode's blocks using block_validity

2020-04-29 Thread ashwin-h
by another inode. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=202879 Signed-off-by: Theodore Ts'o Signed-off-by: Ashwin H Cc: sta...@kernel.org --- fs/ext4/block_validity.c | 48 fs/ext4/inode.c | 4 2 files changed

[PATCH 5/5] ext4: unsigned int compared against zero

2020-04-29 Thread ashwin-h
-Coverity: ("Unsigned compared against 0") Fixes: 345c0dbf3a30 ("ext4: protect journal inode's blocks using block_validity") Signed-off-by: Colin Ian King Signed-off-by: Theodore Ts'o Signed-off-by: Ashwin H --- fs/ext4/block_validity.c | 3 ++- 1 file change

[PATCH 4/5] ext4: fix block validity checks for journal inodes using indirect blocks

2020-04-29 Thread ashwin-h
uot;ext4: protect journal inode's blocks using block_validity") Reported-by: Arthur Marsh Signed-off-by: Theodore Ts'o Signed-off-by: Ashwin H --- fs/ext4/block_validity.c | 5 + 1 file changed, 5 insertions(+) diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.

[PATCH 5/5] ext4: unsigned int compared against zero

2020-04-29 Thread ashwin-h
-Coverity: ("Unsigned compared against 0") Fixes: 345c0dbf3a30 ("ext4: protect journal inode's blocks using block_validity") Signed-off-by: Colin Ian King Signed-off-by: Theodore Ts'o Signed-off-by: Ashwin H --- fs/ext4/block_validity.c | 3 ++- 1 file change

[PATCH 3/5] ext4: don't perform block validity checks on the journal inode

2020-04-29 Thread ashwin-h
k_validity") Reported-by: Dan Rue Signed-off-by: Theodore Ts'o Tested-by: Naresh Kamboju Signed-off-by: Ashwin H --- fs/ext4/extents.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 71c68bd..76a8a03 100644 ---

[PATCH 2/5] ext4: protect journal inode's blocks using block_validity

2020-04-29 Thread ashwin-h
by another inode. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=202879 Signed-off-by: Theodore Ts'o Signed-off-by: Ashwin H Cc: sta...@kernel.org --- fs/ext4/block_validity.c | 48 fs/ext4/inode.c | 4 2 files changed

[PATCH 1/5] ext4: avoid declaring fs inconsistent due to invalid file handles

2020-04-29 Thread ashwin-h
Theodore Ts'o Signed-off-by: Ashwin H Cc: sta...@kernel.org --- fs/ext4/ext4.h | 15 +-- fs/ext4/ialloc.c | 2 +- fs/ext4/inode.c | 44 +++- fs/ext4/ioctl.c | 2 +- fs/ext4/namei.c | 4 ++-- fs/ext4/resize.c | 5 +++-- fs/ext4/su

[PATCH 0/5] Backport to 4.9- ext4: protect journal inode's blocks using block_validity

2020-04-29 Thread ashwin-h
[PATCH 1/5] ext4: avoid declaring fs inconsistent due to invalid file handles This patch is backported as functionality in this commit is used by Patch 2 in this patchset. [PATCH 2/5] ext4: protect journal inode's blocks using block_validity Backport to 4.9 [PATCH 3/5] ext4: don't perform block v

Re: [PATCH v5] Force cppc_cpufreq to report values in KHz to fix user space reporting

2016-08-22 Thread Ashwin Chaugule
gt;>>> This has been tested on three arm64 servers, with and without DMI, with >>>> and without CPPC support. >>>> >>>> Changes for v5: >>>> -- Move code to cpufreq/cppc_cpufreq.c from acpi/cppc_acpi.c to keep >>>>frequency-related code together, and keep the CPPC abstract scale >>>>in ACPI (Prashanth Prakash) >>>> -- Fix the scaling to remove the incorrect assumption that frequency >>>>was always a range from zero to max; as a practical matter, it is >>>>not (Prasanth Prakash); this also allowed us to remove an over- >>>>engineered function to do this math. >>>> This addresses my previous feedback. So FWIW, Acked-by: Ashwin Chaugule Cheers, Ashwin.

Re: [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2

2016-06-08 Thread Ashwin Chaugule
+ Prashanth (Can you please have a look as well?) On 31 May 2016 at 15:35, Hoan Tran wrote: > Hi Ashwin, Hi, Sorry about the delay. I'm in the middle of switching jobs and locations, so its been a bit crazy lately. I dont have any major concerns with this code, although there could b

[PATCH 2649/2649] Staging: comedi : fixed a camel case style issue

2016-06-01 Thread Ashwin Ravichandran
Fixed a coding style issue. Signed-off-by: Ashwin Ravichandran --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +- drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers

[PATCH 2649/2649] Staging: comedi : fixed a camel case style issue

2016-05-31 Thread Ashwin
From: Ashwin R Fixed a coding style issue. Signed-off-by: Ashwin R --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +- drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi

Re: [PATCH] acpi: cppc: Prevent cpc_desc_ptr points to the invalid data

2016-05-31 Thread Ashwin Chaugule
On 27 May 2016 at 12:41, Hoan Tran wrote: > Hi Ashwin, Hi, > > Yes, I saw kernel crash. > As cpc_desc_ptr is not NULL, cppc_cpufreq_init() still can pass then > crash during cppc_get_perf_caps() access CPPC shared memory. > > It's not only "PCC channel request

Re: [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2

2016-05-31 Thread Ashwin Chaugule
t; + if (!pcc_doorbell_irq) { > + rc = -ENOMEM; > + goto err_free_db_ack_vaddr; > } > > /* Point to the first PCC subspace entry */ > pcct_entry = (struct acpi_subtable_header *) ( > (unsigned long) pcct_tbl + sizeof(struct acpi_table_pcct)); > > - for (i = 0; i < count; i++) { > + acpi_pcct_tbl = (struct acpi_table_pcct *) pcct_tbl; > + if (acpi_pcct_tbl->flags & ACPI_PCCT_DOORBELL) > + pcc_mbox_ctrl.txdone_irq = true; > + This flag is still bothering me. Can't you have a system where one client requires polling on the command completion bit and another can send a command completion IRQ? Seems to me that you need a channel specific flag to indicate this. Besides, this global flag seems to be used for async platform notifications. i.e. when the OS sets the Generate doorbell irq bit in the Command field (Section 14.2.1 in ACPI v6.1). Thanks, Ashwin.

Re: [PATCH] acpi: cppc: Prevent cpc_desc_ptr points to the invalid data

2016-05-27 Thread Ashwin Chaugule
riptor. */ > + per_cpu(cpc_desc_ptr, pr->id) = cpc_ptr; > + Are you seeing a real problem without this change? I'm missing where this pointer is dereferenced if the PCC channel request fails. Thanks, Ashwin.

Re: [PATCH v2] mailbox: pcc: Support HW-Reduced Communication Subspace Type 2

2016-05-13 Thread Ashwin Chaugule
On 11 May 2016 at 14:15, Hoan Tran wrote: > On Wed, May 11, 2016 at 4:57 AM, Ashwin Chaugule > wrote: >> On 11 May 2016 at 00:21, Hoan Tran wrote: >>> On Tue, May 10, 2016 at 5:00 AM, Ashwin Chaugule >>>> On 6 May 2016 at 14:38, Hoan Tran wrote: >>>&

Re: [PATCH v2] mailbox: pcc: Support HW-Reduced Communication Subspace Type 2

2016-05-11 Thread Ashwin Chaugule
On 11 May 2016 at 00:21, Hoan Tran wrote: > Hi Ashwin, Hi, > On Tue, May 10, 2016 at 5:00 AM, Ashwin Chaugule >> On 6 May 2016 at 14:38, Hoan Tran wrote: >>> From: hotran >>> >>> ACPI 6.1 has a PCC HW-Reduced Communication Subspace Type 2 intended for &g

Re: [PATCH v2] mailbox: pcc: Support HW-Reduced Communication Subspace Type 2

2016-05-10 Thread Ashwin Chaugule
pcc_mbox_ctrl.chans = pcc_mbox_channels; > - pcc_mbox_ctrl.ops = &pcc_chan_ops; > - pcc_mbox_ctrl.dev = &pdev->dev; > + pcc_mbox_ctx.mbox_ctrl.chans = pcc_mbox_ctx.chans; > + pcc_mbox_ctx.mbox_ctrl.ops = &pcc_chan_ops; > + pcc_mbox_ctx.mbox_ctrl.dev = &pdev->dev; > > pr_info("Registering PCC driver as Mailbox controller\n"); > - ret = mbox_controller_register(&pcc_mbox_ctrl); > + ret = mbox_controller_register(&pcc_mbox_ctx.mbox_ctrl); That pcc_mbox_ctx usage everywhere seems questionable to me. But its also too early in the morning here. ;) Regards, Ashwin.

Re: [PATCH v2] Force cppc_cpufreq to report values in KHz to fix user space reporting

2016-04-19 Thread Ashwin Chaugule
- Come up with a scaling factor using the PMU cycle counter at boot before the CPPC drivers are initialized. This would use the current freq set by some UEFI var. This would possibly require some messy perfevents plumbing and added bootup time though. - .. ? Cheers, Ashwin.

Re: [PATCH 0/3] cpufreq: Replace timers with utilization update callbacks

2016-02-12 Thread Ashwin Chaugule
e of such feedback counters for selecting the next freq request. Use (num of cycles used/total cycles) to figure out %ON time for the CPU. I understand its not the goal for this patch series, but in the future if we can do this in your callbacks where possible, then I think we will do better than Ondemand. Regards, Ashwin. > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mailbox: pcc: fix channel calculation in get_pcc_channel()

2015-12-10 Thread Ashwin Chaugule
return &pcc_mbox_channels[id]; > } > Strange that we didn't catch this even with a non-zero id. But the change makes sense so.. Acked-by: Ashwin Chaugule Thanks, Ashwin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 5/6] cpufreq: governor: replace per-cpu delayed work with timers

2015-11-03 Thread Ashwin Chaugule
Hi Viresh, On 30 October 2015 at 22:36, Viresh Kumar wrote: > Hi Ashwin, > > On 30-10-15, 16:46, Ashwin Chaugule wrote: >> On 29 October 2015 at 08:27, Viresh Kumar wrote: >> > This could be made lightweight by keeping per-cpu deferred timers with a >> > single

Re: [PATCH 5/6] cpufreq: governor: replace per-cpu delayed work with timers

2015-10-30 Thread Ashwin Chaugule
cy = shared->policy; > + > + /* > +* Timer handler isn't allowed to queue work at the moment, because: > +* - Another timer handler has done that > +* - We are stopping the governor > + * - Or we are updating the sampling rate of ondemand

Re: [PATCH v2 5/5] ACPI / processor_idle: Add support for Low Power Idle(LPI) states

2015-10-26 Thread Ashwin Chaugule
+ Prashanth (who has successfully run this patch on Qcomm hardware) On 16 September 2015 at 09:59, Sudeep Holla wrote: > ACPI 6.0 introduced an optional object _LPI that provides an alternate > method to describe Low Power Idle states. It defines the local power > states for each node in a hierar

Re: [PATCH v2 5/5] ACPI / processor_idle: Add support for Low Power Idle(LPI) states

2015-10-02 Thread Ashwin Chaugule
; + kfree(info); > + > + /* Tell driver that _LPI is supported. */ > + pr->flags.has_lpi = 1; > + pr->flags.power = 1; > + > + return 0; > +} > + > +/** > + * acpi_idle_lpi_enter - enters an ACPI any LPI state > + * @dev: the target CPU &g

Re: [PATCH v2 4/5] ACPI / processor_idle : introduce ARCH_SUPPORTS_ACPI_PROCESSOR_CSTATE

2015-09-24 Thread Ashwin Chaugule
nfig > +++ b/drivers/acpi/Kconfig > @@ -48,6 +48,9 @@ config ACPI_LEGACY_TABLES_LOOKUP > config ARCH_MIGHT_HAVE_ACPI_PDC > bool > > +config ARCH_SUPPORTS_ACPI_PROCESSOR_CSTATE > + bool > + > config ACPI_GENERIC_GSI > bool > Can't this b

Re: [lkp] [PCC] d3c68f218f: PCCT header not found.

2015-09-09 Thread Ashwin Chaugule
fault: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/mailbox/Kconfig?id=b6fc6072b1268a0025850cd9d3dce25a7be0158d Ashwin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.or

Re: [lkp] [ACPI] 239708a3af: Warning: Processor Platform Limit event detected, but not handled.

2015-08-27 Thread Ashwin Chaugule
maintain previous behavior. i.e. selecting ACPI_PROCESSOR didn't auto enable CPU_FREQ. Regards, Ashwin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device

2015-05-26 Thread Ashwin Chaugule
On 26 May 2015 at 11:18, Will Deacon wrote: > On Tue, May 26, 2015 at 04:02:56PM +0100, Ashwin Chaugule wrote: >> On 26 May 2015 at 08:28, Will Deacon wrote: >> > On Mon, May 25, 2015 at 11:03:13AM +0100, fu@linaro.org wrote: >> >> From: Fu Wei >>

Re: [PATCH v3 6/6] ACPI: import watchdog info of GTDT into platform device

2015-05-26 Thread Ashwin Chaugule
• Secure privilege level 1 (EL1) timer, • Non-Secure EL1 timer, • Non-Secure privilege level 2 (EL2) timer, • Virtual timer, and the following Platform (memory-mapped) timers. • GT Block • Server Base System Architecture (SBSA) Generic Watchdog ---8< Thanks, Ashwin. -- To unsubscribe fro

Re: [PATCH RFC 2/5] ACPI / processor: always compile perflib if CONFIG_ACPI_PROCESSOR

2015-05-06 Thread Ashwin Chaugule
by CPPC. The OS is not expected to support both at runtime, so by keeping this a config option, we can then disable it at compile time when CPPC is enabled. We could couple processor_throttling, thermal and perflib under this config option (CONFIG_PSS ?) since they're all under the same CPU perf

Re: question about drivers/mailbox/pcc.c

2015-03-13 Thread Ashwin Chaugule
now their upstreaming status. Thanks, Ashwin. [1] - https://www.marc.info/?t=14223927425&r=1&w=1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/maj

Re: [PATCH v2 2/2] ARM: perf: Add support for Scorpion PMUs

2015-02-25 Thread Ashwin Chaugule
On 24 February 2015 at 12:23, Ashwin Chaugule wrote: > On 20 February 2015 at 15:16, Stephen Boyd wrote: >> On 02/20, Will Deacon wrote: >>> On Fri, Feb 13, 2015 at 06:24:09PM +, Stephen Boyd wrote: >>> >>> > +static void scor

Re: [PATCH v2 2/2] ARM: perf: Add support for Scorpion PMUs

2015-02-24 Thread Ashwin Chaugule
ot; (0)); >> >> What's this guy doing? > > This is the same as Krait. It's clearing some implementation > defined register. From what I can tell it's a per-event register > (i.e. PMSELR decides which event this register write actually > affects) and we do this her

Re: [PATCH 2/2] ARM: perf: Add support for Scorpion PMUs

2015-02-11 Thread Ashwin Chaugule
On 11 February 2015 at 13:27, Stephen Boyd wrote: > On 02/10, Ashwin Chaugule wrote: >> Hi Stephen, >> >> On 10 February 2015 at 20:05, Stephen Boyd wrote: >> > Scorpion supports a set of local performance monitor event >> > selection registers (LPM

Re: [PATCH 2/2] ARM: perf: Add support for Scorpion PMUs

2015-02-10 Thread Ashwin Chaugule
vent number is a pure software construct that > allows us to map the multi-dimensional number space of regions, > groups, and event codes into a flat event number space suitable > for use by the perf framework. > > This is based on code originally written by Ashwin Chaugule and > Neil

Re: [Linaro-acpi] [PATCH] Mailbox: Complete wait event only if Tx was successful

2014-12-16 Thread Ashwin Chaugule
On 16 December 2014 at 06:36, Sudeep Holla wrote: > On Fri, Dec 12, 2014 at 05:47:26PM +0000, Ashwin Chaugule wrote: >> On 12 December 2014 at 03:43, Sudeep Holla wrote: >> > On Thursday 11 December 2014 01:46 AM, Ashwin Chaugule wrote: >> >> >> >> If a

Re: [PATCH] Mailbox: Complete wait event only if Tx was successful

2014-12-12 Thread Ashwin Chaugule
On 12 December 2014 at 05:21, Jassi Brar wrote: > On 11 December 2014 at 01:46, Ashwin Chaugule > wrote: >> If a wait_for_completion_timeout() call returns due to a timeout, >> the mbox code can still call complete() after returning from the wait. >> This can cause subse

Re: [Linaro-acpi] [PATCH] Mailbox: Complete wait event only if Tx was successful

2014-12-12 Thread Ashwin Chaugule
On 12 December 2014 at 03:43, Sudeep Holla wrote: > Hi Ashwin, Hi, > On Thursday 11 December 2014 01:46 AM, Ashwin Chaugule wrote: >> >> If a wait_for_completion_timeout() call returns due to a timeout, >> the mbox code can still call complete() after returning from the

[PATCH] Mailbox: Complete wait event only if Tx was successful

2014-12-10 Thread Ashwin Chaugule
erroneous complete() call, and immediately returns without waiting for the time as expected by the client. Fix this by calling complete() only if the TX was successful. Signed-off-by: Ashwin Chaugule --- drivers/mailbox/mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCHv10 2/4] mailbox: Introduce framework for mailbox

2014-09-26 Thread Ashwin Chaugule
On 25 September 2014 20:57, Jassi Brar wrote: > On 24 September 2014 09:14, Ashwin Chaugule > wrote: >> On 22 September 2014 14:33, Sudeep Holla wrote: > >>>>>> +static void poll_txdone(unsigned long data) >>>>>> +{ >>>>>>

Re: [PATCHv10 2/4] mailbox: Introduce framework for mailbox

2014-09-24 Thread Ashwin Chaugule
On 22 September 2014 14:33, Sudeep Holla wrote: > On 22/09/14 19:15, Sudeep Holla wrote: >> On 22/09/14 19:01, Ashwin Chaugule wrote: >>> >>> Hi Jassi, >>> >>> On 1 August 2014 08:31, Jassi Brar wrote: >>>> >>>> Introduce com

Re: [PATCHv10 2/4] mailbox: Introduce framework for mailbox

2014-09-22 Thread Ashwin Chaugule
_controller.h that you'd want to use that value in the mod_timer above, or equate the two somewhere in the controller registration or eliminate one of the two. FWIW I also looked at your code in [1]. Thanks, Ashwin [1] - http://git.linaro.org/landing-teams/working/fujitsu/integration.git/sh

Re: [RFC v1 0/6] CPPC as a PID backend

2014-09-10 Thread Ashwin Chaugule
On 10 September 2014 13:31, Dirk Brandewie wrote: > On 09/10/2014 09:11 AM, Ashwin Chaugule wrote: >> On 10 September 2014 11:44, Dirk Brandewie >> With the current split I think you will still be able to maintain >> Intel specific changes for the future in the ba

Re: [RFC v1 0/6] CPPC as a PID backend

2014-09-10 Thread Ashwin Chaugule
On 10 September 2014 11:44, Dirk Brandewie wrote: > Hi Ashwin, Hi Dirk, > > I think the CPPC based driver should be a separate driver. > > We made the conscious decision to not use any of the ACPI mechanisms > to enumerate or control P state selection. Experience over the

[PATCH 3/6] PID: Move Baytrail specific accessors into backend driver

2014-09-09 Thread Ashwin Chaugule
The Baytrail series uses additional information while setting a target CPU performance value. To keep the PID governor generic, move this out into the platform specific backend driver. Signed-off-by: Ashwin Chaugule --- drivers/cpufreq/intel_pid_ctrl.c | 57

[PATCH 2/6] PID: Move Turbo detection into backend driver

2014-09-09 Thread Ashwin Chaugule
Move X86 specific turbo detection logic into platform specific PID backend driver. Signed-off-by: Ashwin Chaugule --- drivers/cpufreq/intel_pid_ctrl.c | 15 ++- drivers/cpufreq/pid_ctrl.c | 13 +++-- 2 files changed, 21 insertions(+), 7 deletions(-) diff --git a

[PATCH 4/6] PID: Add new function pointers to read multiple registers

2014-09-09 Thread Ashwin Chaugule
multiple registers at once. In contrast, we'd have to ring the Doorbell for every register Read. Signed-off-by: Ashwin Chaugule --- drivers/cpufreq/intel_pid_ctrl.c | 49 ++-- drivers/cpufreq/pid_ctrl.c | 34 ++-- drivers/cp

[PATCH 6/6] PID: Add CPPC (Collaborative Processor Performance) backend driver

2014-09-09 Thread Ashwin Chaugule
PID backend interfaces using CPPC semantics. Signed-off-by: Ashwin Chaugule --- drivers/cpufreq/Kconfig | 10 + drivers/cpufreq/Makefile| 1 + drivers/cpufreq/cppc_pid_ctrl.c | 406 3 files changed, 417 insertions(+) create mode 100644

[PATCH 5/6] PID: Rename counters to make them more generic

2014-09-09 Thread Ashwin Chaugule
Aperf/Mperf are very X86 specific names but effectively count Delivered and Reference Cpu performance values. Signed-off-by: Ashwin Chaugule --- drivers/cpufreq/intel_pid_ctrl.c | 12 ++-- drivers/cpufreq/pid_ctrl.c | 10 +- drivers/cpufreq/pid_ctrl.h | 8

[PATCH 1/6] PID Controller governor

2014-09-09 Thread Ashwin Chaugule
contoller. The PID governor still has a few X86 specific things which are moved out in the following patch. Signed-off-by: Ashwin Chaugule --- Documentation/cpu-freq/intel-pstate.txt | 43 -- Documentation/cpu-freq/pid_ctrl.txt | 41 ++ drivers/cpufreq/Kconfig |9

[RFC v1 0/6] CPPC as a PID backend

2014-09-09 Thread Ashwin Chaugule
/ [2] - http://www.uefi.org/sites/default/files/resources/ACPI_5_1release.pdf [3] - http://comments.gmane.org/gmane.linux.acpi.devel/70299 [4] - http://git.linaro.org/people/ashwin.chaugule/leg-kernel.git/shortlog/refs/heads/cppc-pid-no_freq_domain Ashwin Chaugule (6): PID Controller governor

Re: [RFC 0/3] Experimental patchset for CPPC

2014-08-18 Thread Ashwin Chaugule
C MSRs. I suppose X86 will not use a majority of it. Cheers, Ashwin [1] - HWP section 14.4 http://www.intel.com/content/dam/www/public/us/en/documents/manuals/64-ia-32-architectures-software-developer-vol-3b-part-2-manual.pdf -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: [RFC 0/3] Experimental patchset for CPPC

2014-08-18 Thread Ashwin Chaugule
Hello, On 15 August 2014 10:41, Peter Zijlstra wrote: > On Fri, Aug 15, 2014 at 10:37:32AM -0400, Ashwin Chaugule wrote: >> On 15 August 2014 10:07, Peter Zijlstra wrote: >> > On Fri, Aug 15, 2014 at 09:08:50AM -0400, Ashwin Chaugule wrote: >> >> If the OS

Re: [RFC 0/3] Experimental patchset for CPPC

2014-08-15 Thread Ashwin Chaugule
Hello, On 15 August 2014 11:47, Arjan van de Ven wrote: > On 8/15/2014 7:24 AM, Ashwin Chaugule wrote: >>>> we've found that so far that there are two reasonable options >>>> 1) Let the OS device (old style) >>>> 2) Let the hardware decide (new style

Re: [RFC 0/3] Experimental patchset for CPPC

2014-08-15 Thread Ashwin Chaugule
Hi Peter, On 15 August 2014 10:07, Peter Zijlstra wrote: > On Fri, Aug 15, 2014 at 09:08:50AM -0400, Ashwin Chaugule wrote: >> If the OS only looks at Highest, Lowest, Delivered registers and only >> writes to Desired, then we're not really any different than how we do &g

Re: [RFC 0/3] Experimental patchset for CPPC

2014-08-15 Thread Ashwin Chaugule
Hi Arjan, On 15 August 2014 09:53, Arjan van de Ven wrote: > On 8/15/2014 6:42 AM, Arjan van de Ven wrote: >> On 8/15/2014 6:08 AM, Ashwin Chaugule wrote: >>> (b) we come up with ways to provide the bounds around a Desired value >>> using the information from the plat

Re: [RFC 0/3] Experimental patchset for CPPC

2014-08-15 Thread Ashwin Chaugule
Hi Peter, On 15 August 2014 02:19, Peter Zijlstra wrote: > On Thu, Aug 14, 2014 at 05:56:10PM -0400, Ashwin Chaugule wrote: >> On 14 August 2014 16:51, Peter Zijlstra wrote: >> > On Thu, Aug 14, 2014 at 03:57:07PM -0400, Ashwin Chaugule wrote: >> >

Re: [RFC 0/3] Experimental patchset for CPPC

2014-08-14 Thread Ashwin Chaugule
Hi Peter, On 14 August 2014 16:51, Peter Zijlstra wrote: > On Thu, Aug 14, 2014 at 03:57:07PM -0400, Ashwin Chaugule wrote: >> >> >> What is CPPC: >> = >> >> CPPC is the new interface for CPU performance control between the OS and the >>

Re: [RFC 3/3] CPPC: Add ACPI accessors to CPC registers

2014-08-14 Thread Ashwin Chaugule
+ Rafael [corrected email addr] On 14 August 2014 15:57, Ashwin Chaugule wrote: > If the firmware supports CPPC natively in the firmware > then we can use the ACPI defined semantics to access > the CPPC specific registers. > > Signed-off-by: Ashwin Chaugule > --- > dr

Re: [RFC 2/3] CPPC: Add support for Collaborative Processor Performance Control

2014-08-14 Thread Ashwin Chaugule
+ Rafael [corrected email addr] On 14 August 2014 15:57, Ashwin Chaugule wrote: > Add support for parsing the CPC tables as described in the > ACPI 5.1+ CPPC specification. When successfully parsed along > with low level register accessors, then enable the PID > (proportion

Re: [RFC 1/3] ACPI: Add support for Platform Communication Channel

2014-08-14 Thread Ashwin Chaugule
+ Rafael [corrected email addr] On 14 August 2014 15:57, Ashwin Chaugule wrote: > The ACPI 5.0+ spec defines a generic mode of communication > between the OS and a platform such as the BMC or external power > controller. This medium (PCC) is typically used by CPPC > (ACPI CPU

Re: [RFC 0/3] Experimental patchset for CPPC

2014-08-14 Thread Ashwin Chaugule
+ Rafael [corrected email addr] On 14 August 2014 15:57, Ashwin Chaugule wrote: > > Hello, > > Apologies in advance for a lengthy cover letter. Hopefully it has all the > required information so you dont need to read the ACPI spec. ;) > > This patchset introduces

[RFC 1/3] ACPI: Add support for Platform Communication Channel

2014-08-14 Thread Ashwin Chaugule
adds initial support for PCC to be usable by the aforementioned PCC clients. Signed-off-by: Ashwin Chaugule --- drivers/acpi/Kconfig | 10 +++ drivers/acpi/Makefile | 1 + drivers/acpi/pcc.c| 192 ++ 3 files changed, 203 insertions(+) create

[RFC 3/3] CPPC: Add ACPI accessors to CPC registers

2014-08-14 Thread Ashwin Chaugule
If the firmware supports CPPC natively in the firmware then we can use the ACPI defined semantics to access the CPPC specific registers. Signed-off-by: Ashwin Chaugule --- drivers/cpufreq/Kconfig | 9 + drivers/cpufreq/Makefile| 1 + drivers/cpufreq/cppc.h | 4 +-- drivers

[RFC 2/3] CPPC: Add support for Collaborative Processor Performance Control

2014-08-14 Thread Ashwin Chaugule
Add support for parsing the CPC tables as described in the ACPI 5.1+ CPPC specification. When successfully parsed along with low level register accessors, then enable the PID (proportional-intergral-derivative) controller based algorithm to manage CPU performance. Signed-off-by: Ashwin Chaugule

[RFC 0/3] Experimental patchset for CPPC

2014-08-14 Thread Ashwin Chaugule
anvandeVen/posts/dLn9T4ehywL [5] - http://git.linaro.org/people/ashwin.chaugule/leg-kernel.git/blob/236d901d31fb06fda798880c9ca09d65123c5dd9:/drivers/cpufreq/cppc_x86.c Ashwin Chaugule (3): ACPI: Add support for Platform Communication Channel CPPC: Add support for Collaborative Processor Perfor

Re: [PATCHv8 2/2] mailbox: Introduce framework for mailbox

2014-07-14 Thread Ashwin Chaugule
Hello, On 14 July 2014 05:17, Jassi Brar wrote: > On 11 July 2014 17:16, Ashwin Chaugule wrote: >> Hi Jassi, >> >> Other than a few nits, this looks good to me. >> > Thanks for the nits. I will club them together with other feedback on > the patchset. > >

Re: [PATCHv8 2/2] mailbox: Introduce framework for mailbox

2014-07-11 Thread Ashwin Chaugule
@txpoll_period: If 'txdone_poll' is in effect, the API polls for > + * last TX's status after these many millisecs > + * @of_xlate: Controller driver specific mapping of channel via DT > + * @poll: API private. Used to poll fo

Re: [PATCHv7 2/5] mailbox: Introduce framework for mailbox

2014-06-19 Thread Ashwin Chaugule
nd via > non-public interactions with developers I understand it last worked > before the revision mandating DT support and ipc->mailbox symbol > renaming. So basic working should still remain the same. > Suman(TI), Loic(ST), Girish(Samsung), Ashwin (PCC+ACPI) guys, > any

Per-process core-file patterns

2005-03-22 Thread R, Ashwin (Ashwin)
So, I want to add the "coreadm" support for manipulating the core file-names like on Solaris, for the latest 2.6 kernel. Solaris supports the concept of per-process corefile patterns. Hence, each process can effectively have its own core-file pattern in the event that it crashes. The pattern

RE: 2.4.2ac8 lost char devices

2001-03-01 Thread Ashwin D
Hi, I lost graphics on my i810 - failed to get minor is the error message on boot. Ashwin - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Pleas

Bug in 2.4.x??

2001-02-13 Thread Ashwin D
a broken .config could have caused this, but no change. I have tried random settings with hdparm to tune /dev/hda. Thanks for your time. Ashwin (Iam not on the list yet, so please cc me personally) - TEST RESULTS ___ a) Kernel 2.2.17 (mandrake