Re: [PATCH] mm/filemap.c: unconditionally call mark_page_accessed

2007-03-15 Thread Ashif Harji
On Thu, 15 Mar 2007, Nick Piggin wrote: On Thu, Mar 15, 2007 at 11:56:59AM -0400, Chuck Ebbert wrote: Ashif Harji wrote: This patch unconditionally calls mark_page_accessed to prevent pages, especially for small files, from being evicted from the page cache despite frequent access. Signed

Re: [PATCH] mm/filemap.c: unconditionally call mark_page_accessed

2007-03-14 Thread Ashif Harji
On Wed, 14 Mar 2007, Xiaoning Ding wrote: Dave Kleikamp wrote: On Wed, 2007-03-14 at 22:33 +0100, Andreas Mohr wrote: Hi, On Wed, Mar 14, 2007 at 03:55:41PM -0500, Dave Kleikamp wrote: On Wed, 2007-03-14 at 15:58 -0400, Ashif Harji wrote: This patch unconditionally calls

[PATCH] mm/filemap.c: unconditionally call mark_page_accessed

2007-03-14 Thread Ashif Harji
This patch unconditionally calls mark_page_accessed to prevent pages, especially for small files, from being evicted from the page cache despite frequent access. Signed-off-by: Ashif Harji <[EMAIL PROTECTED]> --- If the same page of a file is repeatedly accessed (without accessing

Re: do_generic_mapping_read performance issue

2007-03-13 Thread Ashif Harji
I would like to submit a patch to fix the performance problem. The simplest solution is to remove the check. Even in the situation where an application does not read in PAGE_SIZE multiples as described above, if the page is accessed frequently it should remain in the cache. However, I am open

Re: do_generic_mapping_read performance issue

2007-03-12 Thread Ashif Harji
On Mon, 12 Mar 2007, Jan Kara wrote: On Mon 12-03-07 15:39:00, Nick Piggin wrote: On Mon, Mar 12, 2007 at 03:20:12PM +0100, Jan Kara wrote: Hi, Hi, I am encountering a performance problem, which I have tracked into the Linux kernel. The problem occurs with my experimental web server that

Re: do_generic_mapping_read performance issue

2007-03-12 Thread Ashif Harji
The implication of this code is that for files of size less than or equal to a single page, the page associated with such a file is likely to get evicted from the cache regardless of how frequently it is accessed. The reason is that after the first access, prev_index is always zero and index ca

do_generic_mapping_read performance issue

2007-03-09 Thread Ashif Harji
Hi, I am encountering a performance problem, which I have tracked into the Linux kernel. The problem occurs with my experimental web server that uses sendfile to repeatedly transmit files. The files are based on the static portion of the SPECweb99 fileset and range in size to model a reasonab