WARNING: Use #include instead of
WARNING: Use #include instead of
WARNING: Use #include instead of
Signed-off-by: Asaf Vertz
---
.../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h|2 +-
.../lustre/lnet/klnds/socklnd/socklnd_lib-linux.h |2 +-
.../lustre/lustre/libcfs/linux/linux
Fixed a coding style error, space prohibited before that '++'
Signed-off-by: Asaf Vertz
---
drivers/staging/lustre/lnet/selftest/console.c | 28
1 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/lustre/lnet/selftest/console.c
Fixed a coding style error, space prohibited after that '!'
Signed-off-by: Asaf Vertz
---
drivers/staging/lustre/lustre/osc/osc_lock.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/lustre/lustre/osc/osc_lock.c
b/drivers/stag
'.
[drivers/scsi/3w-9xxx.c:166]: (warning) %d in format string (no. 10)
requires 'int' but the argument type is 'unsigned int'.
[drivers/scsi/3w-9xxx.c:166]: (warning) %d in format string (no. 11)
requires 'int' but the argument type is 'unsigned int'.
Si
but the argument type is 'unsigned int'.
[drivers/usb/gadget/function/f_sourcesink.c:1608]: (warning) %d in format
string (no. 1)
requires 'int' but the argument type is 'unsigned int'
Signed-off-by: Asaf Vertz
---
drivers/usb/gadget/function/f_sourcesink.c | 2
#x27; but the argument type is 'unsigned long'.
[drivers/hwmon/abx500.c:242]: (warning) %ld in format string (no. 1)
requires 'long' but the argument type is 'unsigned long'.
Signed-off-by: Asaf Vertz
---
drivers/hwmon/abx500.c |6 +++---
1 files changed, 3 insertio
Fixed the following warning (reported by cppcheck):
[drivers/mmc/card/block.c:2149]: (warning) %d in format string (no. 1)
requires 'int' but the argument type is 'unsigned int'.
Signed-off-by: Asaf Vertz
---
drivers/mmc/card/block.c |2 +-
1 files changed, 1 insert
quires 'int' but the argument type is 'unsigned int'.
[drivers/staging/iio/light/tsl2583.c:695]: (warning) %d in format string (no. 3)
requires 'int' but the argument type is 'unsigned int'.
Signed-off-by: Asaf Vertz
---
drivers/staging/iio/light/tsl2583.c |
no. 2)
requires 'int' but the argument type is 'unsigned int'.
[drivers/staging/iio/light/tsl2x7x_core.c:1150]: (warning) %d in format string
(no. 3)
requires 'int' but the argument type is 'unsigned int'.
Signed-off-by: Asaf Vertz
---
drivers/st
nalyzer/ad5933.c:367]: (warning) %d in format
string (no. 3)
requires 'int' but the argument type is 'unsigned int'.
[drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format
string (no. 4)
requires 'int' but the argument type is 'unsigned int&#x
-off-by: Asaf Vertz
---
drivers/staging/wlan-ng/hfa384x.h |4 ++--
drivers/staging/wlan-ng/hfa384x_usb.c |2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/hfa384x.h
b/drivers/staging/wlan-ng/hfa384x.h
index 20d146b..964a662 100644
--- a
To be future-proof and for better readability the time comparisons are
modified to use time_after_eq() instead of plain, error-prone math.
Signed-off-by: Asaf Vertz
---
drivers/net/ethernet/intel/e1000/e1000_ethtool.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a
To be future-proof and for better readability the time comparisons are
modified to use time_before() instead of plain, error-prone math.
Signed-off-by: Asaf Vertz
---
drivers/block/rsxx/core.c |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/block/rsxx
To be future-proof and for better readability the time comparison
modified to use time_after_eq() instead of plain, error-prone math.
Signed-off-by: Asaf Vertz
---
drivers/md/dm-bufio.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/md/dm-bufio.c b/drivers/md
dd->total is unsigned so it won't do any good to check for negative value after
subtracting
instead of that we should check if the subtracted value is bigger than him
This was partially found by using a static code analysis program called
cppcheck.
Signed-off-by: Asaf Vertz
---
Fixed a coding style error, "foo * bar" should be "foo *bar"
Signed-off-by: Asaf Vertz
---
Changes in v2:
- fix ugly multiline arguments to the functions
drivers/staging/rtl8723au/core/rtw_efuse.c | 32 ++-
1 files changed, 7 insertions(+), 2
Fixed a coding style error, "foo * bar" should be "foo *bar"
Signed-off-by: Asaf Vertz
---
drivers/staging/rtl8723au/core/rtw_efuse.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_efuse.c
b/drivers/st
To be future-proof and for better readability the time comparisons are
modified to use time_after() instead of plain, error-prone math.
Signed-off-by: Asaf Vertz
---
drivers/usb/host/max3421-hcd.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host
To be future-proof and for better readability the time comparisons are
modified to use time_before, time_after, and time_after_eq instead of
plain, error-prone math.
Signed-off-by: Asaf Vertz
---
drivers/net/ethernet/cirrus/cs89x0.c | 27 ++-
1 files changed, 14
To be future-proof and for better readability the time comparisons are
modified to use time_after() instead of plain, error-prone math.
Signed-off-by: Asaf Vertz
---
drivers/media/dvb-frontends/stb0899_drv.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers
Fixed a coding style error, trailing whitespace.
Signed-off-by: Asaf Vertz
---
drivers/video/vgastate.c | 82 +++---
1 files changed, 41 insertions(+), 41 deletions(-)
diff --git a/drivers/video/vgastate.c b/drivers/video/vgastate.c
index b91c466
On 12/11/2014 06:50 AM, Vinod Koul wrote:
> On Wed, Dec 10, 2014 at 10:00:36AM +0200, Asaf Vertz wrote:
>> Fixed a coding style error, switch and case should be at the same indent
> Please use the right subsystem name for the patches
what subsystem name I should have used?
I used the
Fixed a coding style error, code indent should use tabs where possible
Signed-off-by: Asaf Vertz
---
drivers/crypto/ux500/cryp/cryp_core.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/ux500/cryp/cryp_core.c
b/drivers/crypto/ux500/cryp
Fixed a coding style error, switch and case should be at the same indent
Signed-off-by: Asaf Vertz
---
drivers/dma/imx-sdma.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index 88afc48..8729877 100644
Fixed a coding style error, macros with complex values should be
enclosed in parentheses.
Signed-off-by: Asaf Vertz
---
Changes in v2:
- use do {...} while (0) instead of {...}
drivers/input/touchscreen/edt-ft5x06.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a
On 12/09/2014 08:44 AM, Joe Perches wrote:
> On Tue, 2014-12-09 at 08:34 +0200, Asaf Vertz wrote:
>> Fixed a coding style error, macros with complex values should be
>> enclosed in parentheses.
>>
>> -#define EDT_ATTR_CHECKSET(name, reg) \
>> +#define EDT_ATTR_C
Fixed a coding style error, macros with complex values should be
enclosed in parentheses.
Signed-off-by: Asaf Vertz
---
drivers/input/touchscreen/edt-ft5x06.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/input/touchscreen/edt-ft5x06.c
b/drivers/input
27 matches
Mail list logo
