Re: [RFC PATCH bpf-next] bpf: change syscall_nr type to int in struct syscall_tp_t

On Thu, Oct 12, 2023 at 04:32:51PM -0700, Andrii Nakryiko wrote: > On Thu, Oct 12, 2023 at 6:43 AM Steven Rostedt wrote: > > > > On Thu, 12 Oct 2023 13:45:50 +0200 > > Artem Savkov wrote: > > > > > linux-rt-devel tree contains a patch (b1773eac3f29c ("sch

[PATCH bpf-next] bpf: change syscall_nr type to int in struct syscall_tp_t

trace_(enter|exit) and changing the tests to use these structs to dereference context. Signed-off-by: Artem Savkov Acked-by: Steven Rostedt (Google) --- kernel/trace/trace_syscalls.c| 4 ++-- tools/testing/selftests/bpf/progs/profiler.inc.h | 2 +- tools/testing/selftests/bpf/pr

[RFC PATCH bpf-next] bpf: change syscall_nr type to int in struct syscall_tp_t

trace_(enter|exit) and changing the tests to use these structs to dereference context. Signed-off-by: Artem Savkov --- kernel/trace/trace_syscalls.c| 4 ++-- tools/testing/selftests/bpf/progs/profiler.inc.h | 2 +- tools/testing/selftests/bpf/progs/test_vmlinux.c | 4 ++-- 3 files

Re: [RFC PATCH] tracing: change syscall number type in struct syscall_trace_*

On Wed, Oct 04, 2023 at 02:55:47PM +0200, Artem Savkov wrote: > On Tue, Oct 03, 2023 at 09:38:44PM -0400, Steven Rostedt wrote: > > On Mon, 2 Oct 2023 15:52:42 +0200 > > Artem Savkov wrote: > > > > > linux-rt-devel tree contains a patch that adds an extra memb

Re: [RFC PATCH] tracing: change syscall number type in struct syscall_trace_*

On Tue, Oct 03, 2023 at 09:38:44PM -0400, Steven Rostedt wrote: > On Mon, 2 Oct 2023 15:52:42 +0200 > Artem Savkov wrote: > > > linux-rt-devel tree contains a patch that adds an extra member to struct > > trace_entry. This causes the offset of args field in struct > >

Re: [RFC PATCH] tracing: change syscall number type in struct syscall_trace_*

On Tue, Oct 03, 2023 at 03:11:15PM -0700, Andrii Nakryiko wrote: > On Mon, Oct 2, 2023 at 6:53 AM Artem Savkov wrote: > > > > linux-rt-devel tree contains a patch that adds an extra member to struct > > can you please point to the patch itself that makes that change? Of

[RFC PATCH] tracing: change syscall number type in struct syscall_trace_*

CES; 10493 } This patch changes the type of nr member in syscall_trace_* structs to be long so that "args" offset is equal to that in struct trace_event_raw_sys_enter. Signed-off-by: Artem Savkov --- kernel/trace/trace.h | 4 ++-- kernel/trace/trace_syscalls.c | 7 ++

Re: [PATCH] kbuild: add extra-y to targets-for-modules

On Thu, Dec 17, 2020 at 05:26:07PM +0900, Masahiro Yamada wrote: > On Thu, Dec 17, 2020 at 8:04 AM Joe Lawrence wrote: > > > > On 12/16/20 1:14 AM, Masahiro Yamada wrote: > > > On Tue, Dec 8, 2020 at 11:31 PM Artem Savkov > > > wrote: > > >> > >

Re: [PATCH] kbuild: add extra-y to targets-for-modules

x27;always-y' is built after 'targets-for-modules'. This makes > > > 'targets-for-modules' fails because kpatch.lds isn't there. > > > > > > Heh, you rely on the targets built from left to right, > > and you have never thought Make supports

Re: [PATCH] pty: do tty_flip_buffer_push without port->lock in pty_write

Hello Sergey, On Fri, Sep 04, 2020 at 04:43:33PM +0900, Sergey Senozhatsky wrote: > On (20/09/01 14:01), Artem Savkov wrote: > [..] > > It looks like the commit was aimed to protect tty_insert_flip_string and > > there is no need for tty_flip_buffer_push to

[PATCH v2] pty: do tty_flip_buffer_push without port->lock in pty_write

tring and there is no need for tty_flip_buffer_push to be under this lock. Fixes: b6da31b2c07c ("tty: Fix data race in tty_insert_flip_string_fixed_flag") Signed-off-by: Artem Savkov Acked-by: Jiri Slaby --- v2: trimmed stack traces in commit message. drivers/tty/pty.c | 2 +- 1 fil

[PATCH] pty: do tty_flip_buffer_push without port->lock in pty_write

R11: 0246 R12: 7f0446d836c0 [30129.876675] R13: 0002 R14: 7f0446d7e880 R15: 0002 It looks like the commit was aimed to protect tty_insert_flip_string and there is no need for tty_flip_buffer_push to be under this lock. Fixes: b6da31b2c07c ("tty: Fix dat

[tip:x86/build] x86/tools/relocs: Fix big section header tables

Commit-ID: f36e7495dd3990d6848e6d6703c78f1f17a97538 Gitweb: https://git.kernel.org/tip/f36e7495dd3990d6848e6d6703c78f1f17a97538 Author: Artem Savkov AuthorDate: Thu, 29 Nov 2018 16:56:15 +0100 Committer: Ingo Molnar CommitDate: Fri, 19 Apr 2019 20:54:07 +0200 x86/tools/relocs: Fix big

Re: [PATCH v3 2/9] kbuild: Support for Symbols.list creation

On Wed, Apr 10, 2019 at 11:50:51AM -0400, Joe Lawrence wrote: > -clean: archclean vmlinuxclean > +klpclean: > + $(Q) rm -f $(objtree)/Symbols.list nit: $(SLIST) can be used here. > +clean: archclean vmlinuxclean klpclean > > # mrproper - Delete all generated files, including .config > # >

Re: mm: race in put_and_wait_on_page_locked()

On Mon, Feb 04, 2019 at 12:42:50PM -0800, Hugh Dickins wrote: > On Mon, 4 Feb 2019, Artem Savkov wrote: > > > Hi Hugh, > > > > Your recent patch 9a1ea439b16b "mm: put_and_wait_on_page_locked() while > > page is migrated" seems to have introduced a race i

mm: race in put_and_wait_on_page_locked()

Hi Hugh, Your recent patch 9a1ea439b16b "mm: put_and_wait_on_page_locked() while page is migrated" seems to have introduced a race into page migration process. I have a host that eagerly reproduces the following BUG under stress: [ 302.847402] page:f0021700 count:0 mapcount:0 mapping:c0

[PATCH v2] x86/tools/relocs: fix big section header tables

e_shstrndx. This case is easily reproducible with KCFLAGS="-ffunction-sections", bzImage build fails with "String table index out of bounds" error. Signed-off-by: Artem Savkov --- arch/x86/tools/relocs.c | 58 + 1 file changed, 41 inserti

Re: [PATCH] x86/tools/relocs: fix big section header tables

On Thu, Nov 29, 2018 at 08:23:12AM -0600, Josh Poimboeuf wrote: > On Thu, Nov 29, 2018 at 02:51:33PM +0100, Artem Savkov wrote: > > In case when the number of entries in the section header table is larger > > then or equal to SHN_LORESERVE the size of the table is held in the sh_siz

[PATCH] x86/tools/relocs: fix big section header tables

e_shstrndx. This case is easily reproducible with KCFLAGS="-ffunction-sections", bzImage build fails with "String table index out of bounds" error. Signed-off-by: Artem Savkov --- arch/x86/tools/relocs.c | 58 + 1 file changed, 41 inserti

[tip:core/urgent] objtool: Fix segfault in .cold detection with -ffunction-sections

Commit-ID: 22566c1603030f0a036ad564634b064ad1a55db2 Gitweb: https://git.kernel.org/tip/22566c1603030f0a036ad564634b064ad1a55db2 Author: Artem Savkov AuthorDate: Tue, 20 Nov 2018 11:52:16 -0600 Committer: Ingo Molnar CommitDate: Tue, 20 Nov 2018 18:59:00 +0100 objtool: Fix segfault in

[tip:core/urgent] objtool: Fix double-free in .cold detection error path

Commit-ID: 0b9301fb632f7111a3293a30cc5b20f1b82ed08d Gitweb: https://git.kernel.org/tip/0b9301fb632f7111a3293a30cc5b20f1b82ed08d Author: Artem Savkov AuthorDate: Tue, 20 Nov 2018 11:52:15 -0600 Committer: Ingo Molnar CommitDate: Tue, 20 Nov 2018 18:59:00 +0100 objtool: Fix double-free

[PATCH v4 1/2] objtool: fix failed cold symbol doublefree

(). Fixes: 13810435b9a7 ("objtool: Support GCC 8's cold subfunctions") Signed-off-by: Artem Savkov --- tools/objtool/elf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 6dbb9fae0f9d..e7a7ac40e045 100644 --- a/tools/objtool/

[PATCH v4 2/2] objtool: fix .cold functions parent symbols search

g it in place. Fixes: 13810435b9a7 ("objtool: Support GCC 8's cold subfunctions") Signed-off-by: Artem Savkov --- tools/objtool/elf.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index e7a7ac40e045..b8f

[PATCH v4 0/2] objtool: read_symbols() fixes

The series started with 'parent symbol search' patch, but I found another issue in read_symbols() while testing the failure-path. Artem Savkov (2): objtool: fix failed cold symbol doublefree objtool: fix .cold functions parent symbols search tools/objtool/elf.c | 19

[PATCH v3 1/2] objtool: fix failed cold symbol doublefree

tions" Signed-off-by: Artem Savkov --- tools/objtool/elf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 6dbb9fae0f9d..3decd43477df 100644 --- a/tools/objtool/elf.c +++ b/tools/objtool/elf.c @@ -312,7 +312,7 @@ static in

[PATCH v3 2/2] objtool: fix .cold functions parent symbols search

g it in place. Fixes: 13810435b9a7 "objtool: Support GCC 8's cold subfunctions" Signed-off-by: Artem Savkov --- tools/objtool/elf.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 3decd43477df..15d9acfb2

[PATCH v3 0/2] objtool: read_symbols() fixes

The series started with 'parent symbol search' patch, but I found another issue in read_symbols() while testing the failure-path. Artem Savkov (2): objtool: fix failed cold symbol doublefree objtool: fix .cold functions parent symbols search tools/objtool/

Re: [PATCH v2] objtool: fix .cold. functions parent symbols search

On Fri, Nov 09, 2018 at 11:23:09AM -0600, Josh Poimboeuf wrote: > On Wed, Nov 07, 2018 at 10:45:15PM +0100, Artem Savkov wrote: > > Because find_symbol_by_name() traverses the same lists as read_symbols() > > changing sym->name in place without copying it aff

[PATCH v2] objtool: fix .cold. functions parent symbols search

place. Signed-off-by: Artem Savkov --- tools/objtool/elf.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 6dbb9fae0f9d..781c8afb29b9 100644 --- a/tools/objtool/elf.c +++ b/tools/objtool/elf.c @@ -298,6 +298,7 @@ static in

Re: [PATCH] objtool: fix .cold. functions parent symbols search

On Wed, Nov 07, 2018 at 11:08:56AM -0600, Josh Poimboeuf wrote: > On Wed, Nov 07, 2018 at 03:05:59PM +0100, Artem Savkov wrote: > > The way it is currently done it is possible for read_symbols() to find the > > same symbol as parent for ".cold" functions. > >

[PATCH] objtool: fix .cold. functions parent symbols search

t in place. Signed-off-by: Artem Savkov --- tools/objtool/elf.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c index 6dbb9fae0f9d..781c8afb29b9 100644 --- a/tools/objtool/elf.c +++ b/tools/objtool/elf.c @@ -298,6 +298,7 @@

[PATCH v2] tracing/kprobes: Fix trace_probe flags on enable_trace_kprobe() failure

every probe to be disabled. Signed-off-by: Artem Savkov --- kernel/trace/trace_kprobe.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index 21f718472942..27ace4513c43 100644 --- a/kernel/trace

[PATCH] kprobes: fix trace_probe flags in enable_trace_kprobe

every probe to be disabled. Signed-off-by: Artem Savkov --- kernel/trace/trace_kprobe.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index 21f718472942..fb887ced5056 100644 --- a/kernel/trace

Re: [PATCH 1/2] sun4i_ss_prng: fix return value of sun4i_ss_prng_generate

On Wed, Feb 07, 2018 at 10:56:59AM +0100, Corentin Labbe wrote: > On Tue, Feb 06, 2018 at 10:20:21PM +0100, Artem Savkov wrote: > > According to crypto/rng.h generate function should return 0 on success > > and < 0 on error. > > > > Fixes: b8ae5c7387ad ("cryp

[PATCH 1/2] sun4i_ss_prng: fix return value of sun4i_ss_prng_generate

According to crypto/rng.h generate function should return 0 on success and < 0 on error. Fixes: b8ae5c7387ad ("crypto: sun4i-ss - support the Security System PRNG") Signed-off-by: Artem Savkov --- drivers/crypto/sunxi-ss/sun4i-ss-prng.c | 2 +- 1 file changed, 1 insertion(+

[PATCH 2/2] sun4i_ss_prng: convert lock to _bh in sun4i_ss_prng_generate

Lockdep detects a possible deadlock in sun4i_ss_prng_generate() and throws an "inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage" warning. Disabling softirqs to fix this. Fixes: b8ae5c7387ad ("crypto: sun4i-ss - support the Security System PRNG") Signed-off-by: Artem Savk

[PATCH 0/2] sun4i_ss_prng fixes

IPSec hasn't been working on my a10 board since 4.14 and it turned out to be caused by sun4i_ss_rng driver. Artem Savkov (2): sun4i_ss_prng: fix return value of sun4i_ss_prng_generate sun4i_ss_prng: convert lock to _bh in sun4i_ss_prng_generate drivers/crypto/sunxi-ss/sun4i-ss-prng.

Re: [PATCH] xfrm: init skb_head lock for transport-mode packets

On Thu, Jan 04, 2018 at 10:01:32PM +1100, Herbert Xu wrote: > On Thu, Jan 04, 2018 at 11:36:28AM +0100, Artem Savkov wrote: > > Commit acf568ee859f "xfrm: Reinject transport-mode packets through tasklet" > > adds an sk_buff_head queue, but never initializes trans->queu

[PATCH] xfrm: init skb_head lock for transport-mode packets

kb_queue_head_init() to properly initialize said lock. Signed-off-by: Artem Savkov --- net/xfrm/xfrm_input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c index 26b10eb7a206..d5389b9dbbb9 100644 --- a/net/xfrm/xfrm_input.c +++

[PATCH] xfrm: don't call xfrm_policy_cache_flush under xfrm_state_lock

30d78c14a8 xfrm: add xdst pcpu cache Signed-off-by: Artem Savkov --- net/xfrm/xfrm_state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c index 0dab1cd79ce4..12213477cd3a 100644 --- a/net/xfrm/xfrm_state.c +++ b/net/xfrm/xfrm_s

[PATCH v3] ebtables: fix race condition in frame_filter_net_init()

: Artem Savkov --- include/linux/netfilter_bridge/ebtables.h | 7 --- net/bridge/netfilter/ebtable_broute.c | 4 ++-- net/bridge/netfilter/ebtable_filter.c | 4 ++-- net/bridge/netfilter/ebtable_nat.c| 4 ++-- net/bridge/netfilter/ebtables.c | 17

[PATCH v2] ebtables: fix race condition in frame_filter_net_init()

It is possible for ebt_in_hook to be triggered before ebt_table is assigned resulting in a NULL-pointer dereference. Make sure hooks are registered as the last step. Fixes: aee12a0a3727 ebtables: remove nf_hook_register usage Signed-off-by: Artem Savkov --- include/linux/netfilter_bridge

Re: [PATCH] ebtables: fix race condition in frame_filter_net_init()

On Tue, Sep 26, 2017 at 02:42:11PM +0200, Florian Westphal wrote: > Artem Savkov wrote: > > It is possible for ebt_in_hook to be triggered before ebt_table is assigned > > resulting in a NULL-pointer dereference. Make sure hooks are > > registered as the last step. >

[PATCH] ebtables: fix race condition in frame_filter_net_init()

It is possible for ebt_in_hook to be triggered before ebt_table is assigned resulting in a NULL-pointer dereference. Make sure hooks are registered as the last step. Fixes: aee12a0a3727 ebtables: remove nf_hook_register usage Signed-off-by: Artem Savkov --- include/linux/netfilter_bridge

Re: MADV_FREE is broken

On Wed, Sep 20, 2017 at 03:37:33PM -0700, Shaohua Li wrote: > On Wed, Sep 20, 2017 at 11:01:47AM +0200, Artem Savkov wrote: > > Hi All, > > > > We recently started noticing madvise09[1] test from ltp failing strangely. > > The > > test does the following: maps

MADV_FREE is broken

Hi All, We recently started noticing madvise09[1] test from ltp failing strangely. The test does the following: maps 32 pages, sets MADV_FREE for the range it got, dirties 2 of the pages, creates memory pressure and check that nondirty pages are free. The test hanged while accessing the last 4 pag

Re: possible circular locking dependency mmap_sem/cpu_hotplug_lock.rw_sem

On Thu, Aug 31, 2017 at 02:09:51PM +0200, Michal Hocko wrote: > On Thu 31-08-17 13:10:06, Artem Savkov wrote: > > Hi Michal, > > > > On Wed, Aug 30, 2017 at 05:43:15PM +0200, Michal Hocko wrote: > > > The previous patch is insufficient. drain_all_stock can still race

Re: possible circular locking dependency mmap_sem/cpu_hotplug_lock.rw_sem

Hi Michal, On Wed, Aug 30, 2017 at 05:43:15PM +0200, Michal Hocko wrote: > The previous patch is insufficient. drain_all_stock can still race with > the memory offline callback and the underlying memcg disappear. So we > need to be more careful and pin the css on the memcg. This patch > instead...

Re: possible circular locking dependency mmap_sem/cpu_hotplug_lock.rw_sem

On Wed, Aug 16, 2017 at 03:39:14PM +0200, Laurent Dufour wrote: > On 15/08/2017 21:01, Paul E. McKenney wrote: > > On Mon, Aug 07, 2017 at 04:09:47PM +0200, Artem Savkov wrote: > >> Hello, > >> > >> After commit fc8dffd "cpu/hotplug: Convert hotplug lo

[PATCH v2] iommu/arm-smmu: fix null-pointer dereference in arm_smmu_add_device

is a NULL-pointer dereference panic during boot on some hosts. Signed-off-by: Artem Savkov --- drivers/iommu/arm-smmu.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index b97188a..2d80fa8 100644 --- a/drivers/iommu/arm-smmu.c +++

[PATCH] iommu/arm-smmu: fix null-pointer dereference in arm_smmu_add_device

is a NULL-pointer dereference panic during boot on some hosts. Signed-off-by: Artem Savkov --- drivers/iommu/arm-smmu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index b97188a..95f1c86 100644 --- a/drivers/iommu/arm-smmu.c +++ b/dri

possible circular locking dependency mmap_sem/cpu_hotplug_lock.rw_sem

Hello, After commit fc8dffd "cpu/hotplug: Convert hotplug locking to percpu rwsem" the following lockdep splat started showing up on some systems while running ltp's madvise06 test (right after first dirty_pages call [1]). [1] https://github.com/linux-test-project/ltp/blob/master/testcases/kerne

Re: [PATCH] iommu/amd: Fix schedule-while-atomic BUG in initialization code

On Wed, Jul 26, 2017 at 02:26:14PM +0200, Joerg Roedel wrote: > Hi Artem, Thomas, > > On Wed, Jul 26, 2017 at 12:42:49PM +0200, Thomas Gleixner wrote: > > On Tue, 25 Jul 2017, Artem Savkov wrote: > > > > > Hi, > > > > > > Commit 1c3c5ea "

amd-iommu/x2apic: sleeping function called from invalid context

Hi, Commit 1c3c5ea "sched/core: Enable might_sleep() and smp_processor_id() checks early" seem to have uncovered an issue with amd-iommu/x2apic. Starting with that commit the following warning started to show up on AMD systems during boot: [0.140480] smpboot: Max logical packages: 6 [0.

[PATCH v2] Use ctlr directly in rdac_failover_get()

..@vger.kernel.org Signed-off-by: Artem Savkov --- drivers/scsi/device_handler/scsi_dh_rdac.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/device_handler/scsi_dh_rdac.c b/drivers/scsi/device_handler/scsi_dh_rdac.c index 3cbab87..2ceff58 100644

[PATCH] Use ctlr directly in rdac_failover_get()

[ 18.436192] CR2: 0790 [ 18.436198] ---[ end trace 40f3e4dca1ffabdd ]--- [ 18.436199] Kernel panic - not syncing: Fatal exception [ 18.436222] Kernel Offset: disabled [-- MARK -- Thu May 18 11:45:00 2017] Signed-off-by: Artem Savkov --- drivers/scsi/device_handler/s

[PATCH v2] nfs/filelayout: fix NULL pointer dereference in fl_pnfs_update_layout()

t_lseg+0x29/0x100 [nfsv4] RSP: c9ff39b8 [ 3000.672462] CR2: 003c Signed-off-by: Artem Savkov --- fs/nfs/filelayout/filelayout.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/nfs/filelayout/filelayout.c b/fs/nfs/filelayout/filelayout.c index a

[PATCH] nfs/filelayout: fix NULL pointer dereference in fl_pnfs_update_layout()

00 [ 3000.671831] RIP: pnfs_put_lseg+0x29/0x100 [nfsv4] RSP: c9ff39b8 [ 3000.672462] CR2: 003c Signed-off-by: Artem Savkov --- fs/nfs/filelayout/filelayout.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/nfs/filelayout/filelayout.c b/fs/nfs/filelayout/filelayout.c index ac

Re: [PATCH] ip6_offload: check segs for NULL in ipv6_gso_segment.

On Thu, Dec 01, 2016 at 09:47:17PM -0500, Don Bowman wrote: > I have been having this problem (4.9rc6). > I applied this patch. > I still have the problem. > > My stack trace (attached as image, i did not get it in text) is: > > ipv6_gso_segment > skb_mac_gso_segment > __skb_gso_segment > validat

Re: [PATCH] ip6_offload: check segs for NULL in ipv6_gso_segment.

On Thu, Dec 01, 2016 at 06:34:07AM -0800, Eric Dumazet wrote: > On Thu, 2016-12-01 at 14:06 +0100, Artem Savkov wrote: > > segs needs to be checked for being NULL in ipv6_gso_segment() before calling > > skb_shinfo(segs), otherwise kernel can run into a NULL-pointer dereference: &

[PATCH] ip6_offload: check segs for NULL in ipv6_gso_segment.

2d78d0 ]--- Signed-off-by: Artem Savkov --- net/ipv6/ip6_offload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/ip6_offload.c b/net/ipv6/ip6_offload.c index 1fcf61f..89c59e6 100644 --- a/net/ipv6/ip6_offload.c +++ b/net/ipv6/ip6_offload.c @@ -99,7 +99,7 @@ static

Re: arm64 build failure with CONFIG_ARM64_LSE_ATOMICS=y

On Thu, Nov 03, 2016 at 06:46:25PM +, Catalin Marinas wrote: > On Thu, Nov 03, 2016 at 12:12:38PM +0100, Artem Savkov wrote: > > On Thu, Nov 03, 2016 at 10:39:43AM +, Suzuki K Poulose wrote: > > > On 02/11/16 23:28, Will Deacon wrote: > > > > On Wed, Nov 02, 2

Re: arm64 build failure with CONFIG_ARM64_LSE_ATOMICS=y

On Thu, Nov 03, 2016 at 10:39:43AM +, Suzuki K Poulose wrote: > On 02/11/16 23:28, Will Deacon wrote: > > Hi Artem, > > > > On Wed, Nov 02, 2016 at 05:44:27PM +0100, Artem Savkov wrote: > > > Hello Catalin, > > > > > > Looks like your patch

arm64 build failure with CONFIG_ARM64_LSE_ATOMICS=y

Hello Catalin, Looks like your patch "efd9e03 arm64: Use static keys for CPU features" breaks arm64 build with "CONFIG_ARM64_LSE_ATOMICS=y" because it creates a circular dependency for asm/lse.h through jump_label.h: CC arch/arm64/kernel/asm-offsets.s In file included from ./arch/arm64/inc

Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng.

On Mon, Oct 24, 2016 at 03:50:54PM +0100, David Howells wrote: > Artem Savkov wrote: > > > > > IMO, the preferable fix depends on your future plan. > > > > If you plan to continue using both ANSI X9.31 DRNG and DRBG - I agree > > > > with the > >

Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng.

On Tue, Sep 06, 2016 at 07:16:13PM +0100, David Howells wrote: > Kirill Marinushkin wrote: > > > IMO, the preferable fix depends on your future plan. > > If you plan to continue using both ANSI X9.31 DRNG and DRBG - I agree with > > the > > patch suggested by Ar

Re: [PATCH] Use proper lock in fscache_objlist_config.

On Tue, Oct 04, 2016 at 04:43:31PM +0100, David Howells wrote: > Artem Savkov wrote: > > > fscache_objlist_config doesn't hold rkey->sem when calling user_key_payload, > > that can result in a "suspicious RCU usage" warning. It does hold > > rcu_read_lo

Re: [PATCH] Fix suspicious RCU usage in nfs_idmap_get_key.

On Tue, Oct 04, 2016 at 04:45:14PM +0100, David Howells wrote: > Artem Savkov wrote: > > > nfs_idmap_get_key doesn't hold rkey->sem when calling user_key_payload > > resulting in a "suspicious RCU usage" lockdep splat. It does, however hold > >

[PATCH] Use proper lock in fscache_objlist_config.

fscache_objlist_config doesn't hold rkey->sem when calling user_key_payload, that can result in a "suspicious RCU usage" warning. It does hold rcu_read_lock, so it either needs to use unprotected rcu_dereference, or take rkey->sem instead of rcu_read_lock. Signed-off-by:

[PATCH] Fix suspicious RCU usage in nfs_idmap_get_key.

nfs_idmap_get_key doesn't hold rkey->sem when calling user_key_payload resulting in a "suspicious RCU usage" lockdep splat. It does, however hold rcu_read_lock, so it either needs to use unprotected rcu_dereference, or take rkey->sem instead of rcu_read_lock. Signed-off-by:

Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng.

On Tue, Sep 06, 2016 at 02:11:56PM +0100, David Howells wrote: > Artem Savkov wrote: > > > > > - select CRYPTO > > > > + depends on (CRYPTO_ANSI_CPRNG = y || CRYPTO_DRBG = y) > > > > > > Should those be "==" not "=&qu

Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng.

On Tue, Sep 06, 2016 at 01:58:49PM +0100, David Howells wrote: > Artem Savkov wrote: > > > - select CRYPTO > > + depends on (CRYPTO_ANSI_CPRNG = y || CRYPTO_DRBG = y) > > Should those be "==" not "="? Accodring to Documentation/kbuild/kconfig

[PATCH] security/keys: make BIG_KEYS dependent on stdrng.

ce. Signed-off-by: Artem Savkov --- security/keys/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/keys/Kconfig b/security/keys/Kconfig index f826e87..d942c7c 100644 --- a/security/keys/Kconfig +++ b/security/keys/Kconfig @@ -41,7 +41,7 @@ config BIG_KEYS

[PATCH v2] Make __xfs_xattr_put_listen preperly report errors.

verwriting data stored at (context->alist - 1). Signed-off-by: Artem Savkov --- fs/xfs/xfs_xattr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/xfs/xfs_xattr.c b/fs/xfs/xfs_xattr.c index ea62245..6290093 100644 --- a/fs/xfs/xfs_xattr.c +++ b/fs/xfs/xfs_xattr.c @@ -147,6 +147,7 @@ __xfs_xatt

Re: [PATCH] Make __xfs_xattr_put_listen preperly report errors.

On Fri, Aug 26, 2016 at 08:42:15AM +1000, Dave Chinner wrote: > On Thu, Aug 25, 2016 at 10:21:09AM +0200, Artem Savkov wrote: > > On Thu, Aug 25, 2016 at 10:24:08AM +1000, Dave Chinner wrote: > > > On Wed, Aug 24, 2016 at 10:08:33AM +0200, Artem Savkov wrote: > > > >

Re: [PATCH] Make __xfs_xattr_put_listen preperly report errors.

On Thu, Aug 25, 2016 at 10:24:08AM +1000, Dave Chinner wrote: > On Wed, Aug 24, 2016 at 10:08:33AM +0200, Artem Savkov wrote: > > On Wed, Aug 24, 2016 at 11:55:51AM +1000, Dave Chinner wrote: > > > On Tue, Aug 23, 2016 at 05:54:13PM +0200, Artem Savkov wrote: > > >

Re: [PATCH] Make __xfs_xattr_put_listen preperly report errors.

On Wed, Aug 24, 2016 at 11:55:51AM +1000, Dave Chinner wrote: > On Tue, Aug 23, 2016 at 05:54:13PM +0200, Artem Savkov wrote: > > Commit "xfs: only return -errno or success from attr ->put_listent" changes > > the > > Please quote commits in --oneline format

[PATCH] Make __xfs_xattr_put_listen preperly report errors.

y check seen_enough. This results in a failed assertion: XFS: Assertion failed: context->count >= 0, file: fs/xfs/xfs_xattr.c, line: 175 in insufficient buffer size case. Signed-off-by: Artem Savkov --- fs/xfs/xfs_xattr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/xfs/xfs_xat

[PATCH] X.509: Fix double free in x509_cert_parse().

Patch "crypto: KEYS: convert public key and digsig asym to the akcipher api" introduced double freeing of cert->pub->key. There is no need to free it in error_decode label as it is later freed in x509_free_certificate(). Signed-off-by: Artem Savkov --- crypto/asymmetric_keys/x5

[PATCH v3] Fix NULL pointer dereference in bl_free_device().

a wrong pointer dereference. Fixing this by setting bdev in struct pnfs_block_dev only if we didn't get an error from blkdev_get_by_*(). Signed-off-by: Artem Savkov --- fs/nfs/blocklayout/dev.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/f

[PATCH v2] Fix NULL pointer dereference in bl_free_device().

a wrong pointer dereference. Fixing this by making sure bdev is not an error code in bl_free_device(). Signed-off-by: Artem Savkov --- fs/nfs/blocklayout/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/blocklayout/dev.c b/fs/nfs/blocklayout/dev.c index 118252f

[PATCH] Fix NULL pointer dereference in bl_free_device().

a wrong pointer dereference. Fixing this by making sure bdev is not an error code in bl_free_device(). Signed-off-by: Artem Savkov --- fs/nfs/blocklayout/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/blocklayout/dev.c b/fs/nfs/blocklayout/dev.c index 118252f

[PATCH] rcuperf: Do not wake up shutdown wait queue if "shutdown" is false.

dereference". Fix by checking "shutdown" param before waking up the queue. Signed-off-by: Artem Savkov --- kernel/rcu/rcuperf.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c index 09ffa36..fb45a26 100644 --- a/ke

Re: [PATCHv12 14/37] futex, thp: remove special case for THP in get_futex_key

On Thu, Oct 22, 2015 at 12:49:45PM +0300, Kirill A. Shutemov wrote: > On Thu, Oct 22, 2015 at 10:24:33AM +0200, Artem Savkov wrote: > > On Tue, Oct 06, 2015 at 06:23:41PM +0300, Kirill A. Shutemov wrote: > > > With new THP refcounting, we don't need tricks to stabilize hu

Re: [PATCHv12 14/37] futex, thp: remove special case for THP in get_futex_key

On Tue, Oct 06, 2015 at 06:23:41PM +0300, Kirill A. Shutemov wrote: > With new THP refcounting, we don't need tricks to stabilize huge page. > If we've got reference to tail page, it can't split under us. > > This patch effectively reverts a5b338f2b0b1. > > Signed-off-by: Kirill A. Shutemov > Te

[PATCH] mfd: rt5033: MFD_RT5033 needs to select REGMAP_IRQ

ined! Signed-off-by: Artem Savkov --- drivers/mfd/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index f8ef77d9a..f49f404 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -680,6 +680,7 @@ config MFD_RT5033 depends on I2C=y

[PATCH] aio: rcu_read_lock protection for new rcu_dereference calls

SyS_io_setup+0x89c/0xc70 [ 471.737806] [] ? SyS_io_setup+0x4fd/0xc70 [ 471.741689] [] ? __audit_syscall_entry+0x94/0xe0 [ 471.746080] [] syscall_call+0x7/0xb [ 471.749723] [] ? task_fork_fair+0x240/0x260 Signed-off-by: Artem Savkov --- fs/aio.c | 6 ++ 1 file changed, 6 insertions(+) di

Re: 3.11.0-next-20130905: kernel BUG at include/linux/pagemap.h:343

On Fri, Sep 06, 2013 at 03:26:18PM +0800, Baoquan He wrote: > [ 30.438555] [ cut here ] > [ 30.443385] kernel BUG at include/linux/pagemap.h:343! Seems to be the same one I reported here: http://www.spinics.net/lists/kernel/msg1597973.html -- Regards, Artem -- To

[BUG] trying to lock tailpage in page_fault path

Hi All, Since the "thp-mm-locking-tail-page-is-a-bug-fix" patch (c6d04b4502a07b040b9e8cce835f899913961248 in linux-next.git) from Andrew's tree I get the following trace on pulseaudio start: [ 147.191296] [ cut here ] [ 147.192017] kernel BUG at include/linux/pagemap.h:3

Re: [PATCH tty-next] n_tty: Fix termios_rwsem lockdep false positive

xed, re-order atomic_read_lock so > termios_rwsem can be dropped and reacquired without > triggering lockdep. Works fine, thanks. Reported-and-tested-by: Artem Savkov > Reported-by: Artem Savkov > Reported-by: Sergey Senozhatsky > Signed-off-by: Peter Hurley &

Re: [PATCH] n_tty: release atomic_read_lock before calling schedule_timeout()

On Tue, Jul 30, 2013 at 12:39:54PM -0400, Peter Hurley wrote: > On 07/30/2013 11:35 AM, Artem Savkov wrote: > >ldata->atomic_read_lock should be released before scheduling as well as > >tty->termios_rwsem, otherwise there is a potential deadlock detected by > >

[PATCH] n_tty: release atomic_read_lock before calling schedule_timeout()

822058] [] ? n_tty_read+0x49b/0x660 [ 16.822058] [] n_tty_read+0x49b/0x660 [ 16.822058] [] ? try_to_wake_up+0x210/0x210 [ 16.822058] [] tty_read+0x86/0xf0 [ 16.822058] [] vfs_read+0xc3/0x130 [ 16.822058] [] SyS_read+0x62/0xa0 [ 16.822058] [] ? trace_hardirqs_on_thunk+0x3a/0x3f [ 16.82205

Re: [PATCH] drm: i915_gem_inactive_scan: insufficient nr_to_scan size

On Tue, Jul 23, 2013 at 11:18:06PM +0400, Artem Savkov wrote: > nr_to_scan needs to be (unsigned) long, not int, otherwise we get negative > values on 32bit systems during shrink resulting in lots of messages like one > below. > > [ 4078.989603] shrink_slab: i915_gem_inactiv

[PATCH] drm: i915_gem_inactive_scan: insufficient nr_to_scan size

nvert shrinkers to new count/scan API" (383e4f4a4cdeb2dd552e90811089bcb4d41eb32e in linux-next.git) Signed-off-by: Artem Savkov --- drivers/gpu/drm/i915/i915_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_g

Re: [tip:timers/core] hrtimers: Support resuming with two or more CPUs online (but stopped)

On Fri, Jul 05, 2013 at 12:36:50PM +0200, Thomas Gleixner wrote: > On Fri, 5 Jul 2013, Thomas Gleixner wrote: > > On Fri, 5 Jul 2013, David Vrabel wrote: > > You failed to CC Artem :( > Second thought. > Where is that warning? Can't find it in neither in Linus tree nor in tip > > > > [ 4363.083800]

Re: [tip:timers/core] hrtimers: Support resuming with two or more CPUs online (but stopped)

; You failed to CC Artem :( > > > On 05/07/13 10:30, Artem Savkov wrote: > > > This commit brings up a warning about a potential deadlock in > > > smp_call_function_many() discussed previously: > > > https://lkml.org/lkml/2013/4/18/546 > > >

Re: [tip:timers/core] hrtimers: Support resuming with two or more CPUs online (but stopped)

This commit brings up a warning about a potential deadlock in smp_call_function_many() discussed previously: https://lkml.org/lkml/2013/4/18/546 [ 4363.082047] PM: Restoring platform NVS memory [ 4363.082471] [ cut here ] [ 4363.083800] WARNING: CPU: 0 PID: 3977 at kernel/s

[BUG]: missing shinfo with netlink_alloc_large_skb

Hello, I ran into a bug while running trinity with write/writev syscalls. Seems like it has been introduced by "netlink: allow large data transfers from user-space" commit. nf_fib_input calls skb_clone which expects skb_shinfo to be allocated, but netlink_alloc_large_skb doesn't do that, should it

[PATCH] non-swapcache pages in end_swap_bio_read()

7 bc 16 82 31 c0 49 c1 ec 39 49 c1 e9 10 41 83 e1 01 e8 6c d2 ad 00 5b 4a 8b 04 e5 e0 bf 14 83 41 5c c9 c3 <0f> 0b eb fe 90 48 8b 07 55 48 89 e5 a9 00 00 01 00 74 12 e8 3d RIP [] page_swap_info+0xab/0xb0 RSP Signed-off-by: Artem Savkov --- m

[BUG] non-swapcache page in end_swap_bio_read()

Hello all, I'm hitting the following BUG_ON during boot when CONFIG_PM_STD_PARTITION or "resume" kernel boot option are set. Looks like this issue was introduced in (or brought up to light by) "mm: remove compressed copy from zram in-memory" (84e5bb4f06e6d6f0c4dfc033b4700702ed8aaccc in linux-next.

  1   2   >