Re: [PATCH] [media] solo6x10: hide unused variable

2017-09-16 Thread Anton Sviridenko
ci/solo6x10/solo6x10-gpio.c > +++ b/drivers/media/pci/solo6x10/solo6x10-gpio.c > @@ -162,7 +162,9 @@ static void solo_gpiochip_set(struct gpio_chip *chip, > > int solo_gpio_init(struct solo_dev *solo_dev) > { > +#ifdef CONFIG_GPIOLIB > int ret; > +#endif > > solo_gpio_config(solo_dev); > #ifdef CONFIG_GPIOLIB > -- > 2.9.0 > Acked-by: Anton Sviridenko

Re: [PATCH] [media] solo6x10: export hardware GPIO pins 8:31 to gpiolib interface

2017-08-08 Thread Anton Sviridenko
On Mon, Aug 07, 2017 at 06:26:44PM +0100, Andrey Utkin wrote: > Hi Anton, > Hi > > @@ -90,16 +93,110 @@ static void solo_gpio_config(struct solo_dev *solo_dev) > > > > > /* Initially set relay status to 0 */ > > Do you mean that relay is initially disabled? > Maybe a rewording would make

[PATCH] [media] solo6x10: export hardware GPIO pins 8:31 to gpiolib interface

2017-08-02 Thread Anton Sviridenko
userspace DVR software can switch relays and read sensor states when GPIO extension cards are attached to Softlogic solo6x10 based video capture cards. Signed-off-by: Anton Sviridenko --- drivers/media/pci/solo6x10/solo6x10-gpio.c | 97 ++ drivers/media/pci/solo6x10/solo6x10

[PATCH] [media] solo6x10: fix detection of TW2864B chips

2017-07-01 Thread Anton Sviridenko
Could not initialize any techwell chips [276582.402781] solo6x10: probe of :07:00.0 failed with error -22 Signed-off-by: Anton Sviridenko --- drivers/media/pci/solo6x10/solo6x10-tw28.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/pci/solo6x10/solo6x10-tw28.c b/drivers

[PATCH v2] [media] solo6x10: release vb2 buffers in solo_stop_streaming()

2017-03-09 Thread Anton Sviridenko
: 0246 R12: [ 8130.281299] R13: 00a0 R14: 7ffe467f6530 R15: 01f32228 [ 8130.281300] ---[ end trace 00695dc96be646e7 ]--- Signed-off-by: Anton Sviridenko --- drivers/media/pci/solo6x10/solo6x10-v4l2.c | 11 +++ 1 file changed, 11

Re: [PATCH] [media] solo6x10: release vb2 buffers in solo_stop_streaming()

2017-03-09 Thread Anton Sviridenko
On Thu, Mar 09, 2017 at 12:55:35PM +0100, Hans Verkuil wrote: > > + dbg_buf_cnt++; > > Left-over from debugging? This variable doesn't exist in the mainline code, so > this patch doesn't compile. > > Regards, > > Hans Exactly, left-over from debugging, thank you. Going to resubm

[PATCH] [media] solo6x10: release vb2 buffers in solo_stop_streaming()

2017-03-08 Thread Anton Sviridenko
] R13: 00a0 R14: 7ffe467f6530 R15: 01f32228 [ 8130.281300] ---[ end trace 00695dc96be646e7 ]--- Signed-off-by: Anton Sviridenko --- drivers/media/pci/solo6x10/solo6x10-v4l2.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/media/pci/solo6x10