Hi Scott,
I'm hitting this issue and Rick just pointed my at your patch. Any
chance we could get it upstream?
Thanks,
Anton
> On PowerPC, memory_add_physaddr_to_nid() uses a linear search to find
> an LMB matching the given address. This scales very poorly when there
> are many LMBs. The poor
onize_rcu() once, then reset each of the buffers. This brings
> the time down to about 0.5s.
It's gone from somewhere more than 10 minutes (I gave up waiting) to
3 seconds. Nice work!
Tested-by: Anton Blanchard
Thanks,
Anton
> Cc: Paul McKenney
> Cc: Anton Blanchard
> Cc: S
Hi,
We are seeing hard lockup warnings caused by CFS bandwidth control code. The
test case below fails almost immediately on a reasonably large (144 thread)
POWER9 guest with:
watchdog: CPU 80 Hard LOCKUP
watchdog: CPU 80 TB:1134131922788, last heartbeat TB:1133207948315 (1804ms ago)
Modules link
> > Unfortunately it doesn't appear to work, at least with ppc64le
> > clang:
> >
> > fs/ext4/mballoc.c:2303:17: error: fields must have a constant size:
> > 'variable length array in structure' extension will never be
> > supported ext4_grpblk_t counters[blocksize_bits + 2];
>
> My fix for thi
Hi Arnd,
> After commit 62d1034f53e3 ("fortify: use WARN instead of BUG for
> now"), we get a warning about possible stack overflow from a memcpy
> that was not strictly bounded to the size of the local variable:
>
> inlined from 'ext4_mb_seq_groups_show' at
> fs/ext4/mballoc.c:2322:2: includ
s likely moved the break even point for this.
Acked-by: Anton Blanchard
Anton
> Signed-off-by: Andrew Jeffery
> ---
> arch/powerpc/lib/copyuser_power7.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/lib/copyuser_power7.S
> b/arc
From: Anton Blanchard
The ir-spi driver has 2 issues which prevents it from working with
lirc:
1. The ir-spi driver uses 16 bits of SPI data to create one cycle of
the waveform. As such our SPI clock needs to be 16x faster than the
carrier frequency.
The driver is inconsistent in how it
Hi Ankit,
> After commit c950fd6f201a kernel registers pstore write based on flag
> set. Pstore write for powerpc is broken as flags(PSTORE_FLAGS_DMESG)
> is not set for powerpc architecture. On panic, kernel doesn't write
> message to /fs/pstore/dmesg*(Entry doesn't gets created at all).
>
> Thi
Hi Ravi,
> If we set a kprobe on a 'stdu' instruction on powerpc64, we see a
> kernel OOPS:
Ouch! We should mark this for stable.
Anton
et.
>
> Please check if patch by this link helps:
>
> http://lkml.kernel.org/r/20170313052213.11411-1-kirill.shute...@linux.intel.com
It does fix the ppc64le boot hangs, thanks.
Tested-by: Anton Blanchard
Anton
Hi,
My ppc64le boot tests stopped working as of commit c2febafc6773 ("mm:
convert generic code to 5-level paging")
We hang part way during boot, just before bringing up the network. I
haven't had a chance to narrow it down yet.
Anton
Commit-ID: 6b0b7551428e4caae1e2c023a529465a9a9ae2d4
Gitweb: http://git.kernel.org/tip/6b0b7551428e4caae1e2c023a529465a9a9ae2d4
Author: Anton Blanchard
AuthorDate: Thu, 16 Feb 2017 17:00:50 +1100
Committer: Ingo Molnar
CommitDate: Wed, 1 Mar 2017 10:26:39 +0100
perf/core: Rename
Hi Gautham,
> +handle_esl_ec_set:
Unless we want to expose this to things like perf, we might want to
make it a local label (eg .Lxx)
Anton
From: Anton Blanchard
We have uses of CONFIG_UPROBE_EVENT and CONFIG_KPROBE_EVENT as
well as CONFIG_UPROBE_EVENTS and CONFIG_KPROBE_EVENTS. Consistently
use the plurals.
Signed-off-by: Anton Blanchard
---
Documentation/trace/kprobetrace.txt | 2 +-
Documentation/trace
Hi Ingo,
> So the names should be fixed, it should be CONFIG_UPROBE_EVENTS and
> CONFIG_KPROBE_EVENTS throughout the code. It's CONFIG_PERF_EVENTS and
> CONFIG_PROBE_EVENTS after all and lives in kernel/events/ - all
> plural.
>
> I didn't notice the misnomer when merging these bits.
Ok, patch
From: Anton Blanchard
Fix some incorrect Kconfig options, they should be CONFIG_KPROBE_EVENT
and CONFIG_UPROBE_EVENT.
Signed-off-by: Anton Blanchard
---
arch/sparc/configs/sparc64_defconfig | 2 +-
tools/perf/util/probe-file.c | 8
2 files changed, 5 insertions(+), 5
Hi Peter,
> Last I checked I couldn't build a x86_64 kernel with llvm. So no, not
> something I've ever ran into.
>
> Also, I would argue that this is broken in llvm, the kernel very much
> relies on things like this all over the place. Sure, we're way outside
> of what the C language spec says,
Hi,
I was debugging a hang on a ppc64le kernel built with clang, and it
looks to be undefined behaviour with pointer wrapping in the llist code.
A test case is below. llist_for_each_entry() does container_of() on a
NULL pointer, which wraps our pointer negative, then adds the same
offset back in
Hi Ted,
> Anton or Chandan, could you do me a favor and verify whether or not
> 64k block sizes are working for you on ppcle on ext4 by running
> xfstests? Light duty testing works for me but when I stress ext4 with
> pagesize==blocksize on ppcle64 via xfstests, it blows up. I suspect
> (but am
Hi,
I'm consistently seeing ext4 filesystem corruption using a mainline
kernel. It doesn't take much to trigger it - download a ppc64le Ubuntu
cloud image, boot it in KVM and run:
sudo apt-get update
sudo apt-get dist-upgrade
sudo reboot
And it never makes it back up, dying with rather severe fi
ttps://lkml.org/lkml/2016/10/8/189
You can add:
Tested-by: Anton Blanchard
Also, since this issue makes perf report pretty much useless on
ppc64, can we mark it for stable@, at least to get it into 4.9 where
the ppc64 kernel changes that triggered this appeared?
Anton
> > Reported-
Hi,
I forgot about the set of issues below. Michael had a suggested powerpc
fix for 3, but it it would be nice to fix the perf bugs in 1 and 2.
Anton
--
> Updating to mainline as of last night, I started seeing the following
> error when running the perf report TUI:
>
> 0x46068 [0x8]: failed to
Hi,
> kprobe, uprobe, hw-breakpoint and xmon are the only user of
> emulate_step.
>
> Kprobe / uprobe single-steps instruction if they can't emulate it, so
> there is no problem with them. As I mention, hw-breakpoint is broken.
> However I'm not sure about xmon, I need to check that.
I was mostl
Hi Ravi,
> emulate_step() uses a number of underlying kernel functions that were
> initially not enabled for LE. This has been rectified since. So, fix
> emulate_step() for LE for the corresponding instructions.
Thanks. Should this be queued up for stable?
Anton
> Reported-by: Ant
Commit-ID: 53613e005496234bb684e5db551fbcededa73999
Gitweb: http://git.kernel.org/tip/53613e005496234bb684e5db551fbcededa73999
Author: Anton Blanchard
AuthorDate: Thu, 13 Oct 2016 13:20:43 +1100
Committer: Arnaldo Carvalho de Melo
CommitDate: Mon, 17 Oct 2016 11:25:34 -0300
perf jit
From: Anton Blanchard
When building on Ubuntu 16.04, I get the following error:
Makefile:49: *** the openjdk development package appears to me missing, install
and try again. Stop.
The problem is that update-java-alternatives has multiple spaces between
fields, and cut treats each space as a
Hi Michael,
> > 14c00-14c00 g exc_virt_0x4c00_system_call
>^
>What's this? The address? If so it's wrong?
Offset into the binary I think, there's one 64kB page of ELF gunk at
the start.
> Seems likely. But I can't see why.
>
> AFAICS we have never emitted a size for those symbols:
>
Hi,
Updating to mainline as of last night, I started seeing the following
error when running the perf report TUI:
0x46068 [0x8]: failed to process type: 68
This event is just PERF_RECORD_FINISHED_ROUND:
0x46068 [0x8]: event: 68
.
. ... raw event: size 8 bytes
. : 44 00 00 00 00 00 08 00
Hi Marcelo
> This series fixes the memory corruption found by Jan Stancek in
> 4.8-rc7. The problem however also affects previous versions of the
> driver.
If it affects previous versions, please add the lines in the sign off to
get it into the stable kernels.
Anton
Hi,
> But I can't merge that patch.
>
> Our options are one or both of:
> - get GCC fixed and backport the fix to the compilers we care about.
> - blacklist the broken compiler versions.
>
> Is there a GCC bug filed for this?
Likely: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71709
We need
Commit-ID: 50de1a0c54cdbc69a6dbcbc323f53daf95a4050e
Gitweb: http://git.kernel.org/tip/50de1a0c54cdbc69a6dbcbc323f53daf95a4050e
Author: Anton Blanchard
AuthorDate: Sat, 13 Aug 2016 11:55:33 +1000
Committer: Arnaldo Carvalho de Melo
CommitDate: Mon, 15 Aug 2016 16:49:57 -0300
perf
From: Anton Blanchard
Commit 73cdf0c6ea9c ("perf symbols: Record text offset in dso
to calculate objdump address") started storing the offset of
the text section for all DSOs:
if (elf_section_by_name(elf, &ehdr, &tshdr, ".text", NULL))
dso-
From: Anton Blanchard
Commit 73cdf0c6ea9c ("perf symbols: Record text offset in dso
to calculate objdump address") started storing the offset of
the text section for all DSOs:
if (elf_section_by_name(elf, &ehdr, &tshdr, ".text", NULL))
dso-
Hi Arnaldo,
> Anyway, Anton, does this fix the problem for you?
Yes it does, thanks!
Anton
Hi,
> Powerpc has Global Entry Point and Local Entry Point for functions.
> LEP catches call from both the GEP and the LEP. Symbol table of ELF
> contains GEP and Offset from which we can calculate LEP, but debuginfo
> does not have LEP info.
>
> Currently, perf prioritize symbol table over dwarf
> > I noticed tip started failing in my CI environment which tests on
> > QEMU. The failure bisected to commit
> > 425209e0abaf2c6e3a90ce4fedb935c10652bf80
>
> That's very useful, thanks Anton!
>
> I have removed this commit from the series for the time being,
> refactored the followup commits
Hi Anna-Maria,
> >> Install the callbacks via the state machine and let the core invoke
> >> the callbacks on the already online CPUs.
> >
> > This is causing an oops on ppc64le QEMU, looks like a NULL
> > pointer:
>
> Did you tested it against tip WIP.hotplug?
I noticed tip started failing
Hi,
> From: Sebastian Andrzej Siewior
>
> Install the callbacks via the state machine and let the core invoke
> the callbacks on the already online CPUs.
This is causing an oops on ppc64le QEMU, looks like a NULL pointer:
percpu: Embedded 3 pages/cpu @c0001fe0 s145816 r0 d50792 u104857
Hi Thomas,
> It really does not matter when we fold the load for the outgoing cpu.
> It's almost dead anyway, so there is no harm if we fail to fold the
> few microseconds which are required for going fully away.
We are seeing the load average shoot up when hot unplugging CPUs (+1
for every CPU w
From: Anton Blanchard
Many targets enable CONFIG_DEBUG_STACK_USAGE, and while the information
is useful, it isn't worthy of pr_warn(). Reduce it to pr_info().
Signed-off-by: Anton Blanchard
---
kernel/exit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/exi
From: Anton Blanchard
commit 612e44939c3c ("mm: workingset: eviction buckets for bigmem/lowbit
machines") added a printk without a log level. Quieten it by using
pr_info().
Signed-off-by: Anton Blanchard
---
mm/workingset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
Hi,
> current_stack_pointeur() is a single instruction function. it
> It is not worth breaking the execution flow with a bl/blr for a
> single instruction
Check out bfe9a2cfe91a ("powerpc: Reimplement __get_SP() as a function
not a define") to see why we made it a function.
Anton
Commit-ID: bd92883051a0228cc34996b8e766111ba10c9aac
Gitweb: http://git.kernel.org/tip/bd92883051a0228cc34996b8e766111ba10c9aac
Author: Anton Blanchard
AuthorDate: Wed, 6 Apr 2016 21:59:50 +1000
Committer: Ingo Molnar
CommitDate: Wed, 13 Apr 2016 13:22:37 +0200
sched/cpuacct: Check for
task_pt_regs() can return NULL for kernel threads, so add a check.
This fixes an oops at boot on ppc64.
Fixes: d740037fac70 ("sched/cpuacct: Split usage accounting into user_usage and
sys_usage")
Signed-off-by: Anton Blanchard
Reported-and-Tested-by: Srikar Dronamraju
---
diff --gi
atch below does fix the oops for me.
Anton
--
task_pt_regs() can return NULL for kernel threads, so add a check.
This fixes an oops at boot on ppc64.
Signed-off-by: Anton Blanchard
---
diff --git a/kernel/sched/cpuacct.c b/kernel/sched/cpuacct.c
index df947e0..41f85c4 100644
--- a/kernel/sched/cpu
Hi,
> > > void cpuacct_charge(struct task_struct *tsk, u64 cputime)
> > > {
> > > struct cpuacct *ca;
> > > + int index;
> > > +
> > > + if (user_mode(task_pt_regs(tsk)))
> > > + index = CPUACCT_USAGE_USER;
> > > + else
> > > + index = CPUACCT_USAGE_SYSTEM;
This is oopsing bec
Commit-ID: 9f56c092b99b40ce3cf4c6d0134ff7e513c9f1a6
Gitweb: http://git.kernel.org/tip/9f56c092b99b40ce3cf4c6d0134ff7e513c9f1a6
Author: Anton Blanchard
AuthorDate: Tue, 29 Mar 2016 17:59:44 +1100
Committer: Arnaldo Carvalho de Melo
CommitDate: Wed, 30 Mar 2016 18:12:06 -0300
perf jit
match what gcc
emits. We should first look for __powerpc64__, then __powerpc__.
Fixes: 9b07e27f88b9 ("perf inject: Add jitdump mmap injection support")
Signed-off-by: Anton Blanchard
---
diff --git a/tools/perf/util/genelf.h b/tools/perf/util/genelf.h
index cd67e64..2fbeb59 100644
-
> Since binutils 2.26 BFD is doing suffix merging on STRTAB sections.
> But dedotify modifies the symbol names in place, which can also modify
> unrelated symbols with a name that matches a suffix of a dotted
> name. To remove the leading dot of a symbol name we can just
> increment the pointer i
Hi Scott,
> I wonder why it was 64-bit specific in the first place.
I think it was part of a series where I added my 64bit assembly checksum
routines, and I didn't step back and think that the wrapper code would
be useful on 32 bit.
Anton
--
To unsubscribe from this list: send the line "unsubscr
Hi,
> > When the host's C compiler is clang, and when attempting to
> > cross-compile Linux e.g. to MIPS with mipsel-linux-gcc, the
> > Makefile would incorrectly detect the use of clang, which
> > resulted in clang-specific flags being passed to
> > mipsel-linux-gcc.
>
Hi Nikunj,
> > Thanks for the patch. Have we tested that this doesn't regress the
> > non dynamic representation?
>
> Yes, that is tested. And works as expected.
Great, you can add:
Acked-by: Anton Blanchard
Anton
--
To unsubscribe from this list: send the line "
Hi Nikunj,
> From: Nikunj A Dadhania
>
> powerpc/numa: initialize distance lookup table from drconf path
>
> In some situations, a NUMA guest that supports
> ibm,dynamic-memory-reconfiguration node will end up having flat NUMA
> distances between nodes. This is because of two problems in the
>
o), is that we
don't restore the DSCR on exit. I'm not sure we need to go to the
trouble of saving and restoring it, but we should at least get it back
to 0 when done.
Also a tiny nit, no need for a newline in perror():
open() failed
: Permission denied
With those changes you can ad
gcc has recently bumped its major version and this is causing kernel
build errors. Create include/linux/compiler-gcc6.h which is a copy
of compiler-gcc5.h, minus a few comments that no longer apply.
Signed-off-by: Anton Blanchard
---
I'm told the versioning scheme in gcc has changed, a
Commit-ID: 55dd0df781e58ec23d218376ea4a676e7362a98c
Gitweb: http://git.kernel.org/tip/55dd0df781e58ec23d218376ea4a676e7362a98c
Author: Anton Blanchard
AuthorDate: Thu, 9 Apr 2015 13:51:30 +1000
Committer: Ingo Molnar
CommitDate: Thu, 9 Apr 2015 09:40:23 +0200
jump_label: Allow asm
Commit-ID: 58995a9a5b292458f94a2356b8c878230fa56fe0
Gitweb: http://git.kernel.org/tip/58995a9a5b292458f94a2356b8c878230fa56fe0
Author: Anton Blanchard
AuthorDate: Thu, 9 Apr 2015 13:51:32 +1000
Committer: Ingo Molnar
CommitDate: Thu, 9 Apr 2015 09:40:29 +0200
powerpc, jump_label
Commit-ID: c0ccf6f99e3a43b87980c9df7da48427885206d0
Gitweb: http://git.kernel.org/tip/c0ccf6f99e3a43b87980c9df7da48427885206d0
Author: Anton Blanchard
AuthorDate: Thu, 9 Apr 2015 13:51:31 +1000
Committer: Ingo Molnar
CommitDate: Thu, 9 Apr 2015 09:40:24 +0200
jump_label: Allow jump
To use jump labels in assembly we need the HAVE_JUMP_LABEL define,
so we select a fallback version if the toolchain does not support
them.
Modify linux/jump_label.h so it can be included by assembly files.
We also need to add -DCC_HAVE_ASM_GOTO to KBUILD_AFLAGS.
Signed-off-by: Anton Blanchard
c9e47aa8e4 ("powerpc/jump_label: Use HAVE_JUMP_LABEL")
Signed-off-by: Anton Blanchard
---
arch/powerpc/platforms/powernv/opal-wrappers.S | 2 +-
arch/powerpc/platforms/pseries/hvCall.S| 2 +-
arch/powerpc/platforms/pseries/lpar.c | 2 +-
3 files changed, 3 insertions(+),
(see ARCH_STATIC_BRANCH in the powerpc asm/jump_label.h
for an example).
Signed-off-by: Anton Blanchard
---
arch/arm/include/asm/jump_label.h | 5 ++---
arch/arm64/include/asm/jump_label.h | 8
arch/mips/include/asm/jump_label.h | 7 +++
arch/s390/include/asm/jump_label.h | 3 +++
Replace the x86 specific oops locking with the common one.
Signed-off-by: Anton Blanchard
---
arch/x86/kernel/dumpstack.c | 26 +++---
1 file changed, 3 insertions(+), 23 deletions(-)
diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
index b74ebc7
Replace the powerpc specific oops locking with the common one.
Signed-off-by: Anton Blanchard
---
arch/powerpc/kernel/traps.c | 24 +++-
1 file changed, 3 insertions(+), 21 deletions(-)
diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
index 19e4744
A simple kernel module was used to create concurrent soft and
hard lockups:
http://ozlabs.org/~anton/junkcode/badguy.tar.gz
Signed-off-by: Anton Blanchard
---
kernel/watchdog.c | 4
1 file changed, 4 insertions(+)
diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 70bf118..dd161e3
A simple kernel module was used to create concurrent WARNs and BUGs:
http://ozlabs.org/~anton/junkcode/warnstorm.tar.gz
Signed-off-by: Anton Blanchard
---
arch/powerpc/kernel/traps.c | 44
1 file changed, 36 insertions(+), 8 deletions(-)
diff --git
Remove another version of a recursive lock in dump_stack.
Signed-off-by: Anton Blanchard
---
lib/dump_stack.c | 40
1 file changed, 4 insertions(+), 36 deletions(-)
diff --git a/lib/dump_stack.c b/lib/dump_stack.c
index 6745c62..f64ee3c 100644
--- a/lib
Many architectures have their own oops locking code that allows
the lock to be taken recursively. Create a common version.
Avoid creating generic locking functions, so they can't be
abused in other parts of the kernel.
Signed-off-by: Anton Blanchard
---
include/linux/die_lock.h
the series:
A trivial module to create concurrent WARNs, BUGs and oopses:
http://ozlabs.org/~anton/junkcode/warnstorm.tar.gz
And one to create concurrent soft and hard lockups:
http://ozlabs.org/~anton/junkcode/badguy.tar.gz
Anton Blanchard (7):
Add die_spin_lock_{irqsave,irqrestore
Replace the ARM specific oops locking with the common one.
Signed-off-by: Anton Blanchard
---
arch/arm/kernel/traps.c | 26 +++---
1 file changed, 3 insertions(+), 23 deletions(-)
diff --git a/arch/arm/kernel/traps.c b/arch/arm/kernel/traps.c
index 788e23f..3e3469d 100644
Hi Jason,
> > diff --git a/arch/powerpc/platforms/pseries/lpar.c
> > b/arch/powerpc/platforms/pseries/lpar.c index 469751d..14ac1ad
> > 100644 --- a/arch/powerpc/platforms/pseries/lpar.c
> > +++ b/arch/powerpc/platforms/pseries/lpar.c
> > @@ -27,6 +27,7 @@
> > #include
> > #include
> > #inclu
Hi Andrew,
> On Wed, Nov 05, 2014 at 09:34:20AM +1100, Anton Blanchard wrote:
> > commit 9919e39a1738 ("kvm: ensure hard lockup detection is disabled
> > by default") provided a way for the kernel to disable the hard
> > lockup detector at runtime.
> >
>
To use jump labels in assembly we need the HAVE_JUMP_LABEL define,
so we select a fallback version if the toolchain does not support
them.
Modify linux/jump_label.h so it can be included by assembly files.
We also need to add -DCC_HAVE_ASM_GOTO to KBUILD_AFLAGS.
Signed-off-by: Anton Blanchard
(see ARCH_STATIC_BRANCH in the powerpc asm/jump_label.h
for an example).
Signed-off-by: Anton Blanchard
---
arch/arm/include/asm/jump_label.h | 5 ++---
arch/arm64/include/asm/jump_label.h | 8
arch/mips/include/asm/jump_label.h | 7 +++
arch/s390/include/asm/jump_label.h | 3 +++
c9e47aa8e4 ("powerpc/jump_label: Use HAVE_JUMP_LABEL")
Signed-off-by: Anton Blanchard
---
arch/powerpc/platforms/powernv/opal-wrappers.S | 2 +-
arch/powerpc/platforms/pseries/hvCall.S| 2 +-
arch/powerpc/platforms/pseries/lpar.c | 1 +
3 files changed, 3 insertions(+), 2 dele
Hi Steve,
> Have you tested this on other archs? Because just looking at x86, it
> doesn't seem that asm/jump_label.h can handle being called in
> assembly.
Since no one is including linux/jump_label.h in assembly yet, nothing
should break. We could however add __ASSEMBLY__ protection to all the
c9e47aa8e4 ("powerpc/jump_label: Use HAVE_JUMP_LABEL")
Signed-off-by: Anton Blanchard
---
arch/powerpc/platforms/pseries/hvCall.S | 2 +-
arch/powerpc/platforms/pseries/lpar.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/hvCall.S
b/ar
To use jump labels in assembly we need the HAVE_JUMP_LABEL define,
so we select a fallback version if the toolchain does not support
them.
Modify linux/jump_label.h so it can be included by assembly files.
We also need to add -DCC_HAVE_ASM_GOTO to KBUILD_AFLAGS.
Signed-off-by: Anton Blanchard
he active and
online bits aren't set we choose some other CPU to run on.
Cc: sta...@vger.kernel.org
Signed-off-by: Anton Blanchard
---
arch/powerpc/kernel/smp.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
ind
Hi Ingo,
> So we cannot call set_task_cpu() because in the normal life time
> of a task the ->cpu value gets set on wakeup. So if a task is
> blocked right now, and its affinity changes, it ought to get a
> correct ->cpu selected on wakeup. The affinity mask and the
> current value of ->cpu g
Hi Linus,
> The __set_task_cpu() function does various other things too:
>
> set_task_rq(p, cpu);
> #ifdef CONFIG_SMP
> /*
> * After ->cpu is set up to a new value, task_rq_lock(p, ...)
> can be
> * successfuly executed on another CPU. We must ensure that
> up
t of task_thread_info(p)->cpu.
Fixes: e2912009fb7b ("sched: Ensure set_task_cpu() is never called on blocked
tasks")
Cc: sta...@vger.kernel.org
Signed-off-by: Anton Blanchard
---
kernel/kthread.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/kthread.c b/kern
Hi,
> is this patchset still needed after Vicky's patch
> "[tpmdd-devel] Fix NULL return in tpm_ibmvtpm_get_desired_dma"
> https://patchwork.ozlabs.org/patch/402315/
>
> Ashley raised some concerns.
>
> Since merge window is coming up, a fast reply is appreciated.
We definitely need a way to c
Hi Don,
> > commit 9919e39a1738 ("kvm: ensure hard lockup detection is disabled
> > by default") provided a way for the kernel to disable the hard
> > lockup detector at runtime.
> >
> > I'm using it on ppc64 but notice some weird behaviour with the
> > nmi_watchdog procfs variable. At boot, tha
Hi,
commit 9919e39a1738 ("kvm: ensure hard lockup detection is disabled by
default") provided a way for the kernel to disable the hard lockup
detector at runtime.
I'm using it on ppc64 but notice some weird behaviour with the
nmi_watchdog procfs variable. At boot, that the hard lockup
detector a
Signed-off-by: Anton Blanchard
---
Index: b/fs/quota/dquot.c
===
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -2743,7 +2743,7 @@ static int __init dquot_init(void)
for (i = 0; i < nr_hash
Signed-off-by: Anton Blanchard
---
Index: b/lib/raid6/algos.c
===
--- a/lib/raid6/algos.c
+++ b/lib/raid6/algos.c
@@ -121,9 +121,9 @@ static inline const struct raid6_recov_c
raid6_2data_recov = best->da
Signed-off-by: Anton Blanchard
---
Index: b/mm/page_alloc.c
===
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3894,14 +3894,14 @@ void __ref build_all_zonelists(pg_data_t
else
d_u32_array to byte swap and avoid the need for a
> number of be32_to_cpu calls.
>
> Cc: sta...@vger.kernel.org # v3.13
> Cc: Benjamin Herrenschmidt
> Reviewed-by: Anton Blanchard
> [aik: folded Anton's patch with of_property_read_u32_array]
> Signed-off-by: Alexe
Hi Mikey,
> We only map what a user processes maps and we tear it down when the
> process is teared down (on the file descriptor release). So I think
> we are ok.
>
> Unless there's some lazy teardown you're alluding to that I'm missing?
I was trying to make sure things like the TLB batching
> From: Ian Munsie
>
> This adds the OPAL call to change a PHB into cxl mode.
>
> Signed-off-by: Ian Munsie
> Signed-off-by: Michael Neuling
Reviewed-by: Anton Blanchard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the
> From: Ian Munsie
>
> This add a hook into tlbie() so that we use global invalidations when
> there are cxl contexts active.
>
> Normally cxl snoops broadcast tlbie. cxl can have TLB entries
> invalidated via MMIO, but we aren't doing that yet. So for now we
> are just disabling local tlbies
by other powerpc code.
Could we also mention:
and adds 1TB segment support.
> Signed-off-by: Ian Munsie
> Signed-off-by: Michael Neuling
Reviewed-by: Anton Blanchard
Anton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to maj
use it.
>
> Signed-off-by: Ian Munsie
> Signed-off-by: Michael Neuling
Reviewed-by: Anton Blanchard
Anton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kern
u verify this works and then fold it into yours? Also mark it for
inclusion in stable v3.13+.
You can add:
Reviewed-by: Anton Blanchard
Thanks!
Anton
Index: b/arch/powerpc/platforms/pseries/iommu.c
===
--- a/arch/powerpc/platform
There is no need to cast from a void pointer to another pointer.
Signed-off-by: Anton Blanchard
---
Index: b/drivers/char/tpm/tpm_ibmvtpm.c
===
--- a/drivers/char/tpm/tpm_ibmvtpm.c
+++ b/drivers/char/tpm/tpm_ibmvtpm.c
@@ -65,7
f the driver
never expects it.
Add a BUG_ON in ibmvtpm_get_data. We still need to identify the root
cause but at least this makes it obvious what went wrong.
Cc: sta...@vger.kernel.org
Signed-off-by: Anton Blanchard
---
diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
Commit-ID: d0b0d0406fe6743e734e1ba780155f8db5f713e6
Gitweb: http://git.kernel.org/tip/d0b0d0406fe6743e734e1ba780155f8db5f713e6
Author: Anton Blanchard
AuthorDate: Tue, 9 Sep 2014 08:59:29 +1000
Committer: Arnaldo Carvalho de Melo
CommitDate: Wed, 17 Sep 2014 17:08:10 -0300
perf
Commit-ID: c657f423aed0d836c807ea1d6d8d28b3914446fa
Gitweb: http://git.kernel.org/tip/c657f423aed0d836c807ea1d6d8d28b3914446fa
Author: Anton Blanchard
AuthorDate: Mon, 15 Sep 2014 16:57:56 -0300
Committer: Arnaldo Carvalho de Melo
CommitDate: Wed, 17 Sep 2014 17:08:10 -0300
perf
Commit-ID: 65ccb4faae872b63dd8f5fbc83d0195e3dfabf0d
Gitweb: http://git.kernel.org/tip/65ccb4faae872b63dd8f5fbc83d0195e3dfabf0d
Author: Anton Blanchard
AuthorDate: Mon, 25 Aug 2014 18:25:06 +1000
Committer: Arnaldo Carvalho de Melo
CommitDate: Wed, 17 Sep 2014 17:08:07 -0300
perf tools
I ran some tests to compare hash_64 using shifts and multiplies.
The results:
POWER6: ~2x slower
POWER7: ~2x faster
POWER8: ~2x faster
Now we have a proper config option, select
CONFIG_ARCH_HAS_FAST_MULTIPLIER on POWER7 and POWER8.
Signed-off-by: Anton Blanchard
---
Index: b/arch/powerpc
1 - 100 of 284 matches
Mail list logo
