Re: [PATCH] ntfs: check for valid standard information attribute

2021-02-22 Thread Anton Altaparmakov
Hi Andrew, Sorry for the delay in replying. > On 19 Feb 2021, at 18:49, Andrew Morton wrote: > > On Fri, 19 Feb 2021 01:54:30 +0000 Anton Altaparmakov > wrote: > >> Hi Andrew, >> >> Can you please push this one upstream? Thanks a lot in advance! > &g

Re: [PATCH] ntfs: check for valid standard information attribute

2021-02-18 Thread Anton Altaparmakov
rted-and-tested-by: syzbot+c584225dabdea2f71...@syzkaller.appspotmail.com > Signed-off-by: Rustam Kovhaev > Acked-by: Anton Altaparmakov > Link: https://syzkaller.appspot.com/bug?extid=c584225dabdea2f71969 > --- > fs/ntfs/inode.c | 6 ++ > 1 file changed, 6 insertions(+) > &

Re: [PATCH] ntfs: move check for valid resident attribute offset and length

2021-02-15 Thread Anton Altaparmakov
ibute list attribute needs to remain, i.e. your second delta needs to be deleted. Please could you address both of the above comments and then resend? Please then also add: "Acked-by: Anton Altaparmakov " to the patch. Thanks a lot in advance! Best regards, Anton > On 14 Feb

Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask'

2020-12-09 Thread Anton Altaparmakov
:36, Andrew Morton wrote: > > On Tue, 8 Dec 2020 08:24:02 +0000 Anton Altaparmakov wrote: > >> Can you please apply this? >> >> ... >> >>> --- a/fs/ntfs/logfile.c >>> +++ b/fs/ntfs/logfile.c >>> @@ -507,7 +507,7 @@ bool ntfs_ch

Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask'

2020-12-08 Thread Anton Altaparmakov
ntfs_check_logfile: > fs/ntfs/logfile.c:481:21: > warning: variable log_page_mask set but not used [-Wunused-but-set-variable] > > Actually log_page_mask can be used to replace 'log_page_size - 1' as it is > set. > > Signed-off-by: Zheng Zengkai > Acked-by: An

Re: [PATCH] fs/ntfs: remove unused varibles

2020-11-09 Thread Anton Altaparmakov
warning: variable ‘base_ni’ set but not used > [-Wunused-but-set-variable] > fs/ntfs/logfile.c:481:21: warning: variable ‘log_page_mask’ set but not > used [-Wunused-but-set-variable] > > Signed-off-by: Alex Shi > Acked-by: Anton Altaparmakov > Cc: linux-ntfs-...@lis

Re: [PATCH] fs/ntfs: remove unused varible attr_len

2020-11-09 Thread Anton Altaparmakov
used varible attr_len > > This varible isn't used anymore, remove it to skip W=1 warning: > fs/ntfs/inode.c:2350:6: warning: variable ‘attr_len’ set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Alex Shi > Acked-by: Anton Altaparmakov > --- > fs/ntfs/

Re: [PATCH RESEND] ntfs: drop unneeded semi-colons

2020-09-18 Thread Anton Altaparmakov
Hi Randy, Sorry, I don't know how I missed those originally. Andrew, please could you add this to your tree for merging with Linus as well? And again, please feel free to add: Acked-by: Anton Altaparmakov Thanks a lot! Best regards, Anton > On 18 Sep 2020, at 02:20, Rand

Re: [PATCH RESEND] ntfs: layout.h: delete duplicated words

2020-09-18 Thread Anton Altaparmakov
Hi Randy, Sorry, I don't know how I missed those originally. Andrew, please could you add this to your tree for merging with Linus? Please feel free to add: Acked-by: Anton Altaparmakov Thanks a lot! Best regards, Anton > On 18 Sep 2020, at 02:20, Randy Dunlap wrote: >

Re: [PATCH] ntfs: add check for mft record size in superblock

2020-08-23 Thread Anton Altaparmakov
13f36eff9b544e > Signed-off-by: Rustam Kovhaev > Acked-by: Anton Altaparmakov > --- > fs/ntfs/inode.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/fs/ntfs/inode.c b/fs/ntfs/inode.c > index 9bb9f0952b18..caf563981532 100644 > --- a/fs/ntfs/ino

Re: [PATCH] ntfs: add check for mft record size in superblock

2020-08-23 Thread Anton Altaparmakov
und the numbers and it would be better to have this consistent throughout. Can you please resend with the above issues addressed? You can then also add to the commit message: Acked-by: Anton Altaparmakov Thanks! Best regards, Anton > On 23 Aug 2020, at 16:21, Rustam K

Re: [PATCH v2] ntfs: Fix ntfs_test_inode and ntfs_init_locked_inode function type

2020-07-18 Thread Anton Altaparmakov
tfs_mount+0x18/0x24 > mount_fs+0x1b0/0x380 > vfs_kern_mount+0x90/0x398 > do_mount+0x5d8/0x1a10 > SyS_mount+0x108/0x144 > el0_svc_naked+0x34/0x38 > > Signed-off-by: Luca Stefani > Tested-by: freak07 > Acked-by: Anton Altaparmakov > --- > fs/ntfs/dir.c | 2 +

Re: [PATCH] ntfs: Fix ntfs_test_inode and ntfs_init_locked_inode function type

2020-07-08 Thread Anton Altaparmakov
Hi Luca, Apologies for taking this long to respond. I have to admit I was not familiar with CFI... Your patch looks good but please could you update the commit message as suggested by Nick to include explanation of CFI? You can then add: Acked-by: Anton Altaparmakov When resending please

Re: [PATCH 34/38] vfs: syscall: Add fsinfo() to query filesystem information [ver #10]

2018-07-27 Thread Anton Altaparmakov
n't many nice things about it!) is that for long names (i.e. not the 8.3 style/DOS/short names), it actually stores on-disk little-endian UTF-16 (since Windows 2000, before that it used little endian UCS-2 - the change was needed to support things like Emojis and some languages that go outside th

Re: Race condition between iget_locked() and evict_inodes()

2016-09-29 Thread Anton Altaparmakov
Hi Al, > On 29 Sep 2016, at 13:17, Al Viro wrote: > > On Thu, Sep 29, 2016 at 11:53:21AM +0000, Anton Altaparmakov wrote: >> Thus if the events happen in this order: >> >> evict_inodes() iget_locked() in >> find_inode_fast() &

Race condition between iget_locked() and evict_inodes()

2016-09-29 Thread Anton Altaparmakov
check or it should at least re-check it. Please tell me what I am missing here. I assume there must be something providing exclusion and I am just too blind to see it but I thought it worth bringing to your attention in case it really is simply broken. Best regards, Anton -- Anton

Re: [PATCH 22/31] fs/ntfs: use kmemdup rather than duplicating its implementation

2015-09-24 Thread Anton Altaparmakov
> On 24 Sep 2015, at 10:20, Anton Altaparmakov wrote: > > Hi Andrzej, > >> On 24 Sep 2015, at 09:34, Andrzej Hajda wrote: >> >> On 09/23/2015 12:21 PM, Anton Altaparmakov wrote: >>> Hi Andrzej, >>> >>> Thanks for your patch. It looks

Re: [PATCH 22/31] fs/ntfs: use kmemdup rather than duplicating its implementation

2015-09-24 Thread Anton Altaparmakov
Hi Andrzej, > On 24 Sep 2015, at 09:34, Andrzej Hajda wrote: > > On 09/23/2015 12:21 PM, Anton Altaparmakov wrote: >> Hi Andrzej, >> >> Thanks for your patch. It looks fine though I don't quite see the point of >> it to be honest. >> >> It

Re: [PATCH 22/31] fs/ntfs: use kmemdup rather than duplicating its implementation

2015-09-23 Thread Anton Altaparmakov
} > - /* Copy the index root value (it has been verified in read_inode). */ > - memcpy(ir, (u8*)ctx->attr + > - le16_to_cpu(ctx->attr->data.resident.value_offset), rc); > ntfs_attr_put_search_ctx(ctx); > unmap_mft_reco

Re: [PATCH] ntfs: Deletion of unnecessary checks before the function call "iput"

2015-07-05 Thread Anton Altaparmakov
Hi Andrew, Can you please take up this trivial patch and merge it upstream? Reviewed-by: Anton Altaparmakov Thanks a lot in advance! Best regards, Anton > On 4 Jul 2015, at 11:32, SF Markus Elfring > wrote: > >> From: Markus Elfring >> Date: Sat, 15 No

i_uid_read()/i_uid_write() and friends

2015-04-10 Thread Anton Altaparmakov
() and because i_uid_read() and i_uid_write() are static inline it causes them to be unusable from non-gpl kernel modules... Same thing applies to i_gid_read() and i_gid_write(). These seem pretty fundamental calls that a non-gpl file system should be able to call, no? Best regards, A

Re: [fuse-devel] [PATCH v5 7/7] add a flag for per-operation O_DSYNC semantics

2014-11-06 Thread Anton Altaparmakov
Hi, > On 7 Nov 2014, at 07:52, Anand Avati wrote: > On Thu, Nov 6, 2014 at 8:22 PM, Anton Altaparmakov wrote: > > On 7 Nov 2014, at 01:46, Jeff Moyer wrote: > > Minor nit, but I'd rather read something that looks like this: > > > > if (ty

Re: [PATCH v5 7/7] add a flag for per-operation O_DSYNC semantics

2014-11-06 Thread Anton Altaparmakov
ase where "type == READ" is true and "flags & RWF_NONBLOCK" is false because your version then has to do the "if (type == WRITE" check before discovering it does not need to take that branch either, whilst the original version does not have to do such a test at al

Re: [Linux-NTFS-Dev] [PATCH v5 6/7] fs: pass iocb to generic_write_sync

2014-11-06 Thread Anton Altaparmakov
pping->host)) > - return 0; > - return vfs_fsync_range(file, pos, pos + count - 1, > -(file->f_flags & __O_SYNC) ? 0 : 1); > -} > +extern int generic_write_sync(struct kiocb *iocb, loff_t count); > extern void emerg

[git pull] Small NTFS update

2014-10-16 Thread Anton Altaparmakov
(+), 293 deletions(-) Shortlog: Anton Altaparmakov (4): NTFS: Split ntfs_aops into ntfs_normal_aops and ntfs_compressed_aop in preparation for them diverging. NTFS: Remove changelog from Documentation/filesystems/ntfs.txt. NTFS: Add bmap address space operation needed

Re: WTF is d_add_ci() doing with negative dentries?

2014-10-13 Thread Anton Altaparmakov
Hi Al, On 13 Oct 2014, at 03:14, Al Viro wrote: > On Mon, Oct 13, 2014 at 12:56:11AM +0100, Anton Altaparmakov wrote: >> I am just wondering whether there might be error conditions in which we >> might end up with a (perhaps invalid) negative dentry in memory which could &

Re: WTF is d_add_ci() doing with negative dentries?

2014-10-12 Thread Anton Altaparmakov
y well be better to pass dentry->d_parent instead > of dentry... Objections? Yes, that bit makes perfect sense given we only ever use dentry->d_parent. Best regards, Anton -- Anton Altaparmakov (replace at with @) University of Cambridge Information Services, Roger Needham Build

Re: [PATCH] NTFS: Remove bogus space.

2014-10-02 Thread Anton Altaparmakov
Hi Andrew, Forgot to say that this patch is from Andrea Gilmini originally (I had to re-do it as it is an old patch and the line numbers had changed)... Best regards, Anton On 3 Oct 2014, at 00:44, Anton Altaparmakov wrote: > fs/ntfs/debug.c:124: WARNING: space prohibited betw

[PATCH] NTFS: Remove bogus space.

2014-10-02 Thread Anton Altaparmakov
fs/ntfs/debug.c:124: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Andrea Gelmini Signed-off-by: Anton Altaparmakov --- Hi Andrew, Can you please take this simple patch and push it to Linus at some point? Thanks a lot in advance! Be

Re: [PATCH] Fix nasty 32-bit overflow bug in buffer i/o code.

2014-09-22 Thread Anton Altaparmakov
Hi Linus, On 22 Sep 2014, at 16:33, Linus Torvalds wrote: > On Mon, Sep 22, 2014 at 8:29 AM, Anton Altaparmakov wrote: >> >> You could do "block & ~(sector_t)(size - 1)" instead of "(sector_t)index << >> sizebits" if you prefer but not sur

Re: [PATCH] Fix nasty 32-bit overflow bug in buffer i/o code.

2014-09-22 Thread Anton Altaparmakov
Hi Linus, On 22 Sep 2014, at 16:18, Linus Torvalds wrote: > On Sun, Sep 21, 2014 at 5:53 PM, Anton Altaparmakov wrote: >> >> This patch fixes this issue by type casting "index" to sector_t before >> doing the left shift. > > Ugh. Does the simpler patch

Re: [PATCH] Fix nasty 32-bit overflow bug in buffer i/o code.

2014-09-22 Thread Anton Altaparmakov
Hi, On 22 Sep 2014, at 11:36, Hugh Dickins wrote: > On Mon, 22 Sep 2014, Anton Altaparmakov wrote: >> On 22 Sep 2014, at 05:43, Hugh Dickins wrote: >>> On Mon, 22 Sep 2014, Anton Altaparmakov wrote: >>>> Any code that uses __getblk() and thus b

Re: [PATCH] Fix nasty 32-bit overflow bug in buffer i/o code.

2014-09-22 Thread Anton Altaparmakov
Hi Hugh, On 22 Sep 2014, at 05:43, Hugh Dickins wrote: > On Mon, 22 Sep 2014, Anton Altaparmakov wrote: >> Any code that uses __getblk() and thus bread(), breadahead(), sb_bread(), >> sb_breadahead(), sb_getblk(), and calls it using a 64-bit block on a >> 32-bit arch (w

[PATCH] Fix nasty 32-bit overflow bug in buffer i/o code.

2014-09-21 Thread Anton Altaparmakov
t is an NTFS volume causes the inifinite loop 100% reproducibly whilst with the patch it works fine as expected. Signed-off-by: Anton Altaparmakov Cc: sta...@vger.kernel.org # 3.6 3.8 3.10 3.12 3.14 3.16 --- Linus, can you please apply this? Alternatively, Andrew, can you please pick this up an

[PATCH] Use find_get_page_flags() to mark page accessed as it is no longer marked later on

2014-09-05 Thread Anton Altaparmakov
ge to never be marked accessed. This patch fixes that. Signed-off-by: Anton Altaparmakov --- Hi Andrew, Can you please take the below patch and forward it for inclusion to Linus? Thanks a lot in advance! Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Co

Re: [PATCH] Now that sync_filesystem() must be called from ->remount_fs() it needs to be EXPORT_SYMBOL() for kernel modules.

2014-09-04 Thread Anton Altaparmakov
Hi Linus, No-one has objected to the below patch I sent you over two weeks ago. Would you please apply it? If you would like it to go through for example Al or Andrew please let me know... Thanks a lot in advance! Best regards, Anton On 21 Aug 2014, at 11:09, Anton Altaparmakov

Re: [PATCH] mm: clear __GFP_FS when PF_MEMALLOC_NOIO is set

2014-09-04 Thread Anton Altaparmakov
ystems that need to take a lock could return with -EDEADLOCK and the VM can then skip over those entries and reclaim others. Though I think it would be more efficient for the VFS/VM to simply not call into the file system that is doing the allocation as above... Best regards, A

[PATCH] Now that sync_filesystem() must be called from ->remount_fs() it needs to be EXPORT_SYMBOL() for kernel modules.

2014-08-21 Thread Anton Altaparmakov
ll it. Signed-off-by: Anton Altaparmakov --- Hi Linus, Can you please apply this patch for inclusion into 3.17? Explanation is above. Thanks a lot in advance! PS. I hope Pine does not mess up the whitespace of the patch! Best regards, Anton -- Anton Altaparmakov (replace at wit

Re: Revert "platform/x86/toshiba-apci.c possible bad if test?"

2014-08-20 Thread Anton Altaparmakov
i.c > +++ b/drivers/platform/x86/toshiba_acpi.c > @@ -1258,7 +1258,7 @@ static ssize_t toshiba_kbd_bl_mode_store(struct device > *dev, > int mode = -1; > int time = -1; > > - if (sscanf(buf, "%i", &mode) != 1 || (mode != 2 || mode != 1)) > + if (ssc

Re: Bug introduced in 3b93f911d5

2014-08-08 Thread Anton Altaparmakov
Hi Al, On 8 Aug 2014, at 16:54, Al Viro wrote: > On Fri, Aug 08, 2014 at 12:11:39AM +0100, Anton Altaparmakov wrote: >> Hi Al, >> >> Was just looking at __generic_file_write_iter() and found a bug in the code >> that you added in 3b93f911d5. >

Bug introduced in 3b93f911d5

2014-08-07 Thread Anton Altaparmakov
uot; being set to "pos - random value - 1", etc. Doesn't seem like that is what you intended? Best regards, Anton -- Anton Altaparmakov (replace at with @) University of Cambridge Information Services, Roger Needham Building 7 JJ Thomson Avenue, Cambridge, CB3 0RB, UK -- To

Re: [PATCH] ntfs: avoid incorrectly release for root inode in fill_super

2014-07-25 Thread Anton Altaparmakov
iput(vol->root_ino); > + > + /* > + * Just set NULL value here because we have already iput root_ino > + * in d_make_root. > + */ > vol->root_ino = NULL; > iput(vol->lcnbmp_ino); > vol->lcnbmp_ino = NULL; -- Anton Altapa

Re: linux fsync behaviour

2014-07-25 Thread Anton Altaparmakov
? We are using >> linux XFS. > > Yes. But beware of the common mistake of using fwrite + fsync which does not actually do what you intend at all and you must instead use fwrite + fflush + fsync... If you are using write(2) then just fsync is obviously fine. Best regards, An

Re: [PATCH 1/1] ntfs: kernel-doc warning fixes

2014-07-04 Thread Anton Altaparmakov
Hi, Looks good, thanks. Feel free to add: Acked-by: Anton Altaparmakov Andrew, could you please take it in your tree for merging? Thanks a lot in advance! Best regards, Anton On 4 Jul 2014, at 20:53, Fabian Frederick wrote: > cached_page and lru_pvec were removed f

Re: [PATCH] ntfs: Drop cast

2014-06-28 Thread Anton Altaparmakov
+++ b/fs/ntfs/inode.c > @@ -1817,7 +1817,7 @@ int ntfs_read_inode_mount(struct inode *vi) > i = vol->mft_record_size; > if (i < sb->s_blocksize) > i = sb->s_blocksize; > - m = (MFT_RECORD*)ntfs_malloc_nofs(i); > + m = ntfs_malloc_nofs(i); &g

Re: [PATCH] ntfs: Cleanup string initializations (char[] instead of char *)

2014-05-17 Thread Anton Altaparmakov
ead_ntfs_boot_sector(struct super_block *sb, > const int silent) > { > - const char *read_err_str = "Unable to read %s boot sector."; > + const char read_err_str[] = "Unable to read %s boot sector."; > struct buffer_head *bh_pr

Re: [PATCH 1/1] fs/ntfs/mft.c: fix 2 sparse warnings

2014-04-28 Thread Anton Altaparmakov
length array is used. > > This is untested. > > Cc: Anton Altaparmakov > Cc: Andrew Morton > Signed-off-by: Fabian Frederick > --- > fs/ntfs/mft.c | 17 - > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/fs/ntfs/mft.c b/fs/ntfs

Re: [PATCH v2] NTFS: Remove NULL value assignments

2014-04-09 Thread Anton Altaparmakov
Hi Andrew, Please could you merge this via your patch series? Thanks a lot in advance! Best regards, Anton On 9 Apr 2014, at 18:01, Fabian Frederick wrote: > Static values are automatically initialized to NULL. > > Acked-by: Anton Altaparmakov > Cc: Andrew Morton

Re: [PATCH 1/1] NTFS: Remove NULL value assignments

2014-04-09 Thread Anton Altaparmakov
> Static values are automatically initialized to NULL. > > Cc: Andrew Morton > Cc: Anton Altaparmakov > Signed-off-by: Fabian Frederick > --- > fs/ntfs/compress.c | 2 +- > fs/ntfs/super.c| 2 +- > fs/ntfs/sysctl.c | 2 +- > 3 files changed, 3 insertions(+),

Re: [PATCH 1/1] NTFS: Logging clean-up

2014-03-16 Thread Anton Altaparmakov
Hi, On 16 Mar 2014, at 16:12, Joe Perches wrote: > On Sun, 2014-03-16 at 15:53 +0000, Anton Altaparmakov wrote: >> Hi, >> >> Looks good, thanks. You can add my Acked-by if you like. Can I assume you >> have test it builds? >> >> Andrew, can you

Re: [PATCH 1/1] NTFS: Logging clean-up

2014-03-16 Thread Anton Altaparmakov
_SPREAD, > ntfs_big_inode_init_once); > if (!ntfs_big_inode_cache) { > - printk(KERN_CRIT "NTFS: Failed to create %s!\n", > - ntfs_big_inode_cache_name); > + pr_crit("Failed to create %s!\n

Re: [PATCH 1/1] Documentation/filesystems/ntfs.txt: Remove changelog reference

2014-03-02 Thread Anton Altaparmakov
/ChangeLog. > - > 2.1.30: > - Fix writev() (it kept writing the first segment over and over again > instead of moving onto subsequent segments). > -- > 1.8.1.4 -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge J.J.

Re: [PATCH] hfsplus: Remove hfsplus_file_lookup

2013-12-11 Thread Anton Altaparmakov
mplement them via the xattr interface (ok it has the 64k limitation but most forks are quite small so not much of an issue). That's how I implemented access to named streams in Tuxera NTFS and it works a treat (and allows Linux apps and various security modules that require xattr

Re: [PATCH] add exFAT driver

2013-09-26 Thread Anton Altaparmakov
an IP license from Microsoft. For licensing information, please contact iplic...@microsoft.com. Above is from bottom of: http://www.microsoft.com/en-us/legal/intellectualproperty/IPLicensing/Programs/exFATFileSystem.aspx Best regards, Anton -- Anton Altaparmakov (replace a

Re: [PATCH] add exFAT driver

2013-09-26 Thread Anton Altaparmakov
Hi, On 25 Sep 2013, at 23:10, Greg Kroah-Hartman wrote: > On Wed, Sep 25, 2013 at 10:44:15PM +0100, Anton Altaparmakov wrote: >> On 25 Sep 2013, at 21:21, Greg Kroah-Hartman >> wrote: >>> On Wed, Sep 25, 2013 at 09:28:56PM +0200, Alexander Holler wrote: >>>&g

Re: [PATCH] add exFAT driver

2013-09-25 Thread Anton Altaparmakov
rote above in a hurry... Sorry I cannot say more but I strongly suggest NOT to use this "GPL-ed exFAT driver" under any circumstances unless you get a patent license from Microsoft first. Best regards, Anton > thanks, > > greg k-h -- Anton Altaparmakov (replace at wi

Re: cifs: bugfix for unreclaimed writeback pages in cifs_writev_requeue()

2013-03-04 Thread Anton Altaparmakov
> + end_page_writeback(wdata->pages[i]); > + page_cache_release(wdata->pages[i]); > + } > unlock_page(wdata->pages[i]); > } > -- Anton Altaparmakov (replace at with @) Unix Support, Computing Serv

Re: cifs: fix return value in cifsConvertToUTF16

2012-09-23 Thread Anton Altaparmakov
6(__le16 *target, const char *source, > int srclen, > } > > ctoUTF16_out: > - return i; > + return j; > } > > #ifdef CONFIG_CIFS_SMB2 -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux N

Re: [PATCH 19/21] ntfs: drop vmtruncate

2012-09-01 Thread Anton Altaparmakov
-git a/fs/ntfs/inode.h b/fs/ntfs/inode.h > index db29695..76b6cfb 100644 > --- a/fs/ntfs/inode.h > +++ b/fs/ntfs/inode.h > @@ -316,6 +316,10 @@ static inline void ntfs_commit_inode(struct inode *vi) > return; > } > > +#else > + > +static inline void ntfs_

Re: Possibly silly Q?

2008-01-14 Thread Anton Altaparmakov
, the blockdev utility. You want the --rereadpt option, i.e. blockdev --rereadpt /dev/sdc It is part of the util-linux package. Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maintainer, http

Re: ncpfs unlink() handling question

2007-12-21 Thread Anton Altaparmakov
source code (linux-2.6/fs/nfs/dir.c), search for "silly" (the feature is called "silly rename")... Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maintainer, http://www.

[PATCH] Fix NTFS reads regression.

2007-11-02 Thread Anton Altaparmakov
ntfs_readpage() to be called for a zero i_size inode, which failed when the file was compressed and non-resident. Looking into it I found three bugs which the patch fixes. Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of

Re: [Linux-NTFS-Dev] 2.6.23 regression: second access of empty ntfs file leads to D state hang

2007-11-02 Thread Anton Altaparmakov
Great, thanks! I will submit it to Linus. Best regards, Anton On 3 Nov 2007, at 04:56, Mike Galbraith wrote: On Fri, 2007-11-02 at 19:22 +, Anton Altaparmakov wrote: Would you be able to test it in your setup? Thanks a lot in advance! Modulo uninitialized vi, works fine. I

Re: [Linux-NTFS-Dev] 2.6.23 regression: second access of empty ntfs file leads to D state hang

2007-11-02 Thread Anton Altaparmakov
Hi Mike, On 30 Oct 2007, at 09:23, Anton Altaparmakov wrote: On 30 Oct 2007, at 08:00, Mike Galbraith wrote: On Mon, 2007-10-29 at 16:18 +0100, Mike Galbraith wrote: Not being very good at walking away from unsolved mysteries, I chased it down. The problem is that... commit

Re: [Linux-NTFS-Dev] 2.6.23 regression: second access of empty ntfs file leads to D state hang

2007-10-30 Thread Anton Altaparmakov
Hi, On 30 Oct 2007, at 08:00, Mike Galbraith wrote: On Mon, 2007-10-29 at 16:18 +0100, Mike Galbraith wrote: On Mon, 2007-10-29 at 15:43 +0100, Mike Galbraith wrote: On Mon, 2007-10-29 at 13:39 +, Anton Altaparmakov wrote: Hi Mike, Thanks for the files. That is really odd. And you are

Re: [Linux-NTFS-Dev] 2.6.23 regression: second access of empty ntfs file leads to D state hang

2007-10-29 Thread Anton Altaparmakov
oops. forgot to attach the patch... Here it is... Best regards, Anton ntfstest.diff Description: Binary data On 29 Oct 2007, at 13:39, Anton Altaparmakov wrote: Hi Mike, Thanks for the files. That is really odd. And you are sure this just works with 2.6.22.10 on the

Re: [Linux-NTFS-Dev] 2.6.23 regression: second access of empty ntfs file leads to D state hang

2007-10-29 Thread Anton Altaparmakov
then send me the NTFS error messages? The patch should cause more verbose error reporting to happen... Thanks! Best regards, Anton On 29 Oct 2007, at 11:45, Mike Galbraith wrote: On Mon, 2007-10-29 at 10:31 +0000, Anton Altaparmakov wrote: Could you post the complete dmesg outp

Re: 2.6.23 regression: second access of empty ntfs file leads to D state hang

2007-10-29 Thread Anton Altaparmakov
__lock_page+0x54/0x5c [ 401.773845] [] do_generic_mapping_read+0x236/0x4e7 [ 401.779629] [] generic_file_aio_read+0xff/0x198 [ 401.785138] [] do_sync_read+0xd0/0x106 [ 401.789873] [] vfs_read+0x89/0x11d [ 401.794266] [] sys_read+0x3d/0x64 [ 401.798569] [] syscall_call+0x7/0xb [ 401.803039]

Re: [Linux-NTFS-Dev] 2.6.23 regression: second access of empty ntfs file leads to D state hang

2007-10-29 Thread Anton Altaparmakov
esg output, please? Nothing related has changed in the NTFS driver between 2.6.22.10 and 2.6.23 so I expect something else to be at fault here. Could you post your .config as well, please? Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service,

Re: [patch 0/6][RFC] Cleanup FIBMAP

2007-10-27 Thread Anton Altaparmakov
be appreciated. The last patch, [6/6] drop_cap_sys_rawio_for_fibmap.patch, is of course, not to be applied until any remaining issues are fixed :) Thanks, Mike Waychison -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maint

[PATCH] NTFS: Fix a mount time deadlock.

2007-10-12 Thread Anton Altaparmakov
++ fs/ntfs/runlist.c |4 - 9 files changed, 181 insertions(+), 53 deletions(-) The patch is below. Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maintainer, http://www

Re: __LITTLE_ENDIAN vs. __LITTLE_ENDIAN_BITFIELD

2007-10-05 Thread Anton Altaparmakov
MSB_3SB_2SB_LSB M765432L_M765432L_M765432L_M765432L That is what little endian means and that is how shift operations can work fine on the CPU. Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maintainer, http://

Re: [03/17] is_vmalloc_addr(): Check if an address is within the vmalloc boundaries

2007-09-19 Thread Anton Altaparmakov
On 19 Sep 2007, at 18:29, Christoph Lameter wrote: On Wed, 19 Sep 2007, Anton Altaparmakov wrote: I suspect that is_vmalloc_addr() should not be in linux/mm.h at all and should be in linux/vmalloc.h instead and vmalloc.h should include linux/ highmem.h. That would be more sensible than

Re: [03/17] is_vmalloc_addr(): Check if an address is within the vmalloc boundaries

2007-09-19 Thread Anton Altaparmakov
On 19 Sep 2007, at 18:29, Christoph Lameter wrote: On Wed, 19 Sep 2007, Anton Altaparmakov wrote: There even is such a function already in mm/ sparse.c::vaddr_in_vmalloc_area() with pretty identical content. I would suggest either this new inline should go away completely and use the

Re: [03/17] is_vmalloc_addr(): Check if an address is within the vmalloc boundaries

2007-09-19 Thread Anton Altaparmakov
On 19 Sep 2007, at 10:19, David Rientjes wrote: On Wed, 19 Sep 2007, Anton Altaparmakov wrote: Although it may cause a problem as highmem.h also includes mm.h so a bit of trickery may be needed to get it to compile... I suspect that is_vmalloc_addr() should not be in linux/mm.h at all and

Re: [03/17] is_vmalloc_addr(): Check if an address is within the vmalloc boundaries

2007-09-19 Thread Anton Altaparmakov
On 19 Sep 2007, at 09:09, David Rientjes wrote: On Wed, 19 Sep 2007, Anton Altaparmakov wrote: Index: linux-2.6/include/linux/mm.h === --- linux-2.6.orig/include/linux/mm.h 2007-09-17 21:46:06.0 -0700 +++ linux-2.6

Re: [00/17] [RFC] Virtual Compound Page Support

2007-09-19 Thread Anton Altaparmakov
vcompound -- - To unsubscribe from this list: send the line "unsubscribe linux- kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ Best regards, Anton

Re: [03/17] is_vmalloc_addr(): Check if an address is within the vmalloc boundaries

2007-09-19 Thread Anton Altaparmakov
uld go away completely and use the existing one and export it or the existing one should go away and the inline should be used. It seems silly to have two functions with different names doing exactly the same thing! Best regards, Anton -- Anton Altaparmakov (replace at with

Re: VM/VFS bug with large amount of memory and file systems?

2007-09-17 Thread Anton Altaparmakov
On 17 Sep 2007, at 15:04, Anton Altaparmakov wrote: On 15 Sep 2007, at 11:52, Andrew Morton wrote: On Sat, 15 Sep 2007 12:08:17 +0200 Peter Zijlstra <[EMAIL PROTECTED]> wrote: Anyway, looks like all of zone_normal is pinned in kernel allocations: Sep 13 15:31:25 escabot Normal free:

Re: VM/VFS bug with large amount of memory and file systems?

2007-09-17 Thread Anton Altaparmakov
cause this problem to happen... Other than using buffer heads for my page cache pages that is but that is hardly a crime! /-; Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maintaine

Re: VM/VFS bug with large amount of memory and file systems?

2007-09-15 Thread Anton Altaparmakov
Hi, Thanks for looking into this. On 15 Sep 2007, at 11:08, Peter Zijlstra wrote: On Sat, 2007-09-15 at 08:27 +0100, Anton Altaparmakov wrote: Please, don't word wrap log-files, they're hard enough to read without it :-( ( I see people do this more and more often, *WHY*? is that

VM/VFS bug with large amount of memory and file systems?

2007-09-15 Thread Anton Altaparmakov
is doing wrong I am happy to try and fix it but at the moment I assume it is something the VM is doing wrong when there is so much RAM available... Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Li

Re: [PATCH] ptrdiff_t is not uintptr_t, damnit

2007-08-19 Thread Anton Altaparmakov
pointer (at least on Linux anyway). On a 32-bit arch "unsigned long" is 32-bit and pointers are 32-bit. On a 64-bit archi "unsigned long" is 64-bit and pointers are 64-bit. Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service

Re: [PATCH] ptrdiff_t is not uintptr_t, damnit

2007-08-19 Thread Anton Altaparmakov
g uintptr_t; + #ifdef CONFIG_UID16 /* This is defined by include/asm-{arch}/posix_types.h */ typedef __kernel_old_uid_t old_uid_t; - To unsubscribe from this list: send the line "unsubscribe linux- kernel" in the body of a message to [EMAIL PROTECTED] More majordomo i

Re: [PATCH RFC] extent mapped page cache

2007-07-26 Thread Anton Altaparmakov
onate your colleage to such a worthy cause. Cambridge = Cam + Bridge = Bridge over the river Cam The Cam is a bit muddy though so it is not a very enjoyable experience falling/being thrown into it. Nice for punting on though when the weather is nice. (-: Best regards, Anton -- Anto

Re: [RFH] Partition table recovery

2007-07-20 Thread Anton Altaparmakov
On 20 Jul 2007, at 12:29, Al Boldi wrote: Anton Altaparmakov wrote: parted and its derivatives are pile of crap... They cause corruption to totally healthy systems at the best of times. Don't go near them. Use TestDisk (http://www.cgsecurity.org/wiki/TestDisk) and be happy. (-: Thi

Re: [RFH] Partion table recovery

2007-07-20 Thread Anton Altaparmakov
corruption to totally healthy systems at the best of times. Don't go near them. Use TestDisk (http://www.cgsecurity.org/wiki/TestDisk) and be happy. (-: Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge, CB

[RESEND: 2.6 PATCH] Fix LDM for new field in the VOL5 VBLK.

2007-07-16 Thread Anton Altaparmakov
Hi Linus, Could you please apply the below patch now that 2.6.22 is released? Thanks a lot in advance! Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maintainer, http://www.linux-ntfs.org

Re: [2.6 PATCH] Fix LDM for new field in the VOL5 VBLK.

2007-06-27 Thread Anton Altaparmakov
On 27 Jun 2007, at 18:03, Linus Torvalds wrote: On Wed, 27 Jun 2007, Anton Altaparmakov wrote: Please apply the below patch to the LDM driver. This looks fine, but last time I applied a LDM patch just before release, there was some embarrassing compile problem with it. See commit

Re: [RFC] fsblock

2007-06-27 Thread Anton Altaparmakov
based api, but we keep the dirty each buffer part. writepages has to turn that back into extents (bio sized), and the result is completely full of dark dark corner cases. I do think fsblocks is a nice cleanup on its own, but Dave has a good point that it makes sense to look for ways gen

[2.6 PATCH] Fix LDM for new field in the VOL5 VBLK.

2007-06-27 Thread Anton Altaparmakov
s time I will not break the patch before sending the email off... (-; Please apply to 2.6.22 if not too late yet... Thanks! Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maintainer

Re: [PATCH resend] introduce I_SYNC

2007-06-01 Thread Anton Altaparmakov
exists with ilookup5() and is avoided by ilookup5_nowait(). This deadlock is inherent to what NTFS does so you don't need to worry about it. (If you want I am happy to explain it but I would rather not waste my time explaining if no-one except me cares about it...) Best regards

Re: [PATCH] partitions/LDM: build fix

2007-05-22 Thread Anton Altaparmakov
On 22 May 2007, at 05:28, Jeff Garzik wrote: This from a "tested" patch... I had already posted a fix earlier: From: Anton Altaparmakov <[EMAIL PROTECTED]> Subject: Fix to the fix! - Re: [2.6 PATCH] LDM: Fix for Windows Vista dynamic disks Date: 21 M

Fix to the fix! - Re: [2.6 PATCH] LDM: Fix for Windows Vista dynamic disks

2007-05-21 Thread Anton Altaparmakov
roken one line... Hopefully I will manage to send it without breaking it, too! /-; Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maintainer, http://www.linux-ntfs.org/ --- Fix the finger tr

[2.6 PATCH] LDM: Fix for Windows Vista dynamic disks

2007-05-21 Thread Anton Altaparmakov
Chris Teachworth for the report and testing. Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maintainer, http://www.linux-ntfs.org/ --- From: Anton Altaparmakov <[EMAIL PROTECTED]> Fix t

Re: Ext3 vs NTFS performance

2007-05-04 Thread Anton Altaparmakov
On 4 May 2007, at 10:46, Christoph Hellwig wrote: On Fri, May 04, 2007 at 09:12:31AM +0100, Anton Altaparmakov wrote: Nothing to do with win32 functions. Windows does NOT create sparse files therefore it never can have an issue like ext3 does in this scenario. Windows will cause nice

Re: Ext3 vs NTFS performance

2007-05-04 Thread Anton Altaparmakov
time Windows will create sparse files is if you specifically mark a file as sparse using the FSCTL_SET_SPARSE ioctl and then create a sparse region using the FSCTL_SET_ZERO_DATA ioctl. Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, U

Re: UID/GID override on CIFS mounts to Samba and proposed new mount parameter to disable Unix Extensions on the client

2007-04-30 Thread Anton Altaparmakov
Why "linuxextensions"? I thought those are the "UNIX extensions" that Samba provides no matter on which platform it is run such as Linux, Mac OS X, Solaris, etc... Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, Universi

Re: Linux 2.6.21

2007-04-30 Thread Anton Altaparmakov
to our workflow voluntarily which says something... Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maintainer, http://www.linux-ntfs.org/ - To unsubscribe from this list: send the line "

Re: [PATCH 1/2] fs: use memclear_highpage_flush to zero page data

2007-04-10 Thread Anton Altaparmakov
hing people's data left right an centre! Best regards, Anton -- Anton Altaparmakov (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maintainer, http://www.linux-ntfs.org/ - To unsubscribe from this list: send the line "unsubscri

  1   2   3   4   >