Re: [PATCH] staging: comedi: ni_*

2017-12-13 Thread Aniruddha Shastri
On Wed, Dec 13, 2017 at 6:07 AM, Greg Kroah-Hartman wrote: > On Wed, Dec 13, 2017 at 05:16:13PM +0530, Aniruddha Shastri wrote: >> On Wed, Dec 13, 2017 at 4:20 PM, Greg Kroah-Hartman >> wrote: >> > >> > On Wed, Dec 13, 2017 at 04:01:04AM -0600, Aniruddha Sha

[PATCH v3] staging: comedi: ni_*: Fix style warnings.

2017-12-13 Thread Aniruddha Shastri
function definition argument 'int *' should also have an identifier name ni_mio_common.c:4699: WARNING: Prefer using '"%s...", __func__' to using 'cs5529_do_conversion', this function's name, in a string ni_stc.h:21: WARNING: Block comments should

[PATCH v2] staging: comedi: ni_*: Fix style warnings.

2017-12-13 Thread Aniruddha Shastri
ould also have an identifier name ni_mio_common.c:4302: WARNING: function definition argument 'int *' should also have an identifier name ni_mio_common.c:4699: WARNING: Prefer using '"%s...", __func__' to using 'cs5529_do_conversion', this fu

Re: [PATCH] staging: comedi: ni_*

2017-12-13 Thread Aniruddha Shastri
On Wed, Dec 13, 2017 at 4:20 PM, Greg Kroah-Hartman wrote: > > On Wed, Dec 13, 2017 at 04:01:04AM -0600, Aniruddha Shastri wrote: > > Fix checkpatch warnings by shortening lines and reorganizing code where > > needed.. > > Re-phrase the assert messages in ni_mio_common.

[PATCH] staging: comedi: ni_*

2017-12-13 Thread Aniruddha Shastri
Fix checkpatch warnings by shortening lines and reorganizing code where needed.. Re-phrase the assert messages in ni_mio_common.c. This was done to meet the character limit for the message. Signed-off-by: Aniruddha Shastri --- drivers/staging/comedi/drivers/ni_670x.c | 3 +- drivers