RE: [PATCH] ARM: dts: add minimal DT support for DevKit8000

2013-02-08 Thread AnilKumar
Hi Mark, Thanks for the review comments. Please find my comments inline. On Thu, Feb 07, 2013 at 23:09:49, Mark Rutland wrote: > Hello, > > I have a couple of minor comments. > > On Thu, Feb 07, 2013 at 02:11:37PM +, Anil Kumar wrote: > > DevKit8000 is a beagle board clone from Timll, sold

RE: [PATCH] mfd: tps65910: Select REGMAP_IRQ in Kconfig to fix build error

2013-01-18 Thread AnilKumar, Chimata
On Wed, Jan 09, 2013 at 22:22:35, Porter, Matt wrote: > On Wed, Jan 02, 2013 at 10:15:39AM +0000, AnilKumar wrote: > > On Mon, Dec 10, 2012 at 16:44:56, AnilKumar, Chimata wrote: > > > TPS65910 mfd driver uses functions that are only avaiable when > > > REGMAP_IRQ is ena

RE: [PATCH] mfd: tps65910: Select REGMAP_IRQ in Kconfig to fix build error

2013-01-02 Thread AnilKumar, Chimata
On Mon, Dec 10, 2012 at 16:44:56, AnilKumar, Chimata wrote: > TPS65910 mfd driver uses functions that are only avaiable when > REGMAP_IRQ is enabled. So "select REGMAP_IRQ" is added to mfd > Kconfig to fix below build error: > > drivers/built-in.o: In function `tps65910

RE: [PATCH] mfd: tps65910: Select REGMAP_IRQ in Kconfig to fix build error

2012-12-16 Thread AnilKumar, Chimata
On Mon, Dec 10, 2012 at 16:44:56, AnilKumar, Chimata wrote: > TPS65910 mfd driver uses functions that are only avaiable when > REGMAP_IRQ is enabled. So "select REGMAP_IRQ" is added to mfd > Kconfig to fix below build error: > > drivers/built-in.o: In function `tps65910

[PATCH] mfd: tps65910: Select REGMAP_IRQ in Kconfig to fix build error

2012-12-10 Thread AnilKumar Ch
65910.c:509: undefined reference to `regmap_irq_get_domain' make: *** [vmlinux] Error 1 Signed-off-by: AnilKumar Ch --- drivers/mfd/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 1c0abd4..01413a2 100644 --- a/drivers/mfd/Kconfig +++ b/driver

RE: [PATCH RESEND] regulator: tps65910: fix BUG_ON() shown with vrtc regulator

2012-11-13 Thread AnilKumar, Chimata
On Wed, Nov 14, 2012 at 11:49:14, Mark Brown wrote: > On Wed, Nov 14, 2012 at 11:24:39AM +0530, AnilKumar Ch wrote: > > Fix BUG_ON() error if tps65910 VRTC regulator is used with out > > rdev->desc->volt_table data. Recent changes in regulator core driver >

[PATCH RESEND] regulator: tps65910: fix BUG_ON() shown with vrtc regulator

2012-11-13 Thread AnilKumar Ch
he voltage table information to fix the issue. Signed-off-by: AnilKumar Ch --- drivers/regulator/tps65910-regulator.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/regulator/tps65910-regulator.c b/drivers/regulator/tps65910-regulator.c index 793adda..1d2dd18 100644 --- a/d

RE: [PATCH 1/2] Input: matrix-keypad - remove const from pointer to array of gpios

2012-10-30 Thread AnilKumar, Chimata
On Sat, Oct 20, 2012 at 04:30:59, Dmitry Torokhov wrote: > On Fri, Oct 19, 2012 at 12:36:12PM +0530, AnilKumar Ch wrote: > > Remove const from pointer to array of gpios in matrix_keypad_platform_data > > struct. This is required if we update row_gpios and col_gpios based on >

RE: [PATCH 2/2] Input: matrix-keypad - Add device tree support

2012-10-30 Thread AnilKumar, Chimata
Hi Rob, Thanks for the comments. On Fri, Oct 19, 2012 at 18:27:21, Rob Herring wrote: > On 10/19/2012 02:06 AM, AnilKumar Ch wrote: > > Add device tree support to matrix keypad driver and usage details > > are added to device tree documentation. Driver was tested on

RE: [RFC PATCH v3 13/16] ARM: dts: add AM33XX MMC support

2012-10-29 Thread AnilKumar, Chimata
al-reset; > + dmas = <&edma 2 > + &edma 3>; > + dma-names = "tx", "rx"; > + status = "disabled"; > + }; > + > +

[PATCH 0/2] Input: matrix-keypad - Add device tree support

2012-10-19 Thread AnilKumar Ch
Add device tree support to matrix keypad driver by adding all necessary DT parameters. Also added device tree bindings. These patches were tested on AM335x-EVM with DT patches, DT patches will be submitted once these are accepted. AnilKumar Ch (2): Input: matrix-keypad - remove const from

[PATCH 1/2] Input: matrix-keypad - remove const from pointer to array of gpios

2012-10-19 Thread AnilKumar Ch
Remove const from pointer to array of gpios in matrix_keypad_platform_data struct. This is required if we update row_gpios and col_gpios based on device tree data. Signed-off-by: AnilKumar Ch --- include/linux/input/matrix_keypad.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH 2/2] Input: matrix-keypad - Add device tree support

2012-10-19 Thread AnilKumar Ch
Add device tree support to matrix keypad driver and usage details are added to device tree documentation. Driver was tested on AM335x EVM. Signed-off-by: AnilKumar Ch --- .../devicetree/bindings/input/matrix-keypad.txt| 52 ++ drivers/input/keyboard/matrix_keypad.c

[PATCH] regulator: tps65910: fix BUG_ON() shown with vrtc regulator

2012-10-15 Thread AnilKumar Ch
he voltage table information to fix the issue. Signed-off-by: AnilKumar Ch --- drivers/regulator/tps65910-regulator.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/regulator/tps65910-regulator.c b/drivers/regulator/tps65910-regulator.c index 793adda..1d2dd18 100644 --- a/d

RE: [PATCH v2] lis3lv02d: Add STMicroelectronics lis331dlh digital accelerometer

2012-09-23 Thread AnilKumar, Chimata
Hi Eric, Thanks for the comments, On Mon, Sep 24, 2012 at 03:08:19, Éric Piel wrote: > On 22-08-12 08:30, AnilKumar Ch wrote: > > This patch adds support for lis331dlh digital accelerometer to the > > lis3lv02d driver family. Adds ID field for detecting the lis331dlh > > mod

[PATCH] regulator: core: fix rdev->regmap NULL pointer

2012-09-07 Thread AnilKumar Ch
Fixes rdev->regmap NULL pointer if regmap for regulator device is NULL. If it is NULL then get regmap for regulator device from its parent (MFD). Signed-off-by: AnilKumar Ch --- drivers/regulator/core.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/regula

RE: [PATCH RFT] regulator: tps65217: Convert to regulator_[is_enabled|get_voltage_sel]_regmap

2012-09-07 Thread AnilKumar, Chimata
On Fri, Sep 07, 2012 at 20:00:59, Mark Brown wrote: > On Fri, Sep 07, 2012 at 02:26:53PM +0000, AnilKumar, Chimata wrote: > > On Fri, Sep 07, 2012 at 19:51:51, Mark Brown wrote: > > > > You didn't send a patch. > > > Its there, above to my comment >

RE: [PATCH RFT] regulator: tps65217: Convert to regulator_[is_enabled|get_voltage_sel]_regmap

2012-09-07 Thread AnilKumar, Chimata
On Fri, Sep 07, 2012 at 19:51:51, Mark Brown wrote: > On Fri, Sep 07, 2012 at 02:19:59PM +0000, AnilKumar, Chimata wrote: > > > Currently this is not properly taken care, is there are any specific > > reasons for this? > > You didn't send a patch. > Its

RE: [PATCH RFT] regulator: tps65217: Convert to regulator_[is_enabled|get_voltage_sel]_regmap

2012-09-07 Thread AnilKumar, Chimata
On Mon, Jun 18, 2012 at 18:15:14, Mark Brown wrote: > On Mon, Jun 18, 2012 at 12:39:38PM +0000, AnilKumar, Chimata wrote: > > > + if (config->regmap) > > + rdev->regmap = config->regmap; > > + else > > + rdev->regmap = dev_get_regm

RE: [PATCH v2] lis3lv02d: Add STMicroelectronics lis331dlh digital accelerometer

2012-08-27 Thread AnilKumar, Chimata
Hi Eric, On Wed, Aug 22, 2012 at 13:18:38, Arnd Bergmann wrote: > On Wednesday 22 August 2012, AnilKumar Ch wrote: > > This patch adds support for lis331dlh digital accelerometer to the > > lis3lv02d driver family. Adds ID field for detecting the lis331dlh > > module, b

RE: [PATCH v2] lis3lv02d: Add STMicroelectronics lis331dlh digital accelerometer

2012-08-23 Thread AnilKumar, Chimata
2d: hi 0xc0 low 0x60 val 0xfc06 [ 47.613464] lis3lv02d: hi 0xfd low 0x90 val 0xffd9 [ 47.619934] lis3lv02d: hi 0x2low 0x40 val 0x24 (-994,-38,35) Lower nibble always "0" Regards AnilKumar -- To unsubscribe from this list: send the line "unsubscribe linux-ke

RE: [PATCH v2] lis3lv02d: Add STMicroelectronics lis331dlh digital accelerometer

2012-08-23 Thread AnilKumar, Chimata
> Note from datasheet, "1LSb=4g/4096 at 12bit representation, ±2g Full-scale" >From this I understood that ±2G full scale value is 12 bits. That is one more reason to take 12bit value. Regards AnilKumar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&q

RE: [PATCH v2] lis3lv02d: Add STMicroelectronics lis331dlh digital accelerometer

2012-08-22 Thread AnilKumar, Chimata
ICAL_RESOURCES/TECHNICAL_LITERATURE/APPLICATION_NOTE/CD00215823.pdf Corresponding to the 4G and 8G I got the details form older patches (SHIFT_ADJ_4G and SHIFT_ADJ_8G). http://driverdev.linuxdriverproject.org/pipermail/devel/2010-November/009685.html We can easily interpret number of bits for 4G a

RE: [PATCH v2] lis3lv02d: Add STMicroelectronics lis331dlh digital accelerometer

2012-08-22 Thread AnilKumar, Chimata
lis3lv02d_read_16; > + lis3->mdps_max_val = 32768; /* 16 bits for +/-2G */ This driver supports only +/-2G range of values so it is limited to 2048. With this we do not have the runtime change of G range so by default 2G is added. Regards AnilKumar

[PATCH v2] lis3lv02d: Add STMicroelectronics lis331dlh digital accelerometer

2012-08-21 Thread AnilKumar Ch
This patch adds support for lis331dlh digital accelerometer to the lis3lv02d driver family. Adds ID field for detecting the lis331dlh module, based on this ID field lis3lv02d driver will export the lis331dlh module functionality. Signed-off-by: AnilKumar Ch --- Changes from v1: - Removed

RE: linux-next: Tree for July 17 (mfd/tps65217.c)

2012-08-21 Thread AnilKumar, Chimata
Hi Samuel, On Tue, Aug 21, 2012 at 23:21:37, Randy Dunlap wrote: > On 08/05/2012 11:38 PM, AnilKumar, Chimata wrote: > > > On Fri, Aug 03, 2012 at 22:58:01, Randy Dunlap wrote: > >> On 07/17/2012 02:48 PM, Randy Dunlap wrote: > >> > >>> On 0

RE: [PATCH v3 1/2] lis3: add generic DT matching code

2012-08-07 Thread AnilKumar, Chimata
Hi Mack, No attachments please. On Wed, Aug 08, 2012 at 00:19:01, Daniel Mack wrote: > Hi, > > thanks for your review. > > On 06.08.2012 12:45, AnilKumar, Chimata wrote: > > On Sun, Aug 05, 2012 at 21:48:42, Daniel Mack wrote: > >> On 30.07.2012 09:36, Daniel Mac

RE: [PATCH v3 1/2] lis3: add generic DT matching code

2012-08-06 Thread AnilKumar, Chimata
On Sun, Aug 05, 2012 at 21:48:42, Daniel Mack wrote: > Ping, anyone? > > On 30.07.2012 09:36, Daniel Mack wrote: > > This patch adds logic to parse lis3 properties from a device tree node > > and store them in a freshly allocated lis3lv02d_platform_data. > > > > Note that the actual match tables

RE: linux-next: Tree for July 17 (mfd/tps65217.c)

2012-08-05 Thread AnilKumar, Chimata
ot enabled. > > > > > This build error is still present in linux-next of 20120803. > This will be fixed with this patch https://patchwork.kernel.org/patch/1220151/ Today, I will submit v2 for this Regards AnilKumar -- To unsubscribe from this list: send the line "unsubscribe linu

RE: [PATCH] lis3lv02d: Add STMicroelectronics lis33ldlh digital

2012-07-25 Thread AnilKumar, Chimata
Hi Arnd, On Thu, Jan 19, 2012 at 22:40:45, Arnd Bergmann wrote: > On Thursday 19 January 2012, AnilKumar, Chimata wrote: > > Android userspace running on TI AM335x EVM is using the interface > > provided by lis3lv02d. They were asking some more interfaces from > > lis3lvo2d d

RE: [PATCH] regulator: tps65217: fix build error if REGULATOR is not enabled

2012-07-19 Thread AnilKumar, Chimata
Hi Mark, On Wed, Jul 18, 2012 at 15:30:13, Mark Brown wrote: > On Wed, Jul 18, 2012 at 09:55:57AM +0000, AnilKumar, Chimata wrote: > > > Regulators platform data is added to platform device in MFD driver, which we > > need for regulator driver, of_regulator_match() is

RE: [PATCH] regulator: tps65217: fix build error if REGULATOR is not enabled

2012-07-18 Thread AnilKumar, Chimata
Mark, On Wed, Jul 18, 2012 at 15:14:49, Mark Brown wrote: > On Wed, Jul 18, 2012 at 12:11:03PM +0530, AnilKumar Ch wrote: > > Fixes below build error if CONFIG_REGULATOR is not enabled. > > > > drivers/built-in.o: In function `tps65217_probe': > > tps65217.c:(.

[PATCH] regulator: tps65217: fix build error if REGULATOR is not enabled

2012-07-17 Thread AnilKumar Ch
Fixes below build error if CONFIG_REGULATOR is not enabled. drivers/built-in.o: In function `tps65217_probe': tps65217.c:(.devinit.text+0x13e37): undefined reference to `of_regulator_match' Signed-off-by: AnilKumar Ch --- drivers/mfd/Kconfig |1 + 1 file changed, 1 insertion(+)

RE: [PATCH v2 1/3] regulator: tps65217: Add device tree support

2012-07-16 Thread AnilKumar, Chimata
+Tony Tony, On Fri, Jul 13, 2012 at 15:24:54, Mark Brown wrote: > On Fri, Jul 13, 2012 at 05:43:30AM +0000, AnilKumar, Chimata wrote: > > > Thanks much, are you going to push reset of the patches in this series? > > No, there's no dependency so I'd expe

RE: [PATCH v2 1/3] regulator: tps65217: Add device tree support

2012-07-12 Thread AnilKumar, Chimata
Hi Mark, On Thu, Jul 12, 2012 at 22:58:37, Mark Brown wrote: > On Tue, Jul 10, 2012 at 04:39:42PM +0530, AnilKumar Ch wrote: > > This commit adds device tree support for tps65217 pmic. And usage > > details are added to device tree documentation. Driver is tested > > by usi

[PATCH v2 1/3] regulator: tps65217: Add device tree support

2012-07-10 Thread AnilKumar Ch
This commit adds device tree support for tps65217 pmic. And usage details are added to device tree documentation. Driver is tested by using kernel module with regulator set and get APIs. Signed-off-by: AnilKumar Ch --- .../devicetree/bindings/regulator/tps65217.txt | 91

[PATCH v2 2/3] ARM: OMAP2+: AM33XX: Add tps65910 device tree data

2012-07-10 Thread AnilKumar Ch
file (tps65910.dtsi). This patch is tested by adding the I2C slave address of TPS65910 pmic to am335x-evm.dts file (Not included in this, I2C slave addition patch will be submitted to linux-omap, where am335x-evm.dts binding file is available). Signed-off-by: AnilKumar Ch --- arch/arm/boot/dts

[PATCH v2 0/3] Add device tree support for AM33XX regulators

2012-07-10 Thread AnilKumar Ch
AnilKumar Ch (3): regulator: tps65217: Add device tree support ARM: OMAP2+: AM33XX: Add tps65910 device tree data ARM: OMAP2+: AM33XX: Add tps65217 device tree data .../devicetree/bindings/regulator/tps65217.txt | 91 +++ arch/arm/boot/dts/tps65217.dtsi| 84

[PATCH v2 3/3] ARM: OMAP2+: AM33XX: Add tps65217 device tree data

2012-07-10 Thread AnilKumar Ch
include file (tps65217.dtsi). This patch is tested by adding the I2C slave address of TPS65217 pmic to am335x-bone.dts file (Not included in this, I2C slave addition patch will be submitted to linux-omap, where am335x-bone.dts binding file is available). Signed-off-by: AnilKumar Ch --- arch/arm