On 8/16/19 3:06 PM, Gerd Rausch wrote:
> Hi,
>
> Just added the e-mail addresses I found using a simple "google search",
> in order to reach out to the original authors of these commits:
> Chris Mason and Andy Grover.
>
> I'm hoping they still remember their
On 02/26/2017 09:59 PM, Xiubo Li wrote:
>> But, We likely don't want to release memory from the data area anyways
>> while active, in any case. How about if we set a timer when active
>> commands go to zero, and then reduce data area to some minimum if no new
>> cmds come in before timer expires?
>
On 02/23/2017 06:07 PM, Xiubo Li wrote:
>> Cool. This is a good approach for an initial patch but this raises
>> concerns about efficiently managing kernel memory usage -- the data area
>> grows but never shrinks, and total possible usage increases per
>> backstore. (What if there are 1000?) Any id
On 02/17/2017 01:24 AM, lixi...@cmss.chinamobile.com wrote:
> From: Xiubo Li
>
> Currently for the TCMU, the ring buffer size is fixed to 64K cmd
> area + 1M data area, and this will be bottlenecks for high iops.
Hi Xiubo, thanks for your work.
daynmic -> dynamic
Have you benchmarked this patc
On 02/15/2017 05:34 PM, Xiubo Li wrote:
>>> --- a/drivers/uio/uio.c
>>> +++ b/drivers/uio/uio.c
>>> @@ -708,6 +708,8 @@ static int uio_mmap(struct file *filep, struct
>>> vm_area_struct *vma)
>>> case UIO_MEM_LOGICAL:
>>> case UIO_MEM_VIRTUAL:
>>> return uio_mmap_l
On 10/05/2016 10:43 AM, Alasdair G Kergon wrote:
On Wed, Oct 05, 2016 at 10:06:41AM -0700, Andy Grover wrote:
My project *would* like this added sooner, so I'll work on a revised
patchset that uses netlink instead of uevents, and will also work on a
revision to uevents.txt that talks
On 10/04/2016 11:51 PM, Greg KH wrote:
On Wed, Oct 05, 2016 at 01:40:05AM +0100, Alasdair G Kergon wrote:
We see these as two different categories of notifications, and prefer
the greater flexibility a mechanism independent of uevents would
provide. The team has discussed several alternatives
On 10/04/2016 12:20 AM, Greg KH wrote:
On Mon, Oct 03, 2016 at 12:22:51PM -0700, Andy Grover wrote:
Hi Mike and GregKH,
I want a way to get devicemapper events without using the DM ioctl,
because that requires creating a thread to sleep in the ioctl for each
dm device I want events from.
It
these to dm-mpath.c and expose a few lower-level functions,
dm_build_uevent, dm_uevent_add and dm_uevent_free, for other dm targets to
build their own uevents.
Signed-off-by: Andy Grover
---
drivers/md/dm-mpath.c | 71 +++
drivers/md/dm-uevent.c
Document the current dm uevent API, as modified by this patchset.
Signed-off-by: Andy Grover
---
Documentation/device-mapper/dm-uevent.txt | 49 ++-
1 file changed, 42 insertions(+), 7 deletions(-)
diff --git a/Documentation/device-mapper/dm-uevent.txt
b
Generate uevents for other targets: cache, log, raid1, and snap.
Signed-off-by: Andy Grover
---
drivers/md/dm-cache-target.c | 5 -
drivers/md/dm-log-userspace-base.c | 8 ++--
drivers/md/dm-log.c| 1 +
drivers/md/dm-raid1.c | 1 +
drivers/md/dm-snap.c
This helper function builds and enqueues the uevent. Targets can use this
when they do not need to customize the uevent beyond its name.
Signed-off-by: Andy Grover
---
Documentation/device-mapper/dm-uevent.txt | 5 +
drivers/md/dm-uevent.c| 26
For consistency with other function names that start with 'dm_uevent'.
Signed-off-by: Andy Grover
---
Documentation/device-mapper/dm-uevent.txt | 2 +-
drivers/md/dm-mpath.c | 4 ++--
drivers/md/dm-uevent.c| 4 ++--
drivers/md/d
Generate uevents when thin pool devices hit data or metadata low water
marks, and when pool mode changes.
Signed-off-by: Andy Grover
---
drivers/md/dm-thin.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c
index d1c05c1..0778a2a 100644
--- a
For clarity. This function queues an event to be sent, which is not
totally clear from the previous name. And, we want to reuse the name
for something else.
Signed-off-by: Andy Grover
---
Documentation/device-mapper/dm-uevent.txt | 2 +-
drivers/md/dm-mpath.c | 2 +-
drivers
Since it's no longer an API boundary we can consolidate these two
functions.
Signed-off-by: Andy Grover
---
drivers/md/dm-mpath.c | 59 +++
1 file changed, 22 insertions(+), 37 deletions(-)
diff --git a/drivers/md/dm-mpath.c b/drivers/
owing patchset may be appliable if you're actually ok with
using KOBJ_CHANGE for dm events, or if not, then I'll look to rework
it to use a dm-specific genetlink approach.
Thanks -- Regards -- Andy
Andy Grover (9):
dm: Do not export dm_send_uevents
dm: Move multipath-specific stuff out
Since dm-uevent.c (if CONFIG_DM_UEVENT) is part of the same module as where
dm_sent_uevents is called, it does not need to be exported.
Signed-off-by: Andy Grover
---
drivers/md/dm-uevent.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/md/dm-uevent.c b/drivers/md/dm-uevent.c
index
On 06/06/2016 11:23 PM, Nicholas A. Bellinger wrote:
Hi HCH & Co,
On Mon, 2016-06-06 at 23:22 +0200, Christoph Hellwig wrote:
This patch set adds a generic NVMe over Fabrics target. The
implementation conforms to the NVMe 1.2b specification (which
includes Fabrics) and provides the NVMe over Fa
On 09/03/2015 12:12 PM, Greg KH wrote:
On Thu, Sep 03, 2015 at 11:47:34AM -0700, Andy Grover wrote:
On 09/03/2015 05:26 AM, Michal Hocko wrote:
On Wed 02-09-15 15:45:10, Andy Grover wrote:
Hi Hans and Greg,
Is this an issue with uio? I swear it didn't used to throw this warning...
T
On 09/03/2015 05:26 AM, Michal Hocko wrote:
On Wed 02-09-15 15:45:10, Andy Grover wrote:
Hi Hans and Greg,
Is this an issue with uio? I swear it didn't used to throw this warning...
Thanks -- Andy
[ 5174.883261] [ cut here ]
[ 5174.883617] WARNING: CPU: 0 PID: 15
Hi Hans and Greg,
Is this an issue with uio? I swear it didn't used to throw this warning...
Thanks -- Andy
[ 5174.883261] [ cut here ]
[ 5174.883617] WARNING: CPU: 0 PID: 1532 at
/home/agrover/git/kernel/kernel/sched/core.c:7389 __might_sleep+0x7d/0x90()
[ 5174.884407]
On 05/12/2015 02:25 AM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger
This patch converts fabric independent configfs link/unlink to use
RCU read path macros for se_node_acl->lun_entry_hlist access.
It also converts SCSI MIB configfs show attribute code to use
RCU read path macros for
On 05/12/2015 02:25 AM, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger
This patch converts se_node_acl->device_list[] table for mappedluns
to modern RCU hlist_head usage in order to support an arbitrary number
of node_acl lun mappings.
This includes changes to core_[enable,disable]_devi
The docs state that sysfs and configfs are peers that meet different needs,
but doesn't explicitly make it clear that if a subsystem needs
functionality that spans both, it is preferable to use both instead of
trying to cram everything into one or the other.
Signed-off-by: Andy G
__attribu...
and so forth.)
Cc: sta...@vger.kernel.org # 3.18
Signed-off-by: Kyle McMartin
---
cc-ing stable@ so this headers fix gets picked up by distros.
Acked-by: Andy Grover
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to major
On 10/13/2014 12:50 AM, Michael S. Tsirkin wrote:
virtio spec 0.9.X requires DRIVER_OK to be set before
VQs are used, but some drivers use VQs before probe
function returns.
Since DRIVER_OK is set after probe, this violates the spec.
Even though under virtio 1.0 transitional devices support this
The check of SCF_SCSI_DATA_CDB seems to be a remnant from before hch's
refactoring of this function. There are no places where that flag is set
that cmd->execute_cmd isn't also set.
Signed-off-by: Andy Grover
---
drivers/target/target_core_sbc.c | 2 +-
1 file changed, 1 in
le if device is unconfigured in tcmu_free_device
Thanks -- Andy
Andy Grover (4):
target: Remove unneeded check in sbc_parse_cdb
uio: Export definition of struct uio_device
target: Add documentation on the target userspace pass-through driver
target: Add a user-passthrough backstore
Docum
* The use of idrs may be overkill -- we maybe can replace them with a
simple counter to generate cmd_ids, and a hash table to get a cmd_id's
associated pointer.
* Use of a free-running counter for cmd ring instead of explicit modulo
math. This would require power-of-2 cmd ring siz
Describes the driver and its interface to make it possible for user
programs to back a LIO-exported LUN.
Thanks to Richard W. M. Jones for review, and supplementing this doc
with the first two paragraphs.
Signed-off-by: Andy Grover
---
Documentation/target/tcmu-design.txt | 378
In order to prevent a O(n) search of the filesystem to link up its uio
node with its target configuration, TCMU needs to know the minor number
that UIO assigned. Expose the definition of this struct so TCMU can
access this field.
Signed-off-by: Andy Grover
---
drivers/uio/uio.c | 12
On 09/18/2014 04:17 PM, Nicholas A. Bellinger wrote:
I'm currently reviewing #2, #4, #5 and #7 and will consider merging
these. These cleanups account for most of the LOC reduction, and avoid
most of the larger concerns.
Also for patches like this, they really need testing on your end before
I
On 09/22/2014 01:58 PM, Nicholas A. Bellinger wrote:
So I'd still like to start for an initial merge with the two different
modes mentioned earlier. The pure-passthrough mode where everything is
handled by user-space, and an I/O passthrough mode where only
SCF_SCSI_DATA_CDB is passed along to us
On 09/19/2014 04:51 PM, Alex Elsayed wrote:
Not sure I follow.. How does the proposed passthrough mode prevent
someone from emulating OSDs, media changers, optical disks or anything
else in userspace with TCMU..?
The main thing that the above comments highlight is why attempting to
combine the
On 09/18/2014 12:38 AM, Nicholas A. Bellinger wrote:
On Sat, 2014-09-13 at 21:55 +0200, Christoph Hellwig wrote:
ping again. We're getting closer to the end of the 3.18 merge window
and there still hasn't been a response. Should Andy just send the patches
directly to Linus once 3.18 opens give
lly is hindered until the kernel code is accepted :)
Changes since version 2:
* Incorporate doc improvements from Richard W. M. Jones
* Correct off-by-1 error in tcmu_get_blocks
* execute_rw must be set in the sbc_ops passed to sbc_parse_cdb
Thanks -- Andy
Andy Grover (4):
target: Remove un
Describes the driver and its interface to make it possible for user
programs to back a LIO-exported LUN.
Thanks to Richard W. M. Jones for review, and supplementing this doc
with the first two paragraphs.
Signed-off-by: Andy Grover
---
Documentation/target/tcmu-design.txt | 239
In order to prevent a O(n) search of the filesystem to link up its uio
node with its target configuration, TCMU needs to know the minor number
that UIO assigned. Expose the definition of this struct so TCMU can
access this field.
Signed-off-by: Andy Grover
---
drivers/uio/uio.c | 12
* The use of idrs may be overkill -- we maybe can replace them with a
simple counter to generate cmd_ids, and a hash table to get a cmd_id's
associated pointer.
* Use of a free-running counter for cmd ring instead of explicit modulo
math. This would require power-of-2 cmd ring siz
The check of SCF_SCSI_DATA_CDB seems to be a remnant from before hch's
refactoring of this function. There are no places where that flag is set
that cmd->execute_cmd isn't also set.
Signed-off-by: Andy Grover
---
drivers/target/target_core_sbc.c | 2 +-
1 file changed, 1 in
On 08/31/2014 02:22 PM, Richard W.M. Jones wrote:
Reading this several times, I now think I get what it's trying to say,
but I think it needs to introduces the terms (as the Economist style
does). Something like this:
"TCM is the new name for LIO, an in-kernel iSCSI target (server).
Exist
On 08/30/2014 10:35 AM, Richard W.M. Jones wrote:
On Tue, Jul 01, 2014 at 12:11:14PM -0700, Andy Grover wrote:
Describes the driver and its interface to make it possible for user
programs to back a LIO-exported LUN.
Signed-off-by: Andy Grover
---
Documentation/target/tcmu-design.txt | 210
rintks in code, still.
Signed-off-by: Andy Grover
---
drivers/target/Kconfig |5 +
drivers/target/Makefile|1 +
drivers/target/target_core_transport.c |4 +
drivers/target/target_core_user.c | 1158
include/uapi/li
Describes the driver and its interface to make it possible for user
programs to back a LIO-exported LUN.
Signed-off-by: Andy Grover
---
Documentation/target/tcmu-design.txt | 229 +++
1 file changed, 229 insertions(+)
create mode 100644 Documentation/target/tcmu
s/userback, create a user
storage object and give it a size, and 'file/foo.img' as config
parameter
* Start tcmu-runner (manually for now)
* Create a loopback fabric and link the above storage object to it
Andy Grover (4):
target: Remove unneeded check in sbc_parse_cdb
uio: Export d
The check of SCF_SCSI_DATA_CDB seems to be a remnant from before hch's
refactoring of this function. There are no places where that flag is set
that cmd->execute_cmd isn't also set.
Signed-off-by: Andy Grover
---
drivers/target/target_core_sbc.c | 2 +-
1 file changed, 1 in
In order to prevent a O(n) search of the filesystem to link up its uio
node with its target configuration, TCMU needs to know the minor number
that UIO assigned. Expose the definition of this struct so TCMU can
access this field.
Signed-off-by: Andy Grover
---
drivers/uio/uio.c | 12
[re-adding individual CCs that were dropped]
On 07/05/2014 04:29 AM, Alex Elsayed wrote:
+Device Discovery:
+
+Other devices may be using UIO besides TCMU. Unrelated user processes
+may also be handling different sets of TCMU devices. TCMU userspace
+processes must find their devices by scanning
Hi, here's some additional beginning bits for the configuration and use
of this code:
Changes to targetcli-fb and rtslib-fb:
https://github.com/agrover/targetcli-fb/tree/userback
https://github.com/agrover/rtslib-fb/tree/userback
An incredibly-crappy stand-in for the user process that will han
rintks in code, still.
Signed-off-by: Andy Grover
---
drivers/target/Kconfig |5 +
drivers/target/Makefile|1 +
drivers/target/target_core_transport.c |4 +
drivers/target/target_core_user.c | 1078
drivers/target/
Describes the driver and its interface to make it possible for user
programs to back a LIO-exported LUN.
Signed-off-by: Andy Grover
---
Documentation/target/tcmu-design.txt | 210 +++
1 file changed, 210 insertions(+)
create mode 100644 Documentation/target/tcmu
is the actual code, along with
implementation rationale.
Thanks -- Andy
[1] http://thread.gmane.org/gmane.linux.scsi.target.devel/5044
Andy Grover (2):
target: Add documentation on the target userspace pass-through driver
target: Add a user-passthrough backstore
Documentation/target/tcmu
On 01/09/2014 10:21 PM, Nicholas A. Bellinger wrote:
What about FORMAT_UNIT emulation?
Would certainly be useful to have..
The backstore protection configuration is done at the target side via
configfs/targetcli, if you publish DIF support in
INQUERY_EVPD/READ_CAPACITY you need to accept prot
On 07/24/2013 06:19 PM, Nicholas A. Bellinger wrote:
Because -fb has had close to zero peer review, and you've not solicited
much input (none from us) before making significant changes to
rtslib/targetcli over the past 1 1/2 years.
For your own private tree this wouldn't matter. However, for a
On 07/24/2013 01:54 PM, Nicholas A. Bellinger wrote:
Yes, which is why I've been accepting his kernel patches the entire time
that user-space has been forked into -fb. Now that the user-space code
has been relicensed as promised, there is no longer any reason for a
separate -fb fork to exist.
T
Hi Nick,
I just wanted to let you know that I finally received permission from
all contributors, and have matched RisingTide's relicensing of targetcli
and its dependencies to Apache 2.0, by relicensing the additional
contributions in the targetcli-fb branch under the same license.
I'm not q
On 01/17/2013 12:56 PM, Nicholas A. Bellinger wrote:
> On Thu, 2013-01-17 at 02:19 +0100, Andreas Steinmetz wrote:
>> This is not a technical point of view. This is a more or less political
>> and user point of view. And for any replies, I'm not subscribed (haven't
>> been now for years).
>>
>> As
Hi all,
First, I do not, and did not, have access to the proprietary OS, which
has been referred to. Otherwise, I would have checked it.
Second, I appreciate that my questions and tentative inferences may not
have been perfect, given that I did not have the complete facts, but I
did try to obtain
On 11/08/2012 06:08 PM, Nicholas A. Bellinger wrote:
> Support for certified VAAI is part of our commercial target core. The
> target core constitutes a stand-alone kernel subsystem of which we are
> the sole copyright owners. In addition, our target contains a number of
> backend drivers, of which
On 11/09/2012 03:03 AM, Alan Cox wrote:
> I fail to understand the maintainer question however. If you were trying
> to block people adding target features that competed that would be a
> different thing.
You think it's ok for us to have an unrepentant GPL violator as a
subsystem maintainer??
If
On 11/08/2012 12:05 PM, Nicholas A. Bellinger wrote:
> Accusing us of violating GPL is a serious legal claim.
>
> In fact, we are not violating GPL. In short, this is because we wrote
> the code you are referring to (the SCSI target core in our commercial
> RTS OS product), we have exclusive co
On 11/07/2012 05:57 PM, Chris Friesen wrote:
> On 11/07/2012 07:02 PM, Jon Mason wrote:
>> I'm not a lawyer, nor do I play one on TV, but if
>> I understand the GPL correctly, RTS only needs to provide the relevant
>> source to their customers upon request.
>
> Not quite.
>
> Assuming the GPL app
On 11/07/2012 05:02 PM, Jon Mason wrote:
> On Wed, Nov 7, 2012 at 9:50 AM, Andy Grover wrote:
>> Your company appears to be shipping kernel features in RTS OS that are
>> not made available under the GPL, specifically support for the
>> EXTENDED_COPY and COMPARE_AND_WRITE SC
Nick,
Your company appears to be shipping kernel features in RTS OS that are
not made available under the GPL, specifically support for the
EXTENDED_COPY and COMPARE_AND_WRITE SCSI commands, in order to claim
full Vmware vSphere 5 VAAI support.
http://www.risingtidesystems.com/storage.html
http:/
Alan Cox wrote:
> Mind you some laptops think S2RAM is just a transition state on the way
> to disk, leave them in ACPI S2RAM and the firmware will magically turn it
> into a save to disk and back to ram if the battery runs low or you leave
> it idle too long.
The OS does this (or at least it's s
66 matches
Mail list logo
