Re: [PATCH 1/2] soc: qcom: mdt_loader: Support loading non-split images

2019-07-01 Thread Andy Gross
ling > back to the split-out segments. > > Signed-off-by: Bjorn Andersson This looks fine to me. Acked-by: Andy Gross

Re: [RESEND v4 1/4] soc: qcom: geni: Add support for ACPI

2019-06-18 Thread Andy Gross
On Mon, Jun 17, 2019 at 01:51:02PM +0100, Lee Jones wrote: > When booting with ACPI as the active set of configuration tables, > all; clocks, regulators, pin functions ect are expected to be at > their ideal values/levels/rates, thus the associated frameworks > are unavailable. Ensure calls to the

Re: [PATCH] dmaengine: qcom-bam: fix circular buffer handling

2019-06-14 Thread Andy Gross
ver SlimBus on DB845c which uses DMA very heavily for > read/writes. > > Signed-off-by: Srinivas Kandagatla Reviewed-by: Andy Gross

Re: [PATCH] Remove myself as qcom maintainer

2019-06-12 Thread Andy Gross
On Wed, Jun 12, 2019 at 11:12 AM David Brown wrote: > > I no longer regularly work on this platform, and only have a few > increasingly outdated boards. Andy has primarily been doing the > maintenance. > > Signed-off-by: David Brown > --- > Resending this, hopefully with text=flowed not set in t

[PATCH] MAINTAINERS: Change QCOM repo location

2019-06-07 Thread Andy Gross
This patch updates the Qualcomm SoC repo to a new location. Signed-off-by: Andy Gross --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 5cfbea4..de1e935 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2079,7 +2079,7 @@ F

Re: linux-next: manual merge of the phy-next tree with the qcom tree

2019-04-23 Thread Andy Gross
On Tue, Apr 23, 2019 at 11:13:59AM +0200, Marc Gonzalez wrote: > > I've included "dt-bindings: phy-qcom-qmp: Tweak qcom,msm8998-qmp-ufs-phy" in > > linux-phy tree now. > > Thanks Kishon, > > Great news. That's one less patch to keep track of. Thanks Kishon! Andy

Re: [PATCH v2 00/13] qcom: dts: thermal cleanups

2019-04-23 Thread Andy Gross
On Tue, Apr 23, 2019 at 06:26:40PM +0530, Amit Kucheria wrote: > On Tue, Apr 23, 2019 at 3:01 PM Marc Gonzalez wrote: > > > > On 02/04/2019 20:46, Amit Kucheria wrote: > > > > > On Tue, Apr 2, 2019 at 8:58 PM Marc Gonzalez wrote: > > >> > > >> On 29/03/2019 11:12, Amit Kucheria wrote: > > >> > > >

Re: linux-next: manual merge of the phy-next tree with the qcom tree

2019-04-19 Thread Andy Gross
On Thu, Apr 18, 2019 at 09:35:44AM +0200, Marc Gonzalez wrote: > > It is not clear to me what I could/should have done differently to avoid > the conflict? I dropped the patch for now. We can deal with this later as it is trivial. The best way probably would have been for Kishon to take this pat

[PATCH] MAINTAINERS: Update email for Qualcomm SoC maintainer

2019-04-09 Thread Andy Gross
This patch changes the email for Andy Gross to agr...@kernel.org. Signed-off-by: Andy Gross --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index e17ebf7..cf39fb06 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1984,7 +1984,7 @@ W

Re: [PATCH] ARM: qcom_defconfig: add options for LG Nexus 5 phone

2019-03-06 Thread Andy Gross
On Sun, Feb 10, 2019 at 07:16:57AM -0500, Brian Masney wrote: > Add wcn36xx wireless, msm vibrator, pm8941 power key, bq24190 charger, > spmi-iadc, spmi-vadc, mpu6515 gyroscope / accelerometer, and tsl2772 > proximity / light drivers as modules to support the LG Nexus 5 > (hammerhead) phone. > > C

Re: [PATCH] arm64: dts: msm8996: fix blsp2_uart1 4-pin pinconfig

2019-02-14 Thread Andy Gross
On Wed, Feb 13, 2019 at 10:05:44AM +0100, Johan Hovold wrote: > That's funny, submitted six days before mine for a 2+ year old issue. I can't tell you how many times I've seen this happen (to myself and others). Andy

Re: [PATCH] arm64: dts: msm8996: fix blsp2_uart1 4-pin pinconfig

2019-02-12 Thread Andy Gross
e the fixes line. commit ff10032fb309d0baa0b79e28009bf154de08d341 Author: Jakob Wuhrer Date: Fri Dec 14 18:01:30 2018 +0100 arm64: dts: qcom: Correct "gpiio" typo in msm8996-pins gpiio5 is missspelt in msm8996-pins.dtsi, fix that. Signed-off-by: Jakob Wuhrer Signed-off-by: Bjorn Andersson Signed-off-by: Andy Gross Regards, Andy

Re: linux-next: manual merge of the char-misc tree with the qcom tree

2019-01-29 Thread Andy Gross
On Tue, 29 Jan 2019 at 05:46, Georgi Djakov wrote: > > Hi Stephen, > > On 1/29/19 05:08, Stephen Rothwell wrote: > > Hi all, > > > > Today's linux-next merge of the char-misc tree got a conflict in: > > > > arch/arm64/boot/dts/qcom/sdm845.dtsi > > > > between commits: > > > > 05556681948b ("ar

Re: [PATCH v3 1/1] MAINTAINERS: update list of qcom drivers

2019-01-22 Thread Andy Gross
On Mon, Jan 21, 2019 at 01:58:41PM +0530, Amit Kucheria wrote: > On Tue, Jan 15, 2019 at 1:16 AM Amit Kucheria > wrote: > > > > Several drivers didn't have a specific maintainer (other than the > > subsystem maintainer). Add some generic regex patterns to capture most > > qcom drivers in the list

Re: [PATCH v3 2/3] usb: dwc3: qcom: Add support for MSM8998

2019-01-22 Thread Andy Gross
dwc3_qcom_runtime_resume(struct > device *dev) > static const struct of_device_id dwc3_qcom_of_match[] = { > { .compatible = "qcom,dwc3" }, > { .compatible = "qcom,msm8996-dwc3" }, > + { .compatible = "qcom,msm8998-dwc3" }, > { .compatible = "qcom,sdm845-dwc3" }, > { } Reviewed-by: Andy Gross

Re: [PATCH v6 00/15] qcom: spmi: add support for hierarchical IRQ chip

2019-01-22 Thread Andy Gross
On Tue, Jan 22, 2019 at 04:31:20PM +0100, Linus Walleij wrote: > On Sat, Jan 19, 2019 at 9:43 PM Brian Masney wrote: > > > This patch series adds hierarchical IRQ chip support to spmi-gpio so > > that device tree consumers can request an IRQ directly from the GPIO > > block rather than having to

Re: [PATCH 1/2] dt-bindings: Add Qualcomm USB Super-Speed PHY bindings

2019-01-07 Thread Andy Gross
On Mon, 7 Jan 2019 at 14:26, Jack Pham wrote: > > Hi Jorge, > > Sorry for the late reply as I was out during the holiday break. > > On Fri, Dec 28, 2018 at 01:38:59PM +0100, Jorge Ramirez wrote: > > On 12/20/18 18:37, Jack Pham wrote: > > >Hi Rob, Jorge, > > > > > >On Thu, Dec 20, 2018 at 11:05:31

Re: [PATCH v1] phy: qcom-ufs: Use iopoll.h readl_poll_timeout macro

2018-12-28 Thread Andy Gross
On Fri, Dec 21, 2018 at 11:13:18AM +0100, Marc Gonzalez wrote: > The private copy of readl_poll_timeout is no longer needed. > Use the implementation in iopoll.h instead. > > Signed-off-by: Marc Gonzalez Reviewed-by: Andy Gross

Re: [GIT PULL] Qualcomm Driver updates for 4.21 - Part 2

2018-12-11 Thread Andy Gross
On Mon, Dec 10, 2018 at 11:36:48PM +0200, Stanimir Varbanov wrote: > > > On 10.12.18 г. 21:05 ч., Andy Gross wrote: > >On Mon, Dec 10, 2018 at 02:20:47PM +0200, Stanimir Varbanov wrote: > >>Hi Andy, > >> > >>On 12/8/18 7:13 AM, Andy Gross wrot

Re: [GIT PULL] Qualcomm Driver updates for 4.21 - Part 2

2018-12-10 Thread Andy Gross
On Mon, Dec 10, 2018 at 02:20:47PM +0200, Stanimir Varbanov wrote: > Hi Andy, > > On 12/8/18 7:13 AM, Andy Gross wrote: > > The following changes since commit b601f73130a375c912d9f2ec93c5f3cea5d6a3da: > > > > drm: msm: Check cmd_db_read_aux_data() for failure (201

[GIT PULL] Qualcomm ARM64 DT updates for 4.21 - Part 2

2018-12-07 Thread Andy Gross
driver on MSM8996 * Fix issue with xo clk name on MSM8998 * Add cooling maps on MSM8916 * Add UART nodes on SDM845 * Add camera subsystem support on MSM8996 and MSM8916 Andy Gross (1): arm64: dts: qcom: msm8998: Fixup clock to

[GIT PULL] Qualcomm Driver updates for 4.21 - Part 2

2018-12-07 Thread Andy Gross
The following changes since commit b601f73130a375c912d9f2ec93c5f3cea5d6a3da: drm: msm: Check cmd_db_read_aux_data() for failure (2018-11-29 17:41:53 -0600) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git tags/qcom-drivers-for-4.21-2 fo

Re: [PATCH] firmware: qcom: scm: fix compilation error when disabled

2018-12-05 Thread Andy Gross
On Wed, Dec 05, 2018 at 09:37:21AM -0800, Bjorn Andersson wrote: > + linux-arm-msm > > On Wed 21 Nov 18:32 PST 2018, Jonathan Marek wrote: > > > This fixes the case when CONFIG_QCOM_SCM is not enabled, and linux/errno.h > > has not been included previously. > > > > Signed-off-by: Jonathan Marek

Re: [PATCH v2] arm64: dts: qcom: sdm845: Add UART nodes

2018-12-05 Thread Andy Gross
On Tue, Dec 04, 2018 at 12:37:18PM -0800, Matthias Kaehlcke wrote: > Hi Andy, > > can this be landed or are any more changes needed? > > Thanks I'll see about adding it to the second pull request. Thank, Andy

Re: [PATCH v2 22/34] dt-bindings: arm: Convert QCom board/soc bindings to json-schema

2018-12-05 Thread Andy Gross
On Mon, Dec 03, 2018 at 03:32:11PM -0600, Rob Herring wrote: > Convert QCom SoC bindings to DT schema format using json-schema. > > Cc: Andy Gross > Cc: David Brown > Cc: Mark Rutland > Cc: devicet...@vger.kernel.org > Signed-off-by: Rob Herring Acked-by: Andy Gross

Re: [PATCH] drm: msm: Check cmd_db_read_aux_data() for failure

2018-11-29 Thread Andy Gross
On Fri, Nov 30, 2018 at 01:12:01PM +1100, Stephen Rothwell wrote: > Hi Andy, > > On Thu, 29 Nov 2018 16:42:34 -0600 Andy Gross wrote: > > > > On Thu, Nov 29, 2018 at 04:36:00PM -0600, Andy Gross wrote: > > > On Thu, Nov 29, 2018 at 08:38:26AM -0800, Stephen Boyd wro

[PATCH] MAINTAINERS: Remove unused Qualcomm SoC mailing list

2018-11-29 Thread Andy Gross
This patch removes the linux-soc mailing list from the Qualcomm SoC entry. We use the linux-msm and there is no need to have the second one and this clears the list for use by others. Signed-off-by: Andy Gross --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b

Re: [PATCH] drm: msm: Check cmd_db_read_aux_data() for failure

2018-11-29 Thread Andy Gross
On Thu, Nov 29, 2018 at 04:36:00PM -0600, Andy Gross wrote: > On Thu, Nov 29, 2018 at 08:38:26AM -0800, Stephen Boyd wrote: > > We need to check the call to cmd_db_read_aux_data() for the error case, > > so that we don't continue and use potentially uninitialized values for

Re: [PATCH] drm: msm: Check cmd_db_read_aux_data() for failure

2018-11-29 Thread Andy Gross
On Thu, Nov 29, 2018 at 08:38:26AM -0800, Stephen Boyd wrote: > We need to check the call to cmd_db_read_aux_data() for the error case, > so that we don't continue and use potentially uninitialized values for > 'pri_count' and 'sec_count'. Otherwise, we get the following compiler > warnings: > >

Re: [PATCH] ARM: dts: qcom: msm8974-hammerhead: correct gpios property on magnetometer

2018-11-28 Thread Andy Gross
On Wed, Nov 28, 2018 at 04:53:35AM -0500, Brian Masney wrote: > This patch correctly sets the gpios property for the ak8963 > magnetometer's DRDY pin so that interrupts work properly. > > Signed-off-by: Brian Masney > --- Queued. Thanks for the patch. Andy

Re: [PATCH v6 0/2] arm64: dts: add prng-ee nodes

2018-11-15 Thread Andy Gross
On Thu, Nov 15, 2018 at 09:15:18AM +0530, Vinod Koul wrote: > On 01-10-18, 11:51, Vinod Koul wrote: > > This adds prng-ee nodes for msm8996 and sdm845 > > Ping Andy, would appreciate if you can pick these up. Done. I did have to massage the location in dts for both of these patches to keep the a

Re: [PATCH 4/4] arm64: dts: qcom: msm8998-mtp: Add external SD

2018-11-15 Thread Andy Gross
On Thu, Nov 15, 2018 at 10:18:11AM -0700, Jeffrey Hugo wrote: > The externally accessible SD card slot on the MTP is driven by SDCC2. > Wire it up for use. > > Signed-off-by: Jeffrey Hugo > --- > arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 13 + > arch/arm64/boot/dts/qcom/msm8998.dts

Re: [PATCH v6 0/2] arm64: dts: qcom: pm8998: Add die temperature channel node to the ADC

2018-11-14 Thread Andy Gross
On Mon, Nov 12, 2018 at 02:11:24PM -0800, Matthias Kaehlcke wrote: > This series adds a channel for the die temperature to the QCOM SPMI > PMIC5 ADC. It also fixes an example in the DT documentation. > > Matthias Kaehlcke (2): > dt-bindings: iio: vadc: Add unit address to ADC channel node in >

Re: [PATCH] soc: qcom: Drop help text for QCOM_QMI_HELPERS

2018-11-14 Thread Andy Gross
On Mon, Oct 01, 2018 at 11:55:54AM +0200, Niklas Cassel wrote: > The help text is visible in menuconfig, however QCOM_QMI_HELPERS is a > hidden kconfig, so it is not selectable in menuconfig. > > Remove the help text so that it is more clear that this is intentionally > a hidden kconfig. > > Sign

Re: [PATCH] soc: qcom: Add irq clear handling during SE init

2018-11-14 Thread Andy Gross
On Wed, Oct 03, 2018 at 05:53:50PM +0530, Alok Chauhan wrote: > when the kernel inits a SE, its quite possible we have pending interrupts > from bootloaders which did not handle/clear them. So do this in kernel at > the SE init, to avoid some of it causing bad behavior, while at it also > club all

Re: [PATCH] arm64: dts: qcom: sdm845-mtp: Mark protected gcc clocks

2018-11-09 Thread Andy Gross
nding clocks protected for the MTP, in order to allow it to boot. > > Cc: Stephen Boyd > Signed-off-by: Bjorn Andersson This looks fine to me. Acked-by: Andy Gross

Re: [GIT PULL] Qualcomm ARM64 DT updates for 4.20

2018-10-25 Thread Andy Gross
On Thu, Oct 25, 2018 at 10:55:32AM +0530, Amit Kucheria wrote: > Andy, > > While you acked the tsens thermal DT patches[1] so they could go > through the thermal tree[2] to avoid a dependency, Eduardo would > prefer the DT changes for tsens to go through the arch tree. > > To avoid a scenario

Re: [GIT PULL] Qualcomm ARM64 DT updates for 4.20

2018-10-05 Thread Andy Gross
On Tue, Oct 02, 2018 at 11:30:29AM +0200, Arnd Bergmann wrote: > On Sun, Sep 30, 2018 at 8:38 PM Andy Gross wrote: > > > > The following changes since commit 5b394b2ddf0347bef56e50c69a58773c94343ff3: > > > > Linux 4.19-rc1 (2018-08-26 14:11:59 -0700) > > > &

Re: [GIT PULL] Qualcomm Device Tree updates for 4.20

2018-10-05 Thread Andy Gross
On Tue, Oct 02, 2018 at 11:36:11AM +0200, Arnd Bergmann wrote: > On Sun, Sep 30, 2018 at 8:38 PM Andy Gross wrote: > > > > The following changes since commit 5b394b2ddf0347bef56e50c69a58773c94343ff3: > > > > Linux 4.19-rc1 (2018-08-26 14:11:59 -0700) > > > &

[GIT PULL] Qualcomm Driver updates for 4.20

2018-09-30 Thread Andy Gross
ion header size soc: qcom: smem: verify partition offset_free_uncached soc: qcom: smem: small change in global entry loop soc: qcom: smem: verify partition host ids match soc: qcom: smem: a few last cleanups Andy Gross (2): Merge tag 'qcom-geni-immutable-for-mark-brow

[GIT PULL] Qualcomm Device Tree updates for 4.20

2018-09-30 Thread Andy Gross
The following changes since commit 5b394b2ddf0347bef56e50c69a58773c94343ff3: Linux 4.19-rc1 (2018-08-26 14:11:59 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git tags/qcom-dts-for-4.20 for you to fetch changes up to ca02f96b95ca1

[GIT PULL] Qualcomm ARM64 Defconfig updates for 4.20

2018-09-30 Thread Andy Gross
The following changes since commit 5b394b2ddf0347bef56e50c69a58773c94343ff3: Linux 4.19-rc1 (2018-08-26 14:11:59 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git tags/qcom-arm64-defconfig-for-4.20 for you to fetch changes up to 1

[GIT PULL] Qualcomm ARM64 DT updates for 4.20

2018-09-30 Thread Andy Gross
mm PM8916 and PM8994 ---- Andy Gross (2): Revert "dt-bindings: iio: vadc: Fix documentation of 'reg'" Revert "dt-bindings: thermal: qcom-spmi-temp-alarm: Fix documentation of 'reg'" Bjorn Andersson (10):

[GIT PULL] Qualcomm Defconfig updates for 4.20

2018-09-30 Thread Andy Gross
The following changes since commit 5b394b2ddf0347bef56e50c69a58773c94343ff3: Linux 4.19-rc1 (2018-08-26 14:11:59 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git tags/qcom-defconfig-for-4.20 for you to fetch changes up to 54c2678

Re: [PATCH v2 05/11] arm64: dts: msm8916: Update coresight bindings for hardware ports

2018-09-30 Thread Andy Gross
On Thu, Sep 27, 2018 at 09:18:06AM +0100, Suzuki K Poulose wrote: > Hi Andy > > On 09/12/2018 02:53 PM, Suzuki K Poulose wrote: > >Switch to updated coresight bindings for hw ports > > > >Cc: Andy Gross > >Cc: David Brown > >Cc: Ivan T. Ivanov > >Cc

Re: [PATCH ARM-next] ARM: dts: qcom-msm8974: change invalid flag IRQ NONE to valid value

2018-09-26 Thread Andy Gross
On Tue, Sep 25, 2018 at 06:46:51AM -0400, Brian Masney wrote: > The following commits used IRQ_TYPE_NONE since that matched what was > already in the file and I do not have access to the datasheets for > these devices. After these patches were submitted, commit dcf145011400 > ("ARM: dts: qcom-msm89

Re: [PATCH v3 00/16] Another round of tsens cleanups

2018-09-20 Thread Andy Gross
On Wed, Sep 12, 2018 at 03:22:45PM +0530, Amit Kucheria wrote: > This is another series of tsens cleanups before we add interrupt support. > This applies on top of 4.19-rc2. > > Patches [1-6] can directly be applied by Eduardo. > Patches [9-16] can directly be applied by Andy. Eduardo, I ACKed

Re: [PATCH v3 16/16] arm64: dts: sdm845: enable tsens thermal zones

2018-09-20 Thread Andy Gross
+++ > 1 file changed, 170 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi > b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 0c9a2aa6a1b5..eb801922f6bb 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi Acked-by: Andy Gross

Re: [PATCH v3 15/16] arm64: dts: msm8916: Add camera thermal zone

2018-09-20 Thread Andy Gross
> > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi > b/arch/arm64/boot/dts/qcom/msm8916.dtsi > index 62f079ae9ba3..3dc8b8aa76c7 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi Acked-by: Andy Gross

Re: [PATCH v3 14/16] arm64: dts: msm8916: Add gpu thermal zone

2018-09-20 Thread Andy Gross
> > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi > b/arch/arm64/boot/dts/qcom/msm8916.dtsi > index be27d8dc9e6b..62f079ae9ba3 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi Acked-by: Andy Gross

Re: [PATCH v3 12/16] arm64: dts: msm8916: thermal: Add "qcom,sensors" property

2018-09-20 Thread Andy Gross
h/arm64/boot/dts/qcom/msm8916.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi > b/arch/arm64/boot/dts/qcom/msm8916.dtsi > index 6a277fce..be27d8dc9e6b 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi Acked-by: Andy Gross

Re: [PATCH v3 11/16] arm: dts: msm8974: thermal: Add "qcom,sensors" property

2018-09-20 Thread Andy Gross
y: Bjorn Andersson > --- > arch/arm/boot/dts/qcom-msm8974.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi > b/arch/arm/boot/dts/qcom-msm8974.dtsi > index 56dbbf788d15..3c4b81c29798 100644 > --- a/arch/arm/boot/dts/qcom-msm8974.dtsi Acked-by: Andy Gross

Re: [PATCH v3 10/16] arm64: dts: msm8916: thermal: split address space into two

2018-09-20 Thread Andy Gross
common.c/init_common() currently only registers one address > space, the order is important (TM before SROT). This is OK since the > code doesn't really use the SROT functionality yet. > > Signed-off-by: Amit Kucheria > Reviewed-by: Matthias Kaehlcke > --- Acked-by: Andy Gross

Re: [PATCH v3 09/16] arm: dts: msm8974: thermal: split address space into two

2018-09-20 Thread Andy Gross
common.c/init_common() currently only registers one address > space, the order is important (TM before SROT). This is OK since the > code doesn't really use the SROT functionality yet. > > Signed-off-by: Amit Kucheria > Reviewed-by: Matthias Kaehlcke > --- Acked-by: Andy Gross

Re: [PATCH] ASoC: qcom: Fix a uninitialized warning.

2018-09-18 Thread Andy Gross
On Tue, Sep 18, 2018 at 01:06:48PM +0800, zhong jiang wrote: > Fix the following compile warning: > > drivers/soc/qcom/cmd-db.c:194:38: warning: ‘ent.addr’ may be used > uninitialized in this function [-Wmaybe-uninitialized] > return ret < 0 ? 0 : le32_to_cpu(ent.addr); > > drivers/soc/qcom/cm

Re: [PATCH v6 0/9] soc: qcom: Allow COMPILE_TEST of qcom SoC Kconfigs

2018-09-13 Thread Andy Gross
On Wed, Aug 29, 2018 at 09:57:14AM +0200, Niklas Cassel wrote: > Since commit cab673583d96 ("soc: Unconditionally include qcom Makefile"), > we unconditionally include the soc/qcom/Makefile. > > This opens up the possibility to compile test the code even when > building for other architectures. >

Re: [PATCH 0/2] qcom: remove memcpy()ing from cmd-db driver

2018-09-13 Thread Andy Gross
On Tue, Jul 17, 2018 at 01:29:45PM -0700, Stephen Boyd wrote: > Some changes to the cmd-db code to not do any more copying > of memory. Instead, we'll just hand out pointers to things > inside cmd-db. Merging the second patch will cause problems > for any in-flight users of the cmd-db APIs that are

Re: [PATCH v9 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

2018-07-26 Thread Andy Gross
+ olof On Tue, Jul 24, 2018 at 05:59:42PM +0100, Mark Brown wrote: > On Tue, Jul 24, 2018 at 08:43:46AM -0700, Doug Anderson wrote: > > On Tue, Jul 24, 2018 at 8:25 AM, Mark Brown wrote: > > > > There was also some other thing called command DB as well which was a > > > separate series. Ideally

Re: [PATCH 14/15] arm: dts: qcom: Add missing OPP properties for CPUs

2018-07-21 Thread Andy Gross
On Wed, Jul 18, 2018 at 03:52:26PM +0530, Amit Kucheria wrote: > On Fri, May 25, 2018 at 4:02 PM, Viresh Kumar wrote: > > The OPP properties, like "operating-points", should either be present > > for all the CPUs of a cluster or none. If these are present only for a > > subset of CPUs of a cluster

Re: [PATCH] arm64: dts: msm8916: drop legacy suffix for clocks used by MSM DRM driver

2018-07-21 Thread Andy Gross
On Thu, Jul 19, 2018 at 12:53:04PM +0200, Nicolas Dechesne wrote: > hi Niklas, > > On Wed, Jul 18, 2018 at 4:53 PM Niklas Cassel > wrote: > > > > Drop legacy suffix for clocks used by MSM DRM driver. > > I had the same patch locally, which I forgot to send.. so thanks for > sending it ;) > > y

Re: [PATCH 1/4] remoteproc: qcom: mdt_loader: Make the firmware authentication optional

2018-06-18 Thread Andy Gross
used > by self-authenticating remoteproc as well. > > Signed-off-by: Sricharan R > Signed-off-by: Bjorn Andersson looks fine to me Acked-by: Andy Gross

Re: [PATCH] arm64: dts: apq8096-db820c: disable uart0 by default

2018-06-13 Thread Andy Gross
On Tue, Jun 12, 2018 at 03:48:06PM +0100, Srinivas Kandagatla wrote: > Access to UART0 is disabled by bootloaders. By leaving it enabled by > default would reboot the board. > Disable this for now, this would alteast give a board which boots. > > Signed-off-by: Srinivas Kandagatla Thanks for thi

Re: [GIT PULL] Qualcomm Driver updates for 4.18

2018-05-24 Thread Andy Gross
18 at 11:37:40PM -0500, Andy Gross wrote: > The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338: > > Linux 4.17-rc1 (2018-04-15 18:24:20 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/agross/linu

[GIT PULL] Qualcomm Device Tree updates for 4.18

2018-05-22 Thread Andy Gross
The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338: Linux 4.17-rc1 (2018-04-15 18:24:20 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git tags/qcom-dts-for-4.18 for you to fetch changes up to 90ce62659994b

[GIT PULL] Qualcomm Driver updates for 4.18

2018-05-22 Thread Andy Gross
The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338: Linux 4.17-rc1 (2018-04-15 18:24:20 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git tags/qcom-drivers-for-4.18 for you to fetch changes up to f378dab2c

[GIT PULL] Qualcomm ARM64 DT updates for 4.18

2018-05-22 Thread Andy Gross
The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338: Linux 4.17-rc1 (2018-04-15 18:24:20 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git tags/qcom-arm64-for-4.18 for you to fetch changes up to 57fc67ef0d3

Re: linux-next: build failure after merge of the qcom tree

2018-04-26 Thread Andy Gross
On Thu, Apr 26, 2018 at 04:42:17PM +, Evan Green wrote: > > I suspect that just Linus' tree merged with the qcom tree would have > > been enough to cause the failure. Sorry for missing this in my testing. > > > I've verified that the patch listed above fixes the issue for me. Andy, if > it

Re: [PATCH v6 02/24] soc: qcom: Add APR bus driver

2018-04-26 Thread Andy Gross
On Thu, Apr 26, 2018 at 12:39:11PM +0100, Mark Brown wrote: > On Thu, Apr 26, 2018 at 10:45:44AM +0100, srinivas.kandaga...@linaro.org > wrote: > > From: Srinivas Kandagatla > > > > This patch adds support toi APR bus (Asynchronous Packet Router) driver. > > ARP driver is made as a bus driver so

Re: [PATCH v6 02/24] soc: qcom: Add APR bus driver

2018-04-26 Thread Andy Gross
ly depending on the state of the services on the dsp. > APR is used for communication between application processor and QDSP to > use services on QDSP like Audio and others. > > Signed-off-by: Srinivas Kandagatla > Reviewed-and-tested-by: Rohit kumar > --- Acked-by: Andy Gross

Re: [PATCH RESEND] firmware: qcom: scm: Fix crash in qcom_scm_call_atomic1()

2018-04-26 Thread Andy Gross
On Thu, Apr 26, 2018 at 09:25:36PM +0200, Niklas Cassel wrote: > On Thu, Apr 26, 2018 at 11:01:30AM -0700, Bjorn Andersson wrote: > > On Thu 26 Apr 04:55 PDT 2018, Niklas Cassel wrote: > > > > > qcom_scm_call_atomic1() can crash with a NULL pointer dereference at > > > qcom_scm_call_atomic1+0x30/0

Re: [PATCH 0/6] soc: qcom: smem: bug fixes

2018-04-24 Thread Andy Gross
On Fri, Apr 20, 2018 at 07:11:41AM -0500, Alex Elder wrote: > On 04/10/2018 05:25 PM, Alex Elder wrote: > > This series contains mostly bug fixes to the Qualcomm shared memory > > ("smem") code. Although the bugs are real, they have most likely > > never been observed. > > > >

Re: [PATCH v3 04/13] ARM: dts: ipq4019: Update ipq4019-dk01.1 board data

2018-03-29 Thread Andy Gross
ou have tested these specifically on this board, I'd appreciate not getting false information about what is or is not working. > > Please add the missing basic board support before hacking random stuff > into the DTS. Feel free to send your own contributions where you are adding the things that are important to you. Regards, Andy Gross

Re: [PATCH v2] ARM: dts: msm8974: castor: Fix typo and add startup delay in touchscreen node

2018-03-14 Thread Andy Gross
On Tue, Mar 13, 2018 at 04:46:38PM +, Craig Tatlor wrote: > The compatible string was mistakenly pulled from the downstream tree and the > startup delay property is needed to prevent io errors on initial page select. > > Signed-off-by: Craig Tatlor Thanks for the patch. I'll add Bjorn's rev

Re: [PATCH] soc: qcom: qmi: add CONFIG_NET dependency

2018-03-08 Thread Andy Gross
n > --- > drivers/remoteproc/Kconfig | 1 + > drivers/soc/qcom/Kconfig | 2 +- > samples/Kconfig| 1 + > 3 files changed, 3 insertions(+), 1 deletion(-) Acked-by: Andy Gross

Re: [PATCH 10/12] i2c: qup: send NACK for last read sub transfers

2018-02-27 Thread Andy Gross
ut stop with QUP_TAG_V2_DATARD_NACK so added the > same. > > Signed-off-by: Abhishek Sahu Reviewed-by: Andy Gross

Re: [PATCH 09/12] i2c: qup: fix buffer overflow for multiple msg of maximum xfer len

2018-02-27 Thread Andy Gross
sing this, then schedule the BAM transfer and subsequent >transfer will again start from zero. > > Signed-off-by: Abhishek Sahu I'm ok with this patch. I find the idea of a > 64k size message to be something that usually wouldn't be encountered, but... with some eeproms and maybe TPMs perhaps this could happen? Reviewed-by: Andy Gross

Re: [PATCH 08/12] i2c: qup: change completion timeout according to transfer length

2018-02-27 Thread Andy Gross
; >>+/* Min timeout for i2c transfers */ > >>+#define TOUT_MIN 2 > >> > > > > may be you can mention, why is this 2 ? > > > > This 2 seconds is timeout which I am adding on the top of maximum > xfer time calculated from bus speed to compensate the interrupt > latency and other factors. It will make xfer timeout minimum as > 2 seconds. > > I will update the comment to explain it in more detail. Once you do that add: Reviewed-by: Andy Gross

Re: [PATCH 07/12] i2c: qup: use the complete transfer length to choose DMA mode

2018-02-27 Thread Andy Gross
gt; --- I agree with Sricharan's nit. Reviewed-by: Andy Gross

Re: [PATCH 06/12] i2c: qup: proper error handling for i2c error in BAM mode

2018-02-27 Thread Andy Gross
On Sat, Feb 03, 2018 at 01:28:11PM +0530, Abhishek Sahu wrote: > @@ -841,20 +856,12 @@ static int qup_i2c_bam_do_xfer(struct qup_i2c_dev *qup, > struct i2c_msg *msg, > goto desc_err; > } > > - if (rx_buf) > - writel(QUP_BAM_I

Re: [PATCH 05/12] i2c: qup: fix the transfer length for BAM rx EOT FLUSH tags

2018-02-27 Thread Andy Gross
f 2 separate tags. > > Signed-off-by: Abhishek Sahu Reviewed-by: Andy Gross

Re: [PATCH 04/12] i2c: qup: schedule EOT and FLUSH tags at the end of transfer

2018-02-27 Thread Andy Gross
On Sat, Feb 03, 2018 at 01:28:09PM +0530, Abhishek Sahu wrote: > A single BAM transfer can have multiple read and write messages. > The EOT and FLUSH tags should be scheduled at the end of BAM HW > descriptors. Since the READ and WRITE can be present in any order > so for some of the cases, these t

Re: [PATCH 03/12] i2c: qup: remove redundant variables for BAM SG count

2018-02-27 Thread Andy Gross
On Sat, Feb 03, 2018 at 01:28:08PM +0530, Abhishek Sahu wrote: > The rx_nents and tx_nents are redundant. rx_buf and tx_buf can > be used for total number of SG entries. > > Signed-off-by: Abhishek Sahu > --- Naming conventions aside, Reviewed-by: Andy Gross

Re: [PATCH 02/12] i2c: qup: minor code reorganization for use_dma

2018-02-27 Thread Andy Gross
d assignment. > > Signed-off-by: Abhishek Sahu Reviewed-by: Andy Gross

Re: [PATCH 01/12] i2c: qup: fixed releasing dma without flush operation completion

2018-02-27 Thread Andy Gross
eted without reinit. It will make > flush operation wait_for_completion_timeout completed immediately > and will proceed for freeing the DMA resources where the > descriptors are still in process. > > Signed-off-by: Abhishek Sahu Reviewed-by: Andy Gross

Re: [PATCH 3/4] arm64: dts: qcom: msm8916: Add clock properties to the APCS node

2018-02-27 Thread Andy Gross
On Wed, Feb 07, 2018 at 03:30:47PM +0530, Amit Kucheria wrote: > On Mon, Feb 5, 2018 at 8:16 PM, Georgi Djakov > wrote: > > There are clock controller registers in the APCS block, which purpose > > If you respin this, s/which/whose I can fix this when I apply them. I'll make a note. No need t

Re: [PATCH v3 3/4] soc: qcom: mdt-loader: Return relocation base

2018-01-27 Thread Andy Gross
gt; > Return the adjusted physical base address to the caller. > > Signed-off-by: Bjorn Andersson This looks fine. Acked-by: Andy Gross

Re: [PATCH -next] of: platform: fix OF node refcount leak

2018-01-19 Thread Andy Gross
On 19 January 2018 at 09:37, Sudeep Holla wrote: > Hi Andy, > > On 18/01/18 10:43, Sudeep Holla wrote: >> We need to call of_node_put() for device nodes obtained with >> of_find_node_by_path(). >> >> Fixes: 3aa0582fdb82 ("of: platform: populate /firmware/ node from >> of_platform_default_populate

Re: [PATCH v3] firmware: qcom: scm: Fix incorrect of_node_put calls in scm_init

2018-01-17 Thread Andy Gross
On Tue, Jan 16, 2018 at 08:45:49AM -0800, Bjorn Andersson wrote: > On Fri 15 Dec 05:40 PST 2017, Loys Ollivier wrote: > > > When using other platform architectures, in the init of the qcom_scm > > driver, of_node_put is called on /firmware if no qcom dt is found. > > This results in a kernel error

Re: [PATCH v2 0/3] arm64: defconfig: remove some Qualcomm USB options

2017-12-31 Thread Andy Gross
On Thu, Nov 02, 2017 at 07:47:54AM -0500, Alex Elder wrote: > On 11/02/2017 04:15 AM, Arnd Bergmann wrote: > > On Tue, Oct 31, 2017 at 1:58 PM, Alex Elder wrote: > >> This series deletes three config options related to USB on Qualcomm > >> SoCs from the arm64 "defconfig". The code enabled by the

Re: [PATCH] arm64: dts: Remove leading 0x and 0s from bindings notation

2017-12-19 Thread Andy Gross
and adding a whitespace before the > the opening curly brace: > > https://elinux.org/Device_Tree_Linux#Linux_conventions > > This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x > from bindings notation") > > Reported-by: David Daney > Suggested-by: Rob Herring > Signed-off-by: Mathieu Malaterre Acked-by: Andy Gross

Re: [PATCH v8 1/4] firmware: scm: Add new SCM call API for switching memory ownership

2017-10-30 Thread Andy Gross
nterface for making secure monitor call for > memory ownership switching request. > > Signed-off-by: Avaneesh Kumar Dwivedi Looks fine to me. Acked-by: Andy Gross

Re: [PATCH 0/3] arm64: remove some unused defconfig options

2017-10-25 Thread Andy Gross
On Tue, Oct 24, 2017 at 05:20:20PM -0700, Stephen Boyd wrote: > On 10/20, Alex Elder wrote: > > This series deletes three config options related to USB on Qualcomm > > SoCs from the arm64 "defconfig", along with the code that they > > enable. The code is no longer needed by any Qualcomm hardware.

Re: [PATCH 3/3] arm64: defconfig: remove CONFIG_USB_QCOM_8X16_PHY

2017-10-25 Thread Andy Gross
f-by: Alex Elder > Acked-by: Bjorn Andersson Acked-by: Andy Gross

Re: [PATCH 2/3] arm64: defconfig: remove CONFIG_USB_MSM_OTG

2017-10-25 Thread Andy Gross
lex Elder > Acked-by: Bjorn Andersson Acked-by: Andy Gross

Re: [PATCH 1/3] arm64: defconfig: remove CONFIG_USB_EHCI_MSM

2017-10-25 Thread Andy Gross
: Bjorn Andersson Acked-by: Andy Gross

Re: [RESEND PATCH 1/1] arm64: dts: Add Variscite DART-SD410 Evaluation board dts

2017-08-26 Thread Andy Gross
b_id: usb-id { compatible = "linux,extcon-usb-gpio"; vbus-gpio = <&msmgpio 121 GPIO_ACTIVE_HIGH>; pinctrl-names = "default"; pinctrl-0 = <&usb_id_default>; Looking at the Dart, you are using a USB2514, but it should be similar. Regards, Andy Gross

Re: [PATCH V3] dmaengine: qcom-bam: Process multiple pending descriptors

2017-08-21 Thread Andy Gross
ed-off-by: Sricharan R > Tested-by: Abhishek Sahu Reviewed-by: Andy Gross

Re: [RESEND PATCH 1/1] arm64: dts: Add Variscite DART-SD410 Evaluation board dts

2017-08-18 Thread Andy Gross
+ extcon = <&usb_id>, <&usb_id>; > + dr_mode = "otg"; > + status = "okay"; > + switch-gpio = <&pm8916_gpios 4 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&usb_sw_sel_pm>; Same here, I think some things changed here. Need to update. switch-gpio went away. > + }; > + > + lpass@07708000 { > + status = "okay"; > + }; > + Regards, Andy Gross

Re: [RESEND PATCH 1/1] arm64: dts: Add Variscite DART-SD410 Evaluation board dts

2017-08-14 Thread Andy Gross
5. That's a little late in the cycle for me to pick it up. If I can review this in depth over the next -rc or so I might throw it in a second pull request. Regards, Andy Gross

Re: [PATCH 2/2] soc: qcom: GLINK SSR notifier

2017-08-01 Thread Andy Gross
K participants that a 3rd party > is gone and that the communication state has to be reset; i.e. that read > and write pointers of the GLINK FIFOs are stale. > > Signed-off-by: Bjorn Andersson Looks pretty straightforward. Acked-by: Andy Gross

  1   2   3   4   5   6   7   8   >