Re: [PATCH net-next 2/2] net: Remove switchdev.h inclusion from team/bond/vlan

2019-02-22 Thread Andy Gospodarek
On Fri, Feb 22, 2019 at 12:31:34PM -0800, Florian Fainelli wrote: > This is no longer necessary after eca59f691566 ("net: Remove support for > bridge bypass ndos from stacked devices") > > Suggested-by: Ido Schimmel > Signed-off-by: Florian Fainelli Rev

Re: [PATCH][next] bnxt_en: ensure len is ininitialized to zero

2018-01-12 Thread Andy Gospodarek
On Fri, Jan 12, 2018 at 10:11:17AM -0800, Michael Chan wrote: > On Fri, Jan 12, 2018 at 9:46 AM, Colin King wrote: > > From: Colin Ian King > > > > In the case where cmp_type == CMP_TYPE_RX_L2_TPA_START_CMP the > > exit return path is via label next_rx_no_prod and cpr->rx_bytes > > is being updat

Re: [PATCH 0/1] net: ethtool: add SmartNIC reset support

2017-10-18 Thread Andy Gospodarek
On Wed, Oct 18, 2017 at 12:31:28PM -0700, Scott Branden wrote: > Hi Andrew, > > > On 17-10-18 12:16 PM, Andrew Lunn wrote: > > > Yes, there is also a management processor. > > O.K. > > > > Maybe it would be nice to add some more text to the commit message to > > make this clear. Define what an a

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode

2017-07-20 Thread Andy Gospodarek
. > > Re-enable transmit dyanmic load balancing by initializing tlb_dynamic_lb > for balance-alb similar to balance-tlb. > > Signed-off-by: Kosuke Tatsukawa > Cc: sta...@vger.kernel.org You probably should add: Fixes: 8b426dc54cf4 ("bonding: remove hardcoded value").

Re: [PATCH RFC 2/3] samples/bpf: Add define __EMITTING_BPF__ when building BPF

2017-06-19 Thread Andy Gospodarek
On Thu, Jun 15, 2017 at 03:35:42PM -0700, David Daney wrote: > ... this allows gating of inline assembly code that causes llvm to > fail when emitting BPF. I floated essentially the same patch in Feb without much luck: http://lists.infradead.org/pipermail/linux-arm-kernel/2017-March/492758.html

Re: [PATCH net] bonding: fix randomly populated arp target array

2017-05-19 Thread Andy Gospodarek
pew shows up even when debug > prints are disabled. > > The fix: just zero out arp_target at init time. > > While we're in here, init arp_all_targets_value in the right place. > Looks good. Thanks, Jarod! Acked-by: Andy Gospodarek > Fixes: dc9c4d0fe023 ("bonding:

Re: [PATCH net-next] bonding: add 802.3ad support for 25G speeds

2017-03-14 Thread Andy Gospodarek
On Tue, Mar 14, 2017 at 11:48:32AM -0400, Jarod Wilson wrote: > Cut-n-paste enablement of 802.3ad bonding on 25G NICs, which currently > report 0 as their bandwidth. > > CC: Jay Vosburgh > CC: Veaceslav Falico > CC: Andy Gospodarek > CC: net...@vger.kernel.org > Sig

Re: [PATCH net-next iproute2] iplink: display rx nohandler stats

2016-02-10 Thread Andy Gospodarek
On Wed, Feb 10, 2016 at 08:20:59AM -0500, Jarod Wilson wrote: > On Tue, Feb 09, 2016 at 08:52:38PM -0800, Eric Dumazet wrote: > > On Tue, 2016-02-09 at 17:41 -0800, Stephen Hemminger wrote: > > > On Tue, 9 Feb 2016 18:51:35 -0500 > > > Jarod Wilson wrote: > > > > > > > On Tue, Feb 09, 2016 at 11:

Re: [RFC PATCH net] net/core: don't increment rx_dropped on inactive slaves

2016-01-23 Thread Andy Gospodarek
_dropped. I completely agree. > CC: "David S. Miller" > CC: Eric Dumazet > CC: Jiri Pirko > CC: Daniel Borkmann > CC: Tom Herbert > CC: Jay Vosburgh > CC: Veaceslav Falico > CC: Andy Gospodarek > CC: net...@vger.kernel.org > Signed-off-by: Jarod Wilson

Re: [PATCH] net/bonding: send arp in interval if no active slave

2015-09-01 Thread Andy Gospodarek
> >this impact failover / recovery times? > > > > -J > It depends. > failover times are not impacted, this is handled different. > Only the transition from a down bonding interface (bond and all slaves are > down) to the state up can be increased by up to 2 times a

Re: [PATCH v2] bonding: "primary_reselect" with "failure" is not working properly

2015-07-06 Thread Andy Gospodarek
On Mon, Jul 06, 2015 at 05:34:01PM +0530, GMAIL wrote: > On Friday 03 July 2015 11:46 PM, Jay Vosburgh wrote: > >GMAIL wrote: [...] > > Looks good, added cosmetic changes for more readability, > it might save some instructions :) > > > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/

Re: [-next] fib_dump_info() suspicious RCU usage

2015-06-26 Thread Andy Gospodarek
On Fri, Jun 26, 2015 at 06:35:40PM +0900, Sergey Senozhatsky wrote: > Hello, > > Since 0eeb075fad736 ('net: ipv4 sysctl option to ignore routes when nexthop > link is down') fib_dump_info() and fib_sync_up() are using __in_dev_get_rcu(), > which requires (missing) RCU read side protection. Yep, I

Re: [PATCH] Fix Kernel Panic in bonding driver debugfs file: rlb_hash_table

2015-04-29 Thread Andy Gospodarek
et and net-next > > Signed-off-by: Vishwanath Pai Signed-off-by: Andy Gospodarek > > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c > index 089a402..806892a 100644 > --- a/drivers/net/bonding/bond_main.c > +++ b/drivers/net/bonding/bond_main.c &

Re: [PATCH] Bonding Overriding Configuration logic restored.

2015-03-30 Thread Andy Gospodarek
is_active_slave), that prevents the user from implementing more > complex policies according to the Documentation/networking/bonding.txt. Yes, this does. Good catch. > Signed-off-by: Anton Nayshtut > Signed-off-by: Alexey Bogoslavsky Signed-off-by: Andy Gospodarek > --- > drivers/net

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-19 Thread Andy Gospodarek
On Fri, Dec 19, 2014 at 03:05:27PM +0530, B Viswanath wrote: > On 19 December 2014 at 14:53, Jiri Pirko wrote: > > Fri, Dec 19, 2014 at 10:01:46AM CET, marichi...@gmail.com wrote: > >>On 19 December 2014 at 13:57, Jiri Pirko wrote: > >>> Fri, Dec 19, 2014 at 06:14:57AM CET, marichi...@gmail.com w

Re: [RFC PATCH 1/1] ethtool: adding support for multiple slave port configuration

2014-07-28 Thread Andy Gospodarek
On Sun, Jul 27, 2014 at 03:47:01AM +0100, Ben Hutchings wrote: > On Fri, 2014-07-25 at 17:58 +0530, Mugunthan V N wrote: > > Some Ethernet Swtich controllers like CPSW in AM335x, TI814x, DRA7x and > > AM43xx SoCs, Network Coprocessor in AM5K2E0x, Realtek Switch controllers > > etc has to capability

Re: question tehuti.c

2013-09-24 Thread Andy Gospodarek
On Mon, Sep 23, 2013 at 05:54:00PM +0200, Julia Lawall wrote: > The function bdx_setmulti in the file drivers/net/ethernet/tehuti/tehuti.c > contains: > > u32 rxf_val = > GMAC_RX_FILTER_AM | GMAC_RX_FILTER_AB | GMAC_RX_FILTER_OSEN; > > and then later: > >} else { >

Re: [patch net-next v2 00/15] net: introduce upper device lists and remove dev->master

2012-08-14 Thread Andy Gospodarek
On Tue, Aug 14, 2012 at 05:05:33PM +0200, Jiri Pirko wrote: > Hi all. > > Recent discussion around > "[net-next] bonding: don't allow the master to become its slave" > forced me to think about upper<->lower device connections. > > This patchset adds a possibility to record upper device linkage. >

Re: [BUG] Lockup on boot when trying to bring up r8169 NIC

2007-07-23 Thread Andy Gospodarek
On Thu, Jul 19, 2007 at 04:11:35PM +0200, Thomas Müller wrote: > Hi, > > I already sent this two days ago, but I have the feeling it was > overlooked or filtered because of a large attachment. > > > If I try to boot 2.6.21.6, 2.6.22.1 or 2.6.22-git8 the system completely > hangs when init tries

[PATCH] PCI: disable MSI by default on systems with Serverworks HT1000 chips

2007-05-07 Thread Andy Gospodarek
as a Broadcom chipset as well) bridge chips. It doesn't appear MSI works well (if at all) on these systems. Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]> --- drivers/pci/quirks.c|1 + include/linux/pci_ids.h |1 + 2 files changed, 2 insertions(+) diff --git a/driver

Re: [patch 4/4] [TULIP] Rev tulip version

2007-03-13 Thread Andy Gospodarek
On Mon, Mar 12, 2007 at 10:07:33AM -0400, Jeff Garzik wrote: > Pekka Enberg wrote: > >Hi, > > > >On 3/12/07, Valerie Henson <[EMAIL PROTECTED]> wrote: > >>--- tulip-2.6-mm-linux.orig/drivers/net/tulip/tulip_core.c > >>+++ tulip-2.6-mm-linux/drivers/net/tulip/tulip_core.c > >>@@ -17,11 +17,11 @@ > >

Re: [PATCH] PCI: Add systems for automatic breadth-first device sorting

2007-02-06 Thread Andy Gospodarek
On Fri, Feb 02, 2007 at 01:27:14PM -0500, Andy Gospodarek wrote: > > This is an additional list of systems that exhibit the PCI device > ordering issue that prompted the following patch: > > commit 6b4b78fed47e7380dfe9280b154e8b9bfcd4c86c > Author: Matt Domsch <[EMAIL PROT

[PATCH] PCI: Add systems for automatic breadth-first device sorting

2007-02-02 Thread Andy Gospodarek
-first Adding these systems to the list prevents the need for the additional kernel command line argument. Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]> --- common.c | 88 +++ 1 files changed, 88 insertions(+) diff

[PATCH] bonding: ARP monitoring broken on x86_64

2007-01-26 Thread Andy Gospodarek
also needs to make its way into the 2.6.19 stable series. Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]> --- bonding.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/bonding/bonding.h b/drivers/net/bonding/bonding.h index dc434fb..cae0e59