[PATCH] media: uapi: Correct doc comment in H264 uAPI

2021-02-04 Thread Andrzej Pietrasiewicz
struct v4l2_ctrl_h264_pps members obviously match picture parameter syntax, not sequence parameter syntax. Signed-off-by: Andrzej Pietrasiewicz --- include/uapi/linux/v4l2-controls.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/v4l2-controls.h b

Re: [PATCH v4 2/7] Input: use input_device_enabled()

2020-12-07 Thread Andrzej Pietrasiewicz
Hi Marek, W dniu 07.12.2020 o 14:32, Marek Szyprowski pisze: Hi Andrzej, On 08.06.2020 13:22, Andrzej Pietrasiewicz wrote: Use the newly added helper in relevant input drivers. Signed-off-by: Andrzej Pietrasiewicz This patch landed recently in linux-next as commit d69f0a43c677 ("

Re: [PATCH] s5p-jpeg: hangle error condition in s5p_jpeg_probe

2020-11-13 Thread Andrzej Pietrasiewicz
Acked-by: Andrzej Pietrasiewicz W dniu 13.11.2020 o 17:06, Baskov Evgeiny pisze: If an error happens in jpeg_get_drv_data(), i.e. match fails, jpeg->variant field is NULL, so we cannot access it. Consider device probe failed if jpeg->variant is NULL. Found by Linux Driver Verifi

Re: [PATCH v4 7/7] Input: Add "inhibited" property

2020-10-06 Thread Andrzej Pietrasiewicz
Hi Dmitry, W dniu 05.10.2020 o 20:10, Dmitry Torokhov pisze: Hi Andrzej, On Mon, Jun 08, 2020 at 01:22:11PM +0200, Andrzej Pietrasiewicz wrote: @@ -284,8 +284,11 @@ static int input_get_disposition(struct input_dev *dev, case EV_KEY: if (is_event_supported(code, dev

Re: [PATCH v3 2/2] tty/sysrq: Add configurable handler to execute a compound action

2020-10-02 Thread Andrzej Pietrasiewicz
Hi, W dniu 02.10.2020 o 16:02, Greg Kroah-Hartman pisze: On Fri, Oct 02, 2020 at 03:42:52PM +0200, Andrzej Pietrasiewicz wrote: Hi, W dniu 02.10.2020 o 14:54, Greg Kroah-Hartman pisze: On Tue, Aug 18, 2020 at 01:28:25PM +0200, Andrzej Pietrasiewicz wrote: Userland might want to execute e.g

Re: [PATCH v3 2/2] tty/sysrq: Add configurable handler to execute a compound action

2020-10-02 Thread Andrzej Pietrasiewicz
Hi, W dniu 02.10.2020 o 14:54, Greg Kroah-Hartman pisze: On Tue, Aug 18, 2020 at 01:28:25PM +0200, Andrzej Pietrasiewicz wrote: Userland might want to execute e.g. 'w' (show blocked tasks), followed by 's' (sync), followed by 1000 ms delay and then followed by 'c

Re: [PATCH v3 0/2] Add configurable handler to execute a compound action

2020-10-02 Thread Andrzej Pietrasiewicz
W dniu 02.10.2020 o 14:33, Andrzej Pietrasiewicz pisze: W dniu 02.10.2020 o 14:31, Greg Kroah-Hartman pisze: On Tue, Aug 18, 2020 at 01:28:23PM +0200, Andrzej Pietrasiewicz wrote: This is a follow-up of this thread: https://www.spinics.net/lists/linux-input/msg68446.html lore.kernel.org is

Re: [PATCH v3 0/2] Add configurable handler to execute a compound action

2020-10-02 Thread Andrzej Pietrasiewicz
W dniu 02.10.2020 o 14:31, Greg Kroah-Hartman pisze: On Tue, Aug 18, 2020 at 01:28:23PM +0200, Andrzej Pietrasiewicz wrote: This is a follow-up of this thread: https://www.spinics.net/lists/linux-input/msg68446.html lore.kernel.org is easier to pull stuff from :) Anyway, what ever happened

[PATCH v3 1/2] tty/sysrq: Extend the sysrq_key_table to cover capital letters

2020-08-18 Thread Andrzej Pietrasiewicz
-SysRq-. Signed-off-by: Andrzej Pietrasiewicz --- Documentation/admin-guide/sysrq.rst | 2 ++ drivers/gpu/drm/drm_fb_helper.c | 2 +- drivers/tty/sysrq.c | 49 +++-- 3 files changed, 50 insertions(+), 3 deletions(-) diff --git a/Documentation/admin

[PATCH v3 0/2] Add configurable handler to execute a compound action

2020-08-18 Thread Andrzej Pietrasiewicz
encoding it (Jiri Slaby) - updated help message of sysrq_drm_fb_helper_restore_op (Jiri Slaby) - used unsigned int for specifying delays (Jiri Slaby) - improved printed messages formatting (Jiri Slaby) Andrzej Pietrasiewicz (2): tty/sysrq: Extend the sysrq_key_table to cover capital letters tty/sys

Re: [PATCH v2 2/2] tty/sysrq: Add configurable handler to execute a compound action

2020-08-18 Thread Andrzej Pietrasiewicz
W dniu 17.08.2020 o 22:09, kernel test robot pisze: Hi Andrzej, I love your patch! Yet something to improve: [auto build test ERROR on 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5] url: https://github.com/0day-ci/linux/commits/Andrzej-Pietrasiewicz/Add-configurable-handler-to-execute-a

[PATCH v3 2/2] tty/sysrq: Add configurable handler to execute a compound action

2020-08-18 Thread Andrzej Pietrasiewicz
of that many milliseconds, e.g.: ws:1000c or r:100eis:1000ub Signed-off-by: Andrzej Pietrasiewicz --- Documentation/admin-guide/sysrq.rst | 9 drivers/tty/sysrq.c | 82 - include/linux/sysrq.h | 1 + 3 files changed, 91 insertions(+

Re: [PATCH 2/2] tty/sysrq: Add configurable handler to execute a compound action

2020-08-17 Thread Andrzej Pietrasiewicz
Hi Jiri, W dniu 12.08.2020 o 13:45, Jiri Slaby pisze: On 04. 08. 20, 18:24, Andrzej Pietrasiewicz wrote: Userland might want to execute e.g. 'w' (show blocked tasks), followed by 's' (sync), followed by 1000 ms delay and then followed by 'c' (crash) upon a single

[PATCH v2 1/2] tty/sysrq: Extend the sysrq_key_table to cover capital letters

2020-08-17 Thread Andrzej Pietrasiewicz
-SysRq-. Signed-off-by: Andrzej Pietrasiewicz --- Documentation/admin-guide/sysrq.rst | 2 ++ drivers/gpu/drm/drm_fb_helper.c | 2 +- drivers/tty/sysrq.c | 49 +++-- 3 files changed, 50 insertions(+), 3 deletions(-) diff --git a/Documentation/admin

[PATCH v2 2/2] tty/sysrq: Add configurable handler to execute a compound action

2020-08-17 Thread Andrzej Pietrasiewicz
of that many milliseconds, e.g.: ws:1000c or r:100eis:1000ub Signed-off-by: Andrzej Pietrasiewicz --- Documentation/admin-guide/sysrq.rst | 9 drivers/tty/sysrq.c | 82 - include/linux/sysrq.h | 1 + 3 files changed, 91 insertions(+

[PATCH v2 0/2] Add configurable handler to execute a compound action

2020-08-17 Thread Andrzej Pietrasiewicz
i Slaby) - used unsigned int for specifying delays (Jiri Slaby) - improved printed messages formatting (Jiri Slaby) Andrzej Pietrasiewicz (2): tty/sysrq: Extend the sysrq_key_table to cover capital letters tty/sysrq: Add configurable handler to execute a compound action Documentatio

[PATCH 0/2] Add configurable handler to execute a compound action

2020-08-04 Thread Andrzej Pietrasiewicz
rst time) causes showing the locked tasks, syncing, waiting a 1000 ms delay and crashing the system. Since all the slots in the sysrq_key_table[] are already taken or reserved, patch 1/2 extends it to cover also capital letter versions. Andrzej Pietrasiewicz (2): tty/sysrq: Extend the sysrq_k

[PATCH 1/2] tty/sysrq: Extend the sysrq_key_table to cover capital letters

2020-08-04 Thread Andrzej Pietrasiewicz
-SysRq-. Signed-off-by: Andrzej Pietrasiewicz --- Documentation/admin-guide/sysrq.rst | 2 ++ drivers/tty/sysrq.c | 49 +++-- 2 files changed, 49 insertions(+), 2 deletions(-) diff --git a/Documentation/admin-guide/sysrq.rst b/Documentation/admin-guide

[PATCH 2/2] tty/sysrq: Add configurable handler to execute a compound action

2020-08-04 Thread Andrzej Pietrasiewicz
of that many milliseconds, e.g.: ws:1000c or r:100eis:1000ub Signed-off-by: Andrzej Pietrasiewicz --- Documentation/admin-guide/sysrq.rst | 9 drivers/tty/sysrq.c | 81 - include/linux/sysrq.h | 1 + 3 files changed, 90 insertions(+

Re: [PATCH v4 0/7] Support inhibiting input devices

2020-08-03 Thread Andrzej Pietrasiewicz
Hi Dmitry, W dniu 12.06.2020 o 10:17, Hans de Goede pisze: Hi, On 6/8/20 1:22 PM, Andrzej Pietrasiewicz wrote: This is a quick respin of v3, with just two small changes, please see the changelog below. Userspace might want to implement a policy to temporarily disregard input from certain

Re: [PATCH] tty/sysrq: Add alternative SysRq key

2020-07-09 Thread Andrzej Pietrasiewicz
Hi Dmitry, W dniu 09.07.2020 o 07:05, Dmitry Torokhov pisze: Hi Andrzej, On Fri, Jun 19, 2020 at 06:28:19PM +0200, Andrzej Pietrasiewicz wrote: There exist machines which don't have SysRq key at all, e.g. chromebooks. This patch allows configuring an alternative key to act as SysRq. De

Re: [PATCH] tty/sysrq: Add alternative SysRq key

2020-06-26 Thread Andrzej Pietrasiewicz
Hi Jiri, W dniu 22.06.2020 o 08:24, Jiri Slaby pisze: On 19. 06. 20, 18:28, Andrzej Pietrasiewicz wrote: There exist machines which don't have SysRq key at all, e.g. chromebooks. This patch allows configuring an alternative key to act as SysRq. Devices which declare KEY_SYSRQ in their &#

Re: [PATCH] tty/sysrq: Add alternative SysRq key

2020-06-26 Thread Andrzej Pietrasiewicz
KEY_SYSRQ, but other devices use the alternative SysRq key instead, by default F10. Which key is actually used can be modified with sysrq's module parameter. Signed-off-by: Andrzej Pietrasiewicz So... SysRq was selected because you are not going to press Alt-Printscreen-X by default. This p

[PATCH] tty/sysrq: Add alternative SysRq key

2020-06-19 Thread Andrzej Pietrasiewicz
by default F10. Which key is actually used can be modified with sysrq's module parameter. Signed-off-by: Andrzej Pietrasiewicz --- drivers/tty/sysrq.c | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.

[PATCH v2] Input: document inhibiting

2020-06-17 Thread Andrzej Pietrasiewicz
Document inhibiting input devices and its relation to being a wakeup source. Signed-off-by: Andrzej Pietrasiewicz --- v1..v2: - Addressed editorial comments from Randy - Added a paragraph by Hans Documentation/input/input-programming.rst | 40 +++ 1 file changed, 40

[PATCH] Input: document inhibiting

2020-06-16 Thread Andrzej Pietrasiewicz
Document inhibiting input devices and its relation to being a wakeup source. Signed-off-by: Andrzej Pietrasiewicz --- @Hans, @Dmitry, My fist attempt at documenting inhibiting. Kindly look at it to see if I haven't got anything wrong. Andrzej Documentation/input/input-programming.rst

Re: [PATCH v4 0/7] Support inhibiting input devices

2020-06-12 Thread Andrzej Pietrasiewicz
Hi Hans, W dniu 12.06.2020 o 10:30, Hans de Goede pisze: Hi, On 6/10/20 3:41 PM, Andrzej Pietrasiewicz wrote: Hi Hans, W dniu 10.06.2020 o 15:21, Hans de Goede pisze: Hi, On 6/10/20 3:12 PM, Andrzej Pietrasiewicz wrote: Hi All, W dniu 10.06.2020 o 12:38, Rafael J. Wysocki pisze: On Wed

Re: [PATCH v4 0/7] Support inhibiting input devices

2020-06-10 Thread Andrzej Pietrasiewicz
Hi Hans, W dniu 10.06.2020 o 15:21, Hans de Goede pisze: Hi, On 6/10/20 3:12 PM, Andrzej Pietrasiewicz wrote: Hi All, W dniu 10.06.2020 o 12:38, Rafael J. Wysocki pisze: On Wed, Jun 10, 2020 at 11:50 AM Hans de Goede wrote: Hi All, On 6/8/20 1:22 PM, Andrzej Pietrasiewicz wrote: This

Re: [PATCH v4 0/7] Support inhibiting input devices

2020-06-10 Thread Andrzej Pietrasiewicz
Hi All, W dniu 10.06.2020 o 12:38, Rafael J. Wysocki pisze: On Wed, Jun 10, 2020 at 11:50 AM Hans de Goede wrote: Hi All, On 6/8/20 1:22 PM, Andrzej Pietrasiewicz wrote: This is a quick respin of v3, with just two small changes, please see the changelog below. Userspace might want to

[FIXED PATCH v4 5/7] iio: adc: exynos: Use input_device_enabled()

2020-06-10 Thread Andrzej Pietrasiewicz
A new helper is available, so use it. Inspecting 'users' member of input_dev requires taking device's mutex. Signed-off-by: Andrzej Pietrasiewicz --- drivers/iio/adc/exynos_adc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc/exynos_adc.

[PATCH v4 6/7] platform/x86: thinkpad_acpi: Use input_device_enabled()

2020-06-08 Thread Andrzej Pietrasiewicz
Use the new helper. Inspecting input device's 'users' member needs to be done under device's mutex, so add appropriate invocations. Signed-off-by: Andrzej Pietrasiewicz Acked-by: Henrique de Moraes Holschuh --- drivers/platform/x86/thinkpad_acpi.c | 4 +++- 1 file changed

[PATCH v4 7/7] Input: Add "inhibited" property

2020-06-08 Thread Andrzej Pietrasiewicz
se to tell the driver to start/stop providing events to the input core. Consequently, open() and close() - if provided - are called in both inhibit and uninhibit paths. Signed-off-by: Patrik Fimml Co-developed-by: Andrzej Pietrasiewicz Signed-off-by: And

[PATCH v4 5/7] iio: adc: exynos: Use input_device_enabled()

2020-06-08 Thread Andrzej Pietrasiewicz
A new helper is available, so use it. Inspecting 'users' member of input_dev requires taking device's mutex. Signed-off-by: Andrzej Pietrasiewicz --- drivers/iio/adc/exynos_adc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc/exynos_adc.

[PATCH v4 2/7] Input: use input_device_enabled()

2020-06-08 Thread Andrzej Pietrasiewicz
Use the newly added helper in relevant input drivers. Signed-off-by: Andrzej Pietrasiewicz --- drivers/input/joystick/xpad.c | 4 ++-- drivers/input/keyboard/ep93xx_keypad.c | 2 +- drivers/input/keyboard/gpio_keys.c | 4 ++-- drivers/input/keyboard/imx_keypad.c

[PATCH v4 3/7] ACPI: button: Access input device's users under appropriate mutex

2020-06-08 Thread Andrzej Pietrasiewicz
Inspecting input device's 'users' member should be done under device's mutex, so add appropriate invocations. Signed-off-by: Andrzej Pietrasiewicz --- drivers/acpi/button.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/button.c b/d

[PATCH v4 4/7] ACPI: button: Use input_device_enabled() helper

2020-06-08 Thread Andrzej Pietrasiewicz
A new helper is available, so use it. Signed-off-by: Andrzej Pietrasiewicz --- drivers/acpi/button.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c index ff7ab291f678..4deb2b48d03c 100644 --- a/drivers/acpi/button.c +++ b

[PATCH v4 0/7] Support inhibiting input devices

2020-06-08 Thread Andrzej Pietrasiewicz
inhibit/uninhibit paths has been emphasized in the commit message of PATCH 6/7 (Dmitry) Andrzej Pietrasiewicz (6): Input: add input_device_enabled() Input: use input_device_enabled() ACPI: button: Access input device's users under appropriate mutex ACPI: button: Use input_device_en

[PATCH v4 1/7] Input: add input_device_enabled()

2020-06-08 Thread Andrzej Pietrasiewicz
A helper function for drivers to decide if the device is used or not. A lockdep check is introduced as inspecting ->users should be done under input device's mutex. Signed-off-by: Andrzej Pietrasiewicz --- drivers/input/input.c | 8 include/linux/input.h | 2 ++ 2 files cha

Re: [PATCH v3 0/7] Support inhibiting input devices

2020-06-08 Thread Andrzej Pietrasiewicz
Hi Pavel, W dniu 08.06.2020 o 07:37, Dmitry Torokhov pisze: On Sun, Jun 07, 2020 at 10:24:14PM +0200, Pavel Machek wrote: On Fri 2020-06-05 19:33:28, Andrzej Pietrasiewicz wrote: Userspace might want to implement a policy to temporarily disregard input from certain devices. Wow, you

[PATCH v3 3/7] ACPI: button: Access input device's users under appropriate mutex

2020-06-05 Thread Andrzej Pietrasiewicz
Inspecting input device's 'users' member should be done under device's mutex, so add appropriate invocations. Signed-off-by: Andrzej Pietrasiewicz --- drivers/acpi/button.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/button.c b/d

[PATCH v3 5/7] iio: adc: exynos: Use input_device_enabled()

2020-06-05 Thread Andrzej Pietrasiewicz
A new helper is available, so use it. Inspecting 'users' member of input_dev requires taking device's mutex. Signed-off-by: Andrzej Pietrasiewicz --- drivers/iio/adc/exynos_adc.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc

[PATCH v3 6/7] platform/x86: thinkpad_acpi: Use input_device_enabled()

2020-06-05 Thread Andrzej Pietrasiewicz
Use the new helper. Inspecting input device's 'users' member needs to be done under device's mutex, so add appropriate invocations. Signed-off-by: Andrzej Pietrasiewicz Acked-by: Henrique de Moraes Holschuh --- drivers/platform/x86/thinkpad_acpi.c | 4 +++- 1 file changed

[PATCH v3 4/7] ACPI: button: Use input_device_enabled() helper

2020-06-05 Thread Andrzej Pietrasiewicz
A new helper is available, so use it. Signed-off-by: Andrzej Pietrasiewicz --- drivers/acpi/button.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c index ff7ab291f678..4deb2b48d03c 100644 --- a/drivers/acpi/button.c +++ b

[PATCH v3 7/7] Input: Add "inhibited" property

2020-06-05 Thread Andrzej Pietrasiewicz
se to tell the driver to start/stop providing events to the input core. Consequently, open() and close() - if provided - are called in both inhibit and uninhibit paths. Signed-off-by: Patrik Fimml Co-developed-by: Andrzej Pietrasiewicz Signed-off-by: And

[PATCH v3 2/7] Input: use input_device_enabled()

2020-06-05 Thread Andrzej Pietrasiewicz
Use the newly added helper in relevant input drivers. Signed-off-by: Andrzej Pietrasiewicz --- drivers/input/joystick/xpad.c | 4 ++-- drivers/input/keyboard/ep93xx_keypad.c | 2 +- drivers/input/keyboard/gpio_keys.c | 4 ++-- drivers/input/keyboard/imx_keypad.c

[PATCH v3 0/7] Support inhibiting input devices

2020-06-05 Thread Andrzej Pietrasiewicz
used it in drivers (Dmitry) - the fact of open() and close() being called in inhibit/uninhibit paths has been emphasized in the commit message of PATCH 6/7 (Dmitry) Andrzej Pietrasiewicz (6): Input: add input_device_enabled() Input: use input_device_enabled() ACPI: button: Access input

[PATCH v3 1/7] Input: add input_device_enabled()

2020-06-05 Thread Andrzej Pietrasiewicz
A helper function for drivers to decide if the device is used or not. A lockdep check is introduced as inspecting ->users should be done under input device's mutex. Signed-off-by: Andrzej Pietrasiewicz --- drivers/input/input.c | 8 include/linux/input.h | 2 ++ 2 files cha

Re: [Patch 2/2] media: use v4l2_rect_enclosed helper

2020-05-29 Thread Andrzej Pietrasiewicz
Parrot for the s5p-jpeg part: Acked-by: Andrzej Pietrasiewicz --- drivers/media/platform/am437x/am437x-vpfe.c | 19 +++ .../media/platform/exynos4-is/fimc-capture.c | 18 +++--- drivers/media/platform/exynos4-is/fimc-lite.c | 18 +++--- drivers

Re: [Patch 1/2] media: v4l2-rect.h: add enclosed rectangle helper

2020-05-29 Thread Andrzej Pietrasiewicz
Hi Benoit, Thank you for the patch, W dniu 28.05.2020 o 15:26, Benoit Parrot pisze: Add a helper function to check if one rectangle is enclosed inside another. Signed-off-by: Benoit Parrot Acked-by: Andrzej Pietrasiewicz --- include/media/v4l2-rect.h | 20 1 file

[PATCH] drm: Fix comment doc for format_modifiers

2019-10-02 Thread Andrzej Pietrasiewicz
but the first words of the comment suggest that it passes an array of structs. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/drm_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_plane.c b/drivers/gpu/drm/drm_plane.c index d6ad60ab0d38.

Re: [PATCH 0/2] Associate ddc adapters with connectors

2019-06-25 Thread Andrzej Pietrasiewicz
Hi Russell, W dniu 25.06.2019 o 12:03, Russell King - ARM Linux admin pisze: On Tue, Jun 25, 2019 at 11:46:34AM +0200, Andrzej Pietrasiewicz wrote: It is difficult for a user to know which of the i2c adapters is for which drm connector. This series addresses this problem. The idea is to have

Re: [REGRESSION] usb: gadget: f_fs: Allow scatter-gather buffers

2019-05-21 Thread Andrzej Pietrasiewicz
Hi, W dniu 20.05.2019 o 23:52, Yang, Fei pisze: One question that comes to my mind is this: Does the USB One of the problems appears to be that req->num_mapped_sgs was left uninitialized. I made the following change and got a lot more requests completed. However this change is not suffici

Re: [REGRESSION] usb: gadget: f_fs: Allow scatter-gather buffers

2019-05-20 Thread Andrzej Pietrasiewicz
Hi John, Is there anything else I can try for you? Have you tried compiling FunctionFS with debugging enabled? You do so bu uncommenting: /* #define DEBUG */ /* #define VERBOSE_DEBUG */ at the beginning of drivers/usb/gadget/function/f_fs.c Is there anything suspicious in the kernel log w

Re: [REGRESSION] usb: gadget: f_fs: Allow scatter-gather buffers

2019-05-14 Thread Andrzej Pietrasiewicz
Hi, W dniu 13.05.2019 o 20:09, John Stultz pisze: On Mon, May 13, 2019 at 7:08 AM Andrzej Pietrasiewicz wrote: Do you get "functionfs read size 512 > requested size 24, splitting request into multiple reads" message when problems happen? Unfortunately no. Actually that&

Re: [REGRESSION] usb: gadget: f_fs: Allow scatter-gather buffers

2019-05-09 Thread Andrzej Pietrasiewicz
Hi John, W dniu 08.05.2019 o 04:18, John Stultz pisze: Since commit 772a7a724f69 ("usb: gadget: f_fs: Allow scatter-gather buffers"), I've been seeing trouble with adb transfers in Android on HiKey960, HiKey and now Dragonboard 845c. Sometimes things crash, but often the transfers just stop w/o

[PATCH] kbuild: make sorting initramfs contents independent of locale

2018-08-17 Thread Andrzej Pietrasiewicz
patch makes sorting use the default (LANG=C) locale, which results in correctly laid out initramfs images (parent directories before files). Signed-off-by: Andrzej Pietrasiewicz --- scripts/gen_initramfs_list.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts

Re: [PATCH] Revert "kbuild: create deterministic initramfs directory listings"

2018-08-17 Thread Andrzej Pietrasiewicz
Hi Bjørn, W dniu 17.08.2018 o 01:34, Bjørn Forsman pisze: > On Thu, 16 Aug 2018 at 18:18, Andrzej Pietrasiewicz > wrote: >> >> This reverts commit 9e6e0d5f2a2713402cf9dce69b9f9b516e4185d2. >> >> The reverted commit introduces broken builds. Even though the cpio a

[PATCH] Revert "kbuild: create deterministic initramfs directory listings"

2018-08-16 Thread Andrzej Pietrasiewicz
/boot/bzImage \ -append "root=/dev/ram console=ttyS0 rdinit=/busybox-x86_64 init" \ -M q35 -initrd ../initramfs.cpio # find find/ find/ find/me find/me/if find/me/if/you find/me/if/you/can find/me/if/you/can/file.txt / # Signed-off-by: Andrzej Pietrasiewicz --- scripts/gen_init

Re: [PATCH v2 1/3] usb: gadget: ccid: add support for USB CCID Gadget Device

2018-05-28 Thread Andrzej Pietrasiewicz
W dniu 28.05.2018 o 11:32, Marcus Folkesson pisze: > Hi Andrzej, > > Thank you for reviewing. > > On Mon, May 28, 2018 at 11:12:27AM +0200, Andrzej Pietrasiewicz wrote: >> W dniu 28.05.2018 o 10:38, Marcus Folkesson pisze: >>> Hi Andrzej, >>> >>> O

Re: [PATCH v2 1/3] usb: gadget: ccid: add support for USB CCID Gadget Device

2018-05-28 Thread Andrzej Pietrasiewicz
W dniu 28.05.2018 o 10:38, Marcus Folkesson pisze: > Hi Andrzej, > > On Mon, May 28, 2018 at 09:04:51AM +0200, Andrzej Pietrasiewicz wrote: >> Mi Marcus, >> >> W dniu 26.05.2018 o 23:19, Marcus Folkesson pisze: >>> Chip Card Interface Device (CCID) protocol

Re: [PATCH v2 1/3] usb: gadget: ccid: add support for USB CCID Gadget Device

2018-05-28 Thread Andrzej Pietrasiewicz
Mi Marcus, W dniu 26.05.2018 o 23:19, Marcus Folkesson pisze: > Chip Card Interface Device (CCID) protocol is a USB protocol that > allows a smartcard device to be connected to a computer via a card > reader using a standard USB interface, without the need for each manufacturer > of smartcards to

Re: [PATCH] media: s5p-jpeg: Fix off-by-one problem

2017-12-07 Thread Andrzej Pietrasiewicz
W dniu 06.12.2017 o 17:37, Flavio Ceolin pisze: s5p_jpeg_runtime_resume() does not call clk_disable_unprepare() for jpeg->clocks[0] when one of the clk_prepare_enable() fails. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Flavio Ceolin Acked-by: Andr

Re: [PATCH v3 8/8] [media] s5p-jpeg: Add stream error handling for Exynos5420

2017-06-29 Thread Andrzej Pietrasiewicz
. Signed-off-by: Henry-Ruey Hsu Signed-off-by: Thierry Escande Acked-by: Andrzej Pietrasiewicz --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p

Re: [PATCH v3 7/8] [media] s5p-jpeg: Add support for resolution change event

2017-06-29 Thread Andrzej Pietrasiewicz
streamoff. This event is used in the Chromium browser project by the V4L2 JPEG Decode Accelerator (V4L2JDA) to allocate output buffer. Signed-off-by: Henry-Ruey Hsu Signed-off-by: Thierry Escande Acked-by: Andrzej Pietrasiewicz --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 106

Re: [PATCH v3 5/8] [media] s5p-jpeg: Split s5p_jpeg_parse_hdr()

2017-06-29 Thread Andrzej Pietrasiewicz
-off-by: Thierry Escande Acked-by: Andrzej Pietrasiewicz --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 42 - 1 file changed, 24 insertions(+), 18 deletions(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg

Re: [PATCH v3 6/8] [media] s5p-jpeg: Decode 4:1:1 chroma subsampling format

2017-06-29 Thread Andrzej Pietrasiewicz
W dniu 27.06.2017 o 18:08, Thierry Escande pisze: From: Tony K Nadackal This patch adds support for decoding 4:1:1 chroma subsampling in the jpeg header parsing function. Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande Acked-by: Andrzej Pietrasiewicz --- drivers/media

Re: [PATCH v3 3/8] [media] s5p-jpeg: Handle parsing error in s5p_jpeg_parse_hdr()

2017-06-29 Thread Andrzej Pietrasiewicz
W dniu 27.06.2017 o 18:08, Thierry Escande pisze: This patch modifies the s5p_jpeg_parse_hdr() function so it only modifies the passed s5p_jpeg_q_data structure if the jpeg header parsing is successful. Signed-off-by: Thierry Escande Acked-by: Andrzej Pietrasiewicz --- drivers/media

Re: [PATCH v3 4/8] [media] s5p-jpeg: Don't use temporary structure in s5p_jpeg_buf_queue

2017-06-29 Thread Andrzej Pietrasiewicz
: Andrzej Pietrasiewicz --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c index df3e5ee..1769744 100644 --- a

Re: [PATCH v3 2/8] [media] s5p-jpeg: Correct WARN_ON statement for checking subsampling

2017-06-29 Thread Andrzej Pietrasiewicz
W dniu 27.06.2017 o 18:08, Thierry Escande pisze: From: Tony K Nadackal Corrects the WARN_ON statement for subsampling based on the JPEG Hardware version. Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande Acked-by: Andrzej Pietrasiewicz --- drivers/media/platform/s5p-jpeg

Re: [PATCH v3 1/8] [media] s5p-jpeg: Call jpeg_bound_align_image after qbuf

2017-06-29 Thread Andrzej Pietrasiewicz
Nadackal Signed-off-by: Thierry Escande Acked-by: Andrzej Pietrasiewicz --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c index

Re: [PATCH v3 0/8] [media] s5p-jpeg: Various fixes and improvements

2017-06-29 Thread Andrzej Pietrasiewicz
Hi Thierry, W dniu 27.06.2017 o 18:08, Thierry Escande pisze: Hi, This series contains various fixes and improvements for the Samsung s5p-jpeg driver. Most of these patches come from the Chromium v3.8 kernel tree. Thank you for the series. It looks good to me. Andrzej

Re: [PATCH v2 1/6] [media] s5p-jpeg: Reset the Codec before doing a soft reset

2017-06-21 Thread Andrzej Pietrasiewicz
Hi Thierry, W dniu 12.06.2017 o 19:13, Thierry Escande pisze: From: Abhilash Kesavan This patch resets the encoding and decoding register bits before doing a soft reset. Here are my thoughts after consulting the documentation: Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande

Re: [PATCH v2 4/6] [media] s5p-jpeg: Decode 4:1:1 chroma subsampling format

2017-06-20 Thread Andrzej Pietrasiewicz
Hi Thierry, W dniu 12.06.2017 o 19:13, Thierry Escande pisze: From: Tony K Nadackal This patch adds support for decoding 4:1:1 chroma subsampling in the jpeg header parsing function. Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande --- drivers/media/platform/s5p-jpeg/jpeg-cor

Re: [PATCH v2 5/6] [media] s5p-jpeg: Add support for resolution change event

2017-06-20 Thread Andrzej Pietrasiewicz
Hi Thierry, W dniu 19.06.2017 o 15:50, Thierry Escande pisze: Hi Andrzej, On 16/06/2017 17:38, Andrzej Pietrasiewicz wrote: Hi Thierry, Thank you for the patch. Can you give a use case for resolution change event? Unfortunately, the original commit does not mention any clear use case. I&#x

Re: [PATCH v2 5/6] [media] s5p-jpeg: Add support for resolution change event

2017-06-16 Thread Andrzej Pietrasiewicz
Hi Thierry, Thank you for the patch. Can you give a use case for resolution change event? Also plase see inline. W dniu 12.06.2017 o 19:13, Thierry Escande pisze: From: henryhsu This patch adds support for resolution change event to notify clients so they can prepare correct output buffer.

Re: [PATCH v2 6/6] [media] s5p-jpeg: Add stream error handling for Exynos5420

2017-06-16 Thread Andrzej Pietrasiewicz
Hi Thierry, Thank you for the patch. Please see inline. W dniu 12.06.2017 o 19:13, Thierry Escande pisze: From: henryhsu On Exynos5420, the STREAM_STAT bit raised on the JPGINTST register means there is a syntax error or an unrecoverable error on compressed file when ERR_INT_EN is set to 1.

Re: [PATCH 1/9] [media] s5p-jpeg: Reset the Codec before doing a soft reset

2017-06-14 Thread Andrzej Pietrasiewicz
Hi, W dniu 13.06.2017 o 20:46, Jacek Anaszewski pisze: Hi Thierry, On 06/07/2017 02:34 PM, Thierry Escande wrote: Hi Jacek, On 02/06/2017 21:50, Jacek Anaszewski wrote: Hi Thierry, On 06/02/2017 06:02 PM, Thierry Escande wrote: From: Abhilash Kesavan This patch resets the encoding and de

Re: [PATCH] usb: gadget: uvc: fix returnvar.cocci warnings

2016-11-23 Thread Andrzej Pietrasiewicz
Hi Laurent, Thanks for a reminder. Please see inline. W dniu 22.11.2016 o 18:27, Laurent Pinchart pisze: Hi Andrzej and Julia, Could one of you please submit a patch to fix this ? On Thursday 17 Sep 2015 13:18:04 Andrzej Pietrasiewicz wrote: Hi Julia, W dniu 17.09.2015 o 10:57, Julia

Re: [PATCH] usb: f_mass_storage: test whether thread is running before starting another

2016-04-18 Thread Andrzej Pietrasiewicz
Hi Michał, W dniu 07.04.2016 o 18:40, Michal Nazarewicz pisze: On Thu, 7 Apr 2016, Michal Nazarewicz wrote: This makes me suspect it’s not possible to link a function instance to the same configuration twice, but now that I think about it, I’m not quite sure what would happen if one did:

Re: [patch -target tree] usb: gadget: f_tcm: use after free

2016-03-10 Thread Andrzej Pietrasiewicz
Hi Nicholas, W dniu 10.03.2016 o 06:19, Nicholas A. Bellinger pisze: Hi Andrzej, On Wed, 2016-03-09 at 13:53 +0100, Andrzej Pietrasiewicz wrote: Hi Nicholas, Applying the following patch to re-add the missing assingment as a proper alloc_session callback. diff --git a/drivers/usb

Re: [patch -target tree] usb: gadget: f_tcm: use after free

2016-03-09 Thread Andrzej Pietrasiewicz
Hi Nicholas, W dniu 05.03.2016 o 08:26, Nicholas A. Bellinger pisze: Hi Felipe + usb-gadget folks, On Wed, 2016-03-02 at 13:55 +0200, Felipe Balbi wrote: usb-gadget/tcm: Conversion to percpu_ida tag pre-allocation http://www.spinics.net/lists/target-devel/msg11777.html usb-gadget/tcm: Co

Re: [PATCH] usb: gadget: uvc: fix returnvar.cocci warnings

2015-09-17 Thread Andrzej Pietrasiewicz
1 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci CC: Andrzej Pietrasiewicz Signed-off-by: Fengguang Wu --- Please take the patch only if it's a positive warning. Thanks! uvc_configfs.c |3 +-- 1 file changed, 1 insertio

Re: [PATCH] usb/gadget: make composite gadget meet usb compliance for vbus draw

2015-07-24 Thread Andrzej Pietrasiewicz
Hi, W dniu 24.07.2015 o 06:11, Du, Changbin pisze: Thanks, Pietrasiewicz. From: Andrzej Pietrasiewicz [mailto:andrze...@samsung.com] W dniu 23.07.2015 o 14:34, Du, Changbin pisze: >From 0a8e0d63a9887735c6782d7b0c15c2c1fdf1952a Mon Sep 17 00:00:00 void composite_disconnect(struct usb_gad

Re: [PATCH] usb/gadget: make composite gadget meet usb compliance for vbus draw

2015-07-23 Thread Andrzej Pietrasiewicz
Hi Changbin, (I assume I address your name properly, if not please excuse) W dniu 23.07.2015 o 14:34, Du, Changbin pisze: From 0a8e0d63a9887735c6782d7b0c15c2c1fdf1952a Mon Sep 17 00:00:00 2001 void composite_disconnect(struct usb_gadget *gadget) { struct usb_composite_dev

Re: Locking issues w/ functionfs gadget and aio?

2015-07-01 Thread Andrzej Pietrasiewicz
W dniu 22.06.2015 o 19:20, John Stultz pisze: On Sat, Jun 20, 2015 at 10:24 PM, Al Viro wrote: On Fri, Jun 12, 2015 at 05:51:12PM -0700, John Stultz wrote: I'm not super sure what the right fix is, but if do something like the following (sorry, whitespace corrupted via copy/paste), I don't se

Re: linux-next: build warnings after merge of the usb-gadget tree

2015-05-20 Thread Andrzej Pietrasiewicz
W dniu 20.05.2015 o 08:29, Stephen Rothwell pisze: Hi Felipe, After merging the usb-gadget tree, today's linux-next build (x86_64 allmodconfig) produced these warnings: drivers/usb/gadget/function/rndis.c: In function 'rndis_proc_write': drivers/usb/gadget/function/rndis.c:1147:4: warning: pass

Re: [PATCH 1/2] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-02-17 Thread Andrzej Pietrasiewicz
W dniu 17.02.2015 o 22:02, Ruslan Bilovol pisze: Hi Andrzej, On Mon, Feb 16, 2015 at 10:07 AM, Andrzej Pietrasiewicz wrote: W dniu 15.02.2015 o 23:43, Ruslan Bilovol pisze: In my opinion all things which you have described are working out-of-box when you use configfs interface. It&#

Re: [PATCH 1/2] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

2015-02-16 Thread Andrzej Pietrasiewicz
W dniu 15.02.2015 o 23:43, Ruslan Bilovol pisze: In my opinion all things which you have described are working out-of-box when you use configfs interface. It's mostly ready so you may create equivalent of most legacy gadgets (apart from printer and tcm) and just bind from one udc to another w

Re: [PATCH] usb: gadget: nokia: Add mass storage driver to g_nokia

2015-02-02 Thread Andrzej Pietrasiewicz
Hello Pali, W dniu 31.01.2015 o 10:53, Pali Rohár pisze: This patch adds removable mass storage support to g_nokia gadget (for N900). It means that at runtime block device can be exported or unexported. For a hint please see this thread: http://www.spinics.net/lists/linux-usb/msg119669.html -

Re: [PATCH next] usb: gadget: uvc: to_uvcg_control_header() can be static

2015-01-13 Thread Andrzej Pietrasiewicz
; was not declared. Should it be static? drivers/usb/gadget/function/uvc_configfs.c:1793:6: sparse: symbol 'uvcg_mjpeg_drop' was not declared. Should it be static? Signed-off-by: Fengguang Wu Reviewed-by: Andrzej Pietrasiewicz --- uvc_configfs.c | 32 ---

Re: [PATCH] usb: gadget: don't create new string_container if already exist

2014-11-04 Thread Andrzej Pietrasiewicz
W dniu 04.11.2014 o 12:05, Neil Zhang pisze: -Original Message- From: Andrzej Pietrasiewicz [mailto:andrze...@samsung.com] Sent: 2014年10月28日 21:10 To: Neil Zhang; linux-...@vger.kernel.org; linux-kernel@vger.kernel.org Cc: ba...@ti.com; gre...@linuxfoundation.org Subject: Re: [PATCH

Re: [PATCH] usb: gadget: don't create new string_container if already exist

2014-10-28 Thread Andrzej Pietrasiewicz
Hi, W dniu 28.10.2014 o 12:33, Neil Zhang pisze: Don't create new usb_gadget_string_container if the current strings are already exist in the usb_composite_dev. Otherwise the ids_tab will overflow soon if we bind / unbind usb functions frequently like android does. The problem you are describi

[PATCH] fs: configfs: add allow_drop() to configfs_item_operations

2014-10-08 Thread Andrzej Pietrasiewicz
called _after_ corresponding filesystem entities are torn down. In other words, the semantics of (*drop_link)() is "the final, unconditional cleanup". In order not to break this semantics, a new method is added and its value is checked in fs/configfs/symlink.c:configfs_unlink(). Signed-off-b

Re: USB_MUSB_DA8XX with g_multi.ko

2014-06-25 Thread Andrzej Pietrasiewicz
W dniu 25.06.2014 17:13, Jon Ringle pisze: In commit 787f5627bec80094db487bfcb401e9744f181aed usb: musb: make davinci and da8xx glues depend on BROKEN USB_MUSB_DA8XX was marked as BROKEN A few months ago, we updated the linux kernel on our AM1808 SoC based embedded board from Linux 2.6.33 to th

Re: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-05 Thread Andrzej Pietrasiewicz
W dniu 04.06.2014 17:26, Alan Stern pisze: On Wed, 4 Jun 2014, Andrzej Pietrasiewicz wrote: What is the difference in purpose between usb_function and usb_function_instance? I can't tell just by reading the header file. Does one of them get created dynamically when the host set

Re: [PATCH v1] USB:gadget: Fix a warning while loading g_mass_storage

2014-06-04 Thread Andrzej Pietrasiewicz
Hi Alan, W dniu 03.06.2014 16:48, Alan Stern pisze: On Tue, 3 Jun 2014 wei.y...@windriver.com wrote: From: Yang Wei While loading g_mass_storage module, the following warning is triggered. In fact, it is more easy to reproduce it with RT kernel. WARNING: at drivers/usb/gadget/composite.c: u

Re: [PATCH trivial] Documentation: fix multiple typo occurences s/KenelVersion/KernelVersion/

2014-01-29 Thread Andrzej Pietrasiewicz
Signed-off-by: Ard Biesheuvel Acked-by: Andrzej Pietrasiewicz Cc: Andrzej Pietrasiewicz --- Documentation/ABI/testing/configfs-usb-gadget | 12 ++-- Documentation/ABI/testing/configfs-usb-gadget-acm | 2 +- Documentation/ABI/testing/configfs-usb-gadget

Re: [PATCH] net: sk == 0xffffffff fix - not for commit

2014-01-17 Thread Andrzej Pietrasiewicz
W dniu 17.01.2014 13:18, Andrzej Pietrasiewicz pisze: W dniu 16.01.2014 17:29, Eric Dumazet pisze: On Thu, 2014-01-16 at 16:21 +0100, Andrzej Pietrasiewicz wrote: W dniu 10.12.2013 15:25, Eric Dumazet pisze: On Tue, 2013-12-10 at 07:55 +0100, Andrzej Pietrasiewicz wrote: W dniu 09.12.2013 16

Re: [PATCH] net: sk == 0xffffffff fix - not for commit

2014-01-17 Thread Andrzej Pietrasiewicz
W dniu 16.01.2014 17:29, Eric Dumazet pisze: On Thu, 2014-01-16 at 16:21 +0100, Andrzej Pietrasiewicz wrote: W dniu 10.12.2013 15:25, Eric Dumazet pisze: On Tue, 2013-12-10 at 07:55 +0100, Andrzej Pietrasiewicz wrote: W dniu 09.12.2013 16:31, Eric Dumazet pisze: On Mon, 2013-12-09 at 12:47

[PATCH v3] kernel/locking: mutex: simplify access to the first entry in the wait-list

2013-12-13 Thread Andrzej Pietrasiewicz
Use list_first_entry instead of explicitly accessing the first entry with "head".next. The comment one line above becomes obsolete. Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Kyungmin Park --- v2..v3: - changed Singed-off-by to Reviewed-by: Kyungmin Park v1..v2: - corrected

  1   2   >