Re: [PATCH v1] module.h: define __symbol_get_gpl() as a regular __symbol_get()

2024-02-13 Thread Andrew Kanner
stringify symbol names at build time to completely remove symbol_get() from module.h? Correct me if I'm wrong since using of a fuction which is not declared anywhere sounds confusing. -- Andrew Kanner

Re: [PATCH v1] module.h: define __symbol_get_gpl() as a regular __symbol_get()

2024-02-01 Thread Andrew Kanner
On Thu, Feb 01, 2024 at 06:29:58AM +0100, Christoph Hellwig wrote: > On Wed, Jan 31, 2024 at 10:02:52PM +0300, Andrew Kanner wrote: > > Prototype for __symbol_get_gpl() was introduced in the initial git > > commit 1da177e4c3f4 ("Linux-2.6.12-rc2"), but was not used after

[PATCH v1] module.h: define __symbol_get_gpl() as a regular __symbol_get()

2024-01-31 Thread Andrew Kanner
t.mche...@kernel.org/ Signed-off-by: Andrew Kanner --- include/linux/module.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/module.h b/include/linux/module.h index 96bc462872c0..8a660c81ac3d 100644 --- a/include/linux/module.h +++ b/include/linux/module.h @@ -29

[PATCH v2] staging: lustre: fixed shadowed variable in socklnd_cb.c

2016-11-03 Thread Andrew Kanner
Removed redundant declaration of variable 'tx' in local scope Fixed: sparse warning: socklnd_cb.c:2476:41: warning: symbol 'tx' shadows an earlier one socklnd_cb.c:2435:25: originally declared here Signed-off-by: Andrew Kanner --- drivers/staging/lustre/lnet/klnds/sock

Re: [PATCH] staging: lustre: fixed shadowed variable in socklnd_cb.c

2016-11-03 Thread Andrew Kanner
2016-11-04 1:12 GMT+03:00 Dilger, Andreas : > On Nov 3, 2016, at 15:54, Andrew Kanner wrote: >> >> Changed variable 'tx' name in local scope >> Fixed: sparse warning: >> socklnd_cb.c:2476:41: warning: symbol 'tx' shadows an earlier one >> sockl

[PATCH] staging: lustre: fixed shadowed variable in socklnd_cb.c

2016-11-03 Thread Andrew Kanner
Changed variable 'tx' name in local scope Fixed: sparse warning: socklnd_cb.c:2476:41: warning: symbol 'tx' shadows an earlier one socklnd_cb.c:2435:25: originally declared here Signed-off-by: Andrew Kanner --- drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 4 ++-

[PATCH v2] drivers: staging: vme: convert to octal notation for permission bits

2016-09-16 Thread Andrew Kanner
Ran checkpatch.pl -f vme_pio2_core.c Fixed: WARNING: Symbolic permissions are not preferred. Consider using octal permissions (0444) Signed-off-by: Andrew Kanner --- drivers/staging/vme/devices/vme_pio2_core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a

Re: drivers: staging: vme: Fixed some code style warnings

2016-09-14 Thread Andrew Kanner
‎Thanks, I understood my fault, but haven't done this changes yet. I can't understand if I should reply to original message with v2 patch or send a new email with it?   Исходное сообщение   От: Markus Böhme Отправлено: среда, 14 сентября 2016 г., 15:56 Кому: Andrew K

drivers: staging: vme: Fixed some code style warnings

2016-09-12 Thread Andrew Kanner
Signed-off-by: Andrew Kanner --- drivers/staging/vme/devices/vme_pio2_core.c | 12 ++-- drivers/staging/vme/devices/vme_user.c | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/vme/devices/vme_pio2_core.c b/drivers/staging/vme/devices