Re: [PATCH 2/2] power: bq27xxx: Fix spacing style and white space issues

2020-07-30 Thread Andrew F. Davis
On 7/30/20 10:31 AM, Dan Murphy wrote: > Fix spacing style issues with the chip data array. As well as fix > missing new line after variable declaration. > > Signed-off-by: Dan Murphy > --- > drivers/power/supply/bq27xxx_battery.c | 63 ++ > 1 file changed, 33 insertions

Re: [PATCH v12 1/4] power_supply: Add additional health properties to the header

2020-05-28 Thread Andrew F. Davis
inagesh > Signed-off-by: Dan Murphy You should collect the acks and such you have received in previous versions here, like mine from v11: Acked-by: Andrew F. Davis > --- > Documentation/ABI/testing/sysfs-class-power | 2 +- > drivers/power/supply/power_supply_sysfs.c |

Re: [PATCH v11 4/4] power: supply: bq25150 introduce the bq25150

2020-05-28 Thread Andrew F. Davis
On 5/28/20 10:05 AM, Ricardo Rivera-Matos wrote: > +static int bq2515x_set_precharge_current(struct bq2515x_device *bq2515x, > + int val) > +{ > + int ret; > + unsigned int pchrgctrl; > + unsigned int icharge_range; > + unsigned int precharge_reg_

Re: [PATCH v11 1/4] power_supply: Add additional health properties to the header

2020-05-28 Thread Andrew F. Davis
n of the spec these are from, but not super important, Acked-by: Andrew F. Davis > > Tested-by: Guru Das Srinagesh > Signed-off-by: Dan Murphy > --- > Documentation/ABI/testing/sysfs-class-power | 2 +- > drivers/power/supply/power_supply_sysfs.c | 2 +- > include/linu

Re: [PATCH 1/2] power: supply: bq27xxx_battery: Notify about all battery changes

2020-05-26 Thread Andrew F. Davis
On 5/25/20 10:11 AM, Krzysztof Kozlowski wrote: > All battery related data could be important for user-space. For example > time-to-full could be shown to user on the screen or health could be > monitored for any issues. Instead of comparing few selected old/new > values, just check if anything c

Re: [RFC] power: supply: bq27xxx_battery: Fix polling interval after re-bind

2020-05-26 Thread Andrew F. Davis
On 5/25/20 7:32 AM, Krzysztof Kozlowski wrote: > This reverts commit 8cfaaa811894a3ae2d7360a15a6cfccff3ebc7db. > > If device was unbound and bound, the polling interval would be set to 0. > This is both unexpected and messes up with other bq27xxx devices (if > more than one battery device is used)

Re: [PATCH v7 3/3] power: supply: bq25150 introduce the bq25150

2020-05-19 Thread Andrew F. Davis
On 5/19/20 10:19 AM, Dan Murphy wrote: > +static int bq2515x_set_ilim_lvl(struct bq2515x_device *bq2515x, int val) > +{ > + int i; > + > + if (val > BQ2515X_ILIM_MAX || val < BQ2515X_ILIM_MIN) > + return -EINVAL; Clamp to these limits, not reject. Or better, modify the below lo

Re: [PATCH 3/3] power: supply: bq25150 introduce the bq25150

2020-05-18 Thread Andrew F. Davis
On 5/15/20 3:31 PM, Dan Murphy wrote: > From: Ricardo Rivera-Matos > > Introduce the bq2515x family of chargers. > > The BQ2515X family of devices are highly integrated battery management > ICs that integrate the most common functions for wearbale devices s/wearbale/wearable > namely a charg

Re: [PATCH v2] dt-bindings: power: Convert bq27xxx dt to yaml

2020-05-11 Thread Andrew F. Davis
On 5/7/20 2:30 PM, Dan Murphy wrote: > Convert the bq27xxx.txt to yaml format > > CC: Pali Rohár > CC: Andrew F. Davis > Signed-off-by: Dan Murphy > --- > .../bindings/power/supply/bq27xxx.txt | 56 > .../bindings/power/supply/

Re: [RFC][PATCH 1/4] devicetree: bindings: Add linux,cma-heap tag for reserved memory

2020-05-06 Thread Andrew F. Davis
On 5/6/20 12:30 PM, John Stultz wrote: > On Wed, May 6, 2020 at 9:04 AM Andrew F. Davis wrote: >> On 5/4/20 4:50 AM, Brian Starkey wrote: >>> On Fri, May 01, 2020 at 11:40:16AM -0700, John Stultz wrote: >>>> So the name we expose is the CMA name itself. So with dt i

Re: [RFC][PATCH 1/4] devicetree: bindings: Add linux,cma-heap tag for reserved memory

2020-05-06 Thread Andrew F. Davis
gt;> This patch adds a linux,cma-heap property for CMA reserved memory >>>> regions, which will be used to allow the region to be exposed via >>>> the DMA-BUF Heaps interface >>>> >>>> Cc: Rob Herring >>>> Cc: Sumit Semwal >>>

Re: [PATCH] dt-bindings: power: Convert bq27xxx dt to yaml

2020-05-04 Thread Andrew F. Davis
On 5/4/20 12:44 PM, Dan Murphy wrote: > Adding Andrew in manually. > > On 5/4/20 11:41 AM, Dan Murphy wrote: >> Convert the bq27xxx.txt to yaml format >> >> CC: Pali Rohár >> CC: Andrew F. Davis" >> Signed-off-by: Dan Murphy >> --- >&

Re: [PATCH] misc: sram: Add dma-heap-export reserved SRAM area type

2020-04-29 Thread Andrew F. Davis
On 4/27/20 11:17 AM, Rob Herring wrote: > On Fri, Apr 24, 2020 at 5:27 PM Andrew F. Davis wrote: >> >> This new export type exposes to userspace the SRAM area as a DMA-Heap, >> this allows for allocations as DMA-BUFs that can be consumed by various >> DMA-BUF supportin

Re: [PATCH] misc: sram: Add dma-heap-export reserved SRAM area type

2020-04-29 Thread Andrew F. Davis
On 4/24/20 8:44 PM, John Stultz wrote: > On Fri, Apr 24, 2020 at 3:27 PM Andrew F. Davis wrote: >> This new export type exposes to userspace the SRAM area as a DMA-Heap, >> this allows for allocations as DMA-BUFs that can be consumed by various >> DMA-BUF supporting devices

[PATCH 06/10] thermal: devfreq_cooling: Remove unneeded conversions to bool

2019-10-16 Thread Andrew F. Davis
Found with scripts/coccinelle/misc/boolconv.cocci. Signed-off-by: Andrew F. Davis --- drivers/thermal/devfreq_cooling.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/devfreq_cooling.c b/drivers/thermal/devfreq_cooling.c index ef59256887ff..e386a3241700

[PATCH 07/10] [SCSI] Buslogic: Remove unneeded conversions to bool

2019-10-16 Thread Andrew F. Davis
Found with scripts/coccinelle/misc/boolconv.cocci. Signed-off-by: Andrew F. Davis --- drivers/scsi/BusLogic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c index c25e8a54e869..6a0a74e9edc9 100644 --- a/drivers/scsi

[PATCH 08/10] i40e: Remove unneeded conversions to bool

2019-10-16 Thread Andrew F. Davis
Found with scripts/coccinelle/misc/boolconv.cocci. Signed-off-by: Andrew F. Davis --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index

[PATCH 04/10] atl1c: remove unneeded conversions to bool

2019-10-16 Thread Andrew F. Davis
Found with scripts/coccinelle/misc/boolconv.cocci. Signed-off-by: Andrew F. Davis --- drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c

[PATCH 09/10] ixgbe: Remove unneeded conversions to bool

2019-10-16 Thread Andrew F. Davis
Found with scripts/coccinelle/misc/boolconv.cocci. Signed-off-by: Andrew F. Davis --- drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe

[PATCH 05/10] mlxsw: Remove unneeded conversions to bool

2019-10-16 Thread Andrew F. Davis
Found with scripts/coccinelle/misc/boolconv.cocci. Signed-off-by: Andrew F. Davis --- drivers/net/ethernet/mellanox/mlxsw/switchx2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/switchx2.c b/drivers/net/ethernet/mellanox/mlxsw/switchx2

[PATCH 10/10] ath5k: Remove unneeded conversions to bool

2019-10-16 Thread Andrew F. Davis
Found with scripts/coccinelle/misc/boolconv.cocci. Signed-off-by: Andrew F. Davis --- drivers/net/wireless/ath/ath5k/ani.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath5k/ani.c b/drivers/net/wireless/ath/ath5k/ani.c index 0624333f5430

[PATCH 03/10] mtd: nand: qcom: remove unneeded conversions to bool

2019-10-16 Thread Andrew F. Davis
Found with scripts/coccinelle/misc/boolconv.cocci. Signed-off-by: Andrew F. Davis --- drivers/mtd/nand/raw/qcom_nandc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c index 7bb9a7e8e1e7..b437b0c79cf2

[PATCH 02/10] cxl: remove unneeded conversions to bool

2019-10-16 Thread Andrew F. Davis
Found with scripts/coccinelle/misc/boolconv.cocci. Signed-off-by: Andrew F. Davis --- drivers/misc/cxl/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/cxl/sysfs.c b/drivers/misc/cxl/sysfs.c index f0263d1a1fdf..c57ec87bc0a6 100644 --- a/drivers/misc/cxl

[PATCH 01/10] drm/nouveau: remove unneeded conversions to bool

2019-10-16 Thread Andrew F. Davis
Found with scripts/coccinelle/misc/boolconv.cocci. Signed-off-by: Andrew F. Davis --- drivers/gpu/drm/nouveau/nouveau_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c index f0daf958e03a

[PATCH] omapfb/dss: remove unneeded conversions to bool

2019-10-16 Thread Andrew F. Davis
Found with scripts/coccinelle/misc/boolconv.cocci. Signed-off-by: Andrew F. Davis --- drivers/video/fbdev/omap2/omapfb/dss/dispc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dispc.c b/drivers/video/fbdev/omap2/omapfb/dss

Re: [PATCH 1/3] mfd: wm8998: Remove some unused registers

2019-10-04 Thread Andrew F. Davis
On 10/1/19 9:46 AM, Charles Keepax wrote: > Signed-off-by: Charles Keepax > --- > Why do this? There is no commit message.. Andrew > Patch is new to the series. > > Thanks, > Charles > > drivers/mfd/wm8998-tables.c | 12 > include/linux/mfd/arizona/registers.h | 7

Re: [PATCH] arm64: use x22 to save boot exception level

2019-08-30 Thread Andrew F. Davis
On 8/29/19 5:47 AM, Mark Rutland wrote: > Hi Andrew, > > On Wed, Aug 28, 2019 at 01:33:18PM -0400, Andrew F. Davis wrote: >> The exception level in which the kernel was entered needs to be saved for >> later. We do this by writing the exception level to memory. As this data &

[PATCH] arm64: use x22 to save boot exception level

2019-08-28 Thread Andrew F. Davis
the data is not written with the MMU off anymore we move the variable definition out of this section and into a regular C code data section. Signed-off-by: Andrew F. Davis --- arch/arm64/kernel/head.S | 31 +++ arch/arm64/kernel/smp.c | 10 ++ 2 files changed

Re: Status of Subsystems - TI BQ27XXX POWER SUPPLY DRIVER

2019-08-21 Thread Andrew F. Davis
On 8/20/19 10:00 AM, Sebastian Duda wrote: > Hello Andrew, > > in my master thesis, I'm using the association of subsystems to > maintainers/reviewers and its status given in the MAINTAINERS file. > During the research I noticed that there are several subsystems without > a status in the maintaine

Re: [PATCH] rpmsg: virtio_rpmsg_bus: replace "%p" with "%pK"

2019-08-12 Thread Andrew F. Davis
On 8/12/19 12:39 PM, Suman Anna wrote: > On 8/12/19 11:36 AM, Andrew F. Davis wrote: >> On 8/12/19 12:28 PM, Suman Anna wrote: >>> On 8/12/19 10:47 AM, Andrew F. Davis wrote: >>>> On 10/23/18 9:19 PM, Suman Anna wrote: >>>>> The virtio_rpmsg_

Re: [PATCH] rpmsg: virtio_rpmsg_bus: replace "%p" with "%pK"

2019-08-12 Thread Andrew F. Davis
On 8/12/19 12:28 PM, Suman Anna wrote: > On 8/12/19 10:47 AM, Andrew F. Davis wrote: >> On 10/23/18 9:19 PM, Suman Anna wrote: >>> The virtio_rpmsg_bus driver uses the "%p" format-specifier for >>> printing the vring buffer address. This prints only a hashed

Re: [PATCH] rpmsg: virtio_rpmsg_bus: replace "%p" with "%pK"

2019-08-12 Thread Andrew F. Davis
On 10/23/18 9:19 PM, Suman Anna wrote: > The virtio_rpmsg_bus driver uses the "%p" format-specifier for > printing the vring buffer address. This prints only a hashed > pointer even for previliged users. Use "%pK" instead so that > the address can be printed during debug using kptr_restrict > sysct

Re: [RFC PATCH 2/2] soc: ti: Add Support for the TI Page-based Address Translator (PAT)

2019-07-31 Thread Andrew F. Davis
On 6/18/19 5:07 AM, Tero Kristo wrote: > On 07/06/2019 22:35, Andrew F. Davis wrote: >> This patch adds a driver for the Page-based Address Translator (PAT) >> present on various TI SoCs. A PAT device performs address translation >> using tables stored in an internal SRAM. Ea

Re: [PATCH v6 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-07-25 Thread Andrew F. Davis
On 7/25/19 10:30 AM, Christoph Hellwig wrote: > On Thu, Jul 25, 2019 at 10:25:50AM -0400, Andrew F. Davis wrote: >> On 7/25/19 10:11 AM, Christoph Hellwig wrote: >>> On Thu, Jul 25, 2019 at 10:10:08AM -0400, Andrew F. Davis wrote: >>>> Pages yes, but not "normal&

Re: [PATCH 1/6] dt-bindings: irqchip: Add PRUSS interrupt controller bindings

2019-07-08 Thread Andrew F. Davis
, and the K3 architecture based AM65x > and J721E SoCs. > > Signed-off-by: Suman Anna > Signed-off-by: Andrew F. Davis > Signed-off-by: Roger Quadros > --- > Prior version: https://patchwork.kernel.org/patch/10795771/ > > .../interrupt-controller/ti,pruss-intc.txt|

Re: [PATCH v2 1/2] ASoC: tas5720.c: cleanup variant management

2019-07-03 Thread Andrew F. Davis
On 7/2/19 6:12 AM, Nikolaus Voss wrote: > On Mon, 1 Jul 2019, Andrew F. Davis wrote: >> On 7/1/19 11:35 AM, Nikolaus Voss wrote: >>> On Mon, 1 Jul 2019, Andrew F. Davis wrote: >>>> On 7/1/19 9:42 AM, Nikolaus Voss wrote: >>>>> Replace enum tas572x_type

Re: [PATCH v2 1/2] ASoC: tas5720.c: cleanup variant management

2019-07-01 Thread Andrew F. Davis
On 7/1/19 11:35 AM, Nikolaus Voss wrote: > On Mon, 1 Jul 2019, Andrew F. Davis wrote: >> On 7/1/19 9:42 AM, Nikolaus Voss wrote: >>> Replace enum tas572x_type with struct tas5720_variant which aggregates >>> variant specific stuff and can be directly referenced from an i

Re: [PATCH v2 1/2] ASoC: tas5720.c: cleanup variant management

2019-07-01 Thread Andrew F. Davis
On 7/1/19 9:42 AM, Nikolaus Voss wrote: > Replace enum tas572x_type with struct tas5720_variant which aggregates > variant specific stuff and can be directly referenced from an id table. > > Signed-off-by: Nikolaus Voss > --- > sound/soc/codecs/tas5720.c | 98 +---

Re: [PATCH] sound/soc/codecs/tas5720.c: add ACPI support

2019-06-28 Thread Andrew F. Davis
On 6/28/19 8:34 AM, Nikolaus Voss wrote: > Add support for ACPI enumeration for tas5720 and tas5722. > Use device_match API to unify access to driver data for DT and ACPI. > Aggregate variant stuff into its own struct and directly reference > it in variant data for i2c/of/acpi_device_id. > > Signe

Re: [PATCH v3 2/2] power: supply: ucs1002: Add HWMON interface

2019-06-05 Thread Andrew F. Davis
On 6/5/19 3:23 AM, Andrey Smirnov wrote: Expose current sensors found on UCS1002 via HWMON. Signed-off-by: Andrey Smirnov Reviewed-by: Guenter Roeck Cc: Chris Healy Cc: Cory Tusar Cc: Lucas Stach Cc: Fabio Estevam Cc: Guenter Roeck Cc: Sebastian Reichel Cc: linux-kernel@vger.kernel.org C

Re: [PATCH v6 1/7] Documentation: DT: arm: add support for sockets defining package boundaries

2019-05-30 Thread Andrew F. Davis
On 5/30/19 7:51 AM, Morten Rasmussen wrote: On Wed, May 29, 2019 at 07:39:17PM -0400, Andrew F. Davis wrote: On 5/29/19 5:13 PM, Atish Patra wrote: From: Sudeep Holla The current ARM DT topology description provides the operating system with a topological view of the system that is based on

Re: [PATCH v6 1/7] Documentation: DT: arm: add support for sockets defining package boundaries

2019-05-29 Thread Andrew F. Davis
On 5/29/19 5:13 PM, Atish Patra wrote: From: Sudeep Holla The current ARM DT topology description provides the operating system with a topological view of the system that is based on leaf nodes representing either cores or threads (in an SMT system) and a hierarchical set of cluster nodes that

[PATCH v2] firmware: ti_sci: Always request response from firmware

2019-05-28 Thread Andrew F. Davis
firmware. Fixes: aa276781a64a ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol") Signed-off-by: Andrew F. Davis Acked-by: Nishanth Menon Tested-by: Alejandro Hernandez --- Changes from v1: - Rebased on v5.2-rc2 drivers/firmware/ti_sci.c | 8 --

Re: [PATCH v3 2/2] RISC-V: sifive_l2_cache: Add L2 cache controller driver for SiFive SoCs

2019-05-07 Thread Andrew F. Davis
On 5/7/19 2:48 AM, Yash Shah wrote: > On Mon, May 6, 2019 at 5:48 PM Andrew F. Davis wrote: >> >> On 5/6/19 6:48 AM, Yash Shah wrote: >>> The driver currently supports only SiFive FU540-C000 platform. >>> >>> The initial version of L2 cache controller dr

Re: [PATCH v3 2/2] RISC-V: sifive_l2_cache: Add L2 cache controller driver for SiFive SoCs

2019-05-06 Thread Andrew F. Davis
On 5/6/19 6:48 AM, Yash Shah wrote: > The driver currently supports only SiFive FU540-C000 platform. > > The initial version of L2 cache controller driver includes: > - Initial configuration reporting at boot up. > - Support for ECC related functionality. > > Signed-off-by: Yash Shah > --- > ar

Re: [PATCH v2 2/2] RISC-V: sifive_l2_cache: Add L2 cache controller driver for SiFive SoCs

2019-05-02 Thread Andrew F. Davis
On 5/2/19 6:34 AM, Yash Shah wrote: > The driver currently supports only SiFive FU540-C000 platform. > > The initial version of L2 cache controller driver includes: > - Initial configuration reporting at boot up. > - Support for ECC related functionality. > > Signed-off-by: Yash Shah > --- > ar

[PATCH] firmware: ti_sci: Always request response from firmware

2019-04-29 Thread Andrew F. Davis
firmware. Fixes: aa276781a64a ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol") Signed-off-by: Andrew F. Davis Acked-by: Nishanth Menon Tested-by: Alejandro Hernandez --- drivers/firmware/ti_sci.c | 8 1 file changed, 4 insertions(+), 4

[PATCH v4 1/2] ASoC: tlv320aic31xx: Add headphone/headset detection

2019-04-01 Thread Andrew F. Davis
by sound card platform code until CODEC outputs to jack mappings can be defined generically. Signed-off-by: Andrew F. Davis --- Changes from v3: - Rebase on broonie/for-next sound/soc/codecs/tlv320aic31xx.c | 48 +++- sound/soc/codecs/tlv320aic31xx.h | 11 2

[PATCH v4 2/2] ASoC: tlv320aic31xx: Add button press detection

2019-04-01 Thread Andrew F. Davis
This device can optionally detect headset or microphone button presses. Add support for this by passing this event to the jack layer. Signed-off-by: Andrew F. Davis --- Changes from v3: - Rebase on broonie/for-next sound/soc/codecs/tlv320aic31xx.c | 17 +++-- sound/soc/codecs

[PATCH 3/4] ARM: dts: imx6qdl: Use new CODEC reset pin name

2019-03-29 Thread Andrew F. Davis
The correct DT property for specifying a GPIO used for reset is "reset-gpios", the driver now accepts this name, use it here. Signed-off-by: Andrew F. Davis --- arch/arm/boot/dts/imx6qdl-var-dart.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/d

[PATCH 4/4] ARM: dts: omap2420-n810: Use new CODEC reset pin name

2019-03-29 Thread Andrew F. Davis
The correct DT property for specifying a GPIO used for reset is "reset-gpios", the driver now accepts this name, use it here. Signed-off-by: Andrew F. Davis --- arch/arm/boot/dts/omap2420-n810.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dt

[PATCH 2/4] ARM: dts: imx: Use new CODEC reset pin name

2019-03-29 Thread Andrew F. Davis
The correct DT property for specifying a GPIO used for reset is "reset-gpios", the driver now accepts this name, use it here. Signed-off-by: Andrew F. Davis --- arch/arm/boot/dts/imx6qdl-gw5903.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/d

[PATCH 1/4] ARM: dts: imx6: RDU2: Use new CODEC reset pin name

2019-03-29 Thread Andrew F. Davis
d polarity. Switch polarity in DT to the currently assumed one, this way when the driver changes the behavior will not change. Signed-off-by: Andrew F. Davis --- arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/imx6qd

[PATCH 4/5] ARM: OMAP: Wakeupgen: AM43xx HS devices should save context like non-HS

2019-03-29 Thread Andrew F. Davis
Unlike some previous generation devices, AM43xx HS IRQ and Wakegen context is handled by the ROM for us, and no secure service call is needed or supported. Non-GP AM43xx devices should take the same path as GP. Signed-off-by: Andrew F. Davis --- arch/arm/mach-omap2/omap-wakeupgen.c | 4 ++-- 1

[PATCH 2/5] ARM: dts: am43xx-epos-evm: Keep DCDC3 regulator on in suspend to memory

2019-03-29 Thread Andrew F. Davis
From: Mike Erdahl When going to suspend to ram mode (or rtc-only mode), the DDR regulator must be told to stay on, else this rail will go down when the PMIC_EN signal is deasserted. Signed-off-by: Mike Erdahl Signed-off-by: Andrew F. Davis --- arch/arm/boot/dts/am43x-epos-evm.dts | 6

[PATCH 3/5] ARM: dts: am43xx-epos-evm: Add matrix keypad as wakeup source

2019-03-29 Thread Andrew F. Davis
Mark matrix-keypad as a wakeup source. Signed-off-by: Andrew F. Davis --- arch/arm/boot/dts/am43x-epos-evm.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts index 606b848d809f..9b8b132b04e1 100644 --- a/arch/arm

[PATCH 1/5] ARM: dts: am43xx-epos-evm: Keep DCDC5 and DCDC6 always on

2019-03-29 Thread Andrew F. Davis
From: Kabir Sahane These regulator outputs are needed even in deep sleep modes to prevent low-voltage detection events. Make these always ON to avoid this. Signed-off-by: Kabir Sahane Signed-off-by: Andrew F. Davis --- arch/arm/boot/dts/am43x-epos-evm.dts | 4 1 file changed, 4

[PATCH 5/5] ARM: OMAP2+: pm33xx-core: Do not Turn OFF CEFUSE as PPA may be using it

2019-03-29 Thread Andrew F. Davis
From: Kabir Sahane This area is used to store keys by HSPPA in case of AM438x SOC. Leave it active. Signed-off-by: Kabir Sahane Signed-off-by: Andrew F. Davis --- arch/arm/mach-omap2/pm33xx-core.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-omap2

[PATCH v3 1/2] ASoC: tlv320aic31xx: Add headphone/headset detection

2019-03-29 Thread Andrew F. Davis
by sound card platform code until CODEC outputs to jack mappings can be defined generically. Signed-off-by: Andrew F. Davis --- Changes from v1: - Rebase Changes from v2: - Rebase sound/soc/codecs/tlv320aic31xx.c | 48 +++- sound/soc/codecs/tlv320aic31xx.h | 11

[PATCH v3 2/2] ASoC: tlv320aic31xx: Add button press detection

2019-03-29 Thread Andrew F. Davis
This device can optionally detect headset or microphone button presses. Add support for this by passing this event to the jack layer. Signed-off-by: Andrew F. Davis --- Changes from v1: - Rebase Changes from v2: - Rebase sound/soc/codecs/tlv320aic31xx.c | 17 +++-- sound/soc

Re: [PATCH v3 4/5] phy: ti: Add a new SERDES driver for TI's AM654x SoC

2019-03-25 Thread Andrew F. Davis
On 3/25/19 3:08 AM, Kishon Vijay Abraham I wrote: > Add a new SERDES driver for TI's AM654x SoC which configures > the SERDES only for PCIe. Support fo USB3 will be added later. > > SERDES in am654x has three input clocks (left input, externel reference > clock and right input) and two output cloc

Re: [RFC][PATCH 2/5 v2] dma-buf: heaps: Add heap helpers

2019-03-19 Thread Andrew F. Davis
On 3/15/19 4:06 AM, Christoph Hellwig wrote: >> +ret = remap_pfn_range(vma, addr, page_to_pfn(page), len, >> + vma->vm_page_prot); > > So the same chunk could be mapped to userspace and vmap, and later on > also DMA mapped. Who is going to take care of

Re: [RFC][PATCH 1/5 v2] dma-buf: Add dma-buf heaps framework

2019-03-06 Thread Andrew F. Davis
On 3/6/19 1:03 PM, John Stultz wrote: > On Wed, Mar 6, 2019 at 10:18 AM Andrew F. Davis wrote: >> >> On 3/5/19 2:54 PM, John Stultz wrote: >>> From: "Andrew F. Davis" >>> >>> This framework allows a unified userspace interface for dma-buf &

Re: [RFC][PATCH 5/5 v2] kselftests: Add dma-heap test

2019-03-06 Thread Andrew F. Davis
On 3/6/19 12:19 PM, John Stultz wrote: > On Wed, Mar 6, 2019 at 10:15 AM Andrew F. Davis wrote: >> >> On 3/6/19 10:14 AM, Benjamin Gaignard wrote: >>> Le mar. 5 mars 2019 à 21:54, John Stultz a écrit : >>>> >>>> Add very trivial allocation test fo

Re: [RFC][PATCH 5/5 v2] kselftests: Add dma-heap test

2019-03-06 Thread Andrew F. Davis
ott >> Cc: Benjamin Gaignard >> Cc: Greg KH >> Cc: Sumit Semwal >> Cc: Liam Mark >> Cc: Brian Starkey >> Cc: Andrew F. Davis >> Cc: Chenbo Feng >> Cc: Alistair Strachan >> Cc: dri-de...@lists.freedesktop.org >> Signed-off-by: John Stu

Re: [RFC][PATCH 1/5 v2] dma-buf: Add dma-buf heaps framework

2019-03-06 Thread Andrew F. Davis
On 3/5/19 2:54 PM, John Stultz wrote: > From: "Andrew F. Davis" > > This framework allows a unified userspace interface for dma-buf > exporters, allowing userland to allocate specific types of > memory for use in dma-buf sharing. > > Each heap is given its ow

Re: [PATCH] regulator: tps65086: Fix tps65086_ldoa1_ranges for selector 0xB

2019-03-04 Thread Andrew F. Davis
l Lin > --- > Hi Steven and Andrew, > I don't have this h/w to test. Can you help to verify it? > I'll dig one of these out for testing, I'll report back here if something is wrong, but for now you are correct according to the datasheet so: Acked-by: Andrew F.

Re: [PATCH v2 2/2] ASoC: codecs: pcm186x: Fix energysense SLEEP bit

2019-02-19 Thread Andrew F. Davis
d if reversed, I wonder if the SLEEP bit is really doing anything here. Can investigate later, for this patch: Acked-by: Andrew F. Davis > Signed-off-by: Codrin Ciubotariu > --- > > Changes in v2: > - none; > > sound/soc/codecs/pcm186x.c | 6 +++--- > 1 file changed,

Re: [PATCH v2 1/2] ASoC: codecs: pcm186x: fix wrong usage of DECLARE_TLV_DB_SCALE()

2019-02-19 Thread Andrew F. Davis
On 2/19/19 10:29 AM, codrin.ciubota...@microchip.com wrote: > From: Codrin Ciubotariu > > According to DS, the gain is between -12 dB and 40 dB, with a 0.5 dB step. > Tested on pcm1863. > > Signed-off-by: Codrin Ciubotariu > --- Acked-by: Andrew F. Davis > > Chan

Re: [PATCH] bq27x00: use cached flags

2019-02-19 Thread Andrew F. Davis
On 2/18/19 12:59 AM, Arthur Demchenkov wrote: > The flags were just read by bq27xxx_battery_update(), > no need to read them again. > > Signed-off-by: Arthur Demchenkov > --- Nothing obviously wrong with this patch so: Reviewed-by: Andrew F. Davis At this point we have W1 r

Re: [PATCH v2] staging: android: ion: Allocate from heap ID directly without mask

2019-02-15 Thread Andrew F. Davis
On 2/15/19 1:58 PM, John Stultz wrote: > On Fri, Feb 15, 2019 at 11:22 AM Andrew F. Davis wrote: >> >> On 2/15/19 1:01 PM, John Stultz wrote: >>> On Fri, Feb 15, 2019 at 2:51 AM Brian Starkey wrote: >>>> On Thu, Feb 14, 2019 at 09:38:29AM -0800, John Stultz wr

Re: [PATCH v2] staging: android: ion: Allocate from heap ID directly without mask

2019-02-15 Thread Andrew F. Davis
On 2/15/19 1:01 PM, John Stultz wrote: > On Fri, Feb 15, 2019 at 2:51 AM Brian Starkey wrote: >> >> Hi John, >> >> On Thu, Feb 14, 2019 at 09:38:29AM -0800, John Stultz wrote: >>> >> [snip] >> >>> Some thoughts, as this ABI break has the potential to be pretty painful. >>> >>> 1) Unfortunately, th

Re: [PATCH v2 14/14] rpmsg: pru: add a PRU RPMsg driver

2019-02-04 Thread Andrew F. Davis
On 2/4/19 8:22 AM, Roger Quadros wrote: > From: Jason Reeder > [...] > +/* .name matches on RPMsg Channels and causes a probe */ > +static const struct rpmsg_device_id rpmsg_driver_pru_id_table[] = { > + { .name = "rpmsg-pru" }, > + { }, > +}; > +MODULE_DEVICE_TABLE(rpmsg, rpmsg_driver_

Re: [PATCH v2 06/14] remoteproc: add page lookup for TI PRU to ELF loader

2019-02-04 Thread Andrew F. Davis
On 2/4/19 8:22 AM, Roger Quadros wrote: > From: David Lechner > > This adds a special handler to the default remoteproc ELF firmware > loader that looks up the memory map on TI PRU firmware files. > > These processors have multiple memory maps that share the same address > space, so we need to k

Re: [PATCH v2 04/14] irqchip: pruss: Add a PRUSS irqchip driver for PRUSS interrupts

2019-02-04 Thread Andrew F. Davis
On 2/4/19 8:22 AM, Roger Quadros wrote: > From: "Andrew F. Davis" > [...] > +static const struct pruss_intc_match_data am437x_pruss_intc_data = { > + .no_host7_intr = true, Like done for the PRUSS driver with 'has_no_sharedram' becoming a DT flag the same c

Re: [PATCH v2 02/14] soc: ti: pruss: Add a platform driver for PRUSS in TI SoCs

2019-02-04 Thread Andrew F. Davis
) allow the > client drivers to set MII_RT event enable/disable and > XFR (XIN XOUT) enable/disable respectively. > > Signed-off-by: Suman Anna > Signed-off-by: Keerthy > Signed-off-by: Andrew F. Davis > Signed-off-by: Tero Kristo > Signed-off-by: Roger Quadros

Re: [PATCH 2/4] staging: android: ion: Restrict cache maintenance to dma mapped memory

2019-01-30 Thread Andrew F. Davis
On 1/29/19 5:44 PM, Liam Mark wrote: > On Fri, 18 Jan 2019, Liam Mark wrote: > >> On Fri, 18 Jan 2019, Andrew F. Davis wrote: >> >>> On 1/18/19 12:37 PM, Liam Mark wrote: >>>> The ION begin_cpu_access and end_cpu_access functions use the >>>> dma

[PATCH v2] staging: android: ion: Allocate from heap ID directly without mask

2019-01-28 Thread Andrew F. Davis
;) Signed-off-by: Andrew F. Davis --- This also means we don't need to store the available heaps in a plist, we only operation we care about is lookup, so a better data structure should be chosen at some point, regular list or xarray maybe? This is base on -next as to be on top of the

Re: [PATCH] staging: android: ion: Allocate from heap ID directly without mask

2019-01-24 Thread Andrew F. Davis
On 1/24/19 9:24 AM, Brian Starkey wrote: > Hi Andrew, > > On Wed, Jan 23, 2019 at 01:28:35PM -0600, Andrew F. Davis wrote: >> Previously the heap to allocate from was selected by a mask of allowed >> heap types. This may have been done as a primitive form of constraint >&

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-24 Thread Andrew F. Davis
On 1/23/19 11:11 AM, Brian Starkey wrote: > Hi Andrew, > > On Wed, Jan 23, 2019 at 10:51:24AM -0600, Andrew F. Davis wrote: >> On 1/22/19 11:33 AM, Sumit Semwal wrote: >>> Hello everyone, >>> >>> Sincere apologies for chiming in a bit late here,

[PATCH] staging: android: ion: Allocate from heap ID directly without mask

2019-01-23 Thread Andrew F. Davis
ned-off-by: Andrew F. Davis --- This also means we don't need to store the available heaps in a plist, we only operation we care about is lookup, so a better data structure should be chosen at some point, regular list or xarray maybe? This is base on -next as to be on top of the other ta

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-23 Thread Andrew F. Davis
On 1/22/19 9:23 PM, Sumit Semwal wrote: > Hello everyone, > > (Thanks to Dan for letting me know my last email got corrupted :/ - > resending it here) > Hmm, this one seems a bit messed up also (Thunderbird doesn't seem to like it at least). [snip] > - from dma-buf PoV, ION is an exporter of d

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-23 Thread Andrew F. Davis
ittle different in each email, so I'd like to respond to bits of both, I'll fix up the formatting. > Also, adding Daniel Vetter to the mix, since he has been one of the > core guys who shaped up dma-buf as it is today. > > On Tue, 22 Jan 2019 at 02:51, Andrew F. Davis w

Re: [PATCH 3/4] dma-buf: add support for mapping with dma mapping attributes

2019-01-22 Thread Andrew F. Davis
On 1/21/19 4:12 PM, Liam Mark wrote: > On Mon, 21 Jan 2019, Christoph Hellwig wrote: > >> On Mon, Jan 21, 2019 at 11:44:10AM -0800, Liam Mark wrote: >>> The main use case is for allowing clients to pass in >>> DMA_ATTR_SKIP_CPU_SYNC in order to skip the default cache maintenance >>> which happen

Re: [PATCH 3/4] dma-buf: add support for mapping with dma mapping attributes

2019-01-22 Thread Andrew F. Davis
On 1/21/19 4:18 PM, Liam Mark wrote: > On Mon, 21 Jan 2019, Andrew F. Davis wrote: > >> On 1/21/19 2:20 PM, Liam Mark wrote: >>> On Mon, 21 Jan 2019, Andrew F. Davis wrote: >>> >>>> On 1/21/19 1:44 PM, Liam Mark wrote: >>>>> On Mon, 21 Ja

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-21 Thread Andrew F. Davis
On 1/21/19 5:22 AM, Brian Starkey wrote: > Hi, > > Sorry for being a bit sporadic on this. I was out travelling last week > with little time for email. > > On Fri, Jan 18, 2019 at 11:16:31AM -0600, Andrew F. Davis wrote: >> On 1/17/19 7:11 PM, Liam Mark wrote: >>&

Re: [PATCH 3/4] dma-buf: add support for mapping with dma mapping attributes

2019-01-21 Thread Andrew F. Davis
On 1/21/19 2:20 PM, Liam Mark wrote: > On Mon, 21 Jan 2019, Andrew F. Davis wrote: > >> On 1/21/19 1:44 PM, Liam Mark wrote: >>> On Mon, 21 Jan 2019, Christoph Hellwig wrote: >>> >>>> On Sat, Jan 19, 2019 at 08:50:41AM -0800, Laura Abbott wrote: >&

Re: [PATCH 3/4] dma-buf: add support for mapping with dma mapping attributes

2019-01-21 Thread Andrew F. Davis
On 1/21/19 1:44 PM, Liam Mark wrote: > On Mon, 21 Jan 2019, Christoph Hellwig wrote: > >> On Sat, Jan 19, 2019 at 08:50:41AM -0800, Laura Abbott wrote: And who is going to decide which ones to pass? And who documents which ones are safe? I'd much rather have explicit, well doc

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-21 Thread Andrew F. Davis
On 1/18/19 3:43 PM, Liam Mark wrote: > On Fri, 18 Jan 2019, Andrew F. Davis wrote: > >> On 1/17/19 7:04 PM, Liam Mark wrote: >>> On Thu, 17 Jan 2019, Andrew F. Davis wrote: >>> >>>> On 1/16/19 4:48 PM, Liam Mark wrote: >>>>> On Wed, 16 Jan

Re: [PATCH 00/14] Misc ION cleanups and adding unmapped heap

2019-01-21 Thread Andrew F. Davis
On 1/18/19 2:19 PM, Laura Abbott wrote: > On 1/16/19 8:05 AM, Andrew F. Davis wrote: >> On 1/15/19 12:58 PM, Laura Abbott wrote: >>> On 1/15/19 9:47 AM, Andrew F. Davis wrote: >>>> On 1/14/19 8:39 PM, Laura Abbott wrote: >>>>> On 1/11/19 10:0

Re: [PATCH 11/14] staging: android: ion: Allow heap name to be null

2019-01-21 Thread Andrew F. Davis
On 1/18/19 1:53 PM, Laura Abbott wrote: > On 1/16/19 9:12 AM, Andrew F. Davis wrote: >> On 1/16/19 9:28 AM, Brian Starkey wrote: >>> Hi Andrew, >>> >>> On Fri, Jan 11, 2019 at 12:05:20PM -0600, Andrew F. Davis wrote: >>>> The heap name can be used f

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-18 Thread Andrew F. Davis
On 1/18/19 2:31 PM, Laura Abbott wrote: > On 1/17/19 8:13 AM, Andrew F. Davis wrote: >> On 1/16/19 4:48 PM, Liam Mark wrote: >>> On Wed, 16 Jan 2019, Andrew F. Davis wrote: >>> >>>> On 1/15/19 1:05 PM, Laura Abbott wrote: >>>>> On 1/15/19 10:38

Re: [PATCH 2/4] staging: android: ion: Restrict cache maintenance to dma mapped memory

2019-01-18 Thread Andrew F. Davis
On 1/18/19 12:37 PM, Liam Mark wrote: > The ION begin_cpu_access and end_cpu_access functions use the > dma_sync_sg_for_cpu and dma_sync_sg_for_device APIs to perform cache > maintenance. > > Currently it is possible to apply cache maintenance, via the > begin_cpu_access and end_cpu_access APIs, t

Re: [PATCH 1/4] staging: android: ion: Support cpu access during dma_buf_detach

2019-01-18 Thread Andrew F. Davis
a_sync_sg_for_cpu > The window for this seems really small, but it does seem technically possible, good find. for what it's worth: Acked-by: Andrew F. Davis > Fix this by getting the ion_buffer lock before freeing the sg table memory. > > Fixes: 2a55e7b5e544 ("staging: andr

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-18 Thread Andrew F. Davis
On 1/17/19 7:11 PM, Liam Mark wrote: > On Thu, 17 Jan 2019, Andrew F. Davis wrote: > >> On 1/16/19 4:54 PM, Liam Mark wrote: >>> On Wed, 16 Jan 2019, Andrew F. Davis wrote: >>> >>>> On 1/16/19 9:19 AM, Brian Starkey wrote: >>>>> Hi :-) >

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-18 Thread Andrew F. Davis
On 1/17/19 7:04 PM, Liam Mark wrote: > On Thu, 17 Jan 2019, Andrew F. Davis wrote: > >> On 1/16/19 4:48 PM, Liam Mark wrote: >>> On Wed, 16 Jan 2019, Andrew F. Davis wrote: >>> >>>> On 1/15/19 1:05 PM, Laura Abbott wrote: >>>>> On 1/15/19

Re: [PATCH 12/14] staging: android: ion: Declare helpers for carveout and chunk heaps

2019-01-18 Thread Andrew F. Davis
On 1/18/19 3:59 AM, Greg Kroah-Hartman wrote: > On Fri, Jan 11, 2019 at 12:05:21PM -0600, Andrew F. Davis wrote: >> When enabled the helpers functions for creating carveout and chunk heaps >> should have declarations in the ION header. > > Why? No one calls these from what I

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-17 Thread Andrew F. Davis
On 1/16/19 4:54 PM, Liam Mark wrote: > On Wed, 16 Jan 2019, Andrew F. Davis wrote: > >> On 1/16/19 9:19 AM, Brian Starkey wrote: >>> Hi :-) >>> >>> On Tue, Jan 15, 2019 at 12:40:16PM -0600, Andrew F. Davis wrote: >>>> On 1/15/19 12:38 PM, And

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-17 Thread Andrew F. Davis
On 1/16/19 4:48 PM, Liam Mark wrote: > On Wed, 16 Jan 2019, Andrew F. Davis wrote: > >> On 1/15/19 1:05 PM, Laura Abbott wrote: >>> On 1/15/19 10:38 AM, Andrew F. Davis wrote: >>>> On 1/15/19 11:45 AM, Liam Mark wrote: >>>>> On Tue, 15 Jan 2019, A

Re: [PATCH 11/14] staging: android: ion: Allow heap name to be null

2019-01-16 Thread Andrew F. Davis
On 1/16/19 9:28 AM, Brian Starkey wrote: > Hi Andrew, > > On Fri, Jan 11, 2019 at 12:05:20PM -0600, Andrew F. Davis wrote: >> The heap name can be used for debugging but otherwise does not seem >> to be required and no other part of the code will fail if left NULL >>

  1   2   3   4   5   6   7   8   9   >