Re: [PATCH] powerpc: powernv: Remove unneeded variable: "rc"

2021-03-26 Thread Andrew Donnellan
On 26/3/21 10:53 pm, dingsen...@163.com wrote: From: dingsenjie Remove unneeded variable: "rc". Signed-off-by: dingsenjie This looks obviously correct and doesn't raise any checkpatch warnings. Reviewed-by: Andrew Donnellan -- Andrew Donnellan OzLabs,

Re: [PATCH] cxl: Fix couple of spellings

2021-03-22 Thread Andrew Donnellan
On 22/3/21 1:33 pm, Bhaskar Chowdhury wrote: s/filesytem/filesystem/ s/symantics/semantics/ Signed-off-by: Bhaskar Chowdhury Acked-by: Andrew Donnellan --- drivers/misc/cxl/context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/cxl/context.c b

Re: [PATCH] cxl: don't manipulate the mm.mm_users field directly

2021-03-11 Thread Andrew Donnellan
On 11/3/21 4:44 am, Laurent Dufour wrote: It is better to rely on the API provided by the MM layer instead of directly manipulating the mm_users field. Signed-off-by: Laurent Dufour LGTM, thanks for picking this up Acked-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL

Re: linux-next: Fixes tag needs some work in the jc_docs tree

2021-02-25 Thread Andrew Donnellan
xing" the changlog on that commit, which included the full ID. Obviously, counting to 12 is a challenging task for a slow guy like me...:) No, no, my local tree tells me that *I* made that tag by hand and failed to count properly... sorry for the noise! -- Andrew Donnellan

Re: [PATCH] cxl: Simplify bool conversion

2021-01-31 Thread Andrew Donnellan
On 29/1/21 7:25 pm, Yang Li wrote: Fix the following coccicheck warning: ./drivers/misc/cxl/sysfs.c:181:48-53: WARNING: conversion to bool not needed here Reported-by: Abaci Robot Signed-off-by: Yang Li Reviewed-by: Andrew Donnellan Thanks! --- drivers/misc/cxl/sysfs.c | 2 +- 1 file

Re: [PATCH 01/13] powerpc/powernv: remove get_cxl_module

2021-01-21 Thread Andrew Donnellan
uot;). Thanks for picking this up. Reviewed-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH v2 -next] misc: ocxl: use DEFINE_MUTEX() for mutex lock

2021-01-05 Thread Andrew Donnellan
On 25/12/20 12:24 am, Zheng Yongjun wrote: mutex lock can be initialized automatically with DEFINE_MUTEX() rather than explicitly calling mutex_init(). Signed-off-by: Zheng Yongjun Acked-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com

Re: [ANNOUNCE] [CFP] Call for Sessions - linux.conf.au Online 2021 Kernel Miniconf

2021-01-02 Thread Andrew Donnellan
On 30/11/20 1:45 pm, Andrew Donnellan wrote: LCA2021 Kernel Miniconf - Online - 2021-01-23 - LCA Kernel Miniconf submissions now open! (Ever wanted to present at LCA, but couldn't justify flying to Australia? Well, 2021 is your chance - we

Re: [PATCH] powerpc/rtas: fix typo of ibm,open-errinjct in rtas filter

2020-12-10 Thread Andrew Donnellan
tching this! Acked-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [ANNOUNCE] [CFP] Call for Sessions - linux.conf.au Online 2021 Kernel Miniconf

2020-11-29 Thread Andrew Donnellan
On 30/11/20 2:46 pm, Andrew Donnellan wrote: On 30/11/20 2:38 pm, CRISTIAN ANDRES VARGAS GONZALEZ wrote:  > More info: https://lca-kernel.ozlabs.org/2021-cfs.html <https://lca-kernel.ozlabs.org/2021-cfs.html> Hi, this link no working. :c Ugh, let me fix my TLS setup. In the mean

Re: [ANNOUNCE] [CFP] Call for Sessions - linux.conf.au Online 2021 Kernel Miniconf

2020-11-29 Thread Andrew Donnellan
ttp://lca-kernel.ozlabs.org/2021-cfs.html Thanks for reporting! Andrew -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

[ANNOUNCE] [CFP] Call for Sessions - linux.conf.au Online 2021 Kernel Miniconf

2020-11-29 Thread Andrew Donnellan
of all levels of experience in the kernel community, covering a broad range of topics. The focus of the miniconf will primarily be on Linux, however non-Linux talks of sufficient interest to a primarily Linux audience will be considered. -- Andrew Donnellan OzLabs,

Re: [PATCH] powerpc/powernv/sriov: fix unsigned int win compared to less than zero

2020-11-10 Thread Andrew Donnellan
ion compared with zero: win < 0 Reported-by: Tosk Robot Signed-off-by: Kaixu Xia This seems like the right fix, the value assigned to win can indeed be -1 so it should be signed. Thanks for sending the patch. Reviewed-by: Andrew Donnellan --- arch/powerpc/platforms/powernv/pci-sriov

Re: [PATCH v2 2/2] misc: ocxl: config: Rename function attribute description

2020-11-02 Thread Andrew Donnellan
7;device' description in 'get_function_0' Cc: Frederic Barrat Cc: Andrew Donnellan Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: linuxppc-...@lists.ozlabs.org Signed-off-by: Lee Jones Thanks! Acked-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra a...

Re: [PATCH -next] ocxl: simplify the return expression of free_function_dev()

2020-09-27 Thread Andrew Donnellan
On 21/9/20 11:10 pm, Qinglang Miao wrote: Simplify the return expression. Signed-off-by: Qinglang Miao Looks good Acked-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH] ocxl: Replace HTTP links with HTTPS ones

2020-07-13 Thread Andrew Donnellan
limov Thanks. Acked-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH v2 3/3] misc: cxl: flash: Remove unused variable 'drc_index'

2020-07-09 Thread Andrew Donnellan
] 178 | __be32 *data, drc_index, phandle; | ^ Cc: Frederic Barrat Cc: Andrew Donnellan Cc: linuxppc-...@lists.ozlabs.org Signed-off-by: Lee Jones Acked-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH 3/3] misc: cxl: flash: Remove unused variable 'drc_index'

2020-07-08 Thread Andrew Donnellan
] 178 | __be32 *data, drc_index, phandle; | ^ Cc: Frederic Barrat Cc: Andrew Donnellan Cc: linuxppc-...@lists.ozlabs.org Signed-off-by: Lee Jones Acked-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH] cxl: Fix kobject memleak

2020-06-03 Thread Andrew Donnellan
On 3/6/20 9:57 pm, wanghai (M) wrote: kfree(cr) can be called when kobject_put()-->kobject_release()-->kobject_cleanup()-->kobj_type->release() is called.  The kobj_type here is afu_config_record_type Of course, I missed that. In that case Acked-by: Andrew Donnellan Thanks

Re: [PATCH] cxl: Fix kobject memleak

2020-06-03 Thread Andrew Donnellan
r1: so it falls through? -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH v3 06/15] powerpc/32: prepare for CONFIG_VMAP_STACK

2019-10-18 Thread Andrew Donnellan
On 18/10/19 5:46 pm, Christophe Leroy wrote: Le 17/10/2019 à 09:36, Andrew Donnellan a écrit : On 10/9/19 7:16 pm, Christophe Leroy wrote: +#if defined(CONFIG_VMAP_STACK) && CONFIG_THREAD_SHIFT < PAGE_SHIFT +#define THREAD_SHIFT    PAGE_SHIFT +#else   #define T

Re: [PATCH v3 06/15] powerpc/32: prepare for CONFIG_VMAP_STACK

2019-10-17 Thread Andrew Donnellan
Looking at 64-bit book3s: with 64K pages, this results in a THREAD_SIZE that's too large for immediate mode arithmetic operations, which is annoying. Hmm. -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

[ANNOUNCE] Call for Sessions - linux.conf.au 2020 Kernel Miniconf

2019-10-16 Thread Andrew Donnellan
/2020-cfs.html ** -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH 1/5] powerpc: Add OPAL calls for LPC memory alloc/release

2019-09-25 Thread Andrew Donnellan
On 17/9/19 3:42 am, Alastair D'Silva wrote: From: Alastair D'Silva Add OPAL calls for LPC memory alloc/release Signed-off-by: Alastair D'Silva This needs rebasing, but apart from that. Acked-by: Andrew Donnellan --- arch/powerpc/include/asm/opal-api.h| 4 +++-

Re: [PATCH] ocxl: Use the correct style for SPDX License Identifier

2019-09-21 Thread Andrew Donnellan
++ style should be used) Changes made by using a script provided by Joe Perches here: https://lkml.org/lkml/2019/2/7/46. Suggested-by: Joe Perches Signed-off-by: Nishad Kamdar Thanks. Acked-by: Andrew Donnellan --- drivers/misc/ocxl/ocxl_internal.h | 2 +- drivers/misc/ocxl/trace.h

Re: [PATCH 22/39] docs: ocxl.rst: add it to the uAPI book

2019-06-30 Thread Andrew Donnellan
On 28/6/19 10:30 pm, Mauro Carvalho Chehab wrote: The content of this file is user-faced. Signed-off-by: Mauro Carvalho Chehab Acked-by: Andrew Donnellan --- Documentation/{ => userspace-api}/accelerators/ocxl.rst | 2 -- Documentation/userspace-api/index.rst

Re: [PATCH v2] ocxl: Allow contexts to be attached with a NULL mm

2019-06-20 Thread Andrew Donnellan
if (pe_data->mm) { + mm_context_remove_copro(pe_data->mm); + mmdrop(pe_data->mm); + } kfree_rcu(pe_data, rcu); } unlock: -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH] ocxl: Allow contexts to be attached with a NULL mm

2019-06-17 Thread Andrew Donnellan
_remove_copro(pe_data->mm); - mmdrop(pe_data->mm); + if (pe_data->mm) { + mm_context_remove_copro(pe_data->mm); + mmdrop(pe_data->mm); + } kfree_rcu(pe_data, rcu); } unlock: -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH] ocxl: do not use C++ style comments in uapi header

2019-06-04 Thread Andrew Donnellan
/1083801/ If you choose to proceed with this patch: Acked-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra a...@linux.ibm.com IBM Australia Limited

Re: [PATCH v4 1/7] ocxl: Split pci.c

2019-04-29 Thread Andrew Donnellan
ic on the card (CFG, TLX) won't be reset, so -* there's no guarantee that it will be enough. -*/ - rc = ocxl_config_read_function(dev, &fn->config); - if (rc) - return rc; - - rc = set_function_device(fn, dev); - if (rc) - return rc; - - rc = assign_function_actag(fn); - if (rc) - return rc; - - rc = set_function_pasid(fn); - if (rc) - return rc; - - rc = ocxl_link_setup(dev, 0, &fn->link); - if (rc) - return rc; - - rc = ocxl_config_set_TL(dev, fn->config.dvsec_tl_pos); - if (rc) { - ocxl_link_release(dev, fn->link); - return rc; - } - return 0; -} - -static void deconfigure_function(struct ocxl_fn *fn) -{ - struct pci_dev *dev = to_pci_dev(fn->dev.parent); - - ocxl_link_release(dev, fn->link); - pci_disable_device(dev); -} - -static struct ocxl_fn *init_function(struct pci_dev *dev) -{ - struct ocxl_fn *fn; - int rc; - - fn = alloc_function(dev); - if (!fn) - return ERR_PTR(-ENOMEM); - - rc = configure_function(fn, dev); - if (rc) { - free_function(fn); - return ERR_PTR(rc); - } - - rc = device_register(&fn->dev); - if (rc) { - deconfigure_function(fn); - put_device(&fn->dev); - return ERR_PTR(rc); - } - return fn; -} - -static void remove_function(struct ocxl_fn *fn) -{ - deconfigure_function(fn); - device_unregister(&fn->dev); -} - static int ocxl_probe(struct pci_dev *dev, const struct pci_device_id *id) { int rc, afu_count = 0; -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH v3 3/5] powerpc: Use the correct style for SPDX License Identifier

2019-04-16 Thread Andrew Donnellan
ixing. Acked-by: Andrew Donnellan arch/powerpc/include/asm/pnv-ocxl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/include/asm/pnv-ocxl.h b/arch/powerpc/include/asm/pnv-ocxl.h index 208b5503f4ed..7de82647e761 100644 --- a/arch/powerpc/include/asm/pnv-ocxl.h

Re: [PATCH 5/5] ocxl: Remove some unused exported symbols

2019-03-14 Thread Andrew Donnellan
On 15/3/19 3:49 pm, Andrew Donnellan wrote: On 13/3/19 3:07 pm, Alastair D'Silva wrote: From: Alastair D'Silva Remove some unused exported symbols. Signed-off-by: Alastair D'Silva See comments on v1 Also a couple of sparse warnings at https://openpower.xyz/job/snowpatc

Re: [PATCH 5/5] ocxl: Remove some unused exported symbols

2019-03-14 Thread Andrew Donnellan
d for the process element - */ -int ocxl_link_update_pe(void *link_handle, int pasid, __u16 tid); - /* * Remove a Process Element from the Shared Process Area for a link */ -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 5/5] ocxl: Remove some unused exported symbols

2019-02-28 Thread Andrew Donnellan
t pasid, __u16 tid); + This isn't actually exported, so if you spin a v2 do that separately from this patch or document the change. Otherwise Acked-by: Andrew Donnellan struct ocxl_context *ocxl_context_alloc(void); int ocxl_context_init(struct ocxl_context *ct

Re: [PATCH 4/5] ocxl: Remove superfluous 'extern' from headers

2019-02-27 Thread Andrew Donnellan
On 27/2/19 3:57 pm, Alastair D'Silva wrote: From: Alastair D'Silva The 'extern' keyword adds no value here. Signed-off-by: Alastair D'Silva Acked-by: Andrew Donnellan --- drivers/misc/ocxl/ocxl_internal.h | 54 +++ include/misc/

Re: [PATCH 3/5] ocxl: read_pasid never returns an error, so make it void

2019-02-27 Thread Andrew Donnellan
On 27/2/19 3:57 pm, Alastair D'Silva wrote: From: Alastair D'Silva No need for a return value in read_pasid as it only returns 0. Signed-off-by: Alastair D'Silva Reviewed-by: Greg Kurz Acked-by: Andrew Donnellan --- drivers/misc/ocxl/config.c | 9 ++--- 1

Re: [PATCH 2/5] ocxl: Clean up printf formats

2019-02-27 Thread Andrew Donnellan
On 27/2/19 3:57 pm, Alastair D'Silva wrote: From: Alastair D'Silva Use %# instead of using a literal '0x' Signed-off-by: Alastair D'Silva Not hugely fussed either way, but today I learned about %#... Acked-by: Andrew Donnellan --- drivers/misc/ocxl/config

Re: [PATCH 1/5] ocxl: Rename struct link to ocxl_link

2019-02-27 Thread Andrew Donnellan
On 27/2/19 7:04 pm, Alastair D'Silva wrote: -Original Message- From: Andrew Donnellan Sent: Wednesday, 27 February 2019 6:55 PM To: Alastair D'Silva ; 'Alastair D'Silva' Cc: 'Greg Kurz' ; 'Frederic Barrat' ; 'Arnd Bergmann' ; '

Re: [PATCH 1/5] ocxl: Rename struct link to ocxl_link

2019-02-26 Thread Andrew Donnellan
ocxl_link * rather than void *, and update the function signature for ocxl_link_update_pe() as well. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 1/5] ocxl: Rename struct link to ocxl_link

2019-02-26 Thread Andrew Donnellan
q_alloc); void ocxl_link_free_irq(void *link_handle, int hw_irq) { - struct link *link = (struct link *) link_handle; + struct ocxl_link *link = (struct ocxl_link *) link_handle; pnv_ocxl_free_xive_irq(hw_irq); atomic_inc(&link->irq_available); -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH v2 1/5] drivers/accel: Introduce subsystem

2019-01-26 Thread Andrew Donnellan
he CAPI or OpenCAPI protocol respectively - many of which will be FPGA boards flashed with customer-designed accelerator cores for specific workloads, some will be accelerators using ASICs or using FPGA images supplied by vendors, some will be driven from userspace, others using the cxl/ocxl kernel A

Re: [PATCH 00/15] Habana Labs kernel driver

2019-01-23 Thread Andrew Donnellan
st I set up at linux-accelerat...@lists.ozlabs.org but we haven't really started using... -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH] docs: Bump version to 5.x

2019-01-14 Thread Andrew Donnellan
tell you what this is all about, explain how to install the kernel, and what to do if something goes wrong. @@ -406,3 +406,4 @@ If something goes wrong gdb'ing a non-running kernel currently fails because ``gdb`` (wrongly) disregards the starting offset for which the kernel is co

Re: [ANNOUNCE] Call for Papers - linux.conf.au Kernel Miniconf, Christchurch NZ, 21-25 Jan 2019

2018-12-14 Thread Andrew Donnellan
On 21/10/18 12:10 pm, Andrew Donnellan wrote: The linux.conf.au Kernel Miniconf is happening once again, this time in Christchurch on 22 Jan 2019. *** Submissions close on 2018-12-16, 23:59 AoE, with early submissions (before 2018-11-16, 23:59 AoE) given priority. *** This deadline is in

[ANNOUNCE] Call for Papers - linux.conf.au Kernel Miniconf, Christchurch NZ, 21-25 Jan 2019

2018-10-20 Thread Andrew Donnellan
-cfp.html for full details and the submission form. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [RESEND PATCHv2] misc: cxl: Fix possible null pointer dereference

2018-10-04 Thread Andrew Donnellan
On 4/10/18 3:02 pm, zhong jiang wrote: It is not safe to dereference an object before a null test. It is not needed and just remove them. Ftrace can be used instead. Signed-off-by: zhong jiang Acked-by: Andrew Donnellan --- drivers/misc/cxl/guest.c | 2 -- 1 file changed, 2 deletions

Re: [PATCH] misc: cxl: Move a deference below a NULL test

2018-09-26 Thread Andrew Donnellan
On 26/9/18 9:41 pm, zhong jiang wrote: It is safe to move a deference below a NULL test. Signed-off-by: zhong jiang Thanks for catching this. Acked-by: Andrew Donnellan --- drivers/misc/cxl/guest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc

Re: [PATCH v2 03/17] compat_ioctl: use correct compat_ptr() translation in drivers

2018-09-12 Thread Andrew Donnellan
other architectures, compat_ptr() does not do anything, but using the new generic_compat_ioctl_ptrarg helper makes it more correct in theory, and simplifies the code. Signed-off-by: Arnd Bergmann For cxl: Acked-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel..

Re: [RFC PATCH 1/2] checkpatch: Correctly detect git commit references that span 3 lines

2018-08-06 Thread Andrew Donnellan
I've got some spare time over the next few days and send a v2. Thanks, -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

[RFC PATCH 2/2] checkpatch: Fix commit ID test when "commit" and hash on different lines

2018-08-05 Thread Andrew Donnellan
Signed-off-by: Andrew Donnellan --- RFC because I'm bad at Perl --- scripts/checkpatch.pl | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index aca4d758112a..ae7a54287db7 100755 --- a/sc

[RFC PATCH 1/2] checkpatch: Correctly detect git commit references that span 3 lines

2018-08-05 Thread Andrew Donnellan
the value of the 'copros' counter of the memory context. === checkpatch will return a GIT_COMMIT_ID error even though the reference actually follows the correct format. Fix the GIT_COMMIT_ID test so it can match against a reference that spans 3 lines. Reported-by: Frederic Barrat S

Re: [PATCH] misc: cxl: changed asterisk position

2018-08-05 Thread Andrew Donnellan
On 03/08/18 20:20, Parth Y Shah wrote: Resolved <"foo* bar" should be "foo *bar"> error Signed-off-by: Parth Y Shah Thanks for picking this up. Acked-by: Andrew Donnellan --- drivers/misc/cxl/fault.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [PATCH v5 2/7] powerpc: Use TIDR CPU feature to control TIDR allocation

2018-05-30 Thread Andrew Donnellan
On 11/05/18 16:12, Alastair D'Silva wrote: From: Alastair D'Silva Switch the use of TIDR on it's CPU feature, rather than assuming it is available based on architecture. Signed-off-by: Alastair D'Silva Reviewed-by: Andrew Donnellan -- Andrew Donnellan

Re: [PATCH v2 3/7] powerpc: use task_pid_nr() for TID allocation

2018-04-26 Thread Andrew Donnellan
. Alastair has also confirmed with me that truncating the pid to a u16 should be safe, so therefore: Reviewed-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH v2 5/7] ocxl: Expose the thread_id needed for wait on p9

2018-04-23 Thread Andrew Donnellan
ir D'Silva nitpicks below Acked-by: Andrew Donnellan --- drivers/misc/ocxl/context.c | 5 +++- drivers/misc/ocxl/file.c | 53 +++ drivers/misc/ocxl/link.c | 36 ++ drivers/misc/ocxl/ocxl_internal.h |

Re: [PATCH v2 3/7] powerpc: use task_pid_nr() for TID allocation

2018-04-20 Thread Andrew Donnellan
return rc; - - t->thread.tidr = rc; + t->thread.tidr = (u16)task_pid_nr(t); mtspr(SPRN_TIDR, t->thread.tidr); return 0; -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH v2 6/7] ocxl: Add an IOCTL so userspace knows what CPU features are available

2018-04-20 Thread Andrew Donnellan
On 18/04/18 11:08, Alastair D'Silva wrote: From: Alastair D'Silva In order for a userspace AFU driver to call the Power9 specific OCXL_IOCTL_ENABLE_P9_WAIT, it needs to verify that it can actually make that call. Signed-off-by: Alastair D'Silva Looks good to me Acked-by: A

Re: [PATCH v2 7/7] ocxl: Document new OCXL IOCTLs

2018-04-18 Thread Andrew Donnellan
On 18/04/18 11:08, Alastair D'Silva wrote: From: Alastair D'Silva Signed-off-by: Alastair D'Silva This looks better. Acked-by: Andrew Donnellan --- Documentation/accelerators/ocxl.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/accele

Re: [PATCH v2 2/7] powerpc: Use TIDR CPU feature to control TIDR allocation

2018-04-18 Thread Andrew Donnellan
On 18/04/18 11:08, Alastair D'Silva wrote: From: Alastair D'Silva Switch the use of TIDR on it's CPU feature, rather than assuming it is available based on architecture. Signed-off-by: Alastair D'Silva Reviewed-by: Andrew Donnellan -- Andrew Donnellan

Re: [PATCH v2 1/7] powerpc: Add TIDR CPU feature for Power9

2018-04-18 Thread Andrew Donnellan
On 18/04/18 11:08, Alastair D'Silva wrote: From: Alastair D'Silva This patch adds a CPU feature bit to show whether the CPU has the TIDR register available, enabling as_notify/wait in userspace. Signed-off-by: Alastair D'Silva Per my previous email: Reviewed-by: A

Re: [PATCH] misc: cxl: Change return type to vm_fault_t

2018-04-17 Thread Andrew Donnellan
looks good to me Acked-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 4/7] ocxl: Rename pnv_ocxl_spa_remove_pe to clarify it's action

2018-04-16 Thread Andrew Donnellan
f a similar name. But I don't feel strongly about this at all, so: Acked-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 2/7] powerpc: Use TIDR CPU feature to control TIDR allocation

2018-04-16 Thread Andrew Donnellan
return -EINVAL; if (t != current) -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 1/7] powerpc: Add TIDR CPU feature for Power9

2018-04-16 Thread Andrew Donnellan
th the CPU features code but nothing seems overly wrong... Reviewed-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 7/7] ocxl: Document new OCXL IOCTLs

2018-04-16 Thread Andrew Donnellan
ags which I suppose imply what the correct platform is, but really they're just feature flags? -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 2/2] misc: ocxl: use put_device() instead of device_unregister()

2018-03-12 Thread Andrew Donnellan
On 12/03/18 22:36, Arvind Yadav wrote: if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav This looks right, thanks for picking it up. Acked-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL

Re: [PATCH v3 2/2] ocxl: Document the OCXL_IOCTL_GET_METADATA IOCTL

2018-02-21 Thread Andrew Donnellan
On 22/02/18 15:17, Alastair D'Silva wrote: From: Alastair D'Silva Signed-off-by: Alastair D'Silva Acked-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH v3 1/2] ocxl: Add get_metadata IOCTL to share OCXL information to userspace

2018-02-21 Thread Andrew Donnellan
userspace. Signed-off-by: Alastair D'Silva Acked-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 21/23] gcc-plugins: move GCC version check for PowerPC to Kconfig

2018-02-21 Thread Andrew Donnellan
On 17/02/18 05:38, Masahiro Yamada wrote: For PowerPC, GCC 5.2 is the requirement for GCC plugins. Move the version check to Kconfig, and remove the ugly checker. Signed-off-by: Masahiro Yamada The old checker was as non-ugly as I could make it. :) Acked-by: Andrew Donnellan -- Andrew

Re: [PATCH] ocxl: Add get_metadata IOCTL to share OCXL information to userspace

2018-02-21 Thread Andrew Donnellan
number set. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH] ocxl: Add get_metadata IOCTL to share OCXL information to userspace

2018-02-20 Thread Andrew Donnellan
userspace. Signed-off-by: Alastair D'Silva Seems fine. Acked-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH] ocxl: fix signed comparison with less than zero

2018-01-30 Thread Andrew Donnellan
< 0 Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices") Signed-off-by: Colin Ian King Thanks for picking this up! Acked-by: Andrew Donnellan --- drivers/misc/ocxl/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [PATCH v2 07/13] ocxl: Add AFU interrupt support

2018-01-25 Thread Andrew Donnellan
written! :D -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 02/13] powerpc/powernv: Set correct configuration space size for opencapi devices

2018-01-21 Thread Andrew Donnellan
On 20/01/18 20:52, Michael Ellerman wrote:> On my Power8 PowerVM LPAR: Will fix... -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 04/13] powerpc/powernv: Add platform-specific services for opencapi

2018-01-02 Thread Andrew Donnellan
dev_err(&dev->dev, + "Can't translation xsl interrupt for device\n"); Can't get? -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 06/13] ocxl: Driver code for 'generic' opencapi devices

2018-01-02 Thread Andrew Donnellan
river currently doesn't handle memory attached to the opencapi device. Signed-off-by: Frederic Barrat Signed-off-by: Andrew Donnellan Signed-off-by: Alastair D'Silva A bunch of sparse warnings we should look at. (there's a few more that appear in later patches too) --- driver

Re: [PATCH 10/13] ocxl: Add Makefile and Kconfig

2018-01-02 Thread Andrew Donnellan
in.o pci.o config.o file.o pasid.o +ocxl-y += link.o context.o afu_irq.o sysfs.o trace.o +obj-$(CONFIG_OCXL) += ocxl.o + +# For tracepoints to include our trace.h from tracepoint infrastructure: +CFLAGS_trace.o := -I$(src) + +# ccflags-y += -DDEBUG -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 01/13] powerpc/powernv: Introduce new PHB type for opencapi links

2018-01-02 Thread Andrew Donnellan
o need the information in later patches. So rename existing PNV_PHB_NPU type to PNV_PHB_NPU_NVLINK and add a new type PNV_PHB_NPU_OCAPI. Signed-off-by: Frederic Barrat Signed-off-by: Andrew Donnellan --- arch/powerpc/platforms/powernv/npu-dma.c | 2 +- arch/powerpc/platforms/powernv/pci-i

Re: [PATCH 02/13] powerpc/powernv: Set correct configuration space size for opencapi devices

2017-12-18 Thread Andrew Donnellan
On 19/12/17 02:21, Frederic Barrat wrote: From Andrew Donnellan Good try :) That should be "From: ..." git format-patch/send-email will handle this automatically if the commit author is set correctly, ie: git commit --amend --author="Andrew Donnellan " The con

Re: [PATCH 03/13] powerpc/powernv: Add opal calls for opencapi

2017-12-18 Thread Andrew Donnellan
exchanged on the link. During link setup, the host and device must negotiate what templates are supported on both sides and at what rates those messages can be sent. Signed-off-by: Frederic Barrat Corresponding skiboot patch: https://patchwork.ozlabs.org/patch/849830/ Acked-by: Andrew Donnellan

Re: [PATCH 00/13] New driver to support OpenCAPI devices on POWER9

2017-12-18 Thread Andrew Donnellan
connection (none exists yet) - no access to the adapter-local memory Many people contributed directly or indirectly, from the software, hardware and bringup teams. In particular Andrew Donnellan and Alastair D'Silva, who are developing the related firmware and library. Feedback welc

Re: [PATCH 11/13] cxl: Remove support for "Processing accelerators" class

2017-12-18 Thread Andrew Donnellan
table. So removing the class is expected to go unnoticed. Signed-off-by: Frederic Barrat Acked-by: Andrew Donnellan --- drivers/misc/cxl/pci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c index 19969ee86d6f..758842f65a1b 100644 --- a/dr

Re: [ANNOUNCE] Call for Papers - linux.conf.au Kernel Miniconf, Sydney, 22 January 2018

2017-11-28 Thread Andrew Donnellan
On 18/10/17 15:34, Andrew Donnellan wrote: Greetings, * TL;DR     - LCA Kernel Miniconf, Sydney, Australia, 22 Jan 2018     - Submissions by 30 November 2017, 23:59 (AEDT/UTC+11)     - Wanted: anything interesting to kernel hackers! Speakers from   diverse backgrounds encouraged

Re: [ANNOUNCE] Call for Papers - linux.conf.au Kernel Miniconf, Sydney, 22 January 2018

2017-11-15 Thread Andrew Donnellan
On 18/10/17 15:34, Andrew Donnellan wrote: Greetings, * TL;DR     - LCA Kernel Miniconf, Sydney, Australia, 22 Jan 2018     - Submissions by 30 November 2017, 23:59 (AEDT/UTC+11)     - Wanted: anything interesting to kernel hackers! Speakers from   diverse backgrounds encouraged

Re: [PATCH] powerpc: eeh: stop using do_gettimeofday()

2017-11-05 Thread Andrew Donnellan
Reviewed-by: Andrew Donnellan --- arch/powerpc/include/asm/eeh.h | 2 +- arch/powerpc/kernel/eeh_driver.c | 2 +- arch/powerpc/kernel/eeh_pe.c | 8 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h index

[ANNOUNCE] Call for Papers - linux.conf.au Kernel Miniconf, Sydney, 22 January 2018

2017-10-17 Thread Andrew Donnellan
e at andrew.donnel...@au1.ibm.com. For general LCA questions, ask t...@lca2018.org or @linuxconfau on Twitter. - Andrew -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

New Linux accelerators discussion list [was: Re: Fostering linux community collaboration on hardware accelerators]

2017-10-16 Thread Andrew Donnellan
-accelerators Archives: https://lists.ozlabs.org/pipermail/linux-accelerators I haven't set up Patchwork as yet, but if people think that's a good idea I can get that done too. Andrew -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: Regression for Power PC in 4.14-rc0 - bisected to commit 31bfdb036f12

2017-09-13 Thread Andrew Donnellan
is the configuration. Try with https://patchwork.ozlabs.org/patch/813153/ (A selftest for the instruction emulation will make its way upstream eventually...) -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH v3] Fix missing PCI ID; Necessary for Lenovo Yoga 720-15 Touchpad.

2017-08-15 Thread Andrew Donnellan
rship details. If you then re-send it, it should skip this From: line and everything should be fine. Andrew -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH] scsi: cxlflash: Fix an error handling path in 'cxlflash_disk_attach()'

2017-08-15 Thread Andrew Donnellan
On 16/08/17 06:18, Christophe JAILLET wrote: 'rc' is known to be 0 at this point. If 'create_context()' fails, returns -ENOMEM instead of 0 which means success. Signed-off-by: Christophe JAILLET ENOMEM seems right here. Reviewed-by: Andrew Donnellan --- d

Re: Missing File REPORTING-BUGS In Linux Kernel.

2017-05-08 Thread Andrew Donnellan
atest/index.html -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH v2 02/11] ABI: fix some syntax issues at the ABI database

2017-04-13 Thread Andrew Donnellan
quot;Please notice". Otherwise, for cxl: Reviewed-by: Andrew Donnellan -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [kernel-hardening] [PATCH v5 1/4] gcc-plugins: Add the initify gcc plugin

2017-03-27 Thread Andrew Donnellan
On 27/03/17 18:38, Andrew Donnellan wrote: On 01/02/17 07:24, Kees Cook wrote: From: Emese Revfy The kernel already has a mechanism to free up code and data memory that is only used during kernel or module initialization. This plugin will teach the compiler to find more such code and data

Re: [kernel-hardening] [PATCH v5 1/4] gcc-plugins: Add the initify gcc plugin

2017-03-27 Thread Andrew Donnellan
+= $(INITIFY_DISABLE_VERIFIY_NOCAPTURE_FUNCTIONS) s/VERIFIY/VERIFY/g here + Makefile.gcc-plugins? -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match

2017-02-15 Thread Andrew Donnellan
This patch will end up missing some code, what about this instead: Remove OPAL regex in powerpc to avoid false match Signed-off-by: Stewart Smith Per my reply to v4 of this series, your list matches mine. With the one typo correction below: Reviewed-by: Andrew Donnellan --- MAINT

Re: [PATCHv4 4/4] MAINTAINERS: Remove powerpc's opal match

2017-02-15 Thread Andrew Donnellan
tion/ABI/stable/sysfs-firmware-opal-dump - no other subsystem -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: Build Linux kernel to have comparable zImages

2017-02-08 Thread Andrew Donnellan
ut it seems to be somewhat in the direction you're after. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

[PATCH] powerpc: sort Kconfig selects under CONFIG_PPC

2017-01-30 Thread Andrew Donnellan
config PPC has a lot of selects under it. They're not sorted in any particular order, leading to merge conflicts when adding items at the end. Sort them alphabetically. Suggested-by: Michael Ellerman Signed-off-by: Andrew Donnellan --- On top of linux-next 20170130 --- arch/powerpc/Kc

Re: [PATCH 3/3] powerpc: enable support for GCC plugins

2017-01-26 Thread Andrew Donnellan
ries again. basic-block.h includes tm.h, and I don't believe we can remove that. I'm not convinced there's a way around this. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com IBM Australia Limited

Re: [PATCH 3/3] powerpc: enable support for GCC plugins

2017-01-26 Thread Andrew Donnellan
On 27/01/17 16:52, Andrew Donnellan wrote: basic-block.h includes tm.h, and I don't believe we can remove that. I'm not convinced there's a way around this. Includes via function.h, I should say. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnel...@au1.ibm.com

  1   2   >