On 8/20/19 4:30 AM, Enrico Weigelt, metux IT consult wrote:
> On 11.08.19 04:52, Andrew Cooks wrote:
>
> Hi,
>
>> My initial work is based on a board that is similar to the APU2, but has
>> additional peripherals connected to the smbus, including a NCT7491 thermal
>&
Hi Enrico
On 8/8/19 7:17 PM, Enrico Weigelt, metux IT consult wrote:
> On 02.08.19 14:51, Jean Delvare wrote:
>
> Hi,
>
>> These patches fix a couple of issues with the i2c-piix4 driver on
>> AMD Family 16h Model 30h SoCs and add ACPI-based enumeration to the
>> i2c-piix4 driver.
> Can you tell a
l have to check when back in office),
>> so (as the apu2 platform driver maintainer) I'm very interested in this.
> Unfortunately not. I only picked up from where Andrew Cooks left, due
> to me being way too slow to review his patches. I did not want his work
> to be lost. I was ab
Hi Tobin
On 26/02/18 18:58, Tobin C. Harding wrote:
> On Mon, Feb 26, 2018 at 10:28:43AM +1000, Andrew Cooks wrote:
>> Family 16h Model 30h SMBus controller needs the same port selection fix
>> as described and fixed in commit 0fe16195f891 ("i2c: piix4: Fix SMBus port
>>
and Kernel Developer's Guide (BKDG) for AMD Family 16h
Models 30h-3Fh Processors
Signed-off-by: Andrew Cooks
---
drivers/i2c/busses/i2c-piix4.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
index 01f1610..9a6cdc8 100644
--
l 30h-3Fh
Signed-off-by: Andrew Cooks
---
drivers/i2c/busses/i2c-piix4.c | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
index 5c90a44..01f1610 100644
--- a/drivers/i2c/busses/i2c-piix4.c
h Model 10h-1Fh doesn't mention any
49125 - Family 15h Model 30h-3Fh doesn't mention any
48751 - Family 16h Model 00h-0Fh uses the previously supported
index register SB800_PIIX4_PORT_IDX_ALT at 0x2e
Signed-off-by: Andrew Cooks
---
drivers/i2c/busses/i2c-piix4.c | 12 +++
I did were reading from the SoC temperature sensor in a loop:
while [ true ] ; do i2cget -y 0 0x4C 0x01 ; done
and scanning for peripherals in a loop:
while [ true ] ; do i2cdetect -y 0 ; done
These tests may be artificial and trivial, but the speedup matters to us
because we have more than one bus master and the embedded controller needs to
poll multiple sensors.
Tested-by: Andrew Cooks
Any comments?
On 31/01/18 07:40, Andrew Cooks wrote:
> Family 16h Model 30h SMBus controller has the same port selection
> register as described and fixed in commit 0fe16195f891
> ("i2c: piix4: Fix SMBus port selection for AMD Family 17h chips")
>
> commit 6befa3fde6
Model 30h-3Fh,
Signed-off-by: Andrew Cooks
---
drivers/i2c/busses/i2c-piix4.c | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
index 5c90a44..01f1610 100644
--- a/drivers/i2c/busses/i2c-piix4.c
/ ASF SMBus adapter"))
}
}
[1] 52740 BIOS and Kernel Developer's Guide (BKDG) for AMD Family 16h
Models 30h-3Fh Processors
Signed-off-by: Andrew Cooks
Reviewed-by: Andy Shevchenko
---
drivers/i2c/busses/i2c-piix4.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/driv
on any
49125 - Family 15h Model 30h-3Fh doesn't mention any
48751 - Family 16h Model 00h-0Fh uses the previously supported
index register SB800_PIIX4_PORT_IDX_ALT at 0x2e
Signed-off-by: Andrew Cooks
---
drivers/i2c/busses/i2c-piix4.c | 12 +---
1 file changed, 5 insertions
ction register
v2:
count the adapters, instead of misusing port numbers
Andrew Cooks (3):
i2c: piix4: Fix port selection for AMD Family 16h Model 30h
i2c: piix4: fix probing of reserved ports on AMD
i2c: piix4: add ACPI support
drivers/i2c/busses/i2c-piix4.c
Hi Andy
On 29/01/18 23:30, Andy Shevchenko wrote:
> On Mon, Jan 29, 2018 at 5:54 AM, Andrew Cooks
> wrote:
>> This enables the i2c-piix4 SMBus controller driver to enumerate I2C
>> slave devices using ACPI. It builds on the related I2C mux device work
>> in commit 8eb5
Hi Andy
Thanks for the review!
On 29/01/18 23:30, Andy Shevchenko wrote:
> On Mon, Jan 29, 2018 at 5:54 AM, Andrew Cooks
> wrote:
>> This enables the i2c-piix4 SMBus controller driver to enumerate I2C
>> slave devices using ACPI. It builds on the related I2C mux device
Hi Guenter
Thanks for your review!
On 29/01/18 15:58, Guenter Roeck wrote:
> On Mon, Jan 29, 2018 at 01:54:19PM +1000, Andrew Cooks wrote:
>> Prevent bus timeouts and resets on Family 16h Model 30h), by not
>> probing reserved Ports 3 and 4.
>>
>> According to the AMD
Hi Andy
On 29/12/17 19:44, Andy Shevchenko wrote:
> On Tue, Dec 5, 2017 at 4:17 AM, Andrew Cooks
> wrote:
>> Using TCA6424A with i2c-piix4 bus driver requires byte-at-a-time IO,
>> because the i2c-piix4 driver (and probably some SMBus controllers) don't
>> sup
odels 30h-3Fh,
Signed-off-by: Andrew Cooks
---
drivers/i2c/busses/i2c-piix4.c | 31 ++-
1 file changed, 22 insertions(+), 9 deletions(-)
diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
index 89692f4..9763241 100644
--- a/drivers/i2c/busse
0 BIOS and Kernel Developer's Guide (BKDG) for AMD Family 16h
Models 30h-3Fh Processors
Signed-off-by: Andrew Cooks
---
drivers/i2c/busses/i2c-piix4.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
index 9763241..97eb6
y
42300 - Family 15h Model 10h-1Fh doesn't mention any
49125 - Family 15h Model 30h-3Fh doesn't mention any
48751 - Family 16h Model 00h-0Fh uses the previously supported
index register SB800_PIIX4_PORT_IDX_ALT at 0x2e
Signed-off-by: Andrew Cooks
---
drivers/i2c/busses/i2c
uses
the i2c-piix4 SMBus driver.
ACPI provides a mechanism to define these peripherals and the controller
port that they're attached to.
Changes:
v3:
take chip revision into account when determining port selection register
v2:
count the adapters, instead of misusing port numbers
Andrew Coo
Hi Christian
On 21/12/17 23:02, Christian Lamparter wrote:
> On Thursday, December 21, 2017 8:25:03 AM CET Andrew Cooks wrote:
>> I'm working on gpio for an AMD Family 16h Model 30h system[1].
>> The SoC is the same as the GX412-TC used in the PC Engines APU2.
>>
>&
Hi Tobias
On 21/12/17 23:06, Tobias Diedrich wrote:
>
> > Another driver (gpio-sb8xx) was submitted for upstream inclusion, but
> was
> > knocked back with the suggestion that pinctrl is the way forward[3].
>
> Hm I cannot follow link [3] right now. And I don't remember the
> subm
Hi Linus
On 21/12/17 20:11, Linus Walleij wrote:
> Hi Andrew!
>
> Thank you for your mail!
>
> On Wed, Dec 20, 2017 at 11:25 PM, Andrew Cooks
> wrote:
>
>> Another driver (gpio-sb8xx) was submitted for upstream inclusion, but was
>> knocked back with the s
On 21/12/17 22:12, Mika Westerberg wrote:
> On Thu, Dec 21, 2017 at 11:11:18AM +0100, Linus Walleij wrote:
>>> In contrast, the pinctrl-amd driver only mentions the newer KERNCZ platform
>>> name and uses ACPI for probing without disclosing any Family or Model
>>> numbers.
>>>
>>> pinctrl-amd ap
Hi Linus
I'm working on gpio for an AMD Family 16h Model 30h system[1]. The SoC is the
same as the GX412-TC used in the PC Engines APU2.
There is an out-of-tree gpio driver (gpio-amd) for this SoC in the meta-amd
yocto layer[2].
Another driver (gpio-sb8xx) was submitted for upstream inclusion,
Hi Jean
On 14/12/17 13:11, Andrew Cooks wrote:
> HUDSON2 SMBus controller has the same port selection register as
> described and fixed in commit 0fe16195f89173652cf111d7b384941b00c5aabd
> ("i2c: piix4: Fix SMBus port selection for AMD Family 17h chips")
>
> The SMBus p
Hi Jean
On 08/12/17 00:29, Jean Delvare wrote:
> Hi Andrew,
>
> On Thu, 23 Nov 2017 13:09:38 +1000, Andrew Cooks wrote:
>> Let the aux port use port number one (not zero), to match the AMD
>> documentation and enable mapping ACPI _ADR to port number.
>>
>> Thi
0 BIOS and Kernel Developer's Guide (BKDG) for AMD Family 16h
Models 30h-3Fh Processors
Signed-off-by: Andrew Cooks
---
drivers/i2c/busses/i2c-piix4.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
index cc38dc3..65e63
y 16h Models 30h-3Fh,
Signed-off-by: Andrew Cooks
---
drivers/i2c/busses/i2c-piix4.c | 31 ++-
1 file changed, 22 insertions(+), 9 deletions(-)
diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
index b92ea5d..cc38dc3 100644
--- a/driver
Family 16h Model 00h-0Fh uses the previously supported
index register SB800_PIIX4_PORT_IDX_ALT at 0x2e
Signed-off-by: Andrew Cooks
---
drivers/i2c/busses/i2c-piix4.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/bu
Using TCA6424A with i2c-piix4 bus driver requires byte-at-a-time IO,
because the i2c-piix4 driver (and probably some SMBus controllers) don't
support I2C_SMBUS_I2C_BLOCK_DATA.
Signed-off-by: Andrew Cooks
---
drivers/gpio/gpio-pca953x.c | 16 ++--
1 file changed, 14 insertions(
This enables the i2c-piix4 SMBus controller driver to enumerate I2C
slave devices using ACPI. It builds on the related I2C mux device work
in commit 8eb5c87a92c0 ("i2c: add ACPI support for I2C mux ports")
Signed-off-by: Andrew Cooks
---
drivers/i2c/busses/i2c-piix4.c | 6 ++
1 fi
Let the aux port use port number one (not zero), to match the AMD
documentation and enable mapping ACPI _ADR to port number.
This fixes ACPI-based enumeration of I2C slave peripherals that are
defined for the aux SMBus port.
Signed-off-by: Andrew Cooks
---
drivers/i2c/busses/i2c-piix4.c | 2
iommu branch for v3.16. I'm happy to include the rest,
> too, given acks from Joerg and David. Or if they prefer to take them all,
> which might be easier than coordinating two trees, especially since there's
> PCI stuff at the beginning and end, here's my ack for the PCI bit
Hi Alex
On Fri, May 16, 2014 at 1:43 AM, Alex Williamson
wrote:
> On Thu, 2014-05-15 at 07:40 +0800, Andrew Cooks wrote:
>> Hi Alex
>>
>> On Fri, May 9, 2014 at 11:28 PM, Alex Williamson
>> wrote:
>> >
>> >
>> > Original description:
Hi Alex
On Fri, May 9, 2014 at 11:28 PM, Alex Williamson
wrote:
>
>
> Original description:
>
> This series attempts to fix a couple issues we've had outstanding in
> the PCI/IOMMU code for a while. The first issue is with devices that
> use the wrong requester ID for DMA transactions. We
Hi Alex
On Sat, May 3, 2014 at 1:15 PM, Alex Williamson
wrote:
> On Sat, 2014-05-03 at 10:29 +0800, Andrew Cooks wrote:
>> Hi Alex
>>
>> On Fri, May 2, 2014 at 12:27 AM, Alex Williamson
>> wrote:
>> > The existing quirk for these devices doesn't reall
On Wed, May 15, 2013 at 12:40 PM, Pat Erley wrote:
> On 04/05/2013 01:50 AM, Pat Erley wrote:
>>
>> On 04/05/2013 12:44 AM, Andrew Cooks wrote:
>>>
>>> On Tue, Apr 2, 2013 at 11:47 PM, Pat Erley wrote:
>>>>
>>>> On 04/02/2013 10:50 AM,
On Fri, Apr 12, 2013 at 4:06 PM, Joerg Roedel wrote:
> Hi Shuah,
>
> On Wed, Apr 10, 2013 at 10:06:02AM -0600, Shuah Khan wrote:
>> On Tue, Apr 9, 2013 at 2:12 PM, Joerg Roedel wrote:
>> > Documentation/kernel-parameters.txt | 14
>> > drivers/iommu/amd_iommu.c | 79 +++---
On Tue, Apr 2, 2013 at 11:47 PM, Pat Erley wrote:
> On 04/02/2013 10:50 AM, Andrew Cooks wrote:
>>
>> On 2 Apr 2013 15:37, "Pat Erley" > <mailto:pat-l...@erley.org>> wrote:
>> >
>> > On 03/07/2013 09:35 PM, Andrew Cooks wrote:
>>
On Fri, Mar 8, 2013 at 12:24 AM, Bjorn Helgaas wrote:
> On Thu, Mar 7, 2013 at 7:28 AM, wrote:
>> From: Xiangliang Yu
>>
>> Define PCI_VENDOR_MARVELL_ID_EXT macro for 0x1b4b vendor ID
>
> "PCI_VENDOR_MARVELL_ID_EXT" is not actually the symbol you defined below.
>
> Per the comment at the top of
On Tue, Mar 12, 2013 at 9:14 AM, Andrew Cooks wrote:
> Hi Jason
>
> When I specify a '-p' modifier in the dynamic debug options in the
> kernel command line, I get a kernel panic during boot. The panic
> happens after userspace starts doing graphical stuff, but I haven&
Hi Jason
When I specify a '-p' modifier in the dynamic debug options in the
kernel command line, I get a kernel panic during boot. The panic
happens after userspace starts doing graphical stuff, but I haven't
been able to pinpoint exactly what.
If I use '=_' instead of '-p', or boot to a recovery
On Fri, Mar 8, 2013 at 7:43 PM, Gaudenz Steinlin wrote:
>
> Hi Andrew
>
> Andrew Cooks writes:
>
>> This patch creates a quirk to allow the Intel IOMMU to be enabled for devices
>> that use incorrect tags during DMA. It is similar to the quirk for Ricoh
>> dev
On Thu, Mar 7, 2013 at 5:25 PM, Gaudenz Steinlin wrote:
>
> Hi Andrew
>
> Andrew Cooks writes:
>
>> On Tue, Mar 5, 2013 at 11:03 PM, Gaudenz Steinlin
>> wrote:
>>>
>>> [ Sending this to the MVUMI driver authors and the IOMMU li
when CONFIG_PCI_QUIRKS is not enabled.
This patch was generated against 3.9-rc1, but will also apply to 3.7.10.
Bug reports:
1. https://bugzilla.redhat.com/show_bug.cgi?id=757166
2. https://bugzilla.kernel.org/show_bug.cgi?id=42679
Signed-off-by: Andrew Cooks
---
driv
On Wed, Mar 6, 2013 at 12:04 PM, Alex Williamson
wrote:
> On Fri, 2013-03-01 at 16:26 +0800, Andrew Cooks wrote:
>
>> +
>> + for (fn = 1; fn < 8; fn++) {
>
> Wouldn't you want to do 0 to 7, then add:
>
> if (fn == PCI_FUNC(pdev->devfn))
> co
On Tue, Mar 5, 2013 at 11:03 PM, Gaudenz Steinlin wrote:
>
> [ Sending this to the MVUMI driver authors and the IOMMU list as I can't
> tell which part is at fault. ]
>
> [ ... ]
> [4.342079] dmar: DRHD: handling fault status reg 2
> [4.342132] dmar: DMAR:[DMA Read] Request device [02:00.0
d46b4 ]---
[1.583443] Mapped at:
[1.583545] [] debug_dma_map_page+0x4c/0xec
[1.583547] [] dma_map_single_attrs.clone.1+0xe3/0xf6
[1.583549] [] ioat_dma_self_test+0xd1/0x29d
[1.583550] [] ioat3_dma_self_test+0x16/0x29
[1.583552] [] ioat_probe+0xbc/0xea
Applies to 3.
On Mon, Mar 4, 2013 at 6:11 PM, Russell King - ARM Linux
wrote:
> On Mon, Mar 04, 2013 at 04:39:16PM +0800, Andrew Cooks wrote:
>> diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c
>> index 1879a59..1f706c4 100644
>> --- a/drivers/dma/ioat/dma.c
>> +
Applies to 3.9-rc1
Signed-off-by: Andrew Cooks
---
drivers/dma/ioat/dma.c | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c
index 1879a59..1f706c4 100644
--- a/drivers/dma/ioat/dma.c
+++ b/drivers/dma/
On Sat, Mar 2, 2013 at 7:18 AM, Justin Piszcz wrote:
>
> Against a clean 3.7.10 (from ftp.kernel.org)
>
> # patch -p1 <
> ../patch/RFC-Fix-Intel-IOMMU-support-for-Marvell-88SE91xx-SATA-controllers..
> patch
> patching file drivers/iommu/intel-iommu.c
> patching file drivers/pci/quirks.c
> Hunk #1
On Sat, Mar 2, 2013 at 1:51 AM, Justin Piszcz wrote:
>
>
> On Fri, Mar 1, 2013 at 3:26 AM, Andrew Cooks wrote:
>>
>> This is my third submitted patch to make Marvell 88SE91xx SATA controllers
>> work when IOMMU is enabled.[1][2]
>>
>
> Hi,
>
> Against
ly cleanly to 3.7.10.
Bug reports:
1. https://bugzilla.redhat.com/show_bug.cgi?id=757166
2. https://bugzilla.kernel.org/show_bug.cgi?id=42679
Signed-off-by: Andrew Cooks
---
drivers/iommu/intel-iommu.c | 50 +++
drivers/pci/qu
On Sat, Feb 23, 2013 at 3:29 AM, Stijn Tintel wrote:
> On 19-12-12 11:58, Andrew Cooks wrote:
>> This is my second attempt to make Marvell 88SE91xx SATA controllers work
>> when IOMMU is enabled.[1][2]
>> As suggested, it no longer tries to add support for phantom functions.
x9123, 0x9125, 0x9128 are
also affected.
Patch is against 3.7.1
Review and feedback would be appreciated.
1. https://bugzilla.redhat.com/show_bug.cgi?id=757166
2. https://bugzilla.kernel.org/show_bug.cgi?id=42679
Signed-off-by: Andrew Cooks
---
drivers/iommu/intel-iommu.c |
Hi Joe
On Wed, Nov 14, 2012 at 4:31 PM, Joe Perches wrote:
> On Tue, 2012-11-13 at 14:50 +0800, Andrew Cooks wrote:
>> The boot_delay parameter affects all printk(), even if the log level
>> prevents visible output from the call. It results in delays greater
>> than the
The boot_delay parameter affects all printk(), even if the log level
prevents visible output from the call. It results in delays greater
than the user intended without purpose.
This patch changes the behaviour of boot_delay to only delay output.
Signed-off-by: Andrew Cooks
---
kernel
config PCI_IOAPIC turned into a tristate in commit
b95a7bd700466c10fda84acbd33f70cf66ec91ce, but no module license is specified.
This adds the missing module license.
Signed-off-by: Andrew Cooks
---
drivers/pci/ioapic.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a
60 matches
Mail list logo
