On Sat, Apr 23, 2016 at 10:46 PM, Wincy Van wrote:
> On Wed, Apr 20, 2016 at 1:07 AM, Andres Lagar-Cavilla
> wrote:
>> Andrea, we provide the, ahem, adjustments to
>> transparent_hugepage_adjust. Rest assured we aggressively use mmu
>> notifiers with no further chang
dvantages of the compound model is that it's half in code
> size despite already including khugepaged (i.e. the same
> split_huge_page works for both tmpfs and anon) and like said above it
> won't introduce much complications for drivers like KVM as the model
> didn't change.
>
> Thanks,
> Andrea
--
Andres Lagar-Cavilla | Google Kernel Team | andre...@google.com
use.
>
>> I didn't mean this as a hard requirement it just sounds that the
>> current implementation restrictions shape the user visible API which
>> is a good sign to think twice about it.
>
> Agree. That's why we are discussing it now :-)
>
>>
>&g
p_ino helper
> hwpoison: use page_cgroup_ino for filtering by memcg
> memcg: zap try_get_mem_cgroup_from_page
> proc: add kpagecgroup file
> mmu-notifier: add clear_young callback
> proc: add kpageidle file
> proc: export idle flag via kpageflags
>
> Documentation/vm/p
renced(page) ||
> mmu_notifier_test_young(vma->vm_mm, address))
> referenced = true;
> }
Cool finds, thanks for the thoroughness
Andres
> diff --git a/mm/migrate.c b/mm/migrate.c
> index 236ee25e79d9..3e7bb4f2b51c 10064
; Signed-off-by: Vladimir Davydov
Reviewed-by: Andres Lagar-Cavilla
> ---
> Documentation/vm/pagemap.txt | 6 ++
> fs/proc/page.c | 3 +++
> include/uapi/linux/kernel-page-flags.h | 1 +
> 3 files changed, 10 insertions(+)
>
> diff -
ne. To achieve that we
> have to add a new mmu-notifier callback, clear_young, since there is no
> method for testing-and-clearing a secondary pte w/o flushing tlb. The
> new method is not mandatory and currently only implemented by KVM.
>
> Signed-off-by: Vladimir Davydov
Reviewed
> +
> +static const struct file_operations proc_kpagecgroup_operations = {
> + .llseek = mem_lseek,
> + .read = kpagecgroup_read,
> +};
> +#endif /* CONFIG_MEMCG */
> +
> static int __init proc_page_init(void)
> {
> proc_create("kpagecount", S_I
roup_ino, so use it instead.
>
> Signed-off-by: Vladimir Davydov
Reviewed-by: Andres Lagar-Cavilla
> ---
> mm/hwpoison-inject.c | 5 +
> mm/memory-failure.c | 16 ++--
> 2 files changed, 3 insertions(+), 18 deletions(-)
>
> diff --git a/mm/hwpoison-inj
hich will be introduced by a following patch.
>
> Signed-off-by: Vladimir Davydov
Reviewed-by: Andres Lagar-Cavilla
> ---
> include/linux/memcontrol.h | 1 +
> mm/memcontrol.c| 23 +++
> 2 files changed, 24 insertions(+)
>
> diff --git a/includ
On Tue, Jul 14, 2015 at 4:05 AM, Vladimir Davydov
wrote:
> On Mon, Jul 13, 2015 at 12:02:57PM -0700, Andres Lagar-Cavilla wrote:
>> On Sat, Jul 11, 2015 at 7:48 AM, Vladimir Davydov
>> wrote:
> [...]
>> > +static struct page *kpageidle_get_page(unsigned long pfn)
>&
dump_flags(unsigned long flags,
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 9671f51e954d..db404966faf4 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -1754,6 +1754,11 @@ static void __split_huge_page_refcount(struct page
> *page,
> /* clea
Hi Vladimir,
On Thu, Jul 9, 2015 at 6:19 AM, Vladimir Davydov wrote:
> Hi Andres,
>
> On Wed, Jul 08, 2015 at 04:01:13PM -0700, Andres Lagar-Cavilla wrote:
>> On Fri, Jun 12, 2015 at 2:52 AM, Vladimir Davydov
> [...]
>> > @@ -275,6 +276,179 @@ static c
-- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -798,6 +798,14 @@ static int page_referenced_one(struct page *page, struct
> vm_area_struct *vma,
> pte_unmap_unlock(pte, ptl);
This is not in your patch, but further up in page_referenced_one there
is the pmd case.
So what happens o
ings? npages is capped to KVM_MEM_MAX_NR_PAGES, i.e.
> | 2^31. A 64 bit overflow would be caused by a gigantic gfn_start which
> | would be trouble in many other ways.
>
> This patch drops the memslot overflow check to make the codes more simple.
>
> Signed-off-by: Wanpeng Li
Reviewed-by: Andres L
On Mon, Apr 13, 2015 at 10:25 PM, Wanpeng Li wrote:
> Hi Andres,
> On Fri, Apr 10, 2015 at 11:05:26AM -0700, Andres Lagar-Cavilla wrote:
> [...]
>>> + if (sp->role.direct &&
>>> + !kvm_is_reserved_pfn(pfn) &&
On Sun, Apr 12, 2015 at 6:45 PM, Xiao Guangrong
wrote:
>
>
> On 04/11/2015 02:05 AM, Andres Lagar-Cavilla wrote:
>>
>> On Fri, Apr 3, 2015 at 12:40 AM, Wanpeng Li
>> wrote:
>>>
>>>
>>> There are two scenarios for the requirement of collapsing
On Tue, Jan 13, 2015 at 8:37 AM, Andrea Arcangeli wrote:
> Last submit didn't go into -mm/3.19-rc, no prob but here I retry
> (possibly too early for 3.20-rc but I don't expect breakages in this
> area post -rc4) after a rebase on upstream.
The series looks good to me, I didn't spot any material
ble to block indefinitely by being allowed to release the mmap_sem).
>
> Signed-off-by: Andrea Arcangeli
Reviewed-by: Andres Lagar-Cavilla
Thanks for the cleanup.
> ---
> include/linux/kvm_host.h | 11 ---
> virt/kvm/async_pf.c | 2 +-
>
k
>> based on
>> qemu? or an independent tool (CRIU migration?) for live-migration?
>> Maybe i could fix the migration problem for ivshmem in qemu now,
>> based on softdirty mechanism.
>>
>>> Documentation/vm/soft-dirty.txt and pagemap.txt in case you aren't
&g
addr, write_fault, page);
> up_read(¤t->mm->mmap_sem);
> - } else {
> - /*
> -* By now we have tried gup_fast, and possibly async_pf, and
> we
> -* are certainly not atomic.
BUG_ON is asserting that when
> __get_user_pages is asked for a single page and it is successfully gets the
> page, then it shouldn't have dropped the mmap_sem. If that's the case, then
> you could generalize this assertion to
>
> BUG_ON(nr_pages == ret
On Fri, Sep 26, 2014 at 10:25 AM, Andrea Arcangeli wrote:
> On Thu, Sep 25, 2014 at 02:50:29PM -0700, Andres Lagar-Cavilla wrote:
>> It's nearly impossible to name it right because 1) it indicates we can
>> relinquish 2) it returns whether we still hold the mmap semaphore.
&
On Thu, Sep 25, 2014 at 2:16 PM, Andrea Arcangeli wrote:
> Hi Andres,
>
> On Wed, Sep 17, 2014 at 10:51:48AM -0700, Andres Lagar-Cavilla wrote:
>> + if (!locked) {
>> + VM_BUG_ON(npages != -EBUSY);
>> +
>
> Shouldn't this be VM_BUG_ON(
having the duplicated trace would make sense if you included
> the accessed bit for each spte, instead of just the "young" variable.
FWIW the new arrangement in kvm.git/queue LGTM
Thanks
Andres
>
> Paolo
--
Andres Lagar-Cavilla | Google Kernel Team | andre...@google
On Tue, Sep 23, 2014 at 12:49 AM, Paolo Bonzini wrote:
> Il 22/09/2014 23:54, Andres Lagar-Cavilla ha scritto:
>> @@ -1406,32 +1406,24 @@ static int kvm_age_rmapp(struct kvm *kvm, unsigned
>> long *rmapp,
>> struct rmap_iterator uninitialized_var(iter);
&
On Mon, Sep 22, 2014 at 2:48 PM, Paolo Bonzini wrote:
> Il 22/09/2014 22:26, Andres Lagar-Cavilla ha scritto:
>> + __entry->gfn= gfn;
>> + __entry->hva= ((gfn - slot->base_gfn) >>
>
&g
d region
* Func prototypes fixed
v2 -> v3 * Added Acked-by
* Fix compilation in PowerPC
v3 -> v4 * Fix page shift direction in trace routine
* Clarified comment in rmap.c
---
Signed-off-by: Andres Lagar-Cavilla
Acked-by: Rik van Riel
---
arch/arm/include/
On Thu, Sep 18, 2014 at 11:08 PM, Paolo Bonzini wrote:
>
> Il 19/09/2014 05:58, Andres Lagar-Cavilla ha scritto:
> > Paolo, should I recut including the recent Reviewed-by's?
>
> No, I'll add them myself.
Paolo, is this patch waiting for something? Is Gleb's
d region
* Func prototypes fixed
v2 -> v3 * Added Acked-by
* Fix compilation in PowerPC
---
Signed-off-by: Andres Lagar-Cavilla
Acked-by: Rik van Riel
---
arch/arm/include/asm/kvm_host.h | 3 ++-
arch/arm64/include/asm/kvm_host.h | 3 ++-
arch/powerpc/include/asm/kvm_
d region
* Func prototypes fixed
---
Signed-off-by: Andres Lagar-Cavilla
---
arch/arm/include/asm/kvm_host.h | 3 ++-
arch/arm64/include/asm/kvm_host.h | 3 ++-
arch/powerpc/include/asm/kvm_host.h | 2 +-
arch/powerpc/kvm/book3s.c | 4 ++--
arch/powerpc/kvm/book3s.h
d region
* Func prototypes fixed
---
Signed-off-by: Andres Lagar-Cavilla
---
arch/arm/include/asm/kvm_host.h | 3 ++-
arch/arm64/include/asm/kvm_host.h | 3 ++-
arch/powerpc/include/asm/kvm_host.h | 2 +-
arch/powerpc/kvm/book3s.c | 4 ++--
arch/powerpc/kvm/book3s.h
), we emulate
the access bit by blowing the spte. This requires proper synchronizing
with MMU notifier consumers, like every other removal of spte's does.
Signed-off-by: Andres Lagar-Cavilla
---
arch/arm/include/asm/kvm_host.h | 3 ++-
arch/arm64/include/asm/kvm_host.h | 3 ++-
On Thu, Sep 18, 2014 at 5:32 PM, Wanpeng Li wrote:
> On Thu, Sep 18, 2014 at 09:13:26AM +0300, Gleb Natapov wrote:
>>On Thu, Sep 18, 2014 at 08:29:17AM +0800, Wanpeng Li wrote:
>>> Hi Andres,
>>> On Wed, Sep 17, 2014 at 10:51:48AM -0700, Andres Lagar-Cavilla wrote:
&g
now stall as a function of swap or filemap latency.
This patch ensures both the regular and async PF path re-enter the
fault allowing for the mmap semaphore to be relinquished in the case
of IO wait.
Reviewed-by: Radim Krčmář
Signed-off-by: Andres Lagar-Cavilla
---
v1 -> v2
* WARN_ON_ONCE
On Wed, Sep 17, 2014 at 10:21 AM, Gleb Natapov wrote:
> On Wed, Sep 17, 2014 at 10:13:45AM -0700, Andres Lagar-Cavilla wrote:
>> On Wed, Sep 17, 2014 at 10:08 AM, Gleb Natapov wrote:
>> > On Wed, Sep 17, 2014 at 10:00:32AM -0700, Andres Lagar-Cavilla wrote:
>> >> O
On Wed, Sep 17, 2014 at 10:08 AM, Gleb Natapov wrote:
> On Wed, Sep 17, 2014 at 10:00:32AM -0700, Andres Lagar-Cavilla wrote:
>> On Wed, Sep 17, 2014 at 4:42 AM, Gleb Natapov wrote:
>> > On Wed, Sep 17, 2014 at 01:27:14PM +0200, Radim Krčmář wrote:
>> >> 2014-
e work
queue will not relinquish the mmap semaphore. And it most definitely
should, given that we are likely looking at swap/filemap.
Andres
>
> --
> Gleb.
--
Andres Lagar-Cavilla | Google Kernel Team | andre...@google.com
--
To unsubscribe from this list: se
On Wed, Sep 17, 2014 at 12:43 AM, Paolo Bonzini wrote:
> Il 16/09/2014 20:42, Andres Lagar-Cavilla ha scritto:
>> On Tue, Sep 16, 2014 at 11:29 AM, Paolo Bonzini wrote:
>>>> I think a first patch should introduce kvm_get_user_page_retry ("Retry
>>>
On Tue, Sep 16, 2014 at 3:34 PM, Radim Krčmář wrote:
> [Emergency posting to fix the tag and couldn't find unmangled Cc list,
> so some recipients were dropped, sorry. (I guess you are glad though).]
>
> 2014-09-16 14:01-0700, Andres Lagar-Cavilla:
>> On Tue, Sep 16,
On Tue, Sep 16, 2014 at 1:51 PM, Radim Krčmář wrote:
> 2014-09-15 13:11-0700, Andres Lagar-Cavilla:
>> +int kvm_get_user_page_retry(struct task_struct *tsk, struct mm_struct *mm,
>
> The suffix '_retry' is not best suited for this.
> On first reading, I imagined we wil
On Tue, Sep 16, 2014 at 11:29 AM, Paolo Bonzini wrote:
> Il 16/09/2014 18:52, Andres Lagar-Cavilla ha scritto:
>> Was this:
>>
>> down_read(&mm->mmap_sem);
>> npages = get_user_pages(NULL, mm, addr, 1, 1, 0, NULL, NULL);
>> up_
On Tue, Sep 16, 2014 at 9:52 AM, Andres Lagar-Cavilla
wrote:
Apologies to all. Resend as lists rejected my gmail-formatted version.
Now on plain text. Won't happen again.
> On Tue, Sep 16, 2014 at 6:51 AM, Paolo Bonzini wrote:
>>
>> Il 15/09/2014 22:11, Andres Laga
on swap or filemap
latency.
This patch ensures both the regular and async PF path re-enter the fault
allowing for the mmap semaphore to be relinquished in the case of IO wait.
Signed-off-by: Andres Lagar-Cavilla
---
include/linux/kvm_host.h | 9 +
include/linux/mm.h | 1 +
From: Andres Lagar-Cavilla
When a foreign mapper attempts to map guest frames that are paged out,
the mapper receives an ENOENT response and will have to try again
while a helper process pages the target frame back in.
Gating checks on PRIVCMD_MMAPBATCH* ioctl args were preventing retries
of
From: Andres Lagar-Cavilla
When a foreign mapper attempts to map guest frames that are paged out,
the mapper receives an ENOENT response and will have to try again
while a helper process pages the target frame back in.
Gating checks on PRIVCMD_MMAPBATCH* ioctl args were preventing retries
of
On Aug 1, 2013, at 8:04 AM, David Vrabel wrote:
> On 01/08/13 12:49, Andres Lagar-Cavilla wrote:
>> On Aug 1, 2013, at 7:23 AM, David Vrabel wrote:
>>
>>> On 01/08/13 04:30, Andres Lagar-Cavilla wrote:
>>>> -- Resend as I haven't seen this
On Aug 1, 2013, at 7:23 AM, David Vrabel wrote:
> On 01/08/13 04:30, Andres Lagar-Cavilla wrote:
>> -- Resend as I haven't seen this hit the lists. Maybe some smtp misconfig.
>> Apologies. Also expanded cc --
>>
>> When a foreign mapper attempts to map guest f
ck in.
Gating checks on PRIVCMD_MMAPBATCH* ioctl args were preventing retries
of mapping calls.
Signed-off-by: Andres Lagar-Cavilla
---
drivers/xen/privcmd.c | 32 +++-
1 files changed, 27 insertions(+), 5 deletions(-)
diff --git a/drivers/xen/privcmd.c b/driver
On Sep 24, 2012, at 11:06 AM, Konrad Rzeszutek Wilk wrote:
> On Mon, Sep 24, 2012 at 10:38:48AM -0400, Andres Lagar-Cavilla wrote:
>> On Sep 21, 2012, at 4:46 PM, Konrad Rzeszutek Wilk wrote:
>>
>>> On Fri, Sep 21, 2012 at 02:56:22PM -0400, Konrad Rzeszutek Wilk wrot
On Sep 21, 2012, at 4:46 PM, Konrad Rzeszutek Wilk wrote:
> On Fri, Sep 21, 2012 at 02:56:22PM -0400, Konrad Rzeszutek Wilk wrote:
>>> *: With a PVHVM guest I get
>>>
>>> [ 261.927218] privcmd_fault: vma=88002a31dce8
>>> 7f4edc095000-7f4edc195000, pgoff=c8, uv=7f4edc15d000
>>>
>>> thou
On Sep 21, 2012, at 2:52 PM, Konrad Rzeszutek Wilk wrote:
> On Mon, Sep 17, 2012 at 05:29:24AM -0400, Andres Lagar-Cavilla wrote:
>> On Sep 17, 2012, at 4:17 AM, Ian Campbell wrote:
>>
>>> (I think I forgot to hit send on this on Friday, sorry. Also
>>> s/xen.
On Sep 17, 2012, at 4:17 AM, Ian Campbell wrote:
> (I think I forgot to hit send on this on Friday, sorry. Also
> s/xen.lists.org/lists.xen.org in the CC line…)
I'm on a roll here…
>
> On Fri, 2012-09-14 at 15:26 +0100, Andres Lagar-Cavilla wrote:
>> Since Xen-4.2, hvm do
On Sep 14, 2012, at 8:44 AM, Konrad Rzeszutek Wilk wrote:
> On Fri, Sep 14, 2012 at 08:19:01AM +0100, Ian Campbell wrote:
>> On Thu, 2012-09-13 at 20:45 +0100, Andres Lagar-Cavilla wrote:
>>> On Sep 13, 2012, at 2:11 PM, Ian Campbell wrote:
>>>
>>>> On
sync of Xen grant table interface headers.
Signed-off-by: Andres Lagar-Cavilla
---
drivers/net/xen-netback/netback.c | 11 ++--
drivers/xen/grant-table.c | 53
drivers/xen/xenbus/xenbus_client.c |6 ++--
include/xen/grant_table.h
On Sep 13, 2012, at 2:11 PM, Ian Campbell wrote:
> On Thu, 2012-09-13 at 18:28 +0100, Andres Lagar-Cavilla wrote:
>>
>> * Add placeholder in array of grant table error descriptions for
>> unrelated error code we jump over.
>
> Why not just define it, it's liste
implementation in grant_table.c, cleaner interface.
Signed-off-by: Andres Lagar-Cavilla
---
drivers/net/xen-netback/netback.c | 11 ++--
drivers/xen/grant-table.c | 53 +++
drivers/xen/xenbus/xenbus_client.c |6 ++--
include/xen
On Sep 13, 2012, at 3:14 AM, Ian Campbell wrote:
> On Wed, 2012-09-12 at 20:45 +0100, Andres Lagar-Cavilla wrote:
>> diff --git a/include/xen/interface/grant_table.h
>> b/include/xen/interface/grant_table.h
>> index 7da811b..66cb734 100644
>> --- a/include/xen/inter
On Sep 12, 2012, at 4:21 PM, Andres Lagar-Cavilla wrote:
>
> On Sep 12, 2012, at 4:06 PM, Konrad Rzeszutek Wilk wrote:
>
>> On Wed, Sep 12, 2012 at 03:45:53PM -0400, Andres Lagar-Cavilla wrote:
>>> Since Xen-4.2, hvm domains may have portions of their memory paged out.
On Sep 12, 2012, at 4:06 PM, Konrad Rzeszutek Wilk wrote:
> On Wed, Sep 12, 2012 at 03:45:53PM -0400, Andres Lagar-Cavilla wrote:
>> Since Xen-4.2, hvm domains may have portions of their memory paged out. When
>> a
>> foreign domain (such as dom0) attempts to map these
GNTST_eagain check into core grant table code for netback module.
Signed-off-by: Andres Lagar-Cavilla
---
drivers/net/xen-netback/netback.c | 11 +++---
drivers/xen/grant-table.c | 26
drivers/xen/xenbus/xenbus_client.c |6 ++
include/xen/grant_table.h
61 matches
Mail list logo
