Re: [PATCH v3] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-05-23 Thread Andrei Borzenkov
24.05.2016 02:03, Gabriele Mazzotta пишет: > On 24/05/2016 00:22, Pali Rohár wrote: >> On Tuesday 24 May 2016 00:17:15 Darren Hart wrote: >>> On Tue, May 24, 2016 at 12:06:03AM +0200, Pali Rohár wrote: On Monday 23 May 2016 23:26:55 Darren Hart wrote: > I've queued this. Thanks for your pa

Re: [PATCH v2] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-03-18 Thread Andrei Borzenkov
t; struct rbtn_data *rbtn_data = device->driver_data; >>> >>> + if (rbtn_data->suspended) { >>> + dev_dbg(&device->dev, "ACPI notification ignored\n"); >>> + return; >>> + } >>> + >>> if (event != 0x80) { >>> dev_info(&device->dev, "Received unknown event (0x%x)\n", >>> event); >>> -- >>> 2.7.0 >>> >> >> I'm sorry, Pali, I must have missed your email address while sending >> this updated version. > > For me patch looks OK. I would suggest to add some comment about BIOS > into code too. > > Rafael, can you review that ACPI suspended/OSL_NOTIFY_HANDLER part? > > Andrei, can you test if it now really fix it on your machine? > TBH I'm still unsure if this fixes root cause or just decreases race window, but so far after multiple suspend/resume cycles on my Dell Latitude E5450 WiFi was restored every time. So Tested-By: Andrei Borzenkov

Re: [PATCH v2] dell-rbtn: Ignore ACPI notifications if device is suspended

2016-03-14 Thread Andrei Borzenkov
On Mon, Mar 14, 2016 at 2:45 PM, Pali Rohár wrote: > On Monday 14 March 2016 12:34:31 Gabriele Mazzotta wrote: >> 2016-03-12 0:49 GMT+01:00 Gabriele Mazzotta : >> > Some BIOSes unconditionally send an ACPI notification to RBTN when the >> > system is resuming from suspend. This makes dell-rbtn sen

Reading the same block via partition and non-partitioned device gives different content

2016-01-05 Thread Andrei Borzenkov
[Please Cc me on reply; thank you] QEMU KVM virtual machine with openSUSE Tumbleweed (kernel 4.3.3-3-default); MD RAID1 with 1.2 metadata on /dev/vdb1 and /dev/vdc1. If I do mdadm /dev/mdX --fail /dev/vdb1 mdadm /dev/mdX --add /dev/vdd1 and wait for synchronization to finish and then look direc