Re: [PATCH v6 12/13] media: i2c: imx214: Fix clock handling on probe error or remove

2025-01-09 Thread André Apitzsch
Hi Sakari, Am Donnerstag, dem 09.01.2025 um 08:59 + schrieb Sakari Ailus: > Hi André, > > On Wed, Jan 08, 2025 at 10:46:51PM +0100, André Apitzsch wrote: > > Hi Sakari, > > > > Am Mittwoch, dem 08.01.2025 um 11:51 + schrieb Sakari Ailus: > > > H

Re: [PATCH v6 12/13] media: i2c: imx214: Fix clock handling on probe error or remove

2025-01-08 Thread André Apitzsch
Hi Sakari, Am Mittwoch, dem 08.01.2025 um 11:51 + schrieb Sakari Ailus: > Hi André, > > Thanks for the update. > > On Fri, Dec 20, 2024 at 02:26:11PM +0100, André Apitzsch via B4 Relay > wrote: > > From: André Apitzsch > > > > The driver should dis

[PATCH v6 13/13] media: i2c: imx214: Fix link frequency validation

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch The driver defines IMX214_DEFAULT_LINK_FREQ 48000, and then IMX214_DEFAULT_PIXEL_RATE ((IMX214_DEFAULT_LINK_FREQ * 8LL) / 10), which works out as 384MPix/s. (The 8 is 4 lanes and DDR.) Parsing the PLL registers with the defined 24MHz input. We're in single PLL mod

[PATCH v6 12/13] media: i2c: imx214: Fix clock handling on probe error or remove

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch The driver should disable or unprepare the clock on probe error and on removing the module. Remove regulator_bulk_disable(), because it is called by imx214_power_off(). Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 4 +++- 1

[PATCH v6 11/13] media: i2c: imx214: Add test pattern control

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch This adds V4L2_CID_TEST_PATTERN control support. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 77 -- 1 file changed, 75 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c

[PATCH v6 10/13] media: i2c: imx214: Verify chip ID

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch Check the chip ID and stop probing if it is no imx214 sensor. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/media/i2c/imx214.c b/drivers

[PATCH v6 06/13] media: i2c: imx214: Check number of lanes from device tree

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch The imx214 camera is capable of either two-lane or four-lane operation. Currently only the four-lane mode is supported, as proper pixel rates and link frequences for the two-lane mode are unknown. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media

[PATCH v6 08/13] media: i2c: imx214: Implement vflip/hflip controls

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch The imx214 sensor supports horizontal and vertical flipping. Add appropriate controls to the driver. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 68 -- 1 file changed, 60 insertions

[PATCH v6 04/13] media: i2c: imx214: Replace register addresses with macros

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch Define macros for all the known registers used in the register arrays, and use them to replace the numerical addresses. This improves readability. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 407

[PATCH v6 01/13] media: i2c: imx214: Use subdev active state

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch Port the imx214 sensor driver to use the subdev active state. Move all the format configuration to the subdevice state and simplify the format handling, locking and initialization. While at it, simplify imx214_start_streaming() by removing unneeded goto statements and the

[PATCH v6 02/13] media: i2c: imx214: Simplify with dev_err_probe()

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch Error handling in probe() can be a bit simpler with dev_err_probe(). Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 54 +- 1 file changed, 24 insertions(+), 30 deletions(-) diff --git

[PATCH v6 09/13] media: i2c: imx214: Add analogue/digital gain control

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch The imx214 sensor supports analogue gain up to 8x and digital gain up to 16x. Implement the corresponding controls in the driver. Default gain values are not modified by this patch. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c

[PATCH v6 03/13] media: i2c: imx214: Convert to CCI register access helpers

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch Use the new common CCI register access helpers to replace the private register access helpers in the imx214 driver. This simplifies the driver by reducing the amount of code. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/Kconfig | 1

[PATCH v6 00/13] media: i2c: imx214: Miscellaneous cleanups and improvements

2024-12-20 Thread André Apitzsch via B4 Relay
This patch series is a collection of miscellaneous cleanups and improvements to the imx214 driver. The series converts the driver to the CCI helpers and adds controls needed to make the driver work with libcamera. The changes are inspired by the imx219 driver. Signed-off-by: André Apitzsch

[PATCH v6 07/13] media: i2c: imx214: Add vblank and hblank controls

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch Add vblank control to allow changing the framerate / higher exposure values. The vblank and hblank controls are needed for libcamera support. While at it, fix the minimal exposure time according to the datasheet. Signed-off-by: André Apitzsch --- drivers/media/i2c

[PATCH v6 05/13] media: i2c: imx214: Drop IMX214_REG_EXPOSURE from mode reg arrays

2024-12-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch The IMX214_REG_EXPOSURE is configured twice, once with a hardcoded value in the mode_ registers arrays, and once via v4l2_ctrl_ops. The latter is enough, drop the former. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 2 -- 1

[PATCH v5 08/13] media: i2c: imx214: Implement vflip/hflip controls

2024-12-17 Thread André Apitzsch via B4 Relay
From: André Apitzsch The imx214 sensor supports horizontal and vertical flipping. Add appropriate controls to the driver. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 69 -- 1 file changed, 61 insertions

[PATCH v5 11/13] media: i2c: imx214: Add test pattern control

2024-12-17 Thread André Apitzsch via B4 Relay
From: André Apitzsch This adds V4L2_CID_TEST_PATTERN control support. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 77 -- 1 file changed, 75 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c

[PATCH v5 07/13] media: i2c: imx214: Add vblank and hblank controls

2024-12-17 Thread André Apitzsch via B4 Relay
From: André Apitzsch Add vblank control to allow changing the framerate / higher exposure values. The vblank and hblank controls are needed for libcamera support. While at it, fix the minimal exposure time according to the datasheet. Signed-off-by: André Apitzsch --- drivers/media/i2c

[PATCH v5 03/13] media: i2c: imx214: Convert to CCI register access helpers

2024-12-17 Thread André Apitzsch via B4 Relay
From: André Apitzsch Use the new common CCI register access helpers to replace the private register access helpers in the imx214 driver. This simplifies the driver by reducing the amount of code. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/Kconfig | 1

[PATCH v5 10/13] media: i2c: imx214: Verify chip ID

2024-12-17 Thread André Apitzsch via B4 Relay
From: André Apitzsch Check the chip ID and stop probing if it is no imx214 sensor. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/media/i2c/imx214.c b/drivers

[PATCH v5 04/13] media: i2c: imx214: Replace register addresses with macros

2024-12-17 Thread André Apitzsch via B4 Relay
From: André Apitzsch Define macros for all the known registers used in the register arrays, and use them to replace the numerical addresses. This improves readability. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 407

[PATCH v5 12/13] media: i2c: imx214: Fix clock handling on probe error or remove

2024-12-17 Thread André Apitzsch via B4 Relay
From: André Apitzsch The driver should disable or unprepare the clock on probe error and on removing the module. Remove regulator_bulk_disable(), because it is called by imx214_power_off(). Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 4 +++- 1 file changed, 3 insertions

[PATCH v5 06/13] media: i2c: imx214: Check number of lanes from device tree

2024-12-17 Thread André Apitzsch via B4 Relay
From: André Apitzsch The imx214 camera is capable of either two-lane or four-lane operation. Currently only the four-lane mode is supported, as proper pixel rates and link frequences for the two-lane mode are unknown. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media

[PATCH v5 13/13] media: i2c: imx214: Fix link frequency validation

2024-12-17 Thread André Apitzsch via B4 Relay
From: André Apitzsch The driver defines IMX214_DEFAULT_LINK_FREQ 48000, and then IMX214_DEFAULT_PIXEL_RATE ((IMX214_DEFAULT_LINK_FREQ * 8LL) / 10), which works out as 384MPix/s. (The 8 is 4 lanes and DDR.) Parsing the PLL registers with the defined 24MHz input. We're in single PLL mod

[PATCH v5 09/13] media: i2c: imx214: Add analogue/digital gain control

2024-12-17 Thread André Apitzsch via B4 Relay
From: André Apitzsch The imx214 sensor supports analogue gain up to 8x and digital gain up to 16x. Implement the corresponding controls in the driver. Default gain values are not modified by this patch. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c

[PATCH v5 05/13] media: i2c: imx214: Drop IMX214_REG_EXPOSURE from mode reg arrays

2024-12-17 Thread André Apitzsch via B4 Relay
From: André Apitzsch The IMX214_REG_EXPOSURE is configured twice, once with a hardcoded value in the mode_ registers arrays, and once via v4l2_ctrl_ops. The latter is enough, drop the former. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 2 -- 1

[PATCH v5 00/13] media: i2c: imx214: Miscellaneous cleanups and improvements

2024-12-17 Thread André Apitzsch via B4 Relay
This patch series is a collection of miscellaneous cleanups and improvements to the imx214 driver. The series converts the driver to the CCI helpers and adds controls needed to make the driver work with libcamera. The changes are inspired by the imx219 driver. Signed-off-by: André Apitzsch

[PATCH v5 01/13] media: i2c: imx214: Use subdev active state

2024-12-17 Thread André Apitzsch via B4 Relay
From: André Apitzsch Port the imx214 sensor driver to use the subdev active state. Move all the format configuration to the subdevice state and simplify the format handling, locking and initialization. While at it, simplify imx214_start_streaming() by removing unneeded goto statements and the

[PATCH v5 02/13] media: i2c: imx214: Simplify with dev_err_probe()

2024-12-17 Thread André Apitzsch via B4 Relay
From: André Apitzsch Error handling in probe() can be a bit simpler with dev_err_probe(). Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 54 +- 1 file changed, 24 insertions(+), 30 deletions(-) diff --git

[PATCH v4 05/13] media: i2c: imx214: Drop IMX214_REG_EXPOSURE from mode reg arrays

2024-12-16 Thread André Apitzsch via B4 Relay
From: André Apitzsch The IMX214_REG_EXPOSURE is configured twice, once with a hardcoded value in the mode_ registers arrays, and once via v4l2_ctrl_ops. The latter is enough, drop the former. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 2 -- 1

[PATCH v4 10/13] media: i2c: imx214: Verify chip ID

2024-12-16 Thread André Apitzsch via B4 Relay
From: André Apitzsch Check the chip ID and stop probing if it is no imx214 sensor. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/media/i2c/imx214.c b/drivers

[PATCH v4 09/13] media: i2c: imx214: Add analogue/digital gain control

2024-12-16 Thread André Apitzsch via B4 Relay
From: André Apitzsch The imx214 sensor supports analogue gain up to 8x and digital gain up to 16x. Implement the corresponding controls in the driver. Default gain values are not modified by this patch. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c

[PATCH v4 11/13] media: i2c: imx214: Add test pattern control

2024-12-16 Thread André Apitzsch via B4 Relay
From: André Apitzsch This adds V4L2_CID_TEST_PATTERN control support. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 77 -- 1 file changed, 75 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c

[PATCH v4 06/13] media: i2c: imx214: Check number of lanes from device tree

2024-12-16 Thread André Apitzsch via B4 Relay
From: André Apitzsch The imx214 camera is capable of either two-lane or four-lane operation. Currently only the four-lane mode is supported, as proper pixel rates and link frequences for the two-lane mode are unknown. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media

[PATCH v4 01/13] media: i2c: imx214: Use subdev active state

2024-12-16 Thread André Apitzsch via B4 Relay
From: André Apitzsch Port the imx214 sensor driver to use the subdev active state. Move all the format configuration to the subdevice state and simplify the format handling, locking and initialization. While at it, simplify imx214_start_streaming() by removing unneeded goto statements and the

[PATCH v4 00/13] media: i2c: imx214: Miscellaneous cleanups and improvements

2024-12-16 Thread André Apitzsch via B4 Relay
This patch series is a collection of miscellaneous cleanups and improvements to the imx214 driver. The series converts the driver to the CCI helpers and adds controls needed to make the driver work with libcamera. The changes are inspired by the imx219 driver. Signed-off-by: André Apitzsch

[PATCH v4 13/13] media: i2c: imx214: Fix link frequency validation

2024-12-16 Thread André Apitzsch via B4 Relay
From: André Apitzsch The driver defines IMX214_DEFAULT_LINK_FREQ 48000, and then IMX214_DEFAULT_PIXEL_RATE ((IMX214_DEFAULT_LINK_FREQ * 8LL) / 10), which works out as 384MPix/s. (The 8 is 4 lanes and DDR.) Parsing the PLL registers with the defined 24MHz input. We're in single PLL mod

[PATCH v4 12/13] media: i2c: imx214: Fix clock handling on probe error or remove

2024-12-16 Thread André Apitzsch via B4 Relay
From: André Apitzsch The driver should disable or unprepare the clock on probe error and on removing the module. Remove regulator_bulk_disable(), because it is called by imx214_power_off(). Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 4 +++- 1 file changed, 3 insertions

[PATCH v4 08/13] media: i2c: imx214: Implement vflip/hflip controls

2024-12-16 Thread André Apitzsch via B4 Relay
From: André Apitzsch The imx214 sensor supports horizontal and vertical flipping. Add appropriate controls to the driver. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 69 -- 1 file changed, 61 insertions

[PATCH v4 04/13] media: i2c: imx214: Replace register addresses with macros

2024-12-16 Thread André Apitzsch via B4 Relay
From: André Apitzsch Define macros for all the known registers used in the register arrays, and use them to replace the numerical addresses. This improves readability. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 407

[PATCH v4 07/13] media: i2c: imx214: Add vblank and hblank controls

2024-12-16 Thread André Apitzsch via B4 Relay
From: André Apitzsch Add vblank control to allow changing the framerate / higher exposure values. The vblank and hblank controls are needed for libcamera support. While at it, fix the minimal exposure time according to the datasheet. Signed-off-by: André Apitzsch --- drivers/media/i2c

[PATCH v4 02/13] media: i2c: imx214: Simplify with dev_err_probe()

2024-12-16 Thread André Apitzsch via B4 Relay
From: André Apitzsch Error handling in probe() can be a bit simpler with dev_err_probe(). Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 54 +- 1 file changed, 24 insertions(+), 30 deletions(-) diff --git

[PATCH v4 03/13] media: i2c: imx214: Convert to CCI register access helpers

2024-12-16 Thread André Apitzsch via B4 Relay
From: André Apitzsch Use the new common CCI register access helpers to replace the private register access helpers in the imx214 driver. This simplifies the driver by reducing the amount of code. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/Kconfig | 1

Re: [PATCH v3 07/12] media: i2c: imx214: Add vblank and hblank controls

2024-12-15 Thread André Apitzsch
;d like to hear back from Sakari regarding the > get_locked_active > > Thanks! > > On Sat, Dec 7, 2024 at 9:48 PM André Apitzsch via B4 Relay > wrote: > > > > From: André Apitzsch > > > > Add vblank control to allow changing the framerate / > > h

Re: [PATCH v3 07/12] media: i2c: imx214: Add vblank and hblank controls

2024-12-14 Thread André Apitzsch
}, -- WARNING: line length of 83 exceeds 80 columns #177: FILE: drivers/media/i2c/imx214.c:730: + exposure_max = format->height + ctrl->val - IMX214_EXPOSURE_OFFSET; -- WARNING: line length of 85 exceeds 80 columns #85: FILE: drivers/media/i2c/imx214.c:1231: + if (bus_cfg.link_frequencies[i] == IMX214_DEFAULT_LINK_FREQ_LEGACY) { Is the strict 80 columns limit really necessary, as it would decrease readability? Best regards, André

[PATCH v4 2/2] selftests/futex: Create test for robust list

2024-12-12 Thread André Almeida
another task - Using the list_op_pending field from robust_list_head struct to test robustness when the lock owner dies before completing the locking - Setting a invalid size for syscall argument `len` Signed-off-by: André Almeida --- Changes from v2: - Dropped kselftest_harness include, using

[PATCH v4 1/2] selftests/futex: Add ASSERT_ macros

2024-12-12 Thread André Almeida
Create ASSERT_{EQ, NE, TRUE, FALSE} macros to make test creation easier. Signed-off-by: André Almeida --- .../testing/selftests/futex/include/logging.h | 28 +++ 1 file changed, 28 insertions(+) diff --git a/tools/testing/selftests/futex/include/logging.h b/tools/testing

[PATCH v4 0/2] selftests/futex: Create test for robust list

2024-12-12 Thread André Almeida
l.org/lkml/20241010011142.905297-1-andrealm...@igalia.com/ - Create ASSERT_ macros for futex selftests - Dropped kselftest_harness include, using just futex test API André Almeida (2): selftests/futex: Add ASSERT_ macros selftests/futex: Create test for robust list .../selftests/futex/functional/.gitignore

Re: [PATCH v3 07/12] media: i2c: imx214: Add vblank and hblank controls

2024-12-08 Thread André Apitzsch
and I'd like to hear back from Sakari regarding the > get_locked_active > > Thanks! > > On Sat, Dec 7, 2024 at 9:48 PM André Apitzsch via B4 Relay > wrote: > > > > From: André Apitzsch > > > > Add vblank control to allow changing the framerate / >

[PATCH v3 12/12] media: i2c: imx214: Fix link frequency

2024-12-07 Thread André Apitzsch via B4 Relay
From: André Apitzsch The driver defines IMX214_DEFAULT_LINK_FREQ 48000, and then IMX214_DEFAULT_PIXEL_RATE ((IMX214_DEFAULT_LINK_FREQ * 8LL) / 10), which works out as 384MPix/s. (The 8 is 4 lanes and DDR.) Parsing the PLL registers with the defined 24MHz input. We're in single PLL mod

[PATCH v3 08/12] media: i2c: imx214: Implement vflip/hflip controls

2024-12-07 Thread André Apitzsch via B4 Relay
From: André Apitzsch The imx214 sensor supports horizontal and vertical flipping. Add appropriate controls to the driver. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 69 -- 1 file changed, 61 insertions

[PATCH v3 00/12] media: i2c: imx214: Miscellaneous cleanups and improvements

2024-12-07 Thread André Apitzsch via B4 Relay
This patch series is a collection of miscellaneous cleanups and improvements to the imx214 driver. The series converts the driver to the CCI helpers and adds controls needed to make the driver work with libcamera. The changes are inspired by the imx219 driver. Signed-off-by: André Apitzsch

[PATCH v3 02/12] media: i2c: imx214: Simplify with dev_err_probe()

2024-12-07 Thread André Apitzsch via B4 Relay
From: André Apitzsch Error handling in probe() can be a bit simpler with dev_err_probe(). Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 52 -- 1 file changed, 22 insertions(+), 30 deletions(-) diff --git

[PATCH v3 10/12] media: i2c: imx214: Verify chip ID

2024-12-07 Thread André Apitzsch via B4 Relay
From: André Apitzsch Check the chip ID and stop probing if it is no imx214 sensor. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/media/i2c/imx214.c b/drivers

[PATCH v3 05/12] media: i2c: imx214: Drop IMX214_REG_EXPOSURE from mode reg arrays

2024-12-07 Thread André Apitzsch via B4 Relay
From: André Apitzsch The IMX214_REG_EXPOSURE is configured twice, once with a hardcoded value in the mode_ registers arrays, and once via v4l2_ctrl_ops. The latter is enough, drop the former. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 2 -- 1

[PATCH v3 07/12] media: i2c: imx214: Add vblank and hblank controls

2024-12-07 Thread André Apitzsch via B4 Relay
From: André Apitzsch Add vblank control to allow changing the framerate / higher exposure values. The vblank and hblank controls are needed for libcamera support. While at it, fix the minimal exposure time according to the datasheet. Signed-off-by: André Apitzsch --- drivers/media/i2c

[PATCH v3 04/12] media: i2c: imx214: Replace register addresses with macros

2024-12-07 Thread André Apitzsch via B4 Relay
From: André Apitzsch Define macros for all the known registers used in the register arrays, and use them to replace the numerical addresses. This improves readability. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 407

[PATCH v3 11/12] media: i2c: imx214: Add test pattern control

2024-12-07 Thread André Apitzsch via B4 Relay
From: André Apitzsch This adds V4L2_CID_TEST_PATTERN control support. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 77 -- 1 file changed, 75 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c

[PATCH v3 06/12] media: i2c: imx214: Check number of lanes from device tree

2024-12-07 Thread André Apitzsch via B4 Relay
From: André Apitzsch The imx214 camera is capable of either two-lane or four-lane operation. Currently only the four-lane mode is supported, as proper pixel rates and link frequences for the two-lane mode are unknown. Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 16

[PATCH v3 09/12] media: i2c: imx214: Add analogue/digital gain control

2024-12-07 Thread André Apitzsch via B4 Relay
From: André Apitzsch The imx214 sensor supports analogue gain up to 8x and digital gain up to 16x. Implement the corresponding controls in the driver. Default gain values are not modified by this patch. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c

[PATCH v3 01/12] media: i2c: imx214: Use subdev active state

2024-12-07 Thread André Apitzsch via B4 Relay
From: André Apitzsch Port the imx214 sensor driver to use the subdev active state. Move all the format configuration to the subdevice state and simplify the format handling, locking and initialization. While at it, simplify imx214_start_streaming() by removing unneeded goto statements and the

[PATCH v3 03/12] media: i2c: imx214: Convert to CCI register access helpers

2024-12-07 Thread André Apitzsch via B4 Relay
From: André Apitzsch Use the new common CCI register access helpers to replace the private register access helpers in the imx214 driver. This simplifies the driver by reducing the amount of code. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/Kconfig | 1

[RESEND v3 1/1] selftests/futex: Create test for robust list

2024-12-03 Thread André Almeida
another task - Using the list_op_pending field from robust_list_head struct to test robustness when the lock owner dies before completing the locking - Setting a invalid size for syscall argument `len` Signed-off-by: André Almeida --- Changes from v2: - Dropped kselftest_harness include, using

Re: [PATCH v2 09/13] media: i2c: imx214: Extract format and crop settings

2024-12-01 Thread André Apitzsch
Hi, I'll drop this patch for now. The changes included are not needed to make imx214 work with libcamera. And with [1] the patch might need a rework anyway. Best regards, André [1] https://lore.kernel.org/linux-media/20241129095142.87196-1-sakari.ai...@linux.intel.com/ Am Montag

Re: [PATCH v2 02/13] media: i2c: imx214: Use subdev active state

2024-12-01 Thread André Apitzsch
Hi, Am Mittwoch, dem 30.10.2024 um 12:36 +0100 schrieb Ricardo Ribalda Delgado: > Hi > > It looks good to me, but I would like Sakari to review it. I am not > sure if it is ok to keep the cur_mode variable. > > On Mon, Oct 21, 2024 at 12:14 AM André Apitzsch via B4 Relay >

Re: [PATCH v2 09/13] media: i2c: imx214: Extract format and crop settings

2024-11-20 Thread André Apitzsch
ed by the user. Is it right, that .set_selection needs to be implemented to change that? The different values are set programmatically to reduce the number of entries in the cci reg sequences to make it easier to add more modes later. Regards, André > > On Mon, Oct 21, 2024 at 12:14 A

Re: [PATCH v2 07/13] media: i2c: imx214: Check number of lanes from device tree

2024-10-30 Thread André Apitzsch
Hi Ricardo, Am Mittwoch, dem 30.10.2024 um 12:38 +0100 schrieb Ricardo Ribalda Delgado: > On Mon, Oct 21, 2024 at 12:14 AM André Apitzsch via B4 Relay > wrote: > > > > From: André Apitzsch > > > > The imx214 camera is capable of either two-lane or four-lane >

[PATCH v2 05/13] media: i2c: imx214: Replace register addresses with macros

2024-10-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch Define macros for all the known registers used in the register arrays, and use them to replace the numerical addresses. This improves readability. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 407

[PATCH v2 12/13] media: i2c: imx214: Verify chip ID

2024-10-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch Check the chip ID and stop probing if it is no imx214 sensor. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/media/i2c/imx214.c b/drivers

[PATCH v2 11/13] media: i2c: imx214: Add analogue/digital gain control

2024-10-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch The imx214 sensor supports analogue gain up to 8x and digital gain up to 16x. Implement the corresponding controls in the driver. Default gain values are not modified by this patch. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c

[PATCH v2 08/13] media: i2c: imx214: Add vblank and hblank controls

2024-10-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch Add vblank control to allow changing the framerate / higher exposure values. The vblank and hblank controls are needed for libcamera support. While at it, fix the minimal exposure time according to the datasheet. Signed-off-by: André Apitzsch --- drivers/media/i2c

[PATCH v2 07/13] media: i2c: imx214: Check number of lanes from device tree

2024-10-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch The imx214 camera is capable of either two-lane or four-lane operation. Currently only the four-lane mode is supported, as proper pixel rates and link frequences for the two-lane mode are unknown. Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 26

[PATCH v2 04/13] media: i2c: imx214: Convert to CCI register access helpers

2024-10-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch Use the new common CCI register access helpers to replace the private register access helpers in the imx214 driver. This simplifies the driver by reducing the amount of code. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/Kconfig | 1

[PATCH v2 10/13] media: i2c: imx214: Implement vflip/hflip controls

2024-10-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch The imx214 sensor supports horizontal and vertical flipping. Add appropriate controls to the driver. Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 69 -- 1 file changed, 61 insertions(+), 8 deletions(-) diff

[PATCH v2 13/13] media: i2c: imx214: Add test pattern control

2024-10-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch This adds V4L2_CID_TEST_PATTERN control support. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 77 -- 1 file changed, 75 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c

[PATCH v2 06/13] media: i2c: imx214: Drop IMX214_REG_EXPOSURE from mode reg arrays

2024-10-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch The IMX214_REG_EXPOSURE is configured twice, once with a hardcoded value in the mode_ registers arrays, and once via v4l2_ctrl_ops. The latter is enough, drop the former. Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 2 -- 1

[PATCH v2 09/13] media: i2c: imx214: Extract format and crop settings

2024-10-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch Remove format and crop settings from register sequences and set them programmatically. Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 129 ++--- 1 file changed, 97 insertions(+), 32 deletions(-) diff --git a/drivers

[PATCH v2 02/13] media: i2c: imx214: Use subdev active state

2024-10-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch Port the imx214 sensor driver to use the subdev active state. Move all the format configuration to the subdevice state and simplify the format handling, locking and initialization. While at it, simplify imx214_start_streaming() by removing unneeded goto statements and the

[PATCH v2 03/13] media: i2c: imx214: Simplify with dev_err_probe()

2024-10-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch Error handling in probe() can be a bit simpler with dev_err_probe(). Acked-by: Ricardo Ribalda Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 52 -- 1 file changed, 22 insertions(+), 30 deletions(-) diff --git

[PATCH v2 01/13] media: i2c: imx214: Fix link frequency

2024-10-20 Thread André Apitzsch via B4 Relay
From: André Apitzsch The driver defines IMX214_DEFAULT_LINK_FREQ 48000, and then IMX214_DEFAULT_PIXEL_RATE ((IMX214_DEFAULT_LINK_FREQ * 8LL) / 10), which works out as 384MPix/s. (The 8 is 4 lanes and DDR.) Parsing the PLL registers with the defined 24MHz input. We're in single PLL mod

[PATCH v2 00/13] media: i2c: imx214: Miscellaneous cleanups and improvements

2024-10-20 Thread André Apitzsch via B4 Relay
This patch series is a collection of miscellaneous cleanups and improvements to the imx214 driver. The series converts the driver to the CCI helpers and adds controls needed to make the driver work with libcamera. The changes are inspired by the imx219 driver. Signed-off-by: André Apitzsch

Re: [PATCH 08/13] media: i2c: imx214: Add vblank and hblank controls

2024-10-12 Thread André Apitzsch
Hi Dave, Am Montag, dem 07.10.2024 um 18:29 +0100 schrieb Dave Stevenson: > Hi Andre > > On Sun, 6 Oct 2024 at 22:41, André wrote: > > > > Hi Dave, > > > > Am Freitag, dem 13.09.2024 um 18:40 +0100 schrieb Dave Stevenson: > > > On Thu, 12 Sept

[PATCH v3 2/2] selftests/futex: Create test for robust list

2024-10-09 Thread André Almeida
another task - Using the list_op_pending field from robust_list_head struct to test robustness when the lock owner dies before completing the locking - Setting a invalid size for syscall argument `len` Signed-off-by: André Almeida --- Changes from v2: - Dropped kselftest_harness include, using

[PATCH v3 1/2] selftests/futex: Add ASSERT_ macros

2024-10-09 Thread André Almeida
Create ASSERT_{EQ, NE, TRUE, FALSE} macros to make test creation easier. Signed-off-by: André Almeida --- .../testing/selftests/futex/include/logging.h | 28 +++ 1 file changed, 28 insertions(+) diff --git a/tools/testing/selftests/futex/include/logging.h b/tools/testing

[PATCH v3 0/2] selftests/futex: Create test for robust list

2024-10-09 Thread André Almeida
/20240903134033.816500-1-andrealm...@igalia.com André Almeida (2): selftests/futex: Add ASSERT_ macros selftests/futex: Create test for robust list .../selftests/futex/functional/.gitignore | 1 + .../selftests/futex/functional/Makefile | 3 +- .../selftests/futex/functional/robust_list.c | 512

Re: [PATCH 09/13] media: i2c: imx214: Extract format and crop settings

2024-10-06 Thread André
Hi Ricardo, Am Donnerstag, dem 12.09.2024 um 15:40 +0200 schrieb Ricardo Ribalda Delgado: > On Mon, Sep 2, 2024 at 11:54 PM André Apitzsch via B4 Relay > wrote: > > > > From: André Apitzsch > > > > Remove format and crop settings from register sequences and set

Re: [PATCH 08/13] media: i2c: imx214: Add vblank and hblank controls

2024-10-06 Thread André
Hi Dave, Am Freitag, dem 13.09.2024 um 18:40 +0100 schrieb Dave Stevenson: > On Thu, 12 Sept 2024 at 15:51, Dave Stevenson > wrote: > > > > Hi André & Ricardo > > > > On Thu, 12 Sept 2024 at 14:41, Ricardo Ribalda Delgado > > wrote: > > > >

Re: [PATCH 0/1] Add KUnit tests for lib/crc16.c

2024-09-24 Thread André Almeida
Hey! On 9/23/24 01:26, Vinicius Peixoto wrote: Hi all, This patch was developed during a hackathon organized by LKCAMP [1], with the objective of writing KUnit tests, both to introduce people to the kernel development process and to learn about different subsystems (with the positive side effec

Re: [PATCH RESEND] selftests/futex: Order calls in futex_requeue

2024-09-04 Thread André Almeida
2 not ok 1 futex_requeue simple returned: 0 not ok 2 futex_requeue simple returned: 0 not ok 3 futex_requeue many returned: 0 not ok 4 futex_requeue many returned: 0 Instead, replace the sleep with barriers to make the sequencing explicit. Reviewed-by: André Almeida

[PATCH v2] selftests/futex: Create test for robust list

2024-09-03 Thread André Almeida
Create a test for the robust list mechanism. Signed-off-by: André Almeida --- Changes from v1: - Change futex type from int to _Atomic(unsigned int) - Use old futex(FUTEX_WAIT) instead of the new sys_futex_wait() --- .../selftests/futex/functional/.gitignore | 1 + .../selftests/futex

[PATCH 09/13] media: i2c: imx214: Extract format and crop settings

2024-09-02 Thread André Apitzsch via B4 Relay
From: André Apitzsch Remove format and crop settings from register sequences and set them programmatically. Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 137 ++--- 1 file changed, 105 insertions(+), 32 deletions(-) diff --git a

[PATCH 13/13] media: i2c: imx214: Add test pattern control

2024-09-02 Thread André Apitzsch via B4 Relay
From: André Apitzsch This adds V4L2_CID_TEST_PATTERN control support. Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 77 -- 1 file changed, 75 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c

[PATCH 12/13] media: i2c: imx214: Verify chip ID

2024-09-02 Thread André Apitzsch via B4 Relay
From: André Apitzsch Check the chip ID and stop probing if it is no imx214 sensor. Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c index

[PATCH 06/13] media: i2c: imx214: Drop IMX214_REG_EXPOSURE from mode reg arrays

2024-09-02 Thread André Apitzsch via B4 Relay
From: André Apitzsch The IMX214_REG_EXPOSURE is configured twice, once with a hardcoded value in the mode_ registers arrays, and once via v4l2_ctrl_ops. The latter is enough, drop the former. Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 2 -- 1 file changed, 2 deletions

[PATCH 11/13] media: i2c: imx214: Add analogue/digital gain control

2024-09-02 Thread André Apitzsch via B4 Relay
From: André Apitzsch The imx214 sensor supports analogue gain up to 8x and digital gain up to 16x. Implement the corresponding controls in the driver. Default gain values are not modified by this patch. Signed-off-by: André Apitzsch --- With the analogue gain control added by this patch, the

[PATCH 10/13] media: i2c: imx214: Implement vflip/hflip controls

2024-09-02 Thread André Apitzsch via B4 Relay
From: André Apitzsch The imx214 sensor supports horizontal and vertical flipping. Add appropriate controls to the driver. Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 73 +- 1 file changed, 65 insertions(+), 8 deletions(-) diff

[PATCH 05/13] media: i2c: imx214: Replace register addresses with macros

2024-09-02 Thread André Apitzsch via B4 Relay
From: André Apitzsch Define macros for all the known registers used in the register arrays, and use them to replace the numerical addresses. This improves readability. Signed-off-by: André Apitzsch --- drivers/media/i2c/imx214.c | 407 ++--- 1 file

[PATCH 04/13] media: i2c: imx214: Convert to CCI register access helpers

2024-09-02 Thread André Apitzsch via B4 Relay
From: André Apitzsch Use the new common CCI register access helpers to replace the private register access helpers in the imx214 driver. This simplifies the driver by reducing the amount of code. Signed-off-by: André Apitzsch --- drivers/media/i2c/Kconfig | 1 + drivers/media/i2c/imx214.c

[PATCH 08/13] media: i2c: imx214: Add vblank and hblank controls

2024-09-02 Thread André Apitzsch via B4 Relay
From: André Apitzsch Add vblank control to allow changing the framerate / higher exposure values. The vblank and hblank controls are needed for libcamera support. While at it, fix the minimal exposure time according to the datasheet. Signed-off-by: André Apitzsch --- drivers/media/i2c

  1   2   3   4   5   6   7   8   >