Re: [PATCH v2] include/linux/byteorder/generic.h: fix signed/unsigned warnings

2019-10-21 Thread Anatol Belski
oise. > > Signed-off-by: Anatol Belski > > --- > > Changelog is missing. > (No need to resend just for this, it's for your future contributions) > Thanks for pointing to this. I also probably should have added a Cc:. Will go through the submitting patches document more carefully. Thanks! anatol

[PATCH v2] include/linux/byteorder/generic.h: fix signed/unsigned warnings

2019-10-21 Thread Anatol Belski
From: Anatol Belski This fixes the warnings like below, thrown by GCC warning: comparison of integer expressions of different signedness: \ ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare] 195 | for (i = 0; i < len; i++) |^ Signed-off-by: Anatol Bel

Re: [PATCH] include/linux/byteorder/generic.h: fix signed/unsigned warnings

2019-10-21 Thread Anatol Belski
Hi, On Mon, 2019-10-21 at 09:52 +0300, Andy Shevchenko wrote: > On Sun, Oct 20, 2019 at 05:22:30PM +0000, Anatol Belski wrote: > > From: Anatol Belski > > Better to add commit message even for small patches like this. > Do you have compiler / sparse / etc warning? Cite it her

Re: byteorder: cpu_to_le32_array vs cpu_to_be32_array function API differences

2019-10-20 Thread Anatol Belski
On Sun, 2019-10-20 at 12:40 -0700, Joe Perches wrote: > On Sun, 2019-10-20 at 19:28 +0000, Anatol Belski wrote: > > Hi, > > Hello. > > > On Sun, 2019-10-20 at 12:02 -0700, Joe Perches wrote: > > > There's an argument inconsistency between these 4 func

Re: byteorder: cpu_to_le32_array vs cpu_to_be32_array function API differences

2019-10-20 Thread Anatol Belski
Hi, On Sun, 2019-10-20 at 12:02 -0700, Joe Perches wrote: > There's an argument inconsistency between these 4 functions > in include/linux/byteorder/generic.h > > It'd be more a consistent API with one form and not two. > >static inline void le32_to_cpu_array(u32 *buf, unsigned int words) >

[PATCH] include/linux/byteorder/generic.h: fix signed/unsigned warnings

2019-10-20 Thread Anatol Belski
From: Anatol Belski Signed-off-by: Anatol Belski --- include/linux/byteorder/generic.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/byteorder/generic.h b/include/linux/byteorder/generic.h index 4b13e0a3e15b..c9a4c96c9943 100644 --- a/include/linux