On Sat, Feb 6, 2021 at 12:07 PM Jakub Kicinski wrote:
>
> On Fri, 5 Feb 2021 16:01:43 -0800 Amy Parker wrote:
> > This patchset updates atarilance.c and sun3lance.c to follow the kernel
> > style guide. Each patch tackles a different issue in the style guide.
>
> These ar
On Sat, Feb 6, 2021 at 8:07 AM John Paul Adrian Glaubitz
wrote:
>
> Hi Amy!
>
> On 2/5/21 11:06 PM, Amy Parker wrote:
> > Some statements do not have proper spacing between their C
> > keywords (commonly if and for) throughout files in the ia64 tree.
> > This pat
On Fri, Feb 5, 2021 at 7:16 PM Randy Dunlap wrote:
>
> On 2/5/21 4:01 PM, Amy Parker wrote:
> > This patchset updates atarilance.c and sun3lance.c to follow the kernel
> > style guide. Each patch tackles a different issue in the style guide.
> >
> >
Some statements do not have proper spacing between their C
keywords (commonly if and for) throughout files in the ia64 tree.
This patch corrects this to follow the kernel code style guide.
Signed-off-by: Amy Parker
---
arch/ia64/hp/common/sba_iommu.c | 6 +++---
arch/ia64/kernel
Many C keywords and their statements are not formatted correctly
per the kernel style guide. Their spacing makes them harder to read
and to maintain. This patch updates their spacing to follow the
style guide.
Signed-off-by: Amy Parker
---
drivers/net/ethernet/amd/atarilance.c | 36
Some statements - often if statements - do not follow the kernel
style guide regarding what lines brackets and pairs should be on.
This patch fixes those style violations.
Signed-off-by: Amy Parker
---
drivers/net/ethernet/amd/atarilance.c | 13 +
drivers/net/ethernet/amd
Some expressions using C keywords - especially if expressions - are
crammed onto one line. The kernel style guide indicates not to do
this, as it harms readability. This patch splits these one-lined
statements into two lines.
Signed-off-by: Amy Parker
---
drivers/net/ethernet/amd/atarilance.c
On Fri, Feb 5, 2021 at 2:37 PM Richard Weinberger
wrote:
>
> On Fri, Feb 5, 2021 at 11:26 PM Amy Parker wrote:
> >
> > On Fri, Feb 5, 2021 at 5:1 AM David Sterba wrote:
> > >
> > > On Thu, Feb 04, 2021 at 08:52:14PM -0800, Amy Parker wrote:
> > >
This patchset updates atarilance.c and sun3lance.c to follow the kernel
style guide. Each patch tackles a different issue in the style guide.
-Amy IP
Amy Parker (3):
drivers/net/ethernet/amd: Correct spacing around C keywords
drivers/net/ethernet/amd: Fix bracket matching and line levels
On Fri, Feb 5, 2021 at 5:1 AM David Sterba wrote:
>
> On Thu, Feb 04, 2021 at 08:52:14PM -0800, Amy Parker wrote:
> > As the EFS driver is old and non-maintained,
>
> Is anybody using EFS on current kernels? There's not much point updating
> it to current coding style, d
Some statements - such as if statements - are not broken into their
lines correctly. For example, some are expressed on a single line.
Single line if statements are expressely prohibited by the style guide.
This patch corrects these violations.
Signed-off-by: Amy Parker
---
fs/efs/inode.c
- Corrected line breakage for C keywords
Amy Parker (3):
fs/efs: Use correct brace styling for statements
fs/efs: Correct spacing after C keywords
fs/efs: Fix line breakage for C keywords
fs/efs/inode.c | 36 ++--
fs/efs/namei.c | 2 +-
fs/efs/super.c | 25
On Thu, Feb 4, 2021 at 9:09 PM Chaitanya Kulkarni
wrote:
>
> On 2/4/21 21:01, Amy Parker wrote:
> >> Commit message is too long. Follow the style present in the tree.
> > Are you referring to the per-line length? That was supposed to have
> > been broken up, my apol
In EFS code, some C keywords (most commonly 'for') do not have spaces
before their instructions, such as for() vs for (). The kernel style
guide indicates that these should be of the latter variant. This patch
updates them accordingly.
Signed-off-by: Amy Parker
---
fs/efs/in
patch fixes these style violations. Single-line statements that
have braces have had their braces stripped. Pair single-line statements
have been formatted per the style guide. Pair mixed-line statements have
had their braces updated to conform.
Signed-off-by: Amy Parker
---
fs/efs/inode.c | 10
On Thu, Feb 4, 2021 at 8:57 PM Chaitanya Kulkarni
wrote:
>
> On 2/4/21 20:55, Amy Parker wrote:
> > Many single-line statements have unnecessary braces, and some statement
> > pairs have mismatched braces. This is a clear violation of the kernel style
> > guide, which m
Some statements - such as if statements - are not broken into their lines
correctly. For example, some are expressed on a single line. Single line if
statements are expressely prohibited by the style guide. This patch corrects
these violations.
Signed-off-by: Amy Parker
---
fs/efs/inode.c
In EFS code, some C keywords (most commonly 'for') do not have spaces before
their instructions, such as for() vs for (). The kernel style guide indicates
that these should be of the latter variant. This patch updates them accordingly.
Signed-off-by: Amy Parker
---
fs/efs/in
patch fixes these style violations. Single-line statements that have
braces have had their braces stripped. Pair single-line statements have been
formatted per the style guide. Pair mixed-line statements have had their braces
updated to conform.
Signed-off-by: Amy Parker
---
fs/efs/inode.c | 10
As the EFS driver is old and non-maintained, many kernel style guide
rules have not been followed, and their violations have not been
noticed. This patchset corrects those violations.
Amy Parker (3):
fs/efs: Use correct brace styling for statements
fs/efs: Correct spacing after C keywords
On Tue, Feb 2, 2021 at 8:26 AM Amy Parker wrote:
> > It compiles extremely fast, implements some subsets of gcc (a few
> > attributes for example), but is far from being able to compile a kernel
>
> Well, we'll see what I can do with that. :)
Well, just installed it and tr
On Mon, Feb 1, 2021 at 9:33 PM Willy Tarreau wrote:
>
> Hi Amy,
>
> On Mon, Feb 01, 2021 at 03:31:49PM -0800, Amy Parker wrote:
> > Hello! My name's Amy. I'm really impressed by the work done to make
> > Clang (and the LLVM toolchain overall) able to compile
On Mon, Feb 1, 2021 at 4:15 PM Alex Elder wrote:
>
> On 2/1/21 6:02 PM, Amy Parker wrote:
> > On Mon, Feb 1, 2021 at 3:32 PM Alex Elder wrote:
> >>
> >> When extracting the destination endpoint ID from the status in
> >> ipa_endpoint_status_skip(), u
.26.2
>
Can't test this - don't have an MP600 of my own to test with - but it
should work just fine. If anyone else has an MP600 to throw at this
that'd be great.
Acked-by: Amy Parker
Best regards,
Amy Parker
(she/her/hers)
read32(virt + GSI_CH_C_CNTXT_0_OFFSET(channel_id));
> --
> 2.27.0
>
Seems pretty straightforward to me, ioread32 expects an
__iomem-annotated pointer.
Reviewed-by: Amy Parker
On Mon, Feb 1, 2021 at 4:02 PM Amy Parker wrote:
> > Fix this by using u8_get_bits() to get the destination endpoint ID.
>
> Isn't
>
Apologies about this - premature email sending. This was simply going
to be "Isn't endpoint_id u32?", which was addressed later
return true;
>
> --
> 2.27.0
>
As far as I see it, using u32_get_bits instead of u8_get_bits simply
eliminates confusion about the type of endpoint_id. Perhaps instead of
this patch, send a patch with a comment that while u32_get_bits is
used, the field is only 8 bits?
Best regards,
Amy Parker
(she/her/hers)
ct attribute *swap_attrs[] = {
> NULL,
> };
>
> -static struct attribute_group swap_attr_group = {
> +static const struct attribute_group swap_attr_group = {
> .attrs = swap_attrs,
> };
>
> --
> 2.30.0
>
Looks all good to me - there aren't any dependencies on it anywhere else.
Reviewed-by: Amy Parker
same arguments structure as GCC and Clang (read: you can pass it
in as CC=compilername in your $MAKEOPTS). Any compilers along that
route anyone here has worked with that I could work with?
Best regards,
Amy Parker
(she/her/hers)
;ll find that none of them are solo endeavors, and all
> of them have multiple companies who are employing the developers who
> work on them. Figuring out how to convince companies that there are
> good business reasons for them to support the developers of your file
> system is im
On Wed, Jan 27, 2021 at 9:08 AM Kari Argillander
wrote:
>
> On Tue, Jan 26, 2021 at 12:58:05PM -0800, Amy Parker wrote:
> > This patch updates inode.c for EFS to follow the kernel style guide.
>
> > +++ b/fs/efs/inode.c
> > @@ -109,9 +109,9 @@ struct inode *efs_ige
On Tue, Jan 26, 2021 at 7:59 PM Randy Dunlap wrote:
>
> On 1/26/21 7:46 PM, Randy Dunlap wrote:
> > Hi Amy,
> >
> > What mail client did you use?
> > It is breaking (splitting) long lines into shorter lines and that
> > makes it not possible to apply the patch cleanly.
Was worried about that, tho
This patch updates various styling in namei.c and super.c to follow
the kernel style guide.
Signed-off-by: Amy Parker
---
fs/efs/namei.c | 2 +-
fs/efs/super.c | 13 +++--
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/fs/efs/namei.c b/fs/efs/namei.c
index 38961ee1d1af
come and fix up something in EFS in an emergency,
probably a good idea to have the code as neat as possible.
Amy Parker (2):
fs/efs/inode.c: follow style guide
fs/efs: fix style guide for namei.c and super.c
fs/efs/inode.c | 64 +-
fs/efs/namei.c
This patch updates inode.c for EFS to follow the kernel style guide.
Signed-off-by: Amy Parker
---
fs/efs/inode.c | 64 +-
1 file changed, 32 insertions(+), 32 deletions(-)
diff --git a/fs/efs/inode.c b/fs/efs/inode.c
index 89e73a6f0d36
On Tue, Jan 26, 2021 at 11:18 AM Matthew Wilcox wrote:
>
> On Tue, Jan 26, 2021 at 08:23:03AM -0800, Amy Parker wrote:
> > Kernel development newcomer here. I've begun creating a concept for a
> > new filesystem, and ideally once it's completed, rich, and stable I&
On Tue, Jan 26, 2021 at 11:06 AM Chaitanya Kulkarni
wrote:
>
> Amy,
>
> On 1/26/21 8:26 AM, Amy Parker wrote:
> > Kernel development newcomer here. I've begun creating a concept for a
> > new filesystem, and ideally once it's completed, rich, and stable I&#
On Tue, Jan 26, 2021 at 9:15 AM Andreas Dilger wrote:
>
> On Jan 26, 2021, at 09:25, Amy Parker wrote:
> >
> > Kernel development newcomer here. I've begun creating a concept for a
> > new filesystem, and ideally once it's completed, rich, and stable I&#
ach other, and sending in tons of
dependent patches doesn't sound like a great idea. I've seen requests
for pulls, but since I'm new here I don't really know what to do.
Thank you for guidance!
Best regards,
Amy Parker
she/her/hers
n the drivers/ folder level? If such is the case, what should said folder
be entitled?
Best regards,
Amy Parker
Please refer to me using singular they/them/theirs pronouns.
40 matches
Mail list logo
