Re: rsi_91x: Failed to read status register on failed authentication

2017-12-05 Thread Amitkumar Karwar
On Tue, Dec 5, 2017 at 9:41 PM, Alexey Brodkin wrote: > Hi Amit, > > I'm seeing quite a strange behavior of RedPine module. > It connects perfectly fine to one of access points but fails > to connect to another. > > Moreover after that failure RSI driver starts to flood me with > messages saying:

RE: Re: [PATCH v2 2/3] mwifiex: pcie: don't loop/retry interrupt status checks

2017-01-18 Thread Amitkumar Karwar
Hi Brian, > From: Brian Norris [mailto:briannor...@chromium.org] > Sent: Wednesday, January 18, 2017 1:18 AM > To: Dmitry Torokhov > Cc: Amitkumar Karwar; Nishant Sarmukadam; linux-kernel@vger.kernel.org; > Kalle Valo; linux-wirel...@vger.kernel.org; Cathy Luo > Subject:

RE: [PATCH] btusb: fix zero BD address problem during stress test

2016-12-06 Thread Amitkumar Karwar
Hi Marcel, > From: Amitkumar Karwar > Sent: Friday, November 25, 2016 4:51 PM > To: 'Marcel Holtmann' > Cc: 'linux-blueto...@vger.kernel.org'; 'linux-kernel@vger.kernel.org'; > Cathy Luo; Nishant Sarmukadam; Ganapathi Bhat > Subject: RE: [PATCH]

RE: [PATCH] btusb: fix zero BD address problem during stress test

2016-11-25 Thread Amitkumar Karwar
Hi Marcel, > From: Amitkumar Karwar > Sent: Wednesday, November 23, 2016 3:14 PM > To: 'Marcel Holtmann' > Cc: linux-blueto...@vger.kernel.org; linux-kernel@vger.kernel.org; > Cathy Luo; Nishant Sarmukadam; Ganapathi Bhat > Subject: RE: [PATCH] btusb: fix zero BD a

RE: [PATCH] mwifiex: pcie: implement timeout loop for FW programming doorbell

2016-11-24 Thread Amitkumar Karwar
> From: Brian Norris [mailto:briannor...@chromium.org] > Sent: Wednesday, November 23, 2016 8:10 AM > To: Amitkumar Karwar; Nishant Sarmukadam > Cc: linux-kernel@vger.kernel.org; Kalle Valo; linux- > wirel...@vger.kernel.org; Cathy Luo; Dmitry Torokhov; Brian Norris > Subjec

RE: [PATCH] btusb: fix zero BD address problem during stress test

2016-11-23 Thread Amitkumar Karwar
Hi Marcel, > From: Marcel Holtmann [mailto:mar...@holtmann.org] > Sent: Wednesday, November 23, 2016 1:46 PM > To: Amitkumar Karwar > Cc: linux-blueto...@vger.kernel.org; linux-kernel@vger.kernel.org; > Cathy Luo; Nishant Sarmukadam; Ganapathi Bhat > Subject: Re: [PATCH]

RE: [PATCH] btusb: fix zero BD address problem during stress test

2016-11-15 Thread Amitkumar Karwar
Hi Marcel, > From: Amitkumar Karwar [mailto:akar...@marvell.com] > Sent: Tuesday, October 18, 2016 6:27 PM > To: linux-blueto...@vger.kernel.org > Cc: mar...@holtmann.org; linux-kernel@vger.kernel.org; Cathy Luo; > Nishant Sarmukadam; Ganapathi Bhat; Amitkumar Karwar > Subject:

RE: [PATCH] mwifiex: fix memory leak in mwifiex_save_hidden_ssid_channels()

2016-11-09 Thread Amitkumar Karwar
> From: Ricky Liang [mailto:jcli...@chromium.org] > Sent: Wednesday, November 09, 2016 9:07 AM > Cc: Ricky Liang; Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo; open > list:MARVELL MWIFIEX WIRELESS DRIVER; open list:NETWORKING DRIVERS; open > list > Subject: [PATCH] mwifiex:

RE: [PATCH] mwifiex: printk() overflow with 32-byte SSIDs

2016-11-08 Thread Amitkumar Karwar
> From: Brian Norris [mailto:briannor...@chromium.org] > Sent: Wednesday, November 09, 2016 7:58 AM > To: Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo > Cc: linux-kernel@vger.kernel.org; linux-wirel...@vger.kernel.org; Cathy > Luo; secur...@kernel.org; sta...@vger.kernel.or

[PATCH] btusb: fix zero BD address problem during stress test

2016-10-18 Thread Amitkumar Karwar
This patch handles the corner case to resolve zero BD address problem. Signed-off-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- drivers/bluetooth/btusb.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 811f9b

RE: mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

2016-09-08 Thread Amitkumar Karwar
Hi Javier, > From: Javier Martinez Canillas [mailto:jav...@osg.samsung.com] > Sent: Tuesday, September 06, 2016 5:43 PM > To: Kalle Valo > Cc: linux-kernel@vger.kernel.org; Amitkumar Karwar; > net...@vger.kernel.org; linux-wirel...@vger.kernel.org; Nishant > Sarmukadam; Arend va

[PATCH v13 3/3] Bluetooth: hci_uart: Support firmware download for Marvell

2016-09-08 Thread Amitkumar Karwar
From: Ganapathi Bhat This patch implement firmware download feature for Marvell Bluetooth devices. If firmware is already downloaded, it will skip downloading. Signed-off-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- v2: Fixed compilation warning reported by kbuild test robot v3

[PATCH v13 1/3] Bluetooth: hci_uart: add prepare callbacks to hci_uart_proto structure.

2016-09-08 Thread Amitkumar Karwar
ff-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- drivers/bluetooth/hci_ldisc.c | 11 ++- drivers/bluetooth/hci_uart.h | 3 +++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c index dda9739..d7184dc 1

[PATCH v13 2/3] Bluetooth: hci_uart: check if hdev is present before using it

2016-09-08 Thread Amitkumar Karwar
From: Ganapathi Bhat The hdev struct might not have initialized in protocol receive handler. This patch adds necessary checks. Signed-off-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- drivers/bluetooth/hci_ldisc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

RE: [PATCH v12 3/3] Bluetooth: hci_uart: Support firmware download for Marvell

2016-09-08 Thread Amitkumar Karwar
Hi Loic, Thanks for your comments. > -Original Message- > From: Loic Poulain [mailto:loic.poul...@intel.com] > Sent: Tuesday, August 16, 2016 1:20 PM > To: Amitkumar Karwar; linux-blueto...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; linux-rockc...@lists.infra

RE: mwifiex: PCIe8997 chip specific handling

2016-09-07 Thread Amitkumar Karwar
Hi Kalle, > From: linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless- > ow...@vger.kernel.org] On Behalf Of Amitkumar Karwar > Sent: Thursday, August 11, 2016 4:11 PM > To: Steve deRosier > Cc: Brian Norris; linux-wirel...@vger.kernel.org; Cathy Luo; Nishant > Sarmuk

RE: mwifiex: PCIe8997 chip specific handling

2016-08-11 Thread Amitkumar Karwar
Hi Steve, > From: Steve deRosier [mailto:deros...@gmail.com] > Sent: Thursday, August 11, 2016 2:39 AM > To: Amitkumar Karwar > Cc: Brian Norris; linux-wirel...@vger.kernel.org; Cathy Luo; Nishant > Sarmukadam; linux-kernel@vger.kernel.org; Wei-Ning Huang > Subject: Re: mwif

RE: mwifiex: PCIe8997 chip specific handling

2016-08-10 Thread Amitkumar Karwar
Hi Brian, > From: Brian Norris [mailto:briannor...@chromium.org] > Sent: Wednesday, August 10, 2016 12:14 AM > To: Amitkumar Karwar > Cc: linux-wirel...@vger.kernel.org; Cathy Luo; Nishant Sarmukadam; > linux-kernel@vger.kernel.org > Subject: Re: mwifiex: PCIe8997 chip specifi

[PATCH v12 3/3] Bluetooth: hci_uart: Support firmware download for Marvell

2016-08-09 Thread Amitkumar Karwar
From: Ganapathi Bhat This patch implement firmware download feature for Marvell Bluetooth devices. If firmware is already downloaded, it will skip downloading. Signed-off-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar Tested-by: Jeffy Chen --- v2: Fixed compilation warning reported by

[PATCH v12 2/3] Bluetooth: hci_uart: check if hdev is present before using it

2016-08-09 Thread Amitkumar Karwar
From: Ganapathi Bhat The hdev struct might not have initialized in protocol receive handler. This patch adds necessary checks. Signed-off-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- drivers/bluetooth/hci_ldisc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH v12 1/3] Bluetooth: hci_uart: add prepare callbacks to hci_uart_proto structure.

2016-08-09 Thread Amitkumar Karwar
ff-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- drivers/bluetooth/hci_ldisc.c | 11 ++- drivers/bluetooth/hci_uart.h | 3 +++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c index dda9739..d7184dc 1

RE: [v11,3/3] Bluetooth: hci_uart: Support firmware download for Marvell

2016-08-09 Thread Amitkumar Karwar
Hi Loic, > -Original Message- > From: Loic Poulain [mailto:loic.poul...@intel.com] > Sent: Thursday, June 30, 2016 4:24 PM > To: Amitkumar Karwar; Jeffy Chen; linux-blueto...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; Ganapathi Bhat; Cathy Luo; Marcel > Holt

RE: [PATCH 1/1] mwifiex: key_material_v2 remove superfluous condition

2016-08-01 Thread Amitkumar Karwar
> From: Heinrich Schuchardt [mailto:xypron.g...@gmx.de] > Sent: Sunday, July 31, 2016 5:41 PM > To: Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo > Cc: linux-wirel...@vger.kernel.org; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; Heinrich Schuchardt > Subject: [

RE: [PATCH 1/1] mwifiex: remove superfluous condition

2016-08-01 Thread Amitkumar Karwar
> From: Heinrich Schuchardt [mailto:xypron.g...@gmx.de] > Sent: Sunday, July 31, 2016 4:09 PM > To: Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo > Cc: linux-wirel...@vger.kernel.org; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; Heinrich Schuchardt > Subject: [

[PATCH] Bluetooth: btmrvl: reset is_suspending flag in failure path

2016-07-15 Thread Amitkumar Karwar
is_suspending flag remains on when host sleep fails to enable. Data path is unnecessarily blocked after this. This patch ensures to reset the flag in failure path. Signed-off-by: Amitkumar Karwar --- drivers/bluetooth/btmrvl_sdio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

RE: [PATCH v4] mwifiex: Reduce endian conversion for REG Host Commands

2016-07-08 Thread Amitkumar Karwar
> From: Prasun Maiti [mailto:prasunmait...@gmail.com] > Sent: Monday, June 27, 2016 3:43 PM > To: Amitkumar Karwar > Cc: Nishant Sarmukadam; Linux Wireless; Linux Next; Linux Kernel; Kalle > Valo > Subject: [PATCH v4] mwifiex: Reduce endian conversion for REG Host > Commands

RE: [PATCH v4] mwifiex: Reduce endian conversion for REG Host Commands

2016-07-08 Thread Amitkumar Karwar
> From: linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless- > ow...@vger.kernel.org] On Behalf Of Kalle Valo > Sent: Friday, July 08, 2016 7:10 PM > To: Amitkumar Karwar > Cc: Prasun Maiti; Nishant Sarmukadam; Linux Wireless; Linux Next; Linux > Kernel > Subject: R

RE: [PATCH v4] mwifiex: Reduce endian conversion for REG Host Commands

2016-07-08 Thread Amitkumar Karwar
Hi Kalle, > From: Prasun Maiti [mailto:prasunmait...@gmail.com] > Sent: Monday, June 27, 2016 3:43 PM > To: Amitkumar Karwar > Cc: Nishant Sarmukadam; Linux Wireless; Linux Next; Linux Kernel; Kalle > Valo > Subject: [PATCH v4] mwifiex: Reduce endian conversion for REG Host &

RE: [PATCH v2] mwifiex: Fix endianness for event TLV type TLV_BTCOEX_WL_SCANTIME

2016-06-30 Thread Amitkumar Karwar
Hi Prasun, > -Original Message- > From: Prasun Maiti [mailto:prasunmait...@gmail.com] > Sent: Thursday, June 30, 2016 2:01 PM > To: Amitkumar Karwar > Cc: Nishant Sarmukadam; Linux Wireless; Linux Next; Linux Kernel; Kalle > Valo > Subject: [PATCH v2] mwifiex: Fix end

RE: [PATCH] mwifiex: Fixed endianness for event TLV type TLV_BTCOEX_WL_SCANTIME

2016-06-30 Thread Amitkumar Karwar
Hi Prasun, > From: Prasun Maiti [mailto:prasunmait...@gmail.com] > Sent: Friday, June 24, 2016 12:27 PM > To: Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo > Cc: Linux Wireless; Linux Next; Linux Kernel > Subject: Re: [PATCH] mwifiex: Fixed endianness for

RE: [PATCH v3] mwifiex: Reduce endian conversion for REG Host Commands

2016-06-27 Thread Amitkumar Karwar
Hi Prasun, > From: Prasun Maiti [mailto:prasunmait...@gmail.com] > Sent: Thursday, June 23, 2016 10:59 AM > To: Amitkumar Karwar > Cc: Nishant Sarmukadam; Linux Wireless; Linux Next; Linux Kernel; Kalle > Valo > Subject: [PATCH v3] mwifiex: Reduce endian conversion for R

RE: [v11,3/3] Bluetooth: hci_uart: Support firmware download for Marvell

2016-06-26 Thread Amitkumar Karwar
Hi Marcel, > From: Jeffy Chen [mailto:jeffy.c...@rock-chips.com] > Sent: Friday, June 24, 2016 11:32 AM > To: Amitkumar Karwar; linux-blueto...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; Ganapathi Bhat > Subject: Re: [v11,3/3] Bluetooth: hci_uart: Support firmware downloa

RE: [Query] mwifiex: few observations to reduce number of endian conversions

2016-06-21 Thread Amitkumar Karwar
Hi Prasun, > From: Prasun Maiti [mailto:prasunmait...@gmail.com] > Sent: Friday, June 17, 2016 6:42 PM > To: Amitkumar Karwar; Nishant Sarmukadam > Cc: Linux Kernel; Linux Next; WiFi Mailing List; Johannes Berg > Subject: [Query] mwifiex: few observations to reduce number of endia

RE: [PATCH v11 3/3] Bluetooth: hci_uart: Support firmware download for Marvell

2016-06-13 Thread Amitkumar Karwar
Hi Marcel, > From: Amitkumar Karwar > Sent: Monday, May 23, 2016 11:37 AM > To: 'linux-blueto...@vger.kernel.org' > Cc: 'linux-kernel@vger.kernel.org'; Ganapathi Bhat; Cathy Luo > Subject: RE: [PATCH v11 3/3] Bluetooth: hci_uart: Support firmware &g

RE: [PATCH v2 2/3] mwifiex: move .get_tx_power logic to station ioctl file

2016-06-10 Thread Amitkumar Karwar
Hi Kalle/Javier, > From: Javier Martinez Canillas [mailto:jav...@osg.samsung.com] > Sent: Friday, June 10, 2016 8:07 PM > To: Kalle Valo > Cc: linux-kernel@vger.kernel.org; Julian Calaby; Shengzhen Li; Enric > Balletbo i Serra; Amitkumar Karwar; net...@vger.kernel.org;

RE: [PATCH 7/8] mwifiex: don't print an error if an optional DT property is missing

2016-06-09 Thread Amitkumar Karwar
> From: Julian Calaby [mailto:julian.cal...@gmail.com] > Sent: Thursday, June 02, 2016 4:44 AM > To: Javier Martinez Canillas; Xinming Hu > Cc: linux-kernel@vger.kernel.org; Amitkumar Karwar; Kalle Valo; netdev; > linux-wireless; Nishant Sarmukadam > Subject: Re: [PATCH 7/8] mw

RE: [PATCH 0/8] mwifiex: Fix some error handling issues in mwifiex_sdio_probe() function

2016-06-09 Thread Amitkumar Karwar
> From: Javier Martinez Canillas [mailto:jav...@osg.samsung.com] > Sent: Friday, May 27, 2016 7:48 PM > To: linux-kernel@vger.kernel.org > Cc: Xinming Hu; Javier Martinez Canillas; Amitkumar Karwar; Kalle Valo; > net...@vger.kernel.org; linux-wirel...@vger.kernel.org; Nisha

RE: [PATCH v2] mwifiex: fix race condition when downloading firmware

2016-06-09 Thread Amitkumar Karwar
> From: Wei-Ning Huang [mailto:wnhu...@chromium.org] > Sent: Friday, May 27, 2016 5:58 PM > To: Linux-Wireless > Cc: LKML; Amitkumar Karwar; djku...@chromium.org; Wei-Ning Huang > Subject: [PATCH v2] mwifiex: fix race condition when downloading > firmware > > The actio

RE: [PATCH 1/1] mwifiex: illegal assignment

2016-06-09 Thread Amitkumar Karwar
> From: Heinrich Schuchardt [mailto:xypron.g...@gmx.de] > Sent: Wednesday, May 18, 2016 4:32 AM > To: Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo > Cc: Xinming Hu; Cathy Luo; linux-wirel...@vger.kernel.org; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; Heinri

RE: mwifiex: fix self-assignment in mwifiex_uap_recv_packet

2016-05-31 Thread Amitkumar Karwar
Hi Dave, > From: Dave Jones [mailto:da...@codemonkey.org.uk] > Sent: Tuesday, May 31, 2016 8:47 PM > To: Linux Kernel > Cc: Xinming Hu; Cathy Luo; Amitkumar Karwar; Kalle Valo > Subject: mwifiex: fix self-assignment in mwifiex_uap_recv_packet > > This function wants to o

RE: [PATCH v11 3/3] Bluetooth: hci_uart: Support firmware download for Marvell

2016-05-22 Thread Amitkumar Karwar
Hi Marcel, > > From: Amitkumar Karwar [mailto:akar...@marvell.com] > > Sent: Friday, May 06, 2016 9:02 PM > > To: linux-blueto...@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org; Ganapathi Bhat; Amitkumar Karwar > > Subject: [PATCH v11 3/3] Bluetooth: hci_uart:

RE: [PATCH v11 3/3] Bluetooth: hci_uart: Support firmware download for Marvell

2016-05-10 Thread Amitkumar Karwar
Hi Marcel, > From: Amitkumar Karwar [mailto:akar...@marvell.com] > Sent: Friday, May 06, 2016 9:02 PM > To: linux-blueto...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; Ganapathi Bhat; Amitkumar Karwar > Subject: [PATCH v11 3/3] Bluetooth: hci_uart: Support firmware downloa

[PATCH v11 3/3] Bluetooth: hci_uart: Support firmware download for Marvell

2016-05-06 Thread Amitkumar Karwar
From: Ganapathi Bhat This patch implement firmware download feature for Marvell Bluetooth devices. If firmware is already downloaded, it will skip downloading. Signed-off-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- v2: Fixed compilation warning reported by kbuild test robot v3

[PATCH v11 2/3] Bluetooth: hci_uart: check if hdev is present before using it

2016-05-06 Thread Amitkumar Karwar
From: Ganapathi Bhat The hdev struct might not have initialized in protocol receive handler. This patch adds necessary checks. Signed-off-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- drivers/bluetooth/hci_ldisc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH v11 1/3] Bluetooth: hci_uart: add prepare callbacks to hci_uart_proto structure.

2016-05-06 Thread Amitkumar Karwar
ff-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- drivers/bluetooth/hci_ldisc.c | 11 ++- drivers/bluetooth/hci_uart.h | 3 +++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c index 49b3e1e..b4ee682 1

RE: [PATCH v10 3/3] Bluetooth: hci_uart: Support firmware download for Marvell

2016-05-05 Thread Amitkumar Karwar
Hi Alan, > From: One Thousand Gnomes [mailto:gno...@lxorguk.ukuu.org.uk] > Sent: Thursday, May 05, 2016 8:53 PM > To: Amitkumar Karwar > Cc: linux-blueto...@vger.kernel.org; linux-kernel@vger.kernel.org; > Ganapathi Bhat > Subject: Re: [PATCH v10 3/3] Bluetooth: hci_uart

RE: [PATCH v10 1/3] Bluetooth: hci_uart: add prepare callbacks to hci_uart_proto structure.

2016-05-05 Thread Amitkumar Karwar
Hi Alan, > From: linux-bluetooth-ow...@vger.kernel.org [mailto:linux-bluetooth- > ow...@vger.kernel.org] On Behalf Of One Thousand Gnomes > Sent: Thursday, May 05, 2016 8:49 PM > To: Amitkumar Karwar > Cc: linux-blueto...@vger.kernel.org; linux-kernel@vger.kernel.org; > Ganapa

[PATCH v10 1/3] Bluetooth: hci_uart: add prepare callbacks to hci_uart_proto structure.

2016-05-05 Thread Amitkumar Karwar
ff-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- drivers/bluetooth/hci_ldisc.c | 11 ++- drivers/bluetooth/hci_uart.h | 3 +++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c index 49b3e1e..b4ee682 1

[PATCH v10 2/3] Bluetooth: hci_uart: check if hdev is present before using it

2016-05-05 Thread Amitkumar Karwar
From: Ganapathi Bhat The hdev struct might not have initialized in protocol receive handler. This patch adds necessary checks. Signed-off-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- drivers/bluetooth/hci_ldisc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH v10 3/3] Bluetooth: hci_uart: Support firmware download for Marvell

2016-05-05 Thread Amitkumar Karwar
From: Ganapathi Bhat This patch implement firmware download feature for Marvell Bluetooth devices. If firmware is already downloaded, it will skip downloading. Signed-off-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- v2: Fixed compilation warning reported by kbuild test robot v3

RE: [PATCH v9 3/3] Bluetooth: hci_uart: Support firmware download for Marvell

2016-05-04 Thread Amitkumar Karwar
Hi Marcel, Thanks for your comments. We are working to resolve them. > > + > > +/* Receive data */ > > +static int mrvl_recv(struct hci_uart *hu, const void *data, int > > +count) { > > + struct mrvl_data *mrvl = hu->priv; > > + > > + if (test_bit(HCI_UART_DNLD_FW, &mrvl->flags)) { > > +

[PATCH v9 3/3] Bluetooth: hci_uart: Support firmware download for Marvell

2016-04-29 Thread Amitkumar Karwar
From: Ganapathi Bhat This patch implement firmware download feature for Marvell Bluetooth devices. If firmware is already downloaded, it will skip downloading. Signed-off-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- v2: Fixed compilation warning reported by kbuild test robot v3

[PATCH v9 2/3] Bluetooth: hci_uart: check if hdev is present before using it

2016-04-29 Thread Amitkumar Karwar
From: Ganapathi Bhat The hdev struct might not have initialized in protocal receive handler. This patch adds necessary checks. Signed-off-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- drivers/bluetooth/hci_ldisc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH v9 1/3] Bluetooth: hci_uart: add prepare callback

2016-04-29 Thread Amitkumar Karwar
From: Ganapathi Bhat This new uart protocol callback is used to prepare the device before HCI becomes ready. One can use this to download firmware if the download process doesn't use HCI commands. Signed-off-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- drivers/bluetooth/hci_ld

RE: [PATCH v7 1/2] dt: bindings: add MARVELL's bt-sd8xxx wireless device

2016-04-26 Thread Amitkumar Karwar
Hi Rob, > From: Rob Herring [mailto:r...@kernel.org] > Sent: Thursday, April 21, 2016 8:06 PM > To: Amitkumar Karwar > Cc: linux-blueto...@vger.kernel.org; linux-kernel@vger.kernel.org; > devicet...@vger.kernel.org; Wei-Ning Huang; Xinming Hu > Subject: Re: [PATCH v7 1/2]

[PATCH v8 1/2] dt: bindings: add MARVELL's bt-sd8xxx wireless device

2016-04-26 Thread Amitkumar Karwar
From: Xinming Hu Add device tree binding documentation for MARVELL's bluetooth sdio (sd8897 and sd8997) chip. Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar --- Listing changelist for both 1/2 and 2/2 here v2: Fixed build error reported by kbuild test robot drivers/blue

[PATCH v8 2/2] btmrvl: add platform specific wakeup interrupt support

2016-04-26 Thread Amitkumar Karwar
, wakeup pin configured to firmware, and soc specific wake up gpio, which will be set as wakeup interrupt pin. Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar --- drivers/bluetooth/btmrvl_drv.h | 11 ++ drivers/bluetooth/btmrvl_main.c | 35 ++ drivers/bluetooth

RE: [PATCH v7] Bluetooth: hci_uart: Support firmware download for Marvell

2016-04-26 Thread Amitkumar Karwar
Hi Marcel, > From: Marcel Holtmann [mailto:mar...@holtmann.org] > Sent: Friday, April 22, 2016 6:19 PM > To: Amitkumar Karwar > Cc: Linux Bluetooth; LKML; Ganapathi Bhat; Cathy Luo > Subject: Re: [PATCH v7] Bluetooth: hci_uart: Support firmware download > for Marvell

RE: [PATCH v7] Bluetooth: hci_uart: Support firmware download for Marvell

2016-04-22 Thread Amitkumar Karwar
Hi Marcel, > From: Marcel Holtmann [mailto:mar...@holtmann.org] > Sent: Friday, April 22, 2016 6:19 PM > To: Amitkumar Karwar > Cc: Linux Bluetooth; LKML; Ganapathi Bhat; Cathy Luo > Subject: Re: [PATCH v7] Bluetooth: hci_uart: Support firmware download > for Marvell

[PATCH v8] Bluetooth: hci_uart: Support firmware download for Marvell

2016-04-22 Thread Amitkumar Karwar
From: Ganapathi Bhat This patch implement firmware download feature for Marvell Bluetooth devices. If firmware is already downloaded, it will skip downloading. Signed-off-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- v2: Fixed compilation warning reported by kbuild test robot v3

RE: [PATCH v7] Bluetooth: hci_uart: Support firmware download for Marvell

2016-04-22 Thread Amitkumar Karwar
Hi Marcel, > > > > + > > > +static int mrvl_setup(struct hci_uart *hu) { > > > + struct mrvl_data *mrvl = hu->priv; > > > + > > > + mrvl_init_fw_data(hu); > > > + set_bit(HCI_UART_DNLD_FW, &mrvl->flags); > > > + > > > + return hci_uart_dnld_fw(hu); > > > +} > > > > So this is clearly the wrong sp

RE: [PATCH v7] Bluetooth: hci_uart: Support firmware download for Marvell

2016-04-20 Thread Amitkumar Karwar
Hi Marcel, Thanks for your review. We will address these comments in updated version. > > + > > +/* Receive data */ > > +static int mrvl_recv(struct hci_uart *hu, const void *data, int > > +count) { > > + struct mrvl_data *mrvl = hu->priv; > > + > > + if (test_bit(HCI_UART_DNLD_FW, &mrvl->fla

[PATCH v7 1/2] dt: bindings: add MARVELL's bt-sd8xxx wireless device

2016-04-18 Thread Amitkumar Karwar
From: Xinming Hu Add device tree binding documentation for MARVELL's bluetooth sdio (sd8897 and sd8997) chip. Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar --- Listing changelist for both 1/2 and 2/2 here v2: Fixed build error reported by kbuild test robot drivers/blue

[PATCH v7 2/2] btmrvl: add platform specific wakeup interrupt support

2016-04-18 Thread Amitkumar Karwar
, wakeup pin configured to firmware, and soc specific wake up gpio, which will be set as wakeup interrupt pin. Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar --- drivers/bluetooth/btmrvl_drv.h | 11 ++ drivers/bluetooth/btmrvl_main.c | 35 ++ drivers/bluetooth

RE: [PATCH v6 2/2] btmrvl: add platform specific wakeup interrupt support

2016-04-10 Thread Amitkumar Karwar
Hi Marcel, > From: Marcel Holtmann [mailto:mar...@holtmann.org] > Sent: Friday, April 08, 2016 10:40 PM > To: Amitkumar Karwar > Cc: linux-blueto...@vger.kernel.org; Nishant Sarmukadam; > wnhu...@chromium.com; devicet...@vger.kernel.org; linux- > ker...@vger.kernel.org; Xinmin

[PATCH v7] Bluetooth: hci_uart: Support firmware download for Marvell

2016-04-05 Thread Amitkumar Karwar
From: Ganapathi Bhat This patch implement firmware download feature for Marvell Bluetooth devices. If firmware is already downloaded, it will skip downloading. Signed-off-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- v2: Fixed compilation warning reported by kbuild test robot v3

RE: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call

2016-04-04 Thread Amitkumar Karwar
Hi Eric, Thanks for the comments. > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Tuesday, March 29, 2016 6:29 PM > To: Wei-Ning Huang > Cc: Kalle Valo; Linux Wireless; LKML; Amitkumar Karwar; Nishant > Sarmukadam; Sameer Nanda; net...@vger.kernel.org; Sonny Rao; Dou

[PATCH v6] Bluetooth: hci_uart: Support firmware download for Marvell

2016-03-31 Thread Amitkumar Karwar
From: Ganapathi Bhat This patch implement firmware download feature for Marvell Bluetooth devices. If firmware is already downloaded, it will skip downloading. Signed-off-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- v2: Fixed compilation warning reported by kbuild test robot v3

RE: [PATCH] Bluetooth: hci_uart: Support firmware download for Marvell

2016-03-31 Thread Amitkumar Karwar
> From: Amitkumar Karwar [mailto:akar...@marvell.com] > Sent: Thursday, March 31, 2016 5:25 PM > To: linux-blueto...@vger.kernel.org > Cc: Cathy Luo; linux-kernel@vger.kernel.org; Nishant Sarmukadam; > Ganapathi Bhat; Amitkumar Karwar > Subject: [PATCH] Bluetooth: hci_uart

[PATCH] Bluetooth: hci_uart: Support firmware download for Marvell

2016-03-31 Thread Amitkumar Karwar
From: Ganapathi Bhat This patch implement firmware download feature for Marvell Bluetooth devices. If firmware is already downloaded, it will skip downloading. Signed-off-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- v2: Fixed compilation warning reported by kbuild test robot v3

[PATCH v6 2/2] btmrvl: add platform specific wakeup interrupt support

2016-03-30 Thread Amitkumar Karwar
, wakeup pin configured to firmware, and soc specific wakeup interrupt pin. Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar --- drivers/bluetooth/btmrvl_drv.h | 11 ++ drivers/bluetooth/btmrvl_main.c | 33 + drivers/bluetooth/btmrvl_sdio.c | 79

[PATCH v6 1/2] dt: bindings: add MARVELL's bt-sd8xxx wireless device

2016-03-30 Thread Amitkumar Karwar
From: Xinming Hu Add device tree binding documentation for MARVELL's bluetooth sdio (sd8897 and sd8997) chip. Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar --- Listing changelist for both 1/2 and 2/2 here v2: Fixed build error reported by kbuild test robot drivers/blue

RE: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call

2016-03-29 Thread Amitkumar Karwar
> From: Wei-Ning Huang [mailto:wnhu...@google.com] > Sent: Tuesday, March 29, 2016 2:57 PM > To: Kalle Valo > Cc: Linux Wireless; LKML; Amitkumar Karwar; Nishant Sarmukadam; Sameer > Nanda; net...@vger.kernel.org; Sonny Rao; Douglas Anderson > Subject: Re: [PATCH] mwifiex: add _

RE: [PATCH v2] mwifiex: advertise low priority scan feature

2016-03-24 Thread Amitkumar Karwar
> From: Wei-Ning Huang [mailto:wnhu...@chromium.org] > Sent: Tuesday, March 22, 2016 9:40 AM > To: Linux Wireless > Cc: LKML; Amitkumar Karwar; djku...@chromium.org; Wei-Ning Huang; > Nishant Sarmukadam; kv...@codeaurora.org; net...@vger.kernel.org > Subject: [PATCH v2] mwif

RE: [PATCH] mwifiex: advertise low priority scan feature

2016-03-21 Thread Amitkumar Karwar
> From: linux-wireless-ow...@vger.kernel.org [mailto:linux-wireless- > ow...@vger.kernel.org] On Behalf Of Wei-Ning Huang > Sent: Monday, March 21, 2016 1:37 PM > To: Linux Wireless > Cc: LKML; Amitkumar Karwar; djku...@chromium.org; Wei-Ning Huang; > Nishant Sarmukadam; kv...@c

[PATCH BlueZ v5] tools/btattach: add marvell support

2016-03-19 Thread Amitkumar Karwar
From: Ganapathi Bhat User needs to issue below command for Marvell devices btattach -P marvell -B /dev/ttyUSB# --- tools/btattach.c | 1 + tools/hciattach.h | 1 + 2 files changed, 2 insertions(+) diff --git a/tools/btattach.c b/tools/btattach.c index a025bb0..7807e9f 100644 --- a/tools/btatt

[PATCH v5] Bluetooth: hci_uart: Support firmware download for Marvell

2016-03-19 Thread Amitkumar Karwar
From: Ganapathi Bhat This patch implement firmware download feature for Marvell Bluetooth devices. If firmware is already downloaded, it will skip downloading. Signed-off-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- v2: Fixed compilation warning reported by kbuild test robot v3

RE: [PATCH v4] Bluetooth: hci_uart: Support firmware download for Marvell

2016-03-19 Thread Amitkumar Karwar
Hi Loic, > From: Loic Poulain [mailto:loic.poul...@intel.com] > Sent: Monday, March 14, 2016 9:25 PM > To: Amitkumar Karwar; linux-blueto...@vger.kernel.org > Cc: Cathy Luo; linux-kernel@vger.kernel.org; Nishant Sarmukadam; > Ganapathi Bhat > Subject: Re: [PATCH v4] Bluetooth:

[PATCH v5 2/2] btmrvl: add platform specific wakeup interrupt support

2016-03-19 Thread Amitkumar Karwar
, wakeup pin configured to firmware, and soc specific wakeup interrupt pin. Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar --- drivers/bluetooth/btmrvl_drv.h | 11 ++ drivers/bluetooth/btmrvl_main.c | 20 +-- drivers/bluetooth/btmrvl_sdio.c | 79

RE: [PATCH 2/2] btmrvl: add platform specific wakeup interrupt support

2016-03-19 Thread Amitkumar Karwar
> From: Amitkumar Karwar [mailto:akar...@marvell.com] > Sent: Friday, March 18, 2016 4:35 PM > To: linux-blueto...@vger.kernel.org > Cc: Cathy Luo; linux-kernel@vger.kernel.org; Nishant Sarmukadam; > devicet...@vger.kernel.org; Wei-Ning Huang; Xinming Hu; Amitkumar Karwar > S

[PATCH v5 1/2] dt: bindings: add MARVELL's bt-sd8xxx wireless device

2016-03-18 Thread Amitkumar Karwar
From: Xinming Hu Add device tree binding documentation for MARVELL's bluetooth sdio (sd8897 and sd8997) chip. Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar --- Listing changelist for both 1/2 and 2/2 here v2: Fixed build error reported by kbuild test robot drivers/blue

[PATCH 2/2] btmrvl: add platform specific wakeup interrupt support

2016-03-18 Thread Amitkumar Karwar
, wakeup pin configured to firmware, and soc specific wakeup interrupt pin. Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar --- drivers/bluetooth/btmrvl_drv.h | 11 ++ drivers/bluetooth/btmrvl_main.c | 20 +-- drivers/bluetooth/btmrvl_sdio.c | 79

RE: [PATCH v4] Bluetooth: hci_uart: Support firmware download for Marvell

2016-03-13 Thread Amitkumar Karwar
Hi Marcel, Do you have any comments for this patch? Please let us know if you have any more suggestions for the improvements. > From: Amitkumar Karwar [mailto:akar...@marvell.com] > Sent: Thursday, March 03, 2016 5:27 PM > To: linux-blueto...@vger.kernel.org > Cc: Cathy Luo;

[PATCH BlueZ v4] tools/btattach: add marvell support

2016-03-03 Thread Amitkumar Karwar
From: Ganapathi Bhat User needs to issue below command for Marvell devices btattach -P marvell -B /dev/ttyUSB# --- tools/btattach.c | 1 + tools/hciattach.h | 1 + 2 files changed, 2 insertions(+) diff --git a/tools/btattach.c b/tools/btattach.c index a025bb0..7807e9f 100644 --- a/tools/btatt

[PATCH v4] Bluetooth: hci_uart: Support firmware download for Marvell

2016-03-03 Thread Amitkumar Karwar
From: Ganapathi Bhat This patch implement firmware download feature for Marvell Bluetooth devices. If firmware is already downloaded, it will skip downloading. Signed-off-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- v2: Fixed compilation warning reported by kbuild test robot v3

RE: [PATCH v3] Bluetooth: hci_uart: Support firmware download for Marvell

2016-03-01 Thread Amitkumar Karwar
Hi Alan, > From: One Thousand Gnomes [mailto:gno...@lxorguk.ukuu.org.uk] > Sent: Wednesday, March 02, 2016 3:29 AM > To: Amitkumar Karwar > Cc: linux-blueto...@vger.kernel.org; Cathy Luo; linux- > ker...@vger.kernel.org; Nishant Sarmukadam; Ganapathi Bhat > Subject: Re: [P

[PATCH BlueZ v3] tools/btattach: add marvell support

2016-03-01 Thread Amitkumar Karwar
From: Ganapathi Bhat User needs to issue below command for Marvell devices btattach -P marvell -B /dev/ttyUSB# --- tools/btattach.c | 1 + tools/hciattach.h | 1 + 2 files changed, 2 insertions(+) diff --git a/tools/btattach.c b/tools/btattach.c index a025bb0..7807e9f 100644 --- a/tools/btatt

[PATCH BlueZ v3] tools/btattach: add marvell support

2016-03-01 Thread Amitkumar Karwar
From: Ganapathi Bhat User needs to issue below command for Marvell devices btattach -P marvell -B /dev/ttyUSB# --- tools/btattach.c | 1 + tools/hciattach.h | 1 + 2 files changed, 2 insertions(+) diff --git a/tools/btattach.c b/tools/btattach.c index a025bb0..7807e9f 100644 --- a/tools/btatt

[PATCH v3] Bluetooth: hci_uart: Support firmware download for Marvell

2016-03-01 Thread Amitkumar Karwar
From: Ganapathi Bhat This patch implement firmware download feature for Marvell Bluetooth devices. If firmware is already downloaded, it will skip downloading. Signed-off-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- v2: Fixed compilation warning reported by kbuild test robot v3

RE: [PATCH v2] Bluetooth: hci_uart: Support firmware download for Marvell

2016-03-01 Thread Amitkumar Karwar
Hi Marcel, > > + > > + kfree(skb); > > + BT_INFO("leave dnld_fw\n"); > > + > > + return ret; > > +} > > I think it would help if you explain on how the firmware download for > your UART devices work. I have the feeling we need a bit better core > handling in this case and not end up hacking

RE: [PATCH v4 1/3] mwifiex: register platform specific driver

2016-02-29 Thread Amitkumar Karwar
Hi Rob, > From: Rob Herring [mailto:r...@kernel.org] > Sent: Thursday, February 18, 2016 8:08 PM > To: Amitkumar Karwar > Cc: linux-blueto...@vger.kernel.org; Nishant Sarmukadam; > wnhu...@chromium.com; devicet...@vger.kernel.org; Cathy Luo; linux- > ker...@vger.kernel.org; Xi

RE: [PATCH v2] Bluetooth: hci_uart: Support firmware download for Marvell

2016-02-25 Thread Amitkumar Karwar
Hi Marcel, > From: Marcel Holtmann [mailto:mar...@holtmann.org] > Sent: Saturday, February 20, 2016 1:37 PM > To: Amitkumar Karwar > Cc: BlueZ development; Nishant Sarmukadam; linux-kernel@vger.kernel.org; > Cathy Luo; Ganapathi Bhat > Subject: Re: [PATCH v2] Bluetooth: hci_uart

[PATCH v2] Bluetooth: hci_uart: Support firmware download for Marvell

2016-02-16 Thread Amitkumar Karwar
From: Ganapathi Bhat This patch implement firmware download feature for Marvell Bluetooth devices. If firmware is already downloaded, it will skip downloading. Signed-off-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- v2: Fixed compilation warning reported by kbuild test robot

[PATCH BlueZ] tools/btattach: add marvell support

2016-02-16 Thread Amitkumar Karwar
From: Ganapathi Bhat User needs to issue below command for Marvell devices btattach -P marvell -B /dev/ttyUSB# Signed-off-by: Ganapathi Bhat Signed-off-by: Amitkumar Karwar --- tools/btattach.c | 1 + tools/hciattach.h | 1 + 2 files changed, 2 insertions(+) diff --git a/tools/btattach.c b

RE: [PATCH v3 1/2] bluetooth: btmrvl: register platform specific driver

2016-02-16 Thread Amitkumar Karwar
Hi Rob, > From: Rob Herring [mailto:r...@kernel.org] > Sent: Tuesday, February 09, 2016 3:35 AM > To: Amitkumar Karwar > Cc: linux-blueto...@vger.kernel.org; Nishant Sarmukadam; > wnhu...@chromium.com; devicet...@vger.kernel.org; linux- > ker...@vger.kernel.org; Xinming Hu >

[PATCH v4 1/2] bluetooth: btmrvl: register platform specific driver

2016-02-16 Thread Amitkumar Karwar
From: Xinming Hu Platform device and driver provide easy way to interact with device-tree-enabled system. This patch registers platform driver and reorganise existing device tree specific code. Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar --- v3: Add NULL check for

[PATCH v4 2/2] bluetooth: btmrvl: parse host wakeup configuration from device tree

2016-02-16 Thread Amitkumar Karwar
-by: Amitkumar Karwar --- v2: Fixed build error reported by kbuild test robot drivers/bluetooth/btmrvl_platform.c:141:22: error: 'btmrvl_plt_pm_ops' undeclared here (not in a function) --- .../devicetree/bindings/net/marvell-bt-sd8xxx.txt | 17 +++- drivers/bluetooth/btmrvl_

[PATCH v4 3/3] mwifiex: parse host wakeup configuration from device

2016-02-16 Thread Amitkumar Karwar
-off-by: Amitkumar Karwar --- v4: Replaced #ifdef with __maybe_unused(Arnd Bergmann) --- .../bindings/net/wireless/marvell-sd8xxx.txt | 10 +++ .../net/wireless/marvell/mwifiex/platform_drv.c| 91 ++ 2 files changed, 101 insertions(+) diff --git a/Documentation

[PATCH v4 2/3] mwifiex: parse chip specific gpio from device tree

2016-02-16 Thread Amitkumar Karwar
From: Xinming Hu This patch parse chip specific gpio parameter from device tree. Corresponding binding file is also updated. Signed-off-by: Xinming Hu Signed-off-by: Amitkumar Karwar --- v4: Renamed "mwifiex,chip-gpio" to "marvell,wakeup-gpios"(Rob Herrin

[PATCH v4 1/3] mwifiex: register platform specific driver

2016-02-16 Thread Amitkumar Karwar
: Amitkumar Karwar --- v3: Don't update adapter->dt_node if mwifiex_plt_dev is NULL v4: Corrected the 'name' and 'compatible' property names.(Arnd Bergmann and Rob Herring) Patch description wraped in 72 columns(Rob Herring) Moved DT binding file to bindin

  1   2   >